headroom/tests/test_netcost_gate.py

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

475 lines
23 KiB
Python
Raw Permalink Normal View History

feat(policy): consume net-cost mutation gate in ContentRouter (#856 P2) (#905) ## Description Fixes #907. Part of #904 — the **P2 (consume, flag-gated)** item from #856's phased plan. (#903, which this was stacked on, has merged; this is now a clean diff.) `HEADROOM_NET_COST_POLICY=1` (default **off** — flag absent restores byte-identical current behavior) routes every ContentRouter mutation candidate through `CompressionPolicy.net_mutation_gain` before compression is applied, at both decision sites: the result-cache-hit path and the fresh-compression merge (pass 3). v1 estimators (as specced in #856): **ΔT** exact (compressed form already computed); **S** = token total after the slot, precomputed once as a reverse cumulative sum (O(1) per candidate); **R / P_alive** env-tunable (`HEADROOM_NET_COST_EXPECTED_READS`=10, `HEADROOM_NET_COST_P_ALIVE`=1.0). Every decision logs all inputs at INFO and increments `netcost_allowed`/`netcost_skipped` counters so the flag can be validated from telemetry before any default-on. Closes #907. ## Type of Change - [x] New feature (non-breaking change which adds functionality) ## Changes Made - Add flag-gated net-cost mutation gate to `ContentRouter` at both mutation sites (cache-hit + fresh-compress merge). - Precompute reverse-cumulative suffix token sums once per request for O(1) S lookups. - Emit INFO telemetry, `netcost_allowed`/`netcost_skipped` counters, and a `netcost:skip:<band>` transform marker on blocked slots. - **Review-response (4eb2307):** reject non-finite env values (`math.isfinite` guard), count suffix tokens block-aware via `_netcost_message_tokens()` (was `str(content)`, which miscounted Anthropic block lists), and bucket the skip marker via `_gain_bucket()` to bound dashboard cardinality. ## Testing - [x] Unit tests pass (`pytest`) - [x] Linting passes (`ruff check .`) - [x] New tests added for new functionality - [x] New and existing unit tests pass locally with my changes ### Test Output ```text $ pytest tests/test_netcost_gate.py -q 11 passed in 0.82s $ pytest tests/ -k "content_router or netcost or router" -q 133 passed, 8 skipped, 6120 deselected in 23.26s $ ruff check headroom/transforms/content_router.py All checks passed! ``` ## Real Behavior Proof - Environment: local macOS, repo .venv, Python 3.11.9, gpt-4o tokenizer fixture - Exact command / steps: `pytest tests/test_netcost_gate.py -q` then the router-suite selector above; gate exercised end-to-end through the real tokenizer + compression path (flag on via monkeypatch) - Observed result: with R=10/P=1 defaults, a 300-row tool result followed by a 40k-word suffix is left uncompressed (gate skips, `netcost:skip:` marker emitted); a 2000-row result with a 5-word suffix compresses (gate allows). Non-finite env (`inf`/`nan`) falls back to defaults and still skips. - Not tested: live proxy traffic / real dashboard validation — deferred to the default-on milestone per #904 (this ships default-off precisely to gather that telemetry first). ## Review Readiness - [x] I have performed a self-review - [x] This PR is ready for human review ## Additional Notes Cache-hit re-tokenization (`:2312`) and the large integration fixtures are tracked as follow-ups in the PR review thread; both are intentional given the flag is default-off. Known v1 limitations (whole-suffix S, no batch awareness, static P_alive) are tracked in #904 as P2b/P3a/P3b. PR body updated to satisfy the new PR-governance template gate (#914-era governance workflow). --------- Co-authored-by: integration-check <integration@local>
2026-06-13 17:46:26 +02:00
"""Net-cost mutation gate in ContentRouter (#856 P2, flag-gated).
``HEADROOM_NET_COST_POLICY=1`` routes every router mutation candidate
through ``CompressionPolicy.net_mutation_gain`` with the issue's v1
estimators (exact ΔT, S = token total after the slot, env-tunable R and
P_alive). Flag off (default) preserves exact current behavior.
"""
from __future__ import annotations
import json
import pytest
from headroom import OpenAIProvider, Tokenizer
from headroom.transforms.content_router import ContentRouter, ContentRouterConfig
_provider = OpenAIProvider()
@pytest.fixture
def tokenizer() -> Tokenizer:
return Tokenizer(_provider.get_token_counter("gpt-4o"), "gpt-4o")
@pytest.fixture
def router() -> ContentRouter:
return ContentRouter(ContentRouterConfig())
def _tool_json(rows: int) -> str:
return json.dumps(
[{"id": i, "name": f"item_{i}", "status": "ok", "score": i * 3.14} for i in range(rows)]
)
def _messages(tool_content: str, suffix_filler_words: int) -> list[dict]:
suffix = "analysis context word " * suffix_filler_words
return [
{"role": "user", "content": "fetch the records"},
{"role": "tool", "content": tool_content},
{"role": "user", "content": suffix},
{"role": "user", "content": "summarize"},
]
def _tool_slot_compressed(result, messages) -> bool:
return result.messages[1]["content"] != messages[1]["content"]
class TestNetCostGate:
def test_flag_off_compresses_as_before(self, router, tokenizer, monkeypatch):
monkeypatch.delenv("HEADROOM_NET_COST_POLICY", raising=False)
messages = _messages(_tool_json(300), suffix_filler_words=4000)
result = router.apply([dict(m) for m in messages], tokenizer)
assert _tool_slot_compressed(result, messages)
assert not any(t.startswith("netcost:") for t in result.transforms_applied)
def test_flag_on_blocks_when_suffix_dominates(self, router, tokenizer, monkeypatch):
# Big suffix after a modest shave: corrected formula says the cache
# invalidation outweighs the saving -> slot left untouched.
monkeypatch.setenv("HEADROOM_NET_COST_POLICY", "1")
messages = _messages(_tool_json(300), suffix_filler_words=40000)
result = router.apply([dict(m) for m in messages], tokenizer)
assert not _tool_slot_compressed(result, messages)
assert any(t.startswith("netcost:skip:") for t in result.transforms_applied)
def test_flag_on_allows_when_shave_dominates(self, router, tokenizer, monkeypatch):
# Tiny suffix after a huge shave -> gate allows, compression applies.
monkeypatch.setenv("HEADROOM_NET_COST_POLICY", "1")
messages = _messages(_tool_json(2000), suffix_filler_words=5)
result = router.apply([dict(m) for m in messages], tokenizer)
assert _tool_slot_compressed(result, messages)
assert not any(t.startswith("netcost:skip:") for t in result.transforms_applied)
fix(policy): price net-cost mutations with the 1h cache-write tier (#2780) ## Description This fixes the net-cost mutation gate for requests using Anthropic's 1-hour prompt-cache TTL. The gate previously hardcoded the 5-minute cache-write multiplier of 1.25x. A 1-hour cache write costs 2.0x, so the old calculation understated the true write penalty and could incorrectly recommend mutation for 1-hour clients. Closes #2773 ## Type of Change - [x] Bug fix (non-breaking change that fixes an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Performance improvement - [ ] Code refactoring (no functional changes) ## Changes Made - Added TTL-aware cache-write multiplier selection for 5-minute and 1-hour tiers. - Threaded the resolved TTL through the content router and compression policy helpers. - Preserved the existing 5-minute behavior as the default. - Added Python and Rust regression coverage for the 1-hour tier. - Retuned the netcost gate fixtures so the 1-hour write tier flips the decision in the full ContentRouter path. - Did not edit CHANGELOG.md. ## Testing - [x] Unit tests pass (pytest) - [x] Linting passes (ruff check .) - [ ] Type checking passes (mypy headroom) - [x] New tests added for new functionality - [ ] Manual testing performed ### Test Output ```text pytest tests/test_compression_policy.py -q 20 passed cargo test -p headroom-core --lib compression_policy -- --nocapture 14 passed pytest tests/test_netcost_gate.py -q 27 passed Ruff checks and formatting passed. git diff --check passed. ``` ## Real Behavior Proof - Environment: Linux x86_64 contributor checkout with Python and Rust test environments. - Exact command / steps: - Ran the Python compression policy test suite. - Ran the Rust compression policy unit tests. - Ran the netcost gate suite, including the 1-hour env and request-marker cases. - Exercised the new 1-hour TTL golden case alongside the existing 5-minute cases. - Observed result: The 1-hour case uses the 2.0x write multiplier and skips the same candidate that still mutates under 5-minute pricing. Existing 5-minute behavior remains covered and passing. - Not tested: A live Anthropic request through the proxy and production traffic. ## Review Readiness - [x] I have performed a self-review - [x] This PR is ready for human review ## Checklist - [x] My code follows the project's style guidelines - [x] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] I did **not** edit CHANGELOG.md - it is generated by release-please from my Conventional Commit PR title (a CI guard enforces this) ## Screenshots (if applicable) Not applicable for this backend policy fix. ## Additional Notes Ready for review. CI is green on the current tip.
2026-08-17 05:09:50 +07:00
def test_one_hour_ttl_prices_write_tier(self, router, tokenizer, monkeypatch):
# 5-minute pricing still admits this shave, while the larger 1h
# cache-write multiplier must turn the same candidate into a skip.
monkeypatch.setenv("HEADROOM_NET_COST_POLICY", "1")
messages = _messages(_tool_json(300), suffix_filler_words=1000)
monkeypatch.delenv("HEADROOM_NET_COST_CACHE_TTL_SECONDS", raising=False)
five_minute = router.apply([dict(m) for m in messages], tokenizer)
assert _tool_slot_compressed(five_minute, messages)
monkeypatch.setenv("HEADROOM_NET_COST_CACHE_TTL_SECONDS", "3600")
one_hour = router.apply([dict(m) for m in messages], tokenizer)
assert not _tool_slot_compressed(one_hour, messages)
assert any(t.startswith("netcost:skip:") for t in one_hour.transforms_applied)
def test_request_one_hour_marker_overrides_env_fallback(self, router, tokenizer, monkeypatch):
monkeypatch.setenv("HEADROOM_NET_COST_POLICY", "1")
monkeypatch.delenv("HEADROOM_NET_COST_CACHE_TTL_SECONDS", raising=False)
for name in (
"DISABLE_PROMPT_CACHING",
"DISABLE_PROMPT_CACHING_SONNET",
"ENABLE_PROMPT_CACHING_1H",
"FORCE_PROMPT_CACHING_5M",
):
monkeypatch.delenv(name, raising=False)
messages = _messages(_tool_json(300), suffix_filler_words=1000)
messages[0] = {
"role": "user",
"content": [
{
"type": "text",
"text": "fetch the records",
"cache_control": {"type": "ephemeral", "ttl": "1h"},
}
],
}
from headroom.transforms.cold_prefix import anthropic_cache_ttl_seconds
request_ttl = anthropic_cache_ttl_seconds("claude-sonnet-4-6", messages)
assert request_ttl == 3600
five_minute = router.apply([dict(m) for m in messages], tokenizer)
assert _tool_slot_compressed(five_minute, messages)
one_hour = router.apply(
[dict(m) for m in messages],
tokenizer,
cache_ttl_seconds=request_ttl,
)
assert not _tool_slot_compressed(one_hour, messages)
assert any(t.startswith("netcost:skip:") for t in one_hour.transforms_applied)
feat(policy): consume net-cost mutation gate in ContentRouter (#856 P2) (#905) ## Description Fixes #907. Part of #904 — the **P2 (consume, flag-gated)** item from #856's phased plan. (#903, which this was stacked on, has merged; this is now a clean diff.) `HEADROOM_NET_COST_POLICY=1` (default **off** — flag absent restores byte-identical current behavior) routes every ContentRouter mutation candidate through `CompressionPolicy.net_mutation_gain` before compression is applied, at both decision sites: the result-cache-hit path and the fresh-compression merge (pass 3). v1 estimators (as specced in #856): **ΔT** exact (compressed form already computed); **S** = token total after the slot, precomputed once as a reverse cumulative sum (O(1) per candidate); **R / P_alive** env-tunable (`HEADROOM_NET_COST_EXPECTED_READS`=10, `HEADROOM_NET_COST_P_ALIVE`=1.0). Every decision logs all inputs at INFO and increments `netcost_allowed`/`netcost_skipped` counters so the flag can be validated from telemetry before any default-on. Closes #907. ## Type of Change - [x] New feature (non-breaking change which adds functionality) ## Changes Made - Add flag-gated net-cost mutation gate to `ContentRouter` at both mutation sites (cache-hit + fresh-compress merge). - Precompute reverse-cumulative suffix token sums once per request for O(1) S lookups. - Emit INFO telemetry, `netcost_allowed`/`netcost_skipped` counters, and a `netcost:skip:<band>` transform marker on blocked slots. - **Review-response (4eb2307):** reject non-finite env values (`math.isfinite` guard), count suffix tokens block-aware via `_netcost_message_tokens()` (was `str(content)`, which miscounted Anthropic block lists), and bucket the skip marker via `_gain_bucket()` to bound dashboard cardinality. ## Testing - [x] Unit tests pass (`pytest`) - [x] Linting passes (`ruff check .`) - [x] New tests added for new functionality - [x] New and existing unit tests pass locally with my changes ### Test Output ```text $ pytest tests/test_netcost_gate.py -q 11 passed in 0.82s $ pytest tests/ -k "content_router or netcost or router" -q 133 passed, 8 skipped, 6120 deselected in 23.26s $ ruff check headroom/transforms/content_router.py All checks passed! ``` ## Real Behavior Proof - Environment: local macOS, repo .venv, Python 3.11.9, gpt-4o tokenizer fixture - Exact command / steps: `pytest tests/test_netcost_gate.py -q` then the router-suite selector above; gate exercised end-to-end through the real tokenizer + compression path (flag on via monkeypatch) - Observed result: with R=10/P=1 defaults, a 300-row tool result followed by a 40k-word suffix is left uncompressed (gate skips, `netcost:skip:` marker emitted); a 2000-row result with a 5-word suffix compresses (gate allows). Non-finite env (`inf`/`nan`) falls back to defaults and still skips. - Not tested: live proxy traffic / real dashboard validation — deferred to the default-on milestone per #904 (this ships default-off precisely to gather that telemetry first). ## Review Readiness - [x] I have performed a self-review - [x] This PR is ready for human review ## Additional Notes Cache-hit re-tokenization (`:2312`) and the large integration fixtures are tracked as follow-ups in the PR review thread; both are intentional given the flag is default-off. Known v1 limitations (whole-suffix S, no batch awareness, static P_alive) are tracked in #904 as P2b/P3a/P3b. PR body updated to satisfy the new PR-governance template gate (#914-era governance workflow). --------- Co-authored-by: integration-check <integration@local>
2026-06-13 17:46:26 +02:00
def test_flag_on_gates_cached_results_too(self, router, tokenizer, monkeypatch):
# First apply warms the result cache with the flag off; second apply
# with the flag on must still gate the cache-hit path.
messages = _messages(_tool_json(300), suffix_filler_words=40000)
monkeypatch.delenv("HEADROOM_NET_COST_POLICY", raising=False)
warm = router.apply([dict(m) for m in messages], tokenizer)
assert _tool_slot_compressed(warm, messages)
monkeypatch.setenv("HEADROOM_NET_COST_POLICY", "1")
gated = router.apply([dict(m) for m in messages], tokenizer)
assert not _tool_slot_compressed(gated, messages)
assert any(t.startswith("netcost:skip:") for t in gated.transforms_applied)
def test_malformed_env_falls_back_to_defaults(self, router, tokenizer, monkeypatch):
monkeypatch.setenv("HEADROOM_NET_COST_POLICY", "1")
monkeypatch.setenv("HEADROOM_NET_COST_EXPECTED_READS", "lots")
monkeypatch.setenv("HEADROOM_NET_COST_P_ALIVE", "warm")
messages = _messages(_tool_json(300), suffix_filler_words=40000)
# Must not raise; defaults (R=10, P=1) still block this scenario.
result = router.apply([dict(m) for m in messages], tokenizer)
assert not _tool_slot_compressed(result, messages)
def test_p_alive_zero_disables_penalty(self, router, tokenizer, monkeypatch):
# Cold cache (P_alive=0): no suffix penalty, mutation always wins.
monkeypatch.setenv("HEADROOM_NET_COST_POLICY", "1")
monkeypatch.setenv("HEADROOM_NET_COST_P_ALIVE", "0")
messages = _messages(_tool_json(300), suffix_filler_words=40000)
result = router.apply([dict(m) for m in messages], tokenizer)
assert _tool_slot_compressed(result, messages)
def test_nonfinite_env_falls_back_to_defaults(self, router, tokenizer, monkeypatch):
# ``float("inf")``/``float("nan")`` parse without ValueError; the gate
# must reject them and fall back to defaults so telemetry isn't
# poisoned. With R=10/P=1 defaults this scenario still skips.
monkeypatch.setenv("HEADROOM_NET_COST_POLICY", "1")
monkeypatch.setenv("HEADROOM_NET_COST_EXPECTED_READS", "inf")
monkeypatch.setenv("HEADROOM_NET_COST_P_ALIVE", "nan")
messages = _messages(_tool_json(300), suffix_filler_words=40000)
result = router.apply([dict(m) for m in messages], tokenizer)
assert not _tool_slot_compressed(result, messages)
# Marker must be a bounded band, never a raw float / "nan".
skip_markers = [t for t in result.transforms_applied if t.startswith("netcost:skip:")]
assert skip_markers
assert all(m.split(":")[-1] in _GAIN_BANDS for m in skip_markers)
_GAIN_BANDS = {
"0",
"lt100",
"lt1k",
"lt10k",
"gte10k",
"neg_lt100",
"neg_lt1k",
"neg_lt10k",
"neg_gte10k",
"nan",
}
class TestNetCostHelpers:
def test_gain_bucket_bands_and_sign(self):
from headroom.transforms.content_router import _gain_bucket
assert _gain_bucket(0) == "0"
assert _gain_bucket(50) == "lt100"
assert _gain_bucket(500) == "lt1k"
assert _gain_bucket(5000) == "lt10k"
assert _gain_bucket(50000) == "gte10k"
assert _gain_bucket(-50) == "neg_lt100"
assert _gain_bucket(-50000) == "neg_gte10k"
assert _gain_bucket(float("nan")) == "nan"
assert _gain_bucket(float("inf")) == "nan"
def test_message_tokens_block_list_beats_repr(self, tokenizer):
fix(router): stop counting an image's base64 payload as suffix tokens (#2778) ## Description `_netcost_message_tokens` walked block-list content itself and fell back to `str(block)` for anything that wasn't `text` or `tool_result` — on the stated assumption that such blocks *"rarely dominate a suffix"*. An `image` block is the exception that breaks it: `str()` embeds the whole base64 payload. ```text counted real over 512x512 PNG 20,034 349 57x 1092x1092 screenshot 100,034 1,589 63x 1568x1568 233,367 1,600 146x ``` **Why this changes behaviour, not just a number.** S is the cache-bust cost — the tokens re-written if message *j* is mutated. `apply()` builds it as a running suffix sum: ```python for j in range(num_messages - 1, -1, -1): netcost_suffix_tokens[j] = netcost_suffix_tokens[j + 1] + _netcost_message_tokens(...) ``` So one image inflates S for **every message before it**, and the break-even gate then declines to compress any of them. A single screenshot could switch off net-cost-gated compression for the whole earlier conversation — and screenshots are routine in agent sessions. ## Type of Change - [x] Bug fix (non-breaking change that fixes an issue) ## Changes Made Delegate block-list content to `tokenizers.base.count_content_blocks`, deleting the local walk. That counter already guards exactly this case — its comment reads *"1MB image = ~330K fake tokens without this"* — so this walk simply predated it. Beyond the raw fix, this removes a **second pricing rule**: the gate now values images the same way the tokenizer that computes `tokens_before`/`tokens_after` does (a flat 1600, "max after auto-resize"). Pricing images one way for the gate and another for the savings math is the same class of problem as #2761. Verified byte-identical on the shapes the old walk handled correctly: ```text old walk canonical text only 101 101 tool_result str 81 81 tool_result list 61 61 image only 100,034 1,600 mixed 100,036 1,602 ``` ## Testing - [x] Unit tests pass (`pytest`) - [x] Linting passes (`ruff check` + `ruff format`) - [x] Type checking passes (`mypy`) - [x] New tests added for new functionality ### Test Output ```text $ pytest tests/test_netcost_suffix_image_tokens.py -q 8 passed $ git stash push headroom/ && pytest tests/test_netcost_suffix_image_tokens.py -q 4 failed, 4 passed # the 4 failures are the payload-scaling assertions; the 4 passes are the # text/tool_result/string shapes, included to prove delegation is behaviour-preserving ``` All netcost + content-router suites: ```text $ pytest tests/test_netcost_gate.py tests/test_content_router_*.py \ tests/test_transforms_content_router.py tests/test_netcost_suffix_image_tokens.py -q 126 passed ``` ```text $ ruff check headroom/transforms/content_router.py tests/... All checks passed! $ mypy headroom/transforms/content_router.py no new errors ``` Deferring the full suite to CI — no maturin/Rust core in this environment. ## One existing test rewritten — please look at this bit `test_netcost_gate.py::TestNetCostHelpers::test_message_tokens_block_list_beats_repr` fails under the fix, and I want to be explicit that I changed a test rather than bury it. It built its image block as `{"type": "image", "source": {"data": "x" * 500}}`. A 500-char stub is **cheaper than a single image's real token cost**, so `str()` over it looked harmless (~130 tokens) and its assertion `abs(helper - text_only) < text_only * 0.5` held. That unrepresentative fixture is precisely why the payload-scaling bug survived — the test named "beats repr" was passing on the one payload size where repr happens not to be catastrophic. Rewritten to use a realistic 200KB payload and to assert what actually matters: ```python assert helper >= text_only # text still counted in full assert helper - text_only <= 2000 # image cost is bounded, not payload-scaled assert helper < count_text(str(content)) / 10 # ...and far below repr ``` I checked this both ways, so it is a real test and not a rubber stamp: ```text old test + fixed code -> FAILS (it was pinning the defect) new test + main -> FAILS (it catches the real bug) new test + fixed code -> passes ``` ## Known limitation The canonical estimate is a flat 1600 per image regardless of dimensions, so a small icon is now over-charged (~1600 vs ~13 real) where repr would have charged ~200. I kept the flat constant deliberately: it is the value every other counter in the codebase uses, and introducing a third rule here to shave small-icon cost would recreate the inconsistency this PR removes. The error is bounded at 1600 tokens and biases the gate conservative, versus an unbounded 100K+ error before.
2026-08-04 11:31:52 -07:00
# str(content) over a block list embeds the whole base64 payload; the
# block-aware helper prices the image at its pixel cost instead.
#
# This used to use a 500-char stub image, which is *smaller* than a
# single image's real token cost -- so repr looked cheap and the
# payload-scaling bug stayed invisible. Use a realistically sized
# payload, which is what actually occurs (screenshots).
feat(policy): consume net-cost mutation gate in ContentRouter (#856 P2) (#905) ## Description Fixes #907. Part of #904 — the **P2 (consume, flag-gated)** item from #856's phased plan. (#903, which this was stacked on, has merged; this is now a clean diff.) `HEADROOM_NET_COST_POLICY=1` (default **off** — flag absent restores byte-identical current behavior) routes every ContentRouter mutation candidate through `CompressionPolicy.net_mutation_gain` before compression is applied, at both decision sites: the result-cache-hit path and the fresh-compression merge (pass 3). v1 estimators (as specced in #856): **ΔT** exact (compressed form already computed); **S** = token total after the slot, precomputed once as a reverse cumulative sum (O(1) per candidate); **R / P_alive** env-tunable (`HEADROOM_NET_COST_EXPECTED_READS`=10, `HEADROOM_NET_COST_P_ALIVE`=1.0). Every decision logs all inputs at INFO and increments `netcost_allowed`/`netcost_skipped` counters so the flag can be validated from telemetry before any default-on. Closes #907. ## Type of Change - [x] New feature (non-breaking change which adds functionality) ## Changes Made - Add flag-gated net-cost mutation gate to `ContentRouter` at both mutation sites (cache-hit + fresh-compress merge). - Precompute reverse-cumulative suffix token sums once per request for O(1) S lookups. - Emit INFO telemetry, `netcost_allowed`/`netcost_skipped` counters, and a `netcost:skip:<band>` transform marker on blocked slots. - **Review-response (4eb2307):** reject non-finite env values (`math.isfinite` guard), count suffix tokens block-aware via `_netcost_message_tokens()` (was `str(content)`, which miscounted Anthropic block lists), and bucket the skip marker via `_gain_bucket()` to bound dashboard cardinality. ## Testing - [x] Unit tests pass (`pytest`) - [x] Linting passes (`ruff check .`) - [x] New tests added for new functionality - [x] New and existing unit tests pass locally with my changes ### Test Output ```text $ pytest tests/test_netcost_gate.py -q 11 passed in 0.82s $ pytest tests/ -k "content_router or netcost or router" -q 133 passed, 8 skipped, 6120 deselected in 23.26s $ ruff check headroom/transforms/content_router.py All checks passed! ``` ## Real Behavior Proof - Environment: local macOS, repo .venv, Python 3.11.9, gpt-4o tokenizer fixture - Exact command / steps: `pytest tests/test_netcost_gate.py -q` then the router-suite selector above; gate exercised end-to-end through the real tokenizer + compression path (flag on via monkeypatch) - Observed result: with R=10/P=1 defaults, a 300-row tool result followed by a 40k-word suffix is left uncompressed (gate skips, `netcost:skip:` marker emitted); a 2000-row result with a 5-word suffix compresses (gate allows). Non-finite env (`inf`/`nan`) falls back to defaults and still skips. - Not tested: live proxy traffic / real dashboard validation — deferred to the default-on milestone per #904 (this ships default-off precisely to gather that telemetry first). ## Review Readiness - [x] I have performed a self-review - [x] This PR is ready for human review ## Additional Notes Cache-hit re-tokenization (`:2312`) and the large integration fixtures are tracked as follow-ups in the PR review thread; both are intentional given the flag is default-off. Known v1 limitations (whole-suffix S, no batch awareness, static P_alive) are tracked in #904 as P2b/P3a/P3b. PR body updated to satisfy the new PR-governance template gate (#914-era governance workflow). --------- Co-authored-by: integration-check <integration@local>
2026-06-13 17:46:26 +02:00
from headroom.transforms.content_router import _netcost_message_tokens
text = "word " * 200
block_msg = {
"role": "user",
"content": [
{"type": "text", "text": text},
fix(router): stop counting an image's base64 payload as suffix tokens (#2778) ## Description `_netcost_message_tokens` walked block-list content itself and fell back to `str(block)` for anything that wasn't `text` or `tool_result` — on the stated assumption that such blocks *"rarely dominate a suffix"*. An `image` block is the exception that breaks it: `str()` embeds the whole base64 payload. ```text counted real over 512x512 PNG 20,034 349 57x 1092x1092 screenshot 100,034 1,589 63x 1568x1568 233,367 1,600 146x ``` **Why this changes behaviour, not just a number.** S is the cache-bust cost — the tokens re-written if message *j* is mutated. `apply()` builds it as a running suffix sum: ```python for j in range(num_messages - 1, -1, -1): netcost_suffix_tokens[j] = netcost_suffix_tokens[j + 1] + _netcost_message_tokens(...) ``` So one image inflates S for **every message before it**, and the break-even gate then declines to compress any of them. A single screenshot could switch off net-cost-gated compression for the whole earlier conversation — and screenshots are routine in agent sessions. ## Type of Change - [x] Bug fix (non-breaking change that fixes an issue) ## Changes Made Delegate block-list content to `tokenizers.base.count_content_blocks`, deleting the local walk. That counter already guards exactly this case — its comment reads *"1MB image = ~330K fake tokens without this"* — so this walk simply predated it. Beyond the raw fix, this removes a **second pricing rule**: the gate now values images the same way the tokenizer that computes `tokens_before`/`tokens_after` does (a flat 1600, "max after auto-resize"). Pricing images one way for the gate and another for the savings math is the same class of problem as #2761. Verified byte-identical on the shapes the old walk handled correctly: ```text old walk canonical text only 101 101 tool_result str 81 81 tool_result list 61 61 image only 100,034 1,600 mixed 100,036 1,602 ``` ## Testing - [x] Unit tests pass (`pytest`) - [x] Linting passes (`ruff check` + `ruff format`) - [x] Type checking passes (`mypy`) - [x] New tests added for new functionality ### Test Output ```text $ pytest tests/test_netcost_suffix_image_tokens.py -q 8 passed $ git stash push headroom/ && pytest tests/test_netcost_suffix_image_tokens.py -q 4 failed, 4 passed # the 4 failures are the payload-scaling assertions; the 4 passes are the # text/tool_result/string shapes, included to prove delegation is behaviour-preserving ``` All netcost + content-router suites: ```text $ pytest tests/test_netcost_gate.py tests/test_content_router_*.py \ tests/test_transforms_content_router.py tests/test_netcost_suffix_image_tokens.py -q 126 passed ``` ```text $ ruff check headroom/transforms/content_router.py tests/... All checks passed! $ mypy headroom/transforms/content_router.py no new errors ``` Deferring the full suite to CI — no maturin/Rust core in this environment. ## One existing test rewritten — please look at this bit `test_netcost_gate.py::TestNetCostHelpers::test_message_tokens_block_list_beats_repr` fails under the fix, and I want to be explicit that I changed a test rather than bury it. It built its image block as `{"type": "image", "source": {"data": "x" * 500}}`. A 500-char stub is **cheaper than a single image's real token cost**, so `str()` over it looked harmless (~130 tokens) and its assertion `abs(helper - text_only) < text_only * 0.5` held. That unrepresentative fixture is precisely why the payload-scaling bug survived — the test named "beats repr" was passing on the one payload size where repr happens not to be catastrophic. Rewritten to use a realistic 200KB payload and to assert what actually matters: ```python assert helper >= text_only # text still counted in full assert helper - text_only <= 2000 # image cost is bounded, not payload-scaled assert helper < count_text(str(content)) / 10 # ...and far below repr ``` I checked this both ways, so it is a real test and not a rubber stamp: ```text old test + fixed code -> FAILS (it was pinning the defect) new test + main -> FAILS (it catches the real bug) new test + fixed code -> passes ``` ## Known limitation The canonical estimate is a flat 1600 per image regardless of dimensions, so a small icon is now over-charged (~1600 vs ~13 real) where repr would have charged ~200. I kept the flat constant deliberately: it is the value every other counter in the codebase uses, and introducing a third rule here to shave small-icon cost would recreate the inconsistency this PR removes. The error is bounded at 1600 tokens and biases the gate conservative, versus an unbounded 100K+ error before.
2026-08-04 11:31:52 -07:00
{"type": "image", "source": {"data": "x" * 200_000}},
feat(policy): consume net-cost mutation gate in ContentRouter (#856 P2) (#905) ## Description Fixes #907. Part of #904 — the **P2 (consume, flag-gated)** item from #856's phased plan. (#903, which this was stacked on, has merged; this is now a clean diff.) `HEADROOM_NET_COST_POLICY=1` (default **off** — flag absent restores byte-identical current behavior) routes every ContentRouter mutation candidate through `CompressionPolicy.net_mutation_gain` before compression is applied, at both decision sites: the result-cache-hit path and the fresh-compression merge (pass 3). v1 estimators (as specced in #856): **ΔT** exact (compressed form already computed); **S** = token total after the slot, precomputed once as a reverse cumulative sum (O(1) per candidate); **R / P_alive** env-tunable (`HEADROOM_NET_COST_EXPECTED_READS`=10, `HEADROOM_NET_COST_P_ALIVE`=1.0). Every decision logs all inputs at INFO and increments `netcost_allowed`/`netcost_skipped` counters so the flag can be validated from telemetry before any default-on. Closes #907. ## Type of Change - [x] New feature (non-breaking change which adds functionality) ## Changes Made - Add flag-gated net-cost mutation gate to `ContentRouter` at both mutation sites (cache-hit + fresh-compress merge). - Precompute reverse-cumulative suffix token sums once per request for O(1) S lookups. - Emit INFO telemetry, `netcost_allowed`/`netcost_skipped` counters, and a `netcost:skip:<band>` transform marker on blocked slots. - **Review-response (4eb2307):** reject non-finite env values (`math.isfinite` guard), count suffix tokens block-aware via `_netcost_message_tokens()` (was `str(content)`, which miscounted Anthropic block lists), and bucket the skip marker via `_gain_bucket()` to bound dashboard cardinality. ## Testing - [x] Unit tests pass (`pytest`) - [x] Linting passes (`ruff check .`) - [x] New tests added for new functionality - [x] New and existing unit tests pass locally with my changes ### Test Output ```text $ pytest tests/test_netcost_gate.py -q 11 passed in 0.82s $ pytest tests/ -k "content_router or netcost or router" -q 133 passed, 8 skipped, 6120 deselected in 23.26s $ ruff check headroom/transforms/content_router.py All checks passed! ``` ## Real Behavior Proof - Environment: local macOS, repo .venv, Python 3.11.9, gpt-4o tokenizer fixture - Exact command / steps: `pytest tests/test_netcost_gate.py -q` then the router-suite selector above; gate exercised end-to-end through the real tokenizer + compression path (flag on via monkeypatch) - Observed result: with R=10/P=1 defaults, a 300-row tool result followed by a 40k-word suffix is left uncompressed (gate skips, `netcost:skip:` marker emitted); a 2000-row result with a 5-word suffix compresses (gate allows). Non-finite env (`inf`/`nan`) falls back to defaults and still skips. - Not tested: live proxy traffic / real dashboard validation — deferred to the default-on milestone per #904 (this ships default-off precisely to gather that telemetry first). ## Review Readiness - [x] I have performed a self-review - [x] This PR is ready for human review ## Additional Notes Cache-hit re-tokenization (`:2312`) and the large integration fixtures are tracked as follow-ups in the PR review thread; both are intentional given the flag is default-off. Known v1 limitations (whole-suffix S, no batch awareness, static P_alive) are tracked in #904 as P2b/P3a/P3b. PR body updated to satisfy the new PR-governance template gate (#914-era governance workflow). --------- Co-authored-by: integration-check <integration@local>
2026-06-13 17:46:26 +02:00
],
}
helper = _netcost_message_tokens(block_msg, tokenizer)
text_only = tokenizer.count_text(text)
fix(router): stop counting an image's base64 payload as suffix tokens (#2778) ## Description `_netcost_message_tokens` walked block-list content itself and fell back to `str(block)` for anything that wasn't `text` or `tool_result` — on the stated assumption that such blocks *"rarely dominate a suffix"*. An `image` block is the exception that breaks it: `str()` embeds the whole base64 payload. ```text counted real over 512x512 PNG 20,034 349 57x 1092x1092 screenshot 100,034 1,589 63x 1568x1568 233,367 1,600 146x ``` **Why this changes behaviour, not just a number.** S is the cache-bust cost — the tokens re-written if message *j* is mutated. `apply()` builds it as a running suffix sum: ```python for j in range(num_messages - 1, -1, -1): netcost_suffix_tokens[j] = netcost_suffix_tokens[j + 1] + _netcost_message_tokens(...) ``` So one image inflates S for **every message before it**, and the break-even gate then declines to compress any of them. A single screenshot could switch off net-cost-gated compression for the whole earlier conversation — and screenshots are routine in agent sessions. ## Type of Change - [x] Bug fix (non-breaking change that fixes an issue) ## Changes Made Delegate block-list content to `tokenizers.base.count_content_blocks`, deleting the local walk. That counter already guards exactly this case — its comment reads *"1MB image = ~330K fake tokens without this"* — so this walk simply predated it. Beyond the raw fix, this removes a **second pricing rule**: the gate now values images the same way the tokenizer that computes `tokens_before`/`tokens_after` does (a flat 1600, "max after auto-resize"). Pricing images one way for the gate and another for the savings math is the same class of problem as #2761. Verified byte-identical on the shapes the old walk handled correctly: ```text old walk canonical text only 101 101 tool_result str 81 81 tool_result list 61 61 image only 100,034 1,600 mixed 100,036 1,602 ``` ## Testing - [x] Unit tests pass (`pytest`) - [x] Linting passes (`ruff check` + `ruff format`) - [x] Type checking passes (`mypy`) - [x] New tests added for new functionality ### Test Output ```text $ pytest tests/test_netcost_suffix_image_tokens.py -q 8 passed $ git stash push headroom/ && pytest tests/test_netcost_suffix_image_tokens.py -q 4 failed, 4 passed # the 4 failures are the payload-scaling assertions; the 4 passes are the # text/tool_result/string shapes, included to prove delegation is behaviour-preserving ``` All netcost + content-router suites: ```text $ pytest tests/test_netcost_gate.py tests/test_content_router_*.py \ tests/test_transforms_content_router.py tests/test_netcost_suffix_image_tokens.py -q 126 passed ``` ```text $ ruff check headroom/transforms/content_router.py tests/... All checks passed! $ mypy headroom/transforms/content_router.py no new errors ``` Deferring the full suite to CI — no maturin/Rust core in this environment. ## One existing test rewritten — please look at this bit `test_netcost_gate.py::TestNetCostHelpers::test_message_tokens_block_list_beats_repr` fails under the fix, and I want to be explicit that I changed a test rather than bury it. It built its image block as `{"type": "image", "source": {"data": "x" * 500}}`. A 500-char stub is **cheaper than a single image's real token cost**, so `str()` over it looked harmless (~130 tokens) and its assertion `abs(helper - text_only) < text_only * 0.5` held. That unrepresentative fixture is precisely why the payload-scaling bug survived — the test named "beats repr" was passing on the one payload size where repr happens not to be catastrophic. Rewritten to use a realistic 200KB payload and to assert what actually matters: ```python assert helper >= text_only # text still counted in full assert helper - text_only <= 2000 # image cost is bounded, not payload-scaled assert helper < count_text(str(content)) / 10 # ...and far below repr ``` I checked this both ways, so it is a real test and not a rubber stamp: ```text old test + fixed code -> FAILS (it was pinning the defect) new test + main -> FAILS (it catches the real bug) new test + fixed code -> passes ``` ## Known limitation The canonical estimate is a flat 1600 per image regardless of dimensions, so a small icon is now over-charged (~1600 vs ~13 real) where repr would have charged ~200. I kept the flat constant deliberately: it is the value every other counter in the codebase uses, and introducing a third rule here to shave small-icon cost would recreate the inconsistency this PR removes. The error is bounded at 1600 tokens and biases the gate conservative, versus an unbounded 100K+ error before.
2026-08-04 11:31:52 -07:00
# The text payload is still counted in full, and the image adds a
# bounded pixel-based cost rather than a payload-scaled one.
assert helper >= text_only
assert helper - text_only <= 2000
# ...which is dramatically less than stringifying the whole list.
assert helper < tokenizer.count_text(str(block_msg["content"])) / 10
feat(policy): consume net-cost mutation gate in ContentRouter (#856 P2) (#905) ## Description Fixes #907. Part of #904 — the **P2 (consume, flag-gated)** item from #856's phased plan. (#903, which this was stacked on, has merged; this is now a clean diff.) `HEADROOM_NET_COST_POLICY=1` (default **off** — flag absent restores byte-identical current behavior) routes every ContentRouter mutation candidate through `CompressionPolicy.net_mutation_gain` before compression is applied, at both decision sites: the result-cache-hit path and the fresh-compression merge (pass 3). v1 estimators (as specced in #856): **ΔT** exact (compressed form already computed); **S** = token total after the slot, precomputed once as a reverse cumulative sum (O(1) per candidate); **R / P_alive** env-tunable (`HEADROOM_NET_COST_EXPECTED_READS`=10, `HEADROOM_NET_COST_P_ALIVE`=1.0). Every decision logs all inputs at INFO and increments `netcost_allowed`/`netcost_skipped` counters so the flag can be validated from telemetry before any default-on. Closes #907. ## Type of Change - [x] New feature (non-breaking change which adds functionality) ## Changes Made - Add flag-gated net-cost mutation gate to `ContentRouter` at both mutation sites (cache-hit + fresh-compress merge). - Precompute reverse-cumulative suffix token sums once per request for O(1) S lookups. - Emit INFO telemetry, `netcost_allowed`/`netcost_skipped` counters, and a `netcost:skip:<band>` transform marker on blocked slots. - **Review-response (4eb2307):** reject non-finite env values (`math.isfinite` guard), count suffix tokens block-aware via `_netcost_message_tokens()` (was `str(content)`, which miscounted Anthropic block lists), and bucket the skip marker via `_gain_bucket()` to bound dashboard cardinality. ## Testing - [x] Unit tests pass (`pytest`) - [x] Linting passes (`ruff check .`) - [x] New tests added for new functionality - [x] New and existing unit tests pass locally with my changes ### Test Output ```text $ pytest tests/test_netcost_gate.py -q 11 passed in 0.82s $ pytest tests/ -k "content_router or netcost or router" -q 133 passed, 8 skipped, 6120 deselected in 23.26s $ ruff check headroom/transforms/content_router.py All checks passed! ``` ## Real Behavior Proof - Environment: local macOS, repo .venv, Python 3.11.9, gpt-4o tokenizer fixture - Exact command / steps: `pytest tests/test_netcost_gate.py -q` then the router-suite selector above; gate exercised end-to-end through the real tokenizer + compression path (flag on via monkeypatch) - Observed result: with R=10/P=1 defaults, a 300-row tool result followed by a 40k-word suffix is left uncompressed (gate skips, `netcost:skip:` marker emitted); a 2000-row result with a 5-word suffix compresses (gate allows). Non-finite env (`inf`/`nan`) falls back to defaults and still skips. - Not tested: live proxy traffic / real dashboard validation — deferred to the default-on milestone per #904 (this ships default-off precisely to gather that telemetry first). ## Review Readiness - [x] I have performed a self-review - [x] This PR is ready for human review ## Additional Notes Cache-hit re-tokenization (`:2312`) and the large integration fixtures are tracked as follow-ups in the PR review thread; both are intentional given the flag is default-off. Known v1 limitations (whole-suffix S, no batch awareness, static P_alive) are tracked in #904 as P2b/P3a/P3b. PR body updated to satisfy the new PR-governance template gate (#914-era governance workflow). --------- Co-authored-by: integration-check <integration@local>
2026-06-13 17:46:26 +02:00
def test_message_tokens_tool_result_blocks(self, tokenizer):
from headroom.transforms.content_router import _netcost_message_tokens
payload = "log line " * 100
msg = {
"role": "user",
"content": [
{
"type": "tool_result",
"tool_use_id": "t1",
"content": [{"type": "text", "text": payload}],
}
],
}
assert _netcost_message_tokens(msg, tokenizer) >= tokenizer.count_text(payload) * 0.8
def test_message_tokens_string_content(self, tokenizer):
from headroom.transforms.content_router import _netcost_message_tokens
s = "plain string content " * 50
assert _netcost_message_tokens({"role": "user", "content": s}, tokenizer) == (
tokenizer.count_text(s)
)
feat(policy): unlock formula-positive deep edits through the frozen floor (#856 P2b) (#944) ## Description Part of #904 — the **P2b (Subscription deep-unlock)** item from #856's phased plan. Builds directly on the P2 gate (#905, now merged); rebased onto `main` so the diff below is P2b-only (`headroom/transforms/content_router.py` +39/−5, `tests/test_netcost_gate.py` +72). The P2 net-cost gate only governs mutations the router already considers — messages **above** the `frozen_message_count` floor. The floor itself stays a hard binary skip: anything in the provider's prefix cache is left byte-identical no matter how compressible. That leaves the deep-edit half of #856 on the table — e.g. a ~60K-token stale tool dump sitting in the frozen prefix with only a small cached suffix after it, which pays for its cache-bust many times over. With `HEADROOM_NET_COST_POLICY=1` (default **off**), a **string-content** frozen message now falls through to the normal candidate pipeline instead of being skipped at the floor. The existing P2 break-even gate then decides per candidate: **S** is the full invalidated suffix after the slot, so the deep edit proceeds only when `ΔT·(w+r(R−1))` still beats the cache-bust penalty. Flag off restores byte-identical current behavior. ## Type of Change - [x] New feature (non-breaking change which adds functionality) ## Changes Made - Open the `frozen_message_count` floor in `ContentRouter` under `HEADROOM_NET_COST_POLICY=1`: string-content frozen messages route to the existing P2 gate instead of an unconditional skip; the gate's whole-suffix S already prices the cache-bust correctly for frozen slots. - **Scope guard:** block-list and non-string frozen content stay frozen — the gate is wired into the string and parallel-merge paths only, and the per-block `cache_control` contract in `_process_content_blocks` is not net-cost aware, so opening them here would mutate cached blocks ungated. - Emit a `router:netcost_frozen_unlock` transform marker + `netcost_frozen_unlocked` route count on actual unlocks, and `netcost_frozen_considered` for every frozen string slot routed to the gate — telemetry to validate the flag before any default-on. ## Testing - [x] Unit tests pass (`pytest`) - [x] Linting passes (`ruff check .`) - [x] New tests added for new functionality - [x] New and existing unit tests pass locally with my changes ### Test Output ```text $ pytest tests/test_netcost_gate.py -q 15 passed in 0.96s $ pytest tests/ -k "content_router or netcost or router" -q 137 passed, 8 skipped, 6251 deselected in 20.89s $ ruff check headroom/transforms/content_router.py tests/test_netcost_gate.py All checks passed! $ ruff format --check headroom/transforms/content_router.py tests/test_netcost_gate.py 2 files already formatted ``` ## Real Behavior Proof - Environment: local macOS, repo .venv, Python 3.11.9, gpt-4o tokenizer fixture - Exact command / steps: drive `ContentRouter.apply()` with a 4-message conversation whose index-1 `tool` message (61,584 tokens) sits inside the frozen prefix (`frozen_message_count=2`), tiny suffix after; run once with the flag absent and once with `HEADROOM_NET_COST_POLICY=1` - Observed result: flag **off** → frozen tool dump left untouched, no unlock marker; flag **on** → dump compressed (`router:smart_crusher`) and `router:netcost_frozen_unlock` emitted, while the surrounding user messages stay `router:protected:user_message`. The 4 new unit tests also confirm a modest-shave / 40K-suffix frozen slot is *kept* frozen (gate runs, `netcost:skip:` emitted, no unlock) and block-list frozen content stays frozen. - Not tested: live proxy traffic / real dashboard validation — deferred to the default-on milestone per #904 (ships default-off precisely to gather that telemetry first). ## Review Readiness - [x] I have performed a self-review - [x] This PR is ready for human review ## Additional Notes Net-cost economics are unchanged from P2 — this only widens *which slots* the same gate may consider. The Subscription deep-unlock story from #856 is realized without a mode branch: the floor is mode-agnostic in `ContentRouter`, and the formula is the correct arbiter regardless of auth mode. Remaining #904 items: P3a (batch deep edits) and P3b (idle-timer compaction).
2026-06-15 18:06:28 +02:00
def _frozen_messages(tool_content: str, suffix_filler_words: int) -> list[dict]:
"""A short conversation whose compressible tool dump sits *inside* the
frozen prefix (index 1, with frozen_message_count=2)."""
suffix = "analysis context word " * suffix_filler_words
return [
{"role": "user", "content": "fetch the records"},
{"role": "tool", "content": tool_content},
{"role": "user", "content": suffix},
{"role": "user", "content": "summarize"},
]
class TestNetCostFrozenUnlock:
"""#856 P2b: let formula-positive deep edits through the frozen floor."""
def test_flag_off_frozen_stays_frozen(self, router, tokenizer, monkeypatch):
# Default (flag off): a message in the prefix cache is never mutated,
# however compressible it is — the binary floor wins.
monkeypatch.delenv("HEADROOM_NET_COST_POLICY", raising=False)
messages = _frozen_messages(_tool_json(2000), suffix_filler_words=5)
result = router.apply([dict(m) for m in messages], tokenizer, frozen_message_count=2)
assert not _tool_slot_compressed(result, messages)
assert "router:netcost_frozen_unlock" not in result.transforms_applied
def test_flag_on_unlocks_when_shave_dominates(self, router, tokenizer, monkeypatch):
# Huge shave deep in the frozen zone, tiny suffix after -> the
# break-even gate clears the deep edit and it proceeds (the "50K
# stale dump, 10K suffix" user story).
monkeypatch.setenv("HEADROOM_NET_COST_POLICY", "1")
messages = _frozen_messages(_tool_json(2000), suffix_filler_words=5)
result = router.apply([dict(m) for m in messages], tokenizer, frozen_message_count=2)
assert _tool_slot_compressed(result, messages)
assert "router:netcost_frozen_unlock" in result.transforms_applied
def test_flag_on_keeps_frozen_when_suffix_dominates(self, router, tokenizer, monkeypatch):
# Modest shave, big cached suffix -> gate runs on the unlocked slot
# but rejects it. The frozen message is left byte-identical and no
# unlock marker is emitted, proving the floor opened yet the formula
# still protected the cache.
monkeypatch.setenv("HEADROOM_NET_COST_POLICY", "1")
messages = _frozen_messages(_tool_json(300), suffix_filler_words=40000)
result = router.apply([dict(m) for m in messages], tokenizer, frozen_message_count=2)
assert not _tool_slot_compressed(result, messages)
assert "router:netcost_frozen_unlock" not in result.transforms_applied
assert any(t.startswith("netcost:skip:") for t in result.transforms_applied)
def test_flag_on_block_content_frozen_stays_frozen(self, router, tokenizer, monkeypatch):
# The gate is wired into the string and parallel-merge paths only;
# block-list frozen content (whose per-block cache_control contract
# is not net-cost aware) stays frozen even with a tiny suffix.
monkeypatch.setenv("HEADROOM_NET_COST_POLICY", "1")
big = "log line of output " * 400
messages = [
{"role": "user", "content": "fetch"},
{
"role": "user",
"content": [
{
"type": "tool_result",
"tool_use_id": "t1",
"content": [{"type": "text", "text": big}],
}
],
},
{"role": "user", "content": "summarize"},
]
original = [dict(m) for m in messages]
result = router.apply([dict(m) for m in messages], tokenizer, frozen_message_count=2)
assert result.messages[1]["content"] == original[1]["content"]
assert "router:netcost_frozen_unlock" not in result.transforms_applied
feat(policy): batch deep edits through one cache-bust (#856 P3a) (#1015) ## Description #856 P3a (umbrella #904), stacked on the now-merged P2 (#905) and P2b (#944). A net-cost mutation at depth K already busts the provider's cached suffix after K. Every *later* candidate at a deeper slot therefore rides that same cache invalidation for free — mutating it adds no incremental cache-bust cost. Today the P2 break-even gate re-charges each candidate the full invalidated suffix S independently, so a batch of legitimate deep edits is under-admitted: only the first pays for the bust, yet each is billed as if it paid alone. This adds a batch-reclaim floor to the net-cost gate so that once one net-positive deep edit is admitted at slot K, candidates at slot > K are admitted on the write/read economics alone (S charged as 0). Flag-gated under `HEADROOM_NET_COST_POLICY` (the same flag as P2/P2b), default **off** — telemetry-first before any default-on. ## Type of Change - [x] New feature (non-breaking change which adds functionality) - [ ] Bug fix - [ ] Breaking change - [ ] Documentation ## Changes Made - `ContentRouter._net_cost_allows`: new `batch_state` param. When the candidate sits strictly deeper than `batch_state["floor"]`, S is charged as 0 via the *same* `net_mutation_gain` formula (conservative — never admits a mutation the real economics would reject). Full-S admits open/lower the floor; batch admits never lower it, so a slot only ever rides free behind a genuinely mutated shallower slot. - `ContentRouter.apply`: shared per-request `netcost_batch_state` wired into both gate call sites (cached-result path and parallel-merge path). - Telemetry: every batch admission emits the `router:netcost_batch_admit` transform marker and the `netcost_batch_admitted` route counter; added to the routing summary log line. - Tests: 5 new cases in `tests/test_netcost_gate.py` (`TestNetCostBatchReclaim`). ## Testing - [x] Unit tests pass (`pytest`) - [x] Linting passes (`ruff check .`) - [x] New tests added for new functionality ### Test Output ```text $ pytest tests/test_netcost_gate.py -q 20 passed in 1.46s $ pytest tests/ -k "content_router or netcost or router" -q 142 passed, 8 skipped, 6342 deselected, 1 warning in 22.54s $ ruff check headroom/transforms/content_router.py tests/test_netcost_gate.py All checks passed! $ ruff format --check headroom/transforms/content_router.py tests/test_netcost_gate.py 2 files already formatted $ mypy headroom/transforms/content_router.py Success: no issues found in 1 source file ``` ## Real Behavior Proof - Environment: local macOS, repo .venv, Python 3.11.9, gpt-4o tokenizer fixture - Exact command / steps: drive `ContentRouter.apply()` on a 5-message conversation — a huge compressible tool dump at slot 1 (ΔT≈34K) and a modest dump at slot 2 (ΔT≈5K) followed by a ~12K-token suffix, so slot 2's own break-even S blocks it. Run with `HEADROOM_NET_COST_POLICY=1`, once with a non-compressible slot 1 (no shallower admit, control) and once with the slot-1 dump intact (opens the floor). - Observed result: control → `slot2_compressed=False batch_markers=0 skip_markers=1` (slot 2 correctly blocked on its own S, no floor opened); floor opened → `slot2_compressed=True batch_markers=1 skip_markers=0` (slot 2 rides slot 1's cache-bust for free, `router:netcost_batch_admit` emitted). Flag absent → no `router:netcost_batch_admit` marker ever. - Not tested: live proxy traffic / real dashboard validation — deferred to the default-on milestone per #904 (ships default-off precisely to gather telemetry first). Known limitation logged for follow-up: in a *warm-cache* request a deep cache-hit slot is gated in pass 1 before a shallower cache-miss slot can lower the floor in pass 3, so the batch win can no-op there (never a wrong admit — strictly conservative). ## Review Readiness - [x] I have performed a self-review - [x] This PR is ready for human review ## Additional Notes Charging S=0 through the existing formula (rather than blanket-admitting on `ΔT > 0`) keeps the decision conservative under non-default env tunables (`HEADROOM_NET_COST_EXPECTED_READS`, `HEADROOM_NET_COST_P_ALIVE`). P3b will be a separate PR after this review. Note: the failing `test` / `test-extras` checks are a **pre-existing regression on `main`** in `tests/test_cache/test_dynamic_detector.py` (unrelated to this PR, which only touches `content_router.py`). Fix tracked in a separate PR; this branch will go green once that lands and this is rebased.
2026-06-16 06:30:23 +02:00
class TestNetCostBatchReclaim:
"""#856 P3a: batch deep edits -- once one net-positive edit is admitted at
slot K, deeper candidates ride that cache-bust for free (S charged as 0).
Tests are cache-cold (fresh router per fixture) so every candidate flows
through the parallel-merge pass in ascending slot order, which is where the
shared batch_state floor is set and then reclaimed.
"""
@staticmethod
def _convo(slot1: str, slot2: str, filler_words: int) -> list[dict]:
# Two consecutive tool dumps (slots 1 and 2) followed by a filler
# suffix. Slot 1 is the shallower candidate; slot 2 the deeper one.
suffix = "analysis context word " * filler_words
return [
{"role": "user", "content": "fetch the records"},
{"role": "tool", "content": slot1},
{"role": "tool", "content": slot2},
{"role": "user", "content": suffix},
{"role": "user", "content": "summarize"},
]
@staticmethod
def _compressed(result, original, idx: int) -> bool:
return result.messages[idx]["content"] != original[idx]["content"]
def test_flag_off_no_batch_marker(self, router, tokenizer, monkeypatch):
# Without the flag the batch path is inert -- no marker, no counter.
monkeypatch.delenv("HEADROOM_NET_COST_POLICY", raising=False)
messages = self._convo(_tool_json(2000), _tool_json(800), filler_words=5)
original = [dict(m) for m in messages]
result = router.apply([dict(m) for m in messages], tokenizer)
assert "router:netcost_batch_admit" not in result.transforms_applied
# Both deep edits still compress (no gate at all when flag off).
assert self._compressed(result, original, 1)
assert self._compressed(result, original, 2)
def test_deeper_edit_rides_free(self, router, tokenizer, monkeypatch):
# Slot 1 (huge shave) admits on its own merit and opens the floor;
# slot 2 then admits via the batch reclaim path and emits the marker.
monkeypatch.setenv("HEADROOM_NET_COST_POLICY", "1")
messages = self._convo(_tool_json(2000), _tool_json(800), filler_words=5)
original = [dict(m) for m in messages]
result = router.apply([dict(m) for m in messages], tokenizer)
assert self._compressed(result, original, 1)
assert self._compressed(result, original, 2)
markers = [t for t in result.transforms_applied if t == "router:netcost_batch_admit"]
# Exactly one deeper slot rode the floor for free.
assert len(markers) == 1
def test_batch_admits_otherwise_blocked_edit(self, router, tokenizer, monkeypatch):
# Slot 2 (modest shave, large suffix after it) would be blocked on its
# own S, but slot 1's admit already busted the suffix -- so slot 2 rides
# free. Pairs with test_no_prior_admit_keeps_block, which shows the same
# slot-2 config stays blocked when no shallower edit opens the floor.
monkeypatch.setenv("HEADROOM_NET_COST_POLICY", "1")
messages = self._convo(_tool_json(2000), _tool_json(300), filler_words=4000)
original = [dict(m) for m in messages]
result = router.apply([dict(m) for m in messages], tokenizer)
assert self._compressed(result, original, 1) # floor-setting admit
assert self._compressed(result, original, 2) # rode free
assert "router:netcost_batch_admit" in result.transforms_applied
def test_no_prior_admit_keeps_block(self, router, tokenizer, monkeypatch):
# Neither candidate beats its own S (both modest shaves under a huge
# suffix), so the floor is never opened and no slot rides free. Guards
# against a floor-init / off-by-one bug that would grant a free ride
# with no genuine shallower mutation behind it.
monkeypatch.setenv("HEADROOM_NET_COST_POLICY", "1")
messages = self._convo(_tool_json(300), _tool_json(300), filler_words=40000)
original = [dict(m) for m in messages]
result = router.apply([dict(m) for m in messages], tokenizer)
assert not self._compressed(result, original, 1)
assert not self._compressed(result, original, 2)
assert "router:netcost_batch_admit" not in result.transforms_applied
def test_frozen_unlock_and_batch_combine(self, router, tokenizer, monkeypatch):
# Two frozen string slots inside the prefix (frozen_message_count=3).
# Slot 1 unlocks and sets the floor; slot 2 unlocks AND rides free.
# Slot 2 carries both markers; the batch counter must not double-count.
monkeypatch.setenv("HEADROOM_NET_COST_POLICY", "1")
messages = self._convo(_tool_json(2000), _tool_json(800), filler_words=5)
original = [dict(m) for m in messages]
result = router.apply([dict(m) for m in messages], tokenizer, frozen_message_count=3)
assert self._compressed(result, original, 1)
assert self._compressed(result, original, 2)
unlocks = [t for t in result.transforms_applied if t == "router:netcost_frozen_unlock"]
batch = [t for t in result.transforms_applied if t == "router:netcost_batch_admit"]
assert len(unlocks) == 2 # both frozen slots opened
assert len(batch) == 1 # only the deeper one rode free -- no double-count
feat(policy): decay P_alive from idle time near cache TTL (#856 P3b) (#1028) ## Description #856 P3b (umbrella #904), the idle-timer-compaction increment after P2 (#905), P2b (#944), and P3a (#1015), all merged. Anthropic prompt-cache entries live in a ~5-minute TTL tier (the basis for the 1.25× write multiplier). As a session goes idle the cached suffix approaches lapse, so **P_alive** — the probability the cache still survives to the next turn — decays toward 0. When P_alive → 0 the net-cost penalty term `P_alive·(w−r)·(S+ΔT)` vanishes and a deep edit near lapse is free to make: the suffix is about to be rebuilt cold regardless. P2/P3a fed the break-even gate a **static** `HEADROOM_NET_COST_P_ALIVE` constant; this derives P_alive from an idle signal when one is available. Flag-gated under `HEADROOM_NET_COST_POLICY` (the same flag as P2/P2b/P3a), default **off**. ## Type of Change - [x] New feature (non-breaking change which adds functionality) - [ ] Bug fix - [ ] Breaking change - [ ] Documentation ## Changes Made - `ContentRouter.apply`: reads an optional `idle_seconds` kwarg and derives `P_alive = max(0, 1 − idle_s / ttl)` **once per request** (idle is a per-request property, like `frozen_message_count`), passing it to the gate as `p_alive_override`. Absent/malformed `idle_seconds` → `None` → the P2 env-constant path is preserved exactly. - `ContentRouter._net_cost_allows`: new `p_alive_override` param. When set it replaces the `HEADROOM_NET_COST_P_ALIVE` constant (clamped to [0,1]); otherwise unchanged. An admit made under a decayed (`< 1.0`) idle P_alive emits the `router:netcost_idle_compaction` marker and the `netcost_idle_admitted` counter (independent of the P3a batch marker; both may apply). - Cache TTL: module default 300s (Anthropic tier), overridable via `HEADROOM_NET_COST_CACHE_TTL_SECONDS`, with malformed/non-positive guards. Explicitly **distinct** from `PrefixFreezeConfig.session_ttl_seconds` (tracker cleanup, 600s). - `PrefixCacheTracker.seconds_since_activity()`: exposes the idle signal for the proxy handlers to plumb (see Additional Notes). ## Testing - [x] Unit tests pass (`pytest`) - [x] Linting passes (`ruff check .`) - [x] New tests added for new functionality ### Test Output ```text $ pytest tests/test_netcost_gate.py -q 25 passed in 2.03s $ pytest tests/ -k "content_router or netcost or router or prefix_tracker or prefix" -q 245 passed, 8 skipped, 6252 deselected, 1 warning in 24.47s $ ruff check headroom/transforms/content_router.py headroom/cache/prefix_tracker.py tests/test_netcost_gate.py All checks passed! $ ruff format --check headroom/transforms/content_router.py headroom/cache/prefix_tracker.py tests/test_netcost_gate.py 3 files already formatted $ mypy headroom/transforms/content_router.py headroom/cache/prefix_tracker.py Success: no issues found in 2 source files ``` ## Real Behavior Proof - Environment: local macOS, repo .venv, Python 3.11.9, gpt-4o tokenizer fixture - Exact command / steps: drive `ContentRouter.apply()` on the P2 "blocked" baseline (a modest tool-dump shave, ΔT≈5K, under a ~120K-token cached suffix — rejected at the default P_alive=1.0), varying only `idle_seconds`. - Observed result: `idle_seconds=295` (TTL 300) → P_alive≈0.017, penalty collapses, the edit is admitted and `router:netcost_idle_compaction` is emitted; `idle_seconds=0` → P_alive=1.0, byte-identical to the constant baseline (still blocked, `netcost:skip:` emitted, no idle marker); absent/malformed `idle_seconds` → env-constant path (blocked); `HEADROOM_NET_COST_CACHE_TTL_SECONDS=60` with `idle_seconds=59` → unlock (custom TTL controls the decay). - Not tested: live proxy traffic — deferred to the default-on milestone per #904 (ships default-off to gather telemetry first). ## Review Readiness - [x] I have performed a self-review - [x] This PR is ready for human review ## Additional Notes **Proxy wiring is a deliberate follow-up**, mirroring how P2 shipped P_alive as an unplumbed constant and gathered telemetry before default-on. The gate already honors `idle_seconds` via kwarg and `PrefixCacheTracker.seconds_since_activity()` exposes the value; the remaining step is for the provider handlers (`handlers/anthropic.py`, `handlers/openai.py`) to pass it alongside the existing `frozen_message_count` kwarg (`pipeline.apply` already forwards `**kwargs` to `transform.apply`, so no pipeline change is needed). One wiring caveat is documented on `seconds_since_activity()`: `SessionTrackerStore.get_or_create` refreshes `_last_activity` on access, so the handler must read idle before fetching the tracker for the current request. Kept out of this PR for reviewability and because it touches ~10 call sites across both providers. --------- Co-authored-by: JD Davis <mxjerrett@gmail.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
2026-06-18 18:15:40 +02:00
class TestNetCostIdleCompaction:
"""#856 P3b: derive P_alive from idle time. As the session goes idle the
cached suffix nears TTL lapse, P_alive -> 0, the net-cost penalty term
vanishes, and edits that lose to a warm suffix become free.
Baseline shape (mirrors TestNetCostGate.test_flag_on_blocks...): a modest
tool-dump shave under a huge cached suffix is BLOCKED at the default
P_alive=1.0. These tests vary only the idle signal.
"""
def test_idle_near_ttl_unlocks_blocked_edit(self, router, tokenizer, monkeypatch):
# idle ~= cache TTL (default 300s) -> P_alive ~= 0 -> penalty ~= 0 ->
# the otherwise-blocked deep edit is admitted and marked.
monkeypatch.setenv("HEADROOM_NET_COST_POLICY", "1")
messages = _messages(_tool_json(300), suffix_filler_words=40000)
result = router.apply([dict(m) for m in messages], tokenizer, idle_seconds=295.0)
assert _tool_slot_compressed(result, messages)
assert "router:netcost_idle_compaction" in result.transforms_applied
assert not any(t.startswith("netcost:skip:") for t in result.transforms_applied)
def test_idle_zero_matches_constant_baseline(self, router, tokenizer, monkeypatch):
# idle=0 -> P_alive=1.0, identical to the env-constant default: the
# edit stays blocked and no idle marker is emitted.
monkeypatch.setenv("HEADROOM_NET_COST_POLICY", "1")
messages = _messages(_tool_json(300), suffix_filler_words=40000)
result = router.apply([dict(m) for m in messages], tokenizer, idle_seconds=0.0)
assert not _tool_slot_compressed(result, messages)
assert "router:netcost_idle_compaction" not in result.transforms_applied
assert any(t.startswith("netcost:skip:") for t in result.transforms_applied)
def test_idle_absent_uses_env_constant(self, router, tokenizer, monkeypatch):
# No idle_seconds kwarg -> override is None -> P2 env-constant path.
monkeypatch.setenv("HEADROOM_NET_COST_POLICY", "1")
messages = _messages(_tool_json(300), suffix_filler_words=40000)
result = router.apply([dict(m) for m in messages], tokenizer)
assert not _tool_slot_compressed(result, messages)
assert "router:netcost_idle_compaction" not in result.transforms_applied
def test_malformed_idle_falls_back_to_constant(self, router, tokenizer, monkeypatch):
# Non-numeric idle_seconds is ignored (override stays None), so the
# gate keeps the constant behaviour rather than crashing the request.
monkeypatch.setenv("HEADROOM_NET_COST_POLICY", "1")
messages = _messages(_tool_json(300), suffix_filler_words=40000)
result = router.apply([dict(m) for m in messages], tokenizer, idle_seconds="soon")
assert not _tool_slot_compressed(result, messages)
assert "router:netcost_idle_compaction" not in result.transforms_applied
def test_custom_ttl_env_controls_decay(self, router, tokenizer, monkeypatch):
# A shorter TTL makes the same idle fully decay P_alive -> unlock.
monkeypatch.setenv("HEADROOM_NET_COST_POLICY", "1")
monkeypatch.setenv("HEADROOM_NET_COST_CACHE_TTL_SECONDS", "60")
messages = _messages(_tool_json(300), suffix_filler_words=40000)
result = router.apply([dict(m) for m in messages], tokenizer, idle_seconds=59.0)
assert _tool_slot_compressed(result, messages)
assert "router:netcost_idle_compaction" in result.transforms_applied