headroom/tests/test_update_check.py

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

187 lines
6.2 KiB
Python
Raw Permalink Normal View History

feat(cli): add headroom update command and release banner (#1088) ## Description Adds a `headroom update` self-update command and a passive "update available" banner, so users no longer need to remember the right `pip`/`pipx`/`uv` incantation for their environment, and long-running proxies get nudged when they drift behind a release. Closes #1087 ## Type of Change - [x] New feature (non-breaking change that adds functionality) - [x] Documentation update ## Changes Made - `headroom/cli/update.py` — `headroom update` command. `detect_install_method()` resolves the install (git checkout, editable, Docker, pipx, uv tool, venv/conda, `pip --user`, externally-managed system Python per PEP 668, writable global) and builds the matching upgrade. pip path always uses `sys.executable -m pip` so it can't touch the wrong interpreter. Refuses with guidance where self-update is unsafe. Flags: `--check`, `--yes`, `--pre`, `--extras`. - `headroom/update_check.py` — best-effort PyPI check (stdlib `urllib`, no new dep). Split into a daemon-thread probe that caches to `~/.headroom/update_check.json` (≤ once/day) and a cache-only `format_update_notice()`. Opt-out `HEADROOM_UPDATE_CHECK=off`; skipped in `--stateless`, CI, Docker, checkouts. - `headroom/cli/main.py`, `headroom/cli/__init__.py` — register `update`; fire the background check from the group callback (skipped for `update`). - `headroom/cli/proxy.py` — render the one-line notice after the startup banner (best-effort, never blocks). - `README.md` — "Updating" section + opt-out env var. - Tests: `tests/test_update_check.py`, `tests/test_cli_update.py`. ## Testing - [x] Unit tests pass (`pytest`) - [x] Linting passes (`ruff check .`) - [x] Type checking passes (`mypy headroom`) - [x] New tests added for new functionality - [x] Manual testing performed ### Test Output ```text $ pytest tests/test_update_check.py tests/test_cli_update.py -q 42 passed in 1.63s $ ruff check headroom/cli/update.py headroom/update_check.py headroom/cli/main.py All checks passed! $ mypy headroom/update_check.py headroom/cli/update.py Success: no issues found in 2 source files ``` ## Real Behavior Proof - Environment: macOS, Python 3.11, source checkout - Exact command / steps: `python -m headroom.cli update --help`; `detect_install_method()` in the checkout - Observed result: command + flags render; in a checkout `detect_install_method()` returns `kind=checkout, can_self_update=False` ("update with `git pull`") and `format_update_notice()` returns `None` (dev tree not nagged) - Not tested: live PyPI fetch and a real pipx/uv-tool upgrade on this machine (covered by unit tests with mocked `urllib`/`subprocess`) ## Review Readiness - [x] I have performed a self-review - [x] This PR is ready for human review ## Checklist - [x] My code follows the project's style guidelines - [x] I have performed a self-review of my code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] I have updated the CHANGELOG.md if applicable ## Additional Notes - CHANGELOG.md is release-please-managed, so it is intentionally not hand-edited (N/A above). - Update check uses stdlib `urllib` because `httpx` lives only in the `[proxy]` extra — the base CLI must stay dependency-light.
2026-06-18 18:22:20 +02:00
"""Tests for headroom.update_check (PyPI probe, cache, banner notice)."""
from __future__ import annotations
import json
import time
import pytest
from headroom import update_check as uc
@pytest.fixture(autouse=True)
def _workspace(tmp_path, monkeypatch):
"""Point the workspace (cache) dir at a tmp dir and enable the check."""
monkeypatch.setenv("HEADROOM_WORKSPACE_DIR", str(tmp_path))
monkeypatch.setenv("HEADROOM_UPDATE_CHECK", "on")
monkeypatch.delenv("HEADROOM_STATELESS", raising=False)
monkeypatch.delenv("CI", raising=False)
# Treat tests as a non-checkout, non-docker install by default.
monkeypatch.setattr(uc, "_is_source_checkout", lambda: False)
monkeypatch.setattr(uc, "_in_docker", lambda: False)
return tmp_path
# --------------------------------------------------------------------------- #
# enable gate
# --------------------------------------------------------------------------- #
def test_enabled_by_default(monkeypatch):
assert uc.is_update_check_enabled() is True
@pytest.mark.parametrize("val", ["off", "false", "0", "no", "disabled"])
def test_disabled_by_env(monkeypatch, val):
monkeypatch.setenv("HEADROOM_UPDATE_CHECK", val)
assert uc.is_update_check_enabled() is False
def test_disabled_in_stateless(monkeypatch):
monkeypatch.setenv("HEADROOM_STATELESS", "1")
assert uc.is_update_check_enabled() is False
def test_disabled_in_ci(monkeypatch):
monkeypatch.setenv("CI", "true")
assert uc.is_update_check_enabled() is False
# --------------------------------------------------------------------------- #
# _select_latest
# --------------------------------------------------------------------------- #
def test_select_latest_picks_max_stable():
data = {"releases": {"0.25.0": [{}], "0.26.0": [{}], "0.27.0rc1": [{}]}}
assert uc._select_latest(data, allow_pre=False) == "0.26.0"
def test_select_latest_allows_pre():
data = {"releases": {"0.26.0": [{}], "0.27.0rc1": [{}]}}
assert uc._select_latest(data, allow_pre=True) == "0.27.0rc1"
def test_select_latest_skips_fully_yanked():
data = {
"releases": {
"0.26.0": [{"yanked": False}],
"0.27.0": [{"yanked": True}],
}
}
assert uc._select_latest(data, allow_pre=False) == "0.26.0"
def test_select_latest_falls_back_to_info_version():
data = {"releases": {}, "info": {"version": "0.26.0"}}
assert uc._select_latest(data, allow_pre=False) == "0.26.0"
# --------------------------------------------------------------------------- #
# fetch_latest_version
# --------------------------------------------------------------------------- #
def test_fetch_latest_version_parses(monkeypatch):
payload = json.dumps({"releases": {"0.26.0": [{}], "0.27.0": [{}]}}).encode()
class _Resp:
def __enter__(self):
return self
def __exit__(self, *a):
return False
def read(self):
return payload
monkeypatch.setattr(uc.urllib.request, "urlopen", lambda *a, **k: _Resp())
assert uc.fetch_latest_version() == "0.27.0"
def test_fetch_latest_version_network_error_returns_none(monkeypatch):
def _boom(*a, **k):
raise OSError("no network")
monkeypatch.setattr(uc.urllib.request, "urlopen", _boom)
assert uc.fetch_latest_version() is None
# --------------------------------------------------------------------------- #
# cache + should_check
# --------------------------------------------------------------------------- #
def test_cache_roundtrip():
uc.write_cache("0.27.0", now=1000.0)
cache = uc.read_cache()
assert cache["latest_version"] == "0.27.0"
assert cache["last_check"] == 1000.0
def test_should_check_true_when_no_cache():
assert uc.should_check() is True
def test_should_check_false_when_fresh():
now = time.time()
uc.write_cache("0.27.0", now=now)
assert uc.should_check(now=now + 10) is False
def test_should_check_true_when_stale():
now = time.time()
uc.write_cache("0.27.0", now=now)
assert uc.should_check(now=now + uc._CHECK_TTL_SECONDS + 1) is True
# --------------------------------------------------------------------------- #
# format_update_notice
# --------------------------------------------------------------------------- #
def test_notice_when_newer(monkeypatch):
uc.write_cache("0.27.0")
monkeypatch.setattr(uc, "installed_version", lambda: "0.26.0")
notice = uc.format_update_notice()
assert notice and "0.27.0" in notice and "headroom update" in notice
def test_no_notice_when_current(monkeypatch):
uc.write_cache("0.26.0")
monkeypatch.setattr(uc, "installed_version", lambda: "0.26.0")
assert uc.format_update_notice() is None
def test_no_notice_in_checkout(monkeypatch):
uc.write_cache("0.27.0")
monkeypatch.setattr(uc, "installed_version", lambda: "0.26.0")
monkeypatch.setattr(uc, "_is_source_checkout", lambda: True)
assert uc.format_update_notice() is None
def test_no_notice_when_disabled(monkeypatch):
uc.write_cache("0.27.0")
monkeypatch.setattr(uc, "installed_version", lambda: "0.26.0")
monkeypatch.setenv("HEADROOM_UPDATE_CHECK", "off")
assert uc.format_update_notice() is None
def test_no_notice_when_version_unknown(monkeypatch):
uc.write_cache("0.27.0")
monkeypatch.setattr(uc, "installed_version", lambda: None)
assert uc.format_update_notice() is None
# --------------------------------------------------------------------------- #
# maybe_check_async
# --------------------------------------------------------------------------- #
def test_maybe_check_async_writes_cache(monkeypatch):
monkeypatch.setattr(uc, "fetch_latest_version", lambda **k: "0.27.0")
thread = uc.maybe_check_async()
assert thread is not None
thread.join(timeout=5)
assert uc.read_cache()["latest_version"] == "0.27.0"
def test_maybe_check_async_skips_in_checkout(monkeypatch):
monkeypatch.setattr(uc, "_is_source_checkout", lambda: True)
assert uc.maybe_check_async() is None
def test_maybe_check_async_skips_when_fresh(monkeypatch):
uc.write_cache("0.27.0")
monkeypatch.setattr(uc, "fetch_latest_version", lambda **k: pytest.fail("should not fetch"))
assert uc.maybe_check_async() is None