From 11f59aed160923718e0a8189e62748df59adc7a2 Mon Sep 17 00:00:00 2001 From: chopratejas Date: Mon, 25 May 2026 18:36:12 -0700 Subject: [PATCH] ci(release): fix workflow-validation for new release trigger MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit scripts/validate-workflows.sh exercises release.yml with an `act` dry-run that posted a synthesized push-to-main event. After the previous commit retired that trigger in favor of `release: published`, the dry-run started failing in CI because release.yml no longer responds to push events. Simulate the new trigger instead: feed release.yml a release-published event (.github/act/release-published.json) and move the push-to-main dry-run onto release-please.yml — the workflow that now owns that event. --- .github/act/release-published.json | 11 +++++++++++ scripts/validate-workflows.sh | 8 +++++++- 2 files changed, 18 insertions(+), 1 deletion(-) create mode 100644 .github/act/release-published.json diff --git a/.github/act/release-published.json b/.github/act/release-published.json new file mode 100644 index 000000000..d46063432 --- /dev/null +++ b/.github/act/release-published.json @@ -0,0 +1,11 @@ +{ + "action": "published", + "release": { + "tag_name": "v0.9.2", + "name": "Release v0.9.2", + "draft": false, + "prerelease": false, + "body": "## What's Changed\n\n* fix: example change for act dry-run simulation" + }, + "ref": "refs/tags/v0.9.2" +} diff --git a/scripts/validate-workflows.sh b/scripts/validate-workflows.sh index b6083ccf0..b0fd2391d 100644 --- a/scripts/validate-workflows.sh +++ b/scripts/validate-workflows.sh @@ -25,5 +25,11 @@ run_act() { } run_act act workflow_dispatch -W .github/workflows/release.yml -e .github/act/dry-run.json -n -run_act act push -W .github/workflows/release.yml -e .github/act/push-feat.json -n +# release.yml's main trigger is now `release: published` (release-please +# emits this event when its release PR is merged). The earlier `push` +# trigger on main was removed in PR #495 to gate PyPI uploads behind +# the bot's release-PR pattern. Simulate the new trigger here so the +# validation step exercises the same code path CI actually fires on. +run_act act release -W .github/workflows/release.yml -e .github/act/release-published.json -n +run_act act push -W .github/workflows/release-please.yml -e .github/act/push-feat.json -n run_act act workflow_dispatch -W .github/workflows/docker.yml -e .github/act/docker-version.json -n