1 commit

Author	SHA1	Message	Date
Abhay Singh	8b7e797ed4	fix(proxy/memory): don't crash memory tool-call detection on a null function (#2272) ... ## Description `MemoryHandler` crashes when an upstream response carries a tool call whose `function` field is explicitly `null`. Three sites read the nested name like `tool_call.get("function", {}).get("name")`: - `has_memory_tool_calls` (line ~1043) — over the response's tool calls. - `handle_tool_calls` (line ~1110/1119) — resolving the tool name and arguments. - the memory tool-injection dedup (line ~562) — over the request's tools. `dict.get("function", {})` only substitutes `{}` for a *missing* key. A present-but-null `{"id": "c1", "type": "function", "function": null}` — a shape upstreams and gateways emit for a partial or streamed tool call — makes the result `None`, and `None.get("name")` raises `AttributeError`. `has_memory_tool_calls` and `handle_tool_calls` both iterate the untrusted upstream response, so a single malformed tool call takes down memory tool-call detection and handling for the whole response. ## Fix Coalesce `function` with `or {}` at all three sites, so a null (or any falsy) value collapses to `{}`: ```python name = tc.get("name") or (tc.get("function") or {}).get("name") args_str = tc.get("arguments") or (tc.get("function") or {}).get("arguments") or "{}" ``` Real tool calls resolve exactly as before. Closes # ## Type of Change - [x] Bug fix (non-breaking change that fixes an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Performance improvement - [ ] Code refactoring (no functional changes) ## Changes Made - `headroom/proxy/memory_handler.py`: coalesce `function` with `or {}` in `has_memory_tool_calls`, `handle_tool_calls`, and the tool-injection dedup. - `tests/test_memory_handler_null_function.py`: new tests that a null-function tool call doesn't crash detection and the real memory call is still seen. - `CHANGELOG.md`: Bug Fixes entry. ## Testing - [ ] Unit tests pass (`pytest`) - [x] Linting passes (`ruff check .`) - [x] Type checking passes (`mypy headroom`) - [x] New tests added for new functionality - [ ] Manual testing performed ### Test Output ```text $ uvx ruff@0.15.17 check headroom/proxy/memory_handler.py tests/test_memory_handler_null_function.py All checks passed! $ uvx mypy@1.20.2 --ignore-missing-imports headroom/proxy/memory_handler.py Success: no issues found in 1 source file ``` ## Real Behavior Proof - Environment: Windows 11, Python 3.12, `uvx ruff@0.15.17` / `uvx mypy@1.20.2`. A full `pytest` OOM-kills this box (ML stack import), so I reproduced the name-resolution logic with a dependency-free script and left the full pytest to CI. - Exact command / steps: ran a `{"function": null}` tool call (plus a real `memory_save` call) through the OLD `get("function", {})` and NEW `get("function") or {}` name resolution. - Observed result: OLD raises `AttributeError` on the null function; NEW returns `None` for it and still resolves the real `memory_save` name and a plain `{"name": "memory"}`. - Not tested: a live upstream emitting a null-function tool call; full local `pytest` deferred to CI (OOM). ## Review Readiness - [x] I have performed a self-review - [x] This PR is ready for human review ## Checklist - [x] My code follows the project's style guidelines - [x] I have performed a self-review of my code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [x] I have updated the CHANGELOG.md if applicable ## Additional Notes The "unit tests pass locally" box is unchecked because the full suite imports the ML stack, which I can't run here. `has_memory_tool_calls` and `_extract_tool_calls` use no instance state, so the new test exercises them on a bare instance via `object.__new__` — it runs under the normal CI pytest job, and the standalone proof above corroborates it. This is the memory-handler sibling of the same null-`function` hazard I'm fixing in the CCR tool-call detection and the memory tool adapter. --------- Co-authored-by: Tejas Chopra <chopratejas@gmail.com>	2026-07-16 14:37:41 -07:00