Commit graph

3 commits

Author SHA1 Message Date
Rod Boev
e035aefce2
fix(dashboard): derive per-project setup URL from live origin (#1511)
## Description

The Per-Project Savings empty state currently shows a hardcoded
`ANTHROPIC_BASE_URL: http://127.0.0.1:8787/p/<project-name>`. When the
proxy listens on a fallback or custom port, users can copy a broken
setup URL from the dashboard. This change derives the hint from the
browser's live origin and keeps the existing `/p/<project-name>` suffix
used by per-project savings. Closes #1508.

Related context: #1406 made non-default proxy ports a normal path, which
makes the hardcoded dashboard hint user-visible more often.

## Type of Change

- [x] Bug fix (non-breaking change that fixes an issue)
- [ ] New feature (non-breaking change that adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Documentation update
- [ ] Performance improvement
- [ ] Code refactoring (no functional changes)

## Changes Made

- Replace the static Per-Project Savings setup hint with an Alpine
`x-text` binding that uses `window.location.origin`.
- Preserve the `/p/<project-name>` suffix so the displayed path shape
stays aligned with the existing per-project routing contract.
- Add a Playwright regression that loads the dashboard from non-default
origins and asserts the empty state follows the active page origin
instead of `8787`.

## Testing

- [x] Unit tests pass (`uv run pytest
tests/test_dashboard_cache_ttl_playwright.py -k
"per_project_setup_url_uses_current_origin" -v`)
- [x] Unit tests pass (`uv run pytest
tests/test_owned_asset_encoding.py::test_get_dashboard_html_reads_as_utf8
tests/test_proxy_dashboard_stats_cache.py::test_dashboard_uses_cached_stats_and_lazy_history_feed_polling
-v`)
- [x] Linting passes (`uv run ruff check
tests/test_dashboard_cache_ttl_playwright.py`)
- [ ] Type checking passes (`uv run mypy headroom`)
- [x] New tests added for new functionality when applicable
- [x] Manual testing performed

### Test Output

```text
uv run pytest tests/test_dashboard_cache_ttl_playwright.py -k "per_project_setup_url_uses_current_origin" -v
tests/test_dashboard_cache_ttl_playwright.py::test_dashboard_per_project_setup_url_uses_current_origin PASSED [100%]
================= 1 passed, 1 deselected, 1 warning in 0.82s ==================

uv run pytest tests/test_owned_asset_encoding.py::test_get_dashboard_html_reads_as_utf8 tests/test_proxy_dashboard_stats_cache.py::test_dashboard_uses_cached_stats_and_lazy_history_feed_polling -v
tests/test_owned_asset_encoding.py::test_get_dashboard_html_reads_as_utf8 PASSED [ 50%]
tests/test_proxy_dashboard_stats_cache.py::test_dashboard_uses_cached_stats_and_lazy_history_feed_polling PASSED [100%]
======================== 2 passed, 1 warning in 0.16s =========================

uv run ruff check tests/test_dashboard_cache_ttl_playwright.py
All checks passed!
```

## Real Behavior Proof

- Environment: Playwright Chromium dashboard harness, dashboard template
served through the existing route interception used by the dashboard
tests, no live provider required.
- Exact command / steps: `uv run pytest
tests/test_dashboard_cache_ttl_playwright.py -k
"per_project_setup_url_uses_current_origin" -v`
- Observed result: `http://127.0.0.1:8788/dashboard` passed with the new
current-origin assertion, and `origin/main` failed the same assertion
because the page still rendered `ANTHROPIC_BASE_URL:
http://127.0.0.1:8787/p/<project-name>`. A separate browser check
against `http://headroom.local:9393/dashboard` also passed on the
patched branch.
- Not tested: full live `headroom proxy --port 8788` browser validation,
unless it is run during implementation.

## Review Readiness

- [x] I have performed a self-review
- [x] This PR is ready for human review

## Checklist

- [x] My code follows the project's style guidelines
- [x] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [x] I have updated the CHANGELOG.md if applicable

## Additional Notes

`CHANGELOG.md` is intentionally unchanged because this repo generates
changelog entries from conventional commits. The documentation checkbox
is satisfied by correcting the in-dashboard setup instruction.
2026-06-30 14:24:00 -05:00
Focused Instability
b7350aa29c
ci: run dashboard playwright tests in a dedicated job (#921)
## Summary

Closes #920. Follow-up noted in #915.

The dashboard Playwright tests guard on
`pytest.importorskip("playwright...")` and no CI job installs
playwright, so they have skipped on every CI run since they were added —
which is how the bitrot fixed in #915 went unnoticed.

This adds a `test-dashboard-ui` job to `ci.yml`, same shape as
`test-agno`:

- installs the prebuilt wheel `[dev]` + playwright, then `playwright
install --with-deps chromium`
- runs `pytest tests/test_dashboard_*_playwright.py` — the stub-based
tests only (all routes mocked via `page.route`, no network); the glob
also picks up the CVC panel tests from #913 once that merges
- sets `HEADROOM_PLAYWRIGHT_ARTIFACT_DIR` and uploads the captured
dashboard screenshots as a workflow artifact (7-day retention), so every
CI run leaves a visual record of the rendered dashboard

Deliberately excluded: `tests/test_dashboard/test_live_feed.py` — it
navigates to a live proxy on `localhost:8787` and would fail on a runner
with nothing listening. The main test shards keep skipping playwright
tests (playwright stays uninstalled there), so nothing double-runs.

## Testing

- `yaml.safe_load` parses the workflow; the `workflow-validation` CI job
(actionlint + act) runs on this PR since it touches `ci.yml`
- The test this job will run passes locally:
`tests/test_dashboard_cache_ttl_playwright.py` — 1 passed (chromium)
- This PR's own CI run exercises the new job end-to-end
2026-06-12 10:20:37 -05:00
JerrettDavis
a6787556be Add observed cache TTL metrics and dashboard coverage 2026-04-06 21:13:30 -05:00