mirror of
https://github.com/headroomlabs-ai/headroom.git
synced 2026-08-27 14:17:10 -04:00
7c9a032f50
## Description
Extracts CCR golden tool replay and fresh-definition canonicalization
from `headroom.proxy.helpers.apply_session_sticky_ccr_tool` into a
focused policy module. This keeps sticky CCR orchestration in helpers
while making the byte replay/regeneration behavior independently
testable.
Closes #
## Type of Change
- [ ] Bug fix (non-breaking change that fixes an issue)
- [ ] New feature (non-breaking change that adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Documentation update
- [ ] Performance improvement
- [x] Code refactoring (no functional changes)
## Changes Made
- Added `headroom.proxy.ccr_golden_policy` for replaying stored CCR
golden bytes and creating canonical fresh CCR tool definitions.
- Updated `apply_session_sticky_ccr_tool` to delegate CCR golden
replay/fresh definition policy while preserving tracker coordination and
logging decisions.
- Added direct tests for golden-byte replay, invalid/corrupt bytes,
non-UTF-8 bytes, and fresh canonical definition generation.
## Testing
- [x] Unit tests pass (`pytest`)
- [x] Linting passes (`ruff check .`)
- [x] Type checking passes (`mypy headroom`)
- [x] New tests added for new functionality
- [ ] Manual testing performed
### Test Output
```text
python -m pytest tests/test_ccr_golden_policy.py tests/test_ccr_tool_always_on.py tests/test_corrupt_golden_bytes_recovery.py tests/test_proxy/test_ccr_frozen_prefix_coupling.py
30 passed in 0.34s
python -m ruff check .
All checks passed!
python -m ruff format --check .
1069 files already formatted
python -m mypy headroom --ignore-missing-imports
Success: no issues found in 410 source files
gitleaks protect --staged --no-banner --redact
no leaks found
```
## Real Behavior Proof
- Environment: Windows, Python 3.13.13, clean worktree from
`headroomlabs/main` at `d2170b19`.
- Exact command / steps: Ran targeted CCR golden replay/sticky
injection/corrupt-byte regression tests plus ruff, ruff-format, mypy,
and staged gitleaks scan.
- Observed result: All targeted tests and local gates passed; staged
secret scan found no leaks.
- Not tested: Full Docker/native wrapper CI locally; covered by
repository CI.
## Review Readiness
- [x] I have performed a self-review
- [x] This PR is ready for human review
## Checklist
- [x] My code follows the project's style guidelines
- [x] I have performed a self-review of my code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] I have updated the CHANGELOG.md if applicable
## Screenshots (if applicable)
N/A.
## Additional Notes
Documentation and changelog updates are not applicable for this internal
refactor. The push reported existing default-branch Dependabot
vulnerabilities; this PR's staged gitleaks scan passed and CI security
checks are expected to validate the branch.
38 lines
1.3 KiB
Python
38 lines
1.3 KiB
Python
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
from headroom.ccr.tool_injection import CCR_TOOL_NAME, create_ccr_tool_definition
|
|
from headroom.proxy.ccr_golden_policy import (
|
|
create_fresh_ccr_tool_definition,
|
|
replay_golden_ccr_tool_definition,
|
|
serialize_ccr_tool_definition_canonical,
|
|
)
|
|
|
|
|
|
def test_replays_golden_definition_without_reserializing() -> None:
|
|
golden = b'{ "name" : "headroom_retrieve" , "description" : "client bytes" }'
|
|
|
|
replay = replay_golden_ccr_tool_definition(golden)
|
|
|
|
assert replay.tool_definition["name"] == CCR_TOOL_NAME
|
|
assert replay.canonical_bytes == golden
|
|
assert replay.used_golden_bytes is True
|
|
|
|
|
|
def test_rejects_invalid_golden_json() -> None:
|
|
with pytest.raises(ValueError):
|
|
replay_golden_ccr_tool_definition(b"not-json")
|
|
|
|
|
|
def test_rejects_non_utf8_golden_bytes() -> None:
|
|
with pytest.raises(UnicodeDecodeError):
|
|
replay_golden_ccr_tool_definition(b"\x80\x81")
|
|
|
|
|
|
def test_fresh_definition_uses_canonical_bytes() -> None:
|
|
replay = create_fresh_ccr_tool_definition("anthropic")
|
|
|
|
assert replay.tool_definition == create_ccr_tool_definition("anthropic")
|
|
assert replay.canonical_bytes == serialize_ccr_tool_definition_canonical(replay.tool_definition)
|
|
assert replay.used_golden_bytes is False
|