mirror of
https://github.com/headroomlabs-ai/headroom.git
synced 2026-08-27 14:17:10 -04:00
## Description
`headroom/providers/openai.py::_get_encoding` calls
`tiktoken.get_encoding` directly. tiktoken downloads missing
vocabularies via `requests.get` with **no timeout**, so on a network
that blackholes the vocab CDN (corporate firewall, SSL-intercepting
proxy), whichever thread first counts tokens for an OpenAI model — proxy
startup included — blocks indefinitely.
This is the provider-path hole left by #956: the tokenizer registry
already routes through a bounded loader
(`headroom/tokenizers/tiktoken_counter.py`, worker-thread load +
`HEADROOM_TIKTOKEN_LOAD_TIMEOUT_SECONDS`, default 10s) and falls back to
estimation, but the OpenAI provider path never got the same treatment.
Observed in production (Headroom Desktop fleet, Sentry): a proxy that
never finished booting, with a faulthandler dump wedged in
`tiktoken/registry.py` `get_encoding` on the main thread, reached from
the `headroom` CLI entrypoint via click. The desktop app now also
pre-seeds a persistent `TIKTOKEN_CACHE_DIR`, but the unbounded load
affects every deployment of the proxy, so it should be fixed here too.
Follow-up to #956.
## Type of Change
- [x] Bug fix (non-breaking change that fixes an issue)
- [ ] New feature (non-breaking change that adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Documentation update
- [ ] Performance improvement
- [ ] Code refactoring (no functional changes)
## Changes Made
- `_get_encoding` now routes through the bounded `load_encoding` from
`headroom.tokenizers.tiktoken_counter` instead of calling
`tiktoken.get_encoding` directly, so a stalled vocab download raises
`TiktokenLoadError` after the timeout instead of hanging the calling
thread.
- `OpenAIProvider.get_token_counter` catches `TiktokenLoadError` and
falls back to `EstimatingTokenCounter`, cached per model so later
requests never re-block on the same failed download — mirroring
`TokenizerRegistry._create_tiktoken`.
- `TIKTOKEN_AVAILABLE` uses `importlib.util.find_spec` (the module-level
`import tiktoken` became unused; same pattern as `LITELLM_AVAILABLE`).
- Two regression tests (`TestGuardedEncodingLoad`) covering the
bounded-raise path and the cached estimation fallback.
## Testing
- [x] Unit tests pass (`pytest`)
- [x] Linting passes (`ruff check .`)
- [x] Type checking passes (`mypy headroom`)
- [x] New tests added for new functionality
- [ ] Manual testing performed
### Test Output
```text
$ uv run --frozen --extra dev pytest tests/test_providers/ tests/test_tokenizers/
======================= 117 passed, 4 warnings in 27.95s =======================
$ uvx ruff check headroom/providers/openai.py tests/test_providers/test_openai.py
All checks passed!
$ uvx ruff format --check headroom/providers/openai.py tests/test_providers/test_openai.py
2 files already formatted
$ uv run --frozen --extra dev mypy headroom/providers/openai.py
Success: no issues found in 1 source file
```
## Real Behavior Proof
- Environment: macOS (arm64), Python 3.12, uv-managed venv, branch off
`upstream/main` (a6d4921e).
- Exact command / steps: the stalled download is simulated in
`TestGuardedEncodingLoad` by monkeypatching
`tiktoken_counter.load_encoding` to raise `TiktokenLoadError`;
`OpenAITokenCounter("gpt-4o")` then raises the bounded error, and
`OpenAIProvider.get_token_counter("gpt-4o")` returns a working
`EstimatingTokenCounter` and reuses the same instance on the second
call.
- Observed result: tests pass (see output above); with an empty tiktoken
on-disk cache, the encoding load path is identical to the one in the
production faulthandler dump.
- Not tested: an end-to-end run against a genuinely blackholed vocab CDN
(needs a firewalled network); the timeout mechanism itself is #956's
code, already covered by its own tests.
## Review Readiness
- [x] I have performed a self-review
- [x] This PR is ready for human review
## Checklist
- [x] My code follows the project's style guidelines
- [x] I have performed a self-review of my code
- [x] I commented my code, particularly in hard-to-understand areas
- [x] I made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I added tests that prove my fix is effective or that my feature
works
- [x] New and existing unit tests pass locally with my changes
- [ ] I updated CHANGELOG.md if applicable (N/A — release-please
generates it from the PR title; changelog-guard forbids manual edits)
## Screenshots (if applicable)
N/A — no UI change.
## Additional Notes
The estimation fallback is sticky for the process lifetime (per-model
cache + the loader's fail-fast set from #956): a network that recovers
mid-session keeps estimation until restart. That matches the registry's
existing behavior, so no new divergence is introduced.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: JD Davis <jd@jds-macbook-air.tail2a279.ts.net>
181 lines
7 KiB
Python
181 lines
7 KiB
Python
"""Tests for OpenAI provider."""
|
|
|
|
import pytest
|
|
|
|
from headroom.providers.openai import (
|
|
_get_encoding_name_for_model,
|
|
)
|
|
|
|
|
|
class TestOpenAITokenCounting:
|
|
def test_count_text_empty(self, openai_tokenizer):
|
|
assert openai_tokenizer.count_text("") == 0
|
|
|
|
def test_count_text_simple(self, openai_tokenizer):
|
|
count = openai_tokenizer.count_text("Hello world")
|
|
assert count > 0
|
|
assert count < 10 # Should be ~2 tokens
|
|
|
|
def test_count_text_with_special_chars(self, openai_tokenizer):
|
|
text = "Hello 🌍! Special chars: @#$%"
|
|
count = openai_tokenizer.count_text(text)
|
|
assert count > 0
|
|
|
|
def test_count_text_allows_literal_special_tokens(self, openai_tokenizer):
|
|
"""count_text must not raise on literal tiktoken special-token strings.
|
|
|
|
Regression: a /v1/responses request whose context contained the literal
|
|
"<|endoftext|>" made tiktoken raise ValueError (default
|
|
disallowed_special="all"), which the proxy turned into an HTTP 413
|
|
compression_refused. Markers must be counted as ordinary text instead.
|
|
"""
|
|
text = "before <|endoftext|> after"
|
|
count = openai_tokenizer.count_text(text)
|
|
assert count > openai_tokenizer.count_text("before after")
|
|
|
|
def test_count_messages_single(self, openai_tokenizer):
|
|
messages = [{"role": "user", "content": "Hello"}]
|
|
count = openai_tokenizer.count_messages(messages)
|
|
assert count > 0
|
|
|
|
def test_count_messages_with_tools(self, openai_tokenizer):
|
|
messages = [
|
|
{"role": "user", "content": "Search"},
|
|
{
|
|
"role": "assistant",
|
|
"tool_calls": [{"id": "call_1", "function": {"name": "search", "arguments": "{}"}}],
|
|
},
|
|
]
|
|
count = openai_tokenizer.count_messages(messages)
|
|
assert count > 10 # Tool calls add overhead
|
|
|
|
def test_count_message_overhead(self, openai_tokenizer):
|
|
# Each message has ~4 tokens overhead
|
|
msg = {"role": "user", "content": ""}
|
|
count = openai_tokenizer.count_message(msg)
|
|
assert count >= 4
|
|
|
|
|
|
class TestOpenAIModelLimits:
|
|
def test_get_context_limit_gpt4o(self, openai_provider):
|
|
assert openai_provider.get_context_limit("gpt-4o") == 128000
|
|
|
|
def test_get_context_limit_o1(self, openai_provider):
|
|
assert openai_provider.get_context_limit("o1") == 200000
|
|
|
|
def test_get_context_limit_unknown_model(self, openai_provider):
|
|
# Unknown models now get a fallback value instead of raising
|
|
limit = openai_provider.get_context_limit("unknown-model")
|
|
assert limit == 128000 # Default fallback
|
|
|
|
def test_supports_model_known(self, openai_provider):
|
|
assert openai_provider.supports_model("gpt-4o") is True
|
|
assert openai_provider.supports_model("gpt-4o-mini") is True
|
|
|
|
def test_supports_model_unknown(self, openai_provider):
|
|
assert openai_provider.supports_model("claude-3") is False
|
|
|
|
|
|
class TestOpenAICostEstimation:
|
|
def test_estimate_cost_input_only(self, openai_provider):
|
|
cost = openai_provider.estimate_cost(
|
|
input_tokens=1000000,
|
|
output_tokens=0,
|
|
model="gpt-4o",
|
|
)
|
|
assert cost == pytest.approx(2.50, rel=0.01)
|
|
|
|
def test_estimate_cost_with_output(self, openai_provider):
|
|
cost = openai_provider.estimate_cost(
|
|
input_tokens=1000000,
|
|
output_tokens=1000000,
|
|
model="gpt-4o",
|
|
)
|
|
# $2.50 input + $10.00 output = $12.50
|
|
assert cost == pytest.approx(12.50, rel=0.01)
|
|
|
|
def test_estimate_cost_with_cached(self, openai_provider):
|
|
cost = openai_provider.estimate_cost(
|
|
input_tokens=1000000,
|
|
output_tokens=0,
|
|
model="gpt-4o",
|
|
cached_tokens=500000,
|
|
)
|
|
# 500K regular @ $2.50/M = $1.25, 500K cached @ $1.25/M = $0.625
|
|
assert cost == pytest.approx(1.875, rel=0.01)
|
|
|
|
def test_estimate_cost_unknown_model(self, openai_provider):
|
|
# Unknown models now get fallback pricing (gpt-4o tier)
|
|
cost = openai_provider.estimate_cost(
|
|
input_tokens=1000,
|
|
output_tokens=1000,
|
|
model="unknown-model",
|
|
)
|
|
# Fallback uses gpt-4o pricing: $2.50/M input + $10/M output
|
|
# = (1000/1M * 2.50) + (1000/1M * 10.00) = 0.0025 + 0.01 = 0.0125
|
|
assert cost == pytest.approx(0.0125, rel=0.01)
|
|
|
|
|
|
class TestEncodingSelection:
|
|
def test_gpt4o_uses_o200k(self):
|
|
assert _get_encoding_name_for_model("gpt-4o") == "o200k_base"
|
|
|
|
def test_gpt4_uses_cl100k(self):
|
|
assert _get_encoding_name_for_model("gpt-4") == "cl100k_base"
|
|
|
|
def test_versioned_model_prefix_match(self):
|
|
assert _get_encoding_name_for_model("gpt-4o-2024-11-20") == "o200k_base"
|
|
|
|
def test_unknown_model_uses_fallback(self):
|
|
# Unknown models now get a fallback encoding instead of raising
|
|
encoding = _get_encoding_name_for_model("completely-unknown")
|
|
assert encoding == "o200k_base" # Default fallback
|
|
|
|
|
|
class TestGuardedEncodingLoad:
|
|
"""The provider must never hang on tiktoken's unbounded vocab download.
|
|
|
|
Regression for the OpenAI-provider hole in GH #956: `_get_encoding` called
|
|
`tiktoken.get_encoding` directly, so a stalled vocab download blocked the
|
|
calling thread (proxy startup included) forever instead of timing out.
|
|
"""
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _clear_encoding_cache(self):
|
|
from headroom.providers import openai as openai_module
|
|
|
|
openai_module._get_encoding.cache_clear()
|
|
yield
|
|
openai_module._get_encoding.cache_clear()
|
|
|
|
def test_get_encoding_routes_through_bounded_loader(self, monkeypatch):
|
|
from headroom.providers.openai import OpenAITokenCounter
|
|
from headroom.tokenizers import tiktoken_counter
|
|
|
|
seen: list[str] = []
|
|
|
|
def fake_load_encoding(name: str):
|
|
seen.append(name)
|
|
raise tiktoken_counter.TiktokenLoadError(f"{name} load timed out")
|
|
|
|
monkeypatch.setattr(tiktoken_counter, "load_encoding", fake_load_encoding)
|
|
with pytest.raises(tiktoken_counter.TiktokenLoadError):
|
|
OpenAITokenCounter(model="gpt-4o")
|
|
assert seen == ["o200k_base"]
|
|
|
|
def test_get_token_counter_falls_back_to_estimation(self, monkeypatch):
|
|
from headroom.providers.openai import OpenAIProvider
|
|
from headroom.tokenizers import tiktoken_counter
|
|
from headroom.tokenizers.estimator import EstimatingTokenCounter
|
|
|
|
def fake_load_encoding(name: str):
|
|
raise tiktoken_counter.TiktokenLoadError(f"{name} load timed out")
|
|
|
|
monkeypatch.setattr(tiktoken_counter, "load_encoding", fake_load_encoding)
|
|
provider = OpenAIProvider()
|
|
counter = provider.get_token_counter("gpt-4o")
|
|
assert isinstance(counter, EstimatingTokenCounter)
|
|
assert counter.count_text("hello world") > 0
|
|
# Cached per model: later requests reuse the fallback instead of
|
|
# re-blocking on the failed download.
|
|
assert provider.get_token_counter("gpt-4o") is counter
|