mirror of
https://github.com/headroomlabs-ai/headroom.git
synced 2026-08-27 14:17:10 -04:00
## Description
`headroom --version` and the dashboard show `0.32.0` from a source
checkout, but the latest published release is `0.31.0`. That `0.32.0` is
not a real release: on a git checkout `get_version()` predicts the
*next* release from conventional commits since the last tag (`v0.31.0` +
`feat:` commits → `0.32.0`) and renders it identically to a shipped
version — so a dev build looks published.
This appends `-dev` on the source-checkout path so a dev build is never
mistaken for the published release.
Closes #
## Type of Change
- [x] Bug fix (non-breaking change that fixes an issue)
## Changes Made
- `headroom/_version.py`: the source-checkout branch of `get_version()`
now returns `f"{source_version}-dev"`.
- `tests/test_package_init_lazy.py`: updated the source-tree version
test to assert the `-dev` suffix.
Released installs are unaffected: pip wheels and Docker images with a
baked `BUILD_VERSION` never take the source-checkout path, so they still
report clean release versions (`0.31.0` / `v0.31.0`). The suffix makes
`is_release_version()` return `False` and `normalize_release_version()`
return `None`, which every comparison site already handles — e.g.
`wrap.py`'s `_proxy_needs_version_restart` requires both sides to
normalize, so a dev build short-circuits to "no restart" (no behavior
change).
## Testing
- [x] Unit tests pass (`pytest`)
- [x] Linting passes (`ruff check .`)
- [x] Type checking passes (`mypy headroom`)
- [x] New tests added for new functionality (updated the existing
source-tree test)
- [x] Manual testing performed
### Test Output
```text
$ python -m pytest tests/test_package_init_lazy.py tests/test_cli_doctor.py -q
============================== 12 passed in 1.79s ==============================
============================== 51 passed in 0.56s ==============================
$ ruff check headroom/_version.py tests/test_package_init_lazy.py
All checks passed!
$ mypy headroom/_version.py
Success: no issues found in 1 source file
```
## Real Behavior Proof
- Environment: local source checkout (macOS), `.venv`, latest release
tag `v0.31.0`
- Exact command / steps: `headroom --version`
- Observed result:
- Before: `headroom, version 0.32.0` — indistinguishable from a release
- After: `headroom, version 0.32.0-dev`
- Not tested: behavior inside a built Docker image / installed pip wheel
— unchanged by design, since those paths never compute a source-tree
version.
## Review Readiness
- [x] I have performed a self-review
- [x] This PR is ready for human review
## Checklist
- [x] My code follows the project's style guidelines
- [x] I have performed a self-review of my code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] I have updated the CHANGELOG.md if applicable
## Additional Notes
Scope kept to a bare `-dev` marker, which answers "is this a release?".
Appending the short git SHA (`-dev+g<sha>`) to distinguish individual
dev builds in bug reports is an easy follow-up if wanted. Docs/CHANGELOG
unchecked as N/A for a dev-only version-string fix.
---------
Co-authored-by: JerrettDavis <mxjerrett@gmail.com>
309 lines
9.7 KiB
Python
309 lines
9.7 KiB
Python
"""Regression tests for lightweight package bootstrap."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
import os
|
|
import subprocess
|
|
import sys
|
|
import textwrap
|
|
import types
|
|
from importlib.metadata import PackageNotFoundError
|
|
from pathlib import Path
|
|
from unittest.mock import patch
|
|
|
|
import headroom._version as version_module
|
|
|
|
|
|
def test_headroom_import_stays_lazy() -> None:
|
|
script = textwrap.dedent(
|
|
"""
|
|
import json
|
|
import sys
|
|
|
|
import headroom
|
|
|
|
print(json.dumps({
|
|
"version": headroom.__version__,
|
|
"cache_loaded": "headroom.cache" in sys.modules,
|
|
"models_registry_loaded": "headroom.models.registry" in sys.modules,
|
|
"memory_loaded": "headroom.memory" in sys.modules,
|
|
}))
|
|
"""
|
|
)
|
|
|
|
result = subprocess.run(
|
|
[sys.executable, "-c", script],
|
|
capture_output=True,
|
|
text=True,
|
|
check=True,
|
|
)
|
|
|
|
data = json.loads(result.stdout.strip())
|
|
# Version is a non-empty string; don't hardcode a specific value.
|
|
assert isinstance(data["version"], str) and data["version"]
|
|
assert data["cache_loaded"] is False
|
|
assert data["models_registry_loaded"] is False
|
|
assert data["memory_loaded"] is False
|
|
|
|
|
|
def test_version_prefers_installed_distribution_metadata() -> None:
|
|
with (
|
|
patch.object(version_module, "_source_root", return_value=None),
|
|
patch.object(version_module, "version", return_value="9.8.7") as package_version,
|
|
):
|
|
assert version_module.get_version() == "9.8.7"
|
|
|
|
package_version.assert_called_once_with("headroom-ai")
|
|
|
|
|
|
def test_version_reports_unknown_when_distribution_metadata_is_missing() -> None:
|
|
with (
|
|
patch.object(version_module, "_source_root", return_value=None),
|
|
patch.object(version_module, "version", side_effect=PackageNotFoundError),
|
|
):
|
|
assert version_module.get_version() == version_module.UNKNOWN_VERSION
|
|
|
|
|
|
def test_version_prefers_explicit_build_env(monkeypatch) -> None:
|
|
monkeypatch.setenv("HEADROOM_BUILD_VERSION", "source-build")
|
|
|
|
with patch.object(version_module, "version", return_value="9.8.7") as package_version:
|
|
assert version_module.get_version() == "source-build"
|
|
|
|
package_version.assert_not_called()
|
|
|
|
|
|
def test_version_label_helpers_only_prefix_release_versions() -> None:
|
|
assert version_module.is_release_version("0.29.0") is True
|
|
assert version_module.is_release_version("v0.29.0") is True
|
|
assert version_module.normalize_release_version("v0.29.0") == "0.29.0"
|
|
assert version_module.is_release_version("source-build+g6266a1d774b5") is False
|
|
assert version_module.is_release_version("source-build+sha.abcdef123456") is False
|
|
assert version_module.is_release_version("6266a1d") is False
|
|
assert version_module.is_release_version("0.29.0+gabcdef0") is False
|
|
|
|
assert version_module.format_version_label("0.29.0") == "v0.29.0"
|
|
assert version_module.format_version_label("v0.29.0") == "v0.29.0"
|
|
assert (
|
|
version_module.format_version_label("source-build+sha.abcdef123456")
|
|
== "source-build+sha.abcdef123456"
|
|
)
|
|
assert (
|
|
version_module.format_version_label("source-build+g6266a1d774b5")
|
|
== "source-build+g6266a1d774b5"
|
|
)
|
|
assert version_module.format_version_label("6266a1d") == "6266a1d"
|
|
assert version_module.format_version_label(None) == version_module.UNKNOWN_VERSION
|
|
|
|
|
|
def test_version_uses_packaged_build_metadata(
|
|
monkeypatch,
|
|
) -> None:
|
|
build_info = types.ModuleType("headroom._build_info")
|
|
build_info.BUILD_VERSION = "0.29.0+gabcdef0"
|
|
monkeypatch.setitem(sys.modules, "headroom._build_info", build_info)
|
|
|
|
with (
|
|
patch.object(version_module, "_source_root", return_value=None),
|
|
patch.object(version_module, "version", return_value="0.29.0") as package_version,
|
|
):
|
|
assert version_module.get_version() == "0.29.0+gabcdef0"
|
|
|
|
package_version.assert_not_called()
|
|
|
|
|
|
def test_observability_version_uses_runtime_version(monkeypatch) -> None:
|
|
from headroom.observability import metrics as metrics_module
|
|
|
|
monkeypatch.setattr(
|
|
metrics_module,
|
|
"get_version",
|
|
lambda: "source-build+sha.abcdef123456",
|
|
)
|
|
|
|
assert metrics_module._headroom_version() == "source-build+sha.abcdef123456"
|
|
|
|
|
|
def test_version_prefers_source_tree_release_history() -> None:
|
|
with (
|
|
patch.object(version_module, "_source_root", return_value=Path(".")),
|
|
patch.object(version_module, "_source_tree_version", return_value="0.21.17"),
|
|
patch.object(version_module, "version", return_value="0.9.1") as package_version,
|
|
):
|
|
# Source checkouts are marked -dev so a dev build is never mistaken
|
|
# for the published release.
|
|
assert version_module.get_version() == "0.21.17-dev"
|
|
|
|
package_version.assert_not_called()
|
|
|
|
|
|
def test_proxy_package_import_does_not_eagerly_load_server() -> None:
|
|
script = textwrap.dedent(
|
|
"""
|
|
import json
|
|
import sys
|
|
|
|
import headroom.proxy
|
|
|
|
print(json.dumps({
|
|
"server_loaded": "headroom.proxy.server" in sys.modules,
|
|
}))
|
|
"""
|
|
)
|
|
|
|
result = subprocess.run(
|
|
[sys.executable, "-c", script],
|
|
capture_output=True,
|
|
text=True,
|
|
check=True,
|
|
)
|
|
|
|
data = json.loads(result.stdout.strip())
|
|
assert data["server_loaded"] is False
|
|
|
|
|
|
def test_codex_package_import_stays_runtime_only() -> None:
|
|
script = textwrap.dedent(
|
|
"""
|
|
import json
|
|
import sys
|
|
|
|
import headroom.providers.codex
|
|
|
|
print(json.dumps({
|
|
"images_loaded": "headroom.providers.codex.images" in sys.modules,
|
|
"model_metadata_loaded": "headroom.providers.codex.model_metadata" in sys.modules,
|
|
"responses_loaded": "headroom.providers.codex.responses" in sys.modules,
|
|
}))
|
|
"""
|
|
)
|
|
|
|
result = subprocess.run(
|
|
[sys.executable, "-c", script],
|
|
capture_output=True,
|
|
text=True,
|
|
check=True,
|
|
)
|
|
|
|
data = json.loads(result.stdout.strip())
|
|
assert data == {
|
|
"images_loaded": False,
|
|
"model_metadata_loaded": False,
|
|
"responses_loaded": False,
|
|
}
|
|
|
|
|
|
def test_proxy_server_import_skips_litellm_backend() -> None:
|
|
script = textwrap.dedent(
|
|
"""
|
|
import json
|
|
import sys
|
|
|
|
import headroom.proxy.server
|
|
|
|
print(json.dumps({
|
|
"litellm_backend_loaded": "headroom.backends.litellm" in sys.modules,
|
|
"anyllm_backend_loaded": "headroom.backends.anyllm" in sys.modules,
|
|
"litellm_loaded": "litellm" in sys.modules,
|
|
}))
|
|
"""
|
|
)
|
|
|
|
result = subprocess.run(
|
|
[sys.executable, "-c", script],
|
|
capture_output=True,
|
|
text=True,
|
|
check=True,
|
|
)
|
|
|
|
data = json.loads(result.stdout.strip())
|
|
assert data["litellm_backend_loaded"] is False
|
|
assert data["anyllm_backend_loaded"] is False
|
|
assert data["litellm_loaded"] is False
|
|
|
|
|
|
def test_dynamic_detector_import_skips_optional_ml_dependencies(tmp_path: Path) -> None:
|
|
(tmp_path / "spacy.py").write_text("", encoding="utf-8")
|
|
(tmp_path / "numpy.py").write_text("", encoding="utf-8")
|
|
(tmp_path / "torch.py").write_text("", encoding="utf-8")
|
|
sentence_transformers_dir = tmp_path / "sentence_transformers"
|
|
sentence_transformers_dir.mkdir()
|
|
(sentence_transformers_dir / "__init__.py").write_text(
|
|
"import torch\n\nclass SentenceTransformer:\n pass\n",
|
|
encoding="utf-8",
|
|
)
|
|
|
|
script = textwrap.dedent(
|
|
"""
|
|
import json
|
|
import sys
|
|
|
|
import headroom.cache.dynamic_detector
|
|
|
|
print(json.dumps({
|
|
"spacy_loaded": "spacy" in sys.modules,
|
|
"sentence_transformers_loaded": "sentence_transformers" in sys.modules,
|
|
"torch_loaded": "torch" in sys.modules,
|
|
}))
|
|
"""
|
|
)
|
|
|
|
env = os.environ.copy()
|
|
env["PYTHONPATH"] = str(tmp_path)
|
|
|
|
result = subprocess.run(
|
|
[sys.executable, "-c", script],
|
|
capture_output=True,
|
|
text=True,
|
|
check=True,
|
|
cwd=Path(__file__).resolve().parents[1],
|
|
env=env,
|
|
)
|
|
|
|
data = json.loads(result.stdout.strip())
|
|
assert data["spacy_loaded"] is False
|
|
assert data["sentence_transformers_loaded"] is False
|
|
assert data["torch_loaded"] is False
|
|
|
|
|
|
def test_compress_spreadsheet_public_import_survives_ort_pin() -> None:
|
|
"""`from headroom import compress_spreadsheet` stays eagerly exported, and the
|
|
Windows ORT dylib pin still runs before the `.compress` import.
|
|
|
|
The pin (`ensure_ort_dylib_pinned`) was inserted above the eager `.compress`
|
|
import; restoring `compress_spreadsheet` to that line must not reorder it
|
|
relative to the pin. The `__dict__` check distinguishes the eager import from
|
|
the lazy `_LAZY_EXPORTS` fallback, which would also resolve the name.
|
|
"""
|
|
script = textwrap.dedent(
|
|
"""
|
|
import json
|
|
|
|
import headroom
|
|
from headroom import compress_spreadsheet
|
|
|
|
print(json.dumps({
|
|
"eager": "compress_spreadsheet" in headroom.__dict__,
|
|
"callable": callable(compress_spreadsheet),
|
|
}))
|
|
"""
|
|
)
|
|
|
|
result = subprocess.run(
|
|
[sys.executable, "-c", script],
|
|
capture_output=True,
|
|
text=True,
|
|
check=True,
|
|
)
|
|
|
|
data = json.loads(result.stdout.strip())
|
|
assert data["eager"] is True
|
|
assert data["callable"] is True
|
|
|
|
# ORT pin must precede the `.compress` import, which must still list the helper.
|
|
src = (Path(version_module.__file__).parent / "__init__.py").read_text(encoding="utf-8")
|
|
pin = src.index("ensure_ort_dylib_pinned()")
|
|
compress_import = src.index("from .compress import")
|
|
assert pin < compress_import
|
|
assert "compress_spreadsheet" in src[compress_import : compress_import + 120]
|