mirror of
https://github.com/headroomlabs-ai/headroom.git
synced 2026-08-27 14:17:10 -04:00
99c874d423
## Description Fix the PR health label job so `status: ci failing` reflects the latest check attempt for each check, not historical failed or cancelled attempts that still appear in `statusCheckRollup`. This showed up on #984: the current checks were green, but the label job kept `status: ci failing` because older failed template runs were still present in the rollup payload. ## Type of Change - [x] Bug fix (non-breaking change that fixes an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Performance improvement - [ ] Code refactoring (no functional changes) ## Changes Made - Added a small `.github/scripts/pr-health-labels.py` helper that groups check-rollup entries by logical check name and evaluates only the newest entry for each check. - Updated the PR health workflow label job to call the helper instead of treating any historical failing rollup entry as current failure. - Added regression tests for historical failures followed by latest passing attempts, plus current latest failure behavior. ## Testing - [x] Unit tests pass (`pytest`) - [x] New tests added for new functionality - [x] Manual testing performed ### Test Output ```text PYTEST_ADDOPTS='-p no:cacheprovider' pytest scripts/tests -q 47 passed, 1 warning in 0.39s python .github/scripts/pr-health-labels.py --state-json '<payload with old FAILURE and latest SUCCESS>' passing data=$(gh pr view 984 --repo chopratejas/headroom --json statusCheckRollup) python .github/scripts/pr-health-labels.py --state-json "$data" passing ``` ## Real Behavior Proof - Environment: macOS local checkout, Python 3.11.7, live GitHub PR #984 check-rollup payload fetched with `gh pr view`. - Exact command / steps: Added regression coverage for historical failed/cancelled check runs followed by latest successful runs, ran the scripts test suite, and evaluated live PR #984's `statusCheckRollup` with the new helper. - Observed result: The helper returns `passing` for #984's live payload even though older failed/cancelled check runs are still present, while still returning `failing` when the latest attempt for a check failed. - Not tested: A full GitHub Actions run of the updated workflow on upstream before merge; this PR should exercise the workflow on itself. ## Review Readiness - [x] I have performed a self-review - [x] This PR is ready for human review
94 lines
3 KiB
Python
94 lines
3 KiB
Python
"""Tests for pr-health-labels.py."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import importlib.util
|
|
import sys
|
|
from pathlib import Path
|
|
|
|
|
|
def _load_module():
|
|
script = Path(__file__).parents[2] / ".github" / "scripts" / "pr-health-labels.py"
|
|
spec = importlib.util.spec_from_file_location("pr_health_labels", script)
|
|
assert spec is not None
|
|
assert spec.loader is not None
|
|
module = importlib.util.module_from_spec(spec)
|
|
sys.modules[spec.name] = module
|
|
spec.loader.exec_module(module)
|
|
return module
|
|
|
|
|
|
def test_check_state_ignores_historical_failures_when_latest_attempt_passed() -> None:
|
|
module = _load_module()
|
|
payload = {
|
|
"statusCheckRollup": [
|
|
{
|
|
"__typename": "CheckRun",
|
|
"workflowName": "PR Governance",
|
|
"name": "template",
|
|
"conclusion": "FAILURE",
|
|
"startedAt": "2026-06-14T13:38:35Z",
|
|
"completedAt": "2026-06-14T13:38:46Z",
|
|
},
|
|
{
|
|
"__typename": "CheckRun",
|
|
"workflowName": "PR Governance",
|
|
"name": "template",
|
|
"conclusion": "SUCCESS",
|
|
"startedAt": "2026-06-14T13:43:26Z",
|
|
"completedAt": "2026-06-14T13:43:35Z",
|
|
},
|
|
{
|
|
"__typename": "CheckRun",
|
|
"workflowName": "PR Governance",
|
|
"name": "label",
|
|
"conclusion": "CANCELLED",
|
|
"startedAt": "2026-06-14T13:43:18Z",
|
|
"completedAt": "2026-06-14T13:43:24Z",
|
|
},
|
|
{
|
|
"__typename": "CheckRun",
|
|
"workflowName": "PR Governance",
|
|
"name": "label",
|
|
"conclusion": "SUCCESS",
|
|
"startedAt": "2026-06-14T13:43:26Z",
|
|
"completedAt": "2026-06-14T13:43:35Z",
|
|
},
|
|
{
|
|
"__typename": "CheckRun",
|
|
"workflowName": "",
|
|
"name": "GitGuardian Security Checks",
|
|
"conclusion": "SUCCESS",
|
|
"startedAt": "2026-06-14T13:38:32Z",
|
|
"completedAt": "2026-06-14T13:39:04Z",
|
|
},
|
|
]
|
|
}
|
|
|
|
assert module.check_state(payload) == "passing"
|
|
|
|
|
|
def test_check_state_fails_when_latest_attempt_failed() -> None:
|
|
module = _load_module()
|
|
payload = {
|
|
"statusCheckRollup": [
|
|
{
|
|
"__typename": "CheckRun",
|
|
"workflowName": "PR Governance",
|
|
"name": "template",
|
|
"conclusion": "SUCCESS",
|
|
"startedAt": "2026-06-14T13:38:35Z",
|
|
"completedAt": "2026-06-14T13:38:46Z",
|
|
},
|
|
{
|
|
"__typename": "CheckRun",
|
|
"workflowName": "PR Governance",
|
|
"name": "template",
|
|
"conclusion": "FAILURE",
|
|
"startedAt": "2026-06-14T13:43:26Z",
|
|
"completedAt": "2026-06-14T13:43:35Z",
|
|
},
|
|
]
|
|
}
|
|
|
|
assert module.check_state(payload) == "failing"
|