mirror of
https://github.com/headroomlabs-ai/headroom.git
synced 2026-08-27 14:17:10 -04:00
## Description
A data-driven push for better compression savings without accuracy loss,
in four parts: expose and tune the Rust compressor knobs, harden the CCR
retrieval store, add traffic-audit tooling that sizes opportunities from
real transcripts, and introduce **read maturation** — a new,
live-validated mechanism that compresses Read outputs *before* they ever
enter the provider prefix cache.
## Type of Change
- [x] Bug fix (non-breaking change that fixes an issue)
- [x] New feature (non-breaking change that adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Documentation update
- [x] Performance improvement
- [ ] Code refactoring (no functional changes)
## Changes Made
### 1. Rust compressor extraction
- Expose `lossless_min_savings_ratio` end-to-end and lower the default
0.30 → 0.15 (lockstep across Rust, PyO3, and both Python config classes)
so the lossless Table/CSV compaction path wins more often.
- Expose the `CompactConfig` heuristics (core-field fraction,
heterogeneity ratio, flatten cap, bucket bounds) through PyO3 + Python.
- `SearchCompressor` grouped-by-file output (`rg --heading` style — path
once per file instead of per match). Library default off; the proxy
enables it in token mode.
- Complete `factor_out_constants`: constant fields now emit once in a
`_constant_fields` sentinel with slim rows (defensive per-item value
match; default off).
- `ContentRouter` accepts a SmartCrusher config override and the
search-grouping knob.
### 2. CCR store hardening
- Session-scale TTL: 300s → 1800s (CCRConfig, CompressionEntry,
CompressionStore, Rust `DEFAULT_TTL` — lockstep).
- **SQLite is the default CCR backend** (`~/.headroom/ccr_store.db`,
WAL): survives proxy restarts and is shared across workers.
`HEADROOM_CCR_BACKEND=memory` opts out.
- Multi-worker safety: `busy_timeout`, and corruption detection narrowed
so transient `SQLITE_BUSY` errors can never trigger database deletion.
- Data-at-rest hygiene: `chmod 600` on db + sidecars, expired rows swept
at open.
- Retrieval-miss messages are actionable (re-read the file / re-run the
command).
### 3. Traffic audit tooling (measure before tuning)
- `headroom audit-reads`: sizes Read opportunities from local Claude
Code transcripts (read share, stale %, line-number overhead, context
residency, cache-death windows).
- `--simulate-maturation`: Mechanism B risk sizing (re-read rates,
never-touched-again share, quiesce coverage, at-risk edits).
- `--codex`: shell-read classifier for Codex transcripts (rtk-wrapper
aware, workdir resolution).
- Findings that shaped this PR (81 sessions): Reads are 67% of tool
bytes; median Read lingers 118 turns (~13x lifetime cost); a prototyped
repeat-Read dedup measured 0.1% and was **removed** rather than shipped
as dead code.
### 4. Read maturation (Mechanism B) — experimental, default OFF
- Activity-based: a fresh large Read is held **out** of the provider
cache (trailing breakpoint relocated before it), stays verbatim while
its file is active, and matures into a CCR-backed marker once the file
is quiet for `quiesce_turns` (default 5; `max_hold_turns` bounds busy
files).
- Only the final compressed form ever enters the cache — **no cached
byte is ever mutated**; matured markers replay byte-identically.
- Wired into the Anthropic handler behind `--read-maturation` /
`HEADROOM_READ_MATURATION=1`; session state rides on the prefix tracker;
advisory (can never fail a request).
- Live-validated against the Anthropic API: held content excluded from
cache_creation; after maturation the prior cached prefix still served —
the no-bust invariant holds end-to-end.
### 5. Rebase / CI fixups (this update)
- Rebased onto latest `main` (was 28 commits behind): picks up `ci: pass
CODECOV_TOKEN to coverage uploads (#968)`, which is what was turning the
4 test shards red — the tests themselves passed (1528) but the post-test
codecov upload exited non-zero on a protected branch.
- Resolved the duplicate `lossless_min_savings_ratio` that two
independent main/branch additions left in `SmartCrusherConfig` and the
Rust-config kwarg (import-time `SyntaxError` + mypy `no-redef`).
- Aligned CCR tests with the new defaults (SQLite backend, 1800s TTL)
across `test_ccr`, `test_adapter_hooks`, `test_compression_store`,
`test_proxy_ccr`, and the lossy row-drop bridge test.
## Testing
<!-- Check what you actually ran, then paste the real command output
below. -->
- [x] Unit tests pass (`pytest`)
- [x] Linting passes (`ruff check .`)
- [x] Type checking passes (`mypy headroom`)
- [x] New tests added for new functionality
- [ ] Manual testing performed
### Test Output
```text
$ python -m pytest tests/test_proxy_ccr.py tests/test_ccr.py tests/test_compression_store.py tests/test_adapter_hooks.py tests/test_ccr_row_drop_store_bridge.py -q
170 passed, 4 warnings in 42.49s
$ python -m pytest tests/test_audit_reads.py tests/test_audit_codex.py tests/test_read_maturation.py tests/test_transforms_content_router.py tests/test_smart_crusher_toin_attachment.py -q
83 passed
$ mypy headroom/
Success: no issues found in 365 source files
$ python -m compileall headroom/ -q
COMPILE-OK
# CI (run 27488990477, pre-rebase head): all 4 shards ran to completion —
# "1528 passed, 120 skipped, 4922 deselected"
# The red shards were the codecov upload step, not test failures; fixed by
# the #968 rebase above.
```
## Real Behavior Proof
- Environment: macOS (darwin), Python 3.12 venv; branch
`feat/compression-extraction` rebased onto `origin/main` (head
7cb0f43b); GitHub Actions CI run 27488990477 for the test shards
- Exact command / steps: rebased onto latest main (clean, 13 commits
replayed, 0 conflicts); ran the pytest suites and mypy above locally;
inspected CI shard logs to confirm the failure was the codecov upload,
not the test phase
- Observed result: 253 targeted tests pass locally; mypy clean on 365
files; CI test phase reports `1528 passed, 120 skipped`; the only red
step (codecov `upload-coverage` → "Token required because branch is
protected") is resolved by the rebased-in #968 CODECOV_TOKEN fix
- Not tested: the read-maturation live-API no-bust validation
(`tests/test_live/`) was not re-run in this rebase pass (requires
provider keys); it was validated when the feature first landed, and no
maturation code changed in the rebase — only CCR-default test assertions
and the duplicate-field resolution
## Review Readiness
- [x] I have performed a self-review
- [x] This PR is ready for human review
## Checklist
- [x] My code follows the project's style guidelines
- [x] I have performed a self-review of my code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] I have updated the CHANGELOG.md if applicable
## Additional Notes
CHANGELOG is generated by release-please from the conventional commits,
so the CHANGELOG box is intentionally left unchecked. "Manual testing
performed" is unchecked deliberately — see `Real Behavior Proof` → `Not
tested` for the exact boundary (the live-API maturation validation was
not re-run in this rebase pass).
### Follow-ups (tracked, not in this PR)
- Mechanism B provider extensions: OpenAI-family wiring (no breakpoint
hold — bounded near-tail bust) and the Codex runtime read-detector (the
audit classifier is the prototype).
- Pilot enablement playbook: run `audit-reads --simulate-maturation` on
target traffic → pick `quiesce_turns` → enable via env → watch cache hit
rate + `read_maturation:N` transform tags.
229 lines
7.9 KiB
Python
229 lines
7.9 KiB
Python
"""Tests for the SQLite CCR backend and session-scale TTL defaults.
|
|
|
|
The SQLite backend is the default for `get_compression_store()` because the
|
|
30-minute TTL assumes entries survive proxy restarts and are visible across
|
|
worker processes — neither holds for the in-memory dict.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import os
|
|
import sqlite3
|
|
import time
|
|
|
|
import pytest
|
|
|
|
from headroom.cache.backends.sqlite import SQLiteBackend
|
|
from headroom.cache.compression_store import CompressionEntry, CompressionStore
|
|
|
|
|
|
def make_entry(hash_key: str = "h1", content: str = "x" * 600, ttl: int = 1800) -> CompressionEntry:
|
|
return CompressionEntry(
|
|
hash=hash_key,
|
|
original_content=content,
|
|
compressed_content="c",
|
|
original_tokens=100,
|
|
compressed_tokens=10,
|
|
original_item_count=50,
|
|
compressed_item_count=5,
|
|
tool_name="Read",
|
|
tool_call_id="t1",
|
|
query_context=None,
|
|
created_at=time.time(),
|
|
ttl=ttl,
|
|
)
|
|
|
|
|
|
@pytest.fixture
|
|
def db_path(tmp_path):
|
|
return tmp_path / "ccr_test.db"
|
|
|
|
|
|
class TestSQLiteBackend:
|
|
def test_crud_roundtrip(self, db_path):
|
|
b = SQLiteBackend(db_path)
|
|
entry = make_entry()
|
|
b.set("h1", entry)
|
|
|
|
got = b.get("h1")
|
|
assert got is not None
|
|
assert got.original_content == entry.original_content
|
|
assert got.tool_name == "Read"
|
|
assert got.ttl == 1800
|
|
|
|
assert b.exists("h1")
|
|
assert b.count() == 1
|
|
assert b.keys() == ["h1"]
|
|
assert b.delete("h1")
|
|
assert not b.exists("h1")
|
|
assert not b.delete("h1")
|
|
|
|
def test_survives_reopen(self, db_path):
|
|
"""The restart-survival property the default flip exists for."""
|
|
SQLiteBackend(db_path).set("h1", make_entry())
|
|
|
|
reopened = SQLiteBackend(db_path)
|
|
got = reopened.get("h1")
|
|
assert got is not None
|
|
assert got.original_content == "x" * 600
|
|
|
|
def test_two_connections_share_data(self, db_path):
|
|
"""Multi-worker property: a second live connection sees writes."""
|
|
writer = SQLiteBackend(db_path)
|
|
reader = SQLiteBackend(db_path)
|
|
writer.set("h1", make_entry())
|
|
assert reader.get("h1") is not None
|
|
|
|
def test_items_and_stats(self, db_path):
|
|
b = SQLiteBackend(db_path)
|
|
b.set("h1", make_entry("h1"))
|
|
b.set("h2", make_entry("h2"))
|
|
|
|
items = dict(b.items())
|
|
assert set(items) == {"h1", "h2"}
|
|
stats = b.get_stats()
|
|
assert stats["backend_type"] == "sqlite"
|
|
assert stats["entry_count"] == 2
|
|
assert stats["bytes_used"] > 0
|
|
|
|
def test_clear(self, db_path):
|
|
b = SQLiteBackend(db_path)
|
|
b.set("h1", make_entry())
|
|
b.clear()
|
|
assert b.count() == 0
|
|
|
|
def test_unknown_json_fields_tolerated(self, db_path):
|
|
"""Forward-compat: entries written by a newer headroom version
|
|
(extra fields) must still load."""
|
|
b = SQLiteBackend(db_path)
|
|
b.set("h1", make_entry())
|
|
with b._lock:
|
|
row = b._conn.execute("SELECT entry_json FROM ccr_entries WHERE hash='h1'").fetchone()
|
|
doctored = row[0][:-1] + ', "field_from_the_future": 7}'
|
|
b._conn.execute("UPDATE ccr_entries SET entry_json=? WHERE hash='h1'", (doctored,))
|
|
b._conn.commit()
|
|
|
|
got = b.get("h1")
|
|
assert got is not None
|
|
assert got.original_content == "x" * 600
|
|
|
|
def test_store_ttl_enforcement_via_compression_store(self, db_path):
|
|
"""TTL checks stay in CompressionStore; expired entries miss."""
|
|
store = CompressionStore(backend=SQLiteBackend(db_path))
|
|
expired = make_entry(ttl=1)
|
|
expired.created_at = time.time() - 10
|
|
store._backend.set("h1", expired)
|
|
|
|
assert store.retrieve("h1") is None
|
|
|
|
def test_retrieval_count_persists(self, db_path):
|
|
"""record_access mutations are re-persisted (store re-sets the
|
|
entry after mutating), so feedback counts survive reopen."""
|
|
store = CompressionStore(backend=SQLiteBackend(db_path))
|
|
store._backend.set("h1", make_entry())
|
|
store.retrieve("h1", query="foo")
|
|
|
|
reopened = SQLiteBackend(db_path)
|
|
got = reopened.get("h1")
|
|
assert got is not None
|
|
assert got.retrieval_count == 1
|
|
|
|
|
|
class TestMultiWorkerSafety:
|
|
def test_busy_error_does_not_delete_database(self, db_path):
|
|
"""SQLITE_BUSY (OperationalError, a DatabaseError subclass) under
|
|
multi-worker write contention must be treated as transient — NOT
|
|
as corruption that deletes every stored original."""
|
|
b = SQLiteBackend(db_path)
|
|
b.set("h1", make_entry())
|
|
|
|
class BusyOnceConn:
|
|
"""Delegating wrapper; first SELECT raises 'database is locked'."""
|
|
|
|
def __init__(self, real):
|
|
self._real = real
|
|
self.raised = False
|
|
|
|
def execute(self, *args, **kwargs):
|
|
if not self.raised and args and "SELECT" in args[0]:
|
|
self.raised = True
|
|
raise sqlite3.OperationalError("database is locked")
|
|
return self._real.execute(*args, **kwargs)
|
|
|
|
def __getattr__(self, name):
|
|
return getattr(self._real, name)
|
|
|
|
real = b._conn
|
|
b._conn = BusyOnceConn(real) # type: ignore[assignment]
|
|
assert b.get("h1") is None # transient miss, not a crash
|
|
|
|
b._conn = real
|
|
# The data and the database file both survived.
|
|
assert db_path.exists()
|
|
assert b.get("h1") is not None
|
|
|
|
def test_corruption_message_triggers_reset(self, db_path):
|
|
b = SQLiteBackend(db_path)
|
|
b.set("h1", make_entry())
|
|
b._handle_db_error(sqlite3.DatabaseError("database disk image is malformed"), "get")
|
|
# Database recreated: empty but functional.
|
|
assert b.count() == 0
|
|
b.set("h2", make_entry("h2"))
|
|
assert b.exists("h2")
|
|
|
|
def test_busy_timeout_configured(self, db_path):
|
|
b = SQLiteBackend(db_path)
|
|
timeout = b._conn.execute("PRAGMA busy_timeout").fetchone()[0]
|
|
assert timeout >= 5000
|
|
|
|
def test_expired_rows_purged_on_open(self, db_path):
|
|
b = SQLiteBackend(db_path)
|
|
expired = make_entry(ttl=1)
|
|
expired.created_at = time.time() - 10
|
|
b.set("old", expired)
|
|
b.set("fresh", make_entry("fresh"))
|
|
|
|
reopened = SQLiteBackend(db_path)
|
|
assert not reopened.exists("old") # swept at open
|
|
assert reopened.exists("fresh")
|
|
|
|
@pytest.mark.skipif(os.name != "posix", reason="POSIX permissions")
|
|
def test_database_file_is_private(self, db_path):
|
|
SQLiteBackend(db_path)
|
|
mode = db_path.stat().st_mode & 0o777
|
|
assert mode == 0o600
|
|
|
|
|
|
class TestDefaults:
|
|
def test_session_scale_ttl_lockstep(self):
|
|
"""CCRConfig, CompressionEntry, and CompressionStore must agree."""
|
|
from headroom.config import CCRConfig
|
|
|
|
assert CCRConfig().store_ttl_seconds == 1800
|
|
assert CompressionEntry.__dataclass_fields__["ttl"].default == 1800
|
|
assert CompressionStore()._default_ttl == 1800
|
|
|
|
def test_default_backend_is_sqlite(self, monkeypatch, tmp_path):
|
|
from headroom.cache.compression_store import _create_default_ccr_backend
|
|
|
|
monkeypatch.delenv("HEADROOM_CCR_BACKEND", raising=False)
|
|
monkeypatch.setenv("HEADROOM_CCR_SQLITE_PATH", str(tmp_path / "d.db"))
|
|
backend = _create_default_ccr_backend()
|
|
assert backend is not None
|
|
assert backend.get_stats()["backend_type"] == "sqlite"
|
|
|
|
def test_memory_opt_out(self, monkeypatch):
|
|
from headroom.cache.compression_store import _create_default_ccr_backend
|
|
|
|
monkeypatch.setenv("HEADROOM_CCR_BACKEND", "memory")
|
|
assert _create_default_ccr_backend() is None
|
|
|
|
def test_miss_message_is_actionable(self):
|
|
from headroom.cache.compression_store import CCR_MISS_MESSAGE
|
|
|
|
assert "re-read" in CCR_MISS_MESSAGE
|
|
assert "re-run" in CCR_MISS_MESSAGE
|
|
|
|
|
|
if __name__ == "__main__":
|
|
pytest.main([__file__, "-v"])
|