mirror of
https://github.com/headroomlabs-ai/headroom.git
synced 2026-08-27 14:17:10 -04:00
daeff69a75
…779) Claude Code 2.1.196 deterministically disables first-party Remote Control (/remote-control, /rc) behind a custom ANTHROPIC_BASE_URL, which Headroom always sets. Make the wrap/doctor warning accurate (state the disable as fact, name the /rc command, detect the installed version), suppress it for auth modes that never had RC (API key, Bedrock/Vertex/Foundry) and for builds older than 2.1.196, co-report the sibling #746/#1158 gates session-accurately, and fix is_custom_anthropic_base_url host handling (scheme-less hosts, malformed URLs). UX/notice-only; no request bytes touched. ## Description <!-- Briefly explain the change and why it is needed. --> Closes # ## Type of Change - [ ] Bug fix (non-breaking change that fixes an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Performance improvement - [ ] Code refactoring (no functional changes) ## Changes Made - ## Testing <!-- Check what you actually ran, then paste the real command output below. --> - [ ] Unit tests pass (`pytest`) - [ ] Linting passes (`ruff check .`) - [ ] Type checking passes (`mypy headroom`) - [ ] New tests added for new functionality - [ ] Manual testing performed ### Test Output ```text # Paste relevant command output or artifact links here ``` ## Real Behavior Proof - Environment: - Exact command / steps: - Observed result: - Not tested: ## Review Readiness - [ ] I have performed a self-review - [ ] This PR is ready for human review ## Checklist - [ ] My code follows the project's style guidelines - [ ] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] I have updated the CHANGELOG.md if applicable ## Screenshots (if applicable) Add screenshots to help explain your changes. ## Additional Notes <!-- Mention any N/A checklist items, tradeoffs, follow-ups, or maintainer context. --> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Tejas Chopra <chopratejas@gmail.com>
28 lines
1.1 KiB
Python
28 lines
1.1 KiB
Python
"""Issue #1601: Claude Remote Control is unavailable with a custom ANTHROPIC_BASE_URL."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from headroom.providers.claude.runtime import (
|
|
REMOTE_CONTROL_BASE_URL_ENV,
|
|
is_custom_anthropic_base_url,
|
|
remote_control_gate_message,
|
|
)
|
|
|
|
|
|
def test_custom_anthropic_base_url_is_remote_control_gated() -> None:
|
|
assert is_custom_anthropic_base_url("http://127.0.0.1:8787")
|
|
assert is_custom_anthropic_base_url("https://gateway.internal.example")
|
|
|
|
|
|
def test_native_anthropic_base_url_is_not_remote_control_gated() -> None:
|
|
assert not is_custom_anthropic_base_url("https://api.anthropic.com")
|
|
|
|
|
|
def test_remote_control_gate_message_mentions_warning_and_source() -> None:
|
|
message = remote_control_gate_message(source=REMOTE_CONTROL_BASE_URL_ENV)
|
|
assert "Remote Control" in message
|
|
assert REMOTE_CONTROL_BASE_URL_ENV in message
|
|
# Issue #1779: the wording must be accurate — name the /rc command and tell
|
|
# the user how to regain it, without the old hedged "may hide the menu".
|
|
assert "/rc" in message
|
|
assert "run Claude without Headroom for sessions that need Remote Control" in message
|