mirror of
https://github.com/headroomlabs-ai/headroom.git
synced 2026-08-27 14:17:10 -04:00
8f374263d3
## What Enrich the `transforms_applied` tags emitted by `ReadLifecycleManager` and `SmartCrusher` so each tag carries the specific target it acted on, instead of being an opaque counter: - `read_lifecycle:<state>` -> `read_lifecycle:<state>:<file_path>` - `smart_crush:<n>` -> `smart_crush:<n>:<tool1,tool2,...>` (tool names resolved from the assistant's `tool_calls` / `tool_use` metadata; falls back to `smart_crush:<n>` when no name resolves) Downstream UIs can then show *what* a compression acted on (which file was a stale read, which tools had their output crushed), not just that it happened. ## Note on the rebase The original revision targeted `ToolCrusher` / `tool_crush:<n>`. That transform has since been retired and replaced by the Rust-backed `SmartCrusher` (which emits `smart_crush:<n>`), so the tool-name attribution moved to `smart_crusher.py`. The `read_lifecycle` half is unchanged. ## Response-header compatibility `x-headroom-transforms` is built as `",".join(transforms_applied)`. A tag containing a comma (tool-name lists; file paths) would make that header ambiguous to split back into tags. To keep the header backward compatible, `header_safe_transforms` (`headroom/proxy/cost.py`) collapses the enriched tags back to their legacy counter shape **for the header only** -- the full enriched detail still flows through the structured `transforms_applied` list (dashboards, request logs, activity feed). Applied at all three header sites (openai / anthropic / gemini handlers). Paths containing `:` survive in `transforms_applied` because consumers bound their split to 3 parts. ## Tests - `tests/test_transforms/test_read_lifecycle.py` -- OpenAI + Anthropic tag shape, colon-in-path preservation - `tests/test_transforms/test_smart_crusher_attribution.py` -- OpenAI + Anthropic tool-name resolution, dedup, no-name fallback, id/name-missing skips - `tests/test_proxy/test_header_safe_transforms.py` -- header normalization keeps the joined header unambiguous (incl. comma-in-path) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
38 lines
1.6 KiB
Python
38 lines
1.6 KiB
Python
"""`header_safe_transforms` keeps the comma-joined transforms header splittable.
|
|
|
|
`x-headroom-transforms` is built as ``",".join(transforms_applied)``. The
|
|
enriched ``read_lifecycle:<state>:<path>`` and ``smart_crush:<n>:<names>`` tags
|
|
can contain commas, which would make that header ambiguous; the helper collapses
|
|
them back to their legacy counter shape so each header token stays comma-free.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from headroom.proxy.cost import header_safe_transforms
|
|
|
|
|
|
def test_strips_smart_crush_tool_names():
|
|
assert header_safe_transforms(["smart_crush:2:Bash,Grep"]) == ["smart_crush:2"]
|
|
|
|
|
|
def test_strips_read_lifecycle_path():
|
|
assert header_safe_transforms(["read_lifecycle:stale:/src/App.tsx"]) == ["read_lifecycle:stale"]
|
|
|
|
|
|
def test_strips_read_lifecycle_path_with_comma():
|
|
# A path containing a comma is exactly the case that would corrupt the header.
|
|
assert header_safe_transforms(["read_lifecycle:superseded:/tmp/a,b/x.py"]) == [
|
|
"read_lifecycle:superseded"
|
|
]
|
|
|
|
|
|
def test_passes_through_legacy_and_unrelated_tags():
|
|
tags = ["smart_crush:3", "read_lifecycle:stale", "router:excluded:tool", "smart:lossless:table"]
|
|
assert header_safe_transforms(tags) == tags
|
|
|
|
|
|
def test_joined_header_remains_unambiguous():
|
|
tags = ["smart_crush:2:Bash,Grep", "read_lifecycle:stale:/a,b.py", "router:excluded:tool"]
|
|
header = ",".join(header_safe_transforms(tags))
|
|
# One token per tag — no stray commas leaking in from enriched detail.
|
|
assert header.split(",") == ["smart_crush:2", "read_lifecycle:stale", "router:excluded:tool"]
|