headroom/tests/test_proxy_openai_responses_integration.py
Tejas Chopra e0ce4b1d48
fix: remove rtk and lean-ctx CLI context tools (#2677)
## Description

Removes both third-party CLI context tools — **rtk** and **lean-ctx** —
and with them the context-tool selector itself. Headroom no longer
downloads, installs or configures either one, and there is no
replacement.

The previous pass (#2344) gated only three entry points inside
`headroom/cli/wrap.py`. That left the feature reachable in practice:

| Gap | Effect |
|---|---|
| `scripts/install.sh:1544`, `install.ps1:1681` | Ran `rtk init --global
--auto-patch` from bash/PowerShell, **bypassing the Python gate
entirely** — `curl \| sh` still wrote a Claude Code `PreToolUse` hook
regardless of `HEADROOM_RTK` |
| `wrap.py` `_setup_context_tool_for_agent` | **`wrap openhands` was
broken by default**: `rtk_required=True` met a gate returning `None` →
`SystemExit(1)`. Invisible because all 8 openhands tests patched
`_ensure_rtk_binary` to a fake path |
| `proxy/helpers.py`, `subscription/tracker.py` | Proxy shelled out to
`rtk gain` from `/stats`, the dashboard and `headroom perf`; the tracker
polled it per contribution (`_RTK_WIRING_DEFAULT = "enabled"`) |
| No cleanup path | Nothing removed artifacts an earlier default had
installed, so a machine that once ran the old default kept rtk in the
loop forever (#1669, #1955) |

Also worth noting: the rtk binary download had **no SHA or signature
verification** — only `rtk --version` as a smoke test.

## Type of Change

- [x] Bug fix (non-breaking change that fixes an issue)
- [ ] New feature (non-breaking change that adds functionality)
- [x] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Documentation update
- [ ] Performance improvement
- [x] Code refactoring (no functional changes)

## Changes Made

**Removed** — `headroom/rtk/` and `headroom/lean_ctx/` packages,
`headroom/cli/wrap_rtk_metrics.py`, `_selected_context_tool` /
`_setup_context_tool_for_agent` / `_VALID_CONTEXT_TOOLS`, the `--rtk` /
`--no-rtk` / `--no-project-rtk` / `--keep-rtk` flags across all 18 wrap
subcommands, `HEADROOM_RTK*`, the proxy-side `rtk gain` polling, the
dashboard CLI-filtering panel (rows + all 8 `cliFiltering*` Alpine
getters), `paths.rtk_path()` / `lean_ctx_path()`, the SDK path helpers,
`benchmarks/rtk_loop_learn_eval.py`, and the `headroom/rtk/**` CI path
filters.

**Fails loudly, not silently** — `--context-tool` / `--no-context-tool`
/ `HEADROOM_CONTEXT_TOOL` are kept solely to error out. They live in
shell profiles, aliases and CI jobs, and accepting them as a no-op would
read as Headroom having quietly stopped working. The installers reject
them too, which matters more than it looks: their arg parsers forward
the first unknown flag **and everything after it** to the wrapped tool,
so a leftover `--no-rtk` would have silently swallowed a following
`--port` and then been ignored downstream.

**New `headroom/context_tool_cleanup.py`** — deleting the code cannot
help a machine that already ran the old default, since the hooks,
binaries and injected guidance are durable on disk.
`purge_context_tool_artifacts()` runs once per `wrap`/`unwrap` and
removes the registered hook entries, the generated hook scripts, the
Headroom-managed `~/.local/bin` symlinks, the vendored
`~/.headroom/bin/{rtk,lean-ctx}` binaries, the `lean-ctx` MCP server
entry and the marker-fenced instruction blocks. Deliberately
conservative: idempotent, **skips** a malformed config rather than
overwriting it, and only unlinks a symlink resolving inside Headroom's
own bin dir so a user's own build is untouched. It reports on
**stderr**, because `wrap/unwrap openclaw --prepare-only` emit
machine-readable JSON on stdout as their entire contract. Skipped for
`wrap selfheal` (runs from a SessionStart hook; must not race Claude
Code's writer for `~/.claude.json`) and for `--help`, which must stay
read-only.

**Client-config hardening** (discovered while investigating a "corrupted
Serena settings file" report) — `wrap.py` reset a settings file to `{}`
when an existing file would not parse, then wrote that back. One
hand-edited typo or a transient `EACCES`/`EINTR` on a valid file
destroyed the user's `permissions`, `env` and `hooks`, on **every
`headroom wrap claude`**. It now refuses to write. Separately,
`fsutil.write_text` is now atomic (temp file + `fsync` + `os.replace`),
fixing all 14 non-atomic client-config writes at once; it follows
symlinks rather than replacing them (dotfile managers) and preserves an
existing file's mode.

**Deliberately kept** — `rtk` stays in the wrapper-peel list in
`transforms/content_router.py`. It sits beside `sudo`/`env`/`timeout` as
shell-command grammar, so `rtk cat f` is still classified as a file read
for anyone running their own rtk install, which the purge intentionally
leaves alone.

## Testing

- [x] Unit tests pass (`pytest`)
- [x] Linting passes (`ruff check .`)
- [x] Type checking passes (`mypy headroom`)
- [x] New tests added for new functionality
- [x] Manual testing performed

### Test Output

```text
$ ruff check headroom/ tests/ e2e/ --exclude headroom/dashboard/templates
All checks passed!

$ ruff format --check headroom/ tests/ e2e/ --exclude headroom/dashboard/templates
1255 files already formatted

$ mypy headroom/
Success: no issues found in 508 source files

$ pytest tests/test_context_tool_cleanup.py -q
11 passed

$ pytest tests/test_fsutil.py -q
12 passed

$ pytest tests/test_cli/test_wrap_codex.py -q            # 89 tests
89 passed in 431.68s
$ pytest tests/test_cli/test_wrap_opencode.py -q
39 passed in 257.46s
$ pytest tests/test_cli/test_wrap_helpers.py -q
45 passed
$ pytest tests/test_paths.py -q
75 passed
$ pytest tests/test_cli/test_unwrap_claude.py -q
14 passed
$ pytest tests/test_proxy_savings_history.py -q
39 passed
$ pytest tests/test_cli/test_wrap_copilot.py -q
27 passed
$ pytest tests/test_cli/test_wrap_zcode.py -q
20 passed
$ pytest tests/test_subscription_tracker.py -q
9 passed
$ pytest tests/test_proxy_dashboard_stats_cache.py -q
5 passed, 1 skipped
```

Repo-wide grep for 14 removed symbols (`headroom.rtk`,
`headroom.lean_ctx`, `_ensure_rtk_binary`, `_selected_context_tool`,
`_get_context_tool_stats`, `rtk_path`, `lean_ctx_path`,
`wrap_rtk_metrics`, `HEADROOM_RTK`, `cli_tokens_avoided`,
`tokens_saved_rtk`, …) across `*.py`, `*.ts`, `*.sh`, `*.ps1`, `*.yml`,
`*.html`: **zero hits**.

Notable test changes: `test_wrap_openhands.py` no longer patches
`_ensure_rtk_binary` and asserts `wrap openhands --prepare-only` exits 0
unpatched — the regression that was previously masked.
`test_wrap_continue.py` and `test_wrap_hintfile_agents.py` were removed
(every test drove RTK instruction injection). A new
`test_subscription_tracker.py::test_load_state_written_before_cli_context_tools_were_removed`
proves a pre-removal `subscription_state.json` still loads.

## Real Behavior Proof

- **Environment:** macOS 15.4 (darwin 25.4.0), Python 3.12.6, Headroom @
this branch, real `~/.headroom` and `~/.claude` on the dev machine.
- **Exact command / steps and observed result:**

```text
# 1. Retired flag fails loudly instead of silently no-op'ing
$ headroom wrap codex --prepare-only --context-tool rtk
Error: CLI context tools (rtk, lean-ctx) have been removed from Headroom: they
rewrote shell commands through a third-party binary Headroom no longer manages.
Drop --context-tool / --no-context-tool and unset HEADROOM_CONTEXT_TOOL;
`headroom wrap` uninstalls what they left behind on first run.

$ HEADROOM_CONTEXT_TOOL=lean-ctx headroom wrap codex --prepare-only
Error: CLI context tools (rtk, lean-ctx) have been removed from Headroom: ...

# 2. install.sh rejects the retired flags (extracted parse_wrap_args harness)
['--no-rtk', '--port', '9999']   rc=1  ERROR: CLI context tools ... Drop --no-rtk
['--context-tool=rtk']           rc=1  ERROR: CLI context tools ... Drop --context-tool
$ bash -n scripts/install.sh   # syntax OK

# 3. Purge ran against the real machine, which had all the orphaned artifacts
$ python -c "from headroom.context_tool_cleanup import purge_context_tool_artifacts; ..."
  removed ~/.headroom/bin/lean-ctx        (51 MB)
  removed ~/.headroom/bin/rtk             (7.7 MB)
  removed ~/.local/bin/rtk                (symlink into ~/.headroom/bin)
  removed ~/.claude/hooks/rtk-rewrite.sh
  removed 8 lean-ctx-* hook scripts
# ~/.claude.json afterwards: 90 top-level keys, 19 projects, mcpServers unchanged
# → ~59 MB reclaimed, no unrelated key touched

# 4. stdout stays machine-readable while the purge reports (planted a fake artifact)
$ headroom wrap openclaw --prepare-only --gateway-provider-id codex >out 2>err
$ cat out
{"enabled":true,"config":{"proxyPort":8787,...}}     # parses as JSON
$ cat err
Retired CLI context tool cleanup: removed /Users/tcms/.headroom/bin/rtk

# 5. --help is inert (planted artifact survives), a real run purges
$ headroom wrap codex --help   → artifact survived: CORRECT
$ headroom wrap openclaw --prepare-only → purged: CORRECT

# 6. MCP purge dry-run against a copy of the real 82 KB ~/.claude.json
top-level keys 90 -> 90;  projects 19 -> 19;  LOST keys: none
all content outside mcpServers byte-identical: True
```

Dashboard rendered via the Playwright test after the panel removal:
"Token Savings" shows only `Proxy 0 (0.0%)` / `Of total wire: 36.86%`,
and "Token Usage" reads Before Compression → Proxy Removed → After
Compression with no "Filtered (this session)" row. Nothing below the
removed panel broke.

- **Not tested:** Windows and Linux (macOS only) — `install.ps1` is
verified by brace-balance and inspection, not executed, since no `pwsh`
is available locally. The wrap e2e suite (`e2e/wrap/run.py`) was updated
but not run; it needs the Docker e2e image. `serena project index`
interaction is exercised in the stacked base PR.

## Review Readiness

- [x] I have performed a self-review
- [x] This PR is ready for human review

## Checklist

- [x] My code follows the project's style guidelines
- [x] I have performed a self-review of my code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [x] I did **not** edit `CHANGELOG.md` — it is generated by
release-please from my Conventional Commit PR title (a CI guard enforces
this)

## Additional Notes

**Stacked on #2676** (`tejas/serena-config-bootstrap`) — please merge
that first; this PR's base should then be retargeted to `main`, or it
will read as containing that fix too.

**Breaking-change migration for users:**
- Drop `--rtk`, `--no-rtk`, `--no-project-rtk`, `--keep-rtk`,
`--context-tool`, `--no-context-tool` from any alias, script or CI job,
and unset `HEADROOM_RTK*` / `HEADROOM_CONTEXT_TOOL`. They now error
rather than being ignored, so the failure is immediate and
self-explaining.
- Previously-installed artifacts are purged automatically on the next
`wrap`/`unwrap`; no manual cleanup needed.
- `headroom perf --json` no longer carries a `cli_filtering` key, and
`/stats` no longer returns a `context_tool` section.

**Docs:** `docs/rtk-architecture.md` deleted; RTK/lean-ctx removed from
`README.md`,
`docs/content/docs/{configuration,opencode,grok-build,docker-install,filesystem-contract}.mdx`,
`docs/observability.md` and the matching `wiki/` pages.
`REALIGNMENT/09-phase-G-rtk-observability.md` is marked SUPERSEDED
rather than deleted, to keep the planning record.

**Follow-ups not in scope:** `_emit_wrap_interrupted` was deleted as
dead code — its only caller was the `except KeyboardInterrupt` guarding
the binary download, so with no download there is nothing slow left to
interrupt.
2026-07-30 22:59:41 -07:00

361 lines
13 KiB
Python

"""Integration tests for OpenAI /v1/responses endpoint with real API calls.
These tests require a valid OPENAI_API_KEY environment variable.
They test the /v1/responses endpoint (introduced March 2025) with compression.
Run with:
OPENAI_API_KEY=your-key pytest tests/test_proxy_openai_responses_integration.py -v
"""
import json
import os
import pytest
# Skip entire module if no API key
pytestmark = pytest.mark.skipif(
not os.environ.get("OPENAI_API_KEY"), reason="OPENAI_API_KEY not set"
)
pytest.importorskip("fastapi")
pytest.importorskip("httpx")
from fastapi.testclient import TestClient # noqa: E402
from headroom.proxy.loopback_guard import require_loopback # noqa: E402
from headroom.proxy.server import ProxyConfig, create_app # noqa: E402
@pytest.fixture
def openai_responses_client():
"""Create test client for OpenAI responses API with optimization enabled."""
config = ProxyConfig(
optimize=True, # Enable compression
cache_enabled=False,
rate_limit_enabled=False,
cost_tracking_enabled=False,
)
app = create_app(config)
app.dependency_overrides[require_loopback] = lambda: None
with TestClient(app) as client:
yield client
@pytest.fixture
def api_key():
"""Get OpenAI API key from environment."""
return os.environ.get("OPENAI_API_KEY")
class TestOpenAIResponsesBasic:
"""Test /v1/responses endpoint basic functionality."""
def test_basic_generation(self, openai_responses_client, api_key):
"""Basic text generation works."""
response = openai_responses_client.post(
"/v1/responses",
headers={"Authorization": f"Bearer {api_key}"},
json={"model": "gpt-4o-mini", "input": "What is 2+2? Reply with just the number."},
)
assert response.status_code == 200
data = response.json()
# Verify responses API format
assert "id" in data
assert "output" in data
assert len(data["output"]) > 0
assert data["output"][0]["type"] == "message"
assert data["output"][0]["role"] == "assistant"
# Get the text content
content = data["output"][0]["content"]
assert len(content) > 0
text = content[0].get("text", "")
assert "4" in text
# Verify usage metadata
assert "usage" in data
def test_with_instructions(self, openai_responses_client, api_key):
"""System instructions work correctly."""
response = openai_responses_client.post(
"/v1/responses",
headers={"Authorization": f"Bearer {api_key}"},
json={
"model": "gpt-4o-mini",
"input": "Hello",
"instructions": "Always respond with exactly one word.",
},
)
assert response.status_code == 200
data = response.json()
content = data["output"][0]["content"]
text = content[0].get("text", "")
# Should be a short response due to instructions
assert len(text.split()) <= 3
def test_input_as_array(self, openai_responses_client, api_key):
"""Input can be an array of messages."""
response = openai_responses_client.post(
"/v1/responses",
headers={"Authorization": f"Bearer {api_key}"},
json={
"model": "gpt-4o-mini",
"input": [
{"role": "user", "content": "My name is TestUser789."},
{"role": "assistant", "content": "Nice to meet you, TestUser789!"},
{"role": "user", "content": "What is my name?"},
],
},
)
assert response.status_code == 200
data = response.json()
content = data["output"][0]["content"]
text = content[0].get("text", "").lower()
assert "testuser789" in text
def test_generation_parameters(self, openai_responses_client, api_key):
"""Generation parameters are respected."""
response = openai_responses_client.post(
"/v1/responses",
headers={"Authorization": f"Bearer {api_key}"},
json={
"model": "gpt-4o-mini",
"input": "Write a very short poem about AI.",
"max_output_tokens": 50,
"temperature": 0.1,
},
)
assert response.status_code == 200
data = response.json()
# Response should be limited by max_output_tokens
assert data["usage"]["output_tokens"] <= 60 # Some buffer
class TestOpenAIResponsesTools:
"""Test function calling / tools with /v1/responses endpoint."""
def test_function_calling(self, openai_responses_client, api_key):
"""Function calling works correctly."""
# Note: /v1/responses uses a different tools format than /v1/chat/completions
# - name, description, parameters are at top level, not nested under "function"
response = openai_responses_client.post(
"/v1/responses",
headers={"Authorization": f"Bearer {api_key}"},
json={
"model": "gpt-4o-mini",
"input": "What is the weather in Tokyo?",
"tools": [
{
"type": "function",
"name": "get_weather",
"description": "Get current weather for a location",
"parameters": {
"type": "object",
"properties": {
"location": {"type": "string", "description": "City name"}
},
"required": ["location"],
},
}
],
},
)
assert response.status_code == 200
data = response.json()
# Find tool call in output
output = data["output"]
tool_call_found = False
for item in output:
if item.get("type") == "function_call":
tool_call_found = True
assert item["name"] == "get_weather"
args = (
json.loads(item["arguments"])
if isinstance(item["arguments"], str)
else item["arguments"]
)
assert "tokyo" in args.get("location", "").lower()
break
assert tool_call_found, "Expected function_call in output"
class TestOpenAIResponsesCompression:
"""Test that compression works with /v1/responses endpoint."""
def test_compression_on_assistant_message(self, openai_responses_client, api_key):
"""Large data in assistant message gets compressed."""
# Create large JSON data (simulating tool output)
items = [
{"id": i, "name": f"Item {i}", "desc": f"Description for item {i}"} for i in range(100)
]
tool_output = json.dumps(items)
# Send as multi-turn with assistant message containing data
response = openai_responses_client.post(
"/v1/responses",
headers={"Authorization": f"Bearer {api_key}"},
json={
"model": "gpt-4o-mini",
"input": [
{"role": "user", "content": "Get items from database"},
{"role": "assistant", "content": f"Here are the results:\n{tool_output}"},
{"role": "user", "content": "How many items are there?"},
],
},
)
assert response.status_code == 200
data = response.json()
content = data["output"][0]["content"]
text = content[0].get("text", "")
# Model should correctly count the items
assert "100" in text
# Check that compression happened via stats
stats = openai_responses_client.get("/stats").json()
# At least some tokens should have been saved
assert stats["tokens"]["saved"] >= 0 # May or may not compress depending on size
def test_compression_on_function_call_output(self, openai_responses_client, api_key):
"""Large function_call_output gets compressed (Codex pattern)."""
# Create large tool output (simulating Codex file read or shell output)
large_output = json.dumps(
[{"id": i, "name": f"record_{i}", "value": f"data_{i}" * 10} for i in range(200)]
)
response = openai_responses_client.post(
"/v1/responses",
headers={"Authorization": f"Bearer {api_key}"},
json={
"model": "gpt-4o-mini",
"input": [
{"role": "user", "content": "How many records are in the database?"},
{
"type": "function_call",
"call_id": "call_test_1",
"name": "query_database",
"arguments": "{}",
},
{
"type": "function_call_output",
"call_id": "call_test_1",
"output": large_output,
},
],
},
)
assert response.status_code == 200
data = response.json()
# Model should be able to answer
assert "output" in data
assert len(data["output"]) > 0
# Compression should have saved tokens
stats = openai_responses_client.get("/stats").json()
assert stats["tokens"]["saved"] > 0
def test_no_compression_with_string_input(self, openai_responses_client, api_key):
"""String input (single message) should not crash or compress."""
response = openai_responses_client.post(
"/v1/responses",
headers={"Authorization": f"Bearer {api_key}"},
json={"model": "gpt-4o-mini", "input": "What is 1+1?"},
)
assert response.status_code == 200
def test_bypass_header_skips_compression(self, openai_responses_client, api_key):
"""x-headroom-bypass header skips compression."""
items = [
{"id": i, "name": f"Item {i}", "desc": f"Description for item {i}"} for i in range(100)
]
tool_output = json.dumps(items)
# Reset stats first
openai_responses_client.post("/stats/reset")
response = openai_responses_client.post(
"/v1/responses",
headers={
"Authorization": f"Bearer {api_key}",
"x-headroom-bypass": "true",
},
json={
"model": "gpt-4o-mini",
"input": [
{"role": "user", "content": "Get items"},
{"role": "assistant", "content": f"Results:\n{tool_output}"},
{"role": "user", "content": "How many?"},
],
},
)
assert response.status_code == 200
stats = openai_responses_client.get("/stats").json()
# With bypass, proxy compression should not save tokens.
assert stats["tokens"]["proxy_compression_saved"] == 0
class TestOpenAIResponsesStats:
"""Test that proxy stats track /v1/responses requests correctly."""
def test_stats_track_openai_provider(self, openai_responses_client, api_key):
"""Stats show requests under 'openai' provider."""
# Make a request
openai_responses_client.post(
"/v1/responses",
headers={"Authorization": f"Bearer {api_key}"},
json={"model": "gpt-4o-mini", "input": "Hi"},
)
stats = openai_responses_client.get("/stats").json()
assert "openai" in stats["requests"]["by_provider"]
assert stats["requests"]["by_provider"]["openai"] >= 1
def test_stats_track_model(self, openai_responses_client, api_key):
"""Stats track the specific model used."""
openai_responses_client.post(
"/v1/responses",
headers={"Authorization": f"Bearer {api_key}"},
json={"model": "gpt-4o-mini", "input": "Hi"},
)
stats = openai_responses_client.get("/stats").json()
assert "gpt-4o-mini" in stats["requests"]["by_model"]
class TestOpenAIResponsesErrorHandling:
"""Test error handling for /v1/responses endpoint."""
def test_invalid_api_key(self, openai_responses_client):
"""Invalid API key returns appropriate error."""
response = openai_responses_client.post(
"/v1/responses",
headers={"Authorization": "Bearer invalid-key-123"},
json={"model": "gpt-4o-mini", "input": "Hi"},
)
assert response.status_code >= 400
def test_invalid_model(self, openai_responses_client, api_key):
"""Invalid model returns appropriate error."""
response = openai_responses_client.post(
"/v1/responses",
headers={"Authorization": f"Bearer {api_key}"},
json={"model": "nonexistent-model-xyz", "input": "Hi"},
)
assert response.status_code >= 400
def test_missing_input(self, openai_responses_client, api_key):
"""Missing input handled gracefully."""
response = openai_responses_client.post(
"/v1/responses",
headers={"Authorization": f"Bearer {api_key}"},
json={"model": "gpt-4o-mini"},
)
# Should either return error or handle gracefully
assert response.status_code in [200, 400, 422]