mirror of
https://github.com/headroomlabs-ai/headroom.git
synced 2026-08-27 14:17:10 -04:00
69fd2189a3
## Description Extracts request/stream limit validation from `helpers.py` into `headroom.proxy.request_limit_policy`. The helpers still read environment variables at request time, but validation of SSE event size and body-too-large status values is now pure and directly tested. Closes # ## Type of Change - [ ] Bug fix (non-breaking change that fixes an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Performance improvement - [x] Code refactoring (no functional changes) ## Changes Made - Added `request_limit_policy.py` for resolving SSE event max bytes and body-too-large HTTP status values. - Kept `helpers.get_sse_event_max_bytes` and `helpers.get_body_too_large_status` reading env vars and delegating to the pure policy. - Added direct tests for defaults, valid override values, and invalid values. - Carried forward the LiteLLM callback compatibility shim needed for current mypy on `main`. ## Testing - [x] Unit tests pass (`pytest`) - [x] Linting passes (`ruff check .`) - [x] Type checking passes (`mypy headroom`) - [x] New tests added for new functionality - [ ] Manual testing performed ### Test Output ```text python -m pytest tests\test_request_limit_policy.py 10 passed in 0.17s python -m ruff check . All checks passed! python -m ruff format --check . 1095 files already formatted python -m mypy headroom --ignore-missing-imports Success: no issues found in 409 source files gitleaks protect --staged --no-banner --redact no leaks found ``` ## Real Behavior Proof - Environment: Windows, Python 3.13.13, branch `jd/architecture-slice-31`. - Exact command / steps: ran focused request-limit policy tests, ruff, ruff format check, mypy, and staged gitleaks scan. - Observed result: limit validation behavior is directly covered and local lint/type/security checks pass. - Not tested: live proxy request rejection; existing helper entry points remain intact. ## Review Readiness - [x] I have performed a self-review - [x] This PR is ready for human review ## Checklist - [x] My code follows the project's style guidelines - [x] I have performed a self-review of my code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] I have updated the CHANGELOG.md if applicable ## Screenshots (if applicable) N/A ## Additional Notes Documentation and changelog updates are N/A for this internal architecture-only refactor. The push reported existing default-branch Dependabot alerts; no staged secret leaks were found for this PR.
41 lines
1.4 KiB
Python
41 lines
1.4 KiB
Python
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
from headroom.proxy.request_limit_policy import (
|
|
BODY_TOO_LARGE_STATUS_DEFAULT,
|
|
SSE_EVENT_MAX_BYTES_DEFAULT,
|
|
resolve_body_too_large_status,
|
|
resolve_sse_event_max_bytes,
|
|
)
|
|
|
|
|
|
def test_resolve_sse_event_max_bytes_uses_default_for_missing_value() -> None:
|
|
assert resolve_sse_event_max_bytes(None) == SSE_EVENT_MAX_BYTES_DEFAULT
|
|
assert resolve_sse_event_max_bytes("") == SSE_EVENT_MAX_BYTES_DEFAULT
|
|
|
|
|
|
def test_resolve_sse_event_max_bytes_accepts_positive_integer() -> None:
|
|
assert resolve_sse_event_max_bytes("2048") == 2048
|
|
|
|
|
|
@pytest.mark.parametrize("raw", ["0", "-1", "not-int"])
|
|
def test_resolve_sse_event_max_bytes_rejects_invalid_values(raw: str) -> None:
|
|
with pytest.raises(ValueError):
|
|
resolve_sse_event_max_bytes(raw)
|
|
|
|
|
|
def test_resolve_body_too_large_status_uses_default_for_missing_value() -> None:
|
|
assert resolve_body_too_large_status(None) == BODY_TOO_LARGE_STATUS_DEFAULT
|
|
assert resolve_body_too_large_status("") == BODY_TOO_LARGE_STATUS_DEFAULT
|
|
|
|
|
|
def test_resolve_body_too_large_status_accepts_4xx_or_5xx_status() -> None:
|
|
assert resolve_body_too_large_status("413") == 413
|
|
assert resolve_body_too_large_status("529") == 529
|
|
|
|
|
|
@pytest.mark.parametrize("raw", ["399", "600", "not-int"])
|
|
def test_resolve_body_too_large_status_rejects_invalid_values(raw: str) -> None:
|
|
with pytest.raises(ValueError):
|
|
resolve_body_too_large_status(raw)
|