headroom/tests/test_audit_reads.py
Tejas Chopra b7be3814f1
feat: compression extraction — Rust knob exposure, CCR hardening, traffic audits (#818)
## Description

A data-driven push for better compression savings without accuracy loss,
in four parts: expose and tune the Rust compressor knobs, harden the CCR
retrieval store, add traffic-audit tooling that sizes opportunities from
real transcripts, and introduce **read maturation** — a new,
live-validated mechanism that compresses Read outputs *before* they ever
enter the provider prefix cache.

## Type of Change

- [x] Bug fix (non-breaking change that fixes an issue)
- [x] New feature (non-breaking change that adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Documentation update
- [x] Performance improvement
- [ ] Code refactoring (no functional changes)

## Changes Made

### 1. Rust compressor extraction

- Expose `lossless_min_savings_ratio` end-to-end and lower the default
0.30 → 0.15 (lockstep across Rust, PyO3, and both Python config classes)
so the lossless Table/CSV compaction path wins more often.
- Expose the `CompactConfig` heuristics (core-field fraction,
heterogeneity ratio, flatten cap, bucket bounds) through PyO3 + Python.
- `SearchCompressor` grouped-by-file output (`rg --heading` style — path
once per file instead of per match). Library default off; the proxy
enables it in token mode.
- Complete `factor_out_constants`: constant fields now emit once in a
`_constant_fields` sentinel with slim rows (defensive per-item value
match; default off).
- `ContentRouter` accepts a SmartCrusher config override and the
search-grouping knob.

### 2. CCR store hardening

- Session-scale TTL: 300s → 1800s (CCRConfig, CompressionEntry,
CompressionStore, Rust `DEFAULT_TTL` — lockstep).
- **SQLite is the default CCR backend** (`~/.headroom/ccr_store.db`,
WAL): survives proxy restarts and is shared across workers.
`HEADROOM_CCR_BACKEND=memory` opts out.
- Multi-worker safety: `busy_timeout`, and corruption detection narrowed
so transient `SQLITE_BUSY` errors can never trigger database deletion.
- Data-at-rest hygiene: `chmod 600` on db + sidecars, expired rows swept
at open.
- Retrieval-miss messages are actionable (re-read the file / re-run the
command).

### 3. Traffic audit tooling (measure before tuning)

- `headroom audit-reads`: sizes Read opportunities from local Claude
Code transcripts (read share, stale %, line-number overhead, context
residency, cache-death windows).
- `--simulate-maturation`: Mechanism B risk sizing (re-read rates,
never-touched-again share, quiesce coverage, at-risk edits).
- `--codex`: shell-read classifier for Codex transcripts (rtk-wrapper
aware, workdir resolution).
- Findings that shaped this PR (81 sessions): Reads are 67% of tool
bytes; median Read lingers 118 turns (~13x lifetime cost); a prototyped
repeat-Read dedup measured 0.1% and was **removed** rather than shipped
as dead code.

### 4. Read maturation (Mechanism B) — experimental, default OFF

- Activity-based: a fresh large Read is held **out** of the provider
cache (trailing breakpoint relocated before it), stays verbatim while
its file is active, and matures into a CCR-backed marker once the file
is quiet for `quiesce_turns` (default 5; `max_hold_turns` bounds busy
files).
- Only the final compressed form ever enters the cache — **no cached
byte is ever mutated**; matured markers replay byte-identically.
- Wired into the Anthropic handler behind `--read-maturation` /
`HEADROOM_READ_MATURATION=1`; session state rides on the prefix tracker;
advisory (can never fail a request).
- Live-validated against the Anthropic API: held content excluded from
cache_creation; after maturation the prior cached prefix still served —
the no-bust invariant holds end-to-end.

### 5. Rebase / CI fixups (this update)

- Rebased onto latest `main` (was 28 commits behind): picks up `ci: pass
CODECOV_TOKEN to coverage uploads (#968)`, which is what was turning the
4 test shards red — the tests themselves passed (1528) but the post-test
codecov upload exited non-zero on a protected branch.
- Resolved the duplicate `lossless_min_savings_ratio` that two
independent main/branch additions left in `SmartCrusherConfig` and the
Rust-config kwarg (import-time `SyntaxError` + mypy `no-redef`).
- Aligned CCR tests with the new defaults (SQLite backend, 1800s TTL)
across `test_ccr`, `test_adapter_hooks`, `test_compression_store`,
`test_proxy_ccr`, and the lossy row-drop bridge test.

## Testing

<!-- Check what you actually ran, then paste the real command output
below. -->

- [x] Unit tests pass (`pytest`)
- [x] Linting passes (`ruff check .`)
- [x] Type checking passes (`mypy headroom`)
- [x] New tests added for new functionality
- [ ] Manual testing performed

### Test Output

```text
$ python -m pytest tests/test_proxy_ccr.py tests/test_ccr.py tests/test_compression_store.py tests/test_adapter_hooks.py tests/test_ccr_row_drop_store_bridge.py -q
170 passed, 4 warnings in 42.49s

$ python -m pytest tests/test_audit_reads.py tests/test_audit_codex.py tests/test_read_maturation.py tests/test_transforms_content_router.py tests/test_smart_crusher_toin_attachment.py -q
83 passed

$ mypy headroom/
Success: no issues found in 365 source files

$ python -m compileall headroom/ -q
COMPILE-OK

# CI (run 27488990477, pre-rebase head): all 4 shards ran to completion —
#   "1528 passed, 120 skipped, 4922 deselected"
# The red shards were the codecov upload step, not test failures; fixed by
# the #968 rebase above.
```

## Real Behavior Proof

- Environment: macOS (darwin), Python 3.12 venv; branch
`feat/compression-extraction` rebased onto `origin/main` (head
7cb0f43b); GitHub Actions CI run 27488990477 for the test shards
- Exact command / steps: rebased onto latest main (clean, 13 commits
replayed, 0 conflicts); ran the pytest suites and mypy above locally;
inspected CI shard logs to confirm the failure was the codecov upload,
not the test phase
- Observed result: 253 targeted tests pass locally; mypy clean on 365
files; CI test phase reports `1528 passed, 120 skipped`; the only red
step (codecov `upload-coverage` → "Token required because branch is
protected") is resolved by the rebased-in #968 CODECOV_TOKEN fix
- Not tested: the read-maturation live-API no-bust validation
(`tests/test_live/`) was not re-run in this rebase pass (requires
provider keys); it was validated when the feature first landed, and no
maturation code changed in the rebase — only CCR-default test assertions
and the duplicate-field resolution

## Review Readiness

- [x] I have performed a self-review
- [x] This PR is ready for human review

## Checklist

- [x] My code follows the project's style guidelines
- [x] I have performed a self-review of my code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] I have updated the CHANGELOG.md if applicable

## Additional Notes

CHANGELOG is generated by release-please from the conventional commits,
so the CHANGELOG box is intentionally left unchecked. "Manual testing
performed" is unchecked deliberately — see `Real Behavior Proof` → `Not
tested` for the exact boundary (the live-API maturation validation was
not re-run in this rebase pass).

### Follow-ups (tracked, not in this PR)

- Mechanism B provider extensions: OpenAI-family wiring (no breakpoint
hold — bounded near-tail bust) and the Codex runtime read-detector (the
audit classifier is the prototype).
- Pilot enablement playbook: run `audit-reads --simulate-maturation` on
target traffic → pick `quiesce_turns` → enable via env → watch cache hit
rate + `read_maturation:N` transform tags.
2026-06-16 20:21:13 -07:00

195 lines
6.8 KiB
Python

"""Tests for the audit-reads traffic audit (headroom.audit.reads)."""
from __future__ import annotations
import json
import pytest
from headroom.audit.reads import audit_reads, render_text
CONTENT = " 1\tdef foo():\n 2\t return 42\n" * 30 # >512B
def _line(role: str, content, ts: str = "2026-06-09T10:00:00Z") -> str:
return json.dumps({"message": {"role": role, "content": content}, "timestamp": ts})
def _tool_use(tc_id: str, name: str, inp: dict) -> dict:
return {"type": "tool_use", "id": tc_id, "name": name, "input": inp}
def _tool_result(tc_id: str, text: str) -> dict:
return {"type": "tool_result", "tool_use_id": tc_id, "content": text}
@pytest.fixture
def transcript_dir(tmp_path):
"""Synthetic session: read foo.py twice (identical), partial read
contained in the full read, edit foo.py, then a >5min gap."""
lines = [
_line("user", "look at foo.py", "2026-06-09T10:00:00Z"),
_line(
"assistant",
[_tool_use("r1", "Read", {"file_path": "/x/foo.py"})],
"2026-06-09T10:00:01Z",
),
_line("user", [_tool_result("r1", CONTENT)], "2026-06-09T10:00:02Z"),
_line(
"assistant",
[_tool_use("r2", "Read", {"file_path": "/x/foo.py"})],
"2026-06-09T10:00:03Z",
),
_line("user", [_tool_result("r2", CONTENT)], "2026-06-09T10:00:04Z"),
_line(
"assistant",
[_tool_use("r3", "Read", {"file_path": "/x/foo.py", "offset": 1, "limit": 2})],
"2026-06-09T10:00:05Z",
),
# Partial read: a strict substring of the earlier full read.
_line("user", [_tool_result("r3", CONTENT[: len(CONTENT) // 2])], "2026-06-09T10:00:06Z"),
_line(
"assistant",
[_tool_use("e1", "Edit", {"file_path": "/x/foo.py", "old_string": "a"})],
"2026-06-09T10:00:07Z",
),
_line("user", [_tool_result("e1", "ok")], "2026-06-09T10:00:08Z"),
# >5min gap before the next message.
_line("user", "back from lunch", "2026-06-09T10:20:00Z"),
]
proj = tmp_path / "projects" / "-x-demo"
proj.mkdir(parents=True)
(proj / "session1.jsonl").write_text("\n".join(lines))
return tmp_path / "projects"
class TestAuditReads:
def test_metrics(self, transcript_dir):
r = audit_reads(transcript_dir)
assert r.sessions == 1
assert r.read_calls == 3
assert r.dedup_identical_calls == 1 # r2 == r1
assert r.subset_calls == 1 # r3 ⊂ r1
# Mechanism rows size each opportunity independently, so a read
# can appear in more than one: r1 and r3 both precede the edit
# (stale), and r3 is also a subset of r1. Only identical-repeat
# excludes from stale (replacing a pointer twice is meaningless).
assert r.stale_calls == 2
assert r.gaps_over_5m == 1
assert r.sessions_with_gap == 1
assert r.linenum_overhead_bytes > 0
assert r.class_bytes.get("source code", 0) > 0
assert r.tool_bytes["Read"] == r.read_bytes
assert r.reads_per_file_max == 3
def test_render_text_runs(self, transcript_dir):
out = render_text(audit_reads(transcript_dir))
assert "Read opportunity sizing" in out
assert "identical repeat" in out
assert "cache-death windows" in out
def test_json_roundtrip(self, transcript_dir):
r = audit_reads(transcript_dir)
data = json.loads(r.to_json())
assert data["read_calls"] == 3
def test_malformed_lines_tolerated(self, tmp_path):
proj = tmp_path / "p"
proj.mkdir()
(proj / "bad.jsonl").write_text("not json\n{\n" + _line("user", "hi"))
r = audit_reads(tmp_path)
assert r.sessions == 1
assert r.read_calls == 0
def test_empty_dir(self, tmp_path):
r = audit_reads(tmp_path)
assert r.sessions == 0
class TestMaturationSim:
def test_metrics(self, transcript_dir):
from headroom.audit.maturation import simulate_maturation
r = simulate_maturation(transcript_dir)
assert r.read_calls == 3
# r2 and r3 target the already-read foo.py; r3 is partial.
assert r.rereads_any == 2
assert r.rereads_partial == 1
# CONTENT is ~1.2KB — below the 2KB maturation floor — so the
# big-read metrics stay empty on this fixture.
assert r.big_reads == 0
# The edit follows reads of the same file with touch-gap 1.
assert r.edits_with_prior_read == 1
assert r.at_risk_edits[1] == 0
def test_big_read_metrics(self, tmp_path):
from headroom.audit.maturation import MATURE_FLOOR, simulate_maturation
big = "x" * (MATURE_FLOOR + 100)
lines = [
_line("assistant", [_tool_use("r1", "Read", {"file_path": "/x/big.py"})]),
_line("user", [_tool_result("r1", big)]),
]
proj = tmp_path / "p"
proj.mkdir()
(proj / "s.jsonl").write_text("\n".join(lines))
r = simulate_maturation(tmp_path)
assert r.big_reads == 1
assert r.never_touched_again == 1
def test_render_runs(self, transcript_dir):
from headroom.audit.maturation import render_sim_text, simulate_maturation
out = render_sim_text(simulate_maturation(transcript_dir))
assert "maturation simulation" in out
assert "at-risk edits" in out
class TestCli:
def test_cli_text_and_json(self, transcript_dir):
from click.testing import CliRunner
from headroom.cli.main import main
runner = CliRunner()
res = runner.invoke(main, ["audit-reads", "--path", str(transcript_dir)])
assert res.exit_code == 0, res.output
assert "Read opportunity sizing" in res.output
res = runner.invoke(
main, ["audit-reads", "--path", str(transcript_dir), "--format", "json"]
)
assert res.exit_code == 0
assert json.loads(res.output)["sessions"] == 1
def test_cli_simulate_maturation(self, transcript_dir):
from click.testing import CliRunner
from headroom.cli.main import main
runner = CliRunner()
res = runner.invoke(
main, ["audit-reads", "--path", str(transcript_dir), "--simulate-maturation"]
)
assert res.exit_code == 0, res.output
assert "maturation simulation" in res.output
res = runner.invoke(
main,
[
"audit-reads",
"--path",
str(transcript_dir),
"--simulate-maturation",
"--format",
"json",
],
)
assert res.exit_code == 0
data = json.loads(res.output)
assert data["maturation_simulation"]["read_calls"] == 3
if __name__ == "__main__":
pytest.main([__file__, "-v"])