mirror of
https://github.com/headroomlabs-ai/headroom.git
synced 2026-08-27 14:17:10 -04:00
b08ec15b0d
## Description
Adds native Bedrock `POST /model/{model_id}/converse-stream` routing in
`headroom-proxy` by reusing the existing streaming handler and
preserving route-specific upstream action forwarding.
This addresses a gap where native Bedrock streaming support existed for
`invoke-with-response-stream` but not `converse-stream`, even though
both share the same EventStream transport and SSE translation path in
this proxy.
Fixes #919
## Type of Change
- [x] Bug fix (non-breaking change that fixes an issue)
- [ ] New feature (non-breaking change that adds functionality)
- [ ] Breaking change
- [ ] Documentation update
- [ ] Performance improvement
- [ ] Code refactoring
## Changes Made
- Add route mount in `crates/headroom-proxy/src/proxy.rs`:
- `POST /model/:model_id/converse-stream` ->
`bedrock::invoke_streaming::handle_invoke_streaming`
- Update streaming handler URL construction in
`crates/headroom-proxy/src/bedrock/invoke_streaming.rs`:
- infer action from inbound path (`invoke-with-response-stream` or
`converse-stream`)
- build upstream URL with the resolved action
- return structured `400` for unsupported streaming action paths
- Add unit tests in
`crates/headroom-proxy/src/bedrock/invoke_streaming.rs`:
- action extraction coverage for both streaming paths
- upstream URL construction coverage for `converse-stream`
- Add integration coverage in
`crates/headroom-proxy/tests/integration_bedrock_streaming.rs`:
- `converse_stream_route_translates_to_sse`
- Add changelog entry under `Unreleased` bug fixes in `CHANGELOG.md`.
## Testing
- `cargo fmt --all`
- `cargo test -p headroom-proxy --test integration_bedrock_streaming --
--nocapture`
- `cargo test -p headroom-proxy --test integration_bedrock_metrics --
--nocapture`
## Real behavior proof
- **Setup tested on**
- macOS (darwin)
- Rust workspace local dev build
- `headroom-proxy` integration tests using wiremock upstream (no AWS
dependency)
- **Exact commands run after patch**
- `cargo test -p headroom-proxy --test integration_bedrock_streaming --
--nocapture`
- `cargo test -p headroom-proxy --test integration_bedrock_metrics --
--nocapture`
- **After-fix evidence + observed result**
- New integration test `converse_stream_route_translates_to_sse` passes.
- Streaming suite result: `10 passed; 0 failed`.
- Metrics suite result: `4 passed; 0 failed`.
- Logs show requests reaching `/model/.../converse-stream` and flowing
through Bedrock streaming path.
- **What I did not test**
- Live AWS Bedrock calls against real credentials/models.
- End-to-end CLI/runtime behavior outside Rust integration test harness.
|
||
|---|---|---|
| .. | ||
| common | ||
| fixtures | ||
| e2e_real.rs | ||
| integration_bedrock_authmode.rs | ||
| integration_bedrock_invoke.rs | ||
| integration_bedrock_metrics.rs | ||
| integration_bedrock_streaming.rs | ||
| integration_body.rs | ||
| integration_body_size.rs | ||
| integration_cache_control.rs | ||
| integration_cache_drift.rs | ||
| integration_chat_completions.rs | ||
| integration_compression.rs | ||
| integration_conversations.rs | ||
| integration_e3_anthropic_cache_control.rs | ||
| integration_e4_openai_cache_key.rs | ||
| integration_headers.rs | ||
| integration_health.rs | ||
| integration_http.rs | ||
| integration_metrics.rs | ||
| integration_request_id.rs | ||
| integration_responses.rs | ||
| integration_responses_streaming.rs | ||
| integration_schema_sort.rs | ||
| integration_sse.rs | ||
| integration_tool_sort.rs | ||
| integration_vertex_raw_predict.rs | ||
| integration_volatile_detector.rs | ||
| integration_ws.rs | ||
| sse_anthropic.rs | ||
| sse_framing.rs | ||
| sse_openai_chat.rs | ||
| sse_openai_responses.rs | ||