mirror of
https://github.com/headroomlabs-ai/headroom.git
synced 2026-08-27 14:17:10 -04:00
d6259b2263
## Description Extracts memory tool injection stickiness configuration parsing from `headroom.proxy.helpers` into a focused policy module. The existing helper functions remain in place for the session tool tracker and sticky injection helpers. Closes # ## Type of Change - [ ] Bug fix (non-breaking change that fixes an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Performance improvement - [x] Code refactoring (no functional changes) ## Changes Made - Added `headroom.proxy.tool_injection_policy` for tool sticky mode and tracker session limit resolution. - Kept `get_tool_injection_sticky_mode()` and `get_tool_tracker_max_sessions()` as compatibility wrappers in `helpers.py`. - Added direct unit tests for defaults, accepted values, and loud rejection of invalid operator configuration. ## Testing - [x] Unit tests pass (`pytest`) - [x] Linting passes (`ruff check .`) - [x] Type checking passes (`mypy headroom`) - [x] New tests added for new functionality - [ ] Manual testing performed ### Test Output ```text python -m pytest tests/test_tool_injection_policy.py tests/test_memory_tool_session_sticky.py 38 passed in 0.44s python -m ruff check . All checks passed! python -m ruff format --check . 1069 files already formatted python -m mypy headroom --ignore-missing-imports Success: no issues found in 410 source files gitleaks protect --staged --no-banner --redact no leaks found ``` ## Real Behavior Proof - Environment: Windows, Python 3.13.13 - Exact command / steps: Ran focused tool injection policy tests, existing memory tool sticky suite, full ruff, format check, mypy, and staged gitleaks scan. - Observed result: Existing sticky memory-tool behavior remains green while extracted policy parsing is covered directly. - Not tested: Full repository pytest suite locally; CI covers the broader matrix. ## Review Readiness - [x] I have performed a self-review - [x] This PR is ready for human review ## Checklist - [x] My code follows the project's style guidelines - [x] I have performed a self-review of my code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] I have updated the CHANGELOG.md if applicable ## Screenshots (if applicable) N/A ## Additional Notes Documentation and changelog updates are not applicable for this internal refactor. The default-branch Dependabot alerts reported during push are pre-existing and unrelated to this PR. Co-authored-by: Tejas Chopra <chopratejas@gmail.com>
42 lines
1.6 KiB
Python
42 lines
1.6 KiB
Python
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
from headroom.proxy.tool_injection_policy import (
|
|
TOOL_INJECTION_STICKY_ENV,
|
|
TOOL_TRACKER_MAX_SESSIONS_DEFAULT,
|
|
TOOL_TRACKER_MAX_SESSIONS_ENV,
|
|
resolve_tool_injection_sticky_mode,
|
|
resolve_tool_tracker_max_sessions,
|
|
)
|
|
|
|
|
|
def test_resolve_tool_injection_sticky_mode_defaults_to_enabled() -> None:
|
|
assert resolve_tool_injection_sticky_mode(None) == "enabled"
|
|
assert resolve_tool_injection_sticky_mode(" ") == "enabled"
|
|
|
|
|
|
def test_resolve_tool_injection_sticky_mode_accepts_known_values() -> None:
|
|
assert resolve_tool_injection_sticky_mode("ENABLED") == "enabled"
|
|
assert resolve_tool_injection_sticky_mode(" disabled ") == "disabled"
|
|
|
|
|
|
def test_resolve_tool_injection_sticky_mode_rejects_unknown_values() -> None:
|
|
with pytest.raises(ValueError, match=TOOL_INJECTION_STICKY_ENV):
|
|
resolve_tool_injection_sticky_mode("maybe")
|
|
|
|
|
|
def test_resolve_tool_tracker_max_sessions_defaults() -> None:
|
|
assert resolve_tool_tracker_max_sessions(None) == TOOL_TRACKER_MAX_SESSIONS_DEFAULT
|
|
assert resolve_tool_tracker_max_sessions(" ") == TOOL_TRACKER_MAX_SESSIONS_DEFAULT
|
|
|
|
|
|
def test_resolve_tool_tracker_max_sessions_accepts_positive_int() -> None:
|
|
assert resolve_tool_tracker_max_sessions("42") == 42
|
|
assert resolve_tool_tracker_max_sessions(" 7 ") == 7
|
|
|
|
|
|
@pytest.mark.parametrize("raw", ["0", "-1", "not-int", "1.5"])
|
|
def test_resolve_tool_tracker_max_sessions_rejects_invalid_values(raw: str) -> None:
|
|
with pytest.raises(ValueError, match=TOOL_TRACKER_MAX_SESSIONS_ENV):
|
|
resolve_tool_tracker_max_sessions(raw)
|