mirror of
https://github.com/headroomlabs-ai/headroom.git
synced 2026-08-27 14:17:10 -04:00
## Description tree-sitter reports node positions as byte offsets into the UTF-8 encoding, but `CodeStructureHandler` builds a character-indexed mask. Any multi-byte character (accents, emoji, CJK in docstrings/comments/strings) shifted every subsequent span, preserving the wrong characters and leaking signature bytes into bodies. Stacked on #890. Closes # <!-- compression-handler review --> ## Type of Change - [x] Bug fix (non-breaking change that fixes an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Performance improvement - [ ] Code refactoring (no functional changes) ## Changes Made - `headroom/compression/handlers/code_handler.py`: remap spans through a byte->char table before masking; pure-ASCII content (byte == char) skips the conversion. - `tests/test_compression/test_code_handler.py`: regression test with `café münü 🎉` in a comment, asserting the following signature and body are correctly aligned. ## Testing - [x] Unit tests pass (`pytest`) - [x] Linting passes (`ruff check .`) - [x] Type checking passes (`mypy headroom`) - [x] New tests added for new functionality - [x] Manual testing performed ### Test Output ```text $ pytest tests/test_compression/ -q 93 passed, 8 skipped ``` ## Real Behavior Proof - Environment: local macOS, Python 3.11, tree-sitter-language-pack 1.8.1, branch `fix/code-byte-char-offsets` (stacked on #890). - Exact command / steps: `pytest tests/test_compression/ -q`. - Observed result: With 9 extra UTF-8 bytes ahead of it, a function signature is exactly preserved and its body stays compressible; before, the offsets were shifted. - Not tested: End-to-end through the live proxy pipeline. ## Review Readiness - [x] I have performed a self-review - [x] This PR is ready for human review ## Checklist - [x] My code follows the project's style guidelines - [x] I have performed a self-review of my code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] I have updated the CHANGELOG.md if applicable ## Screenshots (if applicable) N/A — library change. See Test Output. ## Additional Notes Stacked on #890 — review the top commit until that merges. PR 4 of 7. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
178 lines
6.7 KiB
Python
178 lines
6.7 KiB
Python
"""Tests for code structure handler."""
|
|
|
|
import pytest
|
|
|
|
from headroom.compression.handlers.code_handler import (
|
|
CodeStructureHandler,
|
|
is_tree_sitter_available,
|
|
)
|
|
|
|
requires_tree_sitter = pytest.mark.skipif(
|
|
not is_tree_sitter_available(),
|
|
reason="tree-sitter-language-pack not installed",
|
|
)
|
|
|
|
|
|
class TestCanHandle:
|
|
@pytest.fixture
|
|
def handler(self):
|
|
return CodeStructureHandler()
|
|
|
|
def test_detects_python(self, handler):
|
|
assert handler.can_handle("def foo():\n pass\n") is True
|
|
|
|
def test_detects_javascript(self, handler):
|
|
assert handler.can_handle("function foo() { return 1; }") is True
|
|
|
|
def test_rejects_prose(self, handler):
|
|
assert handler.can_handle("This is a plain sentence.") is False
|
|
|
|
|
|
class TestRegexFallback:
|
|
"""Regex path runs regardless of tree-sitter availability."""
|
|
|
|
@pytest.fixture
|
|
def handler(self):
|
|
return CodeStructureHandler(use_tree_sitter=False)
|
|
|
|
def test_python_signature_preserved_body_compressible(self, handler):
|
|
code = "def hello(name: str) -> str:\n message = name\n return message\n"
|
|
result = handler.get_mask(code, language="python")
|
|
|
|
assert result.metadata["parser"] == "regex"
|
|
sig = "def hello(name: str) -> str:"
|
|
start = code.index(sig)
|
|
assert all(result.mask.mask[i] for i in range(start, start + len(sig)))
|
|
|
|
body_char = code.index("message = name")
|
|
assert result.mask.mask[body_char] is False
|
|
|
|
def test_python_import_preserved(self, handler):
|
|
code = "import os\n\nx = 1\n"
|
|
result = handler.get_mask(code, language="python")
|
|
assert all(result.mask.mask[i] for i in range(len("import os")))
|
|
|
|
|
|
@requires_tree_sitter
|
|
class TestTreeSitterContainers:
|
|
"""Container bodies must stay compressible (signature-only spans).
|
|
|
|
Regression: class_definition / decorated_definition / impl_item were
|
|
marked structural over their FULL span, so every method body inside a
|
|
class (i.e. most real code) was preserved and compression no-opped at
|
|
confidence 0.95.
|
|
"""
|
|
|
|
@pytest.fixture
|
|
def handler(self):
|
|
return CodeStructureHandler()
|
|
|
|
def test_class_method_bodies_compressible(self, handler):
|
|
code = (
|
|
"class Foo:\n"
|
|
" def method_a(self):\n"
|
|
" body_line_a = 1\n"
|
|
" return body_line_a\n"
|
|
"\n"
|
|
" def method_b(self):\n"
|
|
" body_line_b = 2\n"
|
|
" return body_line_b\n"
|
|
)
|
|
result = handler.get_mask(code, language="python")
|
|
assert result.metadata["parser"] == "tree-sitter"
|
|
|
|
# Class signature and method signatures preserved
|
|
assert all(result.mask.mask[i] for i in range(len("class Foo:")))
|
|
sig = "def method_a(self):"
|
|
start = code.index(sig)
|
|
assert all(result.mask.mask[i] for i in range(start, start + len(sig)))
|
|
|
|
# Method bodies compressible
|
|
for body in ("body_line_a = 1", "body_line_b = 2"):
|
|
start = code.index(body)
|
|
assert not any(result.mask.mask[i] for i in range(start, start + len(body))), (
|
|
f"method body {body!r} must be compressible"
|
|
)
|
|
|
|
def test_decorated_function_body_compressible(self, handler):
|
|
code = "@decorator\ndef decorated():\n body_line = 4\n return body_line\n"
|
|
result = handler.get_mask(code, language="python")
|
|
|
|
# Decorator and signature preserved
|
|
assert all(result.mask.mask[i] for i in range(len("@decorator")))
|
|
sig = "def decorated():"
|
|
start = code.index(sig)
|
|
assert all(result.mask.mask[i] for i in range(start, start + len(sig)))
|
|
|
|
# Body compressible
|
|
start = code.index("body_line = 4")
|
|
assert not any(result.mask.mask[i] for i in range(start, start + len("body_line = 4"))), (
|
|
"decorated function body must be compressible"
|
|
)
|
|
|
|
def test_module_function_body_compressible(self, handler):
|
|
code = "def standalone():\n body_line = 3\n return body_line\n"
|
|
result = handler.get_mask(code, language="python")
|
|
|
|
start = code.index("body_line = 3")
|
|
assert not any(result.mask.mask[i] for i in range(start, start + len("body_line = 3")))
|
|
|
|
def test_rust_impl_method_bodies_compressible(self, handler):
|
|
code = (
|
|
"struct Foo { x: i32 }\n"
|
|
"impl Foo {\n"
|
|
" fn method(&self) -> i32 {\n"
|
|
" let body_line = 5;\n"
|
|
" body_line\n"
|
|
" }\n"
|
|
"}\n"
|
|
)
|
|
result = handler.get_mask(code, language="rust")
|
|
|
|
# impl signature preserved
|
|
start = code.index("impl Foo")
|
|
assert all(result.mask.mask[i] for i in range(start, start + len("impl Foo")))
|
|
|
|
# method body compressible
|
|
start = code.index("let body_line = 5;")
|
|
assert not any(
|
|
result.mask.mask[i] for i in range(start, start + len("let body_line = 5;"))
|
|
), "impl method body must be compressible"
|
|
|
|
def test_non_ascii_content_mask_alignment(self, handler):
|
|
"""Byte offsets must be converted to char offsets.
|
|
|
|
Regression: tree-sitter reports byte offsets into the UTF-8
|
|
encoding, but the mask is char-indexed. Multi-byte characters
|
|
(here: accents + an emoji, 9 extra bytes) shifted every later
|
|
span, preserving the wrong characters.
|
|
"""
|
|
code = (
|
|
"# café münü 🎉 comment\n"
|
|
"def target(x: int) -> int:\n"
|
|
" body_value = 9\n"
|
|
" return body_value\n"
|
|
)
|
|
result = handler.get_mask(code, language="python")
|
|
|
|
sig = "def target(x: int) -> int:"
|
|
start = code.index(sig)
|
|
assert all(result.mask.mask[i] for i in range(start, start + len(sig))), (
|
|
"signature after non-ASCII content must be exactly preserved"
|
|
)
|
|
|
|
bstart = code.index("body_value = 9")
|
|
assert not any(
|
|
result.mask.mask[i] for i in range(bstart, bstart + len("body_value = 9"))
|
|
), "body after non-ASCII content must stay compressible"
|
|
|
|
def test_preservation_ratio_sane_for_class_code(self, handler):
|
|
"""A class with substantial method bodies should NOT preserve
|
|
everything — the whole point of the handler."""
|
|
body = "\n".join(f" line_{i} = {i}" for i in range(20))
|
|
code = f"class Big:\n def method(self):\n{body}\n return 0\n"
|
|
result = handler.get_mask(code, language="python")
|
|
assert result.preservation_ratio < 0.5, (
|
|
f"class code preserved {result.preservation_ratio:.0%} — "
|
|
"container bodies are leaking into the structural mask"
|
|
)
|