mirror of
https://github.com/headroomlabs-ai/headroom.git
synced 2026-08-27 14:17:10 -04:00
1aa701adaa
## Description Fixes #2492, #2028, and #2827. Claude daemon workers consume project settings rather than reliably inheriting wrapper environment state, while the Claude VS Code webview cannot render deferred-tool response blocks. Separately, recent Copilot Chat versions use the whole CAPI override for generation; the legacy proxy override alone only sends model discovery through Headroom. This PR carries both integrations through to the actual consumers instead of only changing their launch-time surface configuration. ## Type of Change - [x] Bug fix - [ ] New feature - [ ] Breaking change - [ ] Documentation update - [ ] Build / CI ## Changes Made - Persist the resolved Claude ENABLE_TOOL_SEARCH value into project settings for daemon workers and restore it transactionally after wrap exits. - Use compatibility-safe Foundry and Claude VS Code defaults while preserving explicit user choices. - Configure both Copilot overrideProxyUrl and overrideCapiUrl in the reversible managed VS Code settings block. - Route Copilot unprefixed POST /chat/completions and HTTP /responses requests through the real compression handlers. - Keep /responses out of the Codex WebSocket aliases because Copilot and Codex use different WebSocket wire protocols. - Extend wrap E2E assertions for both the Claude webview mode and Copilot CAPI routing. ## Testing - [x] 127 combined Claude, Copilot, route-integration, and MCP dependency-contract tests pass. - [x] Ruff check passes on all changed Python files. - [x] Ruff format check passes. - [x] Python compilation and git diff --check pass. ## Runtime Safety Standalone Claude CLI defaults remain unchanged. Explicit Claude tool-search values retain precedence, and project settings are restored through the existing cleanup path. Copilot model/session helper endpoints continue through generic passthrough, while only validated HTTP generation paths receive explicit compression routes. Existing Codex WebSocket behavior is unchanged. ## Review Readiness - [x] Current main and MCP v1 compatibility retained - [x] Worker-facing Claude persistence covered - [x] Reversible Copilot and Claude settings behavior covered - [x] Copilot generation routes covered at registration and proxy integration layers - [x] Ready for review
62 lines
2.2 KiB
Python
62 lines
2.2 KiB
Python
"""CLI coverage for Claude Code inside VS Code."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
from pathlib import Path
|
|
from unittest.mock import patch
|
|
|
|
from click.testing import CliRunner
|
|
|
|
from headroom.cli.main import main
|
|
|
|
|
|
def test_wrap_vscode_claude_configures_actual_port(tmp_path: Path) -> None:
|
|
path = tmp_path / "settings.json"
|
|
captured = {}
|
|
|
|
def fake_watcher(**kwargs): # noqa: ANN003, ANN202
|
|
captured.update(kwargs)
|
|
kwargs["print_setup_lines"](9999)
|
|
|
|
with patch("headroom.cli.wrap._run_proxy_only_watcher", side_effect=fake_watcher):
|
|
result = CliRunner().invoke(main, ["wrap", "vscode-claude", "--settings-file", str(path)])
|
|
|
|
assert result.exit_code == 0, result.output
|
|
env = json.loads(path.read_text(encoding="utf-8"))["env"]
|
|
assert env["ANTHROPIC_BASE_URL"].startswith("http://127.0.0.1:9999/p/")
|
|
assert env["ENABLE_TOOL_SEARCH"] == "false"
|
|
assert "Reload VS Code" in result.output
|
|
assert captured["agent_type"] == "claude"
|
|
|
|
|
|
def test_wrap_vscode_claude_no_configure_prints_settings(tmp_path: Path) -> None:
|
|
path = tmp_path / "settings.json"
|
|
|
|
def fake_watcher(**kwargs): # noqa: ANN003, ANN202
|
|
kwargs["print_setup_lines"](8787)
|
|
|
|
with patch("headroom.cli.wrap._run_proxy_only_watcher", side_effect=fake_watcher):
|
|
result = CliRunner().invoke(
|
|
main,
|
|
["wrap", "vscode-claude", "--no-configure", "--settings-file", str(path)],
|
|
)
|
|
|
|
assert result.exit_code == 0, result.output
|
|
assert not path.exists()
|
|
assert "ANTHROPIC_BASE_URL" in result.output
|
|
assert "ENABLE_TOOL_SEARCH" in result.output
|
|
|
|
|
|
def test_unwrap_vscode_claude_restores_previous_settings(tmp_path: Path) -> None:
|
|
path = tmp_path / "settings.json"
|
|
original = {"env": {"KEEP": "1"}, "permissions": {"allow": ["Read"]}}
|
|
path.write_text(json.dumps(original), encoding="utf-8")
|
|
|
|
from headroom.providers.claude.vscode import configure_vscode_claude_settings
|
|
|
|
configure_vscode_claude_settings(path, "http://127.0.0.1:8787/p/demo")
|
|
result = CliRunner().invoke(main, ["unwrap", "vscode-claude", "--settings-file", str(path)])
|
|
|
|
assert result.exit_code == 0, result.output
|
|
assert json.loads(path.read_text(encoding="utf-8")) == original
|