headroom/tests/test_copilot_provider_label.py
Serge ARADJ d7a8cdbee1
feat(proxy): label GitHub Copilot traffic as "copilot" in the outcome… (#2377)
## Description

Requests routed to the GitHub Copilot API travel on the OpenAI or
Anthropic
wire, so the proxy handlers stamp the *wire* provider (`openai` /
`anthropic`)
on the outcome. As a result, Copilot traffic is attributed to
OpenAI/Claude in
the dashboard's per-request provider stats, hiding the real upstream.
(This is
distinct from the existing **Copilot Quota** panel, which is separate
from
per-request provider attribution.)

This labels Copilot traffic as `copilot` in the single outcome funnel.
`build_copilot_upstream_url()` is already the one routing chokepoint
every
Copilot surface goes through (OpenAI `/chat/completions` + `/responses`
and the
Anthropic `/v1/messages` route all build their upstream URL there), so
it flags
the request via a task-local `ContextVar`; `emit_request_outcome()`
reads the
flag and relabels the provider. The relabel runs before the `>= 500`
failed
guard, so a failed Copilot request is attributed to `copilot` too.
Non-Copilot
traffic never sets the flag and is untouched.

## Type of Change

- [x] New feature (non-breaking change that adds functionality)

## Changes Made

- `headroom/copilot_auth.py`: add a task-local
`_request_routed_to_copilot`
`ContextVar` with `mark_request_routed_to_copilot()` /
`request_routed_to_copilot()`
helpers; set the flag in `build_copilot_upstream_url()` whenever the
base is a
  Copilot API URL (the existing `is_copilot_api_url` check). `/v1` path
  normalization is unchanged.
- `headroom/proxy/outcome.py`: in `emit_request_outcome()`, when the
request was
routed to Copilot and the wire provider is `openai`/`anthropic`, relabel
the
  outcome provider to `copilot` (before the 5xx guard).
- `tests/test_copilot_provider_label.py`: new tests for the chokepoint
marking
  and the outcome relabel.

## Testing

- [x] Unit tests pass (`pytest`)
- [ ] Linting passes (`ruff check .`) — ran on the changed files only
(clean)
- [ ] Type checking passes (`mypy headroom`) — ran on the changed files
only (clean)
- [x] New tests added for new functionality
- [ ] Manual testing performed

### Test Output

```text
$ python -m pytest tests/test_copilot_provider_label.py tests/test_outcome_records_5xx_as_failed.py -q
tests/test_copilot_provider_label.py .....                               [ 71%]
tests/test_outcome_records_5xx_as_failed.py ..                           [100%]
7 passed

$ python -m pytest tests/test_copilot_auth.py -k "build_copilot_upstream_url or copilot_api_url" -q
8 passed, 58 deselected      # existing /v1-stripping behavior preserved

$ python -m ruff check headroom/copilot_auth.py headroom/proxy/outcome.py tests/test_copilot_provider_label.py
All checks passed!

$ python -m mypy headroom/copilot_auth.py headroom/proxy/outcome.py
Success: no issues found in 2 source files
```

## Real Behavior Proof

- Environment: Python 3.11, headroom installed with the `proxy` extra.
- Exact command / steps: the unit tests above drive
`build_copilot_upstream_url()`
followed by `emit_request_outcome()` in an isolated context and assert
the
  recorded provider.
- Observed result: an `anthropic`/`openai` outcome for a request routed
to
`https://api.githubcopilot.com` is recorded as provider `copilot`; a
request
  not routed to Copilot is recorded under its wire provider unchanged.
- Not tested: end-to-end against a live Copilot subscription (no live
seat in the
  test environment).

## Review Readiness

- [x] I have performed a self-review
- [x] This PR is ready for human review

## Additional Notes

- The flag is a `ContextVar` (task-local), so it cannot bleed across
concurrent
requests; each request that is not routed to Copilot simply reads the
`False`
  default.
- No `CHANGELOG.md` edits (release-please generates it from the
Conventional
  Commit PR title).

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: JerrettDavis <mxjerrett@gmail.com>
2026-07-18 09:54:06 -07:00

136 lines
4.9 KiB
Python

"""GitHub Copilot traffic must be labeled provider "copilot" in the outcome
funnel, even though it travels on the OpenAI/Anthropic wire.
``build_copilot_upstream_url`` is the single routing chokepoint for every
Copilot surface (OpenAI chat/responses and Anthropic messages all build their
upstream URL there), so it flags the request; ``emit_request_outcome`` reads
the flag and relabels the provider. The flag is a task-local ContextVar, so it
never bleeds across concurrent requests.
"""
import asyncio
import contextvars
from headroom import copilot_auth
from headroom.proxy.outcome import RequestOutcome, emit_request_outcome
COPILOT = "https://api.githubcopilot.com"
def _run_isolated(fn):
"""Run ``fn`` in a fresh context so the per-request
ContextVar set by one test never leaks into the next."""
return contextvars.Context().run(fn)
# --- chokepoint marking -----------------------------------------------------
def test_build_url_marks_request_routed_to_copilot() -> None:
def scenario() -> bool:
assert copilot_auth.request_routed_to_copilot() is False
copilot_auth.build_copilot_upstream_url(COPILOT, "/v1/chat/completions")
return copilot_auth.request_routed_to_copilot()
assert _run_isolated(scenario) is True
def test_build_url_does_not_mark_non_copilot_hosts() -> None:
def scenario() -> bool:
copilot_auth.build_copilot_upstream_url("https://api.openai.com", "/v1/chat/completions")
return copilot_auth.request_routed_to_copilot()
assert _run_isolated(scenario) is False
def test_build_url_clears_stale_flag_for_non_copilot_hosts() -> None:
def scenario() -> bool:
copilot_auth.build_copilot_upstream_url(COPILOT, "/v1/messages")
assert copilot_auth.request_routed_to_copilot() is True
copilot_auth.build_copilot_upstream_url("https://api.openai.com", "/v1/chat/completions")
return copilot_auth.request_routed_to_copilot()
assert _run_isolated(scenario) is False
# --- outcome relabeling -----------------------------------------------------
class _Metrics:
def __init__(self) -> None:
self.failed: list[str] = []
async def record_failed(self, provider: str) -> None:
self.failed.append(provider)
class _Handler:
# Exposes ONLY .metrics: a >=500 outcome must relabel and then hit the
# failed-request guard without touching the success funnel.
def __init__(self) -> None:
self.metrics = _Metrics()
def _outcome(provider: str, status_code: int) -> RequestOutcome:
return RequestOutcome(
request_id="req-1",
provider=provider,
model="claude-opus-4-8",
original_tokens=0,
optimized_tokens=0,
output_tokens=0,
tokens_saved=0,
attempted_input_tokens=0,
status_code=status_code,
)
def test_relabels_anthropic_to_copilot_when_routed() -> None:
def scenario() -> _Handler:
copilot_auth.build_copilot_upstream_url(COPILOT, "/v1/messages")
handler = _Handler()
asyncio.run(emit_request_outcome(handler, _outcome("anthropic", 503)))
return handler
handler = _run_isolated(scenario)
# Relabeled before the 5xx guard, so even a failed Copilot request is
# attributed to "copilot" rather than the wire provider.
assert handler.metrics.failed == ["copilot"]
def test_relabels_openai_to_copilot_when_routed() -> None:
def scenario() -> _Handler:
copilot_auth.build_copilot_upstream_url(COPILOT, "/v1/chat/completions")
handler = _Handler()
asyncio.run(emit_request_outcome(handler, _outcome("openai", 503)))
return handler
handler = _run_isolated(scenario)
assert handler.metrics.failed == ["copilot"]
def test_no_relabel_when_not_routed_to_copilot() -> None:
def scenario() -> _Handler:
handler = _Handler()
asyncio.run(emit_request_outcome(handler, _outcome("anthropic", 503)))
return handler
handler = _run_isolated(scenario)
assert handler.metrics.failed == ["anthropic"]
def test_flag_does_not_leak_to_a_later_outcome_in_the_same_context() -> None:
# Regression: the Copilot flag is a ContextVar whose value persists until
# overwritten. Within one execution context (e.g. successive messages on a
# single long-lived WebSocket task), a Copilot request followed by a
# non-Copilot one must NOT relabel the second. emit_request_outcome consumes
# (reads AND clears) the flag, so only the first outcome is labeled copilot.
async def scenario() -> _Handler:
copilot_auth.build_copilot_upstream_url(COPILOT, "/v1/messages")
handler = _Handler()
await emit_request_outcome(handler, _outcome("anthropic", 503)) # routed
await emit_request_outcome(handler, _outcome("openai", 503)) # not routed
return handler
handler = asyncio.run(scenario())
assert handler.metrics.failed == ["copilot", "openai"]