drop-oss/drop
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

docs(design): correct the slug-to-provider-key mapping

Browse source 
Two of three match (eqemu, daoc) but wow does not - Drop names the game,
the provider names the emulator (trinitycore). Needs one explicit alias
constant, not an assumption that slug == key. Asserted in mmo-portal's
tests so a rename breaks a test rather than the mapping.
This commit is contained in:
wdunn001 2026-08-07 18:16:05 -04:00
parent 0572321b5d
commit 1e1f005f76
1 changed files with 19 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

21
docs/design/0002-game-account-management.md
View file

@ -84,8 +84,25 @@ with `slug`, `kind`, `host`, `port`, `protocol`, live `status` /
`joinInstructions` and `deepLink`. Slugs are stable and hand-picked
(`eqemu`, `wow`, `daoc`) and are already the join key chat uses.
**That slug is the whole integration.** `GameServer.slug` ↔ mmo-portal
`provider.key`. No new identifier, no mapping table.
**That slug is very nearly the whole integration.** `GameServer.slug` ↔
mmo-portal `provider.key`:
| Drop `GameServer.slug` | provider `key` | |
|---|---|---|
| `eqemu` | `eqemu` | matches |
| `daoc` | `daoc` | matches |
| `wow` | `trinitycore` | **does not match** |
Two of three agree; WoW does not, because Drop names the *game* and the
provider names the *emulator*. So Drop needs one explicit alias map rather
than assuming `slug == key` — a three-entry constant, not a table. Do not
"fix" this by renaming either side: `GameServer.slug` is already load-bearing
for chat's `KNOWN_SERVERS` match (see `community-servers.prisma`), and
`provider.key` is the registry lookup used across mmo-portal's routes,
templates and its own SQLite link rows.
Asserted in `mmo-portal/tests/test_internal_api.py` so a rename breaks a test
instead of silently breaking the mapping.
## Coverage