pr-check: Fix some comments
This commit is contained in:
parent
f01a7a0205
commit
cb8c8f6e45
1 changed files with 5 additions and 5 deletions
10
.github/workflows/pr-check.yml
vendored
10
.github/workflows/pr-check.yml
vendored
|
|
@ -150,13 +150,13 @@ jobs:
|
|||
|
||||
if [ "$CONTAINS_MASTER" = "true" ]; then
|
||||
echo "PR contains commits from master branch"
|
||||
REVIEW_COMMENT_LINES+=("- PR contains commits from master branch")
|
||||
REVIEW_COMMENT_LINES+=("- PR does not contain commits from the [master branch](https://github.com/flathub/flathub/commits/master/)")
|
||||
BLOCKED=1
|
||||
fi
|
||||
|
||||
if [ "$EXIT_CODE" -ne 0 ]; then
|
||||
echo "PR title validation failed"
|
||||
REVIEW_COMMENT_LINES+=("- PR title should be `Add $FLATPAK_ID`")
|
||||
REVIEW_COMMENT_LINES+=("- PR title is `Add $FLATPAK_ID`")
|
||||
BLOCKED=1
|
||||
fi
|
||||
|
||||
|
|
@ -167,11 +167,11 @@ jobs:
|
|||
|
||||
if [ "$CHECKLIST_PRESENT" -eq 0 ]; then
|
||||
echo "No checklist present in PR body"
|
||||
REVIEW_COMMENT_LINES+=("- No checklist present in PR body")
|
||||
REVIEW_COMMENT_LINES+=("- All [checklists](https://github.com/flathub/flathub/blob/master/.github/pull_request_template.md?plain=1) are completed")
|
||||
BLOCKED=1
|
||||
elif [ "$UNCHECKED" -gt 0 ]; then
|
||||
echo "Checklist incomplete in PR body"
|
||||
REVIEW_COMMENT_LINES+=("- Some checklist items are not checked")
|
||||
REVIEW_COMMENT_LINES+=("- All [checklists](https://github.com/flathub/flathub/blob/master/.github/pull_request_template.md?plain=1) are completed")
|
||||
BLOCKED=1
|
||||
fi
|
||||
|
||||
|
|
@ -180,7 +180,7 @@ jobs:
|
|||
|
||||
if [ -z "$REQUIRED_CHECKED" ]; then
|
||||
echo "Required checklist not found in PR body"
|
||||
REVIEW_COMMENT_LINES+=("- Required submission checklist not marked as complete")
|
||||
REVIEW_COMMENT_LINES+=("- All [checklists](https://github.com/flathub/flathub/blob/master/.github/pull_request_template.md?plain=1) are completed")
|
||||
BLOCKED=1
|
||||
fi
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue