drop-oss/libtailscale-drop
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

libtailscale: take a C.int, not a Go int

Browse source 
This was compiling because of the implicit integer conversion on the C
side. But -1 was becoming INT32MAX. Which was an invalid fd, so the logs
were hidden just as if the fd were -1. But it filled strace with EBADF.

Signed-off-by: David Crawshaw <crawshaw@tailscale.com>
This commit is contained in:
David Crawshaw 2023-03-07 13:58:46 -05:00 • committed by David Crawshaw
parent 56cb66829f
commit 926893f68c
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tailscale.go
View file

@ -349,7 +349,7 @@ func TsnetSetEphemeral(sd C.int, e int) C.int {
}
//export TsnetSetLogFD
func TsnetSetLogFD(sd C.int, fd int) C.int {
func TsnetSetLogFD(sd, fd C.int) C.int {
s, err := getServer(sd)
if err != nil {
return s.recErr(err)