Commit graph

5 commits

Author SHA1 Message Date
Dan Smith
fe90410c2a Capture and show driver messages during load
This makes us capture and display any warning or error log messages
that the driver emits while we're loading it (but no other times).
While this is sort of a hack, it provides a conduit for the driver's
sanity-checking routines to communicate concerns to the UI user, such
as un-parse-able CSV lines, etc. Actual failures to parse the image
should of course still raise an exception to stop the process.

Fixes: #11093
2024-01-29 18:30:42 -08:00
Dan Smith
5ad747a0bd Style cleanups for tests/ 2023-03-10 18:07:04 -08:00
Dan Smith
bc7d1df77b Add missing Icom IC-E90 test image
This also fixes the detect test, which fails to consider sub devices
as subclasses of the original rclass of a dynamic alias.

We probably need to not use the dynamic alias nonsense for actual
non-alias matches.

Related to #10304
2023-01-24 16:22:26 -08:00
Dan Smith
aad93d3cf4 Clean up extreme chattiness in match_model()
We've got a ton of chatty match_model() methods in drivers that make
a ton of useless noise in everyone's debug logs which makes
debugging harder. Shut them up.
2023-01-19 15:04:53 -08:00
Dan Smith
06176e6202 Massive driver test refactor
This has been a long time coming. Our tests have always been a bit
weird because when we added them, there weren't great ways of loading
dynamic test classes with the runners at the time. That is now much
better. With everyone running tests via tox and the unittest framework,
we can move our tests out of the adapter and into proper test cases.
We still need the custom loader to generate classes based on test
images, but it's majorly simpler and uses the hooks available.

With this, each test case is broken into proper scenarios so that
each can be run (and fail) independently. We also don't need all the
wrapper and logging stuff, which means exceptions are reported where
they actually happen, and as such, debugging what is failing should
be much easier.

The content is mostly the same, although the detect test is tightend
a bit, just because it needed rewriting anyway. That uncovered the
bug in the test images fixed a few patches ago.
2023-01-12 15:31:20 -08:00