mirror of
https://github.com/magicbug/Cloudlog
synced 2026-08-13 17:49:35 -04:00
e3c602127a
Replace concatenated SQL with CodeIgniter query builder across models to improve safety and readability. Changes in Cat, Contesting_model and Oqrs_model convert raw SQL strings into active-record calls, add integer casting for ID/station values, use select/from/join/where/order_by/get patterns, and simplify delete/query flows. Affected methods include radio_status, multiple contest-related selects/inserts/deletes, and several oqrs/station_profile queries.
468 lines
No EOL
14 KiB
PHP
468 lines
No EOL
14 KiB
PHP
<?php
|
|
|
|
class Cat extends CI_Model {
|
|
|
|
function update($result, $user_id) {
|
|
|
|
$timestamp = gmdate("Y-m-d H:i:s");
|
|
|
|
if (isset($result['prop_mode'])) {
|
|
$prop_mode = $result['prop_mode'];
|
|
// For backward compatibility, SatPC32 does not set propergation mode
|
|
} else if (isset($result['sat_name'])) {
|
|
$prop_mode = "SAT";
|
|
} else {
|
|
$prop_mode = NULL;
|
|
}
|
|
|
|
$this->db->where('radio', $result['radio']);
|
|
$this->db->where('user_id', $user_id);
|
|
$query = $this->db->get('cat');
|
|
|
|
// Let's keep uplink_freq, downlink_freq, uplink_mode and downlink_mode for backward compatibility
|
|
$data = array(
|
|
'prop_mode' => $prop_mode,
|
|
'power' => $result['power'] ?? NULL,
|
|
'sat_name' => $result['sat_name'] ?? NULL,
|
|
'timestamp' => $timestamp,
|
|
);
|
|
|
|
// Validate frequency data - only set if it's numeric to avoid inserting error messages
|
|
if (isset($result['frequency']) && $result['frequency'] != "NULL") {
|
|
if (is_numeric($result['frequency'])) {
|
|
$data['frequency'] = $result['frequency'];
|
|
} else {
|
|
// Log the error message for debugging but don't store it in frequency field
|
|
log_message('debug', 'CAT: Non-numeric frequency data received: ' . $result['frequency']);
|
|
$data['frequency'] = NULL;
|
|
}
|
|
} else if (isset($result['uplink_freq']) && is_numeric($result['uplink_freq'])) {
|
|
$data['frequency'] = $result['uplink_freq'];
|
|
} else {
|
|
$data['frequency'] = NULL;
|
|
}
|
|
|
|
// Validate mode data - filter out obvious error messages
|
|
if (isset($result['mode']) && $result['mode'] != "NULL") {
|
|
// Check if mode contains error indicators
|
|
if (strpos(strtolower($result['mode']), 'error') !== false ||
|
|
strpos($result['mode'], '.c(') !== false ||
|
|
strlen($result['mode']) > 20) {
|
|
log_message('debug', 'CAT: Invalid mode data received: ' . $result['mode']);
|
|
$data['mode'] = NULL;
|
|
} else {
|
|
$data['mode'] = $result['mode'];
|
|
}
|
|
} else {
|
|
if (isset($result['uplink_mode']) && $result['uplink_mode'] != "NULL") {
|
|
// Apply same validation to uplink_mode
|
|
if (strpos(strtolower($result['uplink_mode']), 'error') !== false ||
|
|
strpos($result['uplink_mode'], '.c(') !== false ||
|
|
strlen($result['uplink_mode']) > 20) {
|
|
log_message('debug', 'CAT: Invalid uplink_mode data received: ' . $result['uplink_mode']);
|
|
$data['mode'] = NULL;
|
|
} else {
|
|
$data['mode'] = $result['uplink_mode'];
|
|
}
|
|
} else {
|
|
$data['mode'] = NULL;
|
|
}
|
|
}
|
|
|
|
// Validate frequency_rx data
|
|
if (isset($result['frequency_rx'])) {
|
|
if (is_numeric($result['frequency_rx'])) {
|
|
$data['frequency_rx'] = $result['frequency_rx'];
|
|
} else {
|
|
log_message('debug', 'CAT: Non-numeric frequency_rx data received: ' . $result['frequency_rx']);
|
|
$data['frequency_rx'] = NULL;
|
|
}
|
|
} else if (isset($result['downlink_freq']) && $result['downlink_freq'] != "NULL") {
|
|
if (is_numeric($result['downlink_freq'])) {
|
|
$data['frequency_rx'] = $result['downlink_freq'];
|
|
} else {
|
|
log_message('debug', 'CAT: Non-numeric downlink_freq data received: ' . $result['downlink_freq']);
|
|
$data['frequency_rx'] = NULL;
|
|
}
|
|
} else {
|
|
$data['frequency_rx'] = NULL;
|
|
}
|
|
|
|
// Validate mode_rx data
|
|
if (isset($result['mode_rx'])) {
|
|
if (strpos(strtolower($result['mode_rx']), 'error') !== false ||
|
|
strpos($result['mode_rx'], '.c(') !== false ||
|
|
strlen($result['mode_rx']) > 20) {
|
|
log_message('debug', 'CAT: Invalid mode_rx data received: ' . $result['mode_rx']);
|
|
$data['mode_rx'] = NULL;
|
|
} else {
|
|
$data['mode_rx'] = $result['mode_rx'];
|
|
}
|
|
} else if (isset($result['downlink_mode']) && $result['downlink_mode'] != "NULL") {
|
|
if (strpos(strtolower($result['downlink_mode']), 'error') !== false ||
|
|
strpos($result['downlink_mode'], '.c(') !== false ||
|
|
strlen($result['downlink_mode']) > 20) {
|
|
log_message('debug', 'CAT: Invalid downlink_mode data received: ' . $result['downlink_mode']);
|
|
$data['mode_rx'] = NULL;
|
|
} else {
|
|
$data['mode_rx'] = $result['downlink_mode'];
|
|
}
|
|
} else {
|
|
$data['mode_rx'] = NULL;
|
|
}
|
|
|
|
if ($query->num_rows() > 0)
|
|
{
|
|
// Update the record
|
|
foreach ($query->result() as $row)
|
|
{
|
|
$radio_id = $row->id;
|
|
|
|
$this->db->where('id', $radio_id);
|
|
$this->db->where('user_id', $user_id);
|
|
$this->db->update('cat', $data);
|
|
}
|
|
} else {
|
|
// Add a new record
|
|
$data['radio'] = $result['radio'];
|
|
$data['user_id'] = $user_id;
|
|
|
|
$this->db->insert('cat', $data);
|
|
}
|
|
}
|
|
|
|
function status() {
|
|
//$this->db->where('radio', $result['radio']);
|
|
$this->db->where('user_id', $this->session->userdata('user_id'));
|
|
$query = $this->db->get('cat');
|
|
|
|
return $query;
|
|
}
|
|
|
|
function recent_status() {
|
|
$this->db->where('user_id', $this->session->userdata('user_id'));
|
|
$this->db->where("timestamp > date_sub(UTC_TIMESTAMP(), interval 15 minute)", NULL, FALSE);
|
|
|
|
$query = $this->db->get('cat');
|
|
return $query;
|
|
}
|
|
|
|
/* Return list of radios */
|
|
function radios() {
|
|
$this->db->select('id, radio');
|
|
$this->db->where('user_id', $this->session->userdata('user_id'));
|
|
$query = $this->db->get('cat');
|
|
|
|
return $query;
|
|
}
|
|
|
|
function radio_status($id) {
|
|
$this->db->where('id', (int) $id);
|
|
$this->db->where('user_id', (int) $this->session->userdata('user_id'));
|
|
return $this->db->get('cat');
|
|
}
|
|
|
|
// Return recent radio status for a specific user_id (no session required, for public widgets)
|
|
function recent_status_by_user_id($user_id) {
|
|
$this->db->where('user_id', (int)$user_id);
|
|
$this->db->where("timestamp > date_sub(UTC_TIMESTAMP(), interval 15 minute)", NULL, FALSE);
|
|
return $this->db->get('cat');
|
|
}
|
|
|
|
function delete($id) {
|
|
$this->db->where('id', $id);
|
|
$this->db->where('user_id', $this->session->userdata('user_id'));
|
|
$this->db->delete('cat');
|
|
|
|
return true;
|
|
}
|
|
|
|
/* Radio Command Functions */
|
|
|
|
/**
|
|
* Queue a command for a radio
|
|
* @param array $command_data Array containing command details
|
|
* @return int|bool Command ID on success, FALSE on failure
|
|
*/
|
|
function queue_command($command_data) {
|
|
// Get radio name if not provided
|
|
if (!isset($command_data['radio_name']) && isset($command_data['radio_id'])) {
|
|
$radio_query = $this->db->select('radio')
|
|
->where('id', $command_data['radio_id'])
|
|
->where('user_id', $command_data['user_id'])
|
|
->get('cat');
|
|
|
|
if ($radio_query->num_rows() > 0) {
|
|
$command_data['radio_name'] = $radio_query->row()->radio;
|
|
}
|
|
}
|
|
|
|
// Set default expires_at if not provided (30 minutes from now)
|
|
if (!isset($command_data['expires_at'])) {
|
|
$command_data['expires_at'] = date('Y-m-d H:i:s', strtotime('+30 minutes'));
|
|
} // Set created_at timestamp
|
|
$command_data['created_at'] = date('Y-m-d H:i:s');
|
|
|
|
$this->db->insert('radio_commands', $command_data);
|
|
|
|
if ($this->db->affected_rows() > 0) {
|
|
return $this->db->insert_id();
|
|
}
|
|
|
|
return FALSE;
|
|
}
|
|
|
|
/**
|
|
* Get pending commands for a specific radio
|
|
* @param int $radio_id Radio ID
|
|
* @param int $user_id User ID (optional, uses session if not provided)
|
|
* @return array Array of pending commands
|
|
*/
|
|
function get_pending_commands($radio_id, $user_id = null) {
|
|
if ($user_id === null) {
|
|
$user_id = $this->session->userdata('user_id');
|
|
}
|
|
|
|
$this->db->select('*');
|
|
$this->db->where('radio_id', $radio_id);
|
|
$this->db->where('user_id', $user_id);
|
|
$this->db->where('status', 'PENDING');
|
|
$this->db->where('expires_at >', date('Y-m-d H:i:s'));
|
|
$this->db->order_by('created_at', 'ASC');
|
|
|
|
$query = $this->db->get('radio_commands');
|
|
return $query->result_array();
|
|
}
|
|
|
|
/**
|
|
* Get all pending commands for all radios (for desktop app polling)
|
|
* @param int $user_id User ID (optional, gets all users if not provided)
|
|
* @return array Array of pending commands
|
|
*/
|
|
function get_all_pending_commands($user_id = null) {
|
|
$this->db->select('*');
|
|
if ($user_id !== null) {
|
|
$this->db->where('user_id', $user_id);
|
|
}
|
|
$this->db->where('status', 'PENDING');
|
|
$this->db->where('expires_at >', date('Y-m-d H:i:s'));
|
|
$this->db->order_by('created_at', 'ASC');
|
|
|
|
$query = $this->db->get('radio_commands');
|
|
return $query->result_array();
|
|
}
|
|
|
|
/**
|
|
* Get pending commands for a radio by radio name (for Aurora)
|
|
* @param string $radio_name Radio name as stored in cat table
|
|
* @param int $user_id User ID (optional, uses session if not provided)
|
|
* @return array Array of pending commands
|
|
*/
|
|
function get_pending_commands_by_name($radio_name, $user_id = null) {
|
|
if ($user_id === null) {
|
|
$user_id = $this->session->userdata('user_id');
|
|
}
|
|
|
|
// First get the radio ID from the cat table using radio name
|
|
$radio_query = $this->db->select('id, user_id, radio')
|
|
->where('radio', $radio_name)
|
|
->where('user_id', $user_id)
|
|
->get('cat');
|
|
|
|
if ($radio_query->num_rows() == 0) {
|
|
// Debug: Check if radio exists for any user
|
|
$all_radios_query = $this->db->select('id, user_id, radio')
|
|
->where('radio', $radio_name)
|
|
->get('cat');
|
|
|
|
log_message('error', "Radio '{$radio_name}' not found for user_id {$user_id}. Found for other users: " . $all_radios_query->num_rows());
|
|
return array(); // No radio found with that name for this user
|
|
}
|
|
|
|
$radio_row = $radio_query->row();
|
|
$radio_id = $radio_row->id;
|
|
|
|
// Debug log
|
|
log_message('error', "Found radio '{$radio_name}' with ID {$radio_id} for user_id {$user_id}");
|
|
|
|
// Now get pending commands for this radio
|
|
$this->db->select('*');
|
|
$this->db->where('radio_id', $radio_id);
|
|
$this->db->where('user_id', $user_id);
|
|
$this->db->where('status', 'PENDING');
|
|
$this->db->where('expires_at >', date('Y-m-d H:i:s'));
|
|
$this->db->order_by('created_at', 'ASC');
|
|
|
|
$query = $this->db->get('radio_commands');
|
|
$commands = $query->result_array();
|
|
|
|
// Debug log
|
|
log_message('error', "Found " . count($commands) . " pending commands for radio_id {$radio_id}, user_id {$user_id}");
|
|
|
|
return $commands;
|
|
}
|
|
|
|
/**
|
|
* Update command status
|
|
* @param int $command_id Command ID
|
|
* @param string $status New status (PENDING, PROCESSING, COMPLETED, FAILED)
|
|
* @param string $error_message Error message if status is FAILED
|
|
* @return bool TRUE on success, FALSE on failure
|
|
*/
|
|
function update_command_status($command_id, $status, $error_message = null) {
|
|
$data = array(
|
|
'status' => $status,
|
|
'processed_at' => date('Y-m-d H:i:s')
|
|
);
|
|
|
|
if ($error_message !== null) {
|
|
$data['error_message'] = $error_message;
|
|
}
|
|
|
|
$this->db->where('id', $command_id);
|
|
$this->db->update('radio_commands', $data);
|
|
|
|
return $this->db->affected_rows() > 0;
|
|
}
|
|
|
|
/**
|
|
* Get command history for a radio
|
|
* @param int $radio_id Radio ID
|
|
* @param int $user_id User ID (optional, uses session if not provided)
|
|
* @param int $limit Number of records to return (default 50)
|
|
* @return array Array of command history
|
|
*/
|
|
function get_command_history($radio_id, $user_id = null, $limit = 50) {
|
|
if ($user_id === null) {
|
|
$user_id = $this->session->userdata('user_id');
|
|
}
|
|
|
|
$this->db->select('*');
|
|
$this->db->where('radio_id', $radio_id);
|
|
$this->db->where('user_id', $user_id);
|
|
$this->db->order_by('created_at', 'DESC');
|
|
$this->db->limit($limit);
|
|
|
|
$query = $this->db->get('radio_commands');
|
|
return $query->result_array();
|
|
}
|
|
|
|
/**
|
|
* Clean up expired commands
|
|
* @param int $user_id User ID (optional, cleans all users if not provided)
|
|
* @return int Number of deleted commands
|
|
*/
|
|
function cleanup_expired_commands($user_id = null) {
|
|
// First, count how many expired commands we have
|
|
$this->db->where('expires_at <', date('Y-m-d H:i:s'));
|
|
$this->db->where('status', 'PENDING');
|
|
|
|
if ($user_id !== null) {
|
|
$this->db->where('user_id', $user_id);
|
|
}
|
|
|
|
$count = $this->db->count_all_results('radio_commands');
|
|
|
|
// If we have expired commands, delete them
|
|
if ($count > 0) {
|
|
log_message('info', "Cleaning up {$count} expired radio commands" . ($user_id ? " for user {$user_id}" : ""));
|
|
|
|
// Reset query builder and build delete query
|
|
$this->db->where('expires_at <', date('Y-m-d H:i:s'));
|
|
$this->db->where('status', 'PENDING');
|
|
|
|
if ($user_id !== null) {
|
|
$this->db->where('user_id', $user_id);
|
|
}
|
|
|
|
$this->db->delete('radio_commands');
|
|
$deleted = $this->db->affected_rows();
|
|
|
|
log_message('info', "Successfully deleted {$deleted} expired radio commands");
|
|
return $deleted;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* Get command by ID
|
|
* @param int $command_id Command ID
|
|
* @param int $user_id User ID (optional, uses session if not provided)
|
|
* @return array|null Command data or null if not found
|
|
*/
|
|
function get_command($command_id, $user_id = null) {
|
|
if ($user_id === null) {
|
|
$user_id = $this->session->userdata('user_id');
|
|
}
|
|
|
|
$this->db->select('*');
|
|
$this->db->where('id', $command_id);
|
|
$this->db->where('user_id', $user_id);
|
|
|
|
$query = $this->db->get('radio_commands');
|
|
|
|
if ($query->num_rows() > 0) {
|
|
return $query->row_array();
|
|
}
|
|
|
|
return null;
|
|
}
|
|
|
|
/**
|
|
* Cancel a pending command
|
|
* @param int $command_id Command ID
|
|
* @param int $user_id User ID (optional, uses session if not provided)
|
|
* @return bool TRUE on success, FALSE on failure
|
|
*/
|
|
function cancel_command($command_id, $user_id = null) {
|
|
if ($user_id === null) {
|
|
$user_id = $this->session->userdata('user_id');
|
|
}
|
|
|
|
$this->db->where('id', $command_id);
|
|
$this->db->where('user_id', $user_id);
|
|
$this->db->where('status', 'PENDING');
|
|
$this->db->update('radio_commands', array(
|
|
'status' => 'FAILED',
|
|
'error_message' => 'Cancelled by user',
|
|
'processed_at' => date('Y-m-d H:i:s')
|
|
));
|
|
|
|
return $this->db->affected_rows() > 0;
|
|
}
|
|
|
|
/**
|
|
* Clean up old completed/failed commands (older than specified days)
|
|
* @param int $days_old Commands older than this many days will be deleted
|
|
* @param int $user_id User ID (optional, cleans all users if not provided)
|
|
* @return int Number of old commands deleted
|
|
*/
|
|
function cleanup_old_commands($days_old = 7, $user_id = null) {
|
|
$cutoff_date = date('Y-m-d H:i:s', strtotime("-{$days_old} days"));
|
|
|
|
$this->db->where('created_at <', $cutoff_date);
|
|
$this->db->where_in('status', array('COMPLETED', 'FAILED'));
|
|
|
|
if ($user_id !== null) {
|
|
$this->db->where('user_id', $user_id);
|
|
}
|
|
|
|
// Get count before deleting for logging
|
|
$count_query = clone $this->db;
|
|
$count = $count_query->count_all_results('radio_commands');
|
|
|
|
if ($count > 0) {
|
|
log_message('info', "Cleaning up {$count} old radio commands older than {$days_old} days" . ($user_id ? " for user {$user_id}" : ""));
|
|
|
|
$this->db->delete('radio_commands');
|
|
$deleted = $this->db->affected_rows();
|
|
|
|
log_message('info', "Successfully deleted {$deleted} old radio commands");
|
|
return $deleted;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
}
|
|
?>
|