Allan Bazinet
3eed0807c0
Ongoing dead shared code removal
...
Deleting unused fields minw, dttol, minSync; of historical interest only, no longer used.
2024-11-01 08:32:48 -07:00
Allan Bazinet
41d639ec36
Ongoing dead shared code removal
...
Deleting unused fields emedelay, nlist, listutc, naggressive, nrobust; of historical interest only, no longer used.
2024-11-01 08:25:10 -07:00
Allan Bazinet
7ba81b2b4b
Dead code removal, nclearave
...
Historical use only; no longer relevant, used int the past for Q65.
2024-11-01 08:16:08 -07:00
Allan Bazinet
3c8e49b4b4
Remove duplicate nftx shared field
...
This is simply an alias for nfqso; it’s entirely redundant
2024-11-01 07:52:41 -07:00
Allan Bazinet
4f1be01811
Dead shared Fortran parameters removal
...
lapcqonly and ljt65apon are just completely dead and can be removed immediately. nQSOProgress and lft8apon were concepts relating to using a variable number of decoder passes per QSO state, but we don’t have QSO states as WSJTX does, and always do 4 passes.
2024-11-01 06:27:48 -07:00
Allan Bazinet
a3e5dcd673
Dead common Fortran code removal
...
The shared decoder parameters ntxmode, mygrid, hiscall, and hisgrid are unused dead stores, related only long-deleted WSJTX function; remove them.
2024-11-01 05:37:56 -07:00
Allan Bazinet
346db7dc1a
Default submode on new installs to Normal
2024-10-31 07:29:55 -07:00
Allan Bazinet
163c57cf97
Use enum value, not zero
2024-10-31 07:29:26 -07:00
Allan Bazinet
a58f9a7136
Submode HB test to accessor; simplify logic
2024-10-31 07:27:22 -07:00
Allan Bazinet
efea433d89
Reduce default decode passes from 3 to 2
2024-10-30 18:44:10 -07:00
Allan Bazinet
274dc702f7
Namespace private constants
...
Move state constants to a State namespace, and hoist up the configurable defaults (dial frequency, frequency, decoder depth) so that they’re not buried lower down.
2024-10-30 11:47:36 -07:00
Allan Bazinet
18f6534918
Don’t parameterize modulator by frame rate
...
There’s zero chance of us using anything other than 48 kHz; there’s no value in allowing anything else.
2024-10-28 09:35:08 -07:00
Allan Bazinet
8a6a06c2cb
Pass only submode to modulator
2024-10-28 07:51:13 -07:00
Allan Bazinet
ee43de6f73
Pass period to modulator when start called
...
Resolves thread safety issue, and the period is only used as an immediate value during the start call, it’s not required to be an instance variable.
2024-10-28 07:25:14 -07:00
Allan Bazinet
976c6f2433
Pass start delay, rather than period, to modulator
2024-10-28 07:03:33 -07:00
Allan Bazinet
9d887dc721
JS8 Submode namespace updates
...
Convert symbo samples, start delay, and period to unsigned; rename startDelay to startDelayMS for clarity.
2024-10-28 06:47:47 -07:00
Allan Bazinet
611e5d5d33
Reorder modulator parameters; avoid defaults
2024-10-27 21:16:31 -07:00
Allan Bazinet
5db8874b48
Don’t parameterize Modulator tone spacing
...
Since the sample rate is a constant, the modulator can figure out the tone spacing by itself, based on the frames per symbol, we don’t need to parameterize it.
2024-10-27 20:58:02 -07:00
Allan Bazinet
cd73c40e25
Don’t parameterize modulator by symbolsLength
...
This is a constant with JS8; simplifies modulator implementation and resolves thread safety issue to not pass it as a variable.
2024-10-27 20:47:54 -07:00
Allan Bazinet
b338804232
Modulator ongoing refactoring
...
Eliminate fSpread parameter; it’s a thread safety issue and it’s never anything other than 0.0. Invert modulator active / idle accessor to simplify logic.
2024-10-27 20:33:26 -07:00
Allan Bazinet
54c9307b2b
Eliminate modulator noise option
...
We never want to inject noise into the signal.
2024-10-27 18:18:44 -07:00
Allan Bazinet
e1cba2a326
Eliminate modulator synchronize option
...
Invariably true; we always want to synchronize.
2024-10-27 18:12:02 -07:00
Allan Bazinet
8398a959ef
Eliminate modulator fast mode option
...
This option is invariably false; simplifying usage.
2024-10-27 18:09:46 -07:00
Allan Bazinet
c7deff81b9
Remove CW function
...
Remove old global icw data, calls to and compilation of the morse subroutine used to generate it, and support for it in the Modulator class.
2024-10-27 14:15:13 -07:00
Allan Bazinet
0101acd403
Eliminate m_mode
...
This instance variable is effectively a constant of ‘FT8’; logic that depends on it can be reduced to always being true.
2024-10-27 13:06:57 -07:00
Allan Bazinet
a00e2e09cd
Use modern erase_if()
2024-10-27 06:28:31 -07:00
Allan Bazinet
a8137054ea
Extract copyByteData() commonality into function
2024-10-27 04:52:52 -07:00
Allan Bazinet
480330d844
Lose m_ntx instance variable
...
This is effectively now a constant of 9, and is therefore no longer relevant. Rename ba2msg() to copyMessage(), have it deal in QStringView, and use STL methods for it. Avoid creating a temporary string to calculate trimmed message length.
2024-10-26 10:37:04 -07:00
Allan Bazinet
07364c01ca
Move g_iptt global to m_iptt instance variable
2024-10-26 07:13:47 -07:00
Allan Bazinet
f03ecb44bc
Normalize constants, move to anonymous namespace
2024-10-26 07:07:12 -07:00
Allan Bazinet
365f045979
Eliminate color table global
2024-10-26 07:02:01 -07:00
Allan Bazinet
2acb5e29c6
Eliminate unused globals
2024-10-26 06:50:58 -07:00
Allan Bazinet
e5fd0313e4
Refactoring; eliminate bandComboBox
...
This widget is always hidden; it can’t be edited or activated, and thus ends up being, effectively, an alias for m_lastBand. As m_bandEdited can’t ever be anything but false, conditional code relying on it being true will never be executed. The LiveFrequencyValidator was only used by this combo box.
2024-10-25 13:27:38 -07:00
Allan Bazinet
fc2f44777a
Ongoing refactoring, bandComboBox
...
Widget is never visible; no point in setting width
2024-10-25 13:04:46 -07:00
Allan Bazinet
2f8b0d8d8d
Dead code removal
2024-10-25 13:04:10 -07:00
Allan Bazinet
ae41ced390
Eliminate bandComboBox style sheet changes
...
Ongoing refactoring; widget is never visible, so what style sheet it uses isn’t interesting.
2024-10-25 10:12:36 -07:00
Allan Bazinet
fece91eed8
Dead code removal, labDialFreq
...
This widget is always hidden; it’s write-only, and since it’s hidden, it can’t be clicked, so the click handler for it is irrelevant.
2024-10-25 08:31:27 -07:00
Allan Bazinet
e802e27f02
Use float precision for dial frequency
2024-10-24 21:25:49 -07:00
Allan Bazinet
86eee6fc05
Commentary
2024-10-23 16:19:55 -07:00
Allan Bazinet
f47f05a561
Commentary
2024-10-23 15:15:26 -07:00
Allan Bazinet
6eb6286cc1
Compare lambda of trivial size; capture by value
2024-10-23 15:03:41 -07:00
Allan Bazinet
d9bc5ac812
Extract compare function common base
2024-10-23 10:50:53 -07:00
Allan Bazinet
e863723524
Reference, don’t copy, band activity when sorting
2024-10-23 09:47:19 -07:00
Allan Bazinet
8b6db24eb3
Address C++17 restriction
...
Capture of structured bindings unfortunately isn’t allowed until C++20.
2024-10-23 09:26:25 -07:00
Allan Bazinet
db8d92777b
Sort comparison cleanup
...
Don’t mutate the return call activity in the SNR comparison.
2024-10-23 09:12:48 -07:00
Allan Bazinet
7889cc6020
Add getSortByReverse() function
2024-10-23 08:14:02 -07:00
Allan Bazinet
452a4fc6e3
Make logic more obvious
2024-10-23 07:53:08 -07:00
Allan Bazinet
9367b531c8
Correct insanity detection logic
2024-10-23 07:48:28 -07:00
Allan Bazinet
2e11363880
Sort comparison cleanup
...
Take QString key arguments by constant reference, as is canonical for std::stable_sort(). Don’t mutate the return call activity in the SNR comparison.
2024-10-23 07:35:25 -07:00
Allan Bazinet
642f7ee7d3
Eliminate temporary usage
2024-10-23 06:53:03 -07:00
