Allan Bazinet
c7deff81b9
Remove CW function
...
Remove old global icw data, calls to and compilation of the morse subroutine used to generate it, and support for it in the Modulator class.
2024-10-27 14:15:13 -07:00
Allan Bazinet
0101acd403
Eliminate m_mode
...
This instance variable is effectively a constant of ‘FT8’; logic that depends on it can be reduced to always being true.
2024-10-27 13:06:57 -07:00
Allan Bazinet
a00e2e09cd
Use modern erase_if()
2024-10-27 06:28:31 -07:00
Allan Bazinet
a8137054ea
Extract copyByteData() commonality into function
2024-10-27 04:52:52 -07:00
Allan Bazinet
480330d844
Lose m_ntx instance variable
...
This is effectively now a constant of 9, and is therefore no longer relevant. Rename ba2msg() to copyMessage(), have it deal in QStringView, and use STL methods for it. Avoid creating a temporary string to calculate trimmed message length.
2024-10-26 10:37:04 -07:00
Allan Bazinet
07364c01ca
Move g_iptt global to m_iptt instance variable
2024-10-26 07:13:47 -07:00
Allan Bazinet
f03ecb44bc
Normalize constants, move to anonymous namespace
2024-10-26 07:07:12 -07:00
Allan Bazinet
365f045979
Eliminate color table global
2024-10-26 07:02:01 -07:00
Allan Bazinet
2acb5e29c6
Eliminate unused globals
2024-10-26 06:50:58 -07:00
Allan Bazinet
e5fd0313e4
Refactoring; eliminate bandComboBox
...
This widget is always hidden; it can’t be edited or activated, and thus ends up being, effectively, an alias for m_lastBand. As m_bandEdited can’t ever be anything but false, conditional code relying on it being true will never be executed. The LiveFrequencyValidator was only used by this combo box.
2024-10-25 13:27:38 -07:00
Allan Bazinet
fc2f44777a
Ongoing refactoring, bandComboBox
...
Widget is never visible; no point in setting width
2024-10-25 13:04:46 -07:00
Allan Bazinet
2f8b0d8d8d
Dead code removal
2024-10-25 13:04:10 -07:00
Allan Bazinet
ae41ced390
Eliminate bandComboBox style sheet changes
...
Ongoing refactoring; widget is never visible, so what style sheet it uses isn’t interesting.
2024-10-25 10:12:36 -07:00
Allan Bazinet
fece91eed8
Dead code removal, labDialFreq
...
This widget is always hidden; it’s write-only, and since it’s hidden, it can’t be clicked, so the click handler for it is irrelevant.
2024-10-25 08:31:27 -07:00
Allan Bazinet
e802e27f02
Use float precision for dial frequency
2024-10-24 21:25:49 -07:00
Allan Bazinet
86eee6fc05
Commentary
2024-10-23 16:19:55 -07:00
Allan Bazinet
f47f05a561
Commentary
2024-10-23 15:15:26 -07:00
Allan Bazinet
6eb6286cc1
Compare lambda of trivial size; capture by value
2024-10-23 15:03:41 -07:00
Allan Bazinet
d9bc5ac812
Extract compare function common base
2024-10-23 10:50:53 -07:00
Allan Bazinet
e863723524
Reference, don’t copy, band activity when sorting
2024-10-23 09:47:19 -07:00
Allan Bazinet
8b6db24eb3
Address C++17 restriction
...
Capture of structured bindings unfortunately isn’t allowed until C++20.
2024-10-23 09:26:25 -07:00
Allan Bazinet
db8d92777b
Sort comparison cleanup
...
Don’t mutate the return call activity in the SNR comparison.
2024-10-23 09:12:48 -07:00
Allan Bazinet
7889cc6020
Add getSortByReverse() function
2024-10-23 08:14:02 -07:00
Allan Bazinet
452a4fc6e3
Make logic more obvious
2024-10-23 07:53:08 -07:00
Allan Bazinet
9367b531c8
Correct insanity detection logic
2024-10-23 07:48:28 -07:00
Allan Bazinet
2e11363880
Sort comparison cleanup
...
Take QString key arguments by constant reference, as is canonical for std::stable_sort(). Don’t mutate the return call activity in the SNR comparison.
2024-10-23 07:35:25 -07:00
Allan Bazinet
642f7ee7d3
Eliminate temporary usage
2024-10-23 06:53:03 -07:00
Allan Bazinet
8534d08a1a
Hoist lambda invariants
2024-10-23 05:26:05 -07:00
Allan Bazinet
e0511943c0
Improve efficiency of list production
2024-10-23 05:16:03 -07:00
Allan Bazinet
c2a33eb2c6
Invert responsibilities of message inbox actions
...
After storing a message for a station, the View->Show Message Inbox… menu item would no longer do anything until the application was restarted.
2024-10-22 20:30:55 -07:00
Allan Bazinet
488f0f6ef1
Purge Save menu and supporting code
2024-10-22 16:36:23 -07:00
Allan Bazinet
0687b69e66
Fix TX frequency bug introduced by setXIT() change
2024-10-21 17:40:39 -07:00
Allan Bazinet
ccade4242c
Use non-macro slot bindings
2024-10-21 15:35:49 -07:00
Allan Bazinet
7982f7ef38
Use non-macro signal / slot connect
2024-10-21 15:19:00 -07:00
Allan Bazinet
5196bad67c
Use timezone functions compatible with Qt 6.4
2024-10-21 13:44:12 -07:00
Allan Bazinet
f4a5bcfc59
Remove splash screen code
...
We don’t use a splash screen; it’s leftovers from WSJTX.
2024-10-21 08:39:09 -07:00
Allan Bazinet
30752423b3
Address impending QDateTime deprecations
2024-10-21 08:30:21 -07:00
Allan Bazinet
d6d0b87e69
Use idiomatic loop format
2024-10-21 06:36:14 -07:00
Allan Bazinet
8b9c11912a
Use new QMap iteration in idle activity processing
2024-10-21 06:25:50 -07:00
Allan Bazinet
3e7419e97a
Hoist loop invariant
2024-10-21 06:10:22 -07:00
Allan Bazinet
1dc19ab5b7
Use new iteration method for free frequency search
2024-10-21 06:07:07 -07:00
Allan Bazinet
83e1269fd9
Add BandActivity convenience type definition
2024-10-21 05:47:38 -07:00
Allan Bazinet
3475d447fc
Use new QMap features for qsy function
2024-10-21 05:39:35 -07:00
Allan Bazinet
c0f80261c4
Clean up signal and slot usage, setXIT, f11f12
2024-10-20 14:36:48 -07:00
Allan Bazinet
0961695fae
Eliminate changeFreq SIGNAL and SLOT macro usage
2024-10-20 14:23:10 -07:00
Allan Bazinet
41eddc6e2e
Collapse TX and RX frequencies
...
Separate TX and RX frequencies is a vestige of WSJTX; in JS8Call, there’s really only a single frequency, which is our offset in hertz into the dial frequency. To date the two separate frequencies have had to have been kept in sync at all times; this change removes the distinction and instead uses a single frequency.
2024-10-20 13:54:14 -07:00
Allan Bazinet
1a21194029
Eliminate unused ihsym parameter from signature
2024-10-20 07:54:09 -07:00
Allan Bazinet
4238380242
Graph mode is always FT8
...
Our widegraph and plotter are always going to be displaying FT8 mode; remove logic to handle multiple modes until such time as they become relevant again, if ever.
2024-10-19 15:16:30 -07:00
Allan Bazinet
466c6415c0
NSPS and FFT_BIN_WIDTH constants
...
The number of samples per second is fixed and unchanging at 6912, and is therefore a constant. Similarly, since FFT bin width is derived from NSPS, it’s also a constant.
2024-10-19 15:10:31 -07:00
Allan Bazinet
f06ec09ffc
Graph / plot class cleanup
...
Standardize nomenclature and function names
2024-10-19 09:14:10 -07:00
