Commit graph

156 commits

Author SHA1 Message Date
Allan Bazinet
a7aaaedb97 Simplified dial frequency drawing 2024-10-24 12:43:53 -07:00
Allan Bazinet
47b7da49f6 Use consistent value in mouse click freq change 2024-10-24 12:38:58 -07:00
Allan Bazinet
85844ee67b Simplify sub-band drawing 2024-10-24 07:16:12 -07:00
Allan Bazinet
cf878ba7a1 Avoid height overdraw 2024-10-24 05:18:24 -07:00
Allan Bazinet
1113106926 Dial frequency brush fill
Bit of a visual experiment, make the dial frequency component appear a bit more above the waterfall.
2024-10-23 17:04:36 -07:00
Allan Bazinet
40f87142b9 Normalize instance variable names 2024-10-20 21:25:26 -07:00
Allan Bazinet
f4e2a330cd Tune mouse events 2024-10-20 21:20:32 -07:00
Allan Bazinet
0961695fae Eliminate changeFreq SIGNAL and SLOT macro usage 2024-10-20 14:23:10 -07:00
Allan Bazinet
41eddc6e2e Collapse TX and RX frequencies
Separate TX and RX frequencies is a vestige of WSJTX; in JS8Call, there’s really only a single frequency, which is our offset in hertz into the dial frequency. To date the two separate frequencies have had to have been kept in sync at all times; this change removes the distinction and instead uses a single frequency.
2024-10-20 13:54:14 -07:00
Allan Bazinet
4238380242 Graph mode is always FT8
Our widegraph and plotter are always going to be displaying FT8 mode; remove logic to handle multiple modes until such time as they become relevant again, if ever.
2024-10-19 15:16:30 -07:00
Allan Bazinet
466c6415c0 NSPS and FFT_BIN_WIDTH constants
The number of samples per second is fixed and unchanging at 6912, and is therefore a constant. Similarly, since FFT bin width is derived from NSPS, it’s also a constant.
2024-10-19 15:10:31 -07:00
Allan Bazinet
82fe088231 Start cleanup of size usage 2024-10-19 13:49:37 -07:00
Allan Bazinet
f139f32757 CPlotter instance variable cleanup 2024-10-19 13:44:02 -07:00
Allan Bazinet
e8fe450aec Use in-class initialization 2024-10-19 13:24:51 -07:00
Allan Bazinet
70ae21338e Use in-class initialization 2024-10-19 13:23:28 -07:00
Allan Bazinet
d8c73c5230 Rename and init scale OK instance variable 2024-10-19 13:20:53 -07:00
Allan Bazinet
c431a4e6c8 Rename and init replot instance variable 2024-10-19 13:18:33 -07:00
Allan Bazinet
6bbf589a24 Convert flatten usage to boolean
This argument was previously integer due to potential use of a reference; use of a reference is now impossible, so it’s just going to be either true or false.
2024-10-19 13:14:18 -07:00
Allan Bazinet
0bc14ecd5d Pass frequency per division as argument 2024-10-19 12:50:43 -07:00
Allan Bazinet
00ac32ffe2 Dead code removal, FMax()
Completely write-only, never referenced.
2024-10-19 11:39:21 -07:00
Allan Bazinet
7571f9e927 Dead code removal m_fMin
This instance variable is completely write-only.
2024-10-19 11:34:43 -07:00
Allan Bazinet
af7cff422c Dead code removal, graph cbRef
Widget that would drive this is always hidden and always false; can never happen.
2024-10-19 11:30:52 -07:00
Allan Bazinet
b683b86977 Dead code removal, m_Running 2024-10-19 09:39:31 -07:00
Allan Bazinet
966ab09c52 Formatting 2024-10-19 09:19:01 -07:00
Allan Bazinet
f06ec09ffc Graph / plot class cleanup
Standardize nomenclature and function names
2024-10-19 09:14:10 -07:00
Allan Bazinet
ce2fb48a60 Plotter cleanup
DRAW_FREQ_OVERALY code is now handled by a tooltip. Eliminate unused includes; use scope guard for paintEvent reentrancy exclusion.
2024-10-19 08:46:49 -07:00
Allan Bazinet
0b3fed5fb7 Use auto return type 2024-10-19 08:23:24 -07:00
Allan Bazinet
401bcde58f Dead code removal, m_set_freq_action 2024-10-18 21:15:43 -07:00
Allan Bazinet
bf18c6a974 Dead code removal, freezeDecode
Old function pertaining only to WSJTX FST4 decoding; no longer relevant.
2024-10-18 19:10:44 -07:00
Allan Bazinet
f6c4c8197f Dead code removal, graph turbo 2024-10-11 08:15:35 -07:00
Allan Bazinet
955da2cdd7 Remove unused fox-related code 2024-10-09 22:05:49 -07:00
Allan Bazinet
aac9c409a0 Move to use of common submode bandwidth function 2024-10-08 06:04:28 -07:00
Allan Bazinet
e2a36e2aeb Return bandwidth as int
Bandwidth is always an integral value; return as int rather than as a float. Preparation for a common namespace, since this code is duplicated in the main window.
2024-10-06 15:00:16 -07:00
Allan Bazinet
907e359390 Kill of unused reference spectrum support 2024-09-26 06:32:08 -07:00
Allan Bazinet
5887cbc3a0 Dead code removal, sbFtol 2024-09-23 22:44:20 -07:00
Allan Bazinet
5cfaa9af6a Eliminate dead 3rd parameter on CPlotter::draw() 2024-09-15 13:53:16 -07:00
Allan Bazinet
137a949909 Use std::array for sum and points 2024-09-15 13:32:54 -07:00
Allan Bazinet
9042748a8f Various plotter fixes
Integration of a few upstream fixes, mostly ensuring consistent state after mutation.
2024-09-15 13:24:27 -07:00
Allan Bazinet
66736c5acb Clean up WSPR sub-band warning display
If we’re in the 30m band, ensure that the 200Hz WSPR portion of the band is clearly indicated, in a manner that looks consistent with the JS8 sub-band indicators.
2024-09-15 08:20:24 -07:00
Allan Bazinet
5a0b950609 Increase linear average plot gain
Doubles gain of the linear average spectrum; matches WSJTX gain setting for this spectrum type.
2024-09-15 06:22:45 -07:00
Allan Bazinet
237d44ff51 Strip dead modeTx code
Removes old code related to setting modeTx in the waterfall; no longer does anything, and has been removed in the upstream WSJTX code as well.
2024-09-15 05:12:15 -07:00
Allan Bazinet
6d8a56d2c6 Eliminate unitialized warning 2024-09-14 22:26:48 -07:00
Allan Bazinet
00de4bcd73 WF namespace
Move WFPallete into WF::Pallete and add WF:Spectrum; greatly simplifies plotter preference handling, and contributes to go-fast in the plotter drawing function.
2024-09-14 06:53:12 -07:00
Allan Bazinet
d98f49a14f Remove JT4 message drawing from draw function
We’ll never be in a mode that would cause this code to be executed; it’s just taking up time in the draw method for nothing.
2024-09-13 21:41:22 -07:00
Allan Bazinet
c1a3fe3a04 Introduce Spectrum enum
The plotter has 4 mutually-exclusive options for spectrum display, but they’re at present being represented by a large number of booleans, which makes for confusing draw loop. Start introduction of an enum to represent these.
2024-09-13 21:36:28 -07:00
Allan Bazinet
8b827f97b0 Extract common summary code 2024-09-13 14:08:06 -07:00
Allan Bazinet
c91fdc1260 Ongoing draw loop tuning 2024-09-13 13:03:50 -07:00
Allan Bazinet
2c1f9d5e2b Use retrieved value 2024-09-13 10:49:58 -07:00
Allan Bazinet
261e1c6335 Extract last point check from loop
Checking to see if the loop is about to end, while you’re in the loop, on every loop iteration, is not ideal.
2024-09-13 10:33:25 -07:00
Allan Bazinet
96c8570c8f Eliminate aliasing
In this loop, j is just an alias for i; we don’t need both of them.
2024-09-13 10:29:46 -07:00