Allan Bazinet
c1e2cf243a
Eliminate iterator temporary
2024-11-08 17:21:41 -08:00
Allan Bazinet
041c2c95df
Avoid creating copies; hoist computations
2024-11-08 16:55:41 -08:00
Allan Bazinet
1545ccaa5a
Avoid copying call activity
2024-11-08 16:28:14 -08:00
Allan Bazinet
1bdf24ed97
Tune replaceMacros()
...
Use asKeyValueRange() iteration, take values by const reference, convert to local utility function.
2024-11-08 16:16:57 -08:00
Allan Bazinet
3b5371d1f1
Revert change and note issue
2024-11-08 15:09:53 -08:00
Allan Bazinet
203dae1952
Use asKeyValueRange() iteration
2024-11-08 15:07:35 -08:00
Allan Bazinet
234a7eeb86
Use asKeyValueRange() iteration
2024-11-08 14:23:44 -08:00
Allan Bazinet
d1ba7db12b
Use asKeyValueRange() iteration
2024-11-08 14:20:30 -08:00
Allan Bazinet
aaa04b3feb
Rename setupJS8()
...
Final function name that’s upsetting the moc auto-connect.
2024-11-08 14:06:18 -08:00
Allan Bazinet
5abc4f9859
Inline switch_mode()
...
Mostly a vestige of WSJTX; we’re always in JS8 mode.
2024-11-08 13:14:53 -08:00
Allan Bazinet
73b33b51b9
Text edit log double click feature to lambda
...
Ongoing reduction of signal / slot connect debug spam
2024-11-08 13:09:29 -08:00
Allan Bazinet
fc25d82110
Address additional callback runtime link errors
...
Ongoing resolutions to runtime signal / slot linkage debug warning spam.
2024-11-08 12:55:07 -08:00
Allan Bazinet
151ec658bd
Convert callback to lambda functions
...
Eliminate TODOs and silence “QMetaObject::connectSlotsByName: No matching signal” runtime debug warnings.
2024-11-08 10:37:24 -08:00
Allan Bazinet
daba0b571f
Remove APRSClient parent; will move to thread
2024-11-07 13:12:55 -08:00
Allan Bazinet
afa3bb449e
Lose unused revision concept
...
This is a carry-over; it’s never used.
2024-11-06 15:09:01 -08:00
Allan Bazinet
8ab8d3e236
Pass in program info, rather than keep in ivar
2024-11-06 12:22:23 -08:00
Allan Bazinet
575cb3d588
Host program_version invariant
2024-11-06 11:36:07 -08:00
Allan Bazinet
9b555d00c5
Debug to implementation; eliminate temporaries
2024-11-06 05:43:03 -08:00
Allan Bazinet
080494f602
Decouple spot client from message client
...
Decouple under-the-covers usage of the message client’s socket by the spot client, in order to facilitate future multicast operations by the message client.
2024-11-05 06:36:43 -08:00
Allan Bazinet
66b8f795d8
Use QVariantHash and QVariantMap
2024-11-04 17:48:36 -08:00
Allan Bazinet
39326e1b1c
Connect server instances to correct routines
...
I assume the original setup to be a mistake, since these routines exist, but without them connected, the relevant checkboxes in the configuration don’t actually do anything.
2024-11-04 13:36:42 -08:00
Allan Bazinet
defc277d12
Use consistent naming
2024-11-03 08:11:34 -08:00
Allan Bazinet
7a09fc698a
Simplify MessageClient constructor
...
Don’t pass arguments that we don’t use.
2024-11-02 09:21:43 -07:00
Allan Bazinet
5fe3c2cd23
Const-qualify attenuation slider argument
2024-11-01 21:11:28 -07:00
Allan Bazinet
fffa0a6fb1
Eliminate temporary
2024-11-01 21:07:48 -07:00
Allan Bazinet
819d2aeef1
Formatting
2024-11-01 10:48:56 -07:00
Allan Bazinet
9eec77d4e0
Eliminate conditional check
...
Conditional is always true at this point; we literally just set the conditions required for it to be true.
2024-11-01 10:42:12 -07:00
Allan Bazinet
9caccdd4af
Dead shared code removal, nzhsym
...
Half-symbol stop index; no longer used by called Fortran code. Additionally, command-line parameter to set transmit period to anything other than 1 minute is also no longer relevant.
2024-11-01 10:37:33 -07:00
Allan Bazinet
9587b5b62c
Dead shared code removal, ntr
...
Historically used by MSK144 mode; no longer relevant
2024-11-01 10:12:00 -07:00
Allan Bazinet
ecd70e8a64
Remove dead single decode support, C++ side
2024-11-01 09:40:02 -07:00
Allan Bazinet
9a82e3edb6
Dead shared code removal, ntol
...
Historically used by modes like MSK144; no longer relevant.
2024-11-01 08:39:44 -07:00
Allan Bazinet
fbc7c3b7f3
Dead shared code removal, n2pass
...
Historically used by JT65; no longer relevant.
2024-11-01 08:35:17 -07:00
Allan Bazinet
3eed0807c0
Ongoing dead shared code removal
...
Deleting unused fields minw, dttol, minSync; of historical interest only, no longer used.
2024-11-01 08:32:48 -07:00
Allan Bazinet
41d639ec36
Ongoing dead shared code removal
...
Deleting unused fields emedelay, nlist, listutc, naggressive, nrobust; of historical interest only, no longer used.
2024-11-01 08:25:10 -07:00
Allan Bazinet
7ba81b2b4b
Dead code removal, nclearave
...
Historical use only; no longer relevant, used int the past for Q65.
2024-11-01 08:16:08 -07:00
Allan Bazinet
3c8e49b4b4
Remove duplicate nftx shared field
...
This is simply an alias for nfqso; it’s entirely redundant
2024-11-01 07:52:41 -07:00
Allan Bazinet
4f1be01811
Dead shared Fortran parameters removal
...
lapcqonly and ljt65apon are just completely dead and can be removed immediately. nQSOProgress and lft8apon were concepts relating to using a variable number of decoder passes per QSO state, but we don’t have QSO states as WSJTX does, and always do 4 passes.
2024-11-01 06:27:48 -07:00
Allan Bazinet
a3e5dcd673
Dead common Fortran code removal
...
The shared decoder parameters ntxmode, mygrid, hiscall, and hisgrid are unused dead stores, related only long-deleted WSJTX function; remove them.
2024-11-01 05:37:56 -07:00
Allan Bazinet
346db7dc1a
Default submode on new installs to Normal
2024-10-31 07:29:55 -07:00
Allan Bazinet
163c57cf97
Use enum value, not zero
2024-10-31 07:29:26 -07:00
Allan Bazinet
a58f9a7136
Submode HB test to accessor; simplify logic
2024-10-31 07:27:22 -07:00
Allan Bazinet
efea433d89
Reduce default decode passes from 3 to 2
2024-10-30 18:44:10 -07:00
Allan Bazinet
274dc702f7
Namespace private constants
...
Move state constants to a State namespace, and hoist up the configurable defaults (dial frequency, frequency, decoder depth) so that they’re not buried lower down.
2024-10-30 11:47:36 -07:00
Allan Bazinet
18f6534918
Don’t parameterize modulator by frame rate
...
There’s zero chance of us using anything other than 48 kHz; there’s no value in allowing anything else.
2024-10-28 09:35:08 -07:00
Allan Bazinet
8a6a06c2cb
Pass only submode to modulator
2024-10-28 07:51:13 -07:00
Allan Bazinet
ee43de6f73
Pass period to modulator when start called
...
Resolves thread safety issue, and the period is only used as an immediate value during the start call, it’s not required to be an instance variable.
2024-10-28 07:25:14 -07:00
Allan Bazinet
976c6f2433
Pass start delay, rather than period, to modulator
2024-10-28 07:03:33 -07:00
Allan Bazinet
9d887dc721
JS8 Submode namespace updates
...
Convert symbo samples, start delay, and period to unsigned; rename startDelay to startDelayMS for clarity.
2024-10-28 06:47:47 -07:00
Allan Bazinet
611e5d5d33
Reorder modulator parameters; avoid defaults
2024-10-27 21:16:31 -07:00
Allan Bazinet
5db8874b48
Don’t parameterize Modulator tone spacing
...
Since the sample rate is a constant, the modulator can figure out the tone spacing by itself, based on the frames per symbol, we don’t need to parameterize it.
2024-10-27 20:58:02 -07:00
