lancommander-ref/LANCommander
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix PowerShell module loading in launcher

Browse source 
When running Windows, set execution policy to bypass. Load modules and trap exceptions that might be thrown. This outputs a warning message per PS module instead of full script execution failing.
This commit is contained in:
Pat Hartl 2026-07-05 14:43:02 -05:00
parent 08f5b5f76d
commit 99569f65c0
1 changed files with 32 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

40
LANCommander.SDK/PowerShell/PowerShellScript.cs
View file

@ -176,21 +176,45 @@ namespace LANCommander.SDK.PowerShell
var initialSessionState = InitialSessionState.CreateDefault();
initialSessionState.AddCustomCmdlets();
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
initialSessionState.ExecutionPolicy = Microsoft.PowerShell.ExecutionPolicy.Bypass;
// Always import synced PowerShell modules so their functions are available to every script
var modulesPath = AppPaths.GetConfigPath("Modules");
if (Directory.Exists(modulesPath))
{
foreach (var moduleDirectory in Directory.GetDirectories(modulesPath))
initialSessionState.ImportPSModule(new[] { moduleDirectory });
}
initialSessionState.AddCustomCmdlets();
DisableWow64Redirection();
using (Runspace runspace = RunspaceFactory.CreateRunspace(initialSessionState))
{
runspace.Open();
var modulesPath = AppPaths.GetConfigPath("Modules");
if (Directory.Exists(modulesPath))
{
foreach (var moduleDirectory in Directory.GetDirectories(modulesPath))
{
try
{
using var import = System.Management.Automation.PowerShell.Create();
import.Runspace = runspace;
import.AddCommand("Import-Module")
.AddParameter("Name", moduleDirectory)
.AddParameter("ErrorAction", "Stop");
import.Invoke();
if (import.HadErrors)
foreach (var error in import.Streams.Error)
Logger.LogWarning("Failed to load module {ModuleDirectory}: {ErrorMessage}", moduleDirectory, error.Exception?.Message);
}
catch (Exception ex)
{
Logger.LogWarning(ex, "Failed to load module {ModuleDirectory}", moduleDirectory);
}
}
}
// Ensure TLS 1.2 is available for web requests (GitHub, etc.)
using (var tls = System.Management.Automation.PowerShell.Create())