lancommander-ref/SharpCompress
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

code review changes

Browse source
This commit is contained in:
Adam Hathcock 2026-03-06 15:16:28 +00:00
parent 15d6d3c641
commit ebd784cfb2
3 changed files with 7 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/SharpCompress/Archives/ArchiveFactory.Async.cs
View file

@ -6,7 +6,6 @@ using System.Threading;
using System.Threading.Tasks;
using SharpCompress.Common;
using SharpCompress.Factories;
using SharpCompress.IO;
using SharpCompress.Readers;
namespace SharpCompress.Archives;
@ -123,7 +122,7 @@ public static partial class ArchiveFactory
return FindFactoryAsync<T>(new FileInfo(filePath), cancellationToken);
}
public static async ValueTask<T> FindFactoryAsync<T>(
private static async ValueTask<T> FindFactoryAsync<T>(
FileInfo finfo,
CancellationToken cancellationToken = default
)

8
src/SharpCompress/Archives/IWritableArchiveExtensions.cs
View file

@ -1,8 +1,6 @@
using System;
using System.IO;
using SharpCompress.Common;
using SharpCompress.Common.Options;
using SharpCompress.Writers;
namespace SharpCompress.Archives;
@ -11,7 +9,7 @@ public static class IWritableArchiveExtensions
extension(IWritableArchive writableArchive)
{
public void AddAllFromDirectory(
string filePath,
string directoryPath,
string searchPattern = "*.*",
SearchOption searchOption = SearchOption.AllDirectories
)
@ -19,12 +17,12 @@ public static class IWritableArchiveExtensions
using (writableArchive.PauseEntryRebuilding())
{
foreach (
var path in Directory.EnumerateFiles(filePath, searchPattern, searchOption)
var filePath in Directory.EnumerateFiles(directoryPath, searchPattern, searchOption)
)
{
var fileInfo = new FileInfo(filePath);
writableArchive.AddEntry(
path.Substring(filePath.Length),
Path.GetFileName(filePath),
fileInfo.OpenRead(),
true,
fileInfo.Length,

8
src/SharpCompress/Archives/IWritableAsyncArchiveExtensions.cs
View file

@ -2,9 +2,7 @@ using System;
using System.IO;
using System.Threading;
using System.Threading.Tasks;
using SharpCompress.Common;
using SharpCompress.Common.Options;
using SharpCompress.Writers;
namespace SharpCompress.Archives;
@ -13,7 +11,7 @@ public static class IWritableAsyncArchiveExtensions
extension(IWritableAsyncArchive writableArchive)
{
public async ValueTask AddAllFromDirectoryAsync(
string filePath,
string directoryPath,
string searchPattern = "*.*",
SearchOption searchOption = SearchOption.AllDirectories
)
@ -21,13 +19,13 @@ public static class IWritableAsyncArchiveExtensions
using (writableArchive.PauseEntryRebuilding())
{
foreach (
var path in Directory.EnumerateFiles(filePath, searchPattern, searchOption)
var filePath in Directory.EnumerateFiles(directoryPath, searchPattern, searchOption)
)
{
var fileInfo = new FileInfo(filePath);
await writableArchive
.AddEntryAsync(
path.Substring(filePath.Length),
Path.GetFileName(filePath),
fileInfo.OpenRead(),
true,
fileInfo.Length,