Mag-nus
dfafa2f026
Few more minor bug fixes with the help of Claude ( #4471 )
2026-08-03 11:48:25 +00:00
gmriggs
3dbcd775f4
fix Kiss of the Grave and some other fellowship spells ( #4425 )
...
* fix Kiss of the Grave and some other fellowship spells
* revise comment
2026-03-26 01:24:47 -04:00
Coldeve-ACE
f5a514beb9
Null Catches ( #4341 )
...
* Update Position.cs
* Update DamageEvent.cs
* Update GameEventFellowshipFullUpdate.cs
* Update EmoteManager.cs
* Update Monster_Combat.cs
* Update DamageEvent.cs
2025-08-11 22:36:48 -04:00
Galli
ecd6ce2b43
Remove UTF-8 BOMs across repository ( #4324 )
...
* remove bom from source files
* Remove stray BOM cleanup comments
2025-06-22 15:33:36 -04:00
OptimShi
7d78202ddc
Reworked Gear Plating Name functionality to fix some gaps and omissions. ( #4276 )
...
* Reworked Gear Plating Name functionality to fix some gaps and omissions, as well as added a `fix-gear-plating` dev command.
* Update DeveloperDatabaseCommands.cs
---------
Co-authored-by: OptimShi <26606778+OptimShi@users.noreply.github.com>
Co-authored-by: Ty Conner <tyconner@itcproductions.com>
2025-03-09 05:22:17 -04:00
Ty Conner
5daa27656b
[DEBUG] Try Catch and log GetCell crash ( #4187 )
...
* [DEBUG] Try Catch and log GetCell crash
* Update PositionExtensions.cs
2024-09-15 22:33:48 -04:00
FlaggAC
7f1b58ab24
Change static readonly fields to const fields. ( #4211 )
...
This will at least somewhat improve performance, as confirmed through microbenchmark testing.
const fields are replaced with literal values in the Assembly's IL code, while static readonly fields may be optimized by the JIT, and is not guaranteed to happen. const fields may also lend themselves to stronger optimizations at runtime.
2024-08-24 14:32:35 +00:00
Mag-nus
2b61b28147
Cumulative updates ( #4180 )
...
* Many lb group performance related updates
* fixes
* tweak partitioner
* Implement LandblockGroupMinSpacingWhenDormant
* More threaddebug
* cleanup
2024-06-28 10:43:53 -04:00
Mag-nus
2498c623cb
Adjust cross-thread error message ( #4181 )
2024-05-17 19:07:43 +00:00
Mag-nus
c96ef83409
More aggressively try to split larger landblock groups ( #4171 )
...
This also reduces the spacing by 1 which should still be plenty safe.
2024-05-12 02:39:04 +00:00
Mag-nus
95e60bf23a
Allow for irregular shaped lb groups ( #4166 )
2024-05-12 02:37:27 +00:00
Mag-nus
ef427aa6e5
lbgroupstats ( #4165 )
...
* lbgroupstats
Stats about landblock groups
* update formatting
2024-05-12 02:37:02 +00:00
Mag-nus
8fdd2ee9c2
ThreadDebug ( #4161 )
...
* ThreadDebug
* add more info on longest ticked lb group
* Improved thread paritioning
* RollingTimeSpanTracker
2024-05-12 02:35:32 +00:00
gmriggs
c13f82d408
add missing .Item to Cloak custom MinProc ( #4140 )
2024-03-26 05:46:50 -04:00
Mag-nus
9d70b48380
Improve logging overhead by fixing string interpolation ( #4107 )
...
* First batch
* Second batch
* another batch
* last batch hopefully
* fix
2024-03-13 02:38:39 +00:00
Mag-nus
63dcd84541
Improve Offline Player Saving ( #4100 )
...
PlayerManager saves offline players in bulk, once very hour. This is done in bulk to help avoid desync between offline player updates.
Player caching is typically set to 30 min.
What can happen now is that PlayerManager may save a bunch of offline players, that will then be loaded into the player biota cache (for 30 min)... then after 30 min, they all get unloaded because nothign touches those biotas, then 30 min later again the PlayerManager performs its hourly maint of bulk save, thus, re-caching all those biotas.
Caching is not necessary for these biotas.
Caching is designed for biotas that exist in an online state.
2024-02-03 20:43:13 +00:00
Ty Conner
bbf0afdaa7
Wire up Core Plating for Gear Knights ( #4080 )
...
* Wire up Core Plating for Gear Knights
* Update CorePlating.cs
* Update CorePlating.cs
2024-01-20 14:58:29 -05:00
gmriggs
f328b57e98
update hardcoded literal in Fellowship.AddConfirmedMember to proper const ( #4092 )
...
* update hardcoded literal in Fellowship.AddConfirmedMember to proper const
* consistency
2024-01-18 12:39:21 -05:00
Ty Conner
12e569652f
Switch to System.Text.Json ( #4002 )
...
* Switch to System.Text.Json
Removed Newtonsoft.Json and DouglasCrockford.JsMin
* Update GameConfiguration.cs
* Update MasterConfiguration.cs
* Update ThreadConfiguration.cs
* Update StarterSpell.cs
* Update StarterGearFactory.cs
* Update Program_Setup.cs
* Update LifestonedConverter.cs
* Update Program_Setup.cs
* Update Program_Setup.cs
* Update ACE.Adaptor
Shift JSON weenie [de]serialization to System.Text.Json
* Update LifestonedConverter.cs
* Update StarterGearFactory.cs
* Update ACE.Server.csproj
* Update ACE.Server.Tests.csproj
* Update Program.cs
* Update MySqlConfiguration.cs
* Update DDDConfiguration.cs
* Update ModContainer.cs
* Update ModManager.cs
* Update ModMetadata.cs
* Update ModMetadata.cs
2023-12-21 14:15:38 -05:00
gmriggs
0922fa024e
update Fellowship.SplitLuminance() to better match retail ( #4042 )
2023-09-13 11:51:44 -04:00
Ty Conner
4538cff246
Add isWeaponSpell to Enchantments ( #4034 )
...
* Add fromWeapon to Enchantments
Used with checking for player.AugmentationIncreasedSpellDuration
* Update AddEnchantmentResult.cs
* Update EnchantmentManager.cs
* Update EnchantmentManagerWithCaching.cs
* Update WorldObject_Magic.cs
2023-08-16 00:00:23 -04:00
Ty Conner
ab54cf9002
Add support for client DAT patching from server ( #3979 )
...
* Update DatFile.cs
* Update DatFileType.cs
Co-Authored-By: OptimShi <OptimShi@users.noreply.github.com>
* Create DDDManager.cs
Co-Authored-By: OptimShi <OptimShi@users.noreply.github.com>
* Create GameMessageDDDBeginDDD.cs
Co-Authored-By: OptimShi <OptimShi@users.noreply.github.com>
* Create GameMessageDDDDataMessage.cs
Co-Authored-By: OptimShi <OptimShi@users.noreply.github.com>
* Update DDDHandler.cs
Co-Authored-By: OptimShi <OptimShi@users.noreply.github.com>
* Update WorldManager.cs
* Update Program.cs
* committing changes provided
Co-Authored-By: OptimShi <OptimShi@users.noreply.github.com>
* more wip changes
* Update DDDManager.cs
* Update DDDManager.cs
Co-Authored-By: OptimShi <OptimShi@users.noreply.github.com>
* Update CMostlyConsecutiveIntSet.cs
Co-Authored-By: OptimShi <OptimShi@users.noreply.github.com>
* Update WorldManager.cs
* Update DDDHandler.cs
* Update Session.cs
* Update DDDManager.cs
* Update Session.cs
* Update DDDManager.cs
* Update DDDManager.cs
* Update GameMessageDDDDataMessage.cs
* Update DDDHandler.cs
* Update Session.cs
* Update CAllIterationList.cs
Co-Authored-By: OptimShi <OptimShi@users.noreply.github.com>
* Update CMostlyConsecutiveIntSet.cs
Co-Authored-By: OptimShi <OptimShi@users.noreply.github.com>
* Create PTaggedIterationList.cs
Co-Authored-By: OptimShi <OptimShi@users.noreply.github.com>
* Update Session.cs
* Update ConnectionListener.cs
* Create DDDConfiguration.cs
* Update MasterConfiguration.cs
* Update Config.js.example
* Update DDDManager.cs
* Update DDDHandler.cs
* Update Program.cs
* Update PropertyManager.cs
* Update WorldManager.cs
* Update SessionTerminationReason.cs
* Update DDDHandler.cs
* Update DDDManager.cs
* Update ConnectionListener.cs
* Update SessionTerminationReason.cs
* Update GameMessageDDDDataMessage.cs
* Update AuthenticationHandler.cs
* Update CharacterHandler.cs
* Update PacketInboundLoginRequest.cs
* Update Session.cs
* Update DatFileType.cs
---------
Co-authored-by: OptimShi <OptimShi@users.noreply.github.com>
2023-06-09 13:15:10 -04:00
Alissa
624afe668f
Cloak proc configuration ( #3955 )
...
* potential opt-in style fix for attributes being able to be augmented above 100 innate
* Fix valid attribute query to target valid attributes
* Fix debug message
* Cleanup messages
* more message cleanup
* target attribute must have points distributed to it
* when redistributing attributes, reset the free attribute reset timer
* Clean up message for verify-attributes augmentation fix
* opt-in attribute exploit fix; cleaned up query, comments, debug messages
* opt-in attribute exploit fix; line format debug messages
* Opt-in style fix for attribute augmentation exploit; remove unnecessary file
* Update Source/ACE.Server/Managers/PropertyManager.cs
flip boolean per suggestion and previous discussion
Co-authored-by: Ty Conner <tyconner@itcproductions.com>
* Add new configuration properties for cloaks to permit custom proc scaling. Modified cloak class to optionally use the new properties
* remove debugging version of the formula for custom proc rate
* Add min proc chance to permit configuration of the lower bound
---------
Co-authored-by: Ty Conner <tyconner@itcproductions.com>
2023-03-19 11:58:37 -04:00
gmriggs
bc09da25df
fixes for previous checkins ( #3926 )
...
* Revert "Adjust calculation of Max Range for Spells (#3924 )"
This reverts commit d1278dd31a
2022-11-28 14:54:42 -05:00
Ty Conner
d1278dd31a
Adjust calculation of Max Range for Spells ( #3924 )
...
* Adjust calculation of Max Range for Spells
based on client calculation found in CACQualities::InqSkillLevel
Thanks to @nwg5817 for finding the bug and resolution
Co-Authored-By: JMAilan <12468698+nwg5817@users.noreply.github.com>
Co-Authored-By: gmriggs <8909245+gmriggs@users.noreply.github.com>
* Further adjustments
Co-Authored-By: JMAilan <12468698+nwg5817@users.noreply.github.com>
Co-Authored-By: gmriggs <8909245+gmriggs@users.noreply.github.com>
* Update Player_Magic.cs
* Update Player_Magic.cs
Co-authored-by: JMAilan <12468698+nwg5817@users.noreply.github.com>
Co-authored-by: gmriggs <8909245+gmriggs@users.noreply.github.com>
2022-11-24 12:52:47 -05:00
Ty Conner
a7d7cb1677
Pre-Validate Tailoring Intermediates ( #3896 )
...
Log errors if pre-validation some how fails to catch capacity issues
2022-08-31 01:47:14 -04:00
Ty Conner
fbdea1fc8a
Update CastSpellParams.cs ( #3894 )
2022-08-29 19:06:31 -04:00
gmriggs
63c325561a
add support for InqYesNo on hooked items ( #3895 )
2022-08-29 16:45:16 -04:00
Ty Conner
a073a9c8e1
Cap Allegiance Rank to 10 ( #3854 )
2022-05-17 00:21:32 -04:00
Ty Conner
d0ad406f43
Another hslist cache null fix ( #3852 )
...
* Adjust HouseList cache null links
* Another hslist cache null fix
* Update HouseList.cs
2022-05-12 14:14:08 -04:00
Ty Conner
7e0eabec02
Adjust HouseList cache null links ( #3851 )
2022-05-12 00:00:52 -04:00
Ty Conner
baada643e7
Update hslist cache when house is purchased, abandoned, or evicted ( #3837 )
2022-05-07 14:36:03 -04:00
Ty Conner
f51929ef62
Adjust UseWithTarget to support SourceContained spell casting ( #3835 )
...
* Adjust UseWithTarget to support SourceContained spell casting
* Update Player_Magic.cs
* Update RecipeManager.cs
* Update CastQueue.cs
* Update CastSpellParams.cs
* Update MagicState.cs
* Update WindupParams.cs
* Update Player_Magic.cs
* Update Player_Use.cs
2022-05-07 14:23:37 -04:00
Ty Conner
ae71c93890
Generator System Revision 4 - Profile Delays ( #3650 )
...
* Switch from Slot delay to profile only delay
* Update GeneratorProfile.cs
* Update Chest.cs
* Update WorldObject_Generators.cs
* Update WorldObject_Generators.cs
* Update WorldObject_Generators.cs
* Update WorldObject_Generators.cs
* Update WorldObject_Generators.cs
* Update DeveloperCommands.cs
* Update GeneratorProfile.cs
* Update Chest.cs
* Update WorldObject_Generators.cs
* Update WorldObject_Generators.cs
* Update GeneratorProfile.cs
* Update WorldObject_Generators.cs
* Handle GeneratorType.Relative Rotation offsets
* Update GeneratorProfile.cs
* Adjust RemoveQueue and CurrentCreate
* Update WorldObject_Generators.cs
* more gen adjustments
* apply recommended changed
Co-Authored-By: gmriggs <8909245+gmriggs@users.noreply.github.com>
* Update GeneratorProfile.cs
Co-Authored-By: gmriggs <8909245+gmriggs@users.noreply.github.com>
* Update GeneratorProfile.cs
* Update GeneratorProfile.cs
* Update GeneratorProfile.cs
* Update WorldObject_Generators.cs
* Update GeneratorProfile.cs
* Update WorldObject_Generators.cs
* revamp 2-22-22
* Add GenStopSelectProfileConditions
* some cleanup / notes
* Update GeneratorProfile.cs
* Update WorldObject_Generators.cs
* Update DeveloperCommands.cs
* Update GeneratorProfile.cs
* Update Chest.cs
* Update WorldObject_Generators.cs
* Update GeneratorProfile.cs
* Update WorldObject_Generators.cs
* Update WorldObject_Generators.cs
* Update WorldObject_Tick.cs
* Update WorldObject_Generators.cs
* Update WorldObject_Generators.cs
* Update WorldObject_Generators.cs
* more cleanup
* Update DeveloperCommands.cs
* Update GeneratorProfile.cs
* Update WorldObject_Generators.cs
Co-authored-by: gmriggs <8909245+gmriggs@users.noreply.github.com>
2022-03-26 22:44:13 -04:00
Ty Conner
c10eb9844d
Adjust redirect code to apply to T2 item rares such as Blood Drinker ( #3812 )
...
* Adjust redirect code to apply to T2 item rares such as Blood Drinker
* update to support Rage of Grael
2022-03-26 22:31:52 -04:00
gmriggs
2cb93f034b
fix monster homesick radius when they start indoors and end up transitioning to outdoor chase ( #3802 )
2022-02-04 03:56:01 -05:00
Mag-nus
1767210401
Generator GUID gaps ( #3792 )
...
* Slight tweak to CreateNewWorldObject
* Cleanup GeneratorProfile.Spawn GUID leak
* SpawnEncounters destroy()
* Another gap in SpawnEncounters
* Creature_Equipment gaps
2022-01-16 18:30:59 +00:00
Ty Conner
fe64bb116c
Add Lucky White Rabbit's Food mutation ( #3769 )
2022-01-08 14:02:07 -05:00
gmriggs
aa29154355
refactor wielded treasure, fixing some bugs ( #3772 )
2022-01-05 03:22:36 -05:00
Ty Conner
4fb80c5010
Adjust rotation for GeneratorType Relative generators ( #3748 )
2021-11-28 13:12:23 -05:00
Ty Conner
aa01b8f0a7
Change DamageEvent to allow Undef damage from everything except players ( #3747 )
2021-11-28 13:12:10 -05:00
Ty Conner
57087db32c
Wire up vloc2loc command ( #3743 )
...
* Squashed commit of the following:
commit fd22196a5e93ef3b1e83696900475f674f6f285b
Merge: 1b6aa6aca b051129b59d915f069efef90444599c865f50ec7ddca9
2021-11-28 13:11:12 -05:00
ziang4891
cb217b68f6
Rare ImpenBane Support ( #3741 )
2021-11-28 13:11:04 -05:00
ziang4891
07339654dc
Magic refactor ( #3703 )
...
* Start of magic refactor
* Add missed DB update file
* Split out SpellType primitives
* Revert DB column name change
* Fix bug
* gmriggs changes
* gmriggs changes.part2
* Minor tweak
* Proficiency correction
* remove unneeded uint damage
* more consolidation
* refactor for EnchantmentStatus-PlayScript
* add missing return statements for WeenieError.OlthoiCanOnlyRecallToLifestone
* .
* additional-cleanup-for-target-acquisition
2021-11-07 08:10:05 -05:00
gmriggs
44ffaec5f5
prevent society armor from being a tailoring source / target ( #3719 )
2021-10-24 17:29:36 -04:00
gmriggs
fb397c06d3
fix busy state timer for allow_fast_chug=true + pk/pkl + MimeEat/MimeDrink ( #3716 )
2021-10-24 17:29:09 -04:00
Ty Conner
046ec2df0e
More OlthoiPlay support ( #3709 )
...
* Adjust CharacterOption defaults
These changes match client enums and pcaps
* Update Player_Character.cs
* Updates for OlthoiPlay
- Handle OIthoi creation defaults
- Handle Olthoi talking
- Handle Olthoi global chat
* .
* Adjust tells from/to Olthoi
* More IsOlthoiPlayer blocks
* Update Player.cs
* Bit o' refactor
* Update AppraiseInfo.cs
* Update TurbineChatHandler.cs
* Update TurbineChatHandler.cs
* Update Player_Inventory.cs
* Update Player_Inventory.cs
* Revert IsOlthoiPlayer to get/set
* Update Player_Xp.cs
* Update Player.cs
* Update Player_Death.cs
* Update Player.cs
* Update Player_Allegiance.cs
* Update Player_Fellowship.cs
* Update Player_Character.cs
* Update WorldObject_Use.cs
* Update WorldObject_Magic.cs
* Update DamageHistoryInfo.cs
* Update Creature_Death.cs
* Update Player_Death.cs
* Update Player_Trade.cs
2021-10-18 21:14:12 -04:00
ziang4891
a9400f04f1
Olthoi play plus ( #3668 )
...
* adding the very basics for olthoi play
* Add more Olthoi Play restrictions
* Fix merge master conflicts
* Disable Allegiance and Fellowship for Olthoi players
* Add more of the restrictions
* More restrictions
* disable skill XP updates for Olthoi play
* Update comments and WeenieError used
* Disable normal treasure gen for Olthoi players
* Couple more adjustments
* opps
Co-authored-by: gmriggs <gmriggs@gmail.com>
2021-10-14 23:59:37 -04:00
Ty Conner
f64038f799
Fix GiveFromEmote for containers ( #3697 )
...
* Fix GiveFromEmote for containers
* slight refactor
* Update ItemsToReceive.cs
2021-10-11 13:52:52 -04:00
gmriggs
844ff7dbf0
fixing slayer mod for thrown weapons ( #3695 )
...
* fixing slayer mod for thrown weapons
* thown weapon procs
2021-10-09 22:08:49 -04:00
