This refactors a comprehensive set of modules for the GameStore system,
including constants, helpers, and parsers. The changes establish a
robust foundation for handling store offers, user actions, and
transactions in a modular and maintainable way. The most important
changes are the addition of a detailed constants file, helper functions
for offer handling, and a parser module that manages all store-related
protocol events and purchase logic.
**GameStore System Foundation**
* Added a new `gamestore.constants.lua` file containing all core
constants for the GameStore, such as offer types, sub-actions, action
types, coin types, error codes, packet codes, default values,
descriptions, and item limits. This centralizes configuration and
improves maintainability.
**Helper Functions**
* Introduced `gamestore.helpers.lua` with utility functions for
converting offer types to display types and determining if an offer
requires configuration, improving code reuse and clarity in offer
handling.
**Store Event and Purchase Parsing**
* Added `gamestore.parsers.lua` which handles all GameStore protocol
events, including opening the store, searching offers, buying offers,
transferring coins, and transaction history. This module coordinates
with helpers and senders to process requests and responses, including
error handling and purchase validation.
These changes collectively lay out the structure for a feature-rich,
extensible GameStore system, making future enhancements and debugging
easier.
---------
Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Refined the logic for purchasing all blessings in the game store,
ensuring that players cannot exceed the maximum blessing count and that
purchases correctly handle partial blessing states. The changes focus on
improving the validation and processing of the "All Blessings" offer to
prevent over-purchasing and to handle edge cases where some blessings
are already at their maximum.
Blessing purchase logic improvements:
- Updated the validation in `Player.canBuyOffer` to check blessings 2
through 8 for maximum count before disabling the "All Blessings" offer,
ensuring players can only buy it if at least one blessing is not maxed.
- Refactored `GameStore.processAllBlessingsPurchase` to add only the
necessary amount of each blessing, respecting the maximum count per
blessing and handling cases where some blessings are already partially
acquired.
Fix gamestore homepage offer state display inconsistency by implementing proper state validation logic in sendHomePage() function. This change aligns the homepage behavior with other gamestore functions that already implement correct offer state handling.
Co-authored-by: Madara <158350170+caiozord@users.noreply.github.com>
Fixed the exploit when holding enter and clicking the buy button multiple times, buying the same item multiple times even though it was charged for each purchase, this was used to stock up on many exp buffs.
# Description
- Fixed stackable items in store;
- Created script to remove empty parcels from the store inbox on login.
---------
Co-authored-by: Luan Luciano <luanluciano@outlook.com>
This add the ability to set ownership on items. An owned item cannot be
picked up or used by anyone except the character that owns it.
If an owned item is inside a container (backpack, etc) that container is
now also treated as owned. "looking" at an owned item shows you the
owner.
New function:
- `item:setOwner(ownerPlayer or id)`
- `item:getOwnerId()`
- `item:getOwnerName()`
- `item:hasOwner()`
- `item:canBeMoved()`
I also sneaked in some other unrelated improvements that didn't fit any
individual PR in here, but the are pretty small.
---------
Co-authored-by: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Adds a `/namelock` command to help you ax those offensive names from
your server.
It works by providing the player with a "free" mandatory name change
upon login.
---------
Co-authored-by: Elson Costa <elsongabriel@hotmail.com>
Make the debug message: "[NetworkMessage::addString] - Value string is
empty" less vague by adding a context parameter to it.
- addString(value, function)
Resolves#1926
Addressed a conflict between hireling system and gamestore subaction IDs, which led to occasional loss of offers and inconvenienced players who had to repurchase the offers. To resolve this issue, we increased the IDs to larger numbers and conducted a minor system overhaul. This involved transitioning to the use of Key-Value (KV) storage, removing obsolete cache code, and enhancing system clarity and performance for a smoother player experience.
Co-authored-by: Luan Santos <git@luan.sh>
Fixes bug introduced from #1821
A mount was added that does not yet exist in appearances, until we add a new dat, we will just ignore their existence.
Removed invalid mounts.
Continues fixing of #1784 and #1847
• Improved message on exercise_training.
• Fixes reward charges.
• Created flag in prison bosses' scripts to enable minus players and removed already created functions.
• Removed create torch when player login.
• Fixes in 'clearBossRoom' function usage on bosses teleports.
• Fixed count days and time on ferumbras_lever and fixed mechanic of Ascending Ferumbras boss.
• Fixed xp boost storage resetter (on very ss, the storage was being presented, and the player always buy it with 30 tc).
• Added 13.21 new mounts, reordered and fixed typos, changed the word moveable to movable.
• Removed unnecessary spaces.
Continues fixing of #1741
• Created a function to check time in levers and changed with `creature:getStorageValue(config.storage) > os.time()`;
• Adjusted save_interval messages.
• Added check to show msg with payment information when traveling as free.
• Fixed loot to custodian.
• Fixed some typos.
• Adjusted reward talkaction, to check cap.
• Fixed adventurer's stone usage.
• Added messages when starting or stopping using exercise weapons.
• Fixed some events of bosses.
The transfer of houses is now permitted only during server restarts to
prevent server freezing when moving items to the depot. While this is
not the most sophisticated solution, it's the simplest and least
error-prone due to the base's complexity. This approach mirrors what
CipSoft employs in the global version of Tibia and effectively addresses
the issue without introducing possible new bugs.
Additional updates include modifications to NPCs to sell the new kit,
which displays the item's sprite in the wrap container. Support for
using old kits remains, allowing players to convert them into new ones.
Unrelated changes affecting houses:
• Purchasing a house with items still inside is no longer possible. This
prevents issues in rare scenarios, such as incomplete item transfers due
to console closure.
• Introduced an "all" parameter to the "/r" command for removing all
items from a tile.
• Removed the "allowpickUpAble" tags from ground/border and derived
items. These were initially implemented to enable item "throwing" onto
tiles. Now, an item can be thrown only if its type is "trashholder,"
fulfilling the same purpose. This change was made because the check for
items inside the house before purchasing relies on the "pickupable" tag,
which is not applicable to tiles and derivatives.
Stylua is easier to configure than what we had before, since it's
already available as a code action. It also parses the code while it
formats which will help catch syntax errors on PRs automatically.
Hard one to describe because it's a lot of datapack changes bundle
together. Non-exhaustive list:
- Fixed a bunch of small quest details that prevented them for being
completable
- Fixes a few raid locations
- Added a new NPC "Battlemart" that can be used a refiller NPC
- Adjusted spawn densities in some spawns
- Fixed a few details with certain spells
Created vip system functionality with some validations and improvements:
• Adjusted store checking to sell VIP or premium;
• Created configs and scripts;
• Fixed and created validation to auto-loot flag enabled by each player.
Features (Vip Accounts):
• Gain more XP
• Gain more loot
• Gain more skill
• Gain coins to be online
• Gain tokens (customized) to be online
• Toggle auto-loot exclusive
• Reduce familiar cooldown time
• Corrected the behaviour of coins to ensure they function properly. In the market, only transferable coins will be deducted.
• In the store, non-transferable coins will be used first, followed by transferable ones.
• Resolved issues with coins in client version 11.00.
• Fixed several typographical errors.
• Replaced coin management in Lua with C++ functions to eliminate the need for direct SQL queries in Lua scripts.
This adds support for the Tibia client 10x, which connects directly to the server without the need for an AAC login. No changes are required on the AAC side, and you can continue to use the acc/login.php endpoint for the client 11+.
To use the client 10x, simply set the tag "allowOldProtocol" to true or false in the config.lua file. You can only log in using your account name on client 10x, and only using your email on client 11+.
Please note that you will need to update the client 10x to your server's sprites/items data. You can download the client 10x from this link: https://github.com/dudantas/tibia-client/releases/download/13.16.13209/client-10x-outdated-11.00.zip.
For update your .spr and .dat can use the SpiderClientConverter: https://github.com/Arch-Mina/ClientConverter
This changes only includes the protocol update up to 13.16. For the changes related to the features, please check PR #531
Disclaimer: this changes removes tournament system and coins completely since Cipsoft removed it from their client, no way back.
Client for login: https://github.com/dudantas/tibia-client/releases/tag/13.16.13209
Client notes:
• Use the client "client-127.0.0.1-13.16.13209" to test local, it already uses the OpenTibia RSA key and the local ip.
• Place the files "cache/eventscheduler.json" and "cache/boostedcreature.json" as read-only for the correct functioning of the systems by the server.
Exhaustion in all actions, as some other buttons generate a large load of information, such as "parseRequestStoreOffers", thus preventing someone from abusing this to generate a freeze on the server.
By default, all items purchased from the store and sent to the store inbox are marked with ATTR_STORE_ITEM except if you mark the offer as moveable = true
Here is an example of an offer in the store that will be "moveable" from the store inbox (read pull request description for more information).
The behaviour of items purchased through the store will now be the same as in real tibia.
