* Refactor code:
- use timers instead of waypoint wait time workaround
- simplify code (less duplicates, unneeded variables...)
* Add missing text yells, says and emotes
* Improve timers
* Various improvements like running and emotes in the right places
Thanks @Grz3s for his help
* Rework Archmage Arugal in Shadowfang Keep:
- Move AI to RangedCombatAI
- Improve and secure teleport logic
- Move possess yell to the correct place
- Remove many helper methods that can now be replaced by more robust core features/methods
- Prevent Arugal's Voidwalker from entering combat on spawn (thanks @Tobschinski)
Timers are probably off though...
* Rework Shadowfang Keep prisoners:
- Remove workaround using duplicate waypoints to time the event
- Use timers instead and adjust timers
- Add missing emotes and remove incorrect ones
- Adjust a few positions and orientations
- Adjust event sequencing
- Remove unneeded code
- Fix despawn and move back to first waypoint
This closes https://github.com/cmangos/mangos-tbc/pull/440 and closes https://github.com/cmangos/wotlk-db/issues/363
* Harmonise structure and convention of scriptdev2.sql file to ease the use of automated scripts.
Handled:
- white spaces
- inline comments
- streamline quote escaping
- streamline string quotes
- trailing 0 on floats
Not handled:
- clean-up of inline SQL comment when comment field is available in table structure
- long floating point precision
* Implement reset through spell in C'Thun encounter: use proper spell mechanics to reset C'Thun encounter both in Phase 1 and Phase 2 (excluding weakened phase rotation)
Thanks @Tobschinski for his precious help on the matter
Sunken Temple: implement Suppression mechanics in Avatar of Hakkar:
- reset encounter is Suppression casting is not disrupted
- add missing texts
- fix encounter reset (flames count was not reset like it should be)
- fix encounter that could not be restarted if failed
* Add and script missing trigger NPCs
* Add missing area trigger and rescript all involved area triggers
* Adjust locations
* Use proper spells for summoning triggers and knocking back players
(based on sniffs)
- Fix errors and add proper failure condition
- Use proper GameObject casting for ritual objects now that it's possible to do
Requires pending DB update
* Several improvements for quest 5944 (In Dreams)
- Fix Taelan not being attackable while on escort
- Improve texts, timing, facing and global role play of quest end script (epilogue with Tirion Fordring)
- Fix points index
* Fixes and improvements for quests 6402 (Stormwind RendezVous) & 6403 (The Great Masquerade):
- Fix issues with recent waypoints changes
- Add missing spells
- Use proper spells for interacting with guards, morphing into Onyxia, dismissing mount...
- Minor cosmetic adjustements
* Update waypoints index in SD2 SQL file according to previous commits
* Also cleanup some of the data: remove white spaces, streamline escaping of ' and round some long float
* Implement end script for quest 4763 (The Blackwood Corrupted) in Darkshore
- Attract corrupted nearby furbolgs to purify them
- Handle aggro when looting quest items
* Implement quest 2969 (Freedom for all Creatures) in Feralas.
Paths for Captured Sprite Darters are guess work based on videos from retail (old and new). They will be improved when sniffs are available.
* Small improvements to Magmus in Blackrock Depths
- Add intro yell when opening the gates leading to Magmus
- Adjust timers of Ironhand Guardians
- Rename variables to new convention
* Improvements for quest 6482 (Freedom to Ruul) in Ashenvale:
* Add missing escort points
* Improve ambushes:
- correct NPC entries
- correct spawn points
- ambusher should aggro on sight, not straight to the escortee
* add missing end event
* Rework and/or add phase 2 and 3 of Kel'Thuzad encounter in Naxxramas:
- Remove unused emotes (added in WotLK)
- Fix many timers
- Fix some targets in Kel'Thuzad abilities
- Fix Frost Blast
- Implement Chains of Kel'Thuzad (group mind control)
- Properly summon adds in phase 3
- Add Blood Tap ability for Guardian of Icecrown in phase 3
- Add dispell for Kel'Thuzad in phase 3 if more than 3 Guardians of Icecrown are crowd controlled
- Fix and add emotes
