mmo-ref/dep-protobuf
1
0
Fork 0
mirror of https://github.com/protocolbuffers/protobuf synced 2026-08-26 02:23:14 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add JSON and CPP option protos to C++ toolchain blacklisted_protos

Browse source 
Add `//:json_enumvalue_options_proto`, `//:json_options_proto`, and
`//:cpp_file_options_proto` to `blacklisted_protos` in
`proto_lang_toolchain(name = "cc_toolchain")`.

The generated C++ sources for these option protos (e.g.,
`json_enumvalue_options.pb.cc`) are built directly into the core protobuf C++
runtime library (`libprotobuf.so`). Without being listed in `blacklisted_protos`,
any downstream `cc_proto_library` target depending on protos that import these
options will generate and compile duplicate `.pb.cc` objects into separate
shared libraries (e.g., `libjson_enumvalue_options_proto.so`), causing
ODR violations, especially under ASAN mode.

PiperOrigin-RevId: 963673828
This commit is contained in:
Tony Liao 2026-08-12 14:50:40 -07:00 • committed by Copybara-Service
parent 011fbe69e9
commit 66d62e385d
1 changed files with 2 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
BUILD.bazel
View file

@ -602,7 +602,9 @@ proto_lang_toolchain(
blacklisted_protos = [
"//:compiler_plugin_proto",
"//:cpp_features_proto",
"//:cpp_file_options_proto",
"//:descriptor_proto",
"//:json_enumvalue_options_proto",
],
command_line = "--cpp_out=$(OUT)",
plugin = "//src/google/protobuf/compiler/cpp:protoc-gen-cpp",