mmo-ref/dep-protobuf
1
0
Fork 0
mirror of https://github.com/protocolbuffers/protobuf synced 2026-08-26 02:23:14 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(cmake): guard uninitialized variable reads in module compatibility shim (#28426)

Browse source 
The backwards-compatibility loop at the bottom of protobuf-module.cmake.in maps each camel-case output variable to its uppercase alias with set(${UPPER} ${${Camel}}), but does not check the source is defined first. Configuring a consumer with --warn-uninitialized then reports uninitialized reads for the optional variables (Protobuf_SRC_ROOT_FOLDER, Protobuf_IMPORT_DIRS, Protobuf_DEBUG, and the *_DEBUG library variables).

The sibling loop just above, which maps in the other direction, already guards with if(DEFINED ${UPPER}). This applies the same guard to the second loop, which the earlier fix in #1778 missed.

Fixes #19683.

Test plan: reproduced the warning and confirmed the fix with plain cmake, no build required. Extracting the loop into a script and running `cmake -P block.cmake --warn-uninitialized` reports 5 uninitialized-variable warnings before the change and 0 after. Behavior is unchanged when the variables are defined: the uppercase alias is still set.

Closes #28426

COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/28426 from yashanil98:fix/issue-19683-cmake-uninitialized-vars b84e7f11b6
PiperOrigin-RevId: 947022521
This commit is contained in:
yashanil98 2026-07-13 07:12:10 -07:00 • committed by Copybara-Service
parent 2288b33629
commit 7772bbf6e3
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
cmake/protobuf-module.cmake.in
View file

@ -184,6 +184,8 @@ foreach(Camel
Protobuf_LITE_LIBRARY
Protobuf_LITE_LIBRARY_DEBUG
)
string(TOUPPER ${Camel} UPPER)
set(${UPPER} ${${Camel}})
if(DEFINED ${Camel})
string(TOUPPER ${Camel} UPPER)
set(${UPPER} ${${Camel}})
endif()
endforeach()