mmo-ref/dep-protobuf
1
0
Fork 0
mirror of https://github.com/protocolbuffers/protobuf synced 2026-08-26 02:23:14 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Convert list to string for COMMENT argument (#22316)

Browse source 
The issue occurs because CMake expects a single string for the COMMENT argument, but when a list is passed, it tries to expand the list into multiple arguments. To resolve this convert lists to strings using string(REPLACE ...) to join list items into a single string.

```
CMake Warning (dev) at <path>/protobuf-generate.cmake:150 (add_custom_command):
  COMMENT requires exactly one argument, but multiple values or COMMENT
  keywords have been given.
```

Closes #22316

COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/22316 from stima:cmake_generate_comment 09e9eda106
PiperOrigin-RevId: 796637787
This commit is contained in:
R. Savchenko 2025-08-18 17:15:41 -07:00 • committed by Copybara-Service
parent e81876d058
commit aa1f665cdc
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
cmake/protobuf-generate.cmake
View file

@ -140,10 +140,12 @@ function(protobuf_generate)
set(_comment "Running ${protobuf_generate_LANGUAGE} protocol buffer compiler on ${_proto}")
if(protobuf_generate_PROTOC_OPTIONS)
set(_comment "${_comment}, protoc-options: ${protobuf_generate_PROTOC_OPTIONS}")
string(REPLACE ";" " " _protoc_options_str "${protobuf_generate_PROTOC_OPTIONS}")
set(_comment "${_comment}, protoc-options: ${_protoc_options_str}")
endif()
if(_plugin_options)
set(_comment "${_comment}, plugin-options: ${_plugin_options}")
string(REPLACE ";" " " _plugin_options_str "${_plugin_options}")
set(_comment "${_comment}, plugin-options: ${_plugin_options_str}")
endif()
add_custom_command(