mmo-ref/dep-protobuf
1
0
Fork 0
mirror of https://github.com/protocolbuffers/protobuf synced 2026-08-26 02:23:14 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Introduce overflow checking functions for add and multiply in upb to replace error-prone manual checks

Browse source 
PiperOrigin-RevId: 966266256
This commit is contained in:
Protobuf Team Bot 2026-08-17 17:13:28 -07:00 • committed by Copybara-Service
parent 993604ee07
commit c6b856d785
14 changed files with 216 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

6
python/repeated.c
View file

@ -24,6 +24,7 @@
#include "upb/message/array.h"
#include "upb/message/message.h"
#include "upb/mini_table/message.h"
#include "upb/port/overflow.h"
#include "upb/reflection/def.h"
// Must be last.
@ -447,8 +448,9 @@ static bool PyUpb_ExtendSizeCb(Py_ssize_t size, void* vctx) {
PyUpb_ExtendCtx* ctx = (PyUpb_ExtendCtx*)vctx;
ctx->size_hint = size;
size_t old_size = upb_Array_Size(ctx->arr);
if (size > 0 && ((size_t)size <= SIZE_MAX - old_size)) {
if (!upb_Array_Reserve(ctx->arr, old_size + size, ctx->arena)) {
size_t new_size;
if (size > 0 && !upb_AddOverflow(old_size, (size_t)size, &new_size)) {
if (!upb_Array_Reserve(ctx->arr, new_size, ctx->arena)) {
PyErr_SetNone(PyExc_MemoryError);
return false;
}