mirror of
https://github.com/protocolbuffers/protobuf
synced 2026-08-26 02:23:14 -04:00
This CL adds support for the Edition 2026 custom JSON enum name feature (pb.enumvalue.json) in PHP Protobuf. Note that we don't need extension caching similar to C++ or Java because our PHP code generator collects custom JSON names at protoc compile time and passes them to DescriptorPool::internalAddGeneratedFile(), populating EnumValueDescriptor and EnumDescriptor during descriptor registration. Tested with PHP unit tests across pure-PHP and C-extension modes. PiperOrigin-RevId: 963411589
42 lines
1.4 KiB
Bash
Executable file
42 lines
1.4 KiB
Bash
Executable file
#!/bin/bash
|
|
|
|
set -ex
|
|
|
|
cd `dirname $0`/..
|
|
|
|
if [[ -z "${PROTOC}" ]]; then
|
|
PROTOC=$(pwd)/protoc
|
|
fi
|
|
if [ ! -f $PROTOC ]; then
|
|
${BAZEL:-bazel} $BAZEL_STARTUP_FLAGS build -c opt //:protoc $BAZEL_FLAGS
|
|
PROTOC=$(pwd)/bazel-bin/protoc
|
|
fi
|
|
|
|
if [[ -d php/tmp && -z $(find php/tests/proto $PROTOC -newer php/tmp) ]]; then
|
|
# Generated protos are already present and up to date, so we can skip protoc.
|
|
#
|
|
# Protoc is very fast, but sometimes it is not available (like if we haven't
|
|
# built it in Docker). Skipping it helps us proceed in this case.
|
|
echo "Test protos are up-to-date, skipping protoc."
|
|
exit 0
|
|
fi
|
|
|
|
rm -rf php/tmp
|
|
mkdir -p php/tmp
|
|
|
|
find php/tests/proto -type f -name "*.proto"| xargs $PROTOC --php_out=php/tmp -Isrc -Iphp/tests
|
|
|
|
# Needed because any test proto importing json_options / json_enumvalue_options
|
|
# will invoke \GPBMetadata\Google\Protobuf\JsonOptions::initOnce() in its
|
|
# generated metadata class.
|
|
JSON_OPTIONS_FILES="src/google/protobuf/json_options.proto \
|
|
src/google/protobuf/json_enumvalue_options.proto"
|
|
$PROTOC --php_out=php/tmp -Isrc -Iphp/tests $JSON_OPTIONS_FILES
|
|
|
|
if [ "$1" = "--aggregate_metadata" ]; then
|
|
# Overwrite some of the files to use aggregation.
|
|
AGGREGATED_FILES="tests/proto/test.proto tests/proto/test_include.proto tests/proto/test_import_descriptor_proto.proto"
|
|
$PROTOC --php_out=aggregate_metadata=foo#bar:php/tmp -Isrc -Iphp/tests $AGGREGATED_FILES
|
|
fi
|
|
|
|
echo "Generated test protos from tests/proto -> tmp"
|