mirror of
https://github.com/protocolbuffers/protobuf
synced 2026-08-26 02:23:14 -04:00
af91d2a2fc
The previous CL's approach of using `__attribute__((weakref()))` was not actually behaving as expected, and the unit tests were not sufficient to catch this. We now use inline assembly to achieve the functionality that we thought we were getting with `__attribute__((weakref()))`. From assembly, we can create a weak symbol whose value is the same as another "stub" symbol in the same file. Unfortunately we cannot have all of our weak symbols reference a single placeholder "empty" message, due to a bug I discovered in the LLVM linker and reported in https://github.com/llvm/llvm-project/issues/167262 If and when that bug is fixed, we should be able to get optimal tree shaking behavior, even on iOS. PiperOrigin-RevId: 831396179
73 lines
2.3 KiB
C++
73 lines
2.3 KiB
C++
// Protocol Buffers - Google's data interchange format
|
|
// Copyright 2024 Google LLC. All rights reserved.
|
|
//
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file or at
|
|
// https://developers.google.com/open-source/licenses/bsd
|
|
|
|
#include <stddef.h>
|
|
|
|
#include <string>
|
|
|
|
#include <gtest/gtest.h>
|
|
#include "upb/base/string_view.h"
|
|
#include "upb/base/upcast.h"
|
|
#include "upb/mem/arena.h"
|
|
#include "upb/message/message.h"
|
|
#include "upb/mini_table/message.h"
|
|
#include "upb/test/test.upb.h"
|
|
#include "upb/test/test.upb_minitable.h"
|
|
#include "upb/text/debug_string.h"
|
|
|
|
std::string GetDebugString(const upb_Message* input,
|
|
const upb_MiniTable* mt_main) {
|
|
// Resizing/reallocation of the buffer is not necessary since we're only
|
|
// testing that we get the expected debug string.
|
|
char buf[100];
|
|
int options =
|
|
UPB_TXTENC_NOSORT; // Does not matter, but maps will not be sorted.
|
|
size_t real_size = upb_DebugString(input, mt_main, options, buf, 100);
|
|
EXPECT_EQ(buf[real_size], '\0');
|
|
return std::string(buf);
|
|
}
|
|
|
|
TEST(TextNoReflection, ExtensionsString) {
|
|
const upb_MiniTable* mt_main = &upb_0test__ModelWithExtensions_msg_init;
|
|
upb_Arena* arena = upb_Arena_New();
|
|
|
|
upb_test_ModelExtension1* extension1 = upb_test_ModelExtension1_new(arena);
|
|
upb_test_ModelExtension1_set_str(extension1,
|
|
upb_StringView_FromString("Hello"));
|
|
|
|
upb_test_ModelWithExtensions* msg = upb_test_ModelWithExtensions_new(arena);
|
|
|
|
upb_test_ModelExtension1_set_model_ext(msg, extension1, arena);
|
|
|
|
std::string buf = GetDebugString(UPB_UPCAST(msg), mt_main);
|
|
upb_Arena_Free(arena);
|
|
std::string golden = R"([1547] {
|
|
25: "Hello"
|
|
}
|
|
)";
|
|
ASSERT_EQ(buf, golden);
|
|
}
|
|
|
|
TEST(TextNoReflection, ExtensionsInt) {
|
|
const upb_MiniTable* mt_main = &upb_0test__ModelWithExtensions_msg_init;
|
|
upb_Arena* arena = upb_Arena_New();
|
|
|
|
upb_test_ModelExtension2* extension2 = upb_test_ModelExtension2_new(arena);
|
|
upb_test_ModelExtension2_set_i(extension2, 5);
|
|
|
|
upb_test_ModelWithExtensions* msg = upb_test_ModelWithExtensions_new(arena);
|
|
|
|
upb_test_ModelExtension2_set_model_ext(msg, extension2, arena);
|
|
|
|
std::string buf = GetDebugString(UPB_UPCAST(msg), mt_main);
|
|
upb_Arena_Free(arena);
|
|
std::string golden = R"([4135] {
|
|
9: 5
|
|
}
|
|
)";
|
|
ASSERT_EQ(buf, golden);
|
|
}
|