mirror of
https://github.com/protocolbuffers/protobuf
synced 2026-08-26 02:23:14 -04:00
9d98477ca9
This implementation is similar to our Java idea in cl/949670944, basically the idea is that we will have a local map (dictionary) that will be populated the very first time we try to parse into an enum field. The lifetime of this dictionary will be tied to the Parser instance, similar to the Java implementation. BENCHMARKS (baseline stats are recorded at cl/952170250): Python: ``` [BENCHMARK] ParseJsonDefault: med 10.06 us/op | p99 11.22 us/op | mean 10.10 ± 0.20 us/op [BENCHMARK] ParseJsonCustom: med 20.33 us/op | p99 22.23 us/op | mean 20.40 ± 0.34 us/op [BENCHMARK] ParseJsonUnknownIgnored: med 24.21 us/op | p99 26.25 us/op | mean 24.31 ± 0.44 us/op [BENCHMARK] ParseRepeatedJsonDefault: med 1.94 us/item | p99 2.05 us/item | mean 1.95 ± 0.03 us/item [BENCHMARK] ParseRepeatedJsonCustom: med 2.26 us/item | p99 2.45 us/item | mean 2.27 ± 0.03 us/item [BENCHMARK] ParseRepeatedJsonUnknownIgnored: med 5.31 us/item | p99 5.52 us/item | mean 5.32 ± 0.05 us/item ``` Cpp: ``` [BENCHMARK] ParseJsonDefault: med 8.66 us/op | p99 9.21 us/op | mean 8.70 ± 0.13 us/op [BENCHMARK] ParseJsonCustom: med 26.33 us/op | p99 29.71 us/op | mean 26.44 ± 0.69 us/op [BENCHMARK] ParseJsonUnknownIgnored: med 28.46 us/op | p99 31.80 us/op | mean 28.59 ± 0.67 us/op [BENCHMARK] ParseRepeatedJsonDefault: med 1.72 us/item | p99 2.19 us/item | mean 1.74 ± 0.06 us/item [BENCHMARK] ParseRepeatedJsonCustom: med 2.12 us/item | p99 2.38 us/item | mean 2.13 ± 0.04 us/item [BENCHMARK] ParseRepeatedJsonUnknownIgnored: med 4.61 us/item | p99 4.92 us/item | mean 4.62 ± 0.07 us/item ``` UPB: ``` [BENCHMARK] ParseJsonDefault: med 11.22 us/op | p99 12.29 us/op | mean 11.27 ± 0.21 us/op [BENCHMARK] ParseJsonCustom: med 37.54 us/op | p99 39.25 us/op | mean 37.65 ± 0.46 us/op [BENCHMARK] ParseJsonUnknownIgnored: med 41.18 us/op | p99 48.45 us/op | mean 41.30 ± 0.89 us/op [BENCHMARK] ParseRepeatedJsonDefault: med 2.10 us/item | p99 2.19 us/item | mean 2.10 ± 0.02 us/item [BENCHMARK] ParseRepeatedJsonCustom: med 2.58 us/item | p99 2.73 us/item | mean 2.59 ± 0.03 us/item [BENCHMARK] ParseRepeatedJsonUnknownIgnored: med 5.70 us/item | p99 5.90 us/item | mean 5.71 ± 0.04 us/item ``` Seeing these benchmarks, we can see a very noticeable improvement in `ParseRepeatedJsonCustom` and `ParseRepeatedJsonUnknownIgnored` cases -- which correspond to the pathological cases that we are worried about. Singular fields are taking longer to parse in our microbenchmark because the cache that we've added is tied to each Parser instance and must be re-instantiated across every `Parse` call. PiperOrigin-RevId: 970528683 |
||
|---|---|---|
| .. | ||
| import_test_package | ||
| numpy | ||
| __init__.py | ||
| allocation_count.py | ||
| any_test.py | ||
| api_implementation.cc | ||
| api_implementation.py | ||
| builder.py | ||
| containers.py | ||
| decoder.py | ||
| decoder_test.py | ||
| descriptor_database_test.py | ||
| descriptor_pool_test.py | ||
| descriptor_pool_test1.proto | ||
| descriptor_pool_test2.proto | ||
| descriptor_test.py | ||
| duration_test.py | ||
| encoder.py | ||
| enum_type_wrapper.py | ||
| extension_dict.py | ||
| factory_test1.proto | ||
| factory_test2.proto | ||
| field_mask.py | ||
| field_mask_test.py | ||
| file_options_test.proto | ||
| generator_test.py | ||
| import_test.py | ||
| json_format_benchmark.py | ||
| json_format_test.py | ||
| keywords_test.py | ||
| message_benchmark.py | ||
| message_factory_test.py | ||
| message_listener.py | ||
| message_set_extensions.proto | ||
| message_test.py | ||
| missing_enum_values.proto | ||
| more_extensions.proto | ||
| more_extensions_dynamic.proto | ||
| more_messages.proto | ||
| no_package.proto | ||
| packed_field_test.proto | ||
| proto_api_test.py | ||
| proto_api_test_ext.cc | ||
| proto_builder_test.py | ||
| proto_json_test.py | ||
| proto_test.py | ||
| proto_text_test.py | ||
| pybind11_test_module.cc | ||
| python_edition_defaults.py.template | ||
| python_message.py | ||
| python_protobuf.cc | ||
| recursive_message_pybind11_test.py | ||
| reflection_cpp_test.py | ||
| reflection_test.py | ||
| runtime_version_test.py | ||
| self_recursive.proto | ||
| self_recursive_from_py.proto | ||
| service_reflection_test.py | ||
| symbol_database_test.py | ||
| test_bad_identifiers.proto | ||
| test_proto2.proto | ||
| test_proto3_optional.proto | ||
| test_util.py | ||
| testing_refleaks.py | ||
| text_encoding_test.py | ||
| text_format_test.py | ||
| thread_safe_test.py | ||
| timestamp_test.py | ||
| type_checkers.py | ||
| unknown_fields_test.py | ||
| well_known_types.py | ||
| well_known_types_test.proto | ||
| well_known_types_test.py | ||
| wire_format.py | ||
| wire_format_test.py | ||