mmo-ref/dep-ygopro-core
1
0
Fork 0
mirror of https://github.com/edo9300/ygopro-core synced 2026-08-25 16:23:07 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

use lua_rawgeti to get table parameters in Effect,SetCountLimit

Browse source 
Don't rely on lua_next to return elements in order
This commit is contained in:
Edoardo Lolletti 2025-11-16 16:18:58 +01:00
parent 7702a9fd92
commit fa9bea8f37
1 changed files with 6 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

18
libeffect.cpp
View file

@ -108,19 +108,13 @@ LUA_FUNCTION(SetCountLimit) {
uint8_t hopt_index = 0;
uint32_t code = 0;
if(lua_istable(L, 3)) {
lua_pushnil(L);
if(lua_next(L, 3) != 0) {
code = lua_get<uint32_t>(L, -1);
lua_pop(L, 1);
if(!code) {
hopt_index = 0;
lua_pop(L, 1); //manually pop the key from the stack as there won't be a next iteration
} else if(lua_next(L, 3) != 0) {
hopt_index = lua_get<uint8_t>(L, -1);
lua_pop(L, 1);
lua_pop(L, 1); //manually pop the key from the stack as there won't be a next iteration
}
auto top = lua_gettop(L);
lua_rawgeti(L, 3, 1);
code = lua_get<uint32_t>(L, -1);
if(code != 0 && lua_rawgeti(L, 3, 2) != LUA_TNIL) {
hopt_index = lua_get<uint8_t>(L, -1);
}
lua_settop(L, top);
} else
code = lua_get<uint32_t, 0>(L, 3);
uint8_t flag = lua_get<uint8_t, 0>(L, 4);