This may not actually be every file, but I did the best I could.
Command applied:
find . -type f -name "*.lua" | xargs -d '\n' sed -i 's/;//g'
Semicolons are not appropriate in Lua per the style guidelines:
https://github.com/project-topaz/topaz/blob/master/CONTRIBUTING.md
..The nil checks needed to be for string manipulations..
..A lot of commands were getting the name from the player to get the player from the name still..
..I accidentally committed something I didn't intend to last round when I was eliminating case sensitivity, that's undone now back to how it was..
I cannot guarantee that the automation didn't mangle the human readability of a line or two someplace, but I did make sure the console log was clean of errors after.
Also, during this process a great many script errors were spotted. Most incidents were missing requires in quest scripts and these are now corrected.
Reasoning:
Many modern sites and services use the AT symbol (`@`) to direct messages to users, including the service currently hosting our repository. Someone unfamiliar with this (or simply doesn't consider it or doesn't care) can easily create situations where persons not involved in the project could be spammed.
Renamed giveexperiance to givexp, and renamed resetplayer to posfix. The resetplayer command will now print a reminder to use the new command name.
Added ability to handle augments to giveitem and fixed a textIDs issue (it was fetching users zone instead of target when printing message to target).
Could not merge giveitem and additem, thats to many params for me to think about messing with.
Added commands to remove spells, gil, and exp without needing to edit database, and added mobhere, npchere, send, and ah commands.
Took the liberty of removing my old forum name from several commands I had shared, and placed my GitHub username in its place.
CORE: GM commands are now loaded/ran at runtime allowing GMs to add/remove commands on the fly during runtime.
CORE: Removed commands.conf as it is no longer used.
SCRIPTS: Recoded all commands to follow suit with the new command system.
SCRIPTS: Modified a handful of scripts to have more error checks to prevent debug breaks.
SCRIPTS: Modified a handful of scripts to better handle their purpose.
CORE: Updated capAllSkills to include blu and geomancy.
SCRIPTS: Updated @capskill command to include geomancy. Updated status.lua with Action IDs.
CORE / SQL: Added new column to skill_caps.
SQL: Added non-job-specific traits to Rune Fencer and Geomancer. Added weapon skills to Rune Fencer and Geomancer.
The general paradigm here is that the individual spell scripts should be merely data wrappers, providing only the data for their spell and letting the new global file bluemagic.lua handle the heavy lifting. Of course, status effects will still need to be added in the individual spell script. The calculations are based off tried and tested formulas from wiki. Edited most BLU magic 'damaging' spells to their correct message ID. Added helldive.lua as an example script (I will add more shortly).
