- Changed from enum class to just enum to ease bitwise maths.
- Changed `GetType()` and `getType()` to `GetTypeMask()` and `getTypeMask()`
- Added zonetypes for signet/sanction/sigil/ionis in the mask.
- Updated all core references to use bitwise checks. values can now be combined.
- Did update existing enum values in zone settings, but did not add new enums to the values in zone_settings yet
TODO: template so that zonetype can be enum class and still used as a mask. Would like all enum to be typesafe eventually, but far out of scope for this PR.
This may not actually be every file, but I did the best I could.
Command applied:
find . -type f -name "*.lua" | xargs -d '\n' sed -i 's/;//g'
Semicolons are not appropriate in Lua per the style guidelines:
https://github.com/project-topaz/topaz/blob/master/CONTRIBUTING.md
I cannot guarantee that the automation didn't mangle the human readability of a line or two someplace, but I did make sure the console log was clean of errors after.
Also, during this process a great many script errors were spotted. Most incidents were missing requires in quest scripts and these are now corrected.
Reasoning:
Many modern sites and services use the AT symbol (`@`) to direct messages to users, including the service currently hosting our repository. Someone unfamiliar with this (or simply doesn't consider it or doesn't care) can easily create situations where persons not involved in the project could be spammed.
fixed getExtraVar with 3 vars
added setFlag to modify the flag of a status effect via script
changed hasStatusEffect to not check the effect icon
SCRIPTS: modified spawnmob to take the intended optional arguments
added EFFECT_ALL_MISS to make all attacks miss (instead of evade like Perfect Dodge)
added Tiamat mobskill scripts
added Tiamat fight logic
SQL: split Tiamat from Wyrm into her own family
added Tiamat mob_skills entries
CORE: GM commands are now loaded/ran at runtime allowing GMs to add/remove commands on the fly during runtime.
CORE: Removed commands.conf as it is no longer used.
SCRIPTS: Recoded all commands to follow suit with the new command system.
SCRIPTS: Modified a handful of scripts to have more error checks to prevent debug breaks.
SCRIPTS: Modified a handful of scripts to better handle their purpose.
