-Added Echad ring to database tables item_basic, item armor and
item_usable
-Created echad_ring.lua script
-added some more items to item basic. storage slip 15 to 23
I noticed some items were missing this flag because the delivery box was rejecting them even though the UI said they should go through. I checked in POLutils to make sure. They are: all coffer/chest keys, all abjurations, and the purple/brown belt quest items. The black belt quest items do not have this flag, however.
I changed the hardcoded IDs used to check for elemental obis as mods. This made it easier to implement the Hachirin-no-Obi, as well as cleaning up hardcoding.
Added Hachirin-no-Obi as an item and equipable item, as well as adding all of the new obi mods to it. The old obis received the one appropriate mod they should have.
Added a modifier for no MP depleted on cast as a % chance to activate, and gave it to the Hachirin-no-Obi (1%).
Fixed the bug where spells that were weak to the current day were getting a damage boost instead of penalty.
SQL:
-Add item definition for Furusumi
-Add item definition for Ranka
-Add item definition for Scroll of Gekka: Ichi
-Add item definition for Scroll of Yain: Ichi
-Add item definition for Toolbag (Ranka)
-Add item definition for Toolbag (Furusumi)
-Add spell defintion for Gekka: Ichi
-Add spell definition for Yain: Ichi
SCRIPTS:
-Add item scripts for Toolbag Ranka/Furusumi
-Add item scripts for Scroll of Gekka: Ichi / Yain: Ichi
-Add spell scripts for Gekka: Ichi, Yain: Ichi
-Update Solby-Maholby (Norg Merchant) to sell Gekka/Yain
scrolls, as he is the vendor
CORE:
-Map FUrusumi/Ranka tools -> Shikanofuda universal tool
-Extend range for usuable items in Item Utils, as the
new tool bags fall outside of the previous upper bound
(there is a gap)
The bulk this file as it exists in my working copy was originally part of Compmike19's huge patches/archives, and I've tried to mesh that work into the newer Darkstar trunk copy.
I had permission to share those changes a long time ago, and had them on the forum back before the switch to git. I took the patch down because it got way far out of date repeatedly.
Since then, I've been hesitant to put this type of thing into a pull request because I keep hearing that I've been accused of code theft by somebody.
To that person: I've never sought credit for work that isn't mine, so learn2opensource, and blow me.
Missing:
cehuetzi_claw
cehuetzi_ice_shard
cehuetzi_pelt
dullahan_armor
goblin_dice
maliyakaleya_coral
rakaznar_visage_i
rakaznar_visage_ii
rakaznar_visage_iii
rakaznar_visage_iv
rakaznar_visage_v
sifs_lock
sifs_macrame
waktza_rostrum
yggdreant_bole
Deliberately omitted:
Riverfin_Soup
Checked in polutils as seeing a 3hr food made stackable was suspicious. Polutils says stack size is 1, so I assume SE made a mistake in their post on the official SE forums when they included Riverfin soup.
Nokkhi Jinjahl will now bundle every item announced.
All the bundled items should properly unpack as well.
Added missing Fusion Bolt.
No more "YourOwnCharacterName smiles slyly at you." in San d'Oria and Bastok.
Implemented Abilities:
Spontaneity - Makes the next spell have no cast time or recast time, as if the caster was under the effect of Chainspell. The implementation mirrors Chainspell, but removes itself after a single spell
Stymie - One Hour Special. Grants a magic accuracy bonus to the next enfeeble spell. From the available information, it seems that as long as the mob is not immune to the status effect, then it will land unresisted. The implementation attempts to mirror this by checking for Stymie + Immunity, and returning unresisted if not immune in the function to calculate resistance to a status effect that is used by all enfeebling spells.
Implemented Spells:
Addle - Increases the targets casting time and lowers their magic accuracy. The exact formula is not known, but the best available information says that the raw value is ~30%, and is boosted to ~50% if Saboteur is active, so this implementation assumes that is the case.
Temper - Grants the target the effect of Multi Strikes, which gives them Double Attack.
Formula used from BGWiki:
-Enhancing Magic Skill < 360 : DA % = 5%
-Enhancing Magic Skill ≥ 360 : DA % = floor( Enhancing Magic Skill - 300 ) ÷ 10 )
-Cap: 20%
TODO: Spell animations, confirm ability animations.
This changes attempts to implement all remaining missing features for NIN, up to Lv99
The following changes are implemented:
SPELLS:
Aisha: Ichi - Lowers the targets attack by 15%. Corresponding tools / toolbags / and scrolls have been finished as necessary as well.
http://wiki.bluegartr.com/bg/Aisha:_Ichi
Yurin: Ichi - Gives the target the effect Inhibit TP, which lowers TP gain. Lowers TP gain by 10%. Corresponding tools / toolbags / and scrolls have been finished as necessary as well.
http://wiki.bluegartr.com/bg/Yurin:_Ichi
Myoshu: Ichi - Grants the caster the effect of Subtle Blow Plus, with a Subtle Blow Bonus of +10. Corresponding tools / toolbags / and scrolls have been finished as necessary as well.
http://wiki.bluegartr.com/bg/Myoshu:_Ichi
Migawari: Ichi - Makes the caster immune to "severely damaging attacks" for the next minute. These are defines as attacks that do damage within a certain threshold of the caster's max hp. From best available info, the threshold starts at 100% of the users max hp, and is lowered by 1% per 5 ninjutsu skill. Corresponding tools / toolbags / and scrolls have been finished as necessary as well.
http://wiki.bluegartr.com/bg/Migawari:_Ichi
Kakka: Ichi - Grants the caster the effect of Store TP, with a Store TP bonus of +10. Corresponding tools / toolbags / and scrolls have been finished as necessary as well.
TODO: Ryuno base price does not seem to be listed on any of the major wikis. If someone with retail is willing to check this for me I will happily put it in the SQL.
http://wiki.bluegartr.com/bg/Kakka:_Ichi
ABILITIES:
Issekigan - NIN 95 - Substantially increases parrying rate for the next minute. The exact rate is not know, but from the testing linked to from the BGWiki article, it is thought that if you have already capped out your parry rate at 25%, Issekigan will boost you beyond that by another 25% to cap out at around 50% for the duration of the effect. The user will also be granted an emnity bonus for each successful parry.
http://wiki.bluegartr.com/bg/Issekigan
Mikage - NIN 96 - NIN One Hour Ability - Makes your main hand attacks vary with the number of utsusemi shadows that are currently up.
TODO: Determine correct animation. I can't find any screenshots or videos of it, and it is not listed in Altana Viewer. If anyone is willing to help me out with that it would be appreciated :p right now it has the same animation as Issekigan set.
http://wiki.bluegartr.com/bg/Mikage
TRAITS:
Tactical Parry - Grants a TP bonus on each successful parry. Implemented for all job / tier levels that have it. Conflicting information between FFXIcyclopedia / BGWiki as to whether the trait is affected by Store TP or not. BGWiki says no, and seems to be more reliable on this fact, as FFXIclopedia's info is listed as unconfirmed, so the implementation is not affected by Store TP.
http://wiki.ffxiclopedia.org/wiki/Tactical_Parryhttp://wiki.bluegartr.com/bg/Tactical_Parry
Mag. Burst Bonus - Grants a bonus to the magic burst damage.
http://wiki.ffxiclopedia.org/wiki/Magic_Burst_Bonus
Skillchain Bonus - Grants a bonus to skillchain damage.
http://wiki.ffxiclopedia.org/wiki/Skillchain_Bonus
This collectively should make nin fully functional all the way to 99.
Cura III is now learnable and has its correct base price, mp, cast times, etc set according to BGWiki
Implementation is very similar to the implementation of Cura/Cura II: largely semi-educated guesswork based off of the best available info on BGWiki, as I could not find a concrete cura formula anywhere. Should be reasonably close, workable.
DATABASE: Removed all 3 breath attack from the Raptor Family and gave their specific region spawn types only 1 breath dependent on zone. Set Memory receptacles magic resistances from .2 to .5 . Fix for morion_tathlum and holy_ampulla not appearing in the AH.