Commit graph

299 commits

Author SHA1 Message Date
Fedja Beader
1b6de71bf1 Put variable declarations into scope where they are used.
****
Approved-by: Jesusalva Jesusalva <jesusalva@themanaworld.org>
2024-03-11 19:29:50 +00:00
Fedja Beader
6f2eb19e89 Make pickup code go to nearby tile, not on top of item.
Fixes most cases of walking through doors/warps on pickup.

****
2024-03-11 18:26:36 +00:00
Jesusalva Jesusalva
ce718ac588 Update copyright headers up to 2023 2024-02-09 13:36:22 +00:00
Fedja Beader
5009e37678 Fix unable to pickup non-ignored items while standing on an ignored
item.

What happened:
1) The pickup code first tries to pickup first item under you without
checking if it is ignored.
2) ::pickUp queries ratelimiter, which clears to send.
3) ::pickUp checks if item is ignored and bails out
4) The pickup code did not bail early, despite "success" of (1) and
   selects a non-ignored item to pick-up.
5) ::pickUp queries ratelimiter, which thinks that a packet has been
   sent in (2) and aborts.
2023-08-16 10:47:10 +00:00
Andrei Karas
1e2a88e975
Fix some code style issues 2020-02-23 09:30:51 +03:00
Andrei Karas
6eb1f6e52f
Fix code style 2019-04-09 01:30:49 +03:00
Andrei Karas
b6043379e6
Add separate auto move sync distance for legacy servers 2019-04-08 19:26:31 +03:00
Andrei Karas
0e3549dd92
Possible fix for desync in moving
Handle player stop packet always.
Check desync always if tile changed client side.
Check desync always if server move response packet received.
Removed unused configuration option.
2019-03-21 01:36:40 +03:00
Andrei Karas
d530e74cc4
Update copyright year. 2019-01-01 20:04:08 +03:00
Andrei Karas
0c20db8d10
Remove extra ; from different code. 2018-11-27 20:33:15 +03:00
Andrei Karas
485e9bb12b
Fix code style. 2018-11-05 01:09:30 +03:00
Andrei Karas
a6d18b282a
Fix code style. 2018-10-29 02:02:04 +03:00
Andrei Karas
44ef654716
Add support for hightlight attribute in groups.xml
This attribute allow to highlight gm groups based on groups.xml
2018-03-04 01:39:30 +03:00
Andrei Karas
4d2e202ee0
Update copyrights year. 2018-01-04 07:12:38 +03:00
Andrei Karas
c58b6c63c8
Remove default parameters from userpalette. 2017-12-22 02:51:27 +03:00
Andrei Karas
5133814218
Remove default parameters from properties.h 2017-12-22 02:03:59 +03:00
Andrei Karas
cc7a39f467
Remove default parameters from map. 2017-12-22 01:28:56 +03:00
Andrei Karas
adc96cc9f4
Remove default parameters from actormanager.cpp 2017-12-17 21:45:33 +03:00
Andrei Karas
58c319a56a
Remove default parameters from localplayer. 2017-12-17 19:51:59 +03:00
Andrei Karas
1be5a1cd67
Remove default parameter from PlayerInfo::setStatMod. 2017-12-17 02:33:41 +03:00
Andrei Karas
e91a8c39e3
Remove default parameter from PlayerInfo::setStatBase. 2017-12-17 02:07:28 +03:00
Andrei Karas
910e16e9c4
Remove extra nextTile function from localplayer. 2017-12-16 01:33:36 +03:00
Andrei Karas
78afa65947
Remove default parameters from soundmanager. 2017-12-14 02:21:30 +03:00
Andrei Karas
ee1fc0b63c
Remove default parameters from ChatTab::chatLog. 2017-12-11 19:10:19 +03:00
Andrei Karas
a499c34b05
Add packet SMSG_PLAYER_GET_EXP2 0x0acc. 2017-10-18 16:21:43 +03:00
Andrei Karas
a8041ac281
Fix some issues with int64 to int32 implicit conversions. 2017-09-27 23:43:44 +03:00
Andrei Karas
9429dc4f5b
Change player job level, exp from stat object to attribute. 2017-09-27 22:35:38 +03:00
Andrei Karas
64d30eda26
Rename Attributes::PLAYER_LEVEL to Attributes::PLAYER_BASE_LEVEL. 2017-09-27 20:27:11 +03:00
Andrei Karas
68a7dd2259
Change attributes value type to int64. 2017-09-27 01:34:49 +03:00
Andrei Karas
b3383a1069
Remove default patameter from LocalPlayer::setAction. 2017-08-22 02:26:10 +03:00
Andrei Karas
42f47e483d
Remove useless else. 2017-08-21 22:45:15 +03:00
Andrei Karas
b8b4e4c524
Replace static members usage from pointers to direct classes.
clang-tidy warning: readability-static-accessed-through-instance
2017-08-14 16:40:47 +03:00
Andrei Karas
a366d82dad
Move group id from localplayer to being. 2017-07-12 21:12:24 +03:00
Andrei Karas
03948f9bc5
Rename gm level into group id in localplayer.cpp 2017-07-12 21:12:24 +03:00
Andrei Karas
64d81679e4
Add packet SMSG_PLAYER_ATTRS 0x0b25.
It allow set local player attributes from server.
For now it send real group id.
2017-07-12 19:20:20 +03:00
Andrei Karas
864e023e0f
Move foreach macroses into separate file. 2017-06-29 20:53:56 +03:00
Andrei Karas
38873bb99d
Move virtual methods from Being constructor to postInit. 2017-06-13 19:56:05 +03:00
Andrei Karas
2f768a34f7
Rename player_relations into playerRelations. 2017-06-11 01:00:01 +03:00
Andrei Karas
407de0a8d0
Fix code style. 2017-06-09 20:30:47 +03:00
Andrei Karas
c6ac11341b
Fix code style. 2017-06-09 00:18:08 +03:00
Andrei Karas
aa0e715fe6
Remove useless extern declarations. 2017-06-08 02:13:12 +03:00
Andrei Karas
36ba43d6ea
Fix clang-tidy check readability-implicit-bool-cast. 2017-06-07 19:23:40 +03:00
Andrei Karas
5612fb3a7f
Fix code style. 2017-06-04 03:18:46 +03:00
Andrei Karas
0c1c6b5df1
Fix wrong checks after removing some server features. 2017-05-08 18:43:49 +03:00
Andrei Karas
47085588f6
Fix compilation without tmwa support. 2017-05-02 20:11:41 +03:00
Andrei Karas
e74e27e0f9
Remove extra includes. 2017-05-02 03:50:33 +03:00
Andrei Karas
a173e97258
Remove ServerFeatures haveExpPacket because it depend only on server type. 2017-05-01 21:26:09 +03:00
Andrei Karas
d9be3eb4cf
Remove ServerFeatures haveVending because it depend only on server type. 2017-05-01 20:11:13 +03:00
Andrei Karas
f06f491e3f
Remove ServerFeatures haveAttackDirections because it depend only on server type. 2017-05-01 19:49:57 +03:00
Andrei Karas
87918db755
Remove ServerFeatures haveItemColors because it depend only by server type. 2017-05-01 17:52:56 +03:00