mmo-ref/mc-fabric-api
1
0
Fork 0
mirror of https://github.com/FabricMC/fabric synced 2026-08-19 06:26:07 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix: No Glow Inside Sulfur Cube (#5442)

Browse source
This commit is contained in:
modmuss 2026-06-18 15:44:40 +01:00 • committed by GitHub
parent 22d0830f2e
commit 93d3a2f58c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
fabric-renderer-api-v1/src/client/java/net/fabricmc/fabric/mixin/client/renderer/block/render/BlockModelRenderStateMixin.java
View file

@ -40,7 +40,7 @@ import net.minecraft.client.renderer.SubmitNodeCollector;
import net.minecraft.client.renderer.block.BlockModelRenderState;
import net.minecraft.client.renderer.block.dispatch.BlockStateModelPart;
import net.minecraft.client.renderer.rendertype.RenderType;
import net.minecraft.util.RandomSource;
import net.minecraft.util.LightCoordsUtil;
import net.fabricmc.fabric.api.client.renderer.v1.Renderer;
import net.fabricmc.fabric.api.client.renderer.v1.mesh.Mesh;
@ -63,8 +63,7 @@ public abstract class BlockModelRenderStateMixin implements FabricBlockModelRend
@Nullable
private IntList tintLayers;
@Shadow
@Nullable
private RandomSource randomSource;
public int blockLightCoords;
@Unique
@Nullable
@ -113,11 +112,13 @@ public abstract class BlockModelRenderStateMixin implements FabricBlockModelRend
// TODO: improve this injection or use a second submit for just the mesh
@Inject(method = "submitModel", at = @At("HEAD"), cancellable = true)
private void submitMesh(RenderType renderType, PoseStack poseStack, SubmitNodeCollector submitNodeCollector, int lightCoords, int overlayCoords, int outlineColor, CallbackInfo ci) {
private void submitMesh(RenderType renderType, PoseStack poseStack, SubmitNodeCollector submitNodeCollector, int externalLightCoords, int overlayCoords, int outlineColor, CallbackInfo ci) {
if (mesh != null && mesh.size() > 0) {
List<BlockStateModelPart> modelPartsCopy = modelParts != null && !modelParts.isEmpty() ? new ObjectArrayList<>(modelParts) : Collections.emptyList();
Mesh meshCopy = mesh.immutableCopy();
int[] tints = tintLayers != null ? tintLayers.toArray(EMPTY_TINTS) : EMPTY_TINTS;
// Match vanilla BlockModelRenderState#submitModel: lightCoords
int lightCoords = LightCoordsUtil.max(externalLightCoords, blockLightCoords);
if (transformation != null) {
poseStack.pushPose();