mmo-ref/mudlet
1
0
Fork 0
mirror of https://github.com/Mudlet/Mudlet synced 2026-08-13 18:26:27 -04:00
Code Issues Projects Releases Packages Wiki Activity
mudlet/src/dlgConnectionProfiles.cpp

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

2887 lines
124 KiB
C++
Raw Permalink Normal View History

start
2009-01-24 02:50:22 +01:00
/***************************************************************************
Rearrange includes to improve compile times. This also allows for memory leak checking on MSVC by having include surrounding Qt headers, which break if you have a macro define new to be something which tracks line information.
2014-08-15 02:11:43 -07:00
* Copyright (C) 2008-2013 by Heiko Koehn - KoehnHeiko@googlemail.com *
* Copyright (C) 2014 by Ahmed Charles - acharles@outlook.com *
Fix: Clazy warnings part 1 - range-loop-detach (#9195) #### Brief overview of PR changes/additions One of a series of PRs, each addressing a type of issue reported by Clazy. This is the: "C+11 range-loop might detach Qt container [clazy-range-loop-detach]" one. #### Motivation for adding to Mudlet Remove warnings detected by the Clazy tool - either when explicitly run on the Mudlet code-base or detected by the background scanner/analyser that Qt Creator offers. #### Other info (issues closed, discussion etc) There was over 100 of this particular item - some of them also could have `const` applied to the iterator. --------- Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
2026-04-16 14:30:33 +01:00
* Copyright (C) 2016-2018, 2020-2023, 2025-2026 by Stephen Lyons *
Enhance: allow the use of system provided QtKeyChain packages (both QMAKE & CMAKE) (#3619) If environmental variable `WITH_OWN_QTKEYCHAIN` is defined to (Case insensitive) `NO` then a system package which places the relevant files in `qt5keychain` folders will be used. If said files are not present then builds will fail. If the variable is set to any other value or not defined at all then Mudlet will do as it did before and download the library from a git repository - there is a separate PR in progress at the moment to change where from and that might need revision to combine cleanly with this PR. Revised to only use find_package(Qt5Keychain) for system library case, it seems we should not use this CMake command when we are building the library ourselves... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Vadim Peretokin <vperetokin@gmail.com>
2020-04-30 02:35:42 +01:00
* - slysven@virginmedia.com *
Infra: Use modern For loop syntax (#8162) #### Brief overview of PR changes/additions No functional change, just internal refactoring #### Motivation for adding to Mudlet Easier to read, clearer style #### Other info (issues closed, discussion etc)
2025-09-16 13:15:54 +02:00
* Copyright (C) 2025 by Lecker Kebap - Leris@mudlet.org *
start
2009-01-24 02:50:22 +01:00
* *
* This program is free software; you can redistribute it and/or modify *
* it under the terms of the GNU General Public License as published by *
* the Free Software Foundation; either version 2 of the License, or *
* (at your option) any later version. *
Fix: initial window too small on first launch
2009-01-30 01:27:51 +01:00
* *
start
2009-01-24 02:50:22 +01:00
* This program is distributed in the hope that it will be useful, *
* but WITHOUT ANY WARRANTY; without even the implied warranty of *
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License *
* along with this program; if not, write to the *
* Free Software Foundation, Inc., *
* 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. *
***************************************************************************/
Rearrange includes to improve compile times. This also allows for memory leak checking on MSVC by having include surrounding Qt headers, which break if you have a macro define new to be something which tracks line information.
2014-08-15 02:11:43 -07:00
start
2009-01-24 02:50:22 +01:00
#include "dlgConnectionProfiles.h"
Rearrange includes to improve compile times. This also allows for memory leak checking on MSVC by having include surrounding Qt headers, which break if you have a macro define new to be something which tracks line information.
2014-08-15 02:11:43 -07:00
Infrastructure: reduce Mudlet build times by 30s (#8403) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Reduce Mudlet build times #### Motivation for adding to Mudlet Address #6765, and give developers a better experience. #### Other info (issues closed, discussion etc) Benchmark Results === Testing: development (before) (development) === Run 1 of 3... Time: 226.071397436s Run 2 of 3... Time: 216.059263209s Run 3 of 3... Time: 221.592760908s === Testing: PR #8403 (after) (pr-8403) === Run 1 of 3... Time: 191.112400957s Run 2 of 3... Time: 193.975717783s Run 3 of 3... Time: 196.569316252s [benchmark-mudlet-build.sh](https://github.com/user-attachments/files/24466717/benchmark-mudlet-build.sh) --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2026-01-08 21:04:24 +01:00
#include <pugixml.hpp>
Rearrange includes to improve compile times. This also allows for memory leak checking on MSVC by having include surrounding Qt headers, which break if you have a macro define new to be something which tracks line information.
2014-08-15 02:11:43 -07:00
start
2009-01-24 02:50:22 +01:00
#include "Host.h"
#include "HostManager.h"
Rearrange includes to improve compile times. This also allows for memory leak checking on MSVC by having include surrounding Qt headers, which break if you have a macro define new to be something which tracks line information.
2014-08-15 02:11:43 -07:00
#include "LuaInterface.h"
Infrastructure: centralise predefined MUD game data (#6434) This moves the "description" data into the same container as all the other details for the predefined MUDS. That data is then refactored out of the `./src/mudlet.h` file into a separate smaller file that only needs to be `#include`d into two class files - so changing any details requires less to rebuild the application. This PR also removes the 3rd party dependency "qt-ordered-map" (which is 3-clause BSD licensed but NOT currently mentioned in our "About" dialogue!) Afterwards the details for each predefined MUD is held in a `QList<T>` instead - with a couple of helper methods defined to reproduce the information retrieval methods used in the prior code. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Vadim Peretokin <vperetokin@gmail.com>
2022-11-27 00:00:34 +00:00
#include "TGameDetails.h"
Feature: command line improved -> different autocompletion scheme | Feature: user toolbar graphics problems solved & 2 state buttons implemented | Feature: stop-all-triggers | Feature: script_editor: add new as sibling except if parent is a folder | Feature: MultiView button
2009-02-08 06:30:23 +01:00
#include "XMLimport.h"
Run clang-format on headers.
2017-04-14 00:40:02 -07:00
#include "mudlet.h"
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
#include "CredentialManager.h"
#include "SecureStringUtils.h"
infrastructure: make windows safe to destroy while a field has the text cursor (#9596) #### Brief overview of PR changes/additions - New `utils::disconnectChildSignals()`, called by the destructors of the connection dialog, the preferences and the editor: a window stops listening to its own widgets before it goes away. - Covers the reported case (connection dialog `Profile name` field) plus the same exposure found in the preferences (MMCP chat name, shortcut editors) and the editor (item name, command, pattern and sound file fields). The preferences and the editor had no destructor at all before this. - New `DialogTeardownTest` covering all three windows, plus a canary that fails if a future Qt stops emitting the focus-out signals the whole thing rests on. #### Motivation for adding to Mudlet Destroying one of these windows while the text cursor sits in one of its fields aborts the run - which is how #9574 turned up, in a functional test - and the windows should simply be safe to destroy, rather than safe only along the `close()` paths that happen to hide them first. #### Other info (issues closed, discussion etc) Closes #9574. The mechanism: a visible window is taken off the screen while its base-class destructors unwind (`~QDialog` hides it, `~QWidget` closes any other window class). That moves the keyboard focus off the field holding it, the field reports `editingFinished()`, and Qt delivers that to a slot of an object whose derived part is already gone: ``` ASSERT failure in dlgConnectionProfiles: "Called object is not of the correct type (class destructor may have already run)" ``` **How much of this can a player hit today: as far as I can trace, none of it**, which is why there are no crash reports behind this: - Every production teardown goes through `close()` / `accept()` / `reject()` first, and that hide happens while the object is still whole - so the field's `editingFinished()` is delivered normally and the edit is saved, exactly as before. `Host::closeChildren()` closes the editor that way, `mudlet::closeEvent()` closes the connection dialog that way. - Nothing `delete`s or `deleteLater()`s these three windows directly. - At exit `main()` deletes the QApplication, which destroys platform windows without running widget destructors, so the preferences dialog - the one window nothing explicitly closes - is never destructed either. - The assert is a `Q_ASSERT_X`, and since we never set `CMAKE_BUILD_TYPE`, Qt defines `QT_NO_DEBUG` for our builds and compiles it out. A shipped build would not abort at that point; it would run the slot against destroyed members instead, which is undefined behaviour that can quietly rename a profile or a trigger. So this is a latent trap rather than a live player crash: it fires today in the test suite, and it fires the moment any future code destroys one of these windows while it is on screen. The fix is small enough to be worth taking on those terms. Verified with standalone Qt probes: `QLineEdit` emits once anything has written to it (`setText()` is enough, even with an empty string), `QAbstractSpinBox` and `QKeySequenceEdit` emit unconditionally, and plain child widgets such as the editor's `dlg*MainArea` panels are not exposed - their slots still run while they are alive. `test/functional_tests/DialogTeardownTest.cpp` is formatted with the repo's clang-format, which the older tests next to it predate. **Test case:** `ctest -R DialogTeardownTest`. All three cases abort on `development` with the assert above and pass here. There is no manual GUI reproduction - see the tracing above.
2026-08-03 11:40:11 +02:00
#include "utils.h"
Rearrange includes to improve compile times. This also allows for memory leak checking on MSVC by having include surrounding Qt headers, which break if you have a macro define new to be something which tracks line information.
2014-08-15 02:11:43 -07:00
Infrastructure: Swap out QtConcurrent module header for sub-module ones (#9246) #### Brief overview of PR changes/additions The Qt documentation for `QtConcurrent` points out: > If you include the `<QtConcurrent>` header, the entire Qt Concurrent module with the entire Qt Core module will be included, which may increase compilation times and binary sizes. To use individual functions from the QtConcurrent namespace, you can include more specific headers. > > The table below lists the functions in the QtConcurrent namespace and their corresponding headers: |Function|Header| |--------|------| |`QtConcurrent::run()`|`<QtConcurrentRun>`| |`QtConcurrent::task()`| `<QtConcurrentTask>`| |`QtConcurrent::filter()`,<br>`QtConcurrent::filtered()`,<br>`QtConcurrent::filteredReduced()`|`<QtConcurrentFilter>`| |`QtConcurrent::map()`,<br>`QtConcurrent::mapped()`,<br>`QtConcurrent::mappedReduced()`|`<QtConcurrentMap>`| #### Motivation for adding to Mudlet To speed up the build a little by removing stuff that isn't needed. #### Other info (issues closed, discussion etc) In doing this I happened to start cleaning up a couple of header files `T2DMap.h` and then `mudlet.h`, I then got into converting some `#include`s into forward declarations in a "include-what-you-use" move. This then rippled through into a (more than 10!) number of files but should "improve" things. Note that the ordering of `#include` in many files seems to be rather haphazard and is due for some serious overhaul - I suggest that we should actually declare an "official" style for this project so that everyone knows what it is. **During the CI/CB process I discovered that Linux and then MacOS builds were failing because the file referred to by the `#include <QtConcurrentTask>` header file was missing, yet was present on my local PC when I was using the Qt framework from the On-line installer. Initially I suspected a Debian (and then Devuan - as the packaged version on my own machine also had this defect AND Ubuntu) package problem; however it now seems to be an upstream Qt issue as the various Qt versions & OS combinations suggest that Qt themselves fixed it for Qt 6.10:** | OS | QtVersion | Missing header | |--------|-----------------------|----------------| | Windows| 6.11.0 package | No | | Devuan | 6.8.2 package | Yes | | Devuan | 6.10.0 online install | No | | Ubuntu | 6.9.0 package | Yes | | Debian | 6.8.2 package | Yes | | MacOS | 6.9.0 package | Yes | **To fix this I reverted to an `#include <qtconcurrenttask.h>` for Linux and MacOS builds - although it would probably have been better to make it conditional on the Qt Version instead...** *I have reported this upstream to Debian - see: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1135197* --------- Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2026-04-29 13:35:29 +01:00
#include <QtConcurrentRun>
Run clang-format on headers.
2017-04-14 00:40:02 -07:00
#include <QtUiTools>
infrastructure: decouple the mapper engine from UI dialogs (#9513) #### Brief overview of PR changes/additions - Removes all raw Qt Widgets usage from the map engine: `TMap.{h,cpp}` no longer owns a `QProgressDialog` (and drops a dead `QFileDialog` include), and `XMLimport.{h,cpp}` no longer pulls in `QApplication` (the clipboard read now uses `QGuiApplication::clipboard()`, which lives in Qt Gui). - The standalone map-progress dialog (shown when the mapper is not visible, for map download / XML import and JSON export/import) is now driven by Qt signals carrying pre-translated payloads; the frontend (`TMainConsole`) owns the actual `QProgressDialog`, and a user cancel returns to the engine through `TMap::slot_mapProgressDialogCancelled()`. - Adds `MapProgressDialogSeamTest` covering the transfer-progress state machine, a JSON export/import round trip driving the new signals, a mid-import cancel delivered through the seam (the highest-risk change, since the JSON reader used to poll `QProgressDialog::wasCanceled()` synchronously), and an XML map import re-entered from inside a running JSON operation. #### Motivation for adding to Mudlet Second concrete step of the re-scoped libmudlet plan (a Qt-Widgets-free `mudlet_core` for headless use, testability and WASM). It copies the seam template established in #9507: core emits a pre-translated payload -> frontend owns the widget -> a callback slot returns the answer. The Qt Widgets dependency audit (`cmake/audit-core-widgets.sh`) drops from **151 to 147** offending files; `TMap.cpp`, `TMap.h`, `XMLimport.cpp` and `XMLimport.h` are all now clean. The mapper-owned inline progress path (`dlgMapper`/`T2DMap`, Mudlet's own widgets) is deliberately untouched here - those move wholesale in the later target-split phase. #### Other info (issues closed, discussion etc) Part of #8681 / #9011. Existing translations are unaffected: every progress string keeps its `TMap` `tr()` context, so current translations carry straight over. Two new strings do arrive, both with `//:` translator comments - the warnings shown when a map download or an XML map import is refused because a JSON import/export is already running. The JSON dialog stays non-modal and the download/import dialog keeps its modeless styling, each applied by the frontend. The engine keeps its own `mMapProgressStandalone` / `mMapProgressCancelRequested` / `mMapProgressStandaloneMaximum` state to replace the widget read-backs it used to do (`!= nullptr`, `wasCanceled()`, `maximum()`). If a map operation ever reaches the engine before a console is wired (checked via `isSignalConnected`), `TMap::warnIfMapProgressUnwired()` logs a loud `qWarning` rather than silently running with no progress UI. It also closes a latent null-dereference that exists on `development` today. With the mapper visible a map download takes the inline-progress path, leaving `mpProgressDialog` null - so a JSON export started meanwhile sails past the `if (mpProgressDialog)` "already in progress" check and creates a dialog of its own. When the download then finishes inside the `processEvents()` pump the export is running, `clearTransferProgress()` deletes and nulls *that* dialog, and the export's next `incrementJsonProgressDialog()` dereferences null. The engine now records whose dialog is up (`mMapProgressIsTransfer`) so a transfer only ever closes its own, and `importMap()` refuses to start while a JSON operation holds the progress - the mirror of the guard `downloadMap()` has. Two review-driven details worth flagging: the frontend only wires the dialog's cancel to the engine when the operation is actually cancelable, so a non-cancelable local XML import no longer turns a window-close into a spurious "Map download was canceled" message; and the standalone download/import dialog is now parented to the console (like the JSON one always was, and like #9507's package-download dialog), so it centres on and dies with the profile window. The three `#include <QApplication>` additions to `Host.cpp` / `dlgTriggerEditor.cpp` / `dlgConnectionProfiles.cpp` replace the transitive include they used to get from `XMLimport.h`; all three are already Qt Widgets consumers, so the audit count is unaffected. Assisted-by: Claude:claude-opus-4-8 Assisted-by: Claude:claude-opus-5 **Test case:** With a mapper window open, use a game that supports map download (or call `downloadMap()`) and confirm the progress dialog shows, updates, and its Abort cancels the download. Then with the mapper window closed, run `exportJsonMap()` and `importJsonMap()` on a large map and confirm the non-modal JSON progress dialog appears, updates its Areas/Rooms/Labels counts, and that clicking Abort during an import stops it with an "aborted by user" result. Load a local XML map (Settings -> Map -> load) and confirm closing its progress window does not print a "Map download was canceled" line. Everything should behave exactly as on `development`. #### Demo (before & after) https://github.com/user-attachments/assets/f1c62580-2d03-4e5b-a6ee-f6e2b78d113d
2026-08-02 15:33:07 +02:00
#include <QApplication>
Add ability to define custom color in profile buttons in connection dialog (#5365)
2021-08-13 07:22:24 +02:00
#include <QColorDialog>
Enhance: remove minuscule text from under profile icons (#4712) This finally enables us to do away with the text under the profile icons as it replicates the normal `QListWidget` behaviour to move the selection to each item which begins with the first letter of the key pressed. This also makes the non-matching profiles get disabled which I think makes the action more obvious... Revised to include a timeout on concatenating keypresses: This is to provide the same functionality that the QListWidget does for keypresses, if the keys are typed fast enough they are concatenated to form the text to search for. However if the user types slower than this then the individual keys are only considered on their own. This reflects what both Vadim and I experienced - in that he was typing fast enough to spell out a particular profile but I wasn't and so the profile that I was having selected was changing on each keypress. The time between keypresses allowed so that they can be concatenated I have set to be 1 second. This is significantly slower that the Qt code but it is long enough to permit the temporary disablement of non-matching profiles to be a useful visual feedback - and besides, it makes it easier to specify one of a number of profiles with a common initial text - the longer the timeout the more keys the user can string together! Add `std::chrono` so we can give a time delay as `1s` instead of `1000` mS. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2021-02-03 19:59:35 +00:00
#include <QDir>
fix: a profile named "." or ".." deletes every profile when removed (#9722) #### Brief overview of PR changes/additions - Validation: a typed profile name must be a folder of its own - rejects a lone `.` and anything containing `..`. Folders already on disk stay exempt - Containment: `reallyDeleteProfile()` refuses any path that is not a direct child of `profiles/`, and now checks `removeRecursively()` instead of failing mute - Confirmation: the "nothing to delete" shortcut no longer fires when a map, stored password or dictionary is present #### Motivation for adding to Mudlet A profile named `.` or `..` turned **Remove** into a wipe: `.` resolves to `profiles/`, `..` to the whole `~/.config/mudlet`. The name was accepted with no error, and the confirmation was skipped because a fresh profile looks empty - two clicks deep on the first screen every user sees. #### Other info (issues closed, discussion etc) Pre-existing, not a 5.0 regression - shipped 4.22.0 behaves identically. Dots have been allowed deliberately since 2011 (`ee1fd051c`), and `Achaea 2.0` keeps working. **Test case:** name a new profile `.` and press Remove - previously every profile was deleted with no prompt, now the name is refused. New `ProfileDeletionSafetyTest` drives the real dialog against a temporary config dir, plus `profileFolderPath`/`profileNameUsableAsIs` rows in `ProfileNameValidationTest`. 81/81 ctest pass. Assisted-by: Claude:claude-opus-5
2026-08-08 08:30:14 +02:00
#include <QFileInfo>
Fix: Crash when removing default MUD profiles from welcome window (#8916) #### Brief overview of PR changes/additions Fixes a crash that occurred when users tried to remove the default MUD profiles from the welcome window on Linux. #### Motivation for adding to Mudlet Users on Linux were experiencing crashes when clicking the remove button on the default game profiles in the connection dialog. This made it difficult to clean up the profile list. #### Other info (issues closed, discussion etc) Closes #8907 The fix ensures that password cleanup operations happen one at a time instead of simultaneously, and adds safety checks to handle cases where the dialog might close during the cleanup process.
2026-02-09 05:44:01 -05:00
#include <QPointer>
Cleanup: replace obsolete in Qt 5.11 qrand() & qsrand() (#4494) The replacement `QRandomGenerator` class has been around since Qt 5.10; it is also true that the original qrand() (needing a call to `qsrand()` one per application one to seed it) has been deprecated since Qt 5.11. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2020-12-16 21:04:11 +00:00
#include <QRandomGenerator>
Store character's login passwords securely (#3018) * Added QtKeychain * Wire in QtKeychain into qmake build * Install libsecret-dev in Travis * Got read/write working from the secure storage only * Reset password * Change to using a callback instead of a deep chain of nested calls * Wire in CMake build, but doesn't work yet * Finish CMake build, works now * WIP * Add migration to secure storage * Remove left-in debug echo * Don't forget password when profile is renamed * Don't delete passwords upon migration for now * Revise: insert QtKeyChain licence boilerplate (#17) I have use the 2-Clause BSD (a.k.a the FreeBSD) licence that is in the upstream's "COPYING" file - this is at varience with the two README files which quote the licence as being the Modified BSD which is the 3-Clause one. I have an open issue on the upstream repository seeking clarification; should things not be as they seem it should be a relatively painless operation to select the other boillerplate for this item. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2019-09-09 07:37:11 +02:00
#include <QSettings>
Fix: prevent password loss in PTBs and improve credential debug messages (#8257) #### Brief overview of PR changes/additions - Fixed a bug where users lost their saved passwords when switching between different Mudlet versions - Added safety checks to prevent password deletion unless you're using a newer version (4.20.0+) - Made error messages clearer and more helpful when password loading fails - Improved the system's ability to find passwords stored in different locations - Added better logging to help diagnose password-related issues #### Motivation for adding to Mudlet Users reported that their saved passwords disappeared after trying development versions of Mudlet. This happened because the system was automatically cleaning up old password storage without considering that users might switch back to older versions. The unclear error messages also made it difficult to understand what was happening when passwords couldn't be loaded. #### Other info (issues closed, discussion etc) This fix ensures users can safely test different Mudlet versions without losing their saved passwords. It also makes password-related problems easier to understand and troubleshoot, while maintaining compatibility with all existing Mudlet installations. --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-09-24 07:28:15 -04:00
#include <QSignalBlocker>
improve: split the games list into My games and All games tabs (#9452) #### Brief overview of PR changes/additions - Tab bar above the connection dialog's games list: "My games" (profiles on disk) and "All games" (full catalog), replacing the right-click "Show my profiles only" stop-gap - Opens on My games when profiles exist, All games on a fresh install; last-used tab and the retired filter's setting are honoured; selection preserved across tab switches - Dedicated single-game builds hide the tab bar and keep their current look #### Motivation for adding to Mudlet One flat grid of ~35 games overwhelmed newcomers and buried the profiles a player actually uses. #### Other info (issues closed, discussion etc) Closes #9140 **Test case:** Fresh install → dialog opens on All games with the tab bar visible. Create a profile, restart → opens on My games showing only that profile, selected with details filled. Switch tabs → selection follows where possible; right-click menu no longer offers "Show my profiles only". https://github.com/user-attachments/assets/50b07d6e-7908-4d25-8b4c-4c6e1396aaea --------- Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-29 17:14:14 +02:00
#include <QTabBar>
Fix: prevent password loss in PTBs and improve credential debug messages (#8257) #### Brief overview of PR changes/additions - Fixed a bug where users lost their saved passwords when switching between different Mudlet versions - Added safety checks to prevent password deletion unless you're using a newer version (4.20.0+) - Made error messages clearer and more helpful when password loading fails - Improved the system's ability to find passwords stored in different locations - Added better logging to help diagnose password-related issues #### Motivation for adding to Mudlet Users reported that their saved passwords disappeared after trying development versions of Mudlet. This happened because the system was automatically cleaning up old password storage without considering that users might switch back to older versions. The unclear error messages also made it difficult to understand what was happening when passwords couldn't be loaded. #### Other info (issues closed, discussion etc) This fix ensures users can safely test different Mudlet versions without losing their saved passwords. It also makes password-related problems easier to understand and troubleshoot, while maintaining compatibility with all existing Mudlet installations. --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-09-24 07:28:15 -04:00
#include <QTime>
Add ability to define custom color in profile buttons in connection dialog (#5365)
2021-08-13 07:22:24 +02:00
#include <chrono>
#include <sstream>
Rearrange includes to improve compile times. This also allows for memory leak checking on MSVC by having include surrounding Qt headers, which break if you have a macro define new to be something which tracks line information.
2014-08-15 02:11:43 -07:00
Enhance: remove minuscule text from under profile icons (#4712) This finally enables us to do away with the text under the profile icons as it replicates the normal `QListWidget` behaviour to move the selection to each item which begins with the first letter of the key pressed. This also makes the non-matching profiles get disabled which I think makes the action more obvious... Revised to include a timeout on concatenating keypresses: This is to provide the same functionality that the QListWidget does for keypresses, if the keys are typed fast enough they are concatenated to form the text to search for. However if the user types slower than this then the individual keys are only considered on their own. This reflects what both Vadim and I experienced - in that he was typing fast enough to spell out a particular profile but I wasn't and so the profile that I was having selected was changing on each keypress. The time between keypresses allowed so that they can be concatenated I have set to be 1 second. This is significantly slower that the Qt code but it is long enough to permit the temporary disablement of non-matching profiles to be a useful visual feedback - and besides, it makes it easier to specify one of a number of profiles with a common initial text - the longer the timeout the more keys the user can string together! Add `std::chrono` so we can give a time delay as `1s` instead of `1000` mS. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2021-02-03 19:59:35 +00:00
using namespace std::chrono_literals;
fix: profiles with parentheses in their name can be opened again (#9610) #### Brief overview of PR changes/additions - Parentheses are now allowed in profile names, matching the "name (2)" folders file managers create when copying - Selecting a profile folder made outside Mudlet no longer silently mangles its name and renames the folder on disk - Adds ProfileNameValidationTest for the name validation rules and ProfileFolderNameTest, which drives the real connection dialog against externally-created folders (fails without the fix) #### Motivation for adding to Mudlet Merely selecting a profile folder like "test (2)" mangled its name to "test 2" and silently renamed the folder on disk, and the reporter could not launch the profile at all. #### Other info (issues closed, discussion etc) Assisted-by: Claude:claude-fable-5 Assisted-by: Claude:claude-opus-5 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org> **Test case:** Copy a profile folder to "test (2)" while Mudlet is closed, reopen - the profile keeps its name, Connect/Offline are enabled, and it opens. #### Demo https://github.com/user-attachments/assets/25b1bb4c-eaa7-4079-8b8e-a12de3ebb215
2026-08-04 16:09:42 +02:00
// Kept to a sub-set of ASCII because the profile name is also used as a
// directory name on all supported OSes; parentheses are included so that
// folders duplicated by a file manager (e.g. "profile (2)") work as-is:
const QString dlgConnectionProfiles::scmAllowedProfileNameChars = qsl(". _()0123456789-#&aAbBcCdDeEfFgGhHiIjJkKlLmMnNoOpPqQrRsStTuUvVwWxXyYzZ");
// Returns the first character not permitted in a (new) profile name, or a
// null QChar if all of them are acceptable. An embedded U+0000 is
// indistinguishable from the all-clear sentinel, but a QLineEdit never lets
// one through:
QChar dlgConnectionProfiles::firstInvalidProfileNameChar(const QString& name)
{
for (const QChar& c : name) {
if (!scmAllowedProfileNameChars.contains(c)) {
return c;
}
}
return {};
}
// Characters that make a name unusable no matter where it came from:
// utils::sanitizeForPath() silently rewrites them out of any path built from
// the profile name, and CredentialManager::generateFilePath() refuses to
// produce a path at all - so a profile named this way could never store or
// retrieve its password. Mirrors the pattern used there:
const QRegularExpression dlgConnectionProfiles::scmUnusableProfileNameChars{qsl(R"REGEX(\.\.|[/\\<>:"|?*\x00-\x1f])REGEX")};
infrastructure: keep the profile-removal file list from going stale (#9739) #### Brief overview of PR changes/additions - Hoists the list `slot_deleteProfile()` checks a never-played profile against out of the function to `dlgConnectionProfiles::scmConnectionDetailFiles`, beside the file's other `scm*` constants, and points at it from both `writeProfileData()` implementations. - Adds a `ProfileDeletionSafetyTest` case that sets a profile up through the real dialog (New profile, name it, fill the connection form in, re-select it) and fails if anything it wrote is missing from the list. - Pins the deliberate exclusions too: a profile holding a stored password or a typed-in character name still asks before removal. #### Motivation for adding to Mudlet Nothing linked that list to the ~15 places profile data gets written, so it could silently go stale; because it is an allowlist a stale entry only ever costs an extra confirmation prompt, but the maintenance trap was worth closing. #### Other info (issues closed, discussion etc) Follows up https://github.com/Mudlet/Mudlet/pull/9722#discussion_r3740581754 on #9722 (fix: a profile named "." or ".." deletes every profile when removed). No behaviour change. **Test case:** `ctest -R ProfileDeletionSafetyTest` (20 cases). Removing an entry from the constant makes it fail naming the file; adding `login` makes the character-name case fail. Assisted-by: Claude:claude-opus-5
2026-08-08 19:30:26 +02:00
// Listing what is expected rather than what to watch out for keeps an
// unrecognised file - a stored password, a character name the user typed - on
// the side of asking. ProfileDeletionSafetyTest fails if the connection form
// comes to write anything this does not name:
const QStringList dlgConnectionProfiles::scmConnectionDetailFiles{qsl("url"), qsl("port"), qsl("ssl_tsl"), qsl("description"), qsl("website"), qsl("autologin"), qsl("autoreconnect")};
fix: a profile named "." or ".." deletes every profile when removed (#9722) #### Brief overview of PR changes/additions - Validation: a typed profile name must be a folder of its own - rejects a lone `.` and anything containing `..`. Folders already on disk stay exempt - Containment: `reallyDeleteProfile()` refuses any path that is not a direct child of `profiles/`, and now checks `removeRecursively()` instead of failing mute - Confirmation: the "nothing to delete" shortcut no longer fires when a map, stored password or dictionary is present #### Motivation for adding to Mudlet A profile named `.` or `..` turned **Remove** into a wipe: `.` resolves to `profiles/`, `..` to the whole `~/.config/mudlet`. The name was accepted with no error, and the confirmation was skipped because a fresh profile looks empty - two clicks deep on the first screen every user sees. #### Other info (issues closed, discussion etc) Pre-existing, not a 5.0 regression - shipped 4.22.0 behaves identically. Dots have been allowed deliberately since 2011 (`ee1fd051c`), and `Achaea 2.0` keeps working. **Test case:** name a new profile `.` and press Remove - previously every profile was deleted with no prompt, now the name is refused. New `ProfileDeletionSafetyTest` drives the real dialog against a temporary config dir, plus `profileFolderPath`/`profileNameUsableAsIs` rows in `ProfileNameValidationTest`. 81/81 ctest pass. Assisted-by: Claude:claude-opus-5
2026-08-08 08:30:14 +02:00
// A lone "." is made entirely of permitted characters, yet every path built
// from it addresses the profiles directory rather than a profile of its own -
// as does "..", which scmUnusableProfileNameChars already covers:
fix: profiles with parentheses in their name can be opened again (#9610) #### Brief overview of PR changes/additions - Parentheses are now allowed in profile names, matching the "name (2)" folders file managers create when copying - Selecting a profile folder made outside Mudlet no longer silently mangles its name and renames the folder on disk - Adds ProfileNameValidationTest for the name validation rules and ProfileFolderNameTest, which drives the real connection dialog against externally-created folders (fails without the fix) #### Motivation for adding to Mudlet Merely selecting a profile folder like "test (2)" mangled its name to "test 2" and silently renamed the folder on disk, and the reporter could not launch the profile at all. #### Other info (issues closed, discussion etc) Assisted-by: Claude:claude-fable-5 Assisted-by: Claude:claude-opus-5 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org> **Test case:** Copy a profile folder to "test (2)" while Mudlet is closed, reopen - the profile keeps its name, Connect/Offline are enabled, and it opens. #### Demo https://github.com/user-attachments/assets/25b1bb4c-eaa7-4079-8b8e-a12de3ebb215
2026-08-04 16:09:42 +02:00
bool dlgConnectionProfiles::profileNameUsableAsIs(const QString& name)
{
fix: a profile named "." or ".." deletes every profile when removed (#9722) #### Brief overview of PR changes/additions - Validation: a typed profile name must be a folder of its own - rejects a lone `.` and anything containing `..`. Folders already on disk stay exempt - Containment: `reallyDeleteProfile()` refuses any path that is not a direct child of `profiles/`, and now checks `removeRecursively()` instead of failing mute - Confirmation: the "nothing to delete" shortcut no longer fires when a map, stored password or dictionary is present #### Motivation for adding to Mudlet A profile named `.` or `..` turned **Remove** into a wipe: `.` resolves to `profiles/`, `..` to the whole `~/.config/mudlet`. The name was accepted with no error, and the confirmation was skipped because a fresh profile looks empty - two clicks deep on the first screen every user sees. #### Other info (issues closed, discussion etc) Pre-existing, not a 5.0 regression - shipped 4.22.0 behaves identically. Dots have been allowed deliberately since 2011 (`ee1fd051c`), and `Achaea 2.0` keeps working. **Test case:** name a new profile `.` and press Remove - previously every profile was deleted with no prompt, now the name is refused. New `ProfileDeletionSafetyTest` drives the real dialog against a temporary config dir, plus `profileFolderPath`/`profileNameUsableAsIs` rows in `ProfileNameValidationTest`. 81/81 ctest pass. Assisted-by: Claude:claude-opus-5
2026-08-08 08:30:14 +02:00
return !name.isEmpty() && name != qsl(".") && !name.contains(scmUnusableProfileNameChars);
}
// Resolved textually rather than with QDir::canonicalPath() so that the answer
// does not depend on the folder existing - a predefined game has none until it
// is saved - and so that a symlinked profile folder still resolves.
QString dlgConnectionProfiles::profileFolderPath(const QString& profilesPath, const QString& profile)
{
// Must precede the parent check below, which QDir::cleanPath() would
// otherwise satisfy by collapsing "../profiles/Foo" straight back in:
if (profile.isEmpty() || profile.contains(QLatin1Char('/')) || profile.contains(QLatin1Char('\\'))) {
return {};
}
const QString profilesDir = QDir::cleanPath(profilesPath);
const QString candidate = QDir::cleanPath(qsl("%1/%2").arg(profilesDir, profile));
if (candidate == profilesDir || QFileInfo(candidate).path() != profilesDir) {
return {};
}
return candidate;
fix: profiles with parentheses in their name can be opened again (#9610) #### Brief overview of PR changes/additions - Parentheses are now allowed in profile names, matching the "name (2)" folders file managers create when copying - Selecting a profile folder made outside Mudlet no longer silently mangles its name and renames the folder on disk - Adds ProfileNameValidationTest for the name validation rules and ProfileFolderNameTest, which drives the real connection dialog against externally-created folders (fails without the fix) #### Motivation for adding to Mudlet Merely selecting a profile folder like "test (2)" mangled its name to "test 2" and silently renamed the folder on disk, and the reporter could not launch the profile at all. #### Other info (issues closed, discussion etc) Assisted-by: Claude:claude-fable-5 Assisted-by: Claude:claude-opus-5 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org> **Test case:** Copy a profile folder to "test (2)" while Mudlet is closed, reopen - the profile keeps its name, Connect/Offline are enabled, and it opens. #### Demo https://github.com/user-attachments/assets/25b1bb4c-eaa7-4079-8b8e-a12de3ebb215
2026-08-04 16:09:42 +02:00
}
Revise: select profiles by typing the name, keep profile icons (#4440) Restore the text display of the profile name. This is so that the keyboard selection of profiles beginning with a particular letter works again. This will close issue #4283 . This also sets it to the minimum size trying to hide it by setting the font size to 1 - however that still show something (and a font size of zero is NOT valid). Manipulating the QPalette of the QListWidget does not work well enough in the presence of Styles or StyleSheets to be a viable means of hiding the text either. Also in the `dlgConnection` class: * refactor out some highly repetitive code that sets up the predefined Mud icons. * remove warnings and adopts a change introduced into Qt 5.15 for the QLabel::pixmap() which now requires a Qt::ReturnByValue argument to prevent an obsolete code warning and to force a QPixmap to be returned by value and not reference... * remove a warning about: QListWidget::setItemSelected(QListWidgetItem*,bool) being deprecated and switches to the recommended: QListWidgetItem::setSelected(bool) Edit: the last item above may have become redundant as further commits amalgamated into this PR may have taken out these lines anyhow! Change the custom icon generator so that there is NOT a dependency on the position in the list for the colours used. This means that the same name will always have the same colours - which will help the user to pick out a particular profile as it will always look the same no matter if other profiles are added or removed. Remove the colour gradient in the custom icon as it is not thought to be useful nowadays. Refactor out the colour icon generator to a single method that is called from more than one place. BugFix: restore odd original way of accessing some QPixmaps This was causing failures in some CI platforms using Qt 5.14. or older. Revise: really frob the custom icon generator This is to try and produce as varied but still readable icons when they are generated entirely on the basis of the MUD name - in a reproducible (though Qt do NOT guarantee repeatable qHash() functionality across Qt versions - so they may not stay *that* constant) manner. Refrob: use a table of fixed colours Using only 15 hues but with 3 different saturation level plus 5 grey-scale one should give enough different icons but not generate them too close to each other for those with normal colour vision... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Kebap <kebap_spam@gmx.net>
2020-12-11 17:53:28 +00:00
dlgConnectionProfiles::dlgConnectionProfiles(QWidget* parent)
Infrastructure: move away from constructor initialisation lists - part 1 (#5890) There is also some minor cosmetic changes, mainly with members initialised within the body of the constructors. Also some bogus uses of `nullptr` **pointer** value instead of a `QColor()` default value for a couple of `QColors` in the `dlgRoomSybol` class. I have steered away from using `{}` to initialise simple, POD data types in favour of explicitly stating what their default values are. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-01-21 04:50:50 +00:00
: QDialog(parent)
start
2009-01-24 02:50:22 +01:00
{
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
setupUi(this);
Fix new profiles to be saved correctly when created (#2677)
2019-06-29 12:06:56 +02:00
BugFix: make date display of profile's history follow selected UI locale (#3917) * BugFix: make date display of profile's history follow selected UI locale This PR adds a `QLocale` object to the `mudlet` class that is set to the user's selection of UI locale (language + country) so that items that need to return data in a locale aware form can use: `(const QLocale&) mudlet::getUserLocale()` in order to present their information in their selected form rather than using what they or their OS/DE has set system/desktop-wide. In this PR it is used to format and present in the correct language the date and time entries for the profile's history but it can be used elsewhere within the Mudlet application as needed. Also: * reorder some items in `dlgConnectionProfile`'s class to be correct. * mark an unused argument in `dlgConnectionProfile::slot_update_name(...)` as unused to prevent a warning. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * Revise: exclude the display of a time zone in the profile's history It takes up extra space which is tight in that widget and (apart from the time around a DST change) does not impart much information to the display. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * Apply suggestions from code review Removed unwanted ellipses from debug texts... Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2020-07-01 20:49:55 +01:00
mDateTimeFormat = mudlet::self()->getUserLocale().dateTimeFormat();
if (mDateTimeFormat.contains(QLatin1Char('t'))) {
// There is a timezone identifier in there - which (apart from perhaps
// the period around DST changes) we don't really need and which takes
// up space:
if (mDateTimeFormat.contains(QLatin1String(" t"))) {
// Deal with the space if the time zone is appended to the end of
// the string:
mDateTimeFormat.remove(QLatin1String(" t"), Qt::CaseSensitive);
} else {
mDateTimeFormat.remove(QLatin1Char('t'), Qt::CaseSensitive);
}
}
Game selection dialog icon size (#2231) * Adding Automatic Qt Scaling for HiDPI for Unix systems * Change to drawForeground in TTextEdit to better account for font painting with different screen resolutions in QPixmap * Fix for scrollback buffer * Updated png to 256x256 (from 48x48) * Found the flag to enable hidpi icons * The ui files are setting absolute pixel sizes for the system message area, so we need to scale these pixmaps to account for higher dpi icons 48 -> 256 = 5.3 ratio. Iconsets automatically scale. * Fix giant notification image on connection profiles
2019-01-29 03:27:37 -05:00
QPixmap holdPixmap;
Fix new profiles to be saved correctly when created (#2677)
2019-06-29 12:06:56 +02:00
Revise: select profiles by typing the name, keep profile icons (#4440) Restore the text display of the profile name. This is so that the keyboard selection of profiles beginning with a particular letter works again. This will close issue #4283 . This also sets it to the minimum size trying to hide it by setting the font size to 1 - however that still show something (and a font size of zero is NOT valid). Manipulating the QPalette of the QListWidget does not work well enough in the presence of Styles or StyleSheets to be a viable means of hiding the text either. Also in the `dlgConnection` class: * refactor out some highly repetitive code that sets up the predefined Mud icons. * remove warnings and adopts a change introduced into Qt 5.15 for the QLabel::pixmap() which now requires a Qt::ReturnByValue argument to prevent an obsolete code warning and to force a QPixmap to be returned by value and not reference... * remove a warning about: QListWidget::setItemSelected(QListWidgetItem*,bool) being deprecated and switches to the recommended: QListWidgetItem::setSelected(bool) Edit: the last item above may have become redundant as further commits amalgamated into this PR may have taken out these lines anyhow! Change the custom icon generator so that there is NOT a dependency on the position in the list for the colours used. This means that the same name will always have the same colours - which will help the user to pick out a particular profile as it will always look the same no matter if other profiles are added or removed. Remove the colour gradient in the custom icon as it is not thought to be useful nowadays. Refactor out the colour icon generator to a single method that is called from more than one place. BugFix: restore odd original way of accessing some QPixmaps This was causing failures in some CI platforms using Qt 5.14. or older. Revise: really frob the custom icon generator This is to try and produce as varied but still readable icons when they are generated entirely on the basis of the MUD name - in a reproducible (though Qt do NOT guarantee repeatable qHash() functionality across Qt versions - so they may not stay *that* constant) manner. Refrob: use a table of fixed colours Using only 15 hues but with 3 different saturation level plus 5 grey-scale one should give enough different icons but not generate them too close to each other for those with normal colour vision... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Kebap <kebap_spam@gmx.net>
2020-12-11 17:53:28 +00:00
holdPixmap = notificationAreaIconLabelWarning->pixmap(Qt::ReturnByValue);
Game selection dialog icon size (#2231) * Adding Automatic Qt Scaling for HiDPI for Unix systems * Change to drawForeground in TTextEdit to better account for font painting with different screen resolutions in QPixmap * Fix for scrollback buffer * Updated png to 256x256 (from 48x48) * Found the flag to enable hidpi icons * The ui files are setting absolute pixel sizes for the system message area, so we need to scale these pixmaps to account for higher dpi icons 48 -> 256 = 5.3 ratio. Iconsets automatically scale. * Fix giant notification image on connection profiles
2019-01-29 03:27:37 -05:00
holdPixmap.setDevicePixelRatio(5.3);
Revise: select profiles by typing the name, keep profile icons (#4440) Restore the text display of the profile name. This is so that the keyboard selection of profiles beginning with a particular letter works again. This will close issue #4283 . This also sets it to the minimum size trying to hide it by setting the font size to 1 - however that still show something (and a font size of zero is NOT valid). Manipulating the QPalette of the QListWidget does not work well enough in the presence of Styles or StyleSheets to be a viable means of hiding the text either. Also in the `dlgConnection` class: * refactor out some highly repetitive code that sets up the predefined Mud icons. * remove warnings and adopts a change introduced into Qt 5.15 for the QLabel::pixmap() which now requires a Qt::ReturnByValue argument to prevent an obsolete code warning and to force a QPixmap to be returned by value and not reference... * remove a warning about: QListWidget::setItemSelected(QListWidgetItem*,bool) being deprecated and switches to the recommended: QListWidgetItem::setSelected(bool) Edit: the last item above may have become redundant as further commits amalgamated into this PR may have taken out these lines anyhow! Change the custom icon generator so that there is NOT a dependency on the position in the list for the colours used. This means that the same name will always have the same colours - which will help the user to pick out a particular profile as it will always look the same no matter if other profiles are added or removed. Remove the colour gradient in the custom icon as it is not thought to be useful nowadays. Refactor out the colour icon generator to a single method that is called from more than one place. BugFix: restore odd original way of accessing some QPixmaps This was causing failures in some CI platforms using Qt 5.14. or older. Revise: really frob the custom icon generator This is to try and produce as varied but still readable icons when they are generated entirely on the basis of the MUD name - in a reproducible (though Qt do NOT guarantee repeatable qHash() functionality across Qt versions - so they may not stay *that* constant) manner. Refrob: use a table of fixed colours Using only 15 hues but with 3 different saturation level plus 5 grey-scale one should give enough different icons but not generate them too close to each other for those with normal colour vision... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Kebap <kebap_spam@gmx.net>
2020-12-11 17:53:28 +00:00
notificationAreaIconLabelWarning->setPixmap(holdPixmap);
Fix new profiles to be saved correctly when created (#2677)
2019-06-29 12:06:56 +02:00
Revise: select profiles by typing the name, keep profile icons (#4440) Restore the text display of the profile name. This is so that the keyboard selection of profiles beginning with a particular letter works again. This will close issue #4283 . This also sets it to the minimum size trying to hide it by setting the font size to 1 - however that still show something (and a font size of zero is NOT valid). Manipulating the QPalette of the QListWidget does not work well enough in the presence of Styles or StyleSheets to be a viable means of hiding the text either. Also in the `dlgConnection` class: * refactor out some highly repetitive code that sets up the predefined Mud icons. * remove warnings and adopts a change introduced into Qt 5.15 for the QLabel::pixmap() which now requires a Qt::ReturnByValue argument to prevent an obsolete code warning and to force a QPixmap to be returned by value and not reference... * remove a warning about: QListWidget::setItemSelected(QListWidgetItem*,bool) being deprecated and switches to the recommended: QListWidgetItem::setSelected(bool) Edit: the last item above may have become redundant as further commits amalgamated into this PR may have taken out these lines anyhow! Change the custom icon generator so that there is NOT a dependency on the position in the list for the colours used. This means that the same name will always have the same colours - which will help the user to pick out a particular profile as it will always look the same no matter if other profiles are added or removed. Remove the colour gradient in the custom icon as it is not thought to be useful nowadays. Refactor out the colour icon generator to a single method that is called from more than one place. BugFix: restore odd original way of accessing some QPixmaps This was causing failures in some CI platforms using Qt 5.14. or older. Revise: really frob the custom icon generator This is to try and produce as varied but still readable icons when they are generated entirely on the basis of the MUD name - in a reproducible (though Qt do NOT guarantee repeatable qHash() functionality across Qt versions - so they may not stay *that* constant) manner. Refrob: use a table of fixed colours Using only 15 hues but with 3 different saturation level plus 5 grey-scale one should give enough different icons but not generate them too close to each other for those with normal colour vision... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Kebap <kebap_spam@gmx.net>
2020-12-11 17:53:28 +00:00
holdPixmap = notificationAreaIconLabelError->pixmap(Qt::ReturnByValue);
Game selection dialog icon size (#2231) * Adding Automatic Qt Scaling for HiDPI for Unix systems * Change to drawForeground in TTextEdit to better account for font painting with different screen resolutions in QPixmap * Fix for scrollback buffer * Updated png to 256x256 (from 48x48) * Found the flag to enable hidpi icons * The ui files are setting absolute pixel sizes for the system message area, so we need to scale these pixmaps to account for higher dpi icons 48 -> 256 = 5.3 ratio. Iconsets automatically scale. * Fix giant notification image on connection profiles
2019-01-29 03:27:37 -05:00
holdPixmap.setDevicePixelRatio(5.3);
Revise: select profiles by typing the name, keep profile icons (#4440) Restore the text display of the profile name. This is so that the keyboard selection of profiles beginning with a particular letter works again. This will close issue #4283 . This also sets it to the minimum size trying to hide it by setting the font size to 1 - however that still show something (and a font size of zero is NOT valid). Manipulating the QPalette of the QListWidget does not work well enough in the presence of Styles or StyleSheets to be a viable means of hiding the text either. Also in the `dlgConnection` class: * refactor out some highly repetitive code that sets up the predefined Mud icons. * remove warnings and adopts a change introduced into Qt 5.15 for the QLabel::pixmap() which now requires a Qt::ReturnByValue argument to prevent an obsolete code warning and to force a QPixmap to be returned by value and not reference... * remove a warning about: QListWidget::setItemSelected(QListWidgetItem*,bool) being deprecated and switches to the recommended: QListWidgetItem::setSelected(bool) Edit: the last item above may have become redundant as further commits amalgamated into this PR may have taken out these lines anyhow! Change the custom icon generator so that there is NOT a dependency on the position in the list for the colours used. This means that the same name will always have the same colours - which will help the user to pick out a particular profile as it will always look the same no matter if other profiles are added or removed. Remove the colour gradient in the custom icon as it is not thought to be useful nowadays. Refactor out the colour icon generator to a single method that is called from more than one place. BugFix: restore odd original way of accessing some QPixmaps This was causing failures in some CI platforms using Qt 5.14. or older. Revise: really frob the custom icon generator This is to try and produce as varied but still readable icons when they are generated entirely on the basis of the MUD name - in a reproducible (though Qt do NOT guarantee repeatable qHash() functionality across Qt versions - so they may not stay *that* constant) manner. Refrob: use a table of fixed colours Using only 15 hues but with 3 different saturation level plus 5 grey-scale one should give enough different icons but not generate them too close to each other for those with normal colour vision... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Kebap <kebap_spam@gmx.net>
2020-12-11 17:53:28 +00:00
notificationAreaIconLabelError->setPixmap(holdPixmap);
Fix new profiles to be saved correctly when created (#2677)
2019-06-29 12:06:56 +02:00
Revise: select profiles by typing the name, keep profile icons (#4440) Restore the text display of the profile name. This is so that the keyboard selection of profiles beginning with a particular letter works again. This will close issue #4283 . This also sets it to the minimum size trying to hide it by setting the font size to 1 - however that still show something (and a font size of zero is NOT valid). Manipulating the QPalette of the QListWidget does not work well enough in the presence of Styles or StyleSheets to be a viable means of hiding the text either. Also in the `dlgConnection` class: * refactor out some highly repetitive code that sets up the predefined Mud icons. * remove warnings and adopts a change introduced into Qt 5.15 for the QLabel::pixmap() which now requires a Qt::ReturnByValue argument to prevent an obsolete code warning and to force a QPixmap to be returned by value and not reference... * remove a warning about: QListWidget::setItemSelected(QListWidgetItem*,bool) being deprecated and switches to the recommended: QListWidgetItem::setSelected(bool) Edit: the last item above may have become redundant as further commits amalgamated into this PR may have taken out these lines anyhow! Change the custom icon generator so that there is NOT a dependency on the position in the list for the colours used. This means that the same name will always have the same colours - which will help the user to pick out a particular profile as it will always look the same no matter if other profiles are added or removed. Remove the colour gradient in the custom icon as it is not thought to be useful nowadays. Refactor out the colour icon generator to a single method that is called from more than one place. BugFix: restore odd original way of accessing some QPixmaps This was causing failures in some CI platforms using Qt 5.14. or older. Revise: really frob the custom icon generator This is to try and produce as varied but still readable icons when they are generated entirely on the basis of the MUD name - in a reproducible (though Qt do NOT guarantee repeatable qHash() functionality across Qt versions - so they may not stay *that* constant) manner. Refrob: use a table of fixed colours Using only 15 hues but with 3 different saturation level plus 5 grey-scale one should give enough different icons but not generate them too close to each other for those with normal colour vision... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Kebap <kebap_spam@gmx.net>
2020-12-11 17:53:28 +00:00
holdPixmap = notificationAreaIconLabelInformation->pixmap(Qt::ReturnByValue);
Game selection dialog icon size (#2231) * Adding Automatic Qt Scaling for HiDPI for Unix systems * Change to drawForeground in TTextEdit to better account for font painting with different screen resolutions in QPixmap * Fix for scrollback buffer * Updated png to 256x256 (from 48x48) * Found the flag to enable hidpi icons * The ui files are setting absolute pixel sizes for the system message area, so we need to scale these pixmaps to account for higher dpi icons 48 -> 256 = 5.3 ratio. Iconsets automatically scale. * Fix giant notification image on connection profiles
2019-01-29 03:27:37 -05:00
holdPixmap.setDevicePixelRatio(5.3);
Revise: select profiles by typing the name, keep profile icons (#4440) Restore the text display of the profile name. This is so that the keyboard selection of profiles beginning with a particular letter works again. This will close issue #4283 . This also sets it to the minimum size trying to hide it by setting the font size to 1 - however that still show something (and a font size of zero is NOT valid). Manipulating the QPalette of the QListWidget does not work well enough in the presence of Styles or StyleSheets to be a viable means of hiding the text either. Also in the `dlgConnection` class: * refactor out some highly repetitive code that sets up the predefined Mud icons. * remove warnings and adopts a change introduced into Qt 5.15 for the QLabel::pixmap() which now requires a Qt::ReturnByValue argument to prevent an obsolete code warning and to force a QPixmap to be returned by value and not reference... * remove a warning about: QListWidget::setItemSelected(QListWidgetItem*,bool) being deprecated and switches to the recommended: QListWidgetItem::setSelected(bool) Edit: the last item above may have become redundant as further commits amalgamated into this PR may have taken out these lines anyhow! Change the custom icon generator so that there is NOT a dependency on the position in the list for the colours used. This means that the same name will always have the same colours - which will help the user to pick out a particular profile as it will always look the same no matter if other profiles are added or removed. Remove the colour gradient in the custom icon as it is not thought to be useful nowadays. Refactor out the colour icon generator to a single method that is called from more than one place. BugFix: restore odd original way of accessing some QPixmaps This was causing failures in some CI platforms using Qt 5.14. or older. Revise: really frob the custom icon generator This is to try and produce as varied but still readable icons when they are generated entirely on the basis of the MUD name - in a reproducible (though Qt do NOT guarantee repeatable qHash() functionality across Qt versions - so they may not stay *that* constant) manner. Refrob: use a table of fixed colours Using only 15 hues but with 3 different saturation level plus 5 grey-scale one should give enough different icons but not generate them too close to each other for those with normal colour vision... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Kebap <kebap_spam@gmx.net>
2020-12-11 17:53:28 +00:00
notificationAreaIconLabelInformation->setPixmap(holdPixmap);
misc
2010-03-15 09:37:16 +01:00
Feature: finished all features in connectionDialog + autologon
2009-01-28 02:35:22 +01:00
// selection mode is important. if this is not set the selection behaviour is
// undefined. this is an undocumented qt bug, as it only shows on certain OS
// and certain architectures.
misc
2010-03-15 09:37:16 +01:00
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
listWidget_profiles->setSelectionMode(QAbstractItemView::SingleSelection);
listWidget_profiles->setContextMenuPolicy(Qt::CustomContextMenu);
connect(listWidget_profiles, &QWidget::customContextMenuRequested, this, &dlgConnectionProfiles::slot_profileContextMenu);
misc
2010-03-15 09:37:16 +01:00
improve: split the games list into My games and All games tabs (#9452) #### Brief overview of PR changes/additions - Tab bar above the connection dialog's games list: "My games" (profiles on disk) and "All games" (full catalog), replacing the right-click "Show my profiles only" stop-gap - Opens on My games when profiles exist, All games on a fresh install; last-used tab and the retired filter's setting are honoured; selection preserved across tab switches - Dedicated single-game builds hide the tab bar and keep their current look #### Motivation for adding to Mudlet One flat grid of ~35 games overwhelmed newcomers and buried the profiles a player actually uses. #### Other info (issues closed, discussion etc) Closes #9140 **Test case:** Fresh install → dialog opens on All games with the tab bar visible. Create a profile, restart → opens on My games showing only that profile, selected with details filled. Switch tabs → selection follows where possible; right-click menu no longer offers "Show my profiles only". https://github.com/user-attachments/assets/50b07d6e-7908-4d25-8b4c-4c6e1396aaea --------- Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-29 17:14:14 +02:00
mpTabBar = new QTabBar(this);
Fix three crashes in the game selection screen (#9702) #### Brief overview of PR changes/additions - **Right-clicking the games list with nothing selected killed Mudlet.** `dlgConnectionProfiles::slot_profileContextMenu()` dereferenced `currentItem()` unguarded. That line is byte-identical in 4.22.0, so the null deref itself is long-standing and latent - what is new is that it became reachable: "improve: split the games list into My games and All games tabs" (#9452) leaves a user with no saved profiles an empty but still right-clickable "My games" tab, a state 4.22.0's always-populated list never had. About 40 seconds into a fresh install. - **Copying a profile while the list was rebuilt was a use-after-free.** The copy runs on a thread pool and its completion handler kept the `QListWidgetItem*` it had made; clicking the other games tab meanwhile calls `fillout_form()`, which destroys every item. The handler now finds the copy by name, and the `QFutureWatcher` is parented so it cannot outlive the dialog. - **Quitting before the connection dialog had been shown dereferenced null.** The queued `0ms` lambda in `mudlet::slot_showConnectionDialog()` used `mpConnectionDialog`, which `mudlet::closeEvent()` closes (it is `WA_DeleteOnClose`) and clears. #### Motivation for adding to Mudlet All three came out of the 5.0 QA sweep and are confirmed with AddressSanitizer. The first is the serious one - it is the default state of a brand-new install, so a new user can lose Mudlet before they have connected to anything. Scope note on the third: it is **not** a 5.0 regression. It has been there since "Fix: Improve tab indicators and detached window UX" (#7965) and is unchanged in 4.22.0; #9493 only turned the literal `0` into `0ms`. Nor could I reach it by clicking: I drove *Games -> Close profile* followed by quitting at six delays from 0 to 2000 ms and the dialog was always painted first. It reproduces deterministically in-process, and QA reproduced it 2/2 driving the close from Lua. Worth guarding - the pointer is documented to go null - but latent rather than routinely hit. #### Other info (issues closed, discussion etc) Test case: `ctest -R ConnectionDialogCrashTest` - with the fix reverted, four of its tests reproduce the original ASan reports exactly (two SEGVs in `slot_profileContextMenu`, a heap-use-after-free in `slot_itemClicked`, the SEGV in `QWidget::show()` from the lambda); two more are controls that pass either way, one of them pinning that the menu still opens for a selected profile so the guard cannot degenerate into an unconditional early return. Full suite 79/79. Assisted-by: Claude:claude-opus-5
2026-08-07 10:14:30 +02:00
// QTabWidget gives this dialog a second QTabBar, so this one needs a name
mpTabBar->setObjectName(qsl("gamesTabBar"));
improve: split the games list into My games and All games tabs (#9452) #### Brief overview of PR changes/additions - Tab bar above the connection dialog's games list: "My games" (profiles on disk) and "All games" (full catalog), replacing the right-click "Show my profiles only" stop-gap - Opens on My games when profiles exist, All games on a fresh install; last-used tab and the retired filter's setting are honoured; selection preserved across tab switches - Dedicated single-game builds hide the tab bar and keep their current look #### Motivation for adding to Mudlet One flat grid of ~35 games overwhelmed newcomers and buried the profiles a player actually uses. #### Other info (issues closed, discussion etc) Closes #9140 **Test case:** Fresh install → dialog opens on All games with the tab bar visible. Create a profile, restart → opens on My games showing only that profile, selected with details filled. Switch tabs → selection follows where possible; right-click menu no longer offers "Show my profiles only". https://github.com/user-attachments/assets/50b07d6e-7908-4d25-8b4c-4c6e1396aaea --------- Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-29 17:14:14 +02:00
//: Tab showing only the games the user already has profiles for
mpTabBar->insertTab(scmMyGamesTab, tr("My games"));
//: Tab showing every game Mudlet has a built-in profile for
mpTabBar->insertTab(scmAllGamesTab, tr("All games"));
mpTabBar->setExpanding(false);
mpTabBar->setAccessibleName(tr("games shown"));
mpTabBar->setAccessibleDescription(tr("Switch between showing only your own games and all of the games Mudlet knows about."));
verticalLayout_gamesList->insertWidget(0, mpTabBar);
setTabOrder(mpTabBar, listWidget_profiles);
if (!mudlet::self()->mOnlyShownPredefinedProfiles.isEmpty()) {
// dedicated single-game builds only ever show their own game(s), so
// there is nothing to switch between
mpTabBar->hide();
} else {
auto& settings = *mudlet::self()->mpSettings;
int initialTab = scmMyGamesTab;
if (settings.contains(qsl("connectionDialogActiveTab"))) {
initialTab = settings.value(qsl("connectionDialogActiveTab")).toInt() == scmAllGamesTab ? scmAllGamesTab : scmMyGamesTab;
} else if (settings.value(qsl("showOnlyMyProfiles"), false).toBool()) {
// migrate the retired "Show my profiles only" context menu filter,
// which the "My games" tab replaces
initialTab = scmMyGamesTab;
settings.setValue(qsl("connectionDialogActiveTab"), initialTab);
} else if (QDir(mudlet::getMudletPath(enums::profilesPath)).entryList(QDir::Dirs | QDir::NoDotAndDotDot).isEmpty()) {
// a newcomer has no profiles yet, so show them the catalog
initialTab = scmAllGamesTab;
}
// the retired filter's setting is dropped even when it was false, so it
// cannot resurface should connectionDialogActiveTab ever go missing
settings.remove(qsl("showOnlyMyProfiles"));
mpTabBar->setCurrentIndex(initialTab);
}
// connected only after the initial tab is set, so that setting it is not
// mistaken for the user switching tabs
connect(mpTabBar, &QTabBar::currentChanged, this, &dlgConnectionProfiles::slot_activeTabChanged);
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
QAbstractButton* abort = dialog_buttonbox->button(QDialogButtonBox::Cancel);
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
connect_button = dialog_buttonbox->addButton(tr("Connect"), QDialogButtonBox::AcceptRole);
Revise: try and identify profiles and some controls in connection dialog (#3966) Also convert all `setDisabled(state)` to `setEnabled(!state)` in the `dlgConnectionProfiles` class - using a single one instead of a mix of the two is less likely to lead to errors - and it means less effort to search for the places where something is being enabled or disabled. Shorten some overlong variable names. Remove some capitalisations. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2020-08-13 00:57:17 +01:00
connect_button->setAccessibleDescription(btn_connOrLoad_disabled_accessDesc);
Add support for opening a profile offline (#2580) * Added Load button to profile selection dialog. * Changed name of load button to offline. * Added successful load message. * Cleaned up some tooltip messages. * Removed obsolete arg historyVersion.
2019-06-01 14:35:50 -06:00
offline_button = dialog_buttonbox->addButton(tr("Offline"), QDialogButtonBox::AcceptRole);
Revise: try and identify profiles and some controls in connection dialog (#3966) Also convert all `setDisabled(state)` to `setEnabled(!state)` in the `dlgConnectionProfiles` class - using a single one instead of a mix of the two is less likely to lead to errors - and it means less effort to search for the places where something is being enabled or disabled. Shorten some overlong variable names. Remove some capitalisations. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2020-08-13 00:57:17 +01:00
offline_button->setAccessibleDescription(btn_connOrLoad_disabled_accessDesc);
Enhance: make Mudlet respect icons on dialog buttons system setting (#1757) At least on X11 based OSes it is possible for the Window Manager to change the styling/images used for icons on native dialog boxes - or even hide them. This hides/shows the icons on dialogues (currently only the "connection preferences") so that they match the system settings that the Qt generated dialogues already respect. There is not a QApplication::getSetting(option) means to do this - instead we have to see whether the buttons on a Qt generated dialogue using a predefined button role has an icon and use it's presence as an indication. This commit also overcomes the problem that the icons would previously have shown as the "baked-in" icons in the "Welcome message" even if they were not present on the buttons themselves. In the future it will be desirable to also use QIcon::fromTheme(...) to furnish the icons for other dialogues and also respect user/system settings for showing/hiding icons on dialogue buttons where we add buttons ourselves to such QDialogButtonBox - from past investigations this is particularly going to apply to the Pack Manager; Module Manager and Package Exporter dialogue as they current have an irregular set of buttons that I plan to "tidy-up" by moving more of them into the button-box on their dialogues. Also: * delete now unused icon: * /src/icons/list-add_small.png * replace with a "better" icon on the Connect Profile dialog (but used elsewhere also and left unchanged there): * /src/icons/edit-delete-shred.png ==> /src/icons/edit-delete.png copy profile button: * /src/icons/list-add_small.png ==> /src/icons/edit-copy.png new profile button: * /src/icons/list-add_small.png ==> /src/icons/document-new.png Removed: * empty #if defined(INCLUDE_UPDATER) code block from mudlet.cpp Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2018-06-11 15:08:35 +00:00
add: Show tutorial invitation on first launch (#9169) #### Brief overview of PR changes/additions - On first launch (no existing profiles), show a focused tutorial invitation instead of the full games list - "Start Tutorial" link launches the Mudlet Tutorial profile directly - "Skip - show me the games list" button reveals the full connection dialog with the tutorial profile preselected - Make the Connect button the dialog's explicit default so Enter in the connection form always means "Connect" (see below) #### Motivation for adding to Mudlet New users currently face a wall of 20+ unknown game names with no guidance - a focused tutorial invitation improves first-time retention by teaching basics before choosing a game. #### Other info (issues closed, discussion etc) https://github.com/user-attachments/assets/2eeb3cb9-f596-4744-b187-24e1fc785246 --- Squash-merge trailers: ``` Assisted-by: Claude:claude-fable-5 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org> ``` --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com> Co-authored-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-18 10:54:52 +02:00
//: Button shown on first launch to skip the tutorial and show the full games list
mpSkipToGamesButton = new QPushButton(tr("Skip - show me the games list"), this);
mpSkipToGamesButton->setObjectName(qsl("skipToGamesButton"));
mpSkipToGamesButton->hide();
horizontalLayout_3->insertWidget(0, mpSkipToGamesButton);
connect(mpSkipToGamesButton, &QPushButton::clicked, this, &dlgConnectionProfiles::slot_skipToGamesList);
// Pressing Enter in the connection form must always mean "Connect". The
// tutorial invitation hides the Connect button on first show, which stops
// Qt's automatic default-button tracking from ever settling on it - Enter
// would then activate the first autoDefault button in the dialog, which
// happens to be Remove, silently deleting the profile being created:
remove_profile_button->setAutoDefault(false);
new_profile_button->setAutoDefault(false);
mpSkipToGamesButton->setAutoDefault(false);
connect_button->setDefault(true);
Enhance: make Mudlet respect icons on dialog buttons system setting (#1757) At least on X11 based OSes it is possible for the Window Manager to change the styling/images used for icons on native dialog boxes - or even hide them. This hides/shows the icons on dialogues (currently only the "connection preferences") so that they match the system settings that the Qt generated dialogues already respect. There is not a QApplication::getSetting(option) means to do this - instead we have to see whether the buttons on a Qt generated dialogue using a predefined button role has an icon and use it's presence as an indication. This commit also overcomes the problem that the icons would previously have shown as the "baked-in" icons in the "Welcome message" even if they were not present on the buttons themselves. In the future it will be desirable to also use QIcon::fromTheme(...) to furnish the icons for other dialogues and also respect user/system settings for showing/hiding icons on dialogue buttons where we add buttons ourselves to such QDialogButtonBox - from past investigations this is particularly going to apply to the Pack Manager; Module Manager and Package Exporter dialogue as they current have an irregular set of buttons that I plan to "tidy-up" by moving more of them into the button-box on their dialogues. Also: * delete now unused icon: * /src/icons/list-add_small.png * replace with a "better" icon on the Connect Profile dialog (but used elsewhere also and left unchanged there): * /src/icons/edit-delete-shred.png ==> /src/icons/edit-delete.png copy profile button: * /src/icons/list-add_small.png ==> /src/icons/edit-copy.png new profile button: * /src/icons/list-add_small.png ==> /src/icons/document-new.png Removed: * empty #if defined(INCLUDE_UPDATER) code block from mudlet.cpp Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2018-06-11 15:08:35 +00:00
// Test and set if needed mudlet::mIsIconShownOnDialogButtonBoxes - if there
// is already a Qt provided icon on a predefined button, this is probably
// the first and best place to test this as the "Cancel" button is a built-
// in dialog button which will have an icon if the current system style
// settings suggest it:
mudlet::self()->mShowIconsOnDialogs = !abort->icon().isNull();
add: Show tutorial invitation on first launch (#9169) #### Brief overview of PR changes/additions - On first launch (no existing profiles), show a focused tutorial invitation instead of the full games list - "Start Tutorial" link launches the Mudlet Tutorial profile directly - "Skip - show me the games list" button reveals the full connection dialog with the tutorial profile preselected - Make the Connect button the dialog's explicit default so Enter in the connection form always means "Connect" (see below) #### Motivation for adding to Mudlet New users currently face a wall of 20+ unknown game names with no guidance - a focused tutorial invitation improves first-time retention by teaching basics before choosing a game. #### Other info (issues closed, discussion etc) https://github.com/user-attachments/assets/2eeb3cb9-f596-4744-b187-24e1fc785246 --- Squash-merge trailers: ``` Assisted-by: Claude:claude-fable-5 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org> ``` --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com> Co-authored-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-18 10:54:52 +02:00
//: Welcome message shown on first launch, focused on starting the tutorial.
auto Welcome_text_template = tr("<p><center><img src=\"tutorialIcon\"/></center></p>"
"<p><center><big><b>Welcome to Mudlet!</b></big></center></p>"
"<p><center>Play a short guided adventure to learn<br>"
"how to navigate in games, use triggers, aliases, and scripting.</center></p>"
"<p><center><a href=\"mudlet-tutorial\">Start Tutorial</a></center></p>"
"<p align=\"right\"><span style=\" font-family:'Sans';\">The Mudlet Team </span>"
"<img src=\":/icons/mudlet_main_16px.png\"/></p>");
Unify almost duplicate welcome messages (#1952) #### Brief overview of PR changes/additions There were two seperate versions of the welcome message. Now there is only a combined one. The only difference was a pair of icons, which are now added dynamically. #### Motivation for adding to Mudlet Reduce translation effort. Before, translators needed to translate a mostly identical text twice. Now only once is necessary. #### Other info (issues closed, discussion etc)
2018-09-07 15:21:48 +02:00
Enhance: make Mudlet respect icons on dialog buttons system setting (#1757) At least on X11 based OSes it is possible for the Window Manager to change the styling/images used for icons on native dialog boxes - or even hide them. This hides/shows the icons on dialogues (currently only the "connection preferences") so that they match the system settings that the Qt generated dialogues already respect. There is not a QApplication::getSetting(option) means to do this - instead we have to see whether the buttons on a Qt generated dialogue using a predefined button role has an icon and use it's presence as an indication. This commit also overcomes the problem that the icons would previously have shown as the "baked-in" icons in the "Welcome message" even if they were not present on the buttons themselves. In the future it will be desirable to also use QIcon::fromTheme(...) to furnish the icons for other dialogues and also respect user/system settings for showing/hiding icons on dialogue buttons where we add buttons ourselves to such QDialogButtonBox - from past investigations this is particularly going to apply to the Pack Manager; Module Manager and Package Exporter dialogue as they current have an irregular set of buttons that I plan to "tidy-up" by moving more of them into the button-box on their dialogues. Also: * delete now unused icon: * /src/icons/list-add_small.png * replace with a "better" icon on the Connect Profile dialog (but used elsewhere also and left unchanged there): * /src/icons/edit-delete-shred.png ==> /src/icons/edit-delete.png copy profile button: * /src/icons/list-add_small.png ==> /src/icons/edit-copy.png new profile button: * /src/icons/list-add_small.png ==> /src/icons/document-new.png Removed: * empty #if defined(INCLUDE_UPDATER) code block from mudlet.cpp Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2018-06-11 15:08:35 +00:00
auto pWelcome_document = new QTextDocument(this);
add: Show tutorial invitation on first launch (#9169) #### Brief overview of PR changes/additions - On first launch (no existing profiles), show a focused tutorial invitation instead of the full games list - "Start Tutorial" link launches the Mudlet Tutorial profile directly - "Skip - show me the games list" button reveals the full connection dialog with the tutorial profile preselected - Make the Connect button the dialog's explicit default so Enter in the connection form always means "Connect" (see below) #### Motivation for adding to Mudlet New users currently face a wall of 20+ unknown game names with no guidance - a focused tutorial invitation improves first-time retention by teaching basics before choosing a game. #### Other info (issues closed, discussion etc) https://github.com/user-attachments/assets/2eeb3cb9-f596-4744-b187-24e1fc785246 --- Squash-merge trailers: ``` Assisted-by: Claude:claude-fable-5 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org> ``` --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com> Co-authored-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-18 10:54:52 +02:00
QPixmap tutorialIcon(qsl(":/icons/mudlet-tutorial.png"));
tutorialIcon = tutorialIcon.scaled(160, 40, Qt::KeepAspectRatio, Qt::SmoothTransformation);
pWelcome_document->addResource(QTextDocument::ImageResource, QUrl(qsl("tutorialIcon")), tutorialIcon);
Add 'Copy profile (settings only)' button (#2779) * Added button and got connection info copied * Add copy profile with settings only * Tweak UI style * Cleanup * Remove duplicates * Remove another debug cout * Fix names getting duplicated * Remove debug statement * Fix unnecessary return
2019-07-17 07:33:47 +02:00
Improve: don't freeze Mudlet when copying large profile (#5056)
2022-04-18 20:37:10 +02:00
mpCopyProfile = new QAction(tr("Copy"), this);
mpCopyProfile->setObjectName(qsl("copyProfile"));
Add 'Copy profile (settings only)' button (#2779) * Added button and got connection info copied * Add copy profile with settings only * Tweak UI style * Cleanup * Remove duplicates * Remove another debug cout * Fix names getting duplicated * Remove debug statement * Fix unnecessary return
2019-07-17 07:33:47 +02:00
auto copyProfileSettings = new QAction(tr("Copy settings only"), this);
Infrastructure: Add short qsl macro to stand in for 'QStringLiteral' (#5640)
2021-12-07 06:21:39 +01:00
copyProfileSettings->setObjectName(qsl("copyProfileSettingsOnly"));
Add 'Copy profile (settings only)' button (#2779) * Added button and got connection info copied * Add copy profile with settings only * Tweak UI style * Cleanup * Remove duplicates * Remove another debug cout * Fix names getting duplicated * Remove debug statement * Fix unnecessary return
2019-07-17 07:33:47 +02:00
Improve: don't freeze Mudlet when copying large profile (#5056)
2022-04-18 20:37:10 +02:00
copy_profile_toolbutton->addAction(mpCopyProfile);
Add 'Copy profile (settings only)' button (#2779) * Added button and got connection info copied * Add copy profile with settings only * Tweak UI style * Cleanup * Remove duplicates * Remove another debug cout * Fix names getting duplicated * Remove debug statement * Fix unnecessary return
2019-07-17 07:33:47 +02:00
copy_profile_toolbutton->addAction(copyProfileSettings);
Improve: don't freeze Mudlet when copying large profile (#5056)
2022-04-18 20:37:10 +02:00
copy_profile_toolbutton->setDefaultAction(mpCopyProfile);
improve: remove qt5 checks (#7736) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Attempt to remove all obsolete qt5 checks. #### Motivation for adding to Mudlet Migrate to qt6. #### Other info (issues closed, discussion etc) --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-02-24 09:59:51 +04:00
Infrastructure: Support both Qt5 & Qt6 in CMake and qmake builds (#6654) #### Brief overview of PR changes/additions - Port code to work in both Qt5 & Qt6. - Notable exception: playing media for Qt6 (see discussion in https://github.com/Mudlet/Mudlet/issues/5623#issuecomment-1455052433) - Add support for Qt6 in CMake files - Add support for Qt6 in qmake file #### Motivation for adding to Mudlet See https://github.com/Mudlet/Mudlet/issues/5623 #### Other info (issues closed, discussion etc) Closes https://github.com/Mudlet/Mudlet/issues/5623. ##### Suggested follow-up work - Add support for Qt6 to Windows build - Add Qt6 targets to CI - Implement playing media for Qt6 (see discussion in https://github.com/Mudlet/Mudlet/issues/5623#issuecomment-1455052433) - Reimplement gamepad support using a different library as the Qt gamepad module was [removed ](https://wiki.qt.io/Qt_6.0.0_Modules)in Qt6 --------- Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2023-03-20 07:18:24 +01:00
auto objectList = mpCopyProfile->associatedObjects();
QList<QWidget*> widgetList;
Fix: Clazy warnings part 1 - range-loop-detach (#9195) #### Brief overview of PR changes/additions One of a series of PRs, each addressing a type of issue reported by Clazy. This is the: "C+11 range-loop might detach Qt container [clazy-range-loop-detach]" one. #### Motivation for adding to Mudlet Remove warnings detected by the Clazy tool - either when explicitly run on the Mudlet code-base or detected by the background scanner/analyser that Qt Creator offers. #### Other info (issues closed, discussion etc) There was over 100 of this particular item - some of them also could have `const` applied to the iterator. --------- Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
2026-04-16 14:30:33 +01:00
for (const auto pObjectItem : std::as_const(objectList)) {
Infrastructure: Support both Qt5 & Qt6 in CMake and qmake builds (#6654) #### Brief overview of PR changes/additions - Port code to work in both Qt5 & Qt6. - Notable exception: playing media for Qt6 (see discussion in https://github.com/Mudlet/Mudlet/issues/5623#issuecomment-1455052433) - Add support for Qt6 in CMake files - Add support for Qt6 in qmake file #### Motivation for adding to Mudlet See https://github.com/Mudlet/Mudlet/issues/5623 #### Other info (issues closed, discussion etc) Closes https://github.com/Mudlet/Mudlet/issues/5623. ##### Suggested follow-up work - Add support for Qt6 to Windows build - Add Qt6 targets to CI - Implement playing media for Qt6 (see discussion in https://github.com/Mudlet/Mudlet/issues/5623#issuecomment-1455052433) - Reimplement gamepad support using a different library as the Qt gamepad module was [removed ](https://wiki.qt.io/Qt_6.0.0_Modules)in Qt6 --------- Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2023-03-20 07:18:24 +01:00
auto pWidgetItem = qobject_cast<QWidget*>(pObjectItem);
if (pWidgetItem) {
widgetList << pWidgetItem;
}
}
improve: remove qt5 checks (#7736) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Attempt to remove all obsolete qt5 checks. #### Motivation for adding to Mudlet Migrate to qt6. #### Other info (issues closed, discussion etc) --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-02-24 09:59:51 +04:00
Infrastructure: use isEmpty() instead of size() or count() being zero (#6333) This better reflects the intention of such checks. A couple of the changes originated in #6330 but they were not germane to the issue being addressed there, so factored out to a separate PR which I extended to cover all (a lot more) cases . Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-10-02 09:43:20 +01:00
Q_ASSERT_X(!widgetList.isEmpty(), "dlgConnectionProfiles::dlgConnectionProfiles(...)", "A QWidget for mpCopyProfile QAction not found.");
Revise: try and identify profiles and some controls in connection dialog (#3966) Also convert all `setDisabled(state)` to `setEnabled(!state)` in the `dlgConnectionProfiles` class - using a single one instead of a mix of the two is less likely to lead to errors - and it means less effort to search for the places where something is being enabled or disabled. Shorten some overlong variable names. Remove some capitalisations. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2020-08-13 00:57:17 +01:00
widgetList.first()->setAccessibleName(tr("copy profile"));
widgetList.first()->setAccessibleDescription(tr("copy the entire profile to new one that will require a different new name."));
Infrastructure: Support both Qt5 & Qt6 in CMake and qmake builds (#6654) #### Brief overview of PR changes/additions - Port code to work in both Qt5 & Qt6. - Notable exception: playing media for Qt6 (see discussion in https://github.com/Mudlet/Mudlet/issues/5623#issuecomment-1455052433) - Add support for Qt6 in CMake files - Add support for Qt6 in qmake file #### Motivation for adding to Mudlet See https://github.com/Mudlet/Mudlet/issues/5623 #### Other info (issues closed, discussion etc) Closes https://github.com/Mudlet/Mudlet/issues/5623. ##### Suggested follow-up work - Add support for Qt6 to Windows build - Add Qt6 targets to CI - Implement playing media for Qt6 (see discussion in https://github.com/Mudlet/Mudlet/issues/5623#issuecomment-1455052433) - Reimplement gamepad support using a different library as the Qt gamepad module was [removed ](https://wiki.qt.io/Qt_6.0.0_Modules)in Qt6 --------- Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2023-03-20 07:18:24 +01:00
objectList = copyProfileSettings->associatedObjects();
widgetList.clear();
Fix: Clazy warnings part 1 - range-loop-detach (#9195) #### Brief overview of PR changes/additions One of a series of PRs, each addressing a type of issue reported by Clazy. This is the: "C+11 range-loop might detach Qt container [clazy-range-loop-detach]" one. #### Motivation for adding to Mudlet Remove warnings detected by the Clazy tool - either when explicitly run on the Mudlet code-base or detected by the background scanner/analyser that Qt Creator offers. #### Other info (issues closed, discussion etc) There was over 100 of this particular item - some of them also could have `const` applied to the iterator. --------- Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
2026-04-16 14:30:33 +01:00
for (const auto pObjectItem : std::as_const(objectList)) {
Infrastructure: Support both Qt5 & Qt6 in CMake and qmake builds (#6654) #### Brief overview of PR changes/additions - Port code to work in both Qt5 & Qt6. - Notable exception: playing media for Qt6 (see discussion in https://github.com/Mudlet/Mudlet/issues/5623#issuecomment-1455052433) - Add support for Qt6 in CMake files - Add support for Qt6 in qmake file #### Motivation for adding to Mudlet See https://github.com/Mudlet/Mudlet/issues/5623 #### Other info (issues closed, discussion etc) Closes https://github.com/Mudlet/Mudlet/issues/5623. ##### Suggested follow-up work - Add support for Qt6 to Windows build - Add Qt6 targets to CI - Implement playing media for Qt6 (see discussion in https://github.com/Mudlet/Mudlet/issues/5623#issuecomment-1455052433) - Reimplement gamepad support using a different library as the Qt gamepad module was [removed ](https://wiki.qt.io/Qt_6.0.0_Modules)in Qt6 --------- Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2023-03-20 07:18:24 +01:00
auto pWidgetItem = qobject_cast<QWidget*>(pObjectItem);
if (pWidgetItem) {
widgetList << pWidgetItem;
}
}
improve: remove qt5 checks (#7736) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Attempt to remove all obsolete qt5 checks. #### Motivation for adding to Mudlet Migrate to qt6. #### Other info (issues closed, discussion etc) --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-02-24 09:59:51 +04:00
Infrastructure: use isEmpty() instead of size() or count() being zero (#6333) This better reflects the intention of such checks. A couple of the changes originated in #6330 but they were not germane to the issue being addressed there, so factored out to a separate PR which I extended to cover all (a lot more) cases . Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-10-02 09:43:20 +01:00
Q_ASSERT_X(!widgetList.isEmpty(), "dlgConnectionProfiles::dlgConnectionProfiles(...)", "A QWidget for copyProfileSettings QAction not found.");
Revise: try and identify profiles and some controls in connection dialog (#3966) Also convert all `setDisabled(state)` to `setEnabled(!state)` in the `dlgConnectionProfiles` class - using a single one instead of a mix of the two is less likely to lead to errors - and it means less effort to search for the places where something is being enabled or disabled. Shorten some overlong variable names. Remove some capitalisations. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2020-08-13 00:57:17 +01:00
widgetList.first()->setAccessibleName(tr("copy profile settings"));
widgetList.first()->setAccessibleDescription(tr("copy the settings and some other parts of the profile to a new one that will require a different new name."));
Add 'Copy profile (settings only)' button (#2779) * Added button and got connection info copied * Add copy profile with settings only * Tweak UI style * Cleanup * Remove duplicates * Remove another debug cout * Fix names getting duplicated * Remove debug statement * Fix unnecessary return
2019-07-17 07:33:47 +02:00
Enhance: make Mudlet respect icons on dialog buttons system setting (#1757) At least on X11 based OSes it is possible for the Window Manager to change the styling/images used for icons on native dialog boxes - or even hide them. This hides/shows the icons on dialogues (currently only the "connection preferences") so that they match the system settings that the Qt generated dialogues already respect. There is not a QApplication::getSetting(option) means to do this - instead we have to see whether the buttons on a Qt generated dialogue using a predefined button role has an icon and use it's presence as an indication. This commit also overcomes the problem that the icons would previously have shown as the "baked-in" icons in the "Welcome message" even if they were not present on the buttons themselves. In the future it will be desirable to also use QIcon::fromTheme(...) to furnish the icons for other dialogues and also respect user/system settings for showing/hiding icons on dialogue buttons where we add buttons ourselves to such QDialogButtonBox - from past investigations this is particularly going to apply to the Pack Manager; Module Manager and Package Exporter dialogue as they current have an irregular set of buttons that I plan to "tidy-up" by moving more of them into the button-box on their dialogues. Also: * delete now unused icon: * /src/icons/list-add_small.png * replace with a "better" icon on the Connect Profile dialog (but used elsewhere also and left unchanged there): * /src/icons/edit-delete-shred.png ==> /src/icons/edit-delete.png copy profile button: * /src/icons/list-add_small.png ==> /src/icons/edit-copy.png new profile button: * /src/icons/list-add_small.png ==> /src/icons/document-new.png Removed: * empty #if defined(INCLUDE_UPDATER) code block from mudlet.cpp Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2018-06-11 15:08:35 +00:00
if (mudlet::self()->mShowIconsOnDialogs) {
// As we are repurposing the cancel to be a close button we do want to
// change it anyhow:
Infrastructure: Add short qsl macro to stand in for 'QStringLiteral' (#5640)
2021-12-07 06:21:39 +01:00
abort->setIcon(QIcon::fromTheme(qsl("dialog-close"), QIcon(qsl(":/icons/dialog-close.png"))));
Enhance: make Mudlet respect icons on dialog buttons system setting (#1757) At least on X11 based OSes it is possible for the Window Manager to change the styling/images used for icons on native dialog boxes - or even hide them. This hides/shows the icons on dialogues (currently only the "connection preferences") so that they match the system settings that the Qt generated dialogues already respect. There is not a QApplication::getSetting(option) means to do this - instead we have to see whether the buttons on a Qt generated dialogue using a predefined button role has an icon and use it's presence as an indication. This commit also overcomes the problem that the icons would previously have shown as the "baked-in" icons in the "Welcome message" even if they were not present on the buttons themselves. In the future it will be desirable to also use QIcon::fromTheme(...) to furnish the icons for other dialogues and also respect user/system settings for showing/hiding icons on dialogue buttons where we add buttons ourselves to such QDialogButtonBox - from past investigations this is particularly going to apply to the Pack Manager; Module Manager and Package Exporter dialogue as they current have an irregular set of buttons that I plan to "tidy-up" by moving more of them into the button-box on their dialogues. Also: * delete now unused icon: * /src/icons/list-add_small.png * replace with a "better" icon on the Connect Profile dialog (but used elsewhere also and left unchanged there): * /src/icons/edit-delete-shred.png ==> /src/icons/edit-delete.png copy profile button: * /src/icons/list-add_small.png ==> /src/icons/edit-copy.png new profile button: * /src/icons/list-add_small.png ==> /src/icons/document-new.png Removed: * empty #if defined(INCLUDE_UPDATER) code block from mudlet.cpp Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2018-06-11 15:08:35 +00:00
Infrastructure: mark read-only variables as const (#6843) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Mark read-only variables as const - that is, not intended to change after they've been declared #### Motivation for adding to Mudlet So we don't change them by accident later on, and also to clearly state intentions for the variables #### Other info (issues closed, discussion etc) This is also recommended by the [C++ Core Guidelines](https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#es25-declare-an-object-const-or-constexpr-unless-you-want-to-modify-its-value-later-on)
2023-05-14 15:06:15 +02:00
const QIcon icon_new(QIcon::fromTheme(qsl("document-new"), QIcon(qsl(":/icons/document-new.png"))));
const QIcon icon_connect(QIcon::fromTheme(qsl("dialog-ok-apply"), QIcon(qsl(":/icons/preferences-web-browser-cache.png"))));
Enhance: make Mudlet respect icons on dialog buttons system setting (#1757) At least on X11 based OSes it is possible for the Window Manager to change the styling/images used for icons on native dialog boxes - or even hide them. This hides/shows the icons on dialogues (currently only the "connection preferences") so that they match the system settings that the Qt generated dialogues already respect. There is not a QApplication::getSetting(option) means to do this - instead we have to see whether the buttons on a Qt generated dialogue using a predefined button role has an icon and use it's presence as an indication. This commit also overcomes the problem that the icons would previously have shown as the "baked-in" icons in the "Welcome message" even if they were not present on the buttons themselves. In the future it will be desirable to also use QIcon::fromTheme(...) to furnish the icons for other dialogues and also respect user/system settings for showing/hiding icons on dialogue buttons where we add buttons ourselves to such QDialogButtonBox - from past investigations this is particularly going to apply to the Pack Manager; Module Manager and Package Exporter dialogue as they current have an irregular set of buttons that I plan to "tidy-up" by moving more of them into the button-box on their dialogues. Also: * delete now unused icon: * /src/icons/list-add_small.png * replace with a "better" icon on the Connect Profile dialog (but used elsewhere also and left unchanged there): * /src/icons/edit-delete-shred.png ==> /src/icons/edit-delete.png copy profile button: * /src/icons/list-add_small.png ==> /src/icons/edit-copy.png new profile button: * /src/icons/list-add_small.png ==> /src/icons/document-new.png Removed: * empty #if defined(INCLUDE_UPDATER) code block from mudlet.cpp Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2018-06-11 15:08:35 +00:00
Infrastructure: Add short qsl macro to stand in for 'QStringLiteral' (#5640)
2021-12-07 06:21:39 +01:00
offline_button->setIcon(QIcon(qsl(":/icons/mudlet_editor.png")));
Fix icon duplication and inconsistency in the welcome dialog (#2595)
2019-06-02 21:43:32 +02:00
connect_button->setIcon(icon_connect);
Enhance: make Mudlet respect icons on dialog buttons system setting (#1757) At least on X11 based OSes it is possible for the Window Manager to change the styling/images used for icons on native dialog boxes - or even hide them. This hides/shows the icons on dialogues (currently only the "connection preferences") so that they match the system settings that the Qt generated dialogues already respect. There is not a QApplication::getSetting(option) means to do this - instead we have to see whether the buttons on a Qt generated dialogue using a predefined button role has an icon and use it's presence as an indication. This commit also overcomes the problem that the icons would previously have shown as the "baked-in" icons in the "Welcome message" even if they were not present on the buttons themselves. In the future it will be desirable to also use QIcon::fromTheme(...) to furnish the icons for other dialogues and also respect user/system settings for showing/hiding icons on dialogue buttons where we add buttons ourselves to such QDialogButtonBox - from past investigations this is particularly going to apply to the Pack Manager; Module Manager and Package Exporter dialogue as they current have an irregular set of buttons that I plan to "tidy-up" by moving more of them into the button-box on their dialogues. Also: * delete now unused icon: * /src/icons/list-add_small.png * replace with a "better" icon on the Connect Profile dialog (but used elsewhere also and left unchanged there): * /src/icons/edit-delete-shred.png ==> /src/icons/edit-delete.png copy profile button: * /src/icons/list-add_small.png ==> /src/icons/edit-copy.png new profile button: * /src/icons/list-add_small.png ==> /src/icons/document-new.png Removed: * empty #if defined(INCLUDE_UPDATER) code block from mudlet.cpp Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2018-06-11 15:08:35 +00:00
new_profile_button->setIcon(icon_new);
Infrastructure: Add short qsl macro to stand in for 'QStringLiteral' (#5640)
2021-12-07 06:21:39 +01:00
remove_profile_button->setIcon(QIcon::fromTheme(qsl("edit-delete"), QIcon(qsl(":/icons/edit-delete.png"))));
Enhance: make Mudlet respect icons on dialog buttons system setting (#1757) At least on X11 based OSes it is possible for the Window Manager to change the styling/images used for icons on native dialog boxes - or even hide them. This hides/shows the icons on dialogues (currently only the "connection preferences") so that they match the system settings that the Qt generated dialogues already respect. There is not a QApplication::getSetting(option) means to do this - instead we have to see whether the buttons on a Qt generated dialogue using a predefined button role has an icon and use it's presence as an indication. This commit also overcomes the problem that the icons would previously have shown as the "baked-in" icons in the "Welcome message" even if they were not present on the buttons themselves. In the future it will be desirable to also use QIcon::fromTheme(...) to furnish the icons for other dialogues and also respect user/system settings for showing/hiding icons on dialogue buttons where we add buttons ourselves to such QDialogButtonBox - from past investigations this is particularly going to apply to the Pack Manager; Module Manager and Package Exporter dialogue as they current have an irregular set of buttons that I plan to "tidy-up" by moving more of them into the button-box on their dialogues. Also: * delete now unused icon: * /src/icons/list-add_small.png * replace with a "better" icon on the Connect Profile dialog (but used elsewhere also and left unchanged there): * /src/icons/edit-delete-shred.png ==> /src/icons/edit-delete.png copy profile button: * /src/icons/list-add_small.png ==> /src/icons/edit-copy.png new profile button: * /src/icons/list-add_small.png ==> /src/icons/document-new.png Removed: * empty #if defined(INCLUDE_UPDATER) code block from mudlet.cpp Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2018-06-11 15:08:35 +00:00
Infrastructure: Add short qsl macro to stand in for 'QStringLiteral' (#5640)
2021-12-07 06:21:39 +01:00
copy_profile_toolbutton->setIcon(QIcon::fromTheme(qsl("edit-copy"), QIcon(qsl(":/icons/edit-copy.png"))));
Add 'Copy profile (settings only)' button (#2779) * Added button and got connection info copied * Add copy profile with settings only * Tweak UI style * Cleanup * Remove duplicates * Remove another debug cout * Fix names getting duplicated * Remove debug statement * Fix unnecessary return
2019-07-17 07:33:47 +02:00
copy_profile_toolbutton->setToolButtonStyle(Qt::ToolButtonTextBesideIcon);
Improve: don't freeze Mudlet when copying large profile (#5056)
2022-04-18 20:37:10 +02:00
mpCopyProfile->setIcon(QIcon::fromTheme(qsl("edit-copy"), QIcon(qsl(":/icons/edit-copy.png"))));
Enhance: make Mudlet respect icons on dialog buttons system setting (#1757) At least on X11 based OSes it is possible for the Window Manager to change the styling/images used for icons on native dialog boxes - or even hide them. This hides/shows the icons on dialogues (currently only the "connection preferences") so that they match the system settings that the Qt generated dialogues already respect. There is not a QApplication::getSetting(option) means to do this - instead we have to see whether the buttons on a Qt generated dialogue using a predefined button role has an icon and use it's presence as an indication. This commit also overcomes the problem that the icons would previously have shown as the "baked-in" icons in the "Welcome message" even if they were not present on the buttons themselves. In the future it will be desirable to also use QIcon::fromTheme(...) to furnish the icons for other dialogues and also respect user/system settings for showing/hiding icons on dialogue buttons where we add buttons ourselves to such QDialogButtonBox - from past investigations this is particularly going to apply to the Pack Manager; Module Manager and Package Exporter dialogue as they current have an irregular set of buttons that I plan to "tidy-up" by moving more of them into the button-box on their dialogues. Also: * delete now unused icon: * /src/icons/list-add_small.png * replace with a "better" icon on the Connect Profile dialog (but used elsewhere also and left unchanged there): * /src/icons/edit-delete-shred.png ==> /src/icons/edit-delete.png copy profile button: * /src/icons/list-add_small.png ==> /src/icons/edit-copy.png new profile button: * /src/icons/list-add_small.png ==> /src/icons/document-new.png Removed: * empty #if defined(INCLUDE_UPDATER) code block from mudlet.cpp Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2018-06-11 15:08:35 +00:00
}
Add 'Copy profile (settings only)' button (#2779) * Added button and got connection info copied * Add copy profile with settings only * Tweak UI style * Cleanup * Remove duplicates * Remove another debug cout * Fix names getting duplicated * Remove debug statement * Fix unnecessary return
2019-07-17 07:33:47 +02:00
add: Show tutorial invitation on first launch (#9169) #### Brief overview of PR changes/additions - On first launch (no existing profiles), show a focused tutorial invitation instead of the full games list - "Start Tutorial" link launches the Mudlet Tutorial profile directly - "Skip - show me the games list" button reveals the full connection dialog with the tutorial profile preselected - Make the Connect button the dialog's explicit default so Enter in the connection form always means "Connect" (see below) #### Motivation for adding to Mudlet New users currently face a wall of 20+ unknown game names with no guidance - a focused tutorial invitation improves first-time retention by teaching basics before choosing a game. #### Other info (issues closed, discussion etc) https://github.com/user-attachments/assets/2eeb3cb9-f596-4744-b187-24e1fc785246 --- Squash-merge trailers: ``` Assisted-by: Claude:claude-fable-5 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org> ``` --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com> Co-authored-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-18 10:54:52 +02:00
pWelcome_document->setHtml(qsl("<html><head/><body>%1</body></html>").arg(Welcome_text_template));
Enhance: make Mudlet respect icons on dialog buttons system setting (#1757) At least on X11 based OSes it is possible for the Window Manager to change the styling/images used for icons on native dialog boxes - or even hide them. This hides/shows the icons on dialogues (currently only the "connection preferences") so that they match the system settings that the Qt generated dialogues already respect. There is not a QApplication::getSetting(option) means to do this - instead we have to see whether the buttons on a Qt generated dialogue using a predefined button role has an icon and use it's presence as an indication. This commit also overcomes the problem that the icons would previously have shown as the "baked-in" icons in the "Welcome message" even if they were not present on the buttons themselves. In the future it will be desirable to also use QIcon::fromTheme(...) to furnish the icons for other dialogues and also respect user/system settings for showing/hiding icons on dialogue buttons where we add buttons ourselves to such QDialogButtonBox - from past investigations this is particularly going to apply to the Pack Manager; Module Manager and Package Exporter dialogue as they current have an irregular set of buttons that I plan to "tidy-up" by moving more of them into the button-box on their dialogues. Also: * delete now unused icon: * /src/icons/list-add_small.png * replace with a "better" icon on the Connect Profile dialog (but used elsewhere also and left unchanged there): * /src/icons/edit-delete-shred.png ==> /src/icons/edit-delete.png copy profile button: * /src/icons/list-add_small.png ==> /src/icons/edit-copy.png new profile button: * /src/icons/list-add_small.png ==> /src/icons/document-new.png Removed: * empty #if defined(INCLUDE_UPDATER) code block from mudlet.cpp Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2018-06-11 15:08:35 +00:00
welcome_message->setDocument(pWelcome_document);
add: Show tutorial invitation on first launch (#9169) #### Brief overview of PR changes/additions - On first launch (no existing profiles), show a focused tutorial invitation instead of the full games list - "Start Tutorial" link launches the Mudlet Tutorial profile directly - "Skip - show me the games list" button reveals the full connection dialog with the tutorial profile preselected - Make the Connect button the dialog's explicit default so Enter in the connection form always means "Connect" (see below) #### Motivation for adding to Mudlet New users currently face a wall of 20+ unknown game names with no guidance - a focused tutorial invitation improves first-time retention by teaching basics before choosing a game. #### Other info (issues closed, discussion etc) https://github.com/user-attachments/assets/2eeb3cb9-f596-4744-b187-24e1fc785246 --- Squash-merge trailers: ``` Assisted-by: Claude:claude-fable-5 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org> ``` --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com> Co-authored-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-18 10:54:52 +02:00
welcome_message->setOpenLinks(false);
welcome_message->setOpenExternalLinks(false);
connect(welcome_message, &QTextBrowser::anchorClicked, this, [this](const QUrl& link) {
if (link.toString() == qsl("mudlet-tutorial")) {
mTutorialDismissed = true;
profile_name_entry->setText(qsl("Mudlet Tutorial"));
host_name_entry->setText(qsl("localhost"));
port_entry->setText(qsl("0"));
validName = true;
validUrl = true;
validPort = true;
loadProfile(true);
}
});
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
Enhance: add option to reveal password temporarily on demand (#3040) This is an edited summary for a collection of 5 commits: * Enhance: add option to reveal password temporarily on demand This will show the password when the eye icon is clicked on until a different profile is selected or it is clicked a second time. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Also rename the icon used when the password is hidden as it is a modified version (of an oxygen theme one) so it is not wise to use the original name. Refactored to remove an unneeded new slot that can be done without; by restructuring things I did not need to have a second slot just to hide the password when the user changed selected profile - it was needed when a Timer was used to automatically hide the password but in its absence a direct call to the other new slot and a fixed argument - is sufficient. Revised to switch to using icons from theme for show/hide password And provide some `.png` icons if they are not in the current desktop theme (on Linux/FreeBSD) or the OS does not provide such a system for them... These icons were created by myself and I will licensing them under GPL 2.0 (or later terms). Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2019-09-20 22:47:20 +01:00
mpAction_revealPassword = new QAction(this);
mpAction_revealPassword->setCheckable(true);
Infrastructure: Add short qsl macro to stand in for 'QStringLiteral' (#5640)
2021-12-07 06:21:39 +01:00
mpAction_revealPassword->setObjectName(qsl("mpAction_revealPassword"));
Enhance: add option to reveal password temporarily on demand (#3040) This is an edited summary for a collection of 5 commits: * Enhance: add option to reveal password temporarily on demand This will show the password when the eye icon is clicked on until a different profile is selected or it is clicked a second time. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Also rename the icon used when the password is hidden as it is a modified version (of an oxygen theme one) so it is not wise to use the original name. Refactored to remove an unneeded new slot that can be done without; by restructuring things I did not need to have a second slot just to hide the password when the user changed selected profile - it was needed when a Timer was used to automatically hide the password but in its absence a direct call to the other new slot and a fixed argument - is sufficient. Revised to switch to using icons from theme for show/hide password And provide some `.png` icons if they are not in the current desktop theme (on Linux/FreeBSD) or the OS does not provide such a system for them... These icons were created by myself and I will licensing them under GPL 2.0 (or later terms). Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2019-09-20 22:47:20 +01:00
slot_togglePasswordVisibility(false);
character_password_entry->addAction(mpAction_revealPassword, QLineEdit::TrailingPosition);
Add a toggle to store password securely, in OS or in the profile (#3121) * Add password migration toggle * Remove colourroles * Store/load option for secure storage * Minor QA cleanup, remove debug messages * Remove checkmark, it looks poor on Windows * Fix 'Copy profile' not to lose password if you're storing them securely * Actually write password to storage on copy as well * Only save secure passwords if we're using secure password storage * Store passwords in profile storage if using profile storage on edit * Use correct tooltip for secure/profile storage * Fix header return signature to match function's
2019-09-30 11:19:28 +02:00
if (mudlet::self()->storingPasswordsSecurely()) {
Infrastructure: replace `qsl(...)` used for Tooltips (#5694) Specifically when it is used to put HTML like tags around the text so that it triggers the "rich-text" detector in the Qt libraries so that the tips gets better formatting than being a single (long) line of plain text. Whilst working on this PR I also spotted and fixed: * A couple of raw strings in the `VarUnit` class that should have been translated (or replaced with a `QString()`) - this required adding the `Q_DECLARE_TR_FUNCTIONS(`className`)` macro to that class as it is not derived from the `QObject` class which we normally use to provide the `QObject::tr(`...`)` method. * The tooltip for the "Save item" button in the editor contained a unmatched `<p>`...`</p>` tag pair as well as a useless (as it is ignored there) `\n` {Line Feed}. * The tooltip for the "Save profile" button in the editor contained a unmatched `<p>`...`</p>` tag pair. * I had previously defined the `QT_NO_CAST_FROM_ASCII` and `QT_NO_CAST_TO_ASCII` macros in the `dlgRoomExits` class but they are no longer considered useful for us so I have removed those Qt macros. * The `utils::richText(`...`)` wraper has exactly the same code effect as the `(const QString) singleParagraph` helper function in the `dlgRoomExits` class - so it has been replaced by that. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Vadim Peretokin <vperetokin@gmail.com>
2021-12-26 15:22:05 +00:00
character_password_entry->setToolTip(utils::richText(tr("Characters password, stored securely in the computer's credential manager")));
Add a toggle to store password securely, in OS or in the profile (#3121) * Add password migration toggle * Remove colourroles * Store/load option for secure storage * Minor QA cleanup, remove debug messages * Remove checkmark, it looks poor on Windows * Fix 'Copy profile' not to lose password if you're storing them securely * Actually write password to storage on copy as well * Only save secure passwords if we're using secure password storage * Store passwords in profile storage if using profile storage on edit * Use correct tooltip for secure/profile storage * Fix header return signature to match function's
2019-09-30 11:19:28 +02:00
} else {
Infrastructure: replace `qsl(...)` used for Tooltips (#5694) Specifically when it is used to put HTML like tags around the text so that it triggers the "rich-text" detector in the Qt libraries so that the tips gets better formatting than being a single (long) line of plain text. Whilst working on this PR I also spotted and fixed: * A couple of raw strings in the `VarUnit` class that should have been translated (or replaced with a `QString()`) - this required adding the `Q_DECLARE_TR_FUNCTIONS(`className`)` macro to that class as it is not derived from the `QObject` class which we normally use to provide the `QObject::tr(`...`)` method. * The tooltip for the "Save item" button in the editor contained a unmatched `<p>`...`</p>` tag pair as well as a useless (as it is ignored there) `\n` {Line Feed}. * The tooltip for the "Save profile" button in the editor contained a unmatched `<p>`...`</p>` tag pair. * I had previously defined the `QT_NO_CAST_FROM_ASCII` and `QT_NO_CAST_TO_ASCII` macros in the `dlgRoomExits` class but they are no longer considered useful for us so I have removed those Qt macros. * The `utils::richText(`...`)` wraper has exactly the same code effect as the `(const QString) singleParagraph` helper function in the `dlgRoomExits` class - so it has been replaced by that. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Vadim Peretokin <vperetokin@gmail.com>
2021-12-26 15:22:05 +00:00
character_password_entry->setToolTip(utils::richText(tr("Characters password. Note that the password is not encrypted in storage")));
Add a toggle to store password securely, in OS or in the profile (#3121) * Add password migration toggle * Remove colourroles * Store/load option for secure storage * Minor QA cleanup, remove debug messages * Remove checkmark, it looks poor on Windows * Fix 'Copy profile' not to lose password if you're storing them securely * Actually write password to storage on copy as well * Only save secure passwords if we're using secure password storage * Store passwords in profile storage if using profile storage on edit * Use correct tooltip for secure/profile storage * Fix header return signature to match function's
2019-09-30 11:19:28 +02:00
}
Enhance: add option to reveal password temporarily on demand (#3040) This is an edited summary for a collection of 5 commits: * Enhance: add option to reveal password temporarily on demand This will show the password when the eye icon is clicked on until a different profile is selected or it is clicked a second time. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Also rename the icon used when the password is hidden as it is a modified version (of an oxygen theme one) so it is not wise to use the original name. Refactored to remove an unneeded new slot that can be done without; by restructuring things I did not need to have a second slot just to hide the password when the user changed selected profile - it was needed when a Timer was used to automatically hide the password but in its absence a direct call to the other new slot and a fixed argument - is sufficient. Revised to switch to using icons from theme for show/hide password And provide some `.png` icons if they are not in the current desktop theme (on Linux/FreeBSD) or the OS does not provide such a system for them... These icons were created by myself and I will licensing them under GPL 2.0 (or later terms). Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2019-09-20 22:47:20 +01:00
connect(mpAction_revealPassword, &QAction::triggered, this, &dlgConnectionProfiles::slot_togglePasswordVisibility);
Add support for opening a profile offline (#2580) * Added Load button to profile selection dialog. * Changed name of load button to offline. * Added successful load message. * Cleaned up some tooltip messages. * Removed obsolete arg historyVersion.
2019-06-01 14:35:50 -06:00
connect(offline_button, &QAbstractButton::clicked, this, &dlgConnectionProfiles::slot_load);
Fixed up a few clazy warnings (#1641) Biggest ones were: 1. https://github.com/KDE/clazy/blob/master/src/checks/level2/README-qstring-allocations.md 1. https://github.com/KDE/clazy/blob/master/src/checks/level2/README-old-style-connect.md
2018-05-14 18:30:48 +02:00
connect(connect_button, &QAbstractButton::clicked, this, &dlgConnectionProfiles::accept);
connect(abort, &QAbstractButton::clicked, this, &dlgConnectionProfiles::slot_cancel);
connect(new_profile_button, &QAbstractButton::clicked, this, &dlgConnectionProfiles::slot_addProfile);
Infrastructure: tidy up naming of SLOT methods and their usage - Part 5 (last) (#6266) When Qt's slot/signal system is used to invoke a method there is some overhead - so it makes sense to ensure developers can spot all such methods (functions). We have tried to do this with a `slot_` prefix to the methods we create but it has not been applied uniformly. This PR is intended to conclude helping with this by more rigorously doing so - the names changed herein should all follow a `slot_`*camelCaseMethodName* style. In addition some methods were detected that are not currently used or which are not actually used via the signal/slot system, these have been commented out or have had the prefix removed and the declaration in the relevant header file moved as appropriate. There were two similar sets of (not prefixed with `slot_`) slots in the Profile preferences class that adjusted the colour settings separately for the main console and the mapper the latter had the same names but with a `2` suffix. To made it more clear I have changed them to include `Map` in their names instead. Also, the NON-slot method: `(void) dlgProfilePreferences::setColor(QPushButton*, QColor&, bool)` has been renamed to: `(void) dlgProfilePreferences::setButtonAndProfileColor(QPushButton*, QColor&, bool)` so that it is clearly distinguishable from built in Qt methods that are also called `setColor` - though which do have different signatures! For reference the changes made are: * `TConsole::slot_stop_all_triggers(...)` ==> `TConsole::slot_stopAllItems(...)` * `dlgConnectionProfiles::slot_copy_profile()` ==> `dlgConnectionProfiles::slot_copyProfile()` * `dlgConnectionProfiles::slot_copy_profilesettings_only()` ==> `dlgConnectionProfiles::slot_copyOnlySettingsOfProfile()` * `dlgConnectionProfiles::slot_deleteprofile_check(...)` ==> `dlgConnectionProfiles::slot_deleteProfileCheck(...)` * `dlgConnectionProfiles::slot_password_deleted(...)` ==> `dlgConnectionProfiles::slot_passwordDeleted(...)` * `dlgConnectionProfiles::slot_password_saved(...) ==> `dlgConnectionProfiles::slot_passwordSaved(...)` * `dlgConnectionProfiles::slot_profile_menu(...)` ==> `dlgConnectionProfiles::slot_profileContextMenu(...)` * `dlgConnectionProfiles::slot_reset_custom_icon()` ==> `dlgConnectionProfiles::slot_resetCustomIcon()` * `dlgConnectionProfiles::slot_set_custom_icon()` ==> `dlgConnectionProfiles::slot_setCustomIcon()` * `dlgConnectionProfiles::slot_set_custom_color()` ==> `dlgConnectionProfiles::slot_setCustomColor()` * `dlgConnectionProfiles::slot_update_autologin(...)` ==> `dlgConnectionProfiles::slot_updateAutoConnect(...)` * `dlgConnectionProfiles::slot_update_autoreconnect(...)` ==> `dlgConnectionProfiles::slot_updateAutoReconnect(...)` * `dlgConnectionProfiles::slot_update_description()` ==> `dlgConnectionProfiles::slot_updateDescription()` * `dlgConnectionProfiles::slot_update_discord_optin(...)` ==> `dlgConnectionProfiles::slot_updateDiscordOptIn(...)` * `dlgProfilePreferences::copyMap()` ==> `dlgProfilePreferences::slot_copyMap()` * `dlgProfilePreferences::downloadMap()` ==> `dlgProfilePreferences::slot_downloadMap()` * `dlgProfilePreferences::hideActionLabel()` ==> `dlgProfilePreferences::slot_hideActionLabel()` * `dlgProfilePreferences::loadMap()` ==> `dlgProfilePreferences::slot_loadMap()` * `dlgProfilePreferences::resetColors()` ==> `dlgProfilePreferences::slot_resetColors()` * `dlgProfilePreferences::resetColors2()` ==> `dlgProfilePreferences::slot_resetMapColors()` * `dlgProfilePreferences::saveMap()` ==> `dlgProfilePreferences::slot_saveMap()` * `dlgProfilePreferences::setBgColor()` ==> `dlgProfilePreferences::slot_setBgColor()` * `dlgProfilePreferences::setBgColor2()` ==> `dlgProfilePreferences::slot_setMapBgColor()` * `dlgProfilePreferences::setColorBlack()` ==> `dlgProfilePreferences::slot_setColorBlack()` * `dlgProfilePreferences::setColorBlack2()` ==> `dlgProfilePreferences::slot_setMapColorBlack()` * `dlgProfilePreferences::setColorBlue()` ==> `dlgProfilePreferences::slot_setColorBlue()` * `dlgProfilePreferences::setColorCyan()` ==> `dlgProfilePreferences::slot_setColorCyan()` * `dlgProfilePreferences::setColorBlue2()` ==> `dlgProfilePreferences::slot_setMapColorBlue()` * `dlgProfilePreferences::setColorCyan2()` ==> `dlgProfilePreferences::slot_setMapColorCyan()` * `dlgProfilePreferences::setColorGreen()` ==> `dlgProfilePreferences::slot_setColorGreen()` * `dlgProfilePreferences::setColorGreen2()` ==> `dlgProfilePreferences::slot_setMapColorGreen()` * `dlgProfilePreferences::setColorLightBlack()` ==> `dlgProfilePreferences::slot_setColorLightBlack()` * `dlgProfilePreferences::setColorLightBlack2()` ==> `dlgProfilePreferences::slot_setMapColorLightBlack()` * `dlgProfilePreferences::setColorLightBlue()` ==> `dlgProfilePreferences::slot_setColorLightBlue()` * `dlgProfilePreferences::setColorLightBlue2()` ==> `dlgProfilePreferences::slot_setMapColorLightBlue()` * `dlgProfilePreferences::setColorLightCyan()` ==> `dlgProfilePreferences::slot_setColorLightCyan()` * `dlgProfilePreferences::setColorLightCyan2()` ==> `dlgProfilePreferences::slot_setMapColorLightCyan()` * `dlgProfilePreferences::setColorLightGreen()` ==> `dlgProfilePreferences::slot_setColorLightGreen()` * `dlgProfilePreferences::setColorLightGreen2()` ==> `dlgProfilePreferences::slot_setMapColorLightGreen()` * `dlgProfilePreferences::setColorLightMagenta()` ==> `dlgProfilePreferences::slot_setColorLightMagenta()` * `dlgProfilePreferences::setColorLightMagenta2()` ==> `dlgProfilePreferences::slot_setMapColorLightMagenta()` * `dlgProfilePreferences::setColorLightRed()` ==> `dlgProfilePreferences::slot_setColorLightRed()` * `dlgProfilePreferences::setColorLightRed2()` ==> `dlgProfilePreferences::slot_setMapColorLightRed()` * `dlgProfilePreferences::setColorLightWhite()` ==> `dlgProfilePreferences::slot_setColorLightWhite()` * `dlgProfilePreferences::setColorLightWhite2()` ==> `dlgProfilePreferences::slot_setMapColorLightWhite()` * `dlgProfilePreferences::setColorLightYellow()` ==> `dlgProfilePreferences::slot_setColorLightYellow()` * `dlgProfilePreferences::setColorLightYellow2()` ==> `dlgProfilePreferences::slot_setMapColorLightYellow()` * `dlgProfilePreferences::setColorMagenta()` ==> `dlgProfilePreferences::slot_setColorMagenta()` * `dlgProfilePreferences::setColorMagenta2()` ==> `dlgProfilePreferences::slot_setMapColorMagenta()` * `dlgProfilePreferences::setColorRed2()` ==> `dlgProfilePreferences::slot_setMapColorRed()` * `dlgProfilePreferences::setColorRed()` ==> `dlgProfilePreferences::slot_setColorRed()` * `dlgProfilePreferences::setColorWhite()` ==> `dlgProfilePreferences::slot_setColorWhite()` * `dlgProfilePreferences::setColorWhite2()` ==> `dlgProfilePreferences::slot_setMapColorWhite()` * `dlgProfilePreferences::setColorYellow()` ==> `dlgProfilePreferences::slot_setColorYellow()` * `dlgProfilePreferences::setColorYellow2()` ==> `dlgProfilePreferences::slot_setMapColorYellow()` * `dlgProfilePreferences::setCommandBgColor()` ==> `dlgProfilePreferences::slot_setCommandBgColor()` * `dlgProfilePreferences::setCommandFgColor()` ==> `dlgProfilePreferences::slot_setCommandFgColor()` * `dlgProfilePreferences::setCommandLineBgColor()` ==> `dlgProfilePreferences::slot_setCommandLineBgColor()` * `dlgProfilePreferences::setCommandLineFgColor()` ==> `dlgProfilePreferences::slot_setCommandLineFgColor()` * `dlgProfilePreferences::setDisplayFont()` ==> `dlgProfilePreferences::slot_setDisplayFont()` * `dlgProfilePreferences::setFgColor()` ==> `dlgProfilePreferences::slot_setFgColor()` * `dlgProfilePreferences::setFgColor2()` ==> `dlgProfilePreferences::slot_setMapExitsColor()` * `dlgProfilePreferences::setFontSize()` ==> `dlgProfilePreferences::slot_setFontSize()` * `dlgProfilePreferences::setMapInfoBackground()` ==> `dlgProfilePreferences::slot_setMapInfoBgColor()` * `dlgProfilePreferences::setRoomBorderColor()` ==> `dlgProfilePreferences::slot_setMapRoomBorderColor()` * `dlgProfilePreferences::slot_script_selected(...)` ==> `dlgProfilePreferences::slot_scriptSelected(...)` * `dlgProfilePreferences::slot_theme_selected(...)` ==> `dlgProfilePreferences::slot_themeSelected(...)` * `dlgRoomSymbol::colorRejected()` ==> `dlgRoomSymbol::slot_colorRejected()` * `dlgRoomSymbol::colorSelected(...)` ==> `dlgRoomSymbol::slot_colorSelected(...)` * `dlgRoomSymbol::currentColorChanged(...)` ==> `dlgRoomSymbol::slot_currentColorChanged(...)` * `dlgRoomSymbol::openColorSelector()` ==> `dlgRoomSymbol::slot_openColorSelector()` * `dlgRoomSymbol::resetColor()` ==> `dlgRoomSymbol::slot_resetColors()` * `dlgRoomSymbol::updatePreview()` ==> `dlgRoomSymbol::slot_updatePreview()` * `dlgTriggerEditor::slot_show_vars()` ==> `dlgTriggerEditor::slot_showVariables()` * `dlgTriggerEditor::slot_var_changed(...)` ==> `dlgTriggerEditor::slot_variableChanged(...)` * `dlgTriggerEditor::slot_var_selected(...)` ==> `dlgTriggerEditor::slot_variableSelected(...)` * `mudlet::slot_check_manual_update()` ==> `mudlet::slot_manualUpdateCheck()` * `mudlet::slot_close_current_profile()` ==> `mudlet::slot_closeCurrentProfile()` * `mudlet::slot_close_profile_requested(...)` ==> `mudlet::slot_closeProfileRequested(...)` * `mudlet::slot_connection_dlg_finished(...)` ==> `mudlet::slot_connectionDialogueFinished(...)` * `mudlet::slot_module_manager()` ==> `mudlet::slot_moduleManager()` * `mudlet::slot_mudlet_discord()` ==> `mudlet::slot_mudletDiscord()` * `mudlet::slot_multi_view(...)` ==> `mudlet::slot_multiView(const bool state)` * `mudlet::slot_package_manager()` ==> `mudlet::slot_packageManager()` * `mudlet::slot_package_exporter()` ==> `mudlet::slot_packageExporter()` * `mudlet::slot_timer_fires()` ==> `mudlet::slot_timerFires()` * `mudlet::slot_toggle_multi_view()` ==> `mudlet::slot_toggleMultiView()` Also the names for these in particular have been changed to make more sense: * `dlgProfilePreferences::slot_chooseProfilesChanged()` ==> `dlgProfilePreferences::slot_chosenProfilesChanged()` * `dlgProfilePreferences::slot_editor_tab_selected(...)` ==> `dlgProfilePreferences::slot_tabChanged(...)` * `dlgProfilePreferences::slot_passwords_location_changed(...)` ==> `dlgProfilePreferences::slot_passwordStorageLocationChanged(...)` * `dlgProfilePreferences::slot_save_and_exit()` ==> `dlgProfilePreferences::slot_saveAndClose()` * `dlgTriggerEditor::slot_toggleHiddenVar(...)` ==> `dlgTriggerEditor::slot_hideVariable(...)` - changed to distinguish it from `slot_toggleHiddenVariables(...)` * `dlgTriggerEditor::slot_item_selected_save(...)` ==> `dlgTriggerEditor::slot_saveSelectedItem(...)` * `mudlet::slot_discord()` ==> `mudlet::slot_profileDiscord()` - changed to distinguish it from `slot_mudletDiscord()` Not currently used and commented out: * `dlgProfilePreferences::setCommandLineFont()` ==> `dlgProfilePreferences::slot_setCommandLineFont()` Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-08-29 14:27:13 +02:00
connect(mpCopyProfile, &QAction::triggered, this, &dlgConnectionProfiles::slot_copyProfile);
connect(copyProfileSettings, &QAction::triggered, this, &dlgConnectionProfiles::slot_copyOnlySettingsOfProfile);
Fixed up a few clazy warnings (#1641) Biggest ones were: 1. https://github.com/KDE/clazy/blob/master/src/checks/level2/README-qstring-allocations.md 1. https://github.com/KDE/clazy/blob/master/src/checks/level2/README-old-style-connect.md
2018-05-14 18:30:48 +02:00
connect(remove_profile_button, &QAbstractButton::clicked, this, &dlgConnectionProfiles::slot_deleteProfile);
fix: Enable connect and offline buttons when selecting currently open and then different profile (#7692) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions This enables the Connect and Offline buttons when changing selection from a currently loaded profile over to another profile that has same server address and port number. #### Motivation for adding to Mudlet I prioritize my time badly and sometimes get the wrong things off my plate first. Though I'm thinking of this as a mental health break from other tasks. #### Other info (issues closed, discussion etc) The changes in #7673 made it so the connection dialog will disable the Connect and Offline buttons when selecting a profile that is already open. But re-enabling the buttons when selecting another profile only happens when other profile has different server address or port. So if you have two profiles for same game, need to select an intermediate one to enable the buttons currently. Whenever you switch to a different profile that has a different server address, the box gets updated which triggers `slot_updateUrl`, which in turn calls `validateProfile()`. Similar deal with `slot_updatePort`. But `slot_updateName` is not similarly called when the name box changes, only when you are typing in the name box, so it only runs `validateProfile()` when typing. I found that the difference between it and the others is `::textChanged` vs `::textEdited`.
2025-02-05 03:02:49 -05:00
connect(profile_name_entry, &QLineEdit::textChanged, this, &dlgConnectionProfiles::slot_updateName);
Infrastructure: tidy up naming of SLOT methods and their usage - Part 2 (#6255) When Qt's slot/signal system is used to invoke a method there is some overhead - so it makes sense to ensure developers can spot all such methods (functions). We have tried to do this with a `slot_` prefix to the methods we create but it has not been applied uniformly. This PR (and one or more to follow) is intended to help with this by more rigorously doing so - the names changed herein should all follow a `slot_`*camelCaseMethodName* style. In addition some methods were detected that are not currently used or which are not actually used via the signal/slot system, these have been commented out or have had the prefix removed and the declaration in the relevant header file moved as appropriate. For reference the changes made are: * `TLuaInterpreter::slotDeleteSender(...)` ==> `TLuaInterpreter::slot_deleteSender(...)` * `TLuaInterpreter::slotPurge()` ==> `TLuaInterpreter::slot_purge()` * `cTelnet::handle_socket_signal_connected()` ==> `cTelnet::slot_socketConnected()` * `cTelnet::handle_socket_signal_disconnected()` ==> `cTelnet::slot_socketDisconnected()` * `cTelnet::handle_socket_signal_hostFound(...)` ==> `cTelnet::slot_socketHostFound(...)` * `cTelnet::handle_socket_signal_readyRead()` ==> `cTelnet::slot_socketReadyToBeRead()` * `cTelnet::handle_socket_signal_sslError(...)` ==> `cTelnet::slot_socketSslError(...)` * `cTelnet::setDownloadProgress(...)` ==> `cTelnet::slot_setDownloadProgress(...)` * `dlgComposer::cancel()` ==> `dlgComposer::slot_cancel()` * `dlgComposer::save()` ==> `dlgComposer::slot_save()` * `dlgConnectionProfiles::slot_item_clicked(...)` ==> `dlgConnectionProfiles::slot_itemClicked(...)` * `dlgConnectionProfiles::slot_save_name()` ==> `dlgConnectionProfiles::slot_saveName()` * `dlgConnectionProfiles::slot_update_login(...)` ==> `dlgConnectionProfiles::slot_updateLogin(...)` * `dlgConnectionProfiles::slot_update_name(...)` ==> `dlgConnectionProfiles::slot_updateName(...)` * `dlgConnectionProfiles::slot_update_pass(...)` ==> `dlgConnectionProfiles::slot_updatePassword(...)` * `dlgConnectionProfiles::slot_update_port(...)` ==> `dlgConnectionProfiles::slot_updatePort(...)` * `dlgConnectionProfiles::slot_update_SSL_TSL_port(...)` ==> `dlgConnectionProfiles::slot_updateSslTslPort(...)` * `dlgConnectionProfiles::slot_update_url(...)` ==> `dlgConnectionProfiles::slot_updateUrl(...)` * `dlgMapLabel::pickBgColor()` ==> `dlgMapLabel::slot_pickBgColor()` * `dlgMapLabel::pickFgColor()` ==> `dlgMapLabel::slot_pickFgColor()` * `dlgMapLabel::pickFile()` ==> `dlgMapLabel::slot_pickFile()` * `dlgMapLabel::pickFont()` ==> `dlgMapLabel::slot_pickFont()` * `dlgMapLabel::save()` ==> `dlgMapLabel::slot_save()` * `dlgMapLabel::updateControls()` ==> `dlgMapLabel::slot_updateControls()` * `dlgMapLabel::updateControlsVisibility()` ==> `dlgMapLabel::slot_updateControlsVisibility()` Commented out as not being used: * `cTelnet::handle_socket_signal_error()` ==> `cTelnet::slot_socketError()` * `dlgConnectionProfiles::slot_update_website(...) ==> `dlgConnectionProfiles::slot_updateWebsite(const QString& url)` I have my doubts about whether the `dlgMapLabel::save()`/`dlgMapLabel::slot_save()` method is needed at all, as it might be that the `QDialog::accept()` slot could have been inserted into the `QObject::connect(...)` call directly instead...? Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-08-27 10:47:01 +02:00
connect(profile_name_entry, &QLineEdit::editingFinished, this, &dlgConnectionProfiles::slot_saveName);
connect(host_name_entry, &QLineEdit::textChanged, this, &dlgConnectionProfiles::slot_updateUrl);
connect(port_entry, &QLineEdit::textChanged, this, &dlgConnectionProfiles::slot_updatePort);
Fix reduce c++20warnings (#7638) #### Brief overview of PR changes/additions 1. Adds explicit ‘this’ or ‘*this’ capture to lambdas where required (not in static ones). 2. Rephrases some combinations of Qt `enum`s that whilst acceptable for C++17 upset the later one. For the non-key related ones which are provided a `int`s arguments to a method this is sufficient; For Qt 6 there are some additional methods that overcome the "incompatibility" of combining such different `enum`s but those have not been back ported to the Qt 5.15.8 I have - despite what https://bugreports.qt.io/browse/QTBUG-99948 says - so fixes for combining QKey and QKeyModifier have been left out of this PR. 3. Removes a couple of unused variables. 4. Adds our `qsl(...)` wrapper about some raw C-string literals used in a loop. 5. Rewrite part of the qmake project file so the logic and choices are correct. #### Motivation for adding to Mudlet 1. To eliminate the following type of warning when building with a C++20 compiler: "warning: implicit capture of ‘this’ via ‘[=]’ is deprecated in C++20 [-Wdeprecated]" 2. To eliminate the following type of warning when building with a C++20 compiler: * warning: bitwise operation between different enumeration types ‘QFont::Weight’ and ‘QFont::StyleHint’ is deprecated [-Wdeprecated-enum-enum-conversion] * warning: bitwise operation between different enumeration types ‘Qt::TextFlag’ and ‘Qt::AlignmentFlag’ is deprecated [-Wdeprecated-enum-enum-conversion] 3. To eliminate the following type of warning when building with a C++20 compiler: "warning: unused variable ‘pHost’ [-Wunused-variable]" 4. To eliminate the following type of warning when building with a C++20 compiler: "warning: loop variable ‘file’ of type ‘const QString&’ binds to a temporary constructed from type ‘const char* const’ [-Wrange-loop-construct]" 5. The previous logic was (incorrect) IF Qt Major version is less than 5 OR (if Qt Major version is less than 6 AND if Qt Minor version is less than 12)) THEN add `-std=c++20` to `QMAKE_CXXFLAGS` ELSE add `c++2a` to `CONFIG` This is borked because we have already rejected Qt versions less than 5.14 so the logic will **always** end up in the **ELSE** case, and whilst Qt 5.15 is documented as accepting `CONFIG += c++2a` (and `c++2b`) the earliest Qt 6.x version describes `c++2a` as an obsolete alias for `c++20` (in https://doc.qt.io/qt-6.2/qmake-variable-reference.html). #### Other info (issues closed, discussion etc) 3. The code in the `QFont` cases contains errors that have been copied from bogus QFont creation code going back to the very first (well second) commit in the git history. This contained calls of the form `QFont font("Courier New", 10, QFont::Courier)` however even the Qt 4.8 documentation does not list a constructor of that form but instead has: `QFont(const QString & family, int pointSize = -1, int weight = -1, bool italic = false)` the third argument could possibly be `QFont::Normal` (50) or `QFont::Bold` (75) however the value of `QFont::Courier` is `2` but it is for a completely different purpose, that of the font matching strategy ("the font matcher prefers fixed pitch fonts.") but that is not something that can be set as an argument to the font constructor! As it happens the combination of `QFont::Bold | QFont::Serif | QFont::PreferMatch | QFont::PreferAntialias` that was being used numerically equals 75 + 2 + 32 + 128 = 227 - and the scale that Qt actually uses only goes from 0 to 99! 5. This change makes the code match the comments! Overall all the changes in this PR means that https://github.com/Mudlet/Mudlet/pull/7613 is not required after all - at least for Mudlet's own code - though there are still some warnings from the edbee-lib sub-module. --------- Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2025-02-10 11:59:45 +00:00
#if QT_VERSION >= QT_VERSION_CHECK(6, 7, 0)
connect(port_ssl_tsl, &QCheckBox::checkStateChanged, this, &dlgConnectionProfiles::slot_updateSslTslPort);
connect(autologin_checkBox, &QCheckBox::checkStateChanged, this, &dlgConnectionProfiles::slot_updateAutoConnect);
connect(auto_reconnect, &QCheckBox::checkStateChanged, this, &dlgConnectionProfiles::slot_updateAutoReconnect);
#else
Infrastructure: tidy up naming of SLOT methods and their usage - Part 2 (#6255) When Qt's slot/signal system is used to invoke a method there is some overhead - so it makes sense to ensure developers can spot all such methods (functions). We have tried to do this with a `slot_` prefix to the methods we create but it has not been applied uniformly. This PR (and one or more to follow) is intended to help with this by more rigorously doing so - the names changed herein should all follow a `slot_`*camelCaseMethodName* style. In addition some methods were detected that are not currently used or which are not actually used via the signal/slot system, these have been commented out or have had the prefix removed and the declaration in the relevant header file moved as appropriate. For reference the changes made are: * `TLuaInterpreter::slotDeleteSender(...)` ==> `TLuaInterpreter::slot_deleteSender(...)` * `TLuaInterpreter::slotPurge()` ==> `TLuaInterpreter::slot_purge()` * `cTelnet::handle_socket_signal_connected()` ==> `cTelnet::slot_socketConnected()` * `cTelnet::handle_socket_signal_disconnected()` ==> `cTelnet::slot_socketDisconnected()` * `cTelnet::handle_socket_signal_hostFound(...)` ==> `cTelnet::slot_socketHostFound(...)` * `cTelnet::handle_socket_signal_readyRead()` ==> `cTelnet::slot_socketReadyToBeRead()` * `cTelnet::handle_socket_signal_sslError(...)` ==> `cTelnet::slot_socketSslError(...)` * `cTelnet::setDownloadProgress(...)` ==> `cTelnet::slot_setDownloadProgress(...)` * `dlgComposer::cancel()` ==> `dlgComposer::slot_cancel()` * `dlgComposer::save()` ==> `dlgComposer::slot_save()` * `dlgConnectionProfiles::slot_item_clicked(...)` ==> `dlgConnectionProfiles::slot_itemClicked(...)` * `dlgConnectionProfiles::slot_save_name()` ==> `dlgConnectionProfiles::slot_saveName()` * `dlgConnectionProfiles::slot_update_login(...)` ==> `dlgConnectionProfiles::slot_updateLogin(...)` * `dlgConnectionProfiles::slot_update_name(...)` ==> `dlgConnectionProfiles::slot_updateName(...)` * `dlgConnectionProfiles::slot_update_pass(...)` ==> `dlgConnectionProfiles::slot_updatePassword(...)` * `dlgConnectionProfiles::slot_update_port(...)` ==> `dlgConnectionProfiles::slot_updatePort(...)` * `dlgConnectionProfiles::slot_update_SSL_TSL_port(...)` ==> `dlgConnectionProfiles::slot_updateSslTslPort(...)` * `dlgConnectionProfiles::slot_update_url(...)` ==> `dlgConnectionProfiles::slot_updateUrl(...)` * `dlgMapLabel::pickBgColor()` ==> `dlgMapLabel::slot_pickBgColor()` * `dlgMapLabel::pickFgColor()` ==> `dlgMapLabel::slot_pickFgColor()` * `dlgMapLabel::pickFile()` ==> `dlgMapLabel::slot_pickFile()` * `dlgMapLabel::pickFont()` ==> `dlgMapLabel::slot_pickFont()` * `dlgMapLabel::save()` ==> `dlgMapLabel::slot_save()` * `dlgMapLabel::updateControls()` ==> `dlgMapLabel::slot_updateControls()` * `dlgMapLabel::updateControlsVisibility()` ==> `dlgMapLabel::slot_updateControlsVisibility()` Commented out as not being used: * `cTelnet::handle_socket_signal_error()` ==> `cTelnet::slot_socketError()` * `dlgConnectionProfiles::slot_update_website(...) ==> `dlgConnectionProfiles::slot_updateWebsite(const QString& url)` I have my doubts about whether the `dlgMapLabel::save()`/`dlgMapLabel::slot_save()` method is needed at all, as it might be that the `QDialog::accept()` slot could have been inserted into the `QObject::connect(...)` call directly instead...? Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-08-27 10:47:01 +02:00
connect(port_ssl_tsl, &QCheckBox::stateChanged, this, &dlgConnectionProfiles::slot_updateSslTslPort);
Infrastructure: tidy up naming of SLOT methods and their usage - Part 5 (last) (#6266) When Qt's slot/signal system is used to invoke a method there is some overhead - so it makes sense to ensure developers can spot all such methods (functions). We have tried to do this with a `slot_` prefix to the methods we create but it has not been applied uniformly. This PR is intended to conclude helping with this by more rigorously doing so - the names changed herein should all follow a `slot_`*camelCaseMethodName* style. In addition some methods were detected that are not currently used or which are not actually used via the signal/slot system, these have been commented out or have had the prefix removed and the declaration in the relevant header file moved as appropriate. There were two similar sets of (not prefixed with `slot_`) slots in the Profile preferences class that adjusted the colour settings separately for the main console and the mapper the latter had the same names but with a `2` suffix. To made it more clear I have changed them to include `Map` in their names instead. Also, the NON-slot method: `(void) dlgProfilePreferences::setColor(QPushButton*, QColor&, bool)` has been renamed to: `(void) dlgProfilePreferences::setButtonAndProfileColor(QPushButton*, QColor&, bool)` so that it is clearly distinguishable from built in Qt methods that are also called `setColor` - though which do have different signatures! For reference the changes made are: * `TConsole::slot_stop_all_triggers(...)` ==> `TConsole::slot_stopAllItems(...)` * `dlgConnectionProfiles::slot_copy_profile()` ==> `dlgConnectionProfiles::slot_copyProfile()` * `dlgConnectionProfiles::slot_copy_profilesettings_only()` ==> `dlgConnectionProfiles::slot_copyOnlySettingsOfProfile()` * `dlgConnectionProfiles::slot_deleteprofile_check(...)` ==> `dlgConnectionProfiles::slot_deleteProfileCheck(...)` * `dlgConnectionProfiles::slot_password_deleted(...)` ==> `dlgConnectionProfiles::slot_passwordDeleted(...)` * `dlgConnectionProfiles::slot_password_saved(...) ==> `dlgConnectionProfiles::slot_passwordSaved(...)` * `dlgConnectionProfiles::slot_profile_menu(...)` ==> `dlgConnectionProfiles::slot_profileContextMenu(...)` * `dlgConnectionProfiles::slot_reset_custom_icon()` ==> `dlgConnectionProfiles::slot_resetCustomIcon()` * `dlgConnectionProfiles::slot_set_custom_icon()` ==> `dlgConnectionProfiles::slot_setCustomIcon()` * `dlgConnectionProfiles::slot_set_custom_color()` ==> `dlgConnectionProfiles::slot_setCustomColor()` * `dlgConnectionProfiles::slot_update_autologin(...)` ==> `dlgConnectionProfiles::slot_updateAutoConnect(...)` * `dlgConnectionProfiles::slot_update_autoreconnect(...)` ==> `dlgConnectionProfiles::slot_updateAutoReconnect(...)` * `dlgConnectionProfiles::slot_update_description()` ==> `dlgConnectionProfiles::slot_updateDescription()` * `dlgConnectionProfiles::slot_update_discord_optin(...)` ==> `dlgConnectionProfiles::slot_updateDiscordOptIn(...)` * `dlgProfilePreferences::copyMap()` ==> `dlgProfilePreferences::slot_copyMap()` * `dlgProfilePreferences::downloadMap()` ==> `dlgProfilePreferences::slot_downloadMap()` * `dlgProfilePreferences::hideActionLabel()` ==> `dlgProfilePreferences::slot_hideActionLabel()` * `dlgProfilePreferences::loadMap()` ==> `dlgProfilePreferences::slot_loadMap()` * `dlgProfilePreferences::resetColors()` ==> `dlgProfilePreferences::slot_resetColors()` * `dlgProfilePreferences::resetColors2()` ==> `dlgProfilePreferences::slot_resetMapColors()` * `dlgProfilePreferences::saveMap()` ==> `dlgProfilePreferences::slot_saveMap()` * `dlgProfilePreferences::setBgColor()` ==> `dlgProfilePreferences::slot_setBgColor()` * `dlgProfilePreferences::setBgColor2()` ==> `dlgProfilePreferences::slot_setMapBgColor()` * `dlgProfilePreferences::setColorBlack()` ==> `dlgProfilePreferences::slot_setColorBlack()` * `dlgProfilePreferences::setColorBlack2()` ==> `dlgProfilePreferences::slot_setMapColorBlack()` * `dlgProfilePreferences::setColorBlue()` ==> `dlgProfilePreferences::slot_setColorBlue()` * `dlgProfilePreferences::setColorCyan()` ==> `dlgProfilePreferences::slot_setColorCyan()` * `dlgProfilePreferences::setColorBlue2()` ==> `dlgProfilePreferences::slot_setMapColorBlue()` * `dlgProfilePreferences::setColorCyan2()` ==> `dlgProfilePreferences::slot_setMapColorCyan()` * `dlgProfilePreferences::setColorGreen()` ==> `dlgProfilePreferences::slot_setColorGreen()` * `dlgProfilePreferences::setColorGreen2()` ==> `dlgProfilePreferences::slot_setMapColorGreen()` * `dlgProfilePreferences::setColorLightBlack()` ==> `dlgProfilePreferences::slot_setColorLightBlack()` * `dlgProfilePreferences::setColorLightBlack2()` ==> `dlgProfilePreferences::slot_setMapColorLightBlack()` * `dlgProfilePreferences::setColorLightBlue()` ==> `dlgProfilePreferences::slot_setColorLightBlue()` * `dlgProfilePreferences::setColorLightBlue2()` ==> `dlgProfilePreferences::slot_setMapColorLightBlue()` * `dlgProfilePreferences::setColorLightCyan()` ==> `dlgProfilePreferences::slot_setColorLightCyan()` * `dlgProfilePreferences::setColorLightCyan2()` ==> `dlgProfilePreferences::slot_setMapColorLightCyan()` * `dlgProfilePreferences::setColorLightGreen()` ==> `dlgProfilePreferences::slot_setColorLightGreen()` * `dlgProfilePreferences::setColorLightGreen2()` ==> `dlgProfilePreferences::slot_setMapColorLightGreen()` * `dlgProfilePreferences::setColorLightMagenta()` ==> `dlgProfilePreferences::slot_setColorLightMagenta()` * `dlgProfilePreferences::setColorLightMagenta2()` ==> `dlgProfilePreferences::slot_setMapColorLightMagenta()` * `dlgProfilePreferences::setColorLightRed()` ==> `dlgProfilePreferences::slot_setColorLightRed()` * `dlgProfilePreferences::setColorLightRed2()` ==> `dlgProfilePreferences::slot_setMapColorLightRed()` * `dlgProfilePreferences::setColorLightWhite()` ==> `dlgProfilePreferences::slot_setColorLightWhite()` * `dlgProfilePreferences::setColorLightWhite2()` ==> `dlgProfilePreferences::slot_setMapColorLightWhite()` * `dlgProfilePreferences::setColorLightYellow()` ==> `dlgProfilePreferences::slot_setColorLightYellow()` * `dlgProfilePreferences::setColorLightYellow2()` ==> `dlgProfilePreferences::slot_setMapColorLightYellow()` * `dlgProfilePreferences::setColorMagenta()` ==> `dlgProfilePreferences::slot_setColorMagenta()` * `dlgProfilePreferences::setColorMagenta2()` ==> `dlgProfilePreferences::slot_setMapColorMagenta()` * `dlgProfilePreferences::setColorRed2()` ==> `dlgProfilePreferences::slot_setMapColorRed()` * `dlgProfilePreferences::setColorRed()` ==> `dlgProfilePreferences::slot_setColorRed()` * `dlgProfilePreferences::setColorWhite()` ==> `dlgProfilePreferences::slot_setColorWhite()` * `dlgProfilePreferences::setColorWhite2()` ==> `dlgProfilePreferences::slot_setMapColorWhite()` * `dlgProfilePreferences::setColorYellow()` ==> `dlgProfilePreferences::slot_setColorYellow()` * `dlgProfilePreferences::setColorYellow2()` ==> `dlgProfilePreferences::slot_setMapColorYellow()` * `dlgProfilePreferences::setCommandBgColor()` ==> `dlgProfilePreferences::slot_setCommandBgColor()` * `dlgProfilePreferences::setCommandFgColor()` ==> `dlgProfilePreferences::slot_setCommandFgColor()` * `dlgProfilePreferences::setCommandLineBgColor()` ==> `dlgProfilePreferences::slot_setCommandLineBgColor()` * `dlgProfilePreferences::setCommandLineFgColor()` ==> `dlgProfilePreferences::slot_setCommandLineFgColor()` * `dlgProfilePreferences::setDisplayFont()` ==> `dlgProfilePreferences::slot_setDisplayFont()` * `dlgProfilePreferences::setFgColor()` ==> `dlgProfilePreferences::slot_setFgColor()` * `dlgProfilePreferences::setFgColor2()` ==> `dlgProfilePreferences::slot_setMapExitsColor()` * `dlgProfilePreferences::setFontSize()` ==> `dlgProfilePreferences::slot_setFontSize()` * `dlgProfilePreferences::setMapInfoBackground()` ==> `dlgProfilePreferences::slot_setMapInfoBgColor()` * `dlgProfilePreferences::setRoomBorderColor()` ==> `dlgProfilePreferences::slot_setMapRoomBorderColor()` * `dlgProfilePreferences::slot_script_selected(...)` ==> `dlgProfilePreferences::slot_scriptSelected(...)` * `dlgProfilePreferences::slot_theme_selected(...)` ==> `dlgProfilePreferences::slot_themeSelected(...)` * `dlgRoomSymbol::colorRejected()` ==> `dlgRoomSymbol::slot_colorRejected()` * `dlgRoomSymbol::colorSelected(...)` ==> `dlgRoomSymbol::slot_colorSelected(...)` * `dlgRoomSymbol::currentColorChanged(...)` ==> `dlgRoomSymbol::slot_currentColorChanged(...)` * `dlgRoomSymbol::openColorSelector()` ==> `dlgRoomSymbol::slot_openColorSelector()` * `dlgRoomSymbol::resetColor()` ==> `dlgRoomSymbol::slot_resetColors()` * `dlgRoomSymbol::updatePreview()` ==> `dlgRoomSymbol::slot_updatePreview()` * `dlgTriggerEditor::slot_show_vars()` ==> `dlgTriggerEditor::slot_showVariables()` * `dlgTriggerEditor::slot_var_changed(...)` ==> `dlgTriggerEditor::slot_variableChanged(...)` * `dlgTriggerEditor::slot_var_selected(...)` ==> `dlgTriggerEditor::slot_variableSelected(...)` * `mudlet::slot_check_manual_update()` ==> `mudlet::slot_manualUpdateCheck()` * `mudlet::slot_close_current_profile()` ==> `mudlet::slot_closeCurrentProfile()` * `mudlet::slot_close_profile_requested(...)` ==> `mudlet::slot_closeProfileRequested(...)` * `mudlet::slot_connection_dlg_finished(...)` ==> `mudlet::slot_connectionDialogueFinished(...)` * `mudlet::slot_module_manager()` ==> `mudlet::slot_moduleManager()` * `mudlet::slot_mudlet_discord()` ==> `mudlet::slot_mudletDiscord()` * `mudlet::slot_multi_view(...)` ==> `mudlet::slot_multiView(const bool state)` * `mudlet::slot_package_manager()` ==> `mudlet::slot_packageManager()` * `mudlet::slot_package_exporter()` ==> `mudlet::slot_packageExporter()` * `mudlet::slot_timer_fires()` ==> `mudlet::slot_timerFires()` * `mudlet::slot_toggle_multi_view()` ==> `mudlet::slot_toggleMultiView()` Also the names for these in particular have been changed to make more sense: * `dlgProfilePreferences::slot_chooseProfilesChanged()` ==> `dlgProfilePreferences::slot_chosenProfilesChanged()` * `dlgProfilePreferences::slot_editor_tab_selected(...)` ==> `dlgProfilePreferences::slot_tabChanged(...)` * `dlgProfilePreferences::slot_passwords_location_changed(...)` ==> `dlgProfilePreferences::slot_passwordStorageLocationChanged(...)` * `dlgProfilePreferences::slot_save_and_exit()` ==> `dlgProfilePreferences::slot_saveAndClose()` * `dlgTriggerEditor::slot_toggleHiddenVar(...)` ==> `dlgTriggerEditor::slot_hideVariable(...)` - changed to distinguish it from `slot_toggleHiddenVariables(...)` * `dlgTriggerEditor::slot_item_selected_save(...)` ==> `dlgTriggerEditor::slot_saveSelectedItem(...)` * `mudlet::slot_discord()` ==> `mudlet::slot_profileDiscord()` - changed to distinguish it from `slot_mudletDiscord()` Not currently used and commented out: * `dlgProfilePreferences::setCommandLineFont()` ==> `dlgProfilePreferences::slot_setCommandLineFont()` Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-08-29 14:27:13 +02:00
connect(autologin_checkBox, &QCheckBox::stateChanged, this, &dlgConnectionProfiles::slot_updateAutoConnect);
connect(auto_reconnect, &QCheckBox::stateChanged, this, &dlgConnectionProfiles::slot_updateAutoReconnect);
Fix reduce c++20warnings (#7638) #### Brief overview of PR changes/additions 1. Adds explicit ‘this’ or ‘*this’ capture to lambdas where required (not in static ones). 2. Rephrases some combinations of Qt `enum`s that whilst acceptable for C++17 upset the later one. For the non-key related ones which are provided a `int`s arguments to a method this is sufficient; For Qt 6 there are some additional methods that overcome the "incompatibility" of combining such different `enum`s but those have not been back ported to the Qt 5.15.8 I have - despite what https://bugreports.qt.io/browse/QTBUG-99948 says - so fixes for combining QKey and QKeyModifier have been left out of this PR. 3. Removes a couple of unused variables. 4. Adds our `qsl(...)` wrapper about some raw C-string literals used in a loop. 5. Rewrite part of the qmake project file so the logic and choices are correct. #### Motivation for adding to Mudlet 1. To eliminate the following type of warning when building with a C++20 compiler: "warning: implicit capture of ‘this’ via ‘[=]’ is deprecated in C++20 [-Wdeprecated]" 2. To eliminate the following type of warning when building with a C++20 compiler: * warning: bitwise operation between different enumeration types ‘QFont::Weight’ and ‘QFont::StyleHint’ is deprecated [-Wdeprecated-enum-enum-conversion] * warning: bitwise operation between different enumeration types ‘Qt::TextFlag’ and ‘Qt::AlignmentFlag’ is deprecated [-Wdeprecated-enum-enum-conversion] 3. To eliminate the following type of warning when building with a C++20 compiler: "warning: unused variable ‘pHost’ [-Wunused-variable]" 4. To eliminate the following type of warning when building with a C++20 compiler: "warning: loop variable ‘file’ of type ‘const QString&’ binds to a temporary constructed from type ‘const char* const’ [-Wrange-loop-construct]" 5. The previous logic was (incorrect) IF Qt Major version is less than 5 OR (if Qt Major version is less than 6 AND if Qt Minor version is less than 12)) THEN add `-std=c++20` to `QMAKE_CXXFLAGS` ELSE add `c++2a` to `CONFIG` This is borked because we have already rejected Qt versions less than 5.14 so the logic will **always** end up in the **ELSE** case, and whilst Qt 5.15 is documented as accepting `CONFIG += c++2a` (and `c++2b`) the earliest Qt 6.x version describes `c++2a` as an obsolete alias for `c++20` (in https://doc.qt.io/qt-6.2/qmake-variable-reference.html). #### Other info (issues closed, discussion etc) 3. The code in the `QFont` cases contains errors that have been copied from bogus QFont creation code going back to the very first (well second) commit in the git history. This contained calls of the form `QFont font("Courier New", 10, QFont::Courier)` however even the Qt 4.8 documentation does not list a constructor of that form but instead has: `QFont(const QString & family, int pointSize = -1, int weight = -1, bool italic = false)` the third argument could possibly be `QFont::Normal` (50) or `QFont::Bold` (75) however the value of `QFont::Courier` is `2` but it is for a completely different purpose, that of the font matching strategy ("the font matcher prefers fixed pitch fonts.") but that is not something that can be set as an argument to the font constructor! As it happens the combination of `QFont::Bold | QFont::Serif | QFont::PreferMatch | QFont::PreferAntialias` that was being used numerically equals 75 + 2 + 32 + 128 = 227 - and the scale that Qt actually uses only goes from 0 to 99! 5. This change makes the code match the comments! Overall all the changes in this PR means that https://github.com/Mudlet/Mudlet/pull/7613 is not required after all - at least for Mudlet's own code - though there are still some warnings from the edbee-lib sub-module. --------- Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2025-02-10 11:59:45 +00:00
#endif
Infrastructure: tidy up naming of SLOT methods and their usage - Part 2 (#6255) When Qt's slot/signal system is used to invoke a method there is some overhead - so it makes sense to ensure developers can spot all such methods (functions). We have tried to do this with a `slot_` prefix to the methods we create but it has not been applied uniformly. This PR (and one or more to follow) is intended to help with this by more rigorously doing so - the names changed herein should all follow a `slot_`*camelCaseMethodName* style. In addition some methods were detected that are not currently used or which are not actually used via the signal/slot system, these have been commented out or have had the prefix removed and the declaration in the relevant header file moved as appropriate. For reference the changes made are: * `TLuaInterpreter::slotDeleteSender(...)` ==> `TLuaInterpreter::slot_deleteSender(...)` * `TLuaInterpreter::slotPurge()` ==> `TLuaInterpreter::slot_purge()` * `cTelnet::handle_socket_signal_connected()` ==> `cTelnet::slot_socketConnected()` * `cTelnet::handle_socket_signal_disconnected()` ==> `cTelnet::slot_socketDisconnected()` * `cTelnet::handle_socket_signal_hostFound(...)` ==> `cTelnet::slot_socketHostFound(...)` * `cTelnet::handle_socket_signal_readyRead()` ==> `cTelnet::slot_socketReadyToBeRead()` * `cTelnet::handle_socket_signal_sslError(...)` ==> `cTelnet::slot_socketSslError(...)` * `cTelnet::setDownloadProgress(...)` ==> `cTelnet::slot_setDownloadProgress(...)` * `dlgComposer::cancel()` ==> `dlgComposer::slot_cancel()` * `dlgComposer::save()` ==> `dlgComposer::slot_save()` * `dlgConnectionProfiles::slot_item_clicked(...)` ==> `dlgConnectionProfiles::slot_itemClicked(...)` * `dlgConnectionProfiles::slot_save_name()` ==> `dlgConnectionProfiles::slot_saveName()` * `dlgConnectionProfiles::slot_update_login(...)` ==> `dlgConnectionProfiles::slot_updateLogin(...)` * `dlgConnectionProfiles::slot_update_name(...)` ==> `dlgConnectionProfiles::slot_updateName(...)` * `dlgConnectionProfiles::slot_update_pass(...)` ==> `dlgConnectionProfiles::slot_updatePassword(...)` * `dlgConnectionProfiles::slot_update_port(...)` ==> `dlgConnectionProfiles::slot_updatePort(...)` * `dlgConnectionProfiles::slot_update_SSL_TSL_port(...)` ==> `dlgConnectionProfiles::slot_updateSslTslPort(...)` * `dlgConnectionProfiles::slot_update_url(...)` ==> `dlgConnectionProfiles::slot_updateUrl(...)` * `dlgMapLabel::pickBgColor()` ==> `dlgMapLabel::slot_pickBgColor()` * `dlgMapLabel::pickFgColor()` ==> `dlgMapLabel::slot_pickFgColor()` * `dlgMapLabel::pickFile()` ==> `dlgMapLabel::slot_pickFile()` * `dlgMapLabel::pickFont()` ==> `dlgMapLabel::slot_pickFont()` * `dlgMapLabel::save()` ==> `dlgMapLabel::slot_save()` * `dlgMapLabel::updateControls()` ==> `dlgMapLabel::slot_updateControls()` * `dlgMapLabel::updateControlsVisibility()` ==> `dlgMapLabel::slot_updateControlsVisibility()` Commented out as not being used: * `cTelnet::handle_socket_signal_error()` ==> `cTelnet::slot_socketError()` * `dlgConnectionProfiles::slot_update_website(...) ==> `dlgConnectionProfiles::slot_updateWebsite(const QString& url)` I have my doubts about whether the `dlgMapLabel::save()`/`dlgMapLabel::slot_save()` method is needed at all, as it might be that the `QDialog::accept()` slot could have been inserted into the `QObject::connect(...)` call directly instead...? Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-08-27 10:47:01 +02:00
connect(login_entry, &QLineEdit::textEdited, this, &dlgConnectionProfiles::slot_updateLogin);
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
// Use textChanged with timer debouncing to avoid saving on every keystroke
connect(character_password_entry, &QLineEdit::textChanged, this, &dlgConnectionProfiles::slot_passwordTextChanged);
// Listen for password migration completion to refresh the form
connect(mudlet::self(), &mudlet::signal_passwordsMigratedToSecure, this, [this]() {
fix: show connection details when picking a game on a fresh install (#9451) #### Brief overview of PR changes/additions - Selecting a game on a first-ever launch now swaps the welcome message for the connection details and restores the dialog height - Programmatic selections (startup pre-selection, password-migration refreshes) still show the welcome message - Copying a pre-configured game now rebuilds the list and selects the copy with its details filled in #### Motivation for adding to Mudlet On a fresh install, clicking a game filled hidden fields and appeared to do nothing - a dead end for the very first thing a new user does. #### Other info (issues closed, discussion etc) Closes #3930 **Test case:** Fresh install (empty config dir) → connection dialog shows the welcome message → click any game → connection details appear filled in. Copy a pre-configured game → the copy appears in the list, selected, with editable details. https://github.com/user-attachments/assets/de6df8fa-e1f0-4564-91e8-c286bebdd791 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-22 05:02:00 +02:00
// Refresh the current profile's password field after migration; this
// is not the user picking a game so keep the welcome message up
mProgrammaticProfileSelection = true;
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
slot_itemClicked(listWidget_profiles->currentItem());
fix: show connection details when picking a game on a fresh install (#9451) #### Brief overview of PR changes/additions - Selecting a game on a first-ever launch now swaps the welcome message for the connection details and restores the dialog height - Programmatic selections (startup pre-selection, password-migration refreshes) still show the welcome message - Copying a pre-configured game now rebuilds the list and selects the copy with its details filled in #### Motivation for adding to Mudlet On a fresh install, clicking a game filled hidden fields and appeared to do nothing - a dead end for the very first thing a new user does. #### Other info (issues closed, discussion etc) Closes #3930 **Test case:** Fresh install (empty config dir) → connection dialog shows the welcome message → click any game → connection details appear filled in. Copy a pre-configured game → the copy appears in the list, selected, with editable details. https://github.com/user-attachments/assets/de6df8fa-e1f0-4564-91e8-c286bebdd791 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-22 05:02:00 +02:00
mProgrammaticProfileSelection = false;
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
});
Add a Mudlet Tutorial profile. (#8188) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Adds a Mudlet Tutorial profile which incorporates a basic GUI tutorial and mini-mud quest. GUI tutorial introduces the main window, command line, search bar, toolbar, map. Mini-quest attempts to act like a MUD. Teaches directional commands and some typical verbs (look, buy, give, get, open, close, quit) while the player wanders around trying to figure out the two 'quests' (buy the sheriff some lunch and find the librarian's lost ring). It is simplistic and more designed to show players how a mud 'feels and progresses' when playing rather than a full blown MUD school which most (all?) MUDs incorporate. #### Motivation for adding to Mudlet Help on-boarding new users. Destination 5.0. /claim #3072 helps #2823 #### Other info (issues closed, discussion etc) I purposefully left out triggers, scripting and all that stuff veteran players take for granted! This is supposed to be an on-boarding tutorial for NEW players, let's not overwhelm them. A link after successful completion of the game introduces the wiki Introduction page for more advanced topics. That said, any improvements or basic features you think are missing from either the GUI or Mud tutorials, let me know and I can add. https://github.com/user-attachments/assets/1d16db50-e24b-4e78-b6b0-66e0e98a0772
2025-09-13 14:17:13 +07:00
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
// Listen for character password migration completion to refresh the form
connect(mudlet::self(), &mudlet::signal_characterPasswordsMigrated, this, [this]() {
fix: show connection details when picking a game on a fresh install (#9451) #### Brief overview of PR changes/additions - Selecting a game on a first-ever launch now swaps the welcome message for the connection details and restores the dialog height - Programmatic selections (startup pre-selection, password-migration refreshes) still show the welcome message - Copying a pre-configured game now rebuilds the list and selects the copy with its details filled in #### Motivation for adding to Mudlet On a fresh install, clicking a game filled hidden fields and appeared to do nothing - a dead end for the very first thing a new user does. #### Other info (issues closed, discussion etc) Closes #3930 **Test case:** Fresh install (empty config dir) → connection dialog shows the welcome message → click any game → connection details appear filled in. Copy a pre-configured game → the copy appears in the list, selected, with editable details. https://github.com/user-attachments/assets/de6df8fa-e1f0-4564-91e8-c286bebdd791 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-22 05:02:00 +02:00
// Refresh the current profile's password field after migration; this
// is not the user picking a game so keep the welcome message up
mProgrammaticProfileSelection = true;
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
slot_itemClicked(listWidget_profiles->currentItem());
fix: show connection details when picking a game on a fresh install (#9451) #### Brief overview of PR changes/additions - Selecting a game on a first-ever launch now swaps the welcome message for the connection details and restores the dialog height - Programmatic selections (startup pre-selection, password-migration refreshes) still show the welcome message - Copying a pre-configured game now rebuilds the list and selects the copy with its details filled in #### Motivation for adding to Mudlet On a fresh install, clicking a game filled hidden fields and appeared to do nothing - a dead end for the very first thing a new user does. #### Other info (issues closed, discussion etc) Closes #3930 **Test case:** Fresh install (empty config dir) → connection dialog shows the welcome message → click any game → connection details appear filled in. Copy a pre-configured game → the copy appears in the list, selected, with editable details. https://github.com/user-attachments/assets/de6df8fa-e1f0-4564-91e8-c286bebdd791 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-22 05:02:00 +02:00
mProgrammaticProfileSelection = false;
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
});
Infrastructure: tidy up naming of SLOT methods and their usage - Part 5 (last) (#6266) When Qt's slot/signal system is used to invoke a method there is some overhead - so it makes sense to ensure developers can spot all such methods (functions). We have tried to do this with a `slot_` prefix to the methods we create but it has not been applied uniformly. This PR is intended to conclude helping with this by more rigorously doing so - the names changed herein should all follow a `slot_`*camelCaseMethodName* style. In addition some methods were detected that are not currently used or which are not actually used via the signal/slot system, these have been commented out or have had the prefix removed and the declaration in the relevant header file moved as appropriate. There were two similar sets of (not prefixed with `slot_`) slots in the Profile preferences class that adjusted the colour settings separately for the main console and the mapper the latter had the same names but with a `2` suffix. To made it more clear I have changed them to include `Map` in their names instead. Also, the NON-slot method: `(void) dlgProfilePreferences::setColor(QPushButton*, QColor&, bool)` has been renamed to: `(void) dlgProfilePreferences::setButtonAndProfileColor(QPushButton*, QColor&, bool)` so that it is clearly distinguishable from built in Qt methods that are also called `setColor` - though which do have different signatures! For reference the changes made are: * `TConsole::slot_stop_all_triggers(...)` ==> `TConsole::slot_stopAllItems(...)` * `dlgConnectionProfiles::slot_copy_profile()` ==> `dlgConnectionProfiles::slot_copyProfile()` * `dlgConnectionProfiles::slot_copy_profilesettings_only()` ==> `dlgConnectionProfiles::slot_copyOnlySettingsOfProfile()` * `dlgConnectionProfiles::slot_deleteprofile_check(...)` ==> `dlgConnectionProfiles::slot_deleteProfileCheck(...)` * `dlgConnectionProfiles::slot_password_deleted(...)` ==> `dlgConnectionProfiles::slot_passwordDeleted(...)` * `dlgConnectionProfiles::slot_password_saved(...) ==> `dlgConnectionProfiles::slot_passwordSaved(...)` * `dlgConnectionProfiles::slot_profile_menu(...)` ==> `dlgConnectionProfiles::slot_profileContextMenu(...)` * `dlgConnectionProfiles::slot_reset_custom_icon()` ==> `dlgConnectionProfiles::slot_resetCustomIcon()` * `dlgConnectionProfiles::slot_set_custom_icon()` ==> `dlgConnectionProfiles::slot_setCustomIcon()` * `dlgConnectionProfiles::slot_set_custom_color()` ==> `dlgConnectionProfiles::slot_setCustomColor()` * `dlgConnectionProfiles::slot_update_autologin(...)` ==> `dlgConnectionProfiles::slot_updateAutoConnect(...)` * `dlgConnectionProfiles::slot_update_autoreconnect(...)` ==> `dlgConnectionProfiles::slot_updateAutoReconnect(...)` * `dlgConnectionProfiles::slot_update_description()` ==> `dlgConnectionProfiles::slot_updateDescription()` * `dlgConnectionProfiles::slot_update_discord_optin(...)` ==> `dlgConnectionProfiles::slot_updateDiscordOptIn(...)` * `dlgProfilePreferences::copyMap()` ==> `dlgProfilePreferences::slot_copyMap()` * `dlgProfilePreferences::downloadMap()` ==> `dlgProfilePreferences::slot_downloadMap()` * `dlgProfilePreferences::hideActionLabel()` ==> `dlgProfilePreferences::slot_hideActionLabel()` * `dlgProfilePreferences::loadMap()` ==> `dlgProfilePreferences::slot_loadMap()` * `dlgProfilePreferences::resetColors()` ==> `dlgProfilePreferences::slot_resetColors()` * `dlgProfilePreferences::resetColors2()` ==> `dlgProfilePreferences::slot_resetMapColors()` * `dlgProfilePreferences::saveMap()` ==> `dlgProfilePreferences::slot_saveMap()` * `dlgProfilePreferences::setBgColor()` ==> `dlgProfilePreferences::slot_setBgColor()` * `dlgProfilePreferences::setBgColor2()` ==> `dlgProfilePreferences::slot_setMapBgColor()` * `dlgProfilePreferences::setColorBlack()` ==> `dlgProfilePreferences::slot_setColorBlack()` * `dlgProfilePreferences::setColorBlack2()` ==> `dlgProfilePreferences::slot_setMapColorBlack()` * `dlgProfilePreferences::setColorBlue()` ==> `dlgProfilePreferences::slot_setColorBlue()` * `dlgProfilePreferences::setColorCyan()` ==> `dlgProfilePreferences::slot_setColorCyan()` * `dlgProfilePreferences::setColorBlue2()` ==> `dlgProfilePreferences::slot_setMapColorBlue()` * `dlgProfilePreferences::setColorCyan2()` ==> `dlgProfilePreferences::slot_setMapColorCyan()` * `dlgProfilePreferences::setColorGreen()` ==> `dlgProfilePreferences::slot_setColorGreen()` * `dlgProfilePreferences::setColorGreen2()` ==> `dlgProfilePreferences::slot_setMapColorGreen()` * `dlgProfilePreferences::setColorLightBlack()` ==> `dlgProfilePreferences::slot_setColorLightBlack()` * `dlgProfilePreferences::setColorLightBlack2()` ==> `dlgProfilePreferences::slot_setMapColorLightBlack()` * `dlgProfilePreferences::setColorLightBlue()` ==> `dlgProfilePreferences::slot_setColorLightBlue()` * `dlgProfilePreferences::setColorLightBlue2()` ==> `dlgProfilePreferences::slot_setMapColorLightBlue()` * `dlgProfilePreferences::setColorLightCyan()` ==> `dlgProfilePreferences::slot_setColorLightCyan()` * `dlgProfilePreferences::setColorLightCyan2()` ==> `dlgProfilePreferences::slot_setMapColorLightCyan()` * `dlgProfilePreferences::setColorLightGreen()` ==> `dlgProfilePreferences::slot_setColorLightGreen()` * `dlgProfilePreferences::setColorLightGreen2()` ==> `dlgProfilePreferences::slot_setMapColorLightGreen()` * `dlgProfilePreferences::setColorLightMagenta()` ==> `dlgProfilePreferences::slot_setColorLightMagenta()` * `dlgProfilePreferences::setColorLightMagenta2()` ==> `dlgProfilePreferences::slot_setMapColorLightMagenta()` * `dlgProfilePreferences::setColorLightRed()` ==> `dlgProfilePreferences::slot_setColorLightRed()` * `dlgProfilePreferences::setColorLightRed2()` ==> `dlgProfilePreferences::slot_setMapColorLightRed()` * `dlgProfilePreferences::setColorLightWhite()` ==> `dlgProfilePreferences::slot_setColorLightWhite()` * `dlgProfilePreferences::setColorLightWhite2()` ==> `dlgProfilePreferences::slot_setMapColorLightWhite()` * `dlgProfilePreferences::setColorLightYellow()` ==> `dlgProfilePreferences::slot_setColorLightYellow()` * `dlgProfilePreferences::setColorLightYellow2()` ==> `dlgProfilePreferences::slot_setMapColorLightYellow()` * `dlgProfilePreferences::setColorMagenta()` ==> `dlgProfilePreferences::slot_setColorMagenta()` * `dlgProfilePreferences::setColorMagenta2()` ==> `dlgProfilePreferences::slot_setMapColorMagenta()` * `dlgProfilePreferences::setColorRed2()` ==> `dlgProfilePreferences::slot_setMapColorRed()` * `dlgProfilePreferences::setColorRed()` ==> `dlgProfilePreferences::slot_setColorRed()` * `dlgProfilePreferences::setColorWhite()` ==> `dlgProfilePreferences::slot_setColorWhite()` * `dlgProfilePreferences::setColorWhite2()` ==> `dlgProfilePreferences::slot_setMapColorWhite()` * `dlgProfilePreferences::setColorYellow()` ==> `dlgProfilePreferences::slot_setColorYellow()` * `dlgProfilePreferences::setColorYellow2()` ==> `dlgProfilePreferences::slot_setMapColorYellow()` * `dlgProfilePreferences::setCommandBgColor()` ==> `dlgProfilePreferences::slot_setCommandBgColor()` * `dlgProfilePreferences::setCommandFgColor()` ==> `dlgProfilePreferences::slot_setCommandFgColor()` * `dlgProfilePreferences::setCommandLineBgColor()` ==> `dlgProfilePreferences::slot_setCommandLineBgColor()` * `dlgProfilePreferences::setCommandLineFgColor()` ==> `dlgProfilePreferences::slot_setCommandLineFgColor()` * `dlgProfilePreferences::setDisplayFont()` ==> `dlgProfilePreferences::slot_setDisplayFont()` * `dlgProfilePreferences::setFgColor()` ==> `dlgProfilePreferences::slot_setFgColor()` * `dlgProfilePreferences::setFgColor2()` ==> `dlgProfilePreferences::slot_setMapExitsColor()` * `dlgProfilePreferences::setFontSize()` ==> `dlgProfilePreferences::slot_setFontSize()` * `dlgProfilePreferences::setMapInfoBackground()` ==> `dlgProfilePreferences::slot_setMapInfoBgColor()` * `dlgProfilePreferences::setRoomBorderColor()` ==> `dlgProfilePreferences::slot_setMapRoomBorderColor()` * `dlgProfilePreferences::slot_script_selected(...)` ==> `dlgProfilePreferences::slot_scriptSelected(...)` * `dlgProfilePreferences::slot_theme_selected(...)` ==> `dlgProfilePreferences::slot_themeSelected(...)` * `dlgRoomSymbol::colorRejected()` ==> `dlgRoomSymbol::slot_colorRejected()` * `dlgRoomSymbol::colorSelected(...)` ==> `dlgRoomSymbol::slot_colorSelected(...)` * `dlgRoomSymbol::currentColorChanged(...)` ==> `dlgRoomSymbol::slot_currentColorChanged(...)` * `dlgRoomSymbol::openColorSelector()` ==> `dlgRoomSymbol::slot_openColorSelector()` * `dlgRoomSymbol::resetColor()` ==> `dlgRoomSymbol::slot_resetColors()` * `dlgRoomSymbol::updatePreview()` ==> `dlgRoomSymbol::slot_updatePreview()` * `dlgTriggerEditor::slot_show_vars()` ==> `dlgTriggerEditor::slot_showVariables()` * `dlgTriggerEditor::slot_var_changed(...)` ==> `dlgTriggerEditor::slot_variableChanged(...)` * `dlgTriggerEditor::slot_var_selected(...)` ==> `dlgTriggerEditor::slot_variableSelected(...)` * `mudlet::slot_check_manual_update()` ==> `mudlet::slot_manualUpdateCheck()` * `mudlet::slot_close_current_profile()` ==> `mudlet::slot_closeCurrentProfile()` * `mudlet::slot_close_profile_requested(...)` ==> `mudlet::slot_closeProfileRequested(...)` * `mudlet::slot_connection_dlg_finished(...)` ==> `mudlet::slot_connectionDialogueFinished(...)` * `mudlet::slot_module_manager()` ==> `mudlet::slot_moduleManager()` * `mudlet::slot_mudlet_discord()` ==> `mudlet::slot_mudletDiscord()` * `mudlet::slot_multi_view(...)` ==> `mudlet::slot_multiView(const bool state)` * `mudlet::slot_package_manager()` ==> `mudlet::slot_packageManager()` * `mudlet::slot_package_exporter()` ==> `mudlet::slot_packageExporter()` * `mudlet::slot_timer_fires()` ==> `mudlet::slot_timerFires()` * `mudlet::slot_toggle_multi_view()` ==> `mudlet::slot_toggleMultiView()` Also the names for these in particular have been changed to make more sense: * `dlgProfilePreferences::slot_chooseProfilesChanged()` ==> `dlgProfilePreferences::slot_chosenProfilesChanged()` * `dlgProfilePreferences::slot_editor_tab_selected(...)` ==> `dlgProfilePreferences::slot_tabChanged(...)` * `dlgProfilePreferences::slot_passwords_location_changed(...)` ==> `dlgProfilePreferences::slot_passwordStorageLocationChanged(...)` * `dlgProfilePreferences::slot_save_and_exit()` ==> `dlgProfilePreferences::slot_saveAndClose()` * `dlgTriggerEditor::slot_toggleHiddenVar(...)` ==> `dlgTriggerEditor::slot_hideVariable(...)` - changed to distinguish it from `slot_toggleHiddenVariables(...)` * `dlgTriggerEditor::slot_item_selected_save(...)` ==> `dlgTriggerEditor::slot_saveSelectedItem(...)` * `mudlet::slot_discord()` ==> `mudlet::slot_profileDiscord()` - changed to distinguish it from `slot_mudletDiscord()` Not currently used and commented out: * `dlgProfilePreferences::setCommandLineFont()` ==> `dlgProfilePreferences::slot_setCommandLineFont()` Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-08-29 14:27:13 +02:00
connect(mud_description_textedit, &QPlainTextEdit::textChanged, this, &dlgConnectionProfiles::slot_updateDescription);
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
connect(listWidget_profiles, &QListWidget::currentItemChanged, this, &dlgConnectionProfiles::slot_itemClicked);
fix: show connection details when picking a game on a fresh install (#9451) #### Brief overview of PR changes/additions - Selecting a game on a first-ever launch now swaps the welcome message for the connection details and restores the dialog height - Programmatic selections (startup pre-selection, password-migration refreshes) still show the welcome message - Copying a pre-configured game now rebuilds the list and selects the copy with its details filled in #### Motivation for adding to Mudlet On a fresh install, clicking a game filled hidden fields and appeared to do nothing - a dead end for the very first thing a new user does. #### Other info (issues closed, discussion etc) Closes #3930 **Test case:** Fresh install (empty config dir) → connection dialog shows the welcome message → click any game → connection details appear filled in. Copy a pre-configured game → the copy appears in the list, selected, with editable details. https://github.com/user-attachments/assets/de6df8fa-e1f0-4564-91e8-c286bebdd791 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-22 05:02:00 +02:00
// clicking the item that is already current (a profile gets pre-selected
// before the dialog is shown) does not change the current item, so it
// still needs to reveal the connection details on a fresh install
connect(listWidget_profiles, &QListWidget::itemClicked, this, &dlgConnectionProfiles::revealConnectionDetails);
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
connect(listWidget_profiles, &QListWidget::itemDoubleClicked, this, &dlgConnectionProfiles::accept);
misc
2010-03-15 09:37:16 +01:00
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
// website_entry atm is only a label
Infrastructure: tidy up naming of SLOT methods and their usage - Part 2 (#6255) When Qt's slot/signal system is used to invoke a method there is some overhead - so it makes sense to ensure developers can spot all such methods (functions). We have tried to do this with a `slot_` prefix to the methods we create but it has not been applied uniformly. This PR (and one or more to follow) is intended to help with this by more rigorously doing so - the names changed herein should all follow a `slot_`*camelCaseMethodName* style. In addition some methods were detected that are not currently used or which are not actually used via the signal/slot system, these have been commented out or have had the prefix removed and the declaration in the relevant header file moved as appropriate. For reference the changes made are: * `TLuaInterpreter::slotDeleteSender(...)` ==> `TLuaInterpreter::slot_deleteSender(...)` * `TLuaInterpreter::slotPurge()` ==> `TLuaInterpreter::slot_purge()` * `cTelnet::handle_socket_signal_connected()` ==> `cTelnet::slot_socketConnected()` * `cTelnet::handle_socket_signal_disconnected()` ==> `cTelnet::slot_socketDisconnected()` * `cTelnet::handle_socket_signal_hostFound(...)` ==> `cTelnet::slot_socketHostFound(...)` * `cTelnet::handle_socket_signal_readyRead()` ==> `cTelnet::slot_socketReadyToBeRead()` * `cTelnet::handle_socket_signal_sslError(...)` ==> `cTelnet::slot_socketSslError(...)` * `cTelnet::setDownloadProgress(...)` ==> `cTelnet::slot_setDownloadProgress(...)` * `dlgComposer::cancel()` ==> `dlgComposer::slot_cancel()` * `dlgComposer::save()` ==> `dlgComposer::slot_save()` * `dlgConnectionProfiles::slot_item_clicked(...)` ==> `dlgConnectionProfiles::slot_itemClicked(...)` * `dlgConnectionProfiles::slot_save_name()` ==> `dlgConnectionProfiles::slot_saveName()` * `dlgConnectionProfiles::slot_update_login(...)` ==> `dlgConnectionProfiles::slot_updateLogin(...)` * `dlgConnectionProfiles::slot_update_name(...)` ==> `dlgConnectionProfiles::slot_updateName(...)` * `dlgConnectionProfiles::slot_update_pass(...)` ==> `dlgConnectionProfiles::slot_updatePassword(...)` * `dlgConnectionProfiles::slot_update_port(...)` ==> `dlgConnectionProfiles::slot_updatePort(...)` * `dlgConnectionProfiles::slot_update_SSL_TSL_port(...)` ==> `dlgConnectionProfiles::slot_updateSslTslPort(...)` * `dlgConnectionProfiles::slot_update_url(...)` ==> `dlgConnectionProfiles::slot_updateUrl(...)` * `dlgMapLabel::pickBgColor()` ==> `dlgMapLabel::slot_pickBgColor()` * `dlgMapLabel::pickFgColor()` ==> `dlgMapLabel::slot_pickFgColor()` * `dlgMapLabel::pickFile()` ==> `dlgMapLabel::slot_pickFile()` * `dlgMapLabel::pickFont()` ==> `dlgMapLabel::slot_pickFont()` * `dlgMapLabel::save()` ==> `dlgMapLabel::slot_save()` * `dlgMapLabel::updateControls()` ==> `dlgMapLabel::slot_updateControls()` * `dlgMapLabel::updateControlsVisibility()` ==> `dlgMapLabel::slot_updateControlsVisibility()` Commented out as not being used: * `cTelnet::handle_socket_signal_error()` ==> `cTelnet::slot_socketError()` * `dlgConnectionProfiles::slot_update_website(...) ==> `dlgConnectionProfiles::slot_updateWebsite(const QString& url)` I have my doubts about whether the `dlgMapLabel::save()`/`dlgMapLabel::slot_save()` method is needed at all, as it might be that the `QDialog::accept()` slot could have been inserted into the `QObject::connect(...)` call directly instead...? Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-08-27 10:47:01 +02:00
//connect(website_entry, SIGNAL(textEdited(const QString)), this, SLOT(slot_updateWebsite(const QString)));
misc
2010-03-15 09:37:16 +01:00
Enhance: remove minuscule text from under profile icons (#4712) This finally enables us to do away with the text under the profile icons as it replicates the normal `QListWidget` behaviour to move the selection to each item which begins with the first letter of the key pressed. This also makes the non-matching profiles get disabled which I think makes the action more obvious... Revised to include a timeout on concatenating keypresses: This is to provide the same functionality that the QListWidget does for keypresses, if the keys are typed fast enough they are concatenated to form the text to search for. However if the user types slower than this then the individual keys are only considered on their own. This reflects what both Vadim and I experienced - in that he was typing fast enough to spell out a particular profile but I wasn't and so the profile that I was having selected was changing on each keypress. The time between keypresses allowed so that they can be concatenated I have set to be 1 second. This is significantly slower that the Qt code but it is long enough to permit the temporary disablement of non-matching profiles to be a useful visual feedback - and besides, it makes it easier to specify one of a number of profiles with a common initial text - the longer the timeout the more keys the user can string together! Add `std::chrono` so we can give a time delay as `1s` instead of `1000` mS. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2021-02-03 19:59:35 +00:00
clearNotificationArea();
misc
2010-03-15 09:37:16 +01:00
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
#if !defined(QT_NO_SSL)
if (QSslSocket::supportsSsl()) {
port_ssl_tsl->setEnabled(true);
BugFix: fix broken compilation when QT_NO_SSL defined (#3569) `mudlet.h` needs the include for `QDir` if `Q_NO_SSL` is defined (might happen on, particularly, Windows builds) - I did not test whether it is a problem only if the updater is excluded or not... I also found a BUG in Qt Creator which meant that code marked with `#ifndef ...` was not being correctly grey-ed out in that editor. I have reported THAT upstream as: https://bugreports.qt.io/browse/QTCREATORBUG-23817 and have switched the Mudlet code-base to use `#if !defined(...)` instead. From previous recent experience with CodeFactor I was aware that it does not like lines where there are `else`s with a miss-matching `{` or `}` either side of them so I have put in or rearranged some `#if ... #endif` extra stuff to provide the balancing things needed. Unfortunately there is also an `#ifndef ...` as part of the *include-guard* in every Mudlet class header file - but I will leave changing those files to another occasion! Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2020-04-13 15:56:56 +01:00
} else {
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
#endif
port_ssl_tsl->setEnabled(false);
BugFix: fix broken compilation when QT_NO_SSL defined (#3569) `mudlet.h` needs the include for `QDir` if `Q_NO_SSL` is defined (might happen on, particularly, Windows builds) - I did not test whether it is a problem only if the updater is excluded or not... I also found a BUG in Qt Creator which meant that code marked with `#ifndef ...` was not being correctly grey-ed out in that editor. I have reported THAT upstream as: https://bugreports.qt.io/browse/QTCREATORBUG-23817 and have switched the Mudlet code-base to use `#if !defined(...)` instead. From previous recent experience with CodeFactor I was aware that it does not like lines where there are `else`s with a miss-matching `{` or `}` either side of them so I have put in or rearranged some `#if ... #endif` extra stuff to provide the balancing things needed. Unfortunately there is also an `#ifndef ...` as part of the *include-guard* in every Mudlet class header file - but I will leave changing those files to another occasion! Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2020-04-13 15:56:56 +01:00
#if !defined(QT_NO_SSL)
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
}
BugFix: fix broken compilation when QT_NO_SSL defined (#3569) `mudlet.h` needs the include for `QDir` if `Q_NO_SSL` is defined (might happen on, particularly, Windows builds) - I did not test whether it is a problem only if the updater is excluded or not... I also found a BUG in Qt Creator which meant that code marked with `#ifndef ...` was not being correctly grey-ed out in that editor. I have reported THAT upstream as: https://bugreports.qt.io/browse/QTCREATORBUG-23817 and have switched the Mudlet code-base to use `#if !defined(...)` instead. From previous recent experience with CodeFactor I was aware that it does not like lines where there are `else`s with a miss-matching `{` or `}` either side of them so I have put in or rearranged some `#if ... #endif` extra stuff to provide the balancing things needed. Unfortunately there is also an `#ifndef ...` as part of the *include-guard* in every Mudlet class header file - but I will leave changing those files to another occasion! Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2020-04-13 15:56:56 +01:00
#endif
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
Dark mode improvement for connection dialog (#4534) * dark mode improvement * adjust colors a bit * fix error color * use default palette for regular input Co-authored-by: Piotr Wilczynski <piotr.wilczynski@bisnode.com>
2020-12-29 08:54:19 +01:00
mReadOnlyPalette.setColor(QPalette::Base, QColor(125, 125, 125, 25));
mOKPalette.setColor(QPalette::Base, QColor(150, 255, 150, 50));
mErrorPalette.setColor(QPalette::Base, QColor(255, 150, 150, 50));
misc
2010-03-15 09:37:16 +01:00
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
listWidget_profiles->setViewMode(QListView::IconMode);
Revise: try and identify profiles and some controls in connection dialog (#3966) Also convert all `setDisabled(state)` to `setEnabled(!state)` in the `dlgConnectionProfiles` class - using a single one instead of a mix of the two is less likely to lead to errors - and it means less effort to search for the places where something is being enabled or disabled. Shorten some overlong variable names. Remove some capitalisations. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2020-08-13 00:57:17 +01:00
btn_load_enabled_accessDesc = tr("Click to load but not connect the selected profile.");
btn_connect_enabled_accessDesc = tr("Click to load and connect the selected profile.");
btn_connOrLoad_disabled_accessDesc = tr("Need to have a valid profile name, game server address and port before this button can be enabled.");
Revise: minor change post PR #3966 Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2020-08-14 18:07:22 +01:00
item_profile_accessName = tr("Game name: %1");
Infrastructure: update tr() annotation style (#6862) #### Brief overview of PR changes/additions Update the tr() annotation style, as discussed in #5522 #### Motivation for adding to Mudlet Makes the code cleaner and also keeps Mudlet in tune with the latest standards. #### Other info (issues closed, discussion etc) /claim #5522 --------- Co-authored-by: TachyonicBytes <support@tachyonicbytes.com> Co-authored-by: Stephen Lyons <slysven@virginmedia.com>
2023-05-29 22:03:34 +03:00
//: Some text to speech engines will spell out initials like MUD so stick to lower case if that is a better option
item_profile_accessDesc = tr("Button to select a mud game to play, double-click it to connect and start playing it.");
Revise: select profiles by typing the name, keep profile icons (#4440) Restore the text display of the profile name. This is so that the keyboard selection of profiles beginning with a particular letter works again. This will close issue #4283 . This also sets it to the minimum size trying to hide it by setting the font size to 1 - however that still show something (and a font size of zero is NOT valid). Manipulating the QPalette of the QListWidget does not work well enough in the presence of Styles or StyleSheets to be a viable means of hiding the text either. Also in the `dlgConnection` class: * refactor out some highly repetitive code that sets up the predefined Mud icons. * remove warnings and adopts a change introduced into Qt 5.15 for the QLabel::pixmap() which now requires a Qt::ReturnByValue argument to prevent an obsolete code warning and to force a QPixmap to be returned by value and not reference... * remove a warning about: QListWidget::setItemSelected(QListWidgetItem*,bool) being deprecated and switches to the recommended: QListWidgetItem::setSelected(bool) Edit: the last item above may have become redundant as further commits amalgamated into this PR may have taken out these lines anyhow! Change the custom icon generator so that there is NOT a dependency on the position in the list for the colours used. This means that the same name will always have the same colours - which will help the user to pick out a particular profile as it will always look the same no matter if other profiles are added or removed. Remove the colour gradient in the custom icon as it is not thought to be useful nowadays. Refactor out the colour icon generator to a single method that is called from more than one place. BugFix: restore odd original way of accessing some QPixmaps This was causing failures in some CI platforms using Qt 5.14. or older. Revise: really frob the custom icon generator This is to try and produce as varied but still readable icons when they are generated entirely on the basis of the MUD name - in a reproducible (though Qt do NOT guarantee repeatable qHash() functionality across Qt versions - so they may not stay *that* constant) manner. Refrob: use a table of fixed colours Using only 15 hues but with 3 different saturation level plus 5 grey-scale one should give enough different icons but not generate them too close to each other for those with normal colour vision... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Kebap <kebap_spam@gmx.net>
2020-12-11 17:53:28 +00:00
// Set up some initial black/white/greys:
Add ability to define custom color in profile buttons in connection dialog (#5365)
2021-08-13 07:22:24 +02:00
mCustomIconColors = {{QColor(0, 0, 0)}, {QColor(63, 63, 63)}, {QColor(128, 128, 128)}, {QColor(192, 192, 192)}, {QColor(255, 255, 255)}};
Revise: select profiles by typing the name, keep profile icons (#4440) Restore the text display of the profile name. This is so that the keyboard selection of profiles beginning with a particular letter works again. This will close issue #4283 . This also sets it to the minimum size trying to hide it by setting the font size to 1 - however that still show something (and a font size of zero is NOT valid). Manipulating the QPalette of the QListWidget does not work well enough in the presence of Styles or StyleSheets to be a viable means of hiding the text either. Also in the `dlgConnection` class: * refactor out some highly repetitive code that sets up the predefined Mud icons. * remove warnings and adopts a change introduced into Qt 5.15 for the QLabel::pixmap() which now requires a Qt::ReturnByValue argument to prevent an obsolete code warning and to force a QPixmap to be returned by value and not reference... * remove a warning about: QListWidget::setItemSelected(QListWidgetItem*,bool) being deprecated and switches to the recommended: QListWidgetItem::setSelected(bool) Edit: the last item above may have become redundant as further commits amalgamated into this PR may have taken out these lines anyhow! Change the custom icon generator so that there is NOT a dependency on the position in the list for the colours used. This means that the same name will always have the same colours - which will help the user to pick out a particular profile as it will always look the same no matter if other profiles are added or removed. Remove the colour gradient in the custom icon as it is not thought to be useful nowadays. Refactor out the colour icon generator to a single method that is called from more than one place. BugFix: restore odd original way of accessing some QPixmaps This was causing failures in some CI platforms using Qt 5.14. or older. Revise: really frob the custom icon generator This is to try and produce as varied but still readable icons when they are generated entirely on the basis of the MUD name - in a reproducible (though Qt do NOT guarantee repeatable qHash() functionality across Qt versions - so they may not stay *that* constant) manner. Refrob: use a table of fixed colours Using only 15 hues but with 3 different saturation level plus 5 grey-scale one should give enough different icons but not generate them too close to each other for those with normal colour vision... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Kebap <kebap_spam@gmx.net>
2020-12-11 17:53:28 +00:00
// Add some color ones with evenly spaced hue
for (quint16 i = 0; i < 360; i += 24) {
Refactor: insert change suggested by Leris/Kebap but missed off (#4463) This should have gone into #4440 but I clicked "Squash-and-merge" before I realised I hadn't accepted this web-review-based suggestion. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Kebap <kebap_spam@gmx.net>
2020-12-11 23:12:11 +00:00
mCustomIconColors.append(QColor::fromHsv(i, 255, 255));
mCustomIconColors.append(QColor::fromHsv(i, 192, 255));
mCustomIconColors.append(QColor::fromHsv(i, 128, 255));
Revise: select profiles by typing the name, keep profile icons (#4440) Restore the text display of the profile name. This is so that the keyboard selection of profiles beginning with a particular letter works again. This will close issue #4283 . This also sets it to the minimum size trying to hide it by setting the font size to 1 - however that still show something (and a font size of zero is NOT valid). Manipulating the QPalette of the QListWidget does not work well enough in the presence of Styles or StyleSheets to be a viable means of hiding the text either. Also in the `dlgConnection` class: * refactor out some highly repetitive code that sets up the predefined Mud icons. * remove warnings and adopts a change introduced into Qt 5.15 for the QLabel::pixmap() which now requires a Qt::ReturnByValue argument to prevent an obsolete code warning and to force a QPixmap to be returned by value and not reference... * remove a warning about: QListWidget::setItemSelected(QListWidgetItem*,bool) being deprecated and switches to the recommended: QListWidgetItem::setSelected(bool) Edit: the last item above may have become redundant as further commits amalgamated into this PR may have taken out these lines anyhow! Change the custom icon generator so that there is NOT a dependency on the position in the list for the colours used. This means that the same name will always have the same colours - which will help the user to pick out a particular profile as it will always look the same no matter if other profiles are added or removed. Remove the colour gradient in the custom icon as it is not thought to be useful nowadays. Refactor out the colour icon generator to a single method that is called from more than one place. BugFix: restore odd original way of accessing some QPixmaps This was causing failures in some CI platforms using Qt 5.14. or older. Revise: really frob the custom icon generator This is to try and produce as varied but still readable icons when they are generated entirely on the basis of the MUD name - in a reproducible (though Qt do NOT guarantee repeatable qHash() functionality across Qt versions - so they may not stay *that* constant) manner. Refrob: use a table of fixed colours Using only 15 hues but with 3 different saturation level plus 5 grey-scale one should give enough different icons but not generate them too close to each other for those with normal colour vision... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Kebap <kebap_spam@gmx.net>
2020-12-11 17:53:28 +00:00
}
Enhance: remove minuscule text from under profile icons (#4712) This finally enables us to do away with the text under the profile icons as it replicates the normal `QListWidget` behaviour to move the selection to each item which begins with the first letter of the key pressed. This also makes the non-matching profiles get disabled which I think makes the action more obvious... Revised to include a timeout on concatenating keypresses: This is to provide the same functionality that the QListWidget does for keypresses, if the keys are typed fast enough they are concatenated to form the text to search for. However if the user types slower than this then the individual keys are only considered on their own. This reflects what both Vadim and I experienced - in that he was typing fast enough to spell out a particular profile but I wasn't and so the profile that I was having selected was changing on each keypress. The time between keypresses allowed so that they can be concatenated I have set to be 1 second. This is significantly slower that the Qt code but it is long enough to permit the temporary disablement of non-matching profiles to be a useful visual feedback - and besides, it makes it easier to specify one of a number of profiles with a common initial text - the longer the timeout the more keys the user can string together! Add `std::chrono` so we can give a time delay as `1s` instead of `1000` mS. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2021-02-03 19:59:35 +00:00
mSearchTextTimer.setInterval(1s);
mSearchTextTimer.setSingleShot(true);
QCoreApplication::instance()->installEventFilter(this);
connect(&mSearchTextTimer, &QTimer::timeout, this, &dlgConnectionProfiles::slot_reenableAllProfileItems);
Fix: Unshrink list of profile history (#8313) #### Brief overview of PR changes/additions Increase the width _of the list popup items_ in connection window to allow for long texts in profile history. #### Motivation for adding to Mudlet Better UI. <img width="794" height="437" alt="grafik" src="https://github.com/user-attachments/assets/170ddbb1-72c6-4773-b6e5-3cfaa77527ce" /> #### Other info (issues closed, discussion etc) Fix #8300 Alternative to #8308
2025-11-03 11:09:42 +01:00
profile_history->view()->setTextElideMode(Qt::ElideNone);
Enhance: remove minuscule text from under profile icons (#4712) This finally enables us to do away with the text under the profile icons as it replicates the normal `QListWidget` behaviour to move the selection to each item which begins with the first letter of the key pressed. This also makes the non-matching profiles get disabled which I think makes the action more obvious... Revised to include a timeout on concatenating keypresses: This is to provide the same functionality that the QListWidget does for keypresses, if the keys are typed fast enough they are concatenated to form the text to search for. However if the user types slower than this then the individual keys are only considered on their own. This reflects what both Vadim and I experienced - in that he was typing fast enough to spell out a particular profile but I wasn't and so the profile that I was having selected was changing on each keypress. The time between keypresses allowed so that they can be concatenated I have set to be 1 second. This is significantly slower that the Qt code but it is long enough to permit the temporary disablement of non-matching profiles to be a useful visual feedback - and besides, it makes it easier to specify one of a number of profiles with a common initial text - the longer the timeout the more keys the user can string together! Add `std::chrono` so we can give a time delay as `1s` instead of `1000` mS. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2021-02-03 19:59:35 +00:00
}
dlgConnectionProfiles::~dlgConnectionProfiles()
{
infrastructure: make windows safe to destroy while a field has the text cursor (#9596) #### Brief overview of PR changes/additions - New `utils::disconnectChildSignals()`, called by the destructors of the connection dialog, the preferences and the editor: a window stops listening to its own widgets before it goes away. - Covers the reported case (connection dialog `Profile name` field) plus the same exposure found in the preferences (MMCP chat name, shortcut editors) and the editor (item name, command, pattern and sound file fields). The preferences and the editor had no destructor at all before this. - New `DialogTeardownTest` covering all three windows, plus a canary that fails if a future Qt stops emitting the focus-out signals the whole thing rests on. #### Motivation for adding to Mudlet Destroying one of these windows while the text cursor sits in one of its fields aborts the run - which is how #9574 turned up, in a functional test - and the windows should simply be safe to destroy, rather than safe only along the `close()` paths that happen to hide them first. #### Other info (issues closed, discussion etc) Closes #9574. The mechanism: a visible window is taken off the screen while its base-class destructors unwind (`~QDialog` hides it, `~QWidget` closes any other window class). That moves the keyboard focus off the field holding it, the field reports `editingFinished()`, and Qt delivers that to a slot of an object whose derived part is already gone: ``` ASSERT failure in dlgConnectionProfiles: "Called object is not of the correct type (class destructor may have already run)" ``` **How much of this can a player hit today: as far as I can trace, none of it**, which is why there are no crash reports behind this: - Every production teardown goes through `close()` / `accept()` / `reject()` first, and that hide happens while the object is still whole - so the field's `editingFinished()` is delivered normally and the edit is saved, exactly as before. `Host::closeChildren()` closes the editor that way, `mudlet::closeEvent()` closes the connection dialog that way. - Nothing `delete`s or `deleteLater()`s these three windows directly. - At exit `main()` deletes the QApplication, which destroys platform windows without running widget destructors, so the preferences dialog - the one window nothing explicitly closes - is never destructed either. - The assert is a `Q_ASSERT_X`, and since we never set `CMAKE_BUILD_TYPE`, Qt defines `QT_NO_DEBUG` for our builds and compiles it out. A shipped build would not abort at that point; it would run the slot against destroyed members instead, which is undefined behaviour that can quietly rename a profile or a trigger. So this is a latent trap rather than a live player crash: it fires today in the test suite, and it fires the moment any future code destroys one of these windows while it is on screen. The fix is small enough to be worth taking on those terms. Verified with standalone Qt probes: `QLineEdit` emits once anything has written to it (`setText()` is enough, even with an empty string), `QAbstractSpinBox` and `QKeySequenceEdit` emit unconditionally, and plain child widgets such as the editor's `dlg*MainArea` panels are not exposed - their slots still run while they are alive. `test/functional_tests/DialogTeardownTest.cpp` is formatted with the repo's clang-format, which the older tests next to it predate. **Test case:** `ctest -R DialogTeardownTest`. All three cases abort on `development` with the assert above and pass here. There is no manual GUI reproduction - see the tracing above.
2026-08-03 11:40:11 +02:00
// ~QDialog hides the dialog once this destructor is done, and the profile
// name field reacts to losing the focus by emitting editingFinished() into
// slot_saveName() when this object is no longer a valid receiver (#9574)
utils::disconnectChildSignals(this);
Fix: Restore password loading from portable file in connection dialog (#8993) #### Brief overview of PR changes/additions Restores the ability for the connection dialog to load saved passwords from the portable password file on disk, which stopped working after PR #7956 introduced secure credential management. #### Motivation for adding to Mudlet After #7956, users who had passwords saved in the old portable file format (`~/.config/mudlet/profiles/<name>/password`) could no longer see their passwords pre-filled when selecting a profile in the connection dialog. This affected users who had not yet migrated to the system keychain. The fix ensures all three password sources are checked in order: system keychain, QSettings, and finally the portable file on disk. It also moves the password migration step to run before the connection dialog opens, so passwords are migrated in time to be found. Includes the profile password collision fix from #8948 and adds new unit tests for the password migration and fallback paths. #### Other info (issues closed, discussion etc) Reported by @SlySven — PR #7956 (commit 79ab7be4) broke password loading for profiles that only had passwords in the portable file. --------- Co-authored-by: Stephen Lyons <slysven@virginmedia.com>
2026-03-08 09:38:15 -04:00
if (mPasswordSaveTimer) {
mPasswordSaveTimer->stop();
}
mPendingPasswordSaveProfile.clear();
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
// Clear any pending operation flags
mKeychainOperationInProgress = false;
mPendingProfileLoad.clear();
Add a Mudlet Tutorial profile. (#8188) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Adds a Mudlet Tutorial profile which incorporates a basic GUI tutorial and mini-mud quest. GUI tutorial introduces the main window, command line, search bar, toolbar, map. Mini-quest attempts to act like a MUD. Teaches directional commands and some typical verbs (look, buy, give, get, open, close, quit) while the player wanders around trying to figure out the two 'quests' (buy the sheriff some lunch and find the librarian's lost ring). It is simplistic and more designed to show players how a mud 'feels and progresses' when playing rather than a full blown MUD school which most (all?) MUDs incorporate. #### Motivation for adding to Mudlet Help on-boarding new users. Destination 5.0. /claim #3072 helps #2823 #### Other info (issues closed, discussion etc) I purposefully left out triggers, scripting and all that stuff veteran players take for granted! This is supposed to be an on-boarding tutorial for NEW players, let's not overwhelm them. A link after successful completion of the game introduces the wiki Introduction page for more advanced topics. That said, any improvements or basic features you think are missing from either the GUI or Mud tutorials, let me know and I can add. https://github.com/user-attachments/assets/1d16db50-e24b-4e78-b6b0-66e0e98a0772
2025-09-13 14:17:13 +07:00
Add `telnet://` URI scheme support for one-click MUD connections (#8601) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions ## Summary Implements full support for `telnet://` links in Mudlet, allowing users to connect to MUD servers with a single click from browsers or other applications. ## Usage Example Users can now click links like: ```html <a href="telnet://aardmud.org:4000">Play Aardwolf MUD</a> <a href="telnet://batmud.bat.org">Connect to BatMUD</a> ``` Or run from command line: ```bash mudlet "telnet://testserver.com:2000" ``` Mudlet will: 1. Parse the URI 2. Find or create a matching profile 3. Auto-connect to the MUD server ### TESTING I ran it on WEB and it worked fine. I ran it from command line, it worked fine HERE IS A DEMO VIDEO : https://github.com/user-attachments/assets/143cc98a-3453-4bd9-bbe8-5b48c58db490 #### Motivation for adding to Mudlet The bounty and to improve myself and contribute #### Other info (issues closed, discussion etc) /closes #689 /claim #689 #### CHECKLIST: [x] Windows [x] Linux [x] macOS --------- Co-authored-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Mike Conley <sousesider@gmail.com>
2026-04-04 07:35:02 +01:00
// Check if QCoreApplication is still valid during shutdown
if (QCoreApplication::instance()) {
QCoreApplication::instance()->removeEventFilter(this);
}
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
}
misc
2010-03-15 09:37:16 +01:00
add: Show tutorial invitation on first launch (#9169) #### Brief overview of PR changes/additions - On first launch (no existing profiles), show a focused tutorial invitation instead of the full games list - "Start Tutorial" link launches the Mudlet Tutorial profile directly - "Skip - show me the games list" button reveals the full connection dialog with the tutorial profile preselected - Make the Connect button the dialog's explicit default so Enter in the connection form always means "Connect" (see below) #### Motivation for adding to Mudlet New users currently face a wall of 20+ unknown game names with no guidance - a focused tutorial invitation improves first-time retention by teaching basics before choosing a game. #### Other info (issues closed, discussion etc) https://github.com/user-attachments/assets/2eeb3cb9-f596-4744-b187-24e1fc785246 --- Squash-merge trailers: ``` Assisted-by: Claude:claude-fable-5 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org> ``` --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com> Co-authored-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-18 10:54:52 +02:00
// Restores the widgets that the first-launch tutorial invitation hides, so
// every path out of the invitation (Skip button, New profile) leaves the
// dialog in its regular state:
void dlgConnectionProfiles::dismissTutorialInvitation()
{
mTutorialDismissed = true;
improve: make the New profile button show what it did (#9607) #### Brief overview of PR changes/additions - Clicking New now shows the new profile at the top of the list with an icon, selected and scrolled into view - The profile selection window no longer grows a little every time it switches views - Skipping the tutorial invitation no longer triggers a needless window resize #### Motivation for adding to Mudlet New users clicking New saw the window resize and nothing else happen, leaving them unable to add a game manually. #### Other info (issues closed, discussion etc) Assisted-by: Claude:claude-fable-5 **Test case:** Open the profile selector, click New - a highlighted "new profile name" entry appears at the top with the name field focused, and the window size does not change. #### Demo https://github.com/user-attachments/assets/5789738a-52fb-492d-89d4-b68cb0f36aff
2026-08-03 14:10:57 +02:00
if (!widget_topLeft->isHidden()) {
// the invitation is not up, so there is nothing to restore - and the
// resize below would make the dialog jump in size for no reason
return;
}
add: Show tutorial invitation on first launch (#9169) #### Brief overview of PR changes/additions - On first launch (no existing profiles), show a focused tutorial invitation instead of the full games list - "Start Tutorial" link launches the Mudlet Tutorial profile directly - "Skip - show me the games list" button reveals the full connection dialog with the tutorial profile preselected - Make the Connect button the dialog's explicit default so Enter in the connection form always means "Connect" (see below) #### Motivation for adding to Mudlet New users currently face a wall of 20+ unknown game names with no guidance - a focused tutorial invitation improves first-time retention by teaching basics before choosing a game. #### Other info (issues closed, discussion etc) https://github.com/user-attachments/assets/2eeb3cb9-f596-4744-b187-24e1fc785246 --- Squash-merge trailers: ``` Assisted-by: Claude:claude-fable-5 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org> ``` --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com> Co-authored-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-18 10:54:52 +02:00
widget_topLeft->show();
welcome_message->hide();
tabWidget_connectionInfo->show();
informationArea->show();
mpSkipToGamesButton->hide();
connect_button->show();
offline_button->show();
// The invitation shrank the dialog to fit its short message; size the
// restored full interface from its own layout instead:
resize(sizeHint().expandedTo(minimumSize()));
}
void dlgConnectionProfiles::slot_skipToGamesList()
{
dismissTutorialInvitation();
const auto items = findData(*listWidget_profiles, qsl("Mudlet Tutorial"), csmNameRole);
if (!items.isEmpty()) {
listWidget_profiles->setCurrentItem(items.first());
}
}
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
// the dialog can be accepted by pressing Enter on an qlineedit; this is a safeguard against it
// accepting invalid data
void dlgConnectionProfiles::accept()
{
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
if (validName && validUrl && validPort) {
BugFix: prevent crashing from double-click on connect button (#5313) This is done by hiding the connect profile dialogue as quickly as possible after the load or connect buttons have been clicked (and before the possibly lengthy profile loading operations commenced). This should close #5303. Also, it was found that the: `(void) dlgConnectionProfiles::slot_connectToServer()` slot method was redundant and could be removed. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2021-07-11 21:06:33 +01:00
setVisible(false);
// This is needed to make the above take effect as fast as possible:
qApp->processEvents();
Add a Mudlet Tutorial profile. (#8188) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Adds a Mudlet Tutorial profile which incorporates a basic GUI tutorial and mini-mud quest. GUI tutorial introduces the main window, command line, search bar, toolbar, map. Mini-quest attempts to act like a MUD. Teaches directional commands and some typical verbs (look, buy, give, get, open, close, quit) while the player wanders around trying to figure out the two 'quests' (buy the sheriff some lunch and find the librarian's lost ring). It is simplistic and more designed to show players how a mud 'feels and progresses' when playing rather than a full blown MUD school which most (all?) MUDs incorporate. #### Motivation for adding to Mudlet Help on-boarding new users. Destination 5.0. /claim #3072 helps #2823 #### Other info (issues closed, discussion etc) I purposefully left out triggers, scripting and all that stuff veteran players take for granted! This is supposed to be an on-boarding tutorial for NEW players, let's not overwhelm them. A link after successful completion of the game introduces the wiki Introduction page for more advanced topics. That said, any improvements or basic features you think are missing from either the GUI or Mud tutorials, let me know and I can add. https://github.com/user-attachments/assets/1d16db50-e24b-4e78-b6b0-66e0e98a0772
2025-09-13 14:17:13 +07:00
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
// Check if keychain authentication is pending - if so, wait for it
ensurePasswordLoadedThenConnect(true);
}
}
void dlgConnectionProfiles::slot_load()
{
setVisible(false);
// This is needed to make the above take effect as fast as possible:
qApp->processEvents();
Add a Mudlet Tutorial profile. (#8188) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Adds a Mudlet Tutorial profile which incorporates a basic GUI tutorial and mini-mud quest. GUI tutorial introduces the main window, command line, search bar, toolbar, map. Mini-quest attempts to act like a MUD. Teaches directional commands and some typical verbs (look, buy, give, get, open, close, quit) while the player wanders around trying to figure out the two 'quests' (buy the sheriff some lunch and find the librarian's lost ring). It is simplistic and more designed to show players how a mud 'feels and progresses' when playing rather than a full blown MUD school which most (all?) MUDs incorporate. #### Motivation for adding to Mudlet Help on-boarding new users. Destination 5.0. /claim #3072 helps #2823 #### Other info (issues closed, discussion etc) I purposefully left out triggers, scripting and all that stuff veteran players take for granted! This is supposed to be an on-boarding tutorial for NEW players, let's not overwhelm them. A link after successful completion of the game introduces the wiki Introduction page for more advanced topics. That said, any improvements or basic features you think are missing from either the GUI or Mud tutorials, let me know and I can add. https://github.com/user-attachments/assets/1d16db50-e24b-4e78-b6b0-66e0e98a0772
2025-09-13 14:17:13 +07:00
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
// Check if keychain authentication is pending - if so, wait for it
ensurePasswordLoadedThenConnect(false);
}
void dlgConnectionProfiles::ensurePasswordLoadedThenConnect(bool alsoConnect)
{
const QString profile_name = profile_name_entry->text().trimmed();
Add a Mudlet Tutorial profile. (#8188) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Adds a Mudlet Tutorial profile which incorporates a basic GUI tutorial and mini-mud quest. GUI tutorial introduces the main window, command line, search bar, toolbar, map. Mini-quest attempts to act like a MUD. Teaches directional commands and some typical verbs (look, buy, give, get, open, close, quit) while the player wanders around trying to figure out the two 'quests' (buy the sheriff some lunch and find the librarian's lost ring). It is simplistic and more designed to show players how a mud 'feels and progresses' when playing rather than a full blown MUD school which most (all?) MUDs incorporate. #### Motivation for adding to Mudlet Help on-boarding new users. Destination 5.0. /claim #3072 helps #2823 #### Other info (issues closed, discussion etc) I purposefully left out triggers, scripting and all that stuff veteran players take for granted! This is supposed to be an on-boarding tutorial for NEW players, let's not overwhelm them. A link after successful completion of the game introduces the wiki Introduction page for more advanced topics. That said, any improvements or basic features you think are missing from either the GUI or Mud tutorials, let me know and I can add. https://github.com/user-attachments/assets/1d16db50-e24b-4e78-b6b0-66e0e98a0772
2025-09-13 14:17:13 +07:00
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
if (profile_name.isEmpty()) {
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
QDialog::accept();
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
return;
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
}
Add a Mudlet Tutorial profile. (#8188) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Adds a Mudlet Tutorial profile which incorporates a basic GUI tutorial and mini-mud quest. GUI tutorial introduces the main window, command line, search bar, toolbar, map. Mini-quest attempts to act like a MUD. Teaches directional commands and some typical verbs (look, buy, give, get, open, close, quit) while the player wanders around trying to figure out the two 'quests' (buy the sheriff some lunch and find the librarian's lost ring). It is simplistic and more designed to show players how a mud 'feels and progresses' when playing rather than a full blown MUD school which most (all?) MUDs incorporate. #### Motivation for adding to Mudlet Help on-boarding new users. Destination 5.0. /claim #3072 helps #2823 #### Other info (issues closed, discussion etc) I purposefully left out triggers, scripting and all that stuff veteran players take for granted! This is supposed to be an on-boarding tutorial for NEW players, let's not overwhelm them. A link after successful completion of the game introduces the wiki Introduction page for more advanced topics. That said, any improvements or basic features you think are missing from either the GUI or Mud tutorials, let me know and I can add. https://github.com/user-attachments/assets/1d16db50-e24b-4e78-b6b0-66e0e98a0772
2025-09-13 14:17:13 +07:00
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
// Check if we have any pending keychain operations for this profile
if (hasPendingKeychainOperation(profile_name)) {
// Queue the profile loading until keychain completes
mPendingConnect = alsoConnect;
mPendingProfileLoad = profile_name;
return; // Will be handled by keychain callback
}
Add a Mudlet Tutorial profile. (#8188) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Adds a Mudlet Tutorial profile which incorporates a basic GUI tutorial and mini-mud quest. GUI tutorial introduces the main window, command line, search bar, toolbar, map. Mini-quest attempts to act like a MUD. Teaches directional commands and some typical verbs (look, buy, give, get, open, close, quit) while the player wanders around trying to figure out the two 'quests' (buy the sheriff some lunch and find the librarian's lost ring). It is simplistic and more designed to show players how a mud 'feels and progresses' when playing rather than a full blown MUD school which most (all?) MUDs incorporate. #### Motivation for adding to Mudlet Help on-boarding new users. Destination 5.0. /claim #3072 helps #2823 #### Other info (issues closed, discussion etc) I purposefully left out triggers, scripting and all that stuff veteran players take for granted! This is supposed to be an on-boarding tutorial for NEW players, let's not overwhelm them. A link after successful completion of the game introduces the wiki Introduction page for more advanced topics. That said, any improvements or basic features you think are missing from either the GUI or Mud tutorials, let me know and I can add. https://github.com/user-attachments/assets/1d16db50-e24b-4e78-b6b0-66e0e98a0772
2025-09-13 14:17:13 +07:00
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
// No pending keychain operations, proceed immediately
loadProfile(alsoConnect);
QDialog::accept();
}
bool dlgConnectionProfiles::hasPendingKeychainOperation(const QString& profile_name) const
{
Q_UNUSED(profile_name)
// Simply check if we have a keychain operation in progress
return mKeychainOperationInProgress;
merge with experimental secureProfiles branch
2009-01-27 12:46:34 +01:00
}
Infrastructure: tidy up naming of SLOT methods and their usage - Part 5 (last) (#6266) When Qt's slot/signal system is used to invoke a method there is some overhead - so it makes sense to ensure developers can spot all such methods (functions). We have tried to do this with a `slot_` prefix to the methods we create but it has not been applied uniformly. This PR is intended to conclude helping with this by more rigorously doing so - the names changed herein should all follow a `slot_`*camelCaseMethodName* style. In addition some methods were detected that are not currently used or which are not actually used via the signal/slot system, these have been commented out or have had the prefix removed and the declaration in the relevant header file moved as appropriate. There were two similar sets of (not prefixed with `slot_`) slots in the Profile preferences class that adjusted the colour settings separately for the main console and the mapper the latter had the same names but with a `2` suffix. To made it more clear I have changed them to include `Map` in their names instead. Also, the NON-slot method: `(void) dlgProfilePreferences::setColor(QPushButton*, QColor&, bool)` has been renamed to: `(void) dlgProfilePreferences::setButtonAndProfileColor(QPushButton*, QColor&, bool)` so that it is clearly distinguishable from built in Qt methods that are also called `setColor` - though which do have different signatures! For reference the changes made are: * `TConsole::slot_stop_all_triggers(...)` ==> `TConsole::slot_stopAllItems(...)` * `dlgConnectionProfiles::slot_copy_profile()` ==> `dlgConnectionProfiles::slot_copyProfile()` * `dlgConnectionProfiles::slot_copy_profilesettings_only()` ==> `dlgConnectionProfiles::slot_copyOnlySettingsOfProfile()` * `dlgConnectionProfiles::slot_deleteprofile_check(...)` ==> `dlgConnectionProfiles::slot_deleteProfileCheck(...)` * `dlgConnectionProfiles::slot_password_deleted(...)` ==> `dlgConnectionProfiles::slot_passwordDeleted(...)` * `dlgConnectionProfiles::slot_password_saved(...) ==> `dlgConnectionProfiles::slot_passwordSaved(...)` * `dlgConnectionProfiles::slot_profile_menu(...)` ==> `dlgConnectionProfiles::slot_profileContextMenu(...)` * `dlgConnectionProfiles::slot_reset_custom_icon()` ==> `dlgConnectionProfiles::slot_resetCustomIcon()` * `dlgConnectionProfiles::slot_set_custom_icon()` ==> `dlgConnectionProfiles::slot_setCustomIcon()` * `dlgConnectionProfiles::slot_set_custom_color()` ==> `dlgConnectionProfiles::slot_setCustomColor()` * `dlgConnectionProfiles::slot_update_autologin(...)` ==> `dlgConnectionProfiles::slot_updateAutoConnect(...)` * `dlgConnectionProfiles::slot_update_autoreconnect(...)` ==> `dlgConnectionProfiles::slot_updateAutoReconnect(...)` * `dlgConnectionProfiles::slot_update_description()` ==> `dlgConnectionProfiles::slot_updateDescription()` * `dlgConnectionProfiles::slot_update_discord_optin(...)` ==> `dlgConnectionProfiles::slot_updateDiscordOptIn(...)` * `dlgProfilePreferences::copyMap()` ==> `dlgProfilePreferences::slot_copyMap()` * `dlgProfilePreferences::downloadMap()` ==> `dlgProfilePreferences::slot_downloadMap()` * `dlgProfilePreferences::hideActionLabel()` ==> `dlgProfilePreferences::slot_hideActionLabel()` * `dlgProfilePreferences::loadMap()` ==> `dlgProfilePreferences::slot_loadMap()` * `dlgProfilePreferences::resetColors()` ==> `dlgProfilePreferences::slot_resetColors()` * `dlgProfilePreferences::resetColors2()` ==> `dlgProfilePreferences::slot_resetMapColors()` * `dlgProfilePreferences::saveMap()` ==> `dlgProfilePreferences::slot_saveMap()` * `dlgProfilePreferences::setBgColor()` ==> `dlgProfilePreferences::slot_setBgColor()` * `dlgProfilePreferences::setBgColor2()` ==> `dlgProfilePreferences::slot_setMapBgColor()` * `dlgProfilePreferences::setColorBlack()` ==> `dlgProfilePreferences::slot_setColorBlack()` * `dlgProfilePreferences::setColorBlack2()` ==> `dlgProfilePreferences::slot_setMapColorBlack()` * `dlgProfilePreferences::setColorBlue()` ==> `dlgProfilePreferences::slot_setColorBlue()` * `dlgProfilePreferences::setColorCyan()` ==> `dlgProfilePreferences::slot_setColorCyan()` * `dlgProfilePreferences::setColorBlue2()` ==> `dlgProfilePreferences::slot_setMapColorBlue()` * `dlgProfilePreferences::setColorCyan2()` ==> `dlgProfilePreferences::slot_setMapColorCyan()` * `dlgProfilePreferences::setColorGreen()` ==> `dlgProfilePreferences::slot_setColorGreen()` * `dlgProfilePreferences::setColorGreen2()` ==> `dlgProfilePreferences::slot_setMapColorGreen()` * `dlgProfilePreferences::setColorLightBlack()` ==> `dlgProfilePreferences::slot_setColorLightBlack()` * `dlgProfilePreferences::setColorLightBlack2()` ==> `dlgProfilePreferences::slot_setMapColorLightBlack()` * `dlgProfilePreferences::setColorLightBlue()` ==> `dlgProfilePreferences::slot_setColorLightBlue()` * `dlgProfilePreferences::setColorLightBlue2()` ==> `dlgProfilePreferences::slot_setMapColorLightBlue()` * `dlgProfilePreferences::setColorLightCyan()` ==> `dlgProfilePreferences::slot_setColorLightCyan()` * `dlgProfilePreferences::setColorLightCyan2()` ==> `dlgProfilePreferences::slot_setMapColorLightCyan()` * `dlgProfilePreferences::setColorLightGreen()` ==> `dlgProfilePreferences::slot_setColorLightGreen()` * `dlgProfilePreferences::setColorLightGreen2()` ==> `dlgProfilePreferences::slot_setMapColorLightGreen()` * `dlgProfilePreferences::setColorLightMagenta()` ==> `dlgProfilePreferences::slot_setColorLightMagenta()` * `dlgProfilePreferences::setColorLightMagenta2()` ==> `dlgProfilePreferences::slot_setMapColorLightMagenta()` * `dlgProfilePreferences::setColorLightRed()` ==> `dlgProfilePreferences::slot_setColorLightRed()` * `dlgProfilePreferences::setColorLightRed2()` ==> `dlgProfilePreferences::slot_setMapColorLightRed()` * `dlgProfilePreferences::setColorLightWhite()` ==> `dlgProfilePreferences::slot_setColorLightWhite()` * `dlgProfilePreferences::setColorLightWhite2()` ==> `dlgProfilePreferences::slot_setMapColorLightWhite()` * `dlgProfilePreferences::setColorLightYellow()` ==> `dlgProfilePreferences::slot_setColorLightYellow()` * `dlgProfilePreferences::setColorLightYellow2()` ==> `dlgProfilePreferences::slot_setMapColorLightYellow()` * `dlgProfilePreferences::setColorMagenta()` ==> `dlgProfilePreferences::slot_setColorMagenta()` * `dlgProfilePreferences::setColorMagenta2()` ==> `dlgProfilePreferences::slot_setMapColorMagenta()` * `dlgProfilePreferences::setColorRed2()` ==> `dlgProfilePreferences::slot_setMapColorRed()` * `dlgProfilePreferences::setColorRed()` ==> `dlgProfilePreferences::slot_setColorRed()` * `dlgProfilePreferences::setColorWhite()` ==> `dlgProfilePreferences::slot_setColorWhite()` * `dlgProfilePreferences::setColorWhite2()` ==> `dlgProfilePreferences::slot_setMapColorWhite()` * `dlgProfilePreferences::setColorYellow()` ==> `dlgProfilePreferences::slot_setColorYellow()` * `dlgProfilePreferences::setColorYellow2()` ==> `dlgProfilePreferences::slot_setMapColorYellow()` * `dlgProfilePreferences::setCommandBgColor()` ==> `dlgProfilePreferences::slot_setCommandBgColor()` * `dlgProfilePreferences::setCommandFgColor()` ==> `dlgProfilePreferences::slot_setCommandFgColor()` * `dlgProfilePreferences::setCommandLineBgColor()` ==> `dlgProfilePreferences::slot_setCommandLineBgColor()` * `dlgProfilePreferences::setCommandLineFgColor()` ==> `dlgProfilePreferences::slot_setCommandLineFgColor()` * `dlgProfilePreferences::setDisplayFont()` ==> `dlgProfilePreferences::slot_setDisplayFont()` * `dlgProfilePreferences::setFgColor()` ==> `dlgProfilePreferences::slot_setFgColor()` * `dlgProfilePreferences::setFgColor2()` ==> `dlgProfilePreferences::slot_setMapExitsColor()` * `dlgProfilePreferences::setFontSize()` ==> `dlgProfilePreferences::slot_setFontSize()` * `dlgProfilePreferences::setMapInfoBackground()` ==> `dlgProfilePreferences::slot_setMapInfoBgColor()` * `dlgProfilePreferences::setRoomBorderColor()` ==> `dlgProfilePreferences::slot_setMapRoomBorderColor()` * `dlgProfilePreferences::slot_script_selected(...)` ==> `dlgProfilePreferences::slot_scriptSelected(...)` * `dlgProfilePreferences::slot_theme_selected(...)` ==> `dlgProfilePreferences::slot_themeSelected(...)` * `dlgRoomSymbol::colorRejected()` ==> `dlgRoomSymbol::slot_colorRejected()` * `dlgRoomSymbol::colorSelected(...)` ==> `dlgRoomSymbol::slot_colorSelected(...)` * `dlgRoomSymbol::currentColorChanged(...)` ==> `dlgRoomSymbol::slot_currentColorChanged(...)` * `dlgRoomSymbol::openColorSelector()` ==> `dlgRoomSymbol::slot_openColorSelector()` * `dlgRoomSymbol::resetColor()` ==> `dlgRoomSymbol::slot_resetColors()` * `dlgRoomSymbol::updatePreview()` ==> `dlgRoomSymbol::slot_updatePreview()` * `dlgTriggerEditor::slot_show_vars()` ==> `dlgTriggerEditor::slot_showVariables()` * `dlgTriggerEditor::slot_var_changed(...)` ==> `dlgTriggerEditor::slot_variableChanged(...)` * `dlgTriggerEditor::slot_var_selected(...)` ==> `dlgTriggerEditor::slot_variableSelected(...)` * `mudlet::slot_check_manual_update()` ==> `mudlet::slot_manualUpdateCheck()` * `mudlet::slot_close_current_profile()` ==> `mudlet::slot_closeCurrentProfile()` * `mudlet::slot_close_profile_requested(...)` ==> `mudlet::slot_closeProfileRequested(...)` * `mudlet::slot_connection_dlg_finished(...)` ==> `mudlet::slot_connectionDialogueFinished(...)` * `mudlet::slot_module_manager()` ==> `mudlet::slot_moduleManager()` * `mudlet::slot_mudlet_discord()` ==> `mudlet::slot_mudletDiscord()` * `mudlet::slot_multi_view(...)` ==> `mudlet::slot_multiView(const bool state)` * `mudlet::slot_package_manager()` ==> `mudlet::slot_packageManager()` * `mudlet::slot_package_exporter()` ==> `mudlet::slot_packageExporter()` * `mudlet::slot_timer_fires()` ==> `mudlet::slot_timerFires()` * `mudlet::slot_toggle_multi_view()` ==> `mudlet::slot_toggleMultiView()` Also the names for these in particular have been changed to make more sense: * `dlgProfilePreferences::slot_chooseProfilesChanged()` ==> `dlgProfilePreferences::slot_chosenProfilesChanged()` * `dlgProfilePreferences::slot_editor_tab_selected(...)` ==> `dlgProfilePreferences::slot_tabChanged(...)` * `dlgProfilePreferences::slot_passwords_location_changed(...)` ==> `dlgProfilePreferences::slot_passwordStorageLocationChanged(...)` * `dlgProfilePreferences::slot_save_and_exit()` ==> `dlgProfilePreferences::slot_saveAndClose()` * `dlgTriggerEditor::slot_toggleHiddenVar(...)` ==> `dlgTriggerEditor::slot_hideVariable(...)` - changed to distinguish it from `slot_toggleHiddenVariables(...)` * `dlgTriggerEditor::slot_item_selected_save(...)` ==> `dlgTriggerEditor::slot_saveSelectedItem(...)` * `mudlet::slot_discord()` ==> `mudlet::slot_profileDiscord()` - changed to distinguish it from `slot_mudletDiscord()` Not currently used and commented out: * `dlgProfilePreferences::setCommandLineFont()` ==> `dlgProfilePreferences::slot_setCommandLineFont()` Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-08-29 14:27:13 +02:00
void dlgConnectionProfiles::slot_updateDescription()
Feature: finished all features in connectionDialog + autologon
2009-01-28 02:35:22 +01:00
{
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
QListWidgetItem* pItem = listWidget_profiles->currentItem();
misc
2010-03-15 09:37:16 +01:00
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
if (pItem) {
Infrastructure: mark read-only variables as const (#6843) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Mark read-only variables as const - that is, not intended to change after they've been declared #### Motivation for adding to Mudlet So we don't change them by accident later on, and also to clearly state intentions for the variables #### Other info (issues closed, discussion etc) This is also recommended by the [C++ Core Guidelines](https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#es25-declare-an-object-const-or-constexpr-unless-you-want-to-modify-its-value-later-on)
2023-05-14 15:06:15 +02:00
const QString description = mud_description_textedit->toPlainText();
Infrastructure: Add short qsl macro to stand in for 'QStringLiteral' (#5640)
2021-12-07 06:21:39 +01:00
writeProfileData(pItem->data(csmNameRole).toString(), qsl("description"), description);
Improve first-time user experience (#1016) * Fixed the welcome message to show again It didn't before because default_host profile directory was getting created on the disk before the check. * Made it so a random profile gets selected for a first-time launch * Modernized mudlet::startAutoLogin function * Renamed poorly-named method to open connections dialog It also was confusing with Host::connectToServer doing the actual connecting * Made the connection dialog open if no profiles are on autoload * Removed superseded status bar notification The connection dialog now opens automatically. * Improved first-launch Mudlet size and positioning Mudlet is now centered and has a decent size for the most common resolutions * Fix connection dialog to get a decent size by default * Updated the welcome text It was pretty ancient and referenced outdated button names. Also cut down on the wording so a new user isn't hit with a wall of text. * Moved icon over to left so the screen isn't so busy * Undid hardcoded fonts and sizes in connection dialog User-selected desktop fonts and sizes should be used instead. * Fixed connection dialog to actually select the last played profile There was a bug where it would ignore predefined profiles in the calculation. Also use the last modified, not read date - a lot of things like virus scanners could read the directory whereas far fewer things will write to it. * Moved 'loaded profile' warning to be below profiles This prevents the whole thing from jumping around. * Added a margin to the right for aesthetic reasons * Revised to use getDescription as a method * Got tooltips to show on profile icons
2017-06-04 08:13:51 +02:00
// don't display custom profile descriptions as a tooltip, as passwords could be stored in there
Feature: finished all features in connectionDialog + autologon
2009-01-28 02:35:22 +01:00
}
}
Add: open .mpackage files with Mudlet (#7065) #### Brief overview of PR changes/additions - Created `MudletServer` to keep track of Mudlet instances and allow them to communicate. - Added cli argument for installing a package. - Created `FileOpenHandler` for installing packages from `QEvent::FileOpen` events. - Updated mudlet.desktop to associate Mudlet with .zip files on Linux. - Created Info.plist to associate Mudlet with .mpackage files on MacOS. - Added registry keys to associate Mudlet with .mpackage files on Windows. #### Motivation for adding to Mudlet fixes #1083 /claim #1083 #### Other info (issues closed, discussion etc) The Info.plist file needs to be copied into the app bundle for MacOS to recognize it. I'm not sure how to do that. I found a reference to mudlet.app in `CI/travis.osx.after_success.sh`, but I think that's just for the CI build. Does someone know how Mudlet is installed on MacOS? Related docs: https://developer.apple.com/library/archive/documentation/CoreFoundation/Conceptual/CFBundles/BundleTypes/BundleTypes.html#//apple_ref/doc/uid/10000123i-CH101-SW1 ## Examples **Installing a package on an already running instance of Mudlet** https://github.com/Mudlet/Mudlet/assets/147658676/4457e496-a24f-420f-9bc3-3a879e7e4f9f **Queueing two packages for install by gui and cli. Displaying connection dialogue to determine which profile the packages should be installed on.** https://github.com/Mudlet/Mudlet/assets/147658676/a12edeea-6973-43c8-a691-cfb4524efdb1 **If no other instance of Mudlet is open, open Mudlet and install on first opened profile** https://github.com/Mudlet/Mudlet/assets/147658676/662d450a-6bbd-4528-88e6-4dba674cc82e
2024-01-07 08:48:57 -05:00
void dlgConnectionProfiles::indicatePackagesInstallOnConnect(QStringList packages)
{
Fix: Clazy warnings part 7 - isempty-vs-count (#9235) #### Brief overview of PR changes/additions One of a series of PRs, each addressing a type of issue reported by Clazy. This is the: "Use isEmpty() instead [-Wclazy-isempty-vs-count]" one. #### Motivation for adding to Mudlet Remove warnings detected by the Clazy tool - either when explicitly run on the Mudlet code-base or detected by the background scanner/analyser that Qt Creator offers. #### Other info (issues closed, discussion etc) A summary I found for this is: > Using isEmpty() is preferred over comparing count to zero because it is more efficient and improves code readability. This is especially important for collections that do not implement `RandomAccessCollection`, as counting elements can be costly. However a conflicting alternative merely suggests that only the semantics are better reflect by the use of `isEmpty` - there is no difference in performance - and the first bit is certainly the basis of our (Mudlet Core Devs) existing preference for it. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2026-04-26 20:05:35 +01:00
if (packages.isEmpty()) {
Add: open .mpackage files with Mudlet (#7065) #### Brief overview of PR changes/additions - Created `MudletServer` to keep track of Mudlet instances and allow them to communicate. - Added cli argument for installing a package. - Created `FileOpenHandler` for installing packages from `QEvent::FileOpen` events. - Updated mudlet.desktop to associate Mudlet with .zip files on Linux. - Created Info.plist to associate Mudlet with .mpackage files on MacOS. - Added registry keys to associate Mudlet with .mpackage files on Windows. #### Motivation for adding to Mudlet fixes #1083 /claim #1083 #### Other info (issues closed, discussion etc) The Info.plist file needs to be copied into the app bundle for MacOS to recognize it. I'm not sure how to do that. I found a reference to mudlet.app in `CI/travis.osx.after_success.sh`, but I think that's just for the CI build. Does someone know how Mudlet is installed on MacOS? Related docs: https://developer.apple.com/library/archive/documentation/CoreFoundation/Conceptual/CFBundles/BundleTypes/BundleTypes.html#//apple_ref/doc/uid/10000123i-CH101-SW1 ## Examples **Installing a package on an already running instance of Mudlet** https://github.com/Mudlet/Mudlet/assets/147658676/4457e496-a24f-420f-9bc3-3a879e7e4f9f **Queueing two packages for install by gui and cli. Displaying connection dialogue to determine which profile the packages should be installed on.** https://github.com/Mudlet/Mudlet/assets/147658676/a12edeea-6973-43c8-a691-cfb4524efdb1 **If no other instance of Mudlet is open, open Mudlet and install on first opened profile** https://github.com/Mudlet/Mudlet/assets/147658676/662d450a-6bbd-4528-88e6-4dba674cc82e
2024-01-07 08:48:57 -05:00
return;
}
QWidget widget;
QGroupBox* packageGroupBox = new QGroupBox("Select and load a profile to install the following package(s) into:", this);
QVBoxLayout* packageInfoLayout = new QVBoxLayout(packageGroupBox);
packageInfoLayout->setContentsMargins(8, 8, 8, 8);
packageGroupBox->setStyleSheet("QGroupBox:title { padding-left: 8px; }");
for (const QString& package : packages) {
QFileInfo fileInfo(package);
QString packageName = fileInfo.baseName();
QLabel* packageLabel = new QLabel(packageName);
packageInfoLayout->addWidget(packageLabel);
}
layout()->addWidget(packageGroupBox);
}
Infrastructure: tidy up naming of SLOT methods and their usage - Part 2 (#6255) When Qt's slot/signal system is used to invoke a method there is some overhead - so it makes sense to ensure developers can spot all such methods (functions). We have tried to do this with a `slot_` prefix to the methods we create but it has not been applied uniformly. This PR (and one or more to follow) is intended to help with this by more rigorously doing so - the names changed herein should all follow a `slot_`*camelCaseMethodName* style. In addition some methods were detected that are not currently used or which are not actually used via the signal/slot system, these have been commented out or have had the prefix removed and the declaration in the relevant header file moved as appropriate. For reference the changes made are: * `TLuaInterpreter::slotDeleteSender(...)` ==> `TLuaInterpreter::slot_deleteSender(...)` * `TLuaInterpreter::slotPurge()` ==> `TLuaInterpreter::slot_purge()` * `cTelnet::handle_socket_signal_connected()` ==> `cTelnet::slot_socketConnected()` * `cTelnet::handle_socket_signal_disconnected()` ==> `cTelnet::slot_socketDisconnected()` * `cTelnet::handle_socket_signal_hostFound(...)` ==> `cTelnet::slot_socketHostFound(...)` * `cTelnet::handle_socket_signal_readyRead()` ==> `cTelnet::slot_socketReadyToBeRead()` * `cTelnet::handle_socket_signal_sslError(...)` ==> `cTelnet::slot_socketSslError(...)` * `cTelnet::setDownloadProgress(...)` ==> `cTelnet::slot_setDownloadProgress(...)` * `dlgComposer::cancel()` ==> `dlgComposer::slot_cancel()` * `dlgComposer::save()` ==> `dlgComposer::slot_save()` * `dlgConnectionProfiles::slot_item_clicked(...)` ==> `dlgConnectionProfiles::slot_itemClicked(...)` * `dlgConnectionProfiles::slot_save_name()` ==> `dlgConnectionProfiles::slot_saveName()` * `dlgConnectionProfiles::slot_update_login(...)` ==> `dlgConnectionProfiles::slot_updateLogin(...)` * `dlgConnectionProfiles::slot_update_name(...)` ==> `dlgConnectionProfiles::slot_updateName(...)` * `dlgConnectionProfiles::slot_update_pass(...)` ==> `dlgConnectionProfiles::slot_updatePassword(...)` * `dlgConnectionProfiles::slot_update_port(...)` ==> `dlgConnectionProfiles::slot_updatePort(...)` * `dlgConnectionProfiles::slot_update_SSL_TSL_port(...)` ==> `dlgConnectionProfiles::slot_updateSslTslPort(...)` * `dlgConnectionProfiles::slot_update_url(...)` ==> `dlgConnectionProfiles::slot_updateUrl(...)` * `dlgMapLabel::pickBgColor()` ==> `dlgMapLabel::slot_pickBgColor()` * `dlgMapLabel::pickFgColor()` ==> `dlgMapLabel::slot_pickFgColor()` * `dlgMapLabel::pickFile()` ==> `dlgMapLabel::slot_pickFile()` * `dlgMapLabel::pickFont()` ==> `dlgMapLabel::slot_pickFont()` * `dlgMapLabel::save()` ==> `dlgMapLabel::slot_save()` * `dlgMapLabel::updateControls()` ==> `dlgMapLabel::slot_updateControls()` * `dlgMapLabel::updateControlsVisibility()` ==> `dlgMapLabel::slot_updateControlsVisibility()` Commented out as not being used: * `cTelnet::handle_socket_signal_error()` ==> `cTelnet::slot_socketError()` * `dlgConnectionProfiles::slot_update_website(...) ==> `dlgConnectionProfiles::slot_updateWebsite(const QString& url)` I have my doubts about whether the `dlgMapLabel::save()`/`dlgMapLabel::slot_save()` method is needed at all, as it might be that the `QDialog::accept()` slot could have been inserted into the `QObject::connect(...)` call directly instead...? Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-08-27 10:47:01 +02:00
// Not used:
//void dlgConnectionProfiles::slot_updateWebsite(const QString& url)
//{
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
// QListWidgetItem* pItem = listWidget_profiles->currentItem();
Infrastructure: tidy up naming of SLOT methods and their usage - Part 2 (#6255) When Qt's slot/signal system is used to invoke a method there is some overhead - so it makes sense to ensure developers can spot all such methods (functions). We have tried to do this with a `slot_` prefix to the methods we create but it has not been applied uniformly. This PR (and one or more to follow) is intended to help with this by more rigorously doing so - the names changed herein should all follow a `slot_`*camelCaseMethodName* style. In addition some methods were detected that are not currently used or which are not actually used via the signal/slot system, these have been commented out or have had the prefix removed and the declaration in the relevant header file moved as appropriate. For reference the changes made are: * `TLuaInterpreter::slotDeleteSender(...)` ==> `TLuaInterpreter::slot_deleteSender(...)` * `TLuaInterpreter::slotPurge()` ==> `TLuaInterpreter::slot_purge()` * `cTelnet::handle_socket_signal_connected()` ==> `cTelnet::slot_socketConnected()` * `cTelnet::handle_socket_signal_disconnected()` ==> `cTelnet::slot_socketDisconnected()` * `cTelnet::handle_socket_signal_hostFound(...)` ==> `cTelnet::slot_socketHostFound(...)` * `cTelnet::handle_socket_signal_readyRead()` ==> `cTelnet::slot_socketReadyToBeRead()` * `cTelnet::handle_socket_signal_sslError(...)` ==> `cTelnet::slot_socketSslError(...)` * `cTelnet::setDownloadProgress(...)` ==> `cTelnet::slot_setDownloadProgress(...)` * `dlgComposer::cancel()` ==> `dlgComposer::slot_cancel()` * `dlgComposer::save()` ==> `dlgComposer::slot_save()` * `dlgConnectionProfiles::slot_item_clicked(...)` ==> `dlgConnectionProfiles::slot_itemClicked(...)` * `dlgConnectionProfiles::slot_save_name()` ==> `dlgConnectionProfiles::slot_saveName()` * `dlgConnectionProfiles::slot_update_login(...)` ==> `dlgConnectionProfiles::slot_updateLogin(...)` * `dlgConnectionProfiles::slot_update_name(...)` ==> `dlgConnectionProfiles::slot_updateName(...)` * `dlgConnectionProfiles::slot_update_pass(...)` ==> `dlgConnectionProfiles::slot_updatePassword(...)` * `dlgConnectionProfiles::slot_update_port(...)` ==> `dlgConnectionProfiles::slot_updatePort(...)` * `dlgConnectionProfiles::slot_update_SSL_TSL_port(...)` ==> `dlgConnectionProfiles::slot_updateSslTslPort(...)` * `dlgConnectionProfiles::slot_update_url(...)` ==> `dlgConnectionProfiles::slot_updateUrl(...)` * `dlgMapLabel::pickBgColor()` ==> `dlgMapLabel::slot_pickBgColor()` * `dlgMapLabel::pickFgColor()` ==> `dlgMapLabel::slot_pickFgColor()` * `dlgMapLabel::pickFile()` ==> `dlgMapLabel::slot_pickFile()` * `dlgMapLabel::pickFont()` ==> `dlgMapLabel::slot_pickFont()` * `dlgMapLabel::save()` ==> `dlgMapLabel::slot_save()` * `dlgMapLabel::updateControls()` ==> `dlgMapLabel::slot_updateControls()` * `dlgMapLabel::updateControlsVisibility()` ==> `dlgMapLabel::slot_updateControlsVisibility()` Commented out as not being used: * `cTelnet::handle_socket_signal_error()` ==> `cTelnet::slot_socketError()` * `dlgConnectionProfiles::slot_update_website(...) ==> `dlgConnectionProfiles::slot_updateWebsite(const QString& url)` I have my doubts about whether the `dlgMapLabel::save()`/`dlgMapLabel::slot_save()` method is needed at all, as it might be that the `QDialog::accept()` slot could have been inserted into the `QObject::connect(...)` call directly instead...? Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-08-27 10:47:01 +02:00
// if (pItem) {
// writeProfileData(pItem->data(csmNameRole).toString(), qsl("website"), url);
// }
//}
Feature: finished all features in connectionDialog + autologon
2009-01-28 02:35:22 +01:00
Infrastructure: tidy up naming of SLOT methods and their usage - Part 2 (#6255) When Qt's slot/signal system is used to invoke a method there is some overhead - so it makes sense to ensure developers can spot all such methods (functions). We have tried to do this with a `slot_` prefix to the methods we create but it has not been applied uniformly. This PR (and one or more to follow) is intended to help with this by more rigorously doing so - the names changed herein should all follow a `slot_`*camelCaseMethodName* style. In addition some methods were detected that are not currently used or which are not actually used via the signal/slot system, these have been commented out or have had the prefix removed and the declaration in the relevant header file moved as appropriate. For reference the changes made are: * `TLuaInterpreter::slotDeleteSender(...)` ==> `TLuaInterpreter::slot_deleteSender(...)` * `TLuaInterpreter::slotPurge()` ==> `TLuaInterpreter::slot_purge()` * `cTelnet::handle_socket_signal_connected()` ==> `cTelnet::slot_socketConnected()` * `cTelnet::handle_socket_signal_disconnected()` ==> `cTelnet::slot_socketDisconnected()` * `cTelnet::handle_socket_signal_hostFound(...)` ==> `cTelnet::slot_socketHostFound(...)` * `cTelnet::handle_socket_signal_readyRead()` ==> `cTelnet::slot_socketReadyToBeRead()` * `cTelnet::handle_socket_signal_sslError(...)` ==> `cTelnet::slot_socketSslError(...)` * `cTelnet::setDownloadProgress(...)` ==> `cTelnet::slot_setDownloadProgress(...)` * `dlgComposer::cancel()` ==> `dlgComposer::slot_cancel()` * `dlgComposer::save()` ==> `dlgComposer::slot_save()` * `dlgConnectionProfiles::slot_item_clicked(...)` ==> `dlgConnectionProfiles::slot_itemClicked(...)` * `dlgConnectionProfiles::slot_save_name()` ==> `dlgConnectionProfiles::slot_saveName()` * `dlgConnectionProfiles::slot_update_login(...)` ==> `dlgConnectionProfiles::slot_updateLogin(...)` * `dlgConnectionProfiles::slot_update_name(...)` ==> `dlgConnectionProfiles::slot_updateName(...)` * `dlgConnectionProfiles::slot_update_pass(...)` ==> `dlgConnectionProfiles::slot_updatePassword(...)` * `dlgConnectionProfiles::slot_update_port(...)` ==> `dlgConnectionProfiles::slot_updatePort(...)` * `dlgConnectionProfiles::slot_update_SSL_TSL_port(...)` ==> `dlgConnectionProfiles::slot_updateSslTslPort(...)` * `dlgConnectionProfiles::slot_update_url(...)` ==> `dlgConnectionProfiles::slot_updateUrl(...)` * `dlgMapLabel::pickBgColor()` ==> `dlgMapLabel::slot_pickBgColor()` * `dlgMapLabel::pickFgColor()` ==> `dlgMapLabel::slot_pickFgColor()` * `dlgMapLabel::pickFile()` ==> `dlgMapLabel::slot_pickFile()` * `dlgMapLabel::pickFont()` ==> `dlgMapLabel::slot_pickFont()` * `dlgMapLabel::save()` ==> `dlgMapLabel::slot_save()` * `dlgMapLabel::updateControls()` ==> `dlgMapLabel::slot_updateControls()` * `dlgMapLabel::updateControlsVisibility()` ==> `dlgMapLabel::slot_updateControlsVisibility()` Commented out as not being used: * `cTelnet::handle_socket_signal_error()` ==> `cTelnet::slot_socketError()` * `dlgConnectionProfiles::slot_update_website(...) ==> `dlgConnectionProfiles::slot_updateWebsite(const QString& url)` I have my doubts about whether the `dlgMapLabel::save()`/`dlgMapLabel::slot_save()` method is needed at all, as it might be that the `QDialog::accept()` slot could have been inserted into the `QObject::connect(...)` call directly instead...? Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-08-27 10:47:01 +02:00
void dlgConnectionProfiles::slot_updatePassword(const QString& pass)
Feature: finished all features in connectionDialog + autologon
2009-01-28 02:35:22 +01:00
{
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
QListWidgetItem* pItem = listWidget_profiles->currentItem();
Store character's login passwords securely (#3018) * Added QtKeychain * Wire in QtKeychain into qmake build * Install libsecret-dev in Travis * Got read/write working from the secure storage only * Reset password * Change to using a callback instead of a deep chain of nested calls * Wire in CMake build, but doesn't work yet * Finish CMake build, works now * WIP * Add migration to secure storage * Remove left-in debug echo * Don't forget password when profile is renamed * Don't delete passwords upon migration for now * Revise: insert QtKeyChain licence boilerplate (#17) I have use the 2-Clause BSD (a.k.a the FreeBSD) licence that is in the upstream's "COPYING" file - this is at varience with the two README files which quote the licence as being the Modified BSD which is the 3-Clause one. I have an open issue on the upstream repository seeking clarification; should things not be as they seem it should be a relatively painless operation to select the other boillerplate for this item. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2019-09-09 07:37:11 +02:00
if (!pItem) {
return;
Feature: finished all features in connectionDialog + autologon
2009-01-28 02:35:22 +01:00
}
Store character's login passwords securely (#3018) * Added QtKeychain * Wire in QtKeychain into qmake build * Install libsecret-dev in Travis * Got read/write working from the secure storage only * Reset password * Change to using a callback instead of a deep chain of nested calls * Wire in CMake build, but doesn't work yet * Finish CMake build, works now * WIP * Add migration to secure storage * Remove left-in debug echo * Don't forget password when profile is renamed * Don't delete passwords upon migration for now * Revise: insert QtKeyChain licence boilerplate (#17) I have use the 2-Clause BSD (a.k.a the FreeBSD) licence that is in the upstream's "COPYING" file - this is at varience with the two README files which quote the licence as being the Modified BSD which is the 3-Clause one. I have an open issue on the upstream repository seeking clarification; should things not be as they seem it should be a relatively painless operation to select the other boillerplate for this item. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2019-09-09 07:37:11 +02:00
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
const QString profileName = pItem->data(csmNameRole).toString();
Add a Mudlet Tutorial profile. (#8188) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Adds a Mudlet Tutorial profile which incorporates a basic GUI tutorial and mini-mud quest. GUI tutorial introduces the main window, command line, search bar, toolbar, map. Mini-quest attempts to act like a MUD. Teaches directional commands and some typical verbs (look, buy, give, get, open, close, quit) while the player wanders around trying to figure out the two 'quests' (buy the sheriff some lunch and find the librarian's lost ring). It is simplistic and more designed to show players how a mud 'feels and progresses' when playing rather than a full blown MUD school which most (all?) MUDs incorporate. #### Motivation for adding to Mudlet Help on-boarding new users. Destination 5.0. /claim #3072 helps #2823 #### Other info (issues closed, discussion etc) I purposefully left out triggers, scripting and all that stuff veteran players take for granted! This is supposed to be an on-boarding tutorial for NEW players, let's not overwhelm them. A link after successful completion of the game introduces the wiki Introduction page for more advanced topics. That said, any improvements or basic features you think are missing from either the GUI or Mud tutorials, let me know and I can add. https://github.com/user-attachments/assets/1d16db50-e24b-4e78-b6b0-66e0e98a0772
2025-09-13 14:17:13 +07:00
Add a toggle to store password securely, in OS or in the profile (#3121) * Add password migration toggle * Remove colourroles * Store/load option for secure storage * Minor QA cleanup, remove debug messages * Remove checkmark, it looks poor on Windows * Fix 'Copy profile' not to lose password if you're storing them securely * Actually write password to storage on copy as well * Only save secure passwords if we're using secure password storage * Store passwords in profile storage if using profile storage on edit * Use correct tooltip for secure/profile storage * Fix header return signature to match function's
2019-09-30 11:19:28 +02:00
if (mudlet::self()->storingPasswordsSecurely()) {
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
if (pass.trimmed().isEmpty()) {
// If password is empty, remove it from secure storage
deleteSecurePassword(profileName);
} else {
// Store the password securely
writeSecurePassword(profileName, pass);
}
Add a toggle to store password securely, in OS or in the profile (#3121) * Add password migration toggle * Remove colourroles * Store/load option for secure storage * Minor QA cleanup, remove debug messages * Remove checkmark, it looks poor on Windows * Fix 'Copy profile' not to lose password if you're storing them securely * Actually write password to storage on copy as well * Only save secure passwords if we're using secure password storage * Store passwords in profile storage if using profile storage on edit * Use correct tooltip for secure/profile storage * Fix header return signature to match function's
2019-09-30 11:19:28 +02:00
} else {
Fix: Connection dialog character name save issues for default games (#8101) #### Brief overview of PR changes/additions - Enhanced `writeProfileData()` to automatically create profile directories when they don't exist - Added proper error checking and logging for character name and password save operations - Fixed silent failures that caused intermittent loss of saved character names #### Motivation for adding to Mudlet Character names in the connection dialog do not persist initially for default game profiles (StickMUD, Achaea, etc.) because their directories don't exist until first connection. Profile data saves failed silently when directories were missing, with no indication to users. This particularly affected new users trying default games, requiring multiple attempts before character names would persist. #### Other info (issues closed, discussion etc) - Resolves character name loss for default game profiles in 4.19.1 - Ensures consistent behavior between default and user-created profiles - Improves reliability of profile data saving system --- In 4.19.1 it takes 2+ connections for the character name to stick: https://github.com/user-attachments/assets/3cd0d87e-54a0-4a24-8abe-260c7471fa82 --- With the fix, this is done right away: https://github.com/user-attachments/assets/84a6a2dc-70f6-475b-8c06-86601d648521
2025-08-27 03:13:07 -04:00
auto result = mudlet::self()->writeProfileData(profileName, qsl("password"), pass);
if (!result.first) {
qWarning().noquote().nospace() << "dlgConnectionProfiles::slot_updatePassword() ERROR - failed to save password for profile \"" << profileName << "\": " << result.second;
}
Add a toggle to store password securely, in OS or in the profile (#3121) * Add password migration toggle * Remove colourroles * Store/load option for secure storage * Minor QA cleanup, remove debug messages * Remove checkmark, it looks poor on Windows * Fix 'Copy profile' not to lose password if you're storing them securely * Actually write password to storage on copy as well * Only save secure passwords if we're using secure password storage * Store passwords in profile storage if using profile storage on edit * Use correct tooltip for secure/profile storage * Fix header return signature to match function's
2019-09-30 11:19:28 +02:00
}
Store character's login passwords securely (#3018) * Added QtKeychain * Wire in QtKeychain into qmake build * Install libsecret-dev in Travis * Got read/write working from the secure storage only * Reset password * Change to using a callback instead of a deep chain of nested calls * Wire in CMake build, but doesn't work yet * Finish CMake build, works now * WIP * Add migration to secure storage * Remove left-in debug echo * Don't forget password when profile is renamed * Don't delete passwords upon migration for now * Revise: insert QtKeyChain licence boilerplate (#17) I have use the 2-Clause BSD (a.k.a the FreeBSD) licence that is in the upstream's "COPYING" file - this is at varience with the two README files which quote the licence as being the Modified BSD which is the 3-Clause one. I have an open issue on the upstream repository seeking clarification; should things not be as they seem it should be a relatively painless operation to select the other boillerplate for this item. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2019-09-09 07:37:11 +02:00
}
improve: improve memory safety by using smart pointers (#9239) ### Refactor: replace raw pointer ownership with smart pointers across core subsystems #### Brief overview of PR changes/additions Replaces raw pointer ownership patterns with `std::unique_ptr` and `std::map` across several core subsystems: - **Host**: `mStopWatchMap` (`QMap<int, stopWatch*>` → `std::map<int, unique_ptr<stopWatch>>`), `profileShortcuts` (`QMap<QString, QKeySequence*>` → `std::map<QString, unique_ptr<QKeySequence>>`). Removes `qDeleteAll` in destructor and `delete mMMCPServer`. - **TMap**: `mpRoomDB` raw pointer → `unique_ptr` - **VarUnit**: `base` raw pointer → `unique_ptr` - **TTrigger**: condition map storage converted to `unique_ptr`, destructor simplified - **discord**: handler and presence maps converted from raw pointer `QMap` to `unique_ptr` + `std::map` - **Updater**: `mFeed` and `mUpdateDialog` converted to `unique_ptr` #### Motivation for adding to Mudlet These patterns were identified as sources of memory leaks and potential use-after-free bugs. Using smart pointers makes ownership explicit, eliminates manual cleanup code, and ensures correct destruction even on early-exit paths. #### Other info (issues closed, discussion etc) sorry this one is still pretty big, but most of the changes are the same for each thing so reviewing them together probably makes sense. sadly there isn't much to see here other than no slow uptick of heap size :-[ Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-05 16:42:09 +12:00
void dlgConnectionProfiles::writeSecurePassword(const QString& profile, const QString& pass)
Store character's login passwords securely (#3018) * Added QtKeychain * Wire in QtKeychain into qmake build * Install libsecret-dev in Travis * Got read/write working from the secure storage only * Reset password * Change to using a callback instead of a deep chain of nested calls * Wire in CMake build, but doesn't work yet * Finish CMake build, works now * WIP * Add migration to secure storage * Remove left-in debug echo * Don't forget password when profile is renamed * Don't delete passwords upon migration for now * Revise: insert QtKeyChain licence boilerplate (#17) I have use the 2-Clause BSD (a.k.a the FreeBSD) licence that is in the upstream's "COPYING" file - this is at varience with the two README files which quote the licence as being the Modified BSD which is the 3-Clause one. I have an open issue on the upstream repository seeking clarification; should things not be as they seem it should be a relatively painless operation to select the other boillerplate for this item. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2019-09-09 07:37:11 +02:00
{
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
// Validate that we have a password to store
if (pass.trimmed().isEmpty()) {
qDebug() << "dlgConnectionProfiles: Skipping storage of empty password for profile" << profile;
return;
}
Add a Mudlet Tutorial profile. (#8188) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Adds a Mudlet Tutorial profile which incorporates a basic GUI tutorial and mini-mud quest. GUI tutorial introduces the main window, command line, search bar, toolbar, map. Mini-quest attempts to act like a MUD. Teaches directional commands and some typical verbs (look, buy, give, get, open, close, quit) while the player wanders around trying to figure out the two 'quests' (buy the sheriff some lunch and find the librarian's lost ring). It is simplistic and more designed to show players how a mud 'feels and progresses' when playing rather than a full blown MUD school which most (all?) MUDs incorporate. #### Motivation for adding to Mudlet Help on-boarding new users. Destination 5.0. /claim #3072 helps #2823 #### Other info (issues closed, discussion etc) I purposefully left out triggers, scripting and all that stuff veteran players take for granted! This is supposed to be an on-boarding tutorial for NEW players, let's not overwhelm them. A link after successful completion of the game introduces the wiki Introduction page for more advanced topics. That said, any improvements or basic features you think are missing from either the GUI or Mud tutorials, let me know and I can add. https://github.com/user-attachments/assets/1d16db50-e24b-4e78-b6b0-66e0e98a0772
2025-09-13 14:17:13 +07:00
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
// Use async API for QtKeychain integration with file fallback
improve: improve memory safety by using smart pointers (#9239) ### Refactor: replace raw pointer ownership with smart pointers across core subsystems #### Brief overview of PR changes/additions Replaces raw pointer ownership patterns with `std::unique_ptr` and `std::map` across several core subsystems: - **Host**: `mStopWatchMap` (`QMap<int, stopWatch*>` → `std::map<int, unique_ptr<stopWatch>>`), `profileShortcuts` (`QMap<QString, QKeySequence*>` → `std::map<QString, unique_ptr<QKeySequence>>`). Removes `qDeleteAll` in destructor and `delete mMMCPServer`. - **TMap**: `mpRoomDB` raw pointer → `unique_ptr` - **VarUnit**: `base` raw pointer → `unique_ptr` - **TTrigger**: condition map storage converted to `unique_ptr`, destructor simplified - **discord**: handler and presence maps converted from raw pointer `QMap` to `unique_ptr` + `std::map` - **Updater**: `mFeed` and `mUpdateDialog` converted to `unique_ptr` #### Motivation for adding to Mudlet These patterns were identified as sources of memory leaks and potential use-after-free bugs. Using smart pointers makes ownership explicit, eliminates manual cleanup code, and ensures correct destruction even on early-exit paths. #### Other info (issues closed, discussion etc) sorry this one is still pretty big, but most of the changes are the same for each thing so reviewing them together probably makes sense. sadly there isn't much to see here other than no slow uptick of heap size :-[ Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-05 16:42:09 +12:00
auto* credManager = new CredentialManager(this);
Add a Mudlet Tutorial profile. (#8188) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Adds a Mudlet Tutorial profile which incorporates a basic GUI tutorial and mini-mud quest. GUI tutorial introduces the main window, command line, search bar, toolbar, map. Mini-quest attempts to act like a MUD. Teaches directional commands and some typical verbs (look, buy, give, get, open, close, quit) while the player wanders around trying to figure out the two 'quests' (buy the sheriff some lunch and find the librarian's lost ring). It is simplistic and more designed to show players how a mud 'feels and progresses' when playing rather than a full blown MUD school which most (all?) MUDs incorporate. #### Motivation for adding to Mudlet Help on-boarding new users. Destination 5.0. /claim #3072 helps #2823 #### Other info (issues closed, discussion etc) I purposefully left out triggers, scripting and all that stuff veteran players take for granted! This is supposed to be an on-boarding tutorial for NEW players, let's not overwhelm them. A link after successful completion of the game introduces the wiki Introduction page for more advanced topics. That said, any improvements or basic features you think are missing from either the GUI or Mud tutorials, let me know and I can add. https://github.com/user-attachments/assets/1d16db50-e24b-4e78-b6b0-66e0e98a0772
2025-09-13 14:17:13 +07:00
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
credManager->storePassword(profile, "character", pass, [credManager, profile](bool success, const QString& errorMessage) {
if (success) {
qDebug() << "dlgConnectionProfiles: Successfully stored password for profile" << profile;
} else {
qWarning() << "dlgConnectionProfiles: Failed to store password for profile" << profile << ":" << errorMessage;
}
Add a Mudlet Tutorial profile. (#8188) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Adds a Mudlet Tutorial profile which incorporates a basic GUI tutorial and mini-mud quest. GUI tutorial introduces the main window, command line, search bar, toolbar, map. Mini-quest attempts to act like a MUD. Teaches directional commands and some typical verbs (look, buy, give, get, open, close, quit) while the player wanders around trying to figure out the two 'quests' (buy the sheriff some lunch and find the librarian's lost ring). It is simplistic and more designed to show players how a mud 'feels and progresses' when playing rather than a full blown MUD school which most (all?) MUDs incorporate. #### Motivation for adding to Mudlet Help on-boarding new users. Destination 5.0. /claim #3072 helps #2823 #### Other info (issues closed, discussion etc) I purposefully left out triggers, scripting and all that stuff veteran players take for granted! This is supposed to be an on-boarding tutorial for NEW players, let's not overwhelm them. A link after successful completion of the game introduces the wiki Introduction page for more advanced topics. That said, any improvements or basic features you think are missing from either the GUI or Mud tutorials, let me know and I can add. https://github.com/user-attachments/assets/1d16db50-e24b-4e78-b6b0-66e0e98a0772
2025-09-13 14:17:13 +07:00
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
// Clean up the credential manager
credManager->deleteLater();
});
Store character's login passwords securely (#3018) * Added QtKeychain * Wire in QtKeychain into qmake build * Install libsecret-dev in Travis * Got read/write working from the secure storage only * Reset password * Change to using a callback instead of a deep chain of nested calls * Wire in CMake build, but doesn't work yet * Finish CMake build, works now * WIP * Add migration to secure storage * Remove left-in debug echo * Don't forget password when profile is renamed * Don't delete passwords upon migration for now * Revise: insert QtKeyChain licence boilerplate (#17) I have use the 2-Clause BSD (a.k.a the FreeBSD) licence that is in the upstream's "COPYING" file - this is at varience with the two README files which quote the licence as being the Modified BSD which is the 3-Clause one. I have an open issue on the upstream repository seeking clarification; should things not be as they seem it should be a relatively painless operation to select the other boillerplate for this item. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2019-09-09 07:37:11 +02:00
}
improve: improve memory safety by using smart pointers (#9239) ### Refactor: replace raw pointer ownership with smart pointers across core subsystems #### Brief overview of PR changes/additions Replaces raw pointer ownership patterns with `std::unique_ptr` and `std::map` across several core subsystems: - **Host**: `mStopWatchMap` (`QMap<int, stopWatch*>` → `std::map<int, unique_ptr<stopWatch>>`), `profileShortcuts` (`QMap<QString, QKeySequence*>` → `std::map<QString, unique_ptr<QKeySequence>>`). Removes `qDeleteAll` in destructor and `delete mMMCPServer`. - **TMap**: `mpRoomDB` raw pointer → `unique_ptr` - **VarUnit**: `base` raw pointer → `unique_ptr` - **TTrigger**: condition map storage converted to `unique_ptr`, destructor simplified - **discord**: handler and presence maps converted from raw pointer `QMap` to `unique_ptr` + `std::map` - **Updater**: `mFeed` and `mUpdateDialog` converted to `unique_ptr` #### Motivation for adding to Mudlet These patterns were identified as sources of memory leaks and potential use-after-free bugs. Using smart pointers makes ownership explicit, eliminates manual cleanup code, and ensures correct destruction even on early-exit paths. #### Other info (issues closed, discussion etc) sorry this one is still pretty big, but most of the changes are the same for each thing so reviewing them together probably makes sense. sadly there isn't much to see here other than no slow uptick of heap size :-[ Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-05 16:42:09 +12:00
void dlgConnectionProfiles::deleteSecurePassword(const QString& profile)
Store character's login passwords securely (#3018) * Added QtKeychain * Wire in QtKeychain into qmake build * Install libsecret-dev in Travis * Got read/write working from the secure storage only * Reset password * Change to using a callback instead of a deep chain of nested calls * Wire in CMake build, but doesn't work yet * Finish CMake build, works now * WIP * Add migration to secure storage * Remove left-in debug echo * Don't forget password when profile is renamed * Don't delete passwords upon migration for now * Revise: insert QtKeyChain licence boilerplate (#17) I have use the 2-Clause BSD (a.k.a the FreeBSD) licence that is in the upstream's "COPYING" file - this is at varience with the two README files which quote the licence as being the Modified BSD which is the 3-Clause one. I have an open issue on the upstream repository seeking clarification; should things not be as they seem it should be a relatively painless operation to select the other boillerplate for this item. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2019-09-09 07:37:11 +02:00
{
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
// Use async API for QtKeychain integration with file fallback
improve: improve memory safety by using smart pointers (#9239) ### Refactor: replace raw pointer ownership with smart pointers across core subsystems #### Brief overview of PR changes/additions Replaces raw pointer ownership patterns with `std::unique_ptr` and `std::map` across several core subsystems: - **Host**: `mStopWatchMap` (`QMap<int, stopWatch*>` → `std::map<int, unique_ptr<stopWatch>>`), `profileShortcuts` (`QMap<QString, QKeySequence*>` → `std::map<QString, unique_ptr<QKeySequence>>`). Removes `qDeleteAll` in destructor and `delete mMMCPServer`. - **TMap**: `mpRoomDB` raw pointer → `unique_ptr` - **VarUnit**: `base` raw pointer → `unique_ptr` - **TTrigger**: condition map storage converted to `unique_ptr`, destructor simplified - **discord**: handler and presence maps converted from raw pointer `QMap` to `unique_ptr` + `std::map` - **Updater**: `mFeed` and `mUpdateDialog` converted to `unique_ptr` #### Motivation for adding to Mudlet These patterns were identified as sources of memory leaks and potential use-after-free bugs. Using smart pointers makes ownership explicit, eliminates manual cleanup code, and ensures correct destruction even on early-exit paths. #### Other info (issues closed, discussion etc) sorry this one is still pretty big, but most of the changes are the same for each thing so reviewing them together probably makes sense. sadly there isn't much to see here other than no slow uptick of heap size :-[ Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-05 16:42:09 +12:00
auto* credManager = new CredentialManager(this);
Add a Mudlet Tutorial profile. (#8188) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Adds a Mudlet Tutorial profile which incorporates a basic GUI tutorial and mini-mud quest. GUI tutorial introduces the main window, command line, search bar, toolbar, map. Mini-quest attempts to act like a MUD. Teaches directional commands and some typical verbs (look, buy, give, get, open, close, quit) while the player wanders around trying to figure out the two 'quests' (buy the sheriff some lunch and find the librarian's lost ring). It is simplistic and more designed to show players how a mud 'feels and progresses' when playing rather than a full blown MUD school which most (all?) MUDs incorporate. #### Motivation for adding to Mudlet Help on-boarding new users. Destination 5.0. /claim #3072 helps #2823 #### Other info (issues closed, discussion etc) I purposefully left out triggers, scripting and all that stuff veteran players take for granted! This is supposed to be an on-boarding tutorial for NEW players, let's not overwhelm them. A link after successful completion of the game introduces the wiki Introduction page for more advanced topics. That said, any improvements or basic features you think are missing from either the GUI or Mud tutorials, let me know and I can add. https://github.com/user-attachments/assets/1d16db50-e24b-4e78-b6b0-66e0e98a0772
2025-09-13 14:17:13 +07:00
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
credManager->removePassword(profile, "character", [credManager, profile](bool success, const QString& errorMessage) {
if (success) {
qDebug() << "dlgConnectionProfiles: Successfully removed password for profile" << profile;
} else {
qWarning() << "dlgConnectionProfiles: Failed to remove password for profile" << profile << ":" << errorMessage;
}
Add a Mudlet Tutorial profile. (#8188) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Adds a Mudlet Tutorial profile which incorporates a basic GUI tutorial and mini-mud quest. GUI tutorial introduces the main window, command line, search bar, toolbar, map. Mini-quest attempts to act like a MUD. Teaches directional commands and some typical verbs (look, buy, give, get, open, close, quit) while the player wanders around trying to figure out the two 'quests' (buy the sheriff some lunch and find the librarian's lost ring). It is simplistic and more designed to show players how a mud 'feels and progresses' when playing rather than a full blown MUD school which most (all?) MUDs incorporate. #### Motivation for adding to Mudlet Help on-boarding new users. Destination 5.0. /claim #3072 helps #2823 #### Other info (issues closed, discussion etc) I purposefully left out triggers, scripting and all that stuff veteran players take for granted! This is supposed to be an on-boarding tutorial for NEW players, let's not overwhelm them. A link after successful completion of the game introduces the wiki Introduction page for more advanced topics. That said, any improvements or basic features you think are missing from either the GUI or Mud tutorials, let me know and I can add. https://github.com/user-attachments/assets/1d16db50-e24b-4e78-b6b0-66e0e98a0772
2025-09-13 14:17:13 +07:00
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
// Clean up the credential manager
credManager->deleteLater();
});
Feature: finished all features in connectionDialog + autologon
2009-01-28 02:35:22 +01:00
}
Infrastructure: tidy up naming of SLOT methods and their usage - Part 2 (#6255) When Qt's slot/signal system is used to invoke a method there is some overhead - so it makes sense to ensure developers can spot all such methods (functions). We have tried to do this with a `slot_` prefix to the methods we create but it has not been applied uniformly. This PR (and one or more to follow) is intended to help with this by more rigorously doing so - the names changed herein should all follow a `slot_`*camelCaseMethodName* style. In addition some methods were detected that are not currently used or which are not actually used via the signal/slot system, these have been commented out or have had the prefix removed and the declaration in the relevant header file moved as appropriate. For reference the changes made are: * `TLuaInterpreter::slotDeleteSender(...)` ==> `TLuaInterpreter::slot_deleteSender(...)` * `TLuaInterpreter::slotPurge()` ==> `TLuaInterpreter::slot_purge()` * `cTelnet::handle_socket_signal_connected()` ==> `cTelnet::slot_socketConnected()` * `cTelnet::handle_socket_signal_disconnected()` ==> `cTelnet::slot_socketDisconnected()` * `cTelnet::handle_socket_signal_hostFound(...)` ==> `cTelnet::slot_socketHostFound(...)` * `cTelnet::handle_socket_signal_readyRead()` ==> `cTelnet::slot_socketReadyToBeRead()` * `cTelnet::handle_socket_signal_sslError(...)` ==> `cTelnet::slot_socketSslError(...)` * `cTelnet::setDownloadProgress(...)` ==> `cTelnet::slot_setDownloadProgress(...)` * `dlgComposer::cancel()` ==> `dlgComposer::slot_cancel()` * `dlgComposer::save()` ==> `dlgComposer::slot_save()` * `dlgConnectionProfiles::slot_item_clicked(...)` ==> `dlgConnectionProfiles::slot_itemClicked(...)` * `dlgConnectionProfiles::slot_save_name()` ==> `dlgConnectionProfiles::slot_saveName()` * `dlgConnectionProfiles::slot_update_login(...)` ==> `dlgConnectionProfiles::slot_updateLogin(...)` * `dlgConnectionProfiles::slot_update_name(...)` ==> `dlgConnectionProfiles::slot_updateName(...)` * `dlgConnectionProfiles::slot_update_pass(...)` ==> `dlgConnectionProfiles::slot_updatePassword(...)` * `dlgConnectionProfiles::slot_update_port(...)` ==> `dlgConnectionProfiles::slot_updatePort(...)` * `dlgConnectionProfiles::slot_update_SSL_TSL_port(...)` ==> `dlgConnectionProfiles::slot_updateSslTslPort(...)` * `dlgConnectionProfiles::slot_update_url(...)` ==> `dlgConnectionProfiles::slot_updateUrl(...)` * `dlgMapLabel::pickBgColor()` ==> `dlgMapLabel::slot_pickBgColor()` * `dlgMapLabel::pickFgColor()` ==> `dlgMapLabel::slot_pickFgColor()` * `dlgMapLabel::pickFile()` ==> `dlgMapLabel::slot_pickFile()` * `dlgMapLabel::pickFont()` ==> `dlgMapLabel::slot_pickFont()` * `dlgMapLabel::save()` ==> `dlgMapLabel::slot_save()` * `dlgMapLabel::updateControls()` ==> `dlgMapLabel::slot_updateControls()` * `dlgMapLabel::updateControlsVisibility()` ==> `dlgMapLabel::slot_updateControlsVisibility()` Commented out as not being used: * `cTelnet::handle_socket_signal_error()` ==> `cTelnet::slot_socketError()` * `dlgConnectionProfiles::slot_update_website(...) ==> `dlgConnectionProfiles::slot_updateWebsite(const QString& url)` I have my doubts about whether the `dlgMapLabel::save()`/`dlgMapLabel::slot_save()` method is needed at all, as it might be that the `QDialog::accept()` slot could have been inserted into the `QObject::connect(...)` call directly instead...? Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-08-27 10:47:01 +02:00
void dlgConnectionProfiles::slot_updateLogin(const QString& login)
Feature: finished all features in connectionDialog + autologon
2009-01-28 02:35:22 +01:00
{
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
QListWidgetItem* pItem = listWidget_profiles->currentItem();
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
if (pItem) {
Fix: Connection dialog character name save issues for default games (#8101) #### Brief overview of PR changes/additions - Enhanced `writeProfileData()` to automatically create profile directories when they don't exist - Added proper error checking and logging for character name and password save operations - Fixed silent failures that caused intermittent loss of saved character names #### Motivation for adding to Mudlet Character names in the connection dialog do not persist initially for default game profiles (StickMUD, Achaea, etc.) because their directories don't exist until first connection. Profile data saves failed silently when directories were missing, with no indication to users. This particularly affected new users trying default games, requiring multiple attempts before character names would persist. #### Other info (issues closed, discussion etc) - Resolves character name loss for default game profiles in 4.19.1 - Ensures consistent behavior between default and user-created profiles - Improves reliability of profile data saving system --- In 4.19.1 it takes 2+ connections for the character name to stick: https://github.com/user-attachments/assets/3cd0d87e-54a0-4a24-8abe-260c7471fa82 --- With the fix, this is done right away: https://github.com/user-attachments/assets/84a6a2dc-70f6-475b-8c06-86601d648521
2025-08-27 03:13:07 -04:00
const QString profileName = pItem->data(csmNameRole).toString();
auto result = mudlet::self()->writeProfileData(profileName, qsl("login"), login);
if (!result.first) {
qWarning().noquote().nospace() << "dlgConnectionProfiles::slot_updateLogin() ERROR - failed to save character name for profile \"" << profileName << "\": " << result.second;
// Could optionally show user notification here
}
Feature: finished all features in connectionDialog + autologon
2009-01-28 02:35:22 +01:00
}
}
Infrastructure: tidy up naming of SLOT methods and their usage - Part 2 (#6255) When Qt's slot/signal system is used to invoke a method there is some overhead - so it makes sense to ensure developers can spot all such methods (functions). We have tried to do this with a `slot_` prefix to the methods we create but it has not been applied uniformly. This PR (and one or more to follow) is intended to help with this by more rigorously doing so - the names changed herein should all follow a `slot_`*camelCaseMethodName* style. In addition some methods were detected that are not currently used or which are not actually used via the signal/slot system, these have been commented out or have had the prefix removed and the declaration in the relevant header file moved as appropriate. For reference the changes made are: * `TLuaInterpreter::slotDeleteSender(...)` ==> `TLuaInterpreter::slot_deleteSender(...)` * `TLuaInterpreter::slotPurge()` ==> `TLuaInterpreter::slot_purge()` * `cTelnet::handle_socket_signal_connected()` ==> `cTelnet::slot_socketConnected()` * `cTelnet::handle_socket_signal_disconnected()` ==> `cTelnet::slot_socketDisconnected()` * `cTelnet::handle_socket_signal_hostFound(...)` ==> `cTelnet::slot_socketHostFound(...)` * `cTelnet::handle_socket_signal_readyRead()` ==> `cTelnet::slot_socketReadyToBeRead()` * `cTelnet::handle_socket_signal_sslError(...)` ==> `cTelnet::slot_socketSslError(...)` * `cTelnet::setDownloadProgress(...)` ==> `cTelnet::slot_setDownloadProgress(...)` * `dlgComposer::cancel()` ==> `dlgComposer::slot_cancel()` * `dlgComposer::save()` ==> `dlgComposer::slot_save()` * `dlgConnectionProfiles::slot_item_clicked(...)` ==> `dlgConnectionProfiles::slot_itemClicked(...)` * `dlgConnectionProfiles::slot_save_name()` ==> `dlgConnectionProfiles::slot_saveName()` * `dlgConnectionProfiles::slot_update_login(...)` ==> `dlgConnectionProfiles::slot_updateLogin(...)` * `dlgConnectionProfiles::slot_update_name(...)` ==> `dlgConnectionProfiles::slot_updateName(...)` * `dlgConnectionProfiles::slot_update_pass(...)` ==> `dlgConnectionProfiles::slot_updatePassword(...)` * `dlgConnectionProfiles::slot_update_port(...)` ==> `dlgConnectionProfiles::slot_updatePort(...)` * `dlgConnectionProfiles::slot_update_SSL_TSL_port(...)` ==> `dlgConnectionProfiles::slot_updateSslTslPort(...)` * `dlgConnectionProfiles::slot_update_url(...)` ==> `dlgConnectionProfiles::slot_updateUrl(...)` * `dlgMapLabel::pickBgColor()` ==> `dlgMapLabel::slot_pickBgColor()` * `dlgMapLabel::pickFgColor()` ==> `dlgMapLabel::slot_pickFgColor()` * `dlgMapLabel::pickFile()` ==> `dlgMapLabel::slot_pickFile()` * `dlgMapLabel::pickFont()` ==> `dlgMapLabel::slot_pickFont()` * `dlgMapLabel::save()` ==> `dlgMapLabel::slot_save()` * `dlgMapLabel::updateControls()` ==> `dlgMapLabel::slot_updateControls()` * `dlgMapLabel::updateControlsVisibility()` ==> `dlgMapLabel::slot_updateControlsVisibility()` Commented out as not being used: * `cTelnet::handle_socket_signal_error()` ==> `cTelnet::slot_socketError()` * `dlgConnectionProfiles::slot_update_website(...) ==> `dlgConnectionProfiles::slot_updateWebsite(const QString& url)` I have my doubts about whether the `dlgMapLabel::save()`/`dlgMapLabel::slot_save()` method is needed at all, as it might be that the `QDialog::accept()` slot could have been inserted into the `QObject::connect(...)` call directly instead...? Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-08-27 10:47:01 +02:00
void dlgConnectionProfiles::slot_updateUrl(const QString& url)
merge with experimental secureProfiles branch
2009-01-27 12:46:34 +01:00
{
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
if (url.isEmpty()) {
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
validUrl = false;
Revise: try and identify profiles and some controls in connection dialog (#3966) Also convert all `setDisabled(state)` to `setEnabled(!state)` in the `dlgConnectionProfiles` class - using a single one instead of a mix of the two is less likely to lead to errors - and it means less effort to search for the places where something is being enabled or disabled. Shorten some overlong variable names. Remove some capitalisations. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2020-08-13 00:57:17 +01:00
offline_button->setEnabled(false);
connect_button->setEnabled(false);
offline_button->setAccessibleDescription(btn_connOrLoad_disabled_accessDesc);
connect_button->setAccessibleDescription(btn_connOrLoad_disabled_accessDesc);
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
return;
}
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
if (validateProfile()) {
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
QListWidgetItem* pItem = listWidget_profiles->currentItem();
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
if (!pItem) {
return;
merge with experimental secureProfiles branch
2009-01-27 12:46:34 +01:00
}
Infrastructure: Add short qsl macro to stand in for 'QStringLiteral' (#5640)
2021-12-07 06:21:39 +01:00
writeProfileData(pItem->data(csmNameRole).toString(), qsl("url"), host_name_entry->text());
merge with experimental secureProfiles branch
2009-01-27 12:46:34 +01:00
}
}
Infrastructure: tidy up naming of SLOT methods and their usage - Part 5 (last) (#6266) When Qt's slot/signal system is used to invoke a method there is some overhead - so it makes sense to ensure developers can spot all such methods (functions). We have tried to do this with a `slot_` prefix to the methods we create but it has not been applied uniformly. This PR is intended to conclude helping with this by more rigorously doing so - the names changed herein should all follow a `slot_`*camelCaseMethodName* style. In addition some methods were detected that are not currently used or which are not actually used via the signal/slot system, these have been commented out or have had the prefix removed and the declaration in the relevant header file moved as appropriate. There were two similar sets of (not prefixed with `slot_`) slots in the Profile preferences class that adjusted the colour settings separately for the main console and the mapper the latter had the same names but with a `2` suffix. To made it more clear I have changed them to include `Map` in their names instead. Also, the NON-slot method: `(void) dlgProfilePreferences::setColor(QPushButton*, QColor&, bool)` has been renamed to: `(void) dlgProfilePreferences::setButtonAndProfileColor(QPushButton*, QColor&, bool)` so that it is clearly distinguishable from built in Qt methods that are also called `setColor` - though which do have different signatures! For reference the changes made are: * `TConsole::slot_stop_all_triggers(...)` ==> `TConsole::slot_stopAllItems(...)` * `dlgConnectionProfiles::slot_copy_profile()` ==> `dlgConnectionProfiles::slot_copyProfile()` * `dlgConnectionProfiles::slot_copy_profilesettings_only()` ==> `dlgConnectionProfiles::slot_copyOnlySettingsOfProfile()` * `dlgConnectionProfiles::slot_deleteprofile_check(...)` ==> `dlgConnectionProfiles::slot_deleteProfileCheck(...)` * `dlgConnectionProfiles::slot_password_deleted(...)` ==> `dlgConnectionProfiles::slot_passwordDeleted(...)` * `dlgConnectionProfiles::slot_password_saved(...) ==> `dlgConnectionProfiles::slot_passwordSaved(...)` * `dlgConnectionProfiles::slot_profile_menu(...)` ==> `dlgConnectionProfiles::slot_profileContextMenu(...)` * `dlgConnectionProfiles::slot_reset_custom_icon()` ==> `dlgConnectionProfiles::slot_resetCustomIcon()` * `dlgConnectionProfiles::slot_set_custom_icon()` ==> `dlgConnectionProfiles::slot_setCustomIcon()` * `dlgConnectionProfiles::slot_set_custom_color()` ==> `dlgConnectionProfiles::slot_setCustomColor()` * `dlgConnectionProfiles::slot_update_autologin(...)` ==> `dlgConnectionProfiles::slot_updateAutoConnect(...)` * `dlgConnectionProfiles::slot_update_autoreconnect(...)` ==> `dlgConnectionProfiles::slot_updateAutoReconnect(...)` * `dlgConnectionProfiles::slot_update_description()` ==> `dlgConnectionProfiles::slot_updateDescription()` * `dlgConnectionProfiles::slot_update_discord_optin(...)` ==> `dlgConnectionProfiles::slot_updateDiscordOptIn(...)` * `dlgProfilePreferences::copyMap()` ==> `dlgProfilePreferences::slot_copyMap()` * `dlgProfilePreferences::downloadMap()` ==> `dlgProfilePreferences::slot_downloadMap()` * `dlgProfilePreferences::hideActionLabel()` ==> `dlgProfilePreferences::slot_hideActionLabel()` * `dlgProfilePreferences::loadMap()` ==> `dlgProfilePreferences::slot_loadMap()` * `dlgProfilePreferences::resetColors()` ==> `dlgProfilePreferences::slot_resetColors()` * `dlgProfilePreferences::resetColors2()` ==> `dlgProfilePreferences::slot_resetMapColors()` * `dlgProfilePreferences::saveMap()` ==> `dlgProfilePreferences::slot_saveMap()` * `dlgProfilePreferences::setBgColor()` ==> `dlgProfilePreferences::slot_setBgColor()` * `dlgProfilePreferences::setBgColor2()` ==> `dlgProfilePreferences::slot_setMapBgColor()` * `dlgProfilePreferences::setColorBlack()` ==> `dlgProfilePreferences::slot_setColorBlack()` * `dlgProfilePreferences::setColorBlack2()` ==> `dlgProfilePreferences::slot_setMapColorBlack()` * `dlgProfilePreferences::setColorBlue()` ==> `dlgProfilePreferences::slot_setColorBlue()` * `dlgProfilePreferences::setColorCyan()` ==> `dlgProfilePreferences::slot_setColorCyan()` * `dlgProfilePreferences::setColorBlue2()` ==> `dlgProfilePreferences::slot_setMapColorBlue()` * `dlgProfilePreferences::setColorCyan2()` ==> `dlgProfilePreferences::slot_setMapColorCyan()` * `dlgProfilePreferences::setColorGreen()` ==> `dlgProfilePreferences::slot_setColorGreen()` * `dlgProfilePreferences::setColorGreen2()` ==> `dlgProfilePreferences::slot_setMapColorGreen()` * `dlgProfilePreferences::setColorLightBlack()` ==> `dlgProfilePreferences::slot_setColorLightBlack()` * `dlgProfilePreferences::setColorLightBlack2()` ==> `dlgProfilePreferences::slot_setMapColorLightBlack()` * `dlgProfilePreferences::setColorLightBlue()` ==> `dlgProfilePreferences::slot_setColorLightBlue()` * `dlgProfilePreferences::setColorLightBlue2()` ==> `dlgProfilePreferences::slot_setMapColorLightBlue()` * `dlgProfilePreferences::setColorLightCyan()` ==> `dlgProfilePreferences::slot_setColorLightCyan()` * `dlgProfilePreferences::setColorLightCyan2()` ==> `dlgProfilePreferences::slot_setMapColorLightCyan()` * `dlgProfilePreferences::setColorLightGreen()` ==> `dlgProfilePreferences::slot_setColorLightGreen()` * `dlgProfilePreferences::setColorLightGreen2()` ==> `dlgProfilePreferences::slot_setMapColorLightGreen()` * `dlgProfilePreferences::setColorLightMagenta()` ==> `dlgProfilePreferences::slot_setColorLightMagenta()` * `dlgProfilePreferences::setColorLightMagenta2()` ==> `dlgProfilePreferences::slot_setMapColorLightMagenta()` * `dlgProfilePreferences::setColorLightRed()` ==> `dlgProfilePreferences::slot_setColorLightRed()` * `dlgProfilePreferences::setColorLightRed2()` ==> `dlgProfilePreferences::slot_setMapColorLightRed()` * `dlgProfilePreferences::setColorLightWhite()` ==> `dlgProfilePreferences::slot_setColorLightWhite()` * `dlgProfilePreferences::setColorLightWhite2()` ==> `dlgProfilePreferences::slot_setMapColorLightWhite()` * `dlgProfilePreferences::setColorLightYellow()` ==> `dlgProfilePreferences::slot_setColorLightYellow()` * `dlgProfilePreferences::setColorLightYellow2()` ==> `dlgProfilePreferences::slot_setMapColorLightYellow()` * `dlgProfilePreferences::setColorMagenta()` ==> `dlgProfilePreferences::slot_setColorMagenta()` * `dlgProfilePreferences::setColorMagenta2()` ==> `dlgProfilePreferences::slot_setMapColorMagenta()` * `dlgProfilePreferences::setColorRed2()` ==> `dlgProfilePreferences::slot_setMapColorRed()` * `dlgProfilePreferences::setColorRed()` ==> `dlgProfilePreferences::slot_setColorRed()` * `dlgProfilePreferences::setColorWhite()` ==> `dlgProfilePreferences::slot_setColorWhite()` * `dlgProfilePreferences::setColorWhite2()` ==> `dlgProfilePreferences::slot_setMapColorWhite()` * `dlgProfilePreferences::setColorYellow()` ==> `dlgProfilePreferences::slot_setColorYellow()` * `dlgProfilePreferences::setColorYellow2()` ==> `dlgProfilePreferences::slot_setMapColorYellow()` * `dlgProfilePreferences::setCommandBgColor()` ==> `dlgProfilePreferences::slot_setCommandBgColor()` * `dlgProfilePreferences::setCommandFgColor()` ==> `dlgProfilePreferences::slot_setCommandFgColor()` * `dlgProfilePreferences::setCommandLineBgColor()` ==> `dlgProfilePreferences::slot_setCommandLineBgColor()` * `dlgProfilePreferences::setCommandLineFgColor()` ==> `dlgProfilePreferences::slot_setCommandLineFgColor()` * `dlgProfilePreferences::setDisplayFont()` ==> `dlgProfilePreferences::slot_setDisplayFont()` * `dlgProfilePreferences::setFgColor()` ==> `dlgProfilePreferences::slot_setFgColor()` * `dlgProfilePreferences::setFgColor2()` ==> `dlgProfilePreferences::slot_setMapExitsColor()` * `dlgProfilePreferences::setFontSize()` ==> `dlgProfilePreferences::slot_setFontSize()` * `dlgProfilePreferences::setMapInfoBackground()` ==> `dlgProfilePreferences::slot_setMapInfoBgColor()` * `dlgProfilePreferences::setRoomBorderColor()` ==> `dlgProfilePreferences::slot_setMapRoomBorderColor()` * `dlgProfilePreferences::slot_script_selected(...)` ==> `dlgProfilePreferences::slot_scriptSelected(...)` * `dlgProfilePreferences::slot_theme_selected(...)` ==> `dlgProfilePreferences::slot_themeSelected(...)` * `dlgRoomSymbol::colorRejected()` ==> `dlgRoomSymbol::slot_colorRejected()` * `dlgRoomSymbol::colorSelected(...)` ==> `dlgRoomSymbol::slot_colorSelected(...)` * `dlgRoomSymbol::currentColorChanged(...)` ==> `dlgRoomSymbol::slot_currentColorChanged(...)` * `dlgRoomSymbol::openColorSelector()` ==> `dlgRoomSymbol::slot_openColorSelector()` * `dlgRoomSymbol::resetColor()` ==> `dlgRoomSymbol::slot_resetColors()` * `dlgRoomSymbol::updatePreview()` ==> `dlgRoomSymbol::slot_updatePreview()` * `dlgTriggerEditor::slot_show_vars()` ==> `dlgTriggerEditor::slot_showVariables()` * `dlgTriggerEditor::slot_var_changed(...)` ==> `dlgTriggerEditor::slot_variableChanged(...)` * `dlgTriggerEditor::slot_var_selected(...)` ==> `dlgTriggerEditor::slot_variableSelected(...)` * `mudlet::slot_check_manual_update()` ==> `mudlet::slot_manualUpdateCheck()` * `mudlet::slot_close_current_profile()` ==> `mudlet::slot_closeCurrentProfile()` * `mudlet::slot_close_profile_requested(...)` ==> `mudlet::slot_closeProfileRequested(...)` * `mudlet::slot_connection_dlg_finished(...)` ==> `mudlet::slot_connectionDialogueFinished(...)` * `mudlet::slot_module_manager()` ==> `mudlet::slot_moduleManager()` * `mudlet::slot_mudlet_discord()` ==> `mudlet::slot_mudletDiscord()` * `mudlet::slot_multi_view(...)` ==> `mudlet::slot_multiView(const bool state)` * `mudlet::slot_package_manager()` ==> `mudlet::slot_packageManager()` * `mudlet::slot_package_exporter()` ==> `mudlet::slot_packageExporter()` * `mudlet::slot_timer_fires()` ==> `mudlet::slot_timerFires()` * `mudlet::slot_toggle_multi_view()` ==> `mudlet::slot_toggleMultiView()` Also the names for these in particular have been changed to make more sense: * `dlgProfilePreferences::slot_chooseProfilesChanged()` ==> `dlgProfilePreferences::slot_chosenProfilesChanged()` * `dlgProfilePreferences::slot_editor_tab_selected(...)` ==> `dlgProfilePreferences::slot_tabChanged(...)` * `dlgProfilePreferences::slot_passwords_location_changed(...)` ==> `dlgProfilePreferences::slot_passwordStorageLocationChanged(...)` * `dlgProfilePreferences::slot_save_and_exit()` ==> `dlgProfilePreferences::slot_saveAndClose()` * `dlgTriggerEditor::slot_toggleHiddenVar(...)` ==> `dlgTriggerEditor::slot_hideVariable(...)` - changed to distinguish it from `slot_toggleHiddenVariables(...)` * `dlgTriggerEditor::slot_item_selected_save(...)` ==> `dlgTriggerEditor::slot_saveSelectedItem(...)` * `mudlet::slot_discord()` ==> `mudlet::slot_profileDiscord()` - changed to distinguish it from `slot_mudletDiscord()` Not currently used and commented out: * `dlgProfilePreferences::setCommandLineFont()` ==> `dlgProfilePreferences::slot_setCommandLineFont()` Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-08-29 14:27:13 +02:00
void dlgConnectionProfiles::slot_updateAutoConnect(int state)
Feature: finished all features in connectionDialog + autologon
2009-01-28 02:35:22 +01:00
{
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
QListWidgetItem* pItem = listWidget_profiles->currentItem();
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
if (!pItem) {
Feature: finished all features in connectionDialog + autologon
2009-01-28 02:35:22 +01:00
return;
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
}
Infrastructure: Add short qsl macro to stand in for 'QStringLiteral' (#5640)
2021-12-07 06:21:39 +01:00
writeProfileData(pItem->data(csmNameRole).toString(), qsl("autologin"), QString::number(state));
Feature: finished all features in connectionDialog + autologon
2009-01-28 02:35:22 +01:00
}
Infrastructure: tidy up naming of SLOT methods and their usage - Part 5 (last) (#6266) When Qt's slot/signal system is used to invoke a method there is some overhead - so it makes sense to ensure developers can spot all such methods (functions). We have tried to do this with a `slot_` prefix to the methods we create but it has not been applied uniformly. This PR is intended to conclude helping with this by more rigorously doing so - the names changed herein should all follow a `slot_`*camelCaseMethodName* style. In addition some methods were detected that are not currently used or which are not actually used via the signal/slot system, these have been commented out or have had the prefix removed and the declaration in the relevant header file moved as appropriate. There were two similar sets of (not prefixed with `slot_`) slots in the Profile preferences class that adjusted the colour settings separately for the main console and the mapper the latter had the same names but with a `2` suffix. To made it more clear I have changed them to include `Map` in their names instead. Also, the NON-slot method: `(void) dlgProfilePreferences::setColor(QPushButton*, QColor&, bool)` has been renamed to: `(void) dlgProfilePreferences::setButtonAndProfileColor(QPushButton*, QColor&, bool)` so that it is clearly distinguishable from built in Qt methods that are also called `setColor` - though which do have different signatures! For reference the changes made are: * `TConsole::slot_stop_all_triggers(...)` ==> `TConsole::slot_stopAllItems(...)` * `dlgConnectionProfiles::slot_copy_profile()` ==> `dlgConnectionProfiles::slot_copyProfile()` * `dlgConnectionProfiles::slot_copy_profilesettings_only()` ==> `dlgConnectionProfiles::slot_copyOnlySettingsOfProfile()` * `dlgConnectionProfiles::slot_deleteprofile_check(...)` ==> `dlgConnectionProfiles::slot_deleteProfileCheck(...)` * `dlgConnectionProfiles::slot_password_deleted(...)` ==> `dlgConnectionProfiles::slot_passwordDeleted(...)` * `dlgConnectionProfiles::slot_password_saved(...) ==> `dlgConnectionProfiles::slot_passwordSaved(...)` * `dlgConnectionProfiles::slot_profile_menu(...)` ==> `dlgConnectionProfiles::slot_profileContextMenu(...)` * `dlgConnectionProfiles::slot_reset_custom_icon()` ==> `dlgConnectionProfiles::slot_resetCustomIcon()` * `dlgConnectionProfiles::slot_set_custom_icon()` ==> `dlgConnectionProfiles::slot_setCustomIcon()` * `dlgConnectionProfiles::slot_set_custom_color()` ==> `dlgConnectionProfiles::slot_setCustomColor()` * `dlgConnectionProfiles::slot_update_autologin(...)` ==> `dlgConnectionProfiles::slot_updateAutoConnect(...)` * `dlgConnectionProfiles::slot_update_autoreconnect(...)` ==> `dlgConnectionProfiles::slot_updateAutoReconnect(...)` * `dlgConnectionProfiles::slot_update_description()` ==> `dlgConnectionProfiles::slot_updateDescription()` * `dlgConnectionProfiles::slot_update_discord_optin(...)` ==> `dlgConnectionProfiles::slot_updateDiscordOptIn(...)` * `dlgProfilePreferences::copyMap()` ==> `dlgProfilePreferences::slot_copyMap()` * `dlgProfilePreferences::downloadMap()` ==> `dlgProfilePreferences::slot_downloadMap()` * `dlgProfilePreferences::hideActionLabel()` ==> `dlgProfilePreferences::slot_hideActionLabel()` * `dlgProfilePreferences::loadMap()` ==> `dlgProfilePreferences::slot_loadMap()` * `dlgProfilePreferences::resetColors()` ==> `dlgProfilePreferences::slot_resetColors()` * `dlgProfilePreferences::resetColors2()` ==> `dlgProfilePreferences::slot_resetMapColors()` * `dlgProfilePreferences::saveMap()` ==> `dlgProfilePreferences::slot_saveMap()` * `dlgProfilePreferences::setBgColor()` ==> `dlgProfilePreferences::slot_setBgColor()` * `dlgProfilePreferences::setBgColor2()` ==> `dlgProfilePreferences::slot_setMapBgColor()` * `dlgProfilePreferences::setColorBlack()` ==> `dlgProfilePreferences::slot_setColorBlack()` * `dlgProfilePreferences::setColorBlack2()` ==> `dlgProfilePreferences::slot_setMapColorBlack()` * `dlgProfilePreferences::setColorBlue()` ==> `dlgProfilePreferences::slot_setColorBlue()` * `dlgProfilePreferences::setColorCyan()` ==> `dlgProfilePreferences::slot_setColorCyan()` * `dlgProfilePreferences::setColorBlue2()` ==> `dlgProfilePreferences::slot_setMapColorBlue()` * `dlgProfilePreferences::setColorCyan2()` ==> `dlgProfilePreferences::slot_setMapColorCyan()` * `dlgProfilePreferences::setColorGreen()` ==> `dlgProfilePreferences::slot_setColorGreen()` * `dlgProfilePreferences::setColorGreen2()` ==> `dlgProfilePreferences::slot_setMapColorGreen()` * `dlgProfilePreferences::setColorLightBlack()` ==> `dlgProfilePreferences::slot_setColorLightBlack()` * `dlgProfilePreferences::setColorLightBlack2()` ==> `dlgProfilePreferences::slot_setMapColorLightBlack()` * `dlgProfilePreferences::setColorLightBlue()` ==> `dlgProfilePreferences::slot_setColorLightBlue()` * `dlgProfilePreferences::setColorLightBlue2()` ==> `dlgProfilePreferences::slot_setMapColorLightBlue()` * `dlgProfilePreferences::setColorLightCyan()` ==> `dlgProfilePreferences::slot_setColorLightCyan()` * `dlgProfilePreferences::setColorLightCyan2()` ==> `dlgProfilePreferences::slot_setMapColorLightCyan()` * `dlgProfilePreferences::setColorLightGreen()` ==> `dlgProfilePreferences::slot_setColorLightGreen()` * `dlgProfilePreferences::setColorLightGreen2()` ==> `dlgProfilePreferences::slot_setMapColorLightGreen()` * `dlgProfilePreferences::setColorLightMagenta()` ==> `dlgProfilePreferences::slot_setColorLightMagenta()` * `dlgProfilePreferences::setColorLightMagenta2()` ==> `dlgProfilePreferences::slot_setMapColorLightMagenta()` * `dlgProfilePreferences::setColorLightRed()` ==> `dlgProfilePreferences::slot_setColorLightRed()` * `dlgProfilePreferences::setColorLightRed2()` ==> `dlgProfilePreferences::slot_setMapColorLightRed()` * `dlgProfilePreferences::setColorLightWhite()` ==> `dlgProfilePreferences::slot_setColorLightWhite()` * `dlgProfilePreferences::setColorLightWhite2()` ==> `dlgProfilePreferences::slot_setMapColorLightWhite()` * `dlgProfilePreferences::setColorLightYellow()` ==> `dlgProfilePreferences::slot_setColorLightYellow()` * `dlgProfilePreferences::setColorLightYellow2()` ==> `dlgProfilePreferences::slot_setMapColorLightYellow()` * `dlgProfilePreferences::setColorMagenta()` ==> `dlgProfilePreferences::slot_setColorMagenta()` * `dlgProfilePreferences::setColorMagenta2()` ==> `dlgProfilePreferences::slot_setMapColorMagenta()` * `dlgProfilePreferences::setColorRed2()` ==> `dlgProfilePreferences::slot_setMapColorRed()` * `dlgProfilePreferences::setColorRed()` ==> `dlgProfilePreferences::slot_setColorRed()` * `dlgProfilePreferences::setColorWhite()` ==> `dlgProfilePreferences::slot_setColorWhite()` * `dlgProfilePreferences::setColorWhite2()` ==> `dlgProfilePreferences::slot_setMapColorWhite()` * `dlgProfilePreferences::setColorYellow()` ==> `dlgProfilePreferences::slot_setColorYellow()` * `dlgProfilePreferences::setColorYellow2()` ==> `dlgProfilePreferences::slot_setMapColorYellow()` * `dlgProfilePreferences::setCommandBgColor()` ==> `dlgProfilePreferences::slot_setCommandBgColor()` * `dlgProfilePreferences::setCommandFgColor()` ==> `dlgProfilePreferences::slot_setCommandFgColor()` * `dlgProfilePreferences::setCommandLineBgColor()` ==> `dlgProfilePreferences::slot_setCommandLineBgColor()` * `dlgProfilePreferences::setCommandLineFgColor()` ==> `dlgProfilePreferences::slot_setCommandLineFgColor()` * `dlgProfilePreferences::setDisplayFont()` ==> `dlgProfilePreferences::slot_setDisplayFont()` * `dlgProfilePreferences::setFgColor()` ==> `dlgProfilePreferences::slot_setFgColor()` * `dlgProfilePreferences::setFgColor2()` ==> `dlgProfilePreferences::slot_setMapExitsColor()` * `dlgProfilePreferences::setFontSize()` ==> `dlgProfilePreferences::slot_setFontSize()` * `dlgProfilePreferences::setMapInfoBackground()` ==> `dlgProfilePreferences::slot_setMapInfoBgColor()` * `dlgProfilePreferences::setRoomBorderColor()` ==> `dlgProfilePreferences::slot_setMapRoomBorderColor()` * `dlgProfilePreferences::slot_script_selected(...)` ==> `dlgProfilePreferences::slot_scriptSelected(...)` * `dlgProfilePreferences::slot_theme_selected(...)` ==> `dlgProfilePreferences::slot_themeSelected(...)` * `dlgRoomSymbol::colorRejected()` ==> `dlgRoomSymbol::slot_colorRejected()` * `dlgRoomSymbol::colorSelected(...)` ==> `dlgRoomSymbol::slot_colorSelected(...)` * `dlgRoomSymbol::currentColorChanged(...)` ==> `dlgRoomSymbol::slot_currentColorChanged(...)` * `dlgRoomSymbol::openColorSelector()` ==> `dlgRoomSymbol::slot_openColorSelector()` * `dlgRoomSymbol::resetColor()` ==> `dlgRoomSymbol::slot_resetColors()` * `dlgRoomSymbol::updatePreview()` ==> `dlgRoomSymbol::slot_updatePreview()` * `dlgTriggerEditor::slot_show_vars()` ==> `dlgTriggerEditor::slot_showVariables()` * `dlgTriggerEditor::slot_var_changed(...)` ==> `dlgTriggerEditor::slot_variableChanged(...)` * `dlgTriggerEditor::slot_var_selected(...)` ==> `dlgTriggerEditor::slot_variableSelected(...)` * `mudlet::slot_check_manual_update()` ==> `mudlet::slot_manualUpdateCheck()` * `mudlet::slot_close_current_profile()` ==> `mudlet::slot_closeCurrentProfile()` * `mudlet::slot_close_profile_requested(...)` ==> `mudlet::slot_closeProfileRequested(...)` * `mudlet::slot_connection_dlg_finished(...)` ==> `mudlet::slot_connectionDialogueFinished(...)` * `mudlet::slot_module_manager()` ==> `mudlet::slot_moduleManager()` * `mudlet::slot_mudlet_discord()` ==> `mudlet::slot_mudletDiscord()` * `mudlet::slot_multi_view(...)` ==> `mudlet::slot_multiView(const bool state)` * `mudlet::slot_package_manager()` ==> `mudlet::slot_packageManager()` * `mudlet::slot_package_exporter()` ==> `mudlet::slot_packageExporter()` * `mudlet::slot_timer_fires()` ==> `mudlet::slot_timerFires()` * `mudlet::slot_toggle_multi_view()` ==> `mudlet::slot_toggleMultiView()` Also the names for these in particular have been changed to make more sense: * `dlgProfilePreferences::slot_chooseProfilesChanged()` ==> `dlgProfilePreferences::slot_chosenProfilesChanged()` * `dlgProfilePreferences::slot_editor_tab_selected(...)` ==> `dlgProfilePreferences::slot_tabChanged(...)` * `dlgProfilePreferences::slot_passwords_location_changed(...)` ==> `dlgProfilePreferences::slot_passwordStorageLocationChanged(...)` * `dlgProfilePreferences::slot_save_and_exit()` ==> `dlgProfilePreferences::slot_saveAndClose()` * `dlgTriggerEditor::slot_toggleHiddenVar(...)` ==> `dlgTriggerEditor::slot_hideVariable(...)` - changed to distinguish it from `slot_toggleHiddenVariables(...)` * `dlgTriggerEditor::slot_item_selected_save(...)` ==> `dlgTriggerEditor::slot_saveSelectedItem(...)` * `mudlet::slot_discord()` ==> `mudlet::slot_profileDiscord()` - changed to distinguish it from `slot_mudletDiscord()` Not currently used and commented out: * `dlgProfilePreferences::setCommandLineFont()` ==> `dlgProfilePreferences::slot_setCommandLineFont()` Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-08-29 14:27:13 +02:00
void dlgConnectionProfiles::slot_updateAutoReconnect(int state)
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
{
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
QListWidgetItem* pItem = listWidget_profiles->currentItem();
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
if (!pItem) {
return;
}
Infrastructure: Add short qsl macro to stand in for 'QStringLiteral' (#5640)
2021-12-07 06:21:39 +01:00
writeProfileData(pItem->data(csmNameRole).toString(), qsl("autoreconnect"), QString::number(state));
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
}
Infrastructure: tidy up naming of SLOT methods and their usage - Part 2 (#6255) When Qt's slot/signal system is used to invoke a method there is some overhead - so it makes sense to ensure developers can spot all such methods (functions). We have tried to do this with a `slot_` prefix to the methods we create but it has not been applied uniformly. This PR (and one or more to follow) is intended to help with this by more rigorously doing so - the names changed herein should all follow a `slot_`*camelCaseMethodName* style. In addition some methods were detected that are not currently used or which are not actually used via the signal/slot system, these have been commented out or have had the prefix removed and the declaration in the relevant header file moved as appropriate. For reference the changes made are: * `TLuaInterpreter::slotDeleteSender(...)` ==> `TLuaInterpreter::slot_deleteSender(...)` * `TLuaInterpreter::slotPurge()` ==> `TLuaInterpreter::slot_purge()` * `cTelnet::handle_socket_signal_connected()` ==> `cTelnet::slot_socketConnected()` * `cTelnet::handle_socket_signal_disconnected()` ==> `cTelnet::slot_socketDisconnected()` * `cTelnet::handle_socket_signal_hostFound(...)` ==> `cTelnet::slot_socketHostFound(...)` * `cTelnet::handle_socket_signal_readyRead()` ==> `cTelnet::slot_socketReadyToBeRead()` * `cTelnet::handle_socket_signal_sslError(...)` ==> `cTelnet::slot_socketSslError(...)` * `cTelnet::setDownloadProgress(...)` ==> `cTelnet::slot_setDownloadProgress(...)` * `dlgComposer::cancel()` ==> `dlgComposer::slot_cancel()` * `dlgComposer::save()` ==> `dlgComposer::slot_save()` * `dlgConnectionProfiles::slot_item_clicked(...)` ==> `dlgConnectionProfiles::slot_itemClicked(...)` * `dlgConnectionProfiles::slot_save_name()` ==> `dlgConnectionProfiles::slot_saveName()` * `dlgConnectionProfiles::slot_update_login(...)` ==> `dlgConnectionProfiles::slot_updateLogin(...)` * `dlgConnectionProfiles::slot_update_name(...)` ==> `dlgConnectionProfiles::slot_updateName(...)` * `dlgConnectionProfiles::slot_update_pass(...)` ==> `dlgConnectionProfiles::slot_updatePassword(...)` * `dlgConnectionProfiles::slot_update_port(...)` ==> `dlgConnectionProfiles::slot_updatePort(...)` * `dlgConnectionProfiles::slot_update_SSL_TSL_port(...)` ==> `dlgConnectionProfiles::slot_updateSslTslPort(...)` * `dlgConnectionProfiles::slot_update_url(...)` ==> `dlgConnectionProfiles::slot_updateUrl(...)` * `dlgMapLabel::pickBgColor()` ==> `dlgMapLabel::slot_pickBgColor()` * `dlgMapLabel::pickFgColor()` ==> `dlgMapLabel::slot_pickFgColor()` * `dlgMapLabel::pickFile()` ==> `dlgMapLabel::slot_pickFile()` * `dlgMapLabel::pickFont()` ==> `dlgMapLabel::slot_pickFont()` * `dlgMapLabel::save()` ==> `dlgMapLabel::slot_save()` * `dlgMapLabel::updateControls()` ==> `dlgMapLabel::slot_updateControls()` * `dlgMapLabel::updateControlsVisibility()` ==> `dlgMapLabel::slot_updateControlsVisibility()` Commented out as not being used: * `cTelnet::handle_socket_signal_error()` ==> `cTelnet::slot_socketError()` * `dlgConnectionProfiles::slot_update_website(...) ==> `dlgConnectionProfiles::slot_updateWebsite(const QString& url)` I have my doubts about whether the `dlgMapLabel::save()`/`dlgMapLabel::slot_save()` method is needed at all, as it might be that the `QDialog::accept()` slot could have been inserted into the `QObject::connect(...)` call directly instead...? Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-08-27 10:47:01 +02:00
void dlgConnectionProfiles::slot_updatePort(const QString& ignoreBlank)
merge with experimental secureProfiles branch
2009-01-27 12:46:34 +01:00
{
Infrastructure: mark read-only variables as const (#6843) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Mark read-only variables as const - that is, not intended to change after they've been declared #### Motivation for adding to Mudlet So we don't change them by accident later on, and also to clearly state intentions for the variables #### Other info (issues closed, discussion etc) This is also recommended by the [C++ Core Guidelines](https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#es25-declare-an-object-const-or-constexpr-unless-you-want-to-modify-its-value-later-on)
2023-05-14 15:06:15 +02:00
const QString port = port_entry->text().trimmed();
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
Fixed up a few clazy warnings (#1641) Biggest ones were: 1. https://github.com/KDE/clazy/blob/master/src/checks/level2/README-qstring-allocations.md 1. https://github.com/KDE/clazy/blob/master/src/checks/level2/README-old-style-connect.md
2018-05-14 18:30:48 +02:00
if (ignoreBlank.isEmpty()) {
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
validPort = false;
Add support for opening a profile offline (#2580) * Added Load button to profile selection dialog. * Changed name of load button to offline. * Added successful load message. * Cleaned up some tooltip messages. * Removed obsolete arg historyVersion.
2019-06-01 14:35:50 -06:00
if (offline_button) {
Revise: try and identify profiles and some controls in connection dialog (#3966) Also convert all `setDisabled(state)` to `setEnabled(!state)` in the `dlgConnectionProfiles` class - using a single one instead of a mix of the two is less likely to lead to errors - and it means less effort to search for the places where something is being enabled or disabled. Shorten some overlong variable names. Remove some capitalisations. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2020-08-13 00:57:17 +01:00
offline_button->setEnabled(false);
offline_button->setAccessibleDescription(btn_connOrLoad_disabled_accessDesc);
Add support for opening a profile offline (#2580) * Added Load button to profile selection dialog. * Changed name of load button to offline. * Added successful load message. * Cleaned up some tooltip messages. * Removed obsolete arg historyVersion.
2019-06-01 14:35:50 -06:00
}
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
if (connect_button) {
Revise: try and identify profiles and some controls in connection dialog (#3966) Also convert all `setDisabled(state)` to `setEnabled(!state)` in the `dlgConnectionProfiles` class - using a single one instead of a mix of the two is less likely to lead to errors - and it means less effort to search for the places where something is being enabled or disabled. Shorten some overlong variable names. Remove some capitalisations. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2020-08-13 00:57:17 +01:00
connect_button->setEnabled(false);
connect_button->setAccessibleDescription(btn_connOrLoad_disabled_accessDesc);
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
}
misc
2010-03-15 09:37:16 +01:00
return;
Feature: finished all features in connectionDialog + autologon
2009-01-28 02:35:22 +01:00
}
misc
2010-03-15 09:37:16 +01:00
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
if (validateProfile()) {
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
QListWidgetItem* pItem = listWidget_profiles->currentItem();
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
if (!pItem) {
return;
merge with experimental secureProfiles branch
2009-01-27 12:46:34 +01:00
}
Infrastructure: Add short qsl macro to stand in for 'QStringLiteral' (#5640)
2021-12-07 06:21:39 +01:00
writeProfileData(pItem->data(csmNameRole).toString(), qsl("port"), port);
merge with experimental secureProfiles branch
2009-01-27 12:46:34 +01:00
}
start
2009-01-24 02:50:22 +01:00
}
Infrastructure: tidy up naming of SLOT methods and their usage - Part 2 (#6255) When Qt's slot/signal system is used to invoke a method there is some overhead - so it makes sense to ensure developers can spot all such methods (functions). We have tried to do this with a `slot_` prefix to the methods we create but it has not been applied uniformly. This PR (and one or more to follow) is intended to help with this by more rigorously doing so - the names changed herein should all follow a `slot_`*camelCaseMethodName* style. In addition some methods were detected that are not currently used or which are not actually used via the signal/slot system, these have been commented out or have had the prefix removed and the declaration in the relevant header file moved as appropriate. For reference the changes made are: * `TLuaInterpreter::slotDeleteSender(...)` ==> `TLuaInterpreter::slot_deleteSender(...)` * `TLuaInterpreter::slotPurge()` ==> `TLuaInterpreter::slot_purge()` * `cTelnet::handle_socket_signal_connected()` ==> `cTelnet::slot_socketConnected()` * `cTelnet::handle_socket_signal_disconnected()` ==> `cTelnet::slot_socketDisconnected()` * `cTelnet::handle_socket_signal_hostFound(...)` ==> `cTelnet::slot_socketHostFound(...)` * `cTelnet::handle_socket_signal_readyRead()` ==> `cTelnet::slot_socketReadyToBeRead()` * `cTelnet::handle_socket_signal_sslError(...)` ==> `cTelnet::slot_socketSslError(...)` * `cTelnet::setDownloadProgress(...)` ==> `cTelnet::slot_setDownloadProgress(...)` * `dlgComposer::cancel()` ==> `dlgComposer::slot_cancel()` * `dlgComposer::save()` ==> `dlgComposer::slot_save()` * `dlgConnectionProfiles::slot_item_clicked(...)` ==> `dlgConnectionProfiles::slot_itemClicked(...)` * `dlgConnectionProfiles::slot_save_name()` ==> `dlgConnectionProfiles::slot_saveName()` * `dlgConnectionProfiles::slot_update_login(...)` ==> `dlgConnectionProfiles::slot_updateLogin(...)` * `dlgConnectionProfiles::slot_update_name(...)` ==> `dlgConnectionProfiles::slot_updateName(...)` * `dlgConnectionProfiles::slot_update_pass(...)` ==> `dlgConnectionProfiles::slot_updatePassword(...)` * `dlgConnectionProfiles::slot_update_port(...)` ==> `dlgConnectionProfiles::slot_updatePort(...)` * `dlgConnectionProfiles::slot_update_SSL_TSL_port(...)` ==> `dlgConnectionProfiles::slot_updateSslTslPort(...)` * `dlgConnectionProfiles::slot_update_url(...)` ==> `dlgConnectionProfiles::slot_updateUrl(...)` * `dlgMapLabel::pickBgColor()` ==> `dlgMapLabel::slot_pickBgColor()` * `dlgMapLabel::pickFgColor()` ==> `dlgMapLabel::slot_pickFgColor()` * `dlgMapLabel::pickFile()` ==> `dlgMapLabel::slot_pickFile()` * `dlgMapLabel::pickFont()` ==> `dlgMapLabel::slot_pickFont()` * `dlgMapLabel::save()` ==> `dlgMapLabel::slot_save()` * `dlgMapLabel::updateControls()` ==> `dlgMapLabel::slot_updateControls()` * `dlgMapLabel::updateControlsVisibility()` ==> `dlgMapLabel::slot_updateControlsVisibility()` Commented out as not being used: * `cTelnet::handle_socket_signal_error()` ==> `cTelnet::slot_socketError()` * `dlgConnectionProfiles::slot_update_website(...) ==> `dlgConnectionProfiles::slot_updateWebsite(const QString& url)` I have my doubts about whether the `dlgMapLabel::save()`/`dlgMapLabel::slot_save()` method is needed at all, as it might be that the `QDialog::accept()` slot could have been inserted into the `QObject::connect(...)` call directly instead...? Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-08-27 10:47:01 +02:00
void dlgConnectionProfiles::slot_updateSslTslPort(int state)
merge with experimental secureProfiles branch
2009-01-27 12:46:34 +01:00
{
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
if (validateProfile()) {
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
QListWidgetItem* pItem = listWidget_profiles->currentItem();
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
if (!pItem) {
return;
misc
2010-01-22 01:45:34 +01:00
}
Infrastructure: Add short qsl macro to stand in for 'QStringLiteral' (#5640)
2021-12-07 06:21:39 +01:00
writeProfileData(pItem->data(csmNameRole).toString(), qsl("ssl_tsl"), QString::number(state));
misc
2010-01-22 01:45:34 +01:00
}
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
}
Update: remove Midkemia (and add WoTMUD) to list of predefined MUDs (#321) * Update: remove Midkemia (and add WoTMUD) to list of predefined MUDs The I.R.E. MUD Midkemia-online was shutdown on 2016/09/07 and it is not helpful to continue to offer it as a predefined MUD in the connection dialog. This commit removes it from that list and adds a favourite of mine "WoTMUD" to replace it. The logo is a temporary one that I will replace with a similar one that I need to get clearance to use (and release with a GPL2.1+ licence) from the Wheel of Time MUD sysop with whom I am in contact {Vivienne needs to get approval from the creator Flash who is away for a few days...!} The dlgConnectionProfiles.cpp file has quite a few ASCII strings, as appropriate for a file that will in the future be subject to I18n work I took the opportunity to put QStringLiteral(...) wrappers around the QStrings that are used for non-GUI tasks and tr(...) ones that are. I expect it isn't complete but it goes someway towards dealing with THIS particular file - and it should improve very slightly the generation of QStrings that need to be constructed because it means as much of possible of them is done at compile rather than run-time...! In relation to the above there are points in the code where QStrings are compared to "" to see if they do not have any contents - the isEmpty() method is a better way to do the same (it does not involve a string expression) In (void)dlgConnectionProfiles::slot_update_name( const QString ) there are a couple of variables that use a double underscore prefix - that is NOT A Good Idea: such a prefix is RESERVED in both C and C++. For example see: [what-are-the-rules-about-using-an-underscore-in-a-c-identifier](http://stackoverflow.com/questions/228783/what-are-the-rules-about-using-an-underscore-in-a-c-identifier) also a single prefix might be a bit of a problem with libraries... I have renames the offending things there - but I may have used the single underscore prefix myself in the past. *blush* There are some help messages in this class that use an apostrophe in a word contraction - as a matter of readability this is not considered best practice IMHO so I have converted them to the full words. Following experiences in my previous Pull Request I also took a look at the initialisation and use of some member variables; it became clear that: * (QString) dlgConnectionProfiles::mOrigin * (bool) dlgConnectionProfiles::mEditOK were not used and could be simply deleted and that: * (QString) dlgConnectionProfiles::mUnsavedProfileName * (QString) dlgConnectionProfiles::mCurrentProfileEditName did not need to be member variables and could be local to the method that used them, so in (void)dlgConnectionProfiles::slot_save_name(): * (QString) dlgConnectionProfiles::mCurrentProfileEditName becomes local: (QString) currentProfileEditName and in (void) dlgConnectionProfiles::slot_addProfile(): * (QString) dlgConnectionProfiles::mUnsavedProfileName becomes local: (QString) newName also added initialisers for: * (QStringList) dlgConnectionProfiles::mProfileList * (QPushButton *) dlgConnectionProfiles::connect_button * (QLineEditQPushButton *) dlgConnectionProfiles::delete_profile_lineedit * (QPushButton *) dlgConnectionProfiles::delete_button Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * More: two items missed from prior commit In the previous commit I forgot to take out: * a check for Midkemia in the dlgProfilePreferences class constructor that enabled the download map options; * a similar check in (bool)TMap::restore(QString) that asked if the user wanted to download a map if there was not one found. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * Tweak: Insert MUD supplied Logo/Icon Received an icon as a .jpg that the MUD operators can allow us to licence as GPL2.1+ which I have converted to a .png file. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2016-10-15 09:57:17 +01:00
Infrastructure: tidy up naming of SLOT methods and their usage - Part 2 (#6255) When Qt's slot/signal system is used to invoke a method there is some overhead - so it makes sense to ensure developers can spot all such methods (functions). We have tried to do this with a `slot_` prefix to the methods we create but it has not been applied uniformly. This PR (and one or more to follow) is intended to help with this by more rigorously doing so - the names changed herein should all follow a `slot_`*camelCaseMethodName* style. In addition some methods were detected that are not currently used or which are not actually used via the signal/slot system, these have been commented out or have had the prefix removed and the declaration in the relevant header file moved as appropriate. For reference the changes made are: * `TLuaInterpreter::slotDeleteSender(...)` ==> `TLuaInterpreter::slot_deleteSender(...)` * `TLuaInterpreter::slotPurge()` ==> `TLuaInterpreter::slot_purge()` * `cTelnet::handle_socket_signal_connected()` ==> `cTelnet::slot_socketConnected()` * `cTelnet::handle_socket_signal_disconnected()` ==> `cTelnet::slot_socketDisconnected()` * `cTelnet::handle_socket_signal_hostFound(...)` ==> `cTelnet::slot_socketHostFound(...)` * `cTelnet::handle_socket_signal_readyRead()` ==> `cTelnet::slot_socketReadyToBeRead()` * `cTelnet::handle_socket_signal_sslError(...)` ==> `cTelnet::slot_socketSslError(...)` * `cTelnet::setDownloadProgress(...)` ==> `cTelnet::slot_setDownloadProgress(...)` * `dlgComposer::cancel()` ==> `dlgComposer::slot_cancel()` * `dlgComposer::save()` ==> `dlgComposer::slot_save()` * `dlgConnectionProfiles::slot_item_clicked(...)` ==> `dlgConnectionProfiles::slot_itemClicked(...)` * `dlgConnectionProfiles::slot_save_name()` ==> `dlgConnectionProfiles::slot_saveName()` * `dlgConnectionProfiles::slot_update_login(...)` ==> `dlgConnectionProfiles::slot_updateLogin(...)` * `dlgConnectionProfiles::slot_update_name(...)` ==> `dlgConnectionProfiles::slot_updateName(...)` * `dlgConnectionProfiles::slot_update_pass(...)` ==> `dlgConnectionProfiles::slot_updatePassword(...)` * `dlgConnectionProfiles::slot_update_port(...)` ==> `dlgConnectionProfiles::slot_updatePort(...)` * `dlgConnectionProfiles::slot_update_SSL_TSL_port(...)` ==> `dlgConnectionProfiles::slot_updateSslTslPort(...)` * `dlgConnectionProfiles::slot_update_url(...)` ==> `dlgConnectionProfiles::slot_updateUrl(...)` * `dlgMapLabel::pickBgColor()` ==> `dlgMapLabel::slot_pickBgColor()` * `dlgMapLabel::pickFgColor()` ==> `dlgMapLabel::slot_pickFgColor()` * `dlgMapLabel::pickFile()` ==> `dlgMapLabel::slot_pickFile()` * `dlgMapLabel::pickFont()` ==> `dlgMapLabel::slot_pickFont()` * `dlgMapLabel::save()` ==> `dlgMapLabel::slot_save()` * `dlgMapLabel::updateControls()` ==> `dlgMapLabel::slot_updateControls()` * `dlgMapLabel::updateControlsVisibility()` ==> `dlgMapLabel::slot_updateControlsVisibility()` Commented out as not being used: * `cTelnet::handle_socket_signal_error()` ==> `cTelnet::slot_socketError()` * `dlgConnectionProfiles::slot_update_website(...) ==> `dlgConnectionProfiles::slot_updateWebsite(const QString& url)` I have my doubts about whether the `dlgMapLabel::save()`/`dlgMapLabel::slot_save()` method is needed at all, as it might be that the `QDialog::accept()` slot could have been inserted into the `QObject::connect(...)` call directly instead...? Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-08-27 10:47:01 +02:00
void dlgConnectionProfiles::slot_updateName(const QString& newName)
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
{
Revise: prevent multiple connection dialogues This will close Issue: #2706. Also fix a couple of warnings for the `dlgConnectionProfiles` class: * an out of order initialisation list * an unused argument in: `(void) dlgConnectionProfiles::slot_update_name(const QString&)` Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2020-06-28 23:37:23 +01:00
Q_UNUSED(newName)
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
validateProfile();
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
}
Infrastructure: tidy up naming of SLOT methods and their usage - Part 2 (#6255) When Qt's slot/signal system is used to invoke a method there is some overhead - so it makes sense to ensure developers can spot all such methods (functions). We have tried to do this with a `slot_` prefix to the methods we create but it has not been applied uniformly. This PR (and one or more to follow) is intended to help with this by more rigorously doing so - the names changed herein should all follow a `slot_`*camelCaseMethodName* style. In addition some methods were detected that are not currently used or which are not actually used via the signal/slot system, these have been commented out or have had the prefix removed and the declaration in the relevant header file moved as appropriate. For reference the changes made are: * `TLuaInterpreter::slotDeleteSender(...)` ==> `TLuaInterpreter::slot_deleteSender(...)` * `TLuaInterpreter::slotPurge()` ==> `TLuaInterpreter::slot_purge()` * `cTelnet::handle_socket_signal_connected()` ==> `cTelnet::slot_socketConnected()` * `cTelnet::handle_socket_signal_disconnected()` ==> `cTelnet::slot_socketDisconnected()` * `cTelnet::handle_socket_signal_hostFound(...)` ==> `cTelnet::slot_socketHostFound(...)` * `cTelnet::handle_socket_signal_readyRead()` ==> `cTelnet::slot_socketReadyToBeRead()` * `cTelnet::handle_socket_signal_sslError(...)` ==> `cTelnet::slot_socketSslError(...)` * `cTelnet::setDownloadProgress(...)` ==> `cTelnet::slot_setDownloadProgress(...)` * `dlgComposer::cancel()` ==> `dlgComposer::slot_cancel()` * `dlgComposer::save()` ==> `dlgComposer::slot_save()` * `dlgConnectionProfiles::slot_item_clicked(...)` ==> `dlgConnectionProfiles::slot_itemClicked(...)` * `dlgConnectionProfiles::slot_save_name()` ==> `dlgConnectionProfiles::slot_saveName()` * `dlgConnectionProfiles::slot_update_login(...)` ==> `dlgConnectionProfiles::slot_updateLogin(...)` * `dlgConnectionProfiles::slot_update_name(...)` ==> `dlgConnectionProfiles::slot_updateName(...)` * `dlgConnectionProfiles::slot_update_pass(...)` ==> `dlgConnectionProfiles::slot_updatePassword(...)` * `dlgConnectionProfiles::slot_update_port(...)` ==> `dlgConnectionProfiles::slot_updatePort(...)` * `dlgConnectionProfiles::slot_update_SSL_TSL_port(...)` ==> `dlgConnectionProfiles::slot_updateSslTslPort(...)` * `dlgConnectionProfiles::slot_update_url(...)` ==> `dlgConnectionProfiles::slot_updateUrl(...)` * `dlgMapLabel::pickBgColor()` ==> `dlgMapLabel::slot_pickBgColor()` * `dlgMapLabel::pickFgColor()` ==> `dlgMapLabel::slot_pickFgColor()` * `dlgMapLabel::pickFile()` ==> `dlgMapLabel::slot_pickFile()` * `dlgMapLabel::pickFont()` ==> `dlgMapLabel::slot_pickFont()` * `dlgMapLabel::save()` ==> `dlgMapLabel::slot_save()` * `dlgMapLabel::updateControls()` ==> `dlgMapLabel::slot_updateControls()` * `dlgMapLabel::updateControlsVisibility()` ==> `dlgMapLabel::slot_updateControlsVisibility()` Commented out as not being used: * `cTelnet::handle_socket_signal_error()` ==> `cTelnet::slot_socketError()` * `dlgConnectionProfiles::slot_update_website(...) ==> `dlgConnectionProfiles::slot_updateWebsite(const QString& url)` I have my doubts about whether the `dlgMapLabel::save()`/`dlgMapLabel::slot_save()` method is needed at all, as it might be that the `QDialog::accept()` slot could have been inserted into the `QObject::connect(...)` call directly instead...? Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-08-27 10:47:01 +02:00
void dlgConnectionProfiles::slot_saveName()
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
{
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
QListWidgetItem* pItem = listWidget_profiles->currentItem();
Infrastructure: mark read-only variables as const (#6843) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Mark read-only variables as const - that is, not intended to change after they've been declared #### Motivation for adding to Mudlet So we don't change them by accident later on, and also to clearly state intentions for the variables #### Other info (issues closed, discussion etc) This is also recommended by the [C++ Core Guidelines](https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#es25-declare-an-object-const-or-constexpr-unless-you-want-to-modify-its-value-later-on)
2023-05-14 15:06:15 +02:00
const QString newProfileName = profile_name_entry->text().trimmed();
const QString newProfileHost = host_name_entry->text().trimmed();
const QString newProfilePort = port_entry->text().trimmed();
const int newProfileSslTsl = port_ssl_tsl->isChecked() * 2;
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
Fix: newly created profiles will remember their connection info (#5245)
2021-06-22 19:22:08 +02:00
validateProfile();
Fix new profiles to be saved correctly when created (#2677)
2019-06-29 12:06:56 +02:00
if (!validName || newProfileName.isEmpty() || !pItem) {
misc
2010-03-15 09:37:16 +01:00
return;
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
}
misc
2010-01-22 01:45:34 +01:00
Infrastructure: mark read-only variables as const (#6843) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Mark read-only variables as const - that is, not intended to change after they've been declared #### Motivation for adding to Mudlet So we don't change them by accident later on, and also to clearly state intentions for the variables #### Other info (issues closed, discussion etc) This is also recommended by the [C++ Core Guidelines](https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#es25-declare-an-object-const-or-constexpr-unless-you-want-to-modify-its-value-later-on)
2023-05-14 15:06:15 +02:00
const QString currentProfileEditName = pItem->data(csmNameRole).toString();
Fix new profiles to be saved correctly when created (#2677)
2019-06-29 12:06:56 +02:00
// don't do anything if this was just a normal click, and not an edit of any sort
if (currentProfileEditName == newProfileName) {
return;
}
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
Add a Mudlet Tutorial profile. (#8188) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Adds a Mudlet Tutorial profile which incorporates a basic GUI tutorial and mini-mud quest. GUI tutorial introduces the main window, command line, search bar, toolbar, map. Mini-quest attempts to act like a MUD. Teaches directional commands and some typical verbs (look, buy, give, get, open, close, quit) while the player wanders around trying to figure out the two 'quests' (buy the sheriff some lunch and find the librarian's lost ring). It is simplistic and more designed to show players how a mud 'feels and progresses' when playing rather than a full blown MUD school which most (all?) MUDs incorporate. #### Motivation for adding to Mudlet Help on-boarding new users. Destination 5.0. /claim #3072 helps #2823 #### Other info (issues closed, discussion etc) I purposefully left out triggers, scripting and all that stuff veteran players take for granted! This is supposed to be an on-boarding tutorial for NEW players, let's not overwhelm them. A link after successful completion of the game introduces the wiki Introduction page for more advanced topics. That said, any improvements or basic features you think are missing from either the GUI or Mud tutorials, let me know and I can add. https://github.com/user-attachments/assets/1d16db50-e24b-4e78-b6b0-66e0e98a0772
2025-09-13 14:17:13 +07:00
// Check for orphaned keychain entries when creating a new profile with a name
// that doesn't exist as a directory but might have keychain entries from
Improve: Clean up keychain entries when deleting profiles and creating new ones (#8103) #### Brief overview of PR changes/additions Adds keychain cleanup functionality to connection profile management: - **Profile deletion cleanup**: When deleting profiles via the "Remove" button, now removes associated keychain entries ("character" and "proxy" passwords) in addition to removing profile directories - **Orphaned entry detection**: When creating new profiles, detects and removes orphaned keychain entries from profiles previously deleted outside Mudlet interface - **Async implementation**: Uses existing CredentialManager async API with proper callback handling and debug logging - **Helper method**: Refactored profile save logic into `continueProfileSave()` to support async orphaned entry cleanup #### Motivation for adding to Mudlet Prevents accumulation of orphaned credentials in system keychains (macOS Keychain, Windows Credential Store, Linux Secret Service) by ensuring complete profile lifecycle management. Previously, keychain entries were left behind when profiles were deleted, and orphaned entries could interfere with new profile creation. #### Other info (issues closed, discussion etc) Builds upon the secure credential management system from PR #7956. Follows the same async architecture patterns with non-blocking UI operations, proper memory management, and callback-based error handling. Changes are only active when secure password storage is enabled. --- Video with evidence of the keychain being cleared after a profile was created, closed, removed, recreated: https://github.com/user-attachments/assets/a5e3e126-8b49-4871-8445-97b938a7c57e --- Video with evidence of the keychain being cleared upon re-creating a profile that has a keychain entry in the past: https://github.com/user-attachments/assets/15b86307-783d-49a4-87cc-06e28a5674b1
2025-08-28 07:03:30 -04:00
// a previously deleted profile (deleted outside Mudlet interface)
if (mudlet::self()->storingPasswordsSecurely() && currentProfileEditName == tr("new profile name") && !QDir(mudlet::getMudletPath(enums::profileHomePath, newProfileName)).exists()) {
// Check if there are orphaned keychain entries for this profile name
Fix: Crash when removing default MUD profiles from welcome window (#8916) #### Brief overview of PR changes/additions Fixes a crash that occurred when users tried to remove the default MUD profiles from the welcome window on Linux. #### Motivation for adding to Mudlet Users on Linux were experiencing crashes when clicking the remove button on the default game profiles in the connection dialog. This made it difficult to clean up the profile list. #### Other info (issues closed, discussion etc) Closes #8907 The fix ensures that password cleanup operations happen one at a time instead of simultaneously, and adds safety checks to handle cases where the dialog might close during the cleanup process.
2026-02-09 05:44:01 -05:00
// Use QPointer to safely detect if dialog or credManager is destroyed during async operations
// Create CredentialManager without a parent to avoid destruction when dialog closes
QPointer<dlgConnectionProfiles> safeThis = this;
QPointer<CredentialManager> safeCredManager = new CredentialManager(nullptr);
safeCredManager->retrievePassword(
Fix: prevent password loss in PTBs and improve credential debug messages (#8257) #### Brief overview of PR changes/additions - Fixed a bug where users lost their saved passwords when switching between different Mudlet versions - Added safety checks to prevent password deletion unless you're using a newer version (4.20.0+) - Made error messages clearer and more helpful when password loading fails - Improved the system's ability to find passwords stored in different locations - Added better logging to help diagnose password-related issues #### Motivation for adding to Mudlet Users reported that their saved passwords disappeared after trying development versions of Mudlet. This happened because the system was automatically cleaning up old password storage without considering that users might switch back to older versions. The unclear error messages also made it difficult to understand what was happening when passwords couldn't be loaded. #### Other info (issues closed, discussion etc) This fix ensures users can safely test different Mudlet versions without losing their saved passwords. It also makes password-related problems easier to understand and troubleshoot, while maintaining compatibility with all existing Mudlet installations. --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-09-24 07:28:15 -04:00
newProfileName,
"character",
Fix: Crash when removing default MUD profiles from welcome window (#8916) #### Brief overview of PR changes/additions Fixes a crash that occurred when users tried to remove the default MUD profiles from the welcome window on Linux. #### Motivation for adding to Mudlet Users on Linux were experiencing crashes when clicking the remove button on the default game profiles in the connection dialog. This made it difficult to clean up the profile list. #### Other info (issues closed, discussion etc) Closes #8907 The fix ensures that password cleanup operations happen one at a time instead of simultaneously, and adds safety checks to handle cases where the dialog might close during the cleanup process.
2026-02-09 05:44:01 -05:00
[safeThis, safeCredManager, currentProfileEditName, newProfileName, newProfileHost, newProfilePort, newProfileSslTsl](
bool foundCharacterEntry, const QString& characterPassword, const QString& errorMessage) {
Improve: Clean up keychain entries when deleting profiles and creating new ones (#8103) #### Brief overview of PR changes/additions Adds keychain cleanup functionality to connection profile management: - **Profile deletion cleanup**: When deleting profiles via the "Remove" button, now removes associated keychain entries ("character" and "proxy" passwords) in addition to removing profile directories - **Orphaned entry detection**: When creating new profiles, detects and removes orphaned keychain entries from profiles previously deleted outside Mudlet interface - **Async implementation**: Uses existing CredentialManager async API with proper callback handling and debug logging - **Helper method**: Refactored profile save logic into `continueProfileSave()` to support async orphaned entry cleanup #### Motivation for adding to Mudlet Prevents accumulation of orphaned credentials in system keychains (macOS Keychain, Windows Credential Store, Linux Secret Service) by ensuring complete profile lifecycle management. Previously, keychain entries were left behind when profiles were deleted, and orphaned entries could interfere with new profile creation. #### Other info (issues closed, discussion etc) Builds upon the secure credential management system from PR #7956. Follows the same async architecture patterns with non-blocking UI operations, proper memory management, and callback-based error handling. Changes are only active when secure password storage is enabled. --- Video with evidence of the keychain being cleared after a profile was created, closed, removed, recreated: https://github.com/user-attachments/assets/a5e3e126-8b49-4871-8445-97b938a7c57e --- Video with evidence of the keychain being cleared upon re-creating a profile that has a keychain entry in the past: https://github.com/user-attachments/assets/15b86307-783d-49a4-87cc-06e28a5674b1
2025-08-28 07:03:30 -04:00
Q_UNUSED(characterPassword)
Q_UNUSED(errorMessage)
infrastructure: Apply clang-format to all CPP files (#8804) #### Brief overview of PR changes/additions Ran clang-format on all 134 CPP files in src/ using the project's .clang-format config #### Motivation for adding to Mudlet Ensures consistent code formatting across the codebase. #### Other info (issues closed, discussion etc) None **Test case:** Build the project and verify it compiles successfully.
2026-01-19 18:10:44 +01:00
Fix: Crash when removing default MUD profiles from welcome window (#8916) #### Brief overview of PR changes/additions Fixes a crash that occurred when users tried to remove the default MUD profiles from the welcome window on Linux. #### Motivation for adding to Mudlet Users on Linux were experiencing crashes when clicking the remove button on the default game profiles in the connection dialog. This made it difficult to clean up the profile list. #### Other info (issues closed, discussion etc) Closes #8907 The fix ensures that password cleanup operations happen one at a time instead of simultaneously, and adds safety checks to handle cases where the dialog might close during the cleanup process.
2026-02-09 05:44:01 -05:00
// Check if credManager was destroyed
if (!safeCredManager) {
qWarning() << "dlgConnectionProfiles: CredentialManager destroyed during keychain operation, aborting";
return;
}
// Check if dialog was destroyed during async operation
if (!safeThis) {
qWarning() << "dlgConnectionProfiles: Dialog destroyed during keychain operation, aborting";
safeCredManager->deleteLater();
return;
}
safeCredManager->retrievePassword(
newProfileName,
"proxy",
[safeThis, safeCredManager, currentProfileEditName, newProfileName, newProfileHost, newProfilePort, newProfileSslTsl, foundCharacterEntry](
bool foundProxyEntry, const QString& proxyPassword, const QString& errorMessage) {
Q_UNUSED(proxyPassword)
Q_UNUSED(errorMessage)
// Check if credManager was destroyed
if (!safeCredManager) {
qWarning() << "dlgConnectionProfiles: CredentialManager destroyed during keychain operation, aborting";
return;
}
// Check if dialog was destroyed during async operation
if (!safeThis) {
qWarning() << "dlgConnectionProfiles: Dialog destroyed during keychain operation, aborting";
safeCredManager->deleteLater();
return;
}
// Define a helper lambda to continue after cleanup is done
// CredentialManager only supports one operation at a time, so we must chain removals
// Captures QPointers to safely detect if dialog or credManager has been destroyed
// -- each must be checked for null before use
auto continueAfterCleanup = [safeThis, safeCredManager, currentProfileEditName, newProfileName, newProfileHost, newProfilePort, newProfileSslTsl]() {
// Clean up credManager if still valid
if (safeCredManager) {
safeCredManager->deleteLater();
}
// Final safety check before accessing dialog members
if (!safeThis) {
qWarning() << "dlgConnectionProfiles: Dialog destroyed before continueProfileSave, aborting";
return;
}
// Find the current item by the old profile name instead of using a captured pointer
auto items = safeThis->findData(*safeThis->listWidget_profiles, currentProfileEditName, csmNameRole);
if (items.isEmpty()) {
qWarning() << "dlgConnectionProfiles: Could not find profile item for" << currentProfileEditName << "after async operation";
return;
}
safeThis->continueProfileSave(items.first(), newProfileName, newProfileHost, newProfilePort, newProfileSslTsl);
};
// If we found any orphaned entries, clean them up (chained to avoid lost callbacks)
if (foundCharacterEntry && foundProxyEntry) {
// Both need cleanup - chain them
safeCredManager->removePassword(newProfileName, "character", [safeCredManager, newProfileName, continueAfterCleanup](bool success, const QString& errorMessage) {
if (!success) {
qWarning() << "dlgConnectionProfiles: Failed to clean up orphaned character password for" << newProfileName << ":" << errorMessage;
}
// Check credManager before chaining next operation
if (!safeCredManager) {
qWarning() << "dlgConnectionProfiles: CredentialManager destroyed, cannot clean up proxy password";
continueAfterCleanup();
return;
}
// Now clean up proxy (chained)
safeCredManager->removePassword(newProfileName, "proxy", [newProfileName, continueAfterCleanup](bool proxySuccess, const QString& proxyError) {
if (!proxySuccess) {
qWarning() << "dlgConnectionProfiles: Failed to clean up orphaned proxy password for" << newProfileName << ":" << proxyError;
}
continueAfterCleanup();
});
});
} else if (foundCharacterEntry) {
safeCredManager->removePassword(newProfileName, "character", [newProfileName, continueAfterCleanup](bool success, const QString& errorMessage) {
if (!success) {
qWarning() << "dlgConnectionProfiles: Failed to clean up orphaned character password for" << newProfileName << ":" << errorMessage;
}
continueAfterCleanup();
});
} else if (foundProxyEntry) {
safeCredManager->removePassword(newProfileName, "proxy", [newProfileName, continueAfterCleanup](bool success, const QString& errorMessage) {
if (!success) {
qWarning() << "dlgConnectionProfiles: Failed to clean up orphaned proxy password for" << newProfileName << ":" << errorMessage;
}
continueAfterCleanup();
});
} else {
// No cleanup needed
continueAfterCleanup();
}
});
Improve: Clean up keychain entries when deleting profiles and creating new ones (#8103) #### Brief overview of PR changes/additions Adds keychain cleanup functionality to connection profile management: - **Profile deletion cleanup**: When deleting profiles via the "Remove" button, now removes associated keychain entries ("character" and "proxy" passwords) in addition to removing profile directories - **Orphaned entry detection**: When creating new profiles, detects and removes orphaned keychain entries from profiles previously deleted outside Mudlet interface - **Async implementation**: Uses existing CredentialManager async API with proper callback handling and debug logging - **Helper method**: Refactored profile save logic into `continueProfileSave()` to support async orphaned entry cleanup #### Motivation for adding to Mudlet Prevents accumulation of orphaned credentials in system keychains (macOS Keychain, Windows Credential Store, Linux Secret Service) by ensuring complete profile lifecycle management. Previously, keychain entries were left behind when profiles were deleted, and orphaned entries could interfere with new profile creation. #### Other info (issues closed, discussion etc) Builds upon the secure credential management system from PR #7956. Follows the same async architecture patterns with non-blocking UI operations, proper memory management, and callback-based error handling. Changes are only active when secure password storage is enabled. --- Video with evidence of the keychain being cleared after a profile was created, closed, removed, recreated: https://github.com/user-attachments/assets/a5e3e126-8b49-4871-8445-97b938a7c57e --- Video with evidence of the keychain being cleared upon re-creating a profile that has a keychain entry in the past: https://github.com/user-attachments/assets/15b86307-783d-49a4-87cc-06e28a5674b1
2025-08-28 07:03:30 -04:00
});
Add a Mudlet Tutorial profile. (#8188) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Adds a Mudlet Tutorial profile which incorporates a basic GUI tutorial and mini-mud quest. GUI tutorial introduces the main window, command line, search bar, toolbar, map. Mini-quest attempts to act like a MUD. Teaches directional commands and some typical verbs (look, buy, give, get, open, close, quit) while the player wanders around trying to figure out the two 'quests' (buy the sheriff some lunch and find the librarian's lost ring). It is simplistic and more designed to show players how a mud 'feels and progresses' when playing rather than a full blown MUD school which most (all?) MUDs incorporate. #### Motivation for adding to Mudlet Help on-boarding new users. Destination 5.0. /claim #3072 helps #2823 #### Other info (issues closed, discussion etc) I purposefully left out triggers, scripting and all that stuff veteran players take for granted! This is supposed to be an on-boarding tutorial for NEW players, let's not overwhelm them. A link after successful completion of the game introduces the wiki Introduction page for more advanced topics. That said, any improvements or basic features you think are missing from either the GUI or Mud tutorials, let me know and I can add. https://github.com/user-attachments/assets/1d16db50-e24b-4e78-b6b0-66e0e98a0772
2025-09-13 14:17:13 +07:00
Improve: Clean up keychain entries when deleting profiles and creating new ones (#8103) #### Brief overview of PR changes/additions Adds keychain cleanup functionality to connection profile management: - **Profile deletion cleanup**: When deleting profiles via the "Remove" button, now removes associated keychain entries ("character" and "proxy" passwords) in addition to removing profile directories - **Orphaned entry detection**: When creating new profiles, detects and removes orphaned keychain entries from profiles previously deleted outside Mudlet interface - **Async implementation**: Uses existing CredentialManager async API with proper callback handling and debug logging - **Helper method**: Refactored profile save logic into `continueProfileSave()` to support async orphaned entry cleanup #### Motivation for adding to Mudlet Prevents accumulation of orphaned credentials in system keychains (macOS Keychain, Windows Credential Store, Linux Secret Service) by ensuring complete profile lifecycle management. Previously, keychain entries were left behind when profiles were deleted, and orphaned entries could interfere with new profile creation. #### Other info (issues closed, discussion etc) Builds upon the secure credential management system from PR #7956. Follows the same async architecture patterns with non-blocking UI operations, proper memory management, and callback-based error handling. Changes are only active when secure password storage is enabled. --- Video with evidence of the keychain being cleared after a profile was created, closed, removed, recreated: https://github.com/user-attachments/assets/a5e3e126-8b49-4871-8445-97b938a7c57e --- Video with evidence of the keychain being cleared upon re-creating a profile that has a keychain entry in the past: https://github.com/user-attachments/assets/15b86307-783d-49a4-87cc-06e28a5674b1
2025-08-28 07:03:30 -04:00
return; // Exit here - continueProfileSave will be called from the callback
}
Improve: do not try loading or saving password securely when storing them portably (#5678) I was annoyed by all the error messages - both on command line from Mudlet itself and also from (on Linux/FreeBSD) the "wallet" system about not finding passwords from the secure storage system when I have explicitly said that Mudlet is to use the (insecure) PORTABLE method. It is worth noting that the second type of warnings (from the DE/OS) can be highly noticeably as they are popups that require clicking to dismiss them! I also took the liberty of tweaking related command line debugging texts to be formatted slightly differently so that they matched the format I now tend to use: "class::method name(...) WORD - text." with terminal punctuation; insertion of double quotes around strings; and spaces as required manually rather than letting the Qt QDebug class doing it on every element of a message. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2021-12-01 21:53:59 +00:00
if (mudlet::self()->storingPasswordsSecurely()) {
migrateSecuredPassword(currentProfileEditName, newProfileName);
}
Store character's login passwords securely (#3018) * Added QtKeychain * Wire in QtKeychain into qmake build * Install libsecret-dev in Travis * Got read/write working from the secure storage only * Reset password * Change to using a callback instead of a deep chain of nested calls * Wire in CMake build, but doesn't work yet * Finish CMake build, works now * WIP * Add migration to secure storage * Remove left-in debug echo * Don't forget password when profile is renamed * Don't delete passwords upon migration for now * Revise: insert QtKeyChain licence boilerplate (#17) I have use the 2-Clause BSD (a.k.a the FreeBSD) licence that is in the upstream's "COPYING" file - this is at varience with the two README files which quote the licence as being the Modified BSD which is the 3-Clause one. I have an open issue on the upstream repository seeking clarification; should things not be as they seem it should be a relatively painless operation to select the other boillerplate for this item. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2019-09-09 07:37:11 +02:00
Improve: Clean up keychain entries when deleting profiles and creating new ones (#8103) #### Brief overview of PR changes/additions Adds keychain cleanup functionality to connection profile management: - **Profile deletion cleanup**: When deleting profiles via the "Remove" button, now removes associated keychain entries ("character" and "proxy" passwords) in addition to removing profile directories - **Orphaned entry detection**: When creating new profiles, detects and removes orphaned keychain entries from profiles previously deleted outside Mudlet interface - **Async implementation**: Uses existing CredentialManager async API with proper callback handling and debug logging - **Helper method**: Refactored profile save logic into `continueProfileSave()` to support async orphaned entry cleanup #### Motivation for adding to Mudlet Prevents accumulation of orphaned credentials in system keychains (macOS Keychain, Windows Credential Store, Linux Secret Service) by ensuring complete profile lifecycle management. Previously, keychain entries were left behind when profiles were deleted, and orphaned entries could interfere with new profile creation. #### Other info (issues closed, discussion etc) Builds upon the secure credential management system from PR #7956. Follows the same async architecture patterns with non-blocking UI operations, proper memory management, and callback-based error handling. Changes are only active when secure password storage is enabled. --- Video with evidence of the keychain being cleared after a profile was created, closed, removed, recreated: https://github.com/user-attachments/assets/a5e3e126-8b49-4871-8445-97b938a7c57e --- Video with evidence of the keychain being cleared upon re-creating a profile that has a keychain entry in the past: https://github.com/user-attachments/assets/15b86307-783d-49a4-87cc-06e28a5674b1
2025-08-28 07:03:30 -04:00
continueProfileSave(pItem, newProfileName, newProfileHost, newProfilePort, newProfileSslTsl);
}
Add a Mudlet Tutorial profile. (#8188) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Adds a Mudlet Tutorial profile which incorporates a basic GUI tutorial and mini-mud quest. GUI tutorial introduces the main window, command line, search bar, toolbar, map. Mini-quest attempts to act like a MUD. Teaches directional commands and some typical verbs (look, buy, give, get, open, close, quit) while the player wanders around trying to figure out the two 'quests' (buy the sheriff some lunch and find the librarian's lost ring). It is simplistic and more designed to show players how a mud 'feels and progresses' when playing rather than a full blown MUD school which most (all?) MUDs incorporate. #### Motivation for adding to Mudlet Help on-boarding new users. Destination 5.0. /claim #3072 helps #2823 #### Other info (issues closed, discussion etc) I purposefully left out triggers, scripting and all that stuff veteran players take for granted! This is supposed to be an on-boarding tutorial for NEW players, let's not overwhelm them. A link after successful completion of the game introduces the wiki Introduction page for more advanced topics. That said, any improvements or basic features you think are missing from either the GUI or Mud tutorials, let me know and I can add. https://github.com/user-attachments/assets/1d16db50-e24b-4e78-b6b0-66e0e98a0772
2025-09-13 14:17:13 +07:00
void dlgConnectionProfiles::continueProfileSave(QListWidgetItem* pItem, const QString& newProfileName, const QString& newProfileHost, const QString& newProfilePort, const int newProfileSslTsl)
Improve: Clean up keychain entries when deleting profiles and creating new ones (#8103) #### Brief overview of PR changes/additions Adds keychain cleanup functionality to connection profile management: - **Profile deletion cleanup**: When deleting profiles via the "Remove" button, now removes associated keychain entries ("character" and "proxy" passwords) in addition to removing profile directories - **Orphaned entry detection**: When creating new profiles, detects and removes orphaned keychain entries from profiles previously deleted outside Mudlet interface - **Async implementation**: Uses existing CredentialManager async API with proper callback handling and debug logging - **Helper method**: Refactored profile save logic into `continueProfileSave()` to support async orphaned entry cleanup #### Motivation for adding to Mudlet Prevents accumulation of orphaned credentials in system keychains (macOS Keychain, Windows Credential Store, Linux Secret Service) by ensuring complete profile lifecycle management. Previously, keychain entries were left behind when profiles were deleted, and orphaned entries could interfere with new profile creation. #### Other info (issues closed, discussion etc) Builds upon the secure credential management system from PR #7956. Follows the same async architecture patterns with non-blocking UI operations, proper memory management, and callback-based error handling. Changes are only active when secure password storage is enabled. --- Video with evidence of the keychain being cleared after a profile was created, closed, removed, recreated: https://github.com/user-attachments/assets/a5e3e126-8b49-4871-8445-97b938a7c57e --- Video with evidence of the keychain being cleared upon re-creating a profile that has a keychain entry in the past: https://github.com/user-attachments/assets/15b86307-783d-49a4-87cc-06e28a5674b1
2025-08-28 07:03:30 -04:00
{
const QString currentProfileEditName = pItem->data(csmNameRole).toString();
Revise: select profiles by typing the name, keep profile icons (#4440) Restore the text display of the profile name. This is so that the keyboard selection of profiles beginning with a particular letter works again. This will close issue #4283 . This also sets it to the minimum size trying to hide it by setting the font size to 1 - however that still show something (and a font size of zero is NOT valid). Manipulating the QPalette of the QListWidget does not work well enough in the presence of Styles or StyleSheets to be a viable means of hiding the text either. Also in the `dlgConnection` class: * refactor out some highly repetitive code that sets up the predefined Mud icons. * remove warnings and adopts a change introduced into Qt 5.15 for the QLabel::pixmap() which now requires a Qt::ReturnByValue argument to prevent an obsolete code warning and to force a QPixmap to be returned by value and not reference... * remove a warning about: QListWidget::setItemSelected(QListWidgetItem*,bool) being deprecated and switches to the recommended: QListWidgetItem::setSelected(bool) Edit: the last item above may have become redundant as further commits amalgamated into this PR may have taken out these lines anyhow! Change the custom icon generator so that there is NOT a dependency on the position in the list for the colours used. This means that the same name will always have the same colours - which will help the user to pick out a particular profile as it will always look the same no matter if other profiles are added or removed. Remove the colour gradient in the custom icon as it is not thought to be useful nowadays. Refactor out the colour icon generator to a single method that is called from more than one place. BugFix: restore odd original way of accessing some QPixmaps This was causing failures in some CI platforms using Qt 5.14. or older. Revise: really frob the custom icon generator This is to try and produce as varied but still readable icons when they are generated entirely on the basis of the MUD name - in a reproducible (though Qt do NOT guarantee repeatable qHash() functionality across Qt versions - so they may not stay *that* constant) manner. Refrob: use a table of fixed colours Using only 15 hues but with 3 different saturation level plus 5 grey-scale one should give enough different icons but not generate them too close to each other for those with normal colour vision... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Kebap <kebap_spam@gmx.net>
2020-12-11 17:53:28 +00:00
setItemName(pItem, newProfileName);
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
Infrastructure: add `enums.h` (#7646) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Add `enums.h` where we can add enums and flags to be used throughout the application that don't have a more specific place to be, without dragging in giant classes such as mudlet.h or Host.h. Also added `enums::PackageModuleType` to track the magic numbers used throughout package/module code :rocket: #### Motivation for adding to Mudlet Simplify code organisation. #### Other info (issues closed, discussion etc) --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-01-08 10:04:50 +01:00
const QDir currentPath(mudlet::getMudletPath(enums::profileHomePath, currentProfileEditName));
Infrastructure: mark read-only variables as const (#6843) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Mark read-only variables as const - that is, not intended to change after they've been declared #### Motivation for adding to Mudlet So we don't change them by accident later on, and also to clearly state intentions for the variables #### Other info (issues closed, discussion etc) This is also recommended by the [C++ Core Guidelines](https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#es25-declare-an-object-const-or-constexpr-unless-you-want-to-modify-its-value-later-on)
2023-05-14 15:06:15 +02:00
const QDir dir;
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
Fix new profiles to be saved correctly when created (#2677)
2019-06-29 12:06:56 +02:00
if (currentPath.exists()) {
// CHECKME: previous code specified a path ending in a '/'
Infrastructure: add `enums.h` (#7646) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Add `enums.h` where we can add enums and flags to be used throughout the application that don't have a more specific place to be, without dragging in giant classes such as mudlet.h or Host.h. Also added `enums::PackageModuleType` to track the magic numbers used throughout package/module code :rocket: #### Motivation for adding to Mudlet Simplify code organisation. #### Other info (issues closed, discussion etc) --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-01-08 10:04:50 +01:00
QDir parentpath(mudlet::getMudletPath(enums::profilesPath));
Fix new profiles to be saved correctly when created (#2677)
2019-06-29 12:06:56 +02:00
if (!parentpath.rename(currentProfileEditName, newProfileName)) {
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
notificationArea->show();
notificationAreaIconLabelWarning->show();
notificationAreaIconLabelError->hide();
notificationAreaIconLabelInformation->hide();
notificationAreaMessageBox->show();
Fix new profiles to be saved correctly when created (#2677)
2019-06-29 12:06:56 +02:00
notificationAreaMessageBox->setText(tr("Could not rename your profile data on the computer."));
}
Infrastructure: add `enums.h` (#7646) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Add `enums.h` where we can add enums and flags to be used throughout the application that don't have a more specific place to be, without dragging in giant classes such as mudlet.h or Host.h. Also added `enums::PackageModuleType` to track the magic numbers used throughout package/module code :rocket: #### Motivation for adding to Mudlet Simplify code organisation. #### Other info (issues closed, discussion etc) --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-01-08 10:04:50 +01:00
} else if (!dir.mkpath(mudlet::getMudletPath(enums::profileHomePath, newProfileName))) {
Fix new profiles to be saved correctly when created (#2677)
2019-06-29 12:06:56 +02:00
notificationArea->show();
notificationAreaIconLabelWarning->show();
notificationAreaIconLabelError->hide();
notificationAreaIconLabelInformation->hide();
notificationAreaMessageBox->show();
notificationAreaMessageBox->setText(tr("Could not create the new profile folder on your computer."));
}
Fix: Save new profile host info on lost focus (#2919) (#6805) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Re-runs update functions for host, port, and ssl state in the saveName function to make sure they have a valid place in system memory to write to. #### Motivation for adding to Mudlet Better UX #### Other info (issues closed, discussion etc) Fixes #2919 To my mind this could have been solved in one of three ways. 1. Assigning every new profile a unique temporary name, and making sure it's written into storage before any changes can be made to the name and connection settings. This way when host and port are edited first, they have a valid place to write to. This would solve the problem, but would also mean that every single new profile would have to be written to disk upon creation, which from my observation is not how it currently works. 2. Creating a place to hold profile information that can then be saved later in one function, but this would require touching a whole bunch of code and potentially breaking things that I'm not aware of. 3. My current solution. I'm open to trying to implement one of the other two solutions if that would be preferable.
2023-05-07 10:36:18 -07:00
if (!newProfileHost.isEmpty()) {
slot_updateUrl(newProfileHost);
}
if (!newProfilePort.isEmpty()) {
slot_updatePort(newProfilePort);
}
slot_updateSslTslPort(newProfileSslTsl);
Fix new profiles to be saved correctly when created (#2677)
2019-06-29 12:06:56 +02:00
// if this was a previously deleted profile, restore it
auto& settings = *mudlet::self()->mpSettings;
Infrastructure: Add short qsl macro to stand in for 'QStringLiteral' (#5640)
2021-12-07 06:21:39 +01:00
auto deletedDefaultMuds = settings.value(qsl("deletedDefaultMuds"), QStringList()).toStringList();
Fix new profiles to be saved correctly when created (#2677)
2019-06-29 12:06:56 +02:00
if (deletedDefaultMuds.contains(newProfileName)) {
deletedDefaultMuds.removeOne(newProfileName);
Infrastructure: Add short qsl macro to stand in for 'QStringLiteral' (#5640)
2021-12-07 06:21:39 +01:00
settings.setValue(qsl("deletedDefaultMuds"), deletedDefaultMuds);
Fix new profiles to be saved correctly when created (#2677)
2019-06-29 12:06:56 +02:00
// run fillout_form to re-create the default profile icon and description
fillout_form();
// and re-select the profile since focus is lost
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
auto pRestoredItems = findData(*listWidget_profiles, newProfileName, csmNameRole);
Improve: Clean up keychain entries when deleting profiles and creating new ones (#8103) #### Brief overview of PR changes/additions Adds keychain cleanup functionality to connection profile management: - **Profile deletion cleanup**: When deleting profiles via the "Remove" button, now removes associated keychain entries ("character" and "proxy" passwords) in addition to removing profile directories - **Orphaned entry detection**: When creating new profiles, detects and removes orphaned keychain entries from profiles previously deleted outside Mudlet interface - **Async implementation**: Uses existing CredentialManager async API with proper callback handling and debug logging - **Helper method**: Refactored profile save logic into `continueProfileSave()` to support async orphaned entry cleanup #### Motivation for adding to Mudlet Prevents accumulation of orphaned credentials in system keychains (macOS Keychain, Windows Credential Store, Linux Secret Service) by ensuring complete profile lifecycle management. Previously, keychain entries were left behind when profiles were deleted, and orphaned entries could interfere with new profile creation. #### Other info (issues closed, discussion etc) Builds upon the secure credential management system from PR #7956. Follows the same async architecture patterns with non-blocking UI operations, proper memory management, and callback-based error handling. Changes are only active when secure password storage is enabled. --- Video with evidence of the keychain being cleared after a profile was created, closed, removed, recreated: https://github.com/user-attachments/assets/a5e3e126-8b49-4871-8445-97b938a7c57e --- Video with evidence of the keychain being cleared upon re-creating a profile that has a keychain entry in the past: https://github.com/user-attachments/assets/15b86307-783d-49a4-87cc-06e28a5674b1
2025-08-28 07:03:30 -04:00
Q_ASSERT_X(pRestoredItems.count() == 1, "dlgConnectionProfiles::continueProfileSave", "Couldn't find exactly 1 restored profile to select");
Refactor: remove minute visible name from Connection dialogue icons We have been trying to hide the text associated with the `QListWidgetItems` in the connection dialogue by setting the font size to the minimum of `1` and by setting it's colour to be white. This is not effective when the background is not white - which is likely for a "Dark" desktop environment. The only way to successfully hide the text is, I think, to not have any! However the text was being used programmatically, so the best way to use a `QListWidget` in this mannar is to store the text elsewhere in each item's structure. Fortunately Qt provides for this with the user data functionality which allows multiple data items (based on the `QVariant` class) to be stored within each `QListWidgetItem` using an integer key to denote the type of the data. Ironically the text, icon and other details for each item are ALSO stored in this way - however for non-Qt internal use the lowest integer key that is to be used is `Qt::UserRole` - which I have assigned to the `(const int) dlgConnectionProfiles::csmNameRole` static value. It is quite possible that a redesign of the Connect Profiles dialogue may use this system to store/cache more details about each profile in the future! The only issue with this is the lack of a: `QListWidget::findData(const QVarient&data, int role = Qt::UserRole ...)` method (c.f. `QComboBox::findData(...)`) so I have had to provide a: `(QList<QListWidgetItem*>) findData(const QListWidget&, const QVariant&, const int role = Qt::UserRole) const; method to fill in this gap and to replace the previous `QListWidget::find(...)` that examined each item's text. Also removed local `(QString) profile` from: `(void) dlgConnectionProfiles::slot_item_clicked(QListWidgetItem*)` as it is merely a redundent duplicate of another local `(QString) profile_name`. Renamed local `(QListWidgetItem*) pM` from: `(void) dlgConnectionProfiles::fillout_form()` to: `(QListWidgetItem*) pItem` as that reflects the name used throughout the rest of the class for this type of variable. Changed a `(QLabel*)::setText(tr(""))` call to the more explicit and less stupid `(QLabel*)::clear()`. Similarly changed a `(QWidget*)::setToolTip("")` to a `(QWidget*)::setToolTip(QString())`. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2020-07-01 20:59:42 +01:00
Revise: select profiles by typing the name, keep profile icons (#4440) Restore the text display of the profile name. This is so that the keyboard selection of profiles beginning with a particular letter works again. This will close issue #4283 . This also sets it to the minimum size trying to hide it by setting the font size to 1 - however that still show something (and a font size of zero is NOT valid). Manipulating the QPalette of the QListWidget does not work well enough in the presence of Styles or StyleSheets to be a viable means of hiding the text either. Also in the `dlgConnection` class: * refactor out some highly repetitive code that sets up the predefined Mud icons. * remove warnings and adopts a change introduced into Qt 5.15 for the QLabel::pixmap() which now requires a Qt::ReturnByValue argument to prevent an obsolete code warning and to force a QPixmap to be returned by value and not reference... * remove a warning about: QListWidget::setItemSelected(QListWidgetItem*,bool) being deprecated and switches to the recommended: QListWidgetItem::setSelected(bool) Edit: the last item above may have become redundant as further commits amalgamated into this PR may have taken out these lines anyhow! Change the custom icon generator so that there is NOT a dependency on the position in the list for the colours used. This means that the same name will always have the same colours - which will help the user to pick out a particular profile as it will always look the same no matter if other profiles are added or removed. Remove the colour gradient in the custom icon as it is not thought to be useful nowadays. Refactor out the colour icon generator to a single method that is called from more than one place. BugFix: restore odd original way of accessing some QPixmaps This was causing failures in some CI platforms using Qt 5.14. or older. Revise: really frob the custom icon generator This is to try and produce as varied but still readable icons when they are generated entirely on the basis of the MUD name - in a reproducible (though Qt do NOT guarantee repeatable qHash() functionality across Qt versions - so they may not stay *that* constant) manner. Refrob: use a table of fixed colours Using only 15 hues but with 3 different saturation level plus 5 grey-scale one should give enough different icons but not generate them too close to each other for those with normal colour vision... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Kebap <kebap_spam@gmx.net>
2020-12-11 17:53:28 +00:00
// As we are using QAbstractItemView::SingleSelection this will
// automatically unselect the previous item:
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
listWidget_profiles->setCurrentItem(pRestoredItems.first());
Infrastructure: tidy up naming of SLOT methods and their usage - Part 2 (#6255) When Qt's slot/signal system is used to invoke a method there is some overhead - so it makes sense to ensure developers can spot all such methods (functions). We have tried to do this with a `slot_` prefix to the methods we create but it has not been applied uniformly. This PR (and one or more to follow) is intended to help with this by more rigorously doing so - the names changed herein should all follow a `slot_`*camelCaseMethodName* style. In addition some methods were detected that are not currently used or which are not actually used via the signal/slot system, these have been commented out or have had the prefix removed and the declaration in the relevant header file moved as appropriate. For reference the changes made are: * `TLuaInterpreter::slotDeleteSender(...)` ==> `TLuaInterpreter::slot_deleteSender(...)` * `TLuaInterpreter::slotPurge()` ==> `TLuaInterpreter::slot_purge()` * `cTelnet::handle_socket_signal_connected()` ==> `cTelnet::slot_socketConnected()` * `cTelnet::handle_socket_signal_disconnected()` ==> `cTelnet::slot_socketDisconnected()` * `cTelnet::handle_socket_signal_hostFound(...)` ==> `cTelnet::slot_socketHostFound(...)` * `cTelnet::handle_socket_signal_readyRead()` ==> `cTelnet::slot_socketReadyToBeRead()` * `cTelnet::handle_socket_signal_sslError(...)` ==> `cTelnet::slot_socketSslError(...)` * `cTelnet::setDownloadProgress(...)` ==> `cTelnet::slot_setDownloadProgress(...)` * `dlgComposer::cancel()` ==> `dlgComposer::slot_cancel()` * `dlgComposer::save()` ==> `dlgComposer::slot_save()` * `dlgConnectionProfiles::slot_item_clicked(...)` ==> `dlgConnectionProfiles::slot_itemClicked(...)` * `dlgConnectionProfiles::slot_save_name()` ==> `dlgConnectionProfiles::slot_saveName()` * `dlgConnectionProfiles::slot_update_login(...)` ==> `dlgConnectionProfiles::slot_updateLogin(...)` * `dlgConnectionProfiles::slot_update_name(...)` ==> `dlgConnectionProfiles::slot_updateName(...)` * `dlgConnectionProfiles::slot_update_pass(...)` ==> `dlgConnectionProfiles::slot_updatePassword(...)` * `dlgConnectionProfiles::slot_update_port(...)` ==> `dlgConnectionProfiles::slot_updatePort(...)` * `dlgConnectionProfiles::slot_update_SSL_TSL_port(...)` ==> `dlgConnectionProfiles::slot_updateSslTslPort(...)` * `dlgConnectionProfiles::slot_update_url(...)` ==> `dlgConnectionProfiles::slot_updateUrl(...)` * `dlgMapLabel::pickBgColor()` ==> `dlgMapLabel::slot_pickBgColor()` * `dlgMapLabel::pickFgColor()` ==> `dlgMapLabel::slot_pickFgColor()` * `dlgMapLabel::pickFile()` ==> `dlgMapLabel::slot_pickFile()` * `dlgMapLabel::pickFont()` ==> `dlgMapLabel::slot_pickFont()` * `dlgMapLabel::save()` ==> `dlgMapLabel::slot_save()` * `dlgMapLabel::updateControls()` ==> `dlgMapLabel::slot_updateControls()` * `dlgMapLabel::updateControlsVisibility()` ==> `dlgMapLabel::slot_updateControlsVisibility()` Commented out as not being used: * `cTelnet::handle_socket_signal_error()` ==> `cTelnet::slot_socketError()` * `dlgConnectionProfiles::slot_update_website(...) ==> `dlgConnectionProfiles::slot_updateWebsite(const QString& url)` I have my doubts about whether the `dlgMapLabel::save()`/`dlgMapLabel::slot_save()` method is needed at all, as it might be that the `QDialog::accept()` slot could have been inserted into the `QObject::connect(...)` call directly instead...? Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-08-27 10:47:01 +02:00
slot_itemClicked(pRestoredItems.first());
Fix new profiles to be saved correctly when created (#2677)
2019-06-29 12:06:56 +02:00
} else {
Revise: select profiles by typing the name, keep profile icons (#4440) Restore the text display of the profile name. This is so that the keyboard selection of profiles beginning with a particular letter works again. This will close issue #4283 . This also sets it to the minimum size trying to hide it by setting the font size to 1 - however that still show something (and a font size of zero is NOT valid). Manipulating the QPalette of the QListWidget does not work well enough in the presence of Styles or StyleSheets to be a viable means of hiding the text either. Also in the `dlgConnection` class: * refactor out some highly repetitive code that sets up the predefined Mud icons. * remove warnings and adopts a change introduced into Qt 5.15 for the QLabel::pixmap() which now requires a Qt::ReturnByValue argument to prevent an obsolete code warning and to force a QPixmap to be returned by value and not reference... * remove a warning about: QListWidget::setItemSelected(QListWidgetItem*,bool) being deprecated and switches to the recommended: QListWidgetItem::setSelected(bool) Edit: the last item above may have become redundant as further commits amalgamated into this PR may have taken out these lines anyhow! Change the custom icon generator so that there is NOT a dependency on the position in the list for the colours used. This means that the same name will always have the same colours - which will help the user to pick out a particular profile as it will always look the same no matter if other profiles are added or removed. Remove the colour gradient in the custom icon as it is not thought to be useful nowadays. Refactor out the colour icon generator to a single method that is called from more than one place. BugFix: restore odd original way of accessing some QPixmaps This was causing failures in some CI platforms using Qt 5.14. or older. Revise: really frob the custom icon generator This is to try and produce as varied but still readable icons when they are generated entirely on the basis of the MUD name - in a reproducible (though Qt do NOT guarantee repeatable qHash() functionality across Qt versions - so they may not stay *that* constant) manner. Refrob: use a table of fixed colours Using only 15 hues but with 3 different saturation level plus 5 grey-scale one should give enough different icons but not generate them too close to each other for those with normal colour vision... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Kebap <kebap_spam@gmx.net>
2020-12-11 17:53:28 +00:00
setItemName(pItem, newProfileName);
Add ability to define custom color in profile buttons in connection dialog (#5365)
2021-08-13 07:22:24 +02:00
pItem->setIcon(customIcon(newProfileName, std::nullopt));
merge with experimental secureProfiles branch
2009-01-27 12:46:34 +01:00
}
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
}
start
2009-01-24 02:50:22 +01:00
improve: split the games list into My games and All games tabs (#9452) #### Brief overview of PR changes/additions - Tab bar above the connection dialog's games list: "My games" (profiles on disk) and "All games" (full catalog), replacing the right-click "Show my profiles only" stop-gap - Opens on My games when profiles exist, All games on a fresh install; last-used tab and the retired filter's setting are honoured; selection preserved across tab switches - Dedicated single-game builds hide the tab bar and keep their current look #### Motivation for adding to Mudlet One flat grid of ~35 games overwhelmed newcomers and buried the profiles a player actually uses. #### Other info (issues closed, discussion etc) Closes #9140 **Test case:** Fresh install → dialog opens on All games with the tab bar visible. Create a profile, restart → opens on My games showing only that profile, selected with details filled. Switch tabs → selection follows where possible; right-click menu no longer offers "Show my profiles only". https://github.com/user-attachments/assets/50b07d6e-7908-4d25-8b4c-4c6e1396aaea --------- Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-29 17:14:14 +02:00
bool dlgConnectionProfiles::showingOnlyMyProfiles() const
{
// the tab bar is hidden for dedicated single-game builds, which list their
// own game(s) unfiltered
return !mpTabBar->isHidden() && mpTabBar->currentIndex() == scmMyGamesTab;
}
void dlgConnectionProfiles::slot_activeTabChanged(const int index)
{
mudlet::self()->mpSettings->setValue(qsl("connectionDialogActiveTab"), index);
const auto* pCurrentItem = listWidget_profiles->currentItem();
const QString previousSelection = pCurrentItem ? pCurrentItem->data(csmNameRole).toString() : QString();
fillout_form();
if (previousSelection.isEmpty()) {
return;
}
// keep the same game selected if the newly shown tab also lists it,
// otherwise the automatic selection made by fillout_form() stands
const auto pPreviousItems = findData(*listWidget_profiles, previousSelection, csmNameRole);
if (!pPreviousItems.isEmpty()) {
listWidget_profiles->setCurrentItem(pPreviousItems.first());
}
}
fix: show connection details when picking a game on a fresh install (#9451) #### Brief overview of PR changes/additions - Selecting a game on a first-ever launch now swaps the welcome message for the connection details and restores the dialog height - Programmatic selections (startup pre-selection, password-migration refreshes) still show the welcome message - Copying a pre-configured game now rebuilds the list and selects the copy with its details filled in #### Motivation for adding to Mudlet On a fresh install, clicking a game filled hidden fields and appeared to do nothing - a dead end for the very first thing a new user does. #### Other info (issues closed, discussion etc) Closes #3930 **Test case:** Fresh install (empty config dir) → connection dialog shows the welcome message → click any game → connection details appear filled in. Copy a pre-configured game → the copy appears in the list, selected, with editable details. https://github.com/user-attachments/assets/de6df8fa-e1f0-4564-91e8-c286bebdd791 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-22 05:02:00 +02:00
// On a fresh install with no saved profiles the dialog shows the welcome
// message in place of the connection details; swap them back in and undo the
// shrink that was applied to fit the welcome message.
void dlgConnectionProfiles::revealConnectionDetails()
{
if (mProgrammaticProfileSelection || welcome_message->isHidden()) {
return;
}
welcome_message->hide();
tabWidget_connectionInfo->show();
informationArea->show();
if (mDialogHeightBeforeShrink > height()) {
resize(width(), mDialogHeightBeforeShrink);
}
}
start
2009-01-24 02:50:22 +01:00
void dlgConnectionProfiles::slot_addProfile()
{
misc
2013-06-12 21:44:38 +02:00
profile_name_entry->setReadOnly(false);
Fix: 'New profile' button to clear an existing password (#6114) * Fix 'New profile' button to clear an existing password * Fix typo
2022-06-16 21:44:07 +02:00
// while normally handled by fillout_form, due to it's asynchronous nature it is better UX to reset it here
Fix: Changing one profile's password no longer affects others (#9049) #### Brief overview of PR changes/additions Fixes an issue where changing the password for one profile would overwrite the passwords of other profiles. This primarily affected Windows users due to how the system credential storage works differently from macOS and Linux. #### Motivation for adding to Mudlet Users reported that setting a password on one profile caused all other profiles to use that same password. This made it impossible to have different passwords for different game connections. The fix ensures each profile's password is stored separately on all platforms. #### Other info (issues closed, discussion etc) Closes #9006
2026-03-18 12:15:40 -04:00
// Block signals to prevent triggering password save for the previously selected profile
{
const QSignalBlocker blocker(character_password_entry);
character_password_entry->setText(QString());
}
add: Show tutorial invitation on first launch (#9169) #### Brief overview of PR changes/additions - On first launch (no existing profiles), show a focused tutorial invitation instead of the full games list - "Start Tutorial" link launches the Mudlet Tutorial profile directly - "Skip - show me the games list" button reveals the full connection dialog with the tutorial profile preselected - Make the Connect button the dialog's explicit default so Enter in the connection form always means "Connect" (see below) #### Motivation for adding to Mudlet New users currently face a wall of 20+ unknown game names with no guidance - a focused tutorial invitation improves first-time retention by teaching basics before choosing a game. #### Other info (issues closed, discussion etc) https://github.com/user-attachments/assets/2eeb3cb9-f596-4744-b187-24e1fc785246 --- Squash-merge trailers: ``` Assisted-by: Claude:claude-fable-5 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org> ``` --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com> Co-authored-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-18 10:54:52 +02:00
dismissTutorialInvitation();
merge with experimental secureProfiles branch
2009-01-27 12:46:34 +01:00
fillout_form();
fix: show connection details when picking a game on a fresh install (#9451) #### Brief overview of PR changes/additions - Selecting a game on a first-ever launch now swaps the welcome message for the connection details and restores the dialog height - Programmatic selections (startup pre-selection, password-migration refreshes) still show the welcome message - Copying a pre-configured game now rebuilds the list and selects the copy with its details filled in #### Motivation for adding to Mudlet On a fresh install, clicking a game filled hidden fields and appeared to do nothing - a dead end for the very first thing a new user does. #### Other info (issues closed, discussion etc) Closes #3930 **Test case:** Fresh install (empty config dir) → connection dialog shows the welcome message → click any game → connection details appear filled in. Copy a pre-configured game → the copy appears in the list, selected, with editable details. https://github.com/user-attachments/assets/de6df8fa-e1f0-4564-91e8-c286bebdd791 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-22 05:02:00 +02:00
revealConnectionDetails();
misc
2010-03-15 09:37:16 +01:00
Infrastructure: mark read-only variables as const (#6843) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Mark read-only variables as const - that is, not intended to change after they've been declared #### Motivation for adding to Mudlet So we don't change them by accident later on, and also to clearly state intentions for the variables #### Other info (issues closed, discussion etc) This is also recommended by the [C++ Core Guidelines](https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#es25-declare-an-object-const-or-constexpr-unless-you-want-to-modify-its-value-later-on)
2023-05-14 15:06:15 +02:00
const QString newname = tr("new profile name");
misc
2010-03-15 09:37:16 +01:00
Fix incorrect allocation error handling in a few files (#7130) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions To avoid a potential crash, improve the code's handling of allocation failures by returning a null check instead of throwing an exception. #### Motivation for adding to Mudlet Cleaner code with fewer potential issues #### Other info (issues closed, discussion etc) This document explains what was going on really well: [Incorrect allocation-error handling · Code scanning alert #138 · Mudlet_Mudlet.pdf](https://github.com/Mudlet/Mudlet/files/14232200/Incorrect.allocation-error.handling.Code.scanning.alert.138.Mudlet_Mudlet.pdf)
2024-02-18 18:07:43 +01:00
auto pItem = new (std::nothrow) QListWidgetItem();
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
if (!pItem) {
merge with experimental secureProfiles branch
2009-01-27 12:46:34 +01:00
return;
}
Revise: select profiles by typing the name, keep profile icons (#4440) Restore the text display of the profile name. This is so that the keyboard selection of profiles beginning with a particular letter works again. This will close issue #4283 . This also sets it to the minimum size trying to hide it by setting the font size to 1 - however that still show something (and a font size of zero is NOT valid). Manipulating the QPalette of the QListWidget does not work well enough in the presence of Styles or StyleSheets to be a viable means of hiding the text either. Also in the `dlgConnection` class: * refactor out some highly repetitive code that sets up the predefined Mud icons. * remove warnings and adopts a change introduced into Qt 5.15 for the QLabel::pixmap() which now requires a Qt::ReturnByValue argument to prevent an obsolete code warning and to force a QPixmap to be returned by value and not reference... * remove a warning about: QListWidget::setItemSelected(QListWidgetItem*,bool) being deprecated and switches to the recommended: QListWidgetItem::setSelected(bool) Edit: the last item above may have become redundant as further commits amalgamated into this PR may have taken out these lines anyhow! Change the custom icon generator so that there is NOT a dependency on the position in the list for the colours used. This means that the same name will always have the same colours - which will help the user to pick out a particular profile as it will always look the same no matter if other profiles are added or removed. Remove the colour gradient in the custom icon as it is not thought to be useful nowadays. Refactor out the colour icon generator to a single method that is called from more than one place. BugFix: restore odd original way of accessing some QPixmaps This was causing failures in some CI platforms using Qt 5.14. or older. Revise: really frob the custom icon generator This is to try and produce as varied but still readable icons when they are generated entirely on the basis of the MUD name - in a reproducible (though Qt do NOT guarantee repeatable qHash() functionality across Qt versions - so they may not stay *that* constant) manner. Refrob: use a table of fixed colours Using only 15 hues but with 3 different saturation level plus 5 grey-scale one should give enough different icons but not generate them too close to each other for those with normal colour vision... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Kebap <kebap_spam@gmx.net>
2020-12-11 17:53:28 +00:00
setItemName(pItem, newname);
improve: make the New profile button show what it did (#9607) #### Brief overview of PR changes/additions - Clicking New now shows the new profile at the top of the list with an icon, selected and scrolled into view - The profile selection window no longer grows a little every time it switches views - Skipping the tutorial invitation no longer triggers a needless window resize #### Motivation for adding to Mudlet New users clicking New saw the window resize and nothing else happen, leaving them unable to add a game manually. #### Other info (issues closed, discussion etc) Assisted-by: Claude:claude-fable-5 **Test case:** Open the profile selector, click New - a highlighted "new profile name" entry appears at the top with the name field focused, and the window size does not change. #### Demo https://github.com/user-attachments/assets/5789738a-52fb-492d-89d4-b68cb0f36aff
2026-08-03 14:10:57 +02:00
// without an icon the item is an invisible blank in the list
pItem->setIcon(customIcon(newname, std::nullopt));
misc
2010-03-15 09:37:16 +01:00
improve: make the New profile button show what it did (#9607) #### Brief overview of PR changes/additions - Clicking New now shows the new profile at the top of the list with an icon, selected and scrolled into view - The profile selection window no longer grows a little every time it switches views - Skipping the tutorial invitation no longer triggers a needless window resize #### Motivation for adding to Mudlet New users clicking New saw the window resize and nothing else happen, leaving them unable to add a game manually. #### Other info (issues closed, discussion etc) Assisted-by: Claude:claude-fable-5 **Test case:** Open the profile selector, click New - a highlighted "new profile name" entry appears at the top with the name field focused, and the window size does not change. #### Demo https://github.com/user-attachments/assets/5789738a-52fb-492d-89d4-b68cb0f36aff
2026-08-03 14:10:57 +02:00
// insert the new entry at the top of the list - appending would bury it
// at the bottom, below all the predefined games
listWidget_profiles->insertItem(0, pItem);
misc
2010-03-15 09:37:16 +01:00
Revise: select profiles by typing the name, keep profile icons (#4440) Restore the text display of the profile name. This is so that the keyboard selection of profiles beginning with a particular letter works again. This will close issue #4283 . This also sets it to the minimum size trying to hide it by setting the font size to 1 - however that still show something (and a font size of zero is NOT valid). Manipulating the QPalette of the QListWidget does not work well enough in the presence of Styles or StyleSheets to be a viable means of hiding the text either. Also in the `dlgConnection` class: * refactor out some highly repetitive code that sets up the predefined Mud icons. * remove warnings and adopts a change introduced into Qt 5.15 for the QLabel::pixmap() which now requires a Qt::ReturnByValue argument to prevent an obsolete code warning and to force a QPixmap to be returned by value and not reference... * remove a warning about: QListWidget::setItemSelected(QListWidgetItem*,bool) being deprecated and switches to the recommended: QListWidgetItem::setSelected(bool) Edit: the last item above may have become redundant as further commits amalgamated into this PR may have taken out these lines anyhow! Change the custom icon generator so that there is NOT a dependency on the position in the list for the colours used. This means that the same name will always have the same colours - which will help the user to pick out a particular profile as it will always look the same no matter if other profiles are added or removed. Remove the colour gradient in the custom icon as it is not thought to be useful nowadays. Refactor out the colour icon generator to a single method that is called from more than one place. BugFix: restore odd original way of accessing some QPixmaps This was causing failures in some CI platforms using Qt 5.14. or older. Revise: really frob the custom icon generator This is to try and produce as varied but still readable icons when they are generated entirely on the basis of the MUD name - in a reproducible (though Qt do NOT guarantee repeatable qHash() functionality across Qt versions - so they may not stay *that* constant) manner. Refrob: use a table of fixed colours Using only 15 hues but with 3 different saturation level plus 5 grey-scale one should give enough different icons but not generate them too close to each other for those with normal colour vision... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Kebap <kebap_spam@gmx.net>
2020-12-11 17:53:28 +00:00
// As we are using QAbstractItemView::SingleSelection this will
improve: make the New profile button show what it did (#9607) #### Brief overview of PR changes/additions - Clicking New now shows the new profile at the top of the list with an icon, selected and scrolled into view - The profile selection window no longer grows a little every time it switches views - Skipping the tutorial invitation no longer triggers a needless window resize #### Motivation for adding to Mudlet New users clicking New saw the window resize and nothing else happen, leaving them unable to add a game manually. #### Other info (issues closed, discussion etc) Assisted-by: Claude:claude-fable-5 **Test case:** Open the profile selector, click New - a highlighted "new profile name" entry appears at the top with the name field focused, and the window size does not change. #### Demo https://github.com/user-attachments/assets/5789738a-52fb-492d-89d4-b68cb0f36aff
2026-08-03 14:10:57 +02:00
// automatically unselect the previous item, and auto-scroll brings the
// new item into view:
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
listWidget_profiles->setCurrentItem(pItem);
misc
2010-03-15 09:37:16 +01:00
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
profile_name_entry->setText(newname);
Remove the prompt for the profile's name
2009-01-24 06:40:18 -05:00
profile_name_entry->setFocus();
profile_name_entry->selectAll();
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
profile_name_entry->setReadOnly(false);
host_name_entry->setReadOnly(false);
port_entry->setReadOnly(false);
misc
2010-03-15 09:37:16 +01:00
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
validName = false;
validUrl = false;
validPort = false;
Revise: try and identify profiles and some controls in connection dialog (#3966) Also convert all `setDisabled(state)` to `setEnabled(!state)` in the `dlgConnectionProfiles` class - using a single one instead of a mix of the two is less likely to lead to errors - and it means less effort to search for the places where something is being enabled or disabled. Shorten some overlong variable names. Remove some capitalisations. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2020-08-13 00:57:17 +01:00
offline_button->setEnabled(false);
offline_button->setAccessibleDescription(btn_connOrLoad_disabled_accessDesc);
connect_button->setEnabled(false);
connect_button->setAccessibleDescription(btn_connOrLoad_disabled_accessDesc);
start
2009-01-24 02:50:22 +01:00
}
fix: a profile named "." or ".." deletes every profile when removed (#9722) #### Brief overview of PR changes/additions - Validation: a typed profile name must be a folder of its own - rejects a lone `.` and anything containing `..`. Folders already on disk stay exempt - Containment: `reallyDeleteProfile()` refuses any path that is not a direct child of `profiles/`, and now checks `removeRecursively()` instead of failing mute - Confirmation: the "nothing to delete" shortcut no longer fires when a map, stored password or dictionary is present #### Motivation for adding to Mudlet A profile named `.` or `..` turned **Remove** into a wipe: `.` resolves to `profiles/`, `..` to the whole `~/.config/mudlet`. The name was accepted with no error, and the confirmation was skipped because a fresh profile looks empty - two clicks deep on the first screen every user sees. #### Other info (issues closed, discussion etc) Pre-existing, not a 5.0 regression - shipped 4.22.0 behaves identically. Dots have been allowed deliberately since 2011 (`ee1fd051c`), and `Achaea 2.0` keeps working. **Test case:** name a new profile `.` and press Remove - previously every profile was deleted with no prompt, now the name is refused. New `ProfileDeletionSafetyTest` drives the real dialog against a temporary config dir, plus `profileFolderPath`/`profileNameUsableAsIs` rows in `ProfileNameValidationTest`. 81/81 ctest pass. Assisted-by: Claude:claude-opus-5
2026-08-08 08:30:14 +02:00
void dlgConnectionProfiles::showRemovalProblem(const QString& message)
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
{
fix: a profile named "." or ".." deletes every profile when removed (#9722) #### Brief overview of PR changes/additions - Validation: a typed profile name must be a folder of its own - rejects a lone `.` and anything containing `..`. Folders already on disk stay exempt - Containment: `reallyDeleteProfile()` refuses any path that is not a direct child of `profiles/`, and now checks `removeRecursively()` instead of failing mute - Confirmation: the "nothing to delete" shortcut no longer fires when a map, stored password or dictionary is present #### Motivation for adding to Mudlet A profile named `.` or `..` turned **Remove** into a wipe: `.` resolves to `profiles/`, `..` to the whole `~/.config/mudlet`. The name was accepted with no error, and the confirmation was skipped because a fresh profile looks empty - two clicks deep on the first screen every user sees. #### Other info (issues closed, discussion etc) Pre-existing, not a 5.0 regression - shipped 4.22.0 behaves identically. Dots have been allowed deliberately since 2011 (`ee1fd051c`), and `Achaea 2.0` keeps working. **Test case:** name a new profile `.` and press Remove - previously every profile was deleted with no prompt, now the name is refused. New `ProfileDeletionSafetyTest` drives the real dialog against a temporary config dir, plus `profileFolderPath`/`profileNameUsableAsIs` rows in `ProfileNameValidationTest`. 81/81 ctest pass. Assisted-by: Claude:claude-opus-5
2026-08-08 08:30:14 +02:00
notificationArea->show();
notificationAreaIconLabelWarning->show();
notificationAreaIconLabelError->hide();
notificationAreaIconLabelInformation->hide();
notificationAreaMessageBox->show();
notificationAreaMessageBox->setText(message);
Make it simple to delete empty default profiles (#4592) Co-authored-by: Stephen Lyons <slysven@virginmedia.com>
2021-02-17 06:58:21 +01:00
}
void dlgConnectionProfiles::reallyDeleteProfile(const QString& profile)
{
fix: a profile named "." or ".." deletes every profile when removed (#9722) #### Brief overview of PR changes/additions - Validation: a typed profile name must be a folder of its own - rejects a lone `.` and anything containing `..`. Folders already on disk stay exempt - Containment: `reallyDeleteProfile()` refuses any path that is not a direct child of `profiles/`, and now checks `removeRecursively()` instead of failing mute - Confirmation: the "nothing to delete" shortcut no longer fires when a map, stored password or dictionary is present #### Motivation for adding to Mudlet A profile named `.` or `..` turned **Remove** into a wipe: `.` resolves to `profiles/`, `..` to the whole `~/.config/mudlet`. The name was accepted with no error, and the confirmation was skipped because a fresh profile looks empty - two clicks deep on the first screen every user sees. #### Other info (issues closed, discussion etc) Pre-existing, not a 5.0 regression - shipped 4.22.0 behaves identically. Dots have been allowed deliberately since 2011 (`ee1fd051c`), and `Achaea 2.0` keeps working. **Test case:** name a new profile `.` and press Remove - previously every profile was deleted with no prompt, now the name is refused. New `ProfileDeletionSafetyTest` drives the real dialog against a temporary config dir, plus `profileFolderPath`/`profileNameUsableAsIs` rows in `ProfileNameValidationTest`. 81/81 ctest pass. Assisted-by: Claude:claude-opus-5
2026-08-08 08:30:14 +02:00
const QString profilesPath = mudlet::getMudletPath(enums::profilesPath);
const QString profileFolder = profileFolderPath(profilesPath, profile);
if (profileFolder.isEmpty()) {
qWarning().nospace() << "dlgConnectionProfiles::reallyDeleteProfile(\"" << profile << "\") ERROR - refusing to delete: that name does not address a folder inside \"" << profilesPath << "\".";
// rebuild the list first: it re-selects a profile, and that clears the
// notification area on its way through validateProfile()
fillout_form();
//: %1 is a profile name that does not name a folder of its own, so there is nothing that could be removed for it
showRemovalProblem(tr("'%1' has no profile folder of its own, so there is nothing to remove.").arg(profile));
return;
}
QDir dir(profileFolder);
if (!dir.removeRecursively()) {
// the profile is still on disk, so its password and its list entry stay:
// removing either would strand the data that is left
qWarning().nospace() << "dlgConnectionProfiles::reallyDeleteProfile(\"" << profile << "\") ERROR - could not completely remove \"" << profileFolder << "\".";
fillout_form();
//: %1 is a profile name. Shown when some of the profile's files could not be deleted, e.g. because another program has them open
showRemovalProblem(tr("Could not remove everything belonging to '%1'. Close it if it is open elsewhere, check that you may write to its folder, and try again.").arg(profile));
return;
}
Allow deletion of default MUDs (#1442) * Allow deletion of default MUDs
2017-12-23 07:16:24 +01:00
Improve: Clean up keychain entries when deleting profiles and creating new ones (#8103) #### Brief overview of PR changes/additions Adds keychain cleanup functionality to connection profile management: - **Profile deletion cleanup**: When deleting profiles via the "Remove" button, now removes associated keychain entries ("character" and "proxy" passwords) in addition to removing profile directories - **Orphaned entry detection**: When creating new profiles, detects and removes orphaned keychain entries from profiles previously deleted outside Mudlet interface - **Async implementation**: Uses existing CredentialManager async API with proper callback handling and debug logging - **Helper method**: Refactored profile save logic into `continueProfileSave()` to support async orphaned entry cleanup #### Motivation for adding to Mudlet Prevents accumulation of orphaned credentials in system keychains (macOS Keychain, Windows Credential Store, Linux Secret Service) by ensuring complete profile lifecycle management. Previously, keychain entries were left behind when profiles were deleted, and orphaned entries could interfere with new profile creation. #### Other info (issues closed, discussion etc) Builds upon the secure credential management system from PR #7956. Follows the same async architecture patterns with non-blocking UI operations, proper memory management, and callback-based error handling. Changes are only active when secure password storage is enabled. --- Video with evidence of the keychain being cleared after a profile was created, closed, removed, recreated: https://github.com/user-attachments/assets/a5e3e126-8b49-4871-8445-97b938a7c57e --- Video with evidence of the keychain being cleared upon re-creating a profile that has a keychain entry in the past: https://github.com/user-attachments/assets/15b86307-783d-49a4-87cc-06e28a5674b1
2025-08-28 07:03:30 -04:00
// Clean up keychain entries for the deleted profile
Fix: Crash when removing default MUD profiles from welcome window (#8916) #### Brief overview of PR changes/additions Fixes a crash that occurred when users tried to remove the default MUD profiles from the welcome window on Linux. #### Motivation for adding to Mudlet Users on Linux were experiencing crashes when clicking the remove button on the default game profiles in the connection dialog. This made it difficult to clean up the profile list. #### Other info (issues closed, discussion etc) Closes #8907 The fix ensures that password cleanup operations happen one at a time instead of simultaneously, and adds safety checks to handle cases where the dialog might close during the cleanup process.
2026-02-09 05:44:01 -05:00
// Note: CredentialManager only supports one operation at a time, so we must
// chain the operations - the second removal starts only after the first completes.
// This prevents lost callbacks from aborting in-progress keychain operations.
// Crash prevention comes from parentless CredentialManager + QPointer guards.
// Create CredentialManager without a parent to avoid destruction when dialog closes
Improve: Clean up keychain entries when deleting profiles and creating new ones (#8103) #### Brief overview of PR changes/additions Adds keychain cleanup functionality to connection profile management: - **Profile deletion cleanup**: When deleting profiles via the "Remove" button, now removes associated keychain entries ("character" and "proxy" passwords) in addition to removing profile directories - **Orphaned entry detection**: When creating new profiles, detects and removes orphaned keychain entries from profiles previously deleted outside Mudlet interface - **Async implementation**: Uses existing CredentialManager async API with proper callback handling and debug logging - **Helper method**: Refactored profile save logic into `continueProfileSave()` to support async orphaned entry cleanup #### Motivation for adding to Mudlet Prevents accumulation of orphaned credentials in system keychains (macOS Keychain, Windows Credential Store, Linux Secret Service) by ensuring complete profile lifecycle management. Previously, keychain entries were left behind when profiles were deleted, and orphaned entries could interfere with new profile creation. #### Other info (issues closed, discussion etc) Builds upon the secure credential management system from PR #7956. Follows the same async architecture patterns with non-blocking UI operations, proper memory management, and callback-based error handling. Changes are only active when secure password storage is enabled. --- Video with evidence of the keychain being cleared after a profile was created, closed, removed, recreated: https://github.com/user-attachments/assets/a5e3e126-8b49-4871-8445-97b938a7c57e --- Video with evidence of the keychain being cleared upon re-creating a profile that has a keychain entry in the past: https://github.com/user-attachments/assets/15b86307-783d-49a4-87cc-06e28a5674b1
2025-08-28 07:03:30 -04:00
if (mudlet::self()->storingPasswordsSecurely()) {
Fix: Crash when removing default MUD profiles from welcome window (#8916) #### Brief overview of PR changes/additions Fixes a crash that occurred when users tried to remove the default MUD profiles from the welcome window on Linux. #### Motivation for adding to Mudlet Users on Linux were experiencing crashes when clicking the remove button on the default game profiles in the connection dialog. This made it difficult to clean up the profile list. #### Other info (issues closed, discussion etc) Closes #8907 The fix ensures that password cleanup operations happen one at a time instead of simultaneously, and adds safety checks to handle cases where the dialog might close during the cleanup process.
2026-02-09 05:44:01 -05:00
QPointer<CredentialManager> safeCredManager = new CredentialManager(nullptr);
Add a Mudlet Tutorial profile. (#8188) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Adds a Mudlet Tutorial profile which incorporates a basic GUI tutorial and mini-mud quest. GUI tutorial introduces the main window, command line, search bar, toolbar, map. Mini-quest attempts to act like a MUD. Teaches directional commands and some typical verbs (look, buy, give, get, open, close, quit) while the player wanders around trying to figure out the two 'quests' (buy the sheriff some lunch and find the librarian's lost ring). It is simplistic and more designed to show players how a mud 'feels and progresses' when playing rather than a full blown MUD school which most (all?) MUDs incorporate. #### Motivation for adding to Mudlet Help on-boarding new users. Destination 5.0. /claim #3072 helps #2823 #### Other info (issues closed, discussion etc) I purposefully left out triggers, scripting and all that stuff veteran players take for granted! This is supposed to be an on-boarding tutorial for NEW players, let's not overwhelm them. A link after successful completion of the game introduces the wiki Introduction page for more advanced topics. That said, any improvements or basic features you think are missing from either the GUI or Mud tutorials, let me know and I can add. https://github.com/user-attachments/assets/1d16db50-e24b-4e78-b6b0-66e0e98a0772
2025-09-13 14:17:13 +07:00
Fix: Crash when removing default MUD profiles from welcome window (#8916) #### Brief overview of PR changes/additions Fixes a crash that occurred when users tried to remove the default MUD profiles from the welcome window on Linux. #### Motivation for adding to Mudlet Users on Linux were experiencing crashes when clicking the remove button on the default game profiles in the connection dialog. This made it difficult to clean up the profile list. #### Other info (issues closed, discussion etc) Closes #8907 The fix ensures that password cleanup operations happen one at a time instead of simultaneously, and adds safety checks to handle cases where the dialog might close during the cleanup process.
2026-02-09 05:44:01 -05:00
// Clean up character password entry first, then chain proxy cleanup
safeCredManager->removePassword(profile, "character", [safeCredManager, profile](bool success, const QString& errorMessage) {
Improve: Clean up keychain entries when deleting profiles and creating new ones (#8103) #### Brief overview of PR changes/additions Adds keychain cleanup functionality to connection profile management: - **Profile deletion cleanup**: When deleting profiles via the "Remove" button, now removes associated keychain entries ("character" and "proxy" passwords) in addition to removing profile directories - **Orphaned entry detection**: When creating new profiles, detects and removes orphaned keychain entries from profiles previously deleted outside Mudlet interface - **Async implementation**: Uses existing CredentialManager async API with proper callback handling and debug logging - **Helper method**: Refactored profile save logic into `continueProfileSave()` to support async orphaned entry cleanup #### Motivation for adding to Mudlet Prevents accumulation of orphaned credentials in system keychains (macOS Keychain, Windows Credential Store, Linux Secret Service) by ensuring complete profile lifecycle management. Previously, keychain entries were left behind when profiles were deleted, and orphaned entries could interfere with new profile creation. #### Other info (issues closed, discussion etc) Builds upon the secure credential management system from PR #7956. Follows the same async architecture patterns with non-blocking UI operations, proper memory management, and callback-based error handling. Changes are only active when secure password storage is enabled. --- Video with evidence of the keychain being cleared after a profile was created, closed, removed, recreated: https://github.com/user-attachments/assets/a5e3e126-8b49-4871-8445-97b938a7c57e --- Video with evidence of the keychain being cleared upon re-creating a profile that has a keychain entry in the past: https://github.com/user-attachments/assets/15b86307-783d-49a4-87cc-06e28a5674b1
2025-08-28 07:03:30 -04:00
if (!success) {
qWarning() << "dlgConnectionProfiles: Failed to clean up character password for deleted profile" << profile << ":" << errorMessage;
}
Add a Mudlet Tutorial profile. (#8188) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Adds a Mudlet Tutorial profile which incorporates a basic GUI tutorial and mini-mud quest. GUI tutorial introduces the main window, command line, search bar, toolbar, map. Mini-quest attempts to act like a MUD. Teaches directional commands and some typical verbs (look, buy, give, get, open, close, quit) while the player wanders around trying to figure out the two 'quests' (buy the sheriff some lunch and find the librarian's lost ring). It is simplistic and more designed to show players how a mud 'feels and progresses' when playing rather than a full blown MUD school which most (all?) MUDs incorporate. #### Motivation for adding to Mudlet Help on-boarding new users. Destination 5.0. /claim #3072 helps #2823 #### Other info (issues closed, discussion etc) I purposefully left out triggers, scripting and all that stuff veteran players take for granted! This is supposed to be an on-boarding tutorial for NEW players, let's not overwhelm them. A link after successful completion of the game introduces the wiki Introduction page for more advanced topics. That said, any improvements or basic features you think are missing from either the GUI or Mud tutorials, let me know and I can add. https://github.com/user-attachments/assets/1d16db50-e24b-4e78-b6b0-66e0e98a0772
2025-09-13 14:17:13 +07:00
Fix: Crash when removing default MUD profiles from welcome window (#8916) #### Brief overview of PR changes/additions Fixes a crash that occurred when users tried to remove the default MUD profiles from the welcome window on Linux. #### Motivation for adding to Mudlet Users on Linux were experiencing crashes when clicking the remove button on the default game profiles in the connection dialog. This made it difficult to clean up the profile list. #### Other info (issues closed, discussion etc) Closes #8907 The fix ensures that password cleanup operations happen one at a time instead of simultaneously, and adds safety checks to handle cases where the dialog might close during the cleanup process.
2026-02-09 05:44:01 -05:00
// Check if credManager was destroyed before chaining next operation
if (!safeCredManager) {
qWarning() << "dlgConnectionProfiles: CredentialManager destroyed, cannot clean up proxy password";
return;
Improve: Clean up keychain entries when deleting profiles and creating new ones (#8103) #### Brief overview of PR changes/additions Adds keychain cleanup functionality to connection profile management: - **Profile deletion cleanup**: When deleting profiles via the "Remove" button, now removes associated keychain entries ("character" and "proxy" passwords) in addition to removing profile directories - **Orphaned entry detection**: When creating new profiles, detects and removes orphaned keychain entries from profiles previously deleted outside Mudlet interface - **Async implementation**: Uses existing CredentialManager async API with proper callback handling and debug logging - **Helper method**: Refactored profile save logic into `continueProfileSave()` to support async orphaned entry cleanup #### Motivation for adding to Mudlet Prevents accumulation of orphaned credentials in system keychains (macOS Keychain, Windows Credential Store, Linux Secret Service) by ensuring complete profile lifecycle management. Previously, keychain entries were left behind when profiles were deleted, and orphaned entries could interfere with new profile creation. #### Other info (issues closed, discussion etc) Builds upon the secure credential management system from PR #7956. Follows the same async architecture patterns with non-blocking UI operations, proper memory management, and callback-based error handling. Changes are only active when secure password storage is enabled. --- Video with evidence of the keychain being cleared after a profile was created, closed, removed, recreated: https://github.com/user-attachments/assets/a5e3e126-8b49-4871-8445-97b938a7c57e --- Video with evidence of the keychain being cleared upon re-creating a profile that has a keychain entry in the past: https://github.com/user-attachments/assets/15b86307-783d-49a4-87cc-06e28a5674b1
2025-08-28 07:03:30 -04:00
}
Add a Mudlet Tutorial profile. (#8188) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Adds a Mudlet Tutorial profile which incorporates a basic GUI tutorial and mini-mud quest. GUI tutorial introduces the main window, command line, search bar, toolbar, map. Mini-quest attempts to act like a MUD. Teaches directional commands and some typical verbs (look, buy, give, get, open, close, quit) while the player wanders around trying to figure out the two 'quests' (buy the sheriff some lunch and find the librarian's lost ring). It is simplistic and more designed to show players how a mud 'feels and progresses' when playing rather than a full blown MUD school which most (all?) MUDs incorporate. #### Motivation for adding to Mudlet Help on-boarding new users. Destination 5.0. /claim #3072 helps #2823 #### Other info (issues closed, discussion etc) I purposefully left out triggers, scripting and all that stuff veteran players take for granted! This is supposed to be an on-boarding tutorial for NEW players, let's not overwhelm them. A link after successful completion of the game introduces the wiki Introduction page for more advanced topics. That said, any improvements or basic features you think are missing from either the GUI or Mud tutorials, let me know and I can add. https://github.com/user-attachments/assets/1d16db50-e24b-4e78-b6b0-66e0e98a0772
2025-09-13 14:17:13 +07:00
Fix: Crash when removing default MUD profiles from welcome window (#8916) #### Brief overview of PR changes/additions Fixes a crash that occurred when users tried to remove the default MUD profiles from the welcome window on Linux. #### Motivation for adding to Mudlet Users on Linux were experiencing crashes when clicking the remove button on the default game profiles in the connection dialog. This made it difficult to clean up the profile list. #### Other info (issues closed, discussion etc) Closes #8907 The fix ensures that password cleanup operations happen one at a time instead of simultaneously, and adds safety checks to handle cases where the dialog might close during the cleanup process.
2026-02-09 05:44:01 -05:00
// Now clean up proxy password entry (chained after character password removal completes)
safeCredManager->removePassword(profile, "proxy", [safeCredManager, profile](bool proxySuccess, const QString& proxyErrorMessage) {
if (!proxySuccess) {
qWarning() << "dlgConnectionProfiles: Failed to clean up proxy password for deleted profile" << profile << ":" << proxyErrorMessage;
}
// Clean up the credential manager after both operations complete (if still valid)
if (safeCredManager) {
safeCredManager->deleteLater();
}
});
Improve: Clean up keychain entries when deleting profiles and creating new ones (#8103) #### Brief overview of PR changes/additions Adds keychain cleanup functionality to connection profile management: - **Profile deletion cleanup**: When deleting profiles via the "Remove" button, now removes associated keychain entries ("character" and "proxy" passwords) in addition to removing profile directories - **Orphaned entry detection**: When creating new profiles, detects and removes orphaned keychain entries from profiles previously deleted outside Mudlet interface - **Async implementation**: Uses existing CredentialManager async API with proper callback handling and debug logging - **Helper method**: Refactored profile save logic into `continueProfileSave()` to support async orphaned entry cleanup #### Motivation for adding to Mudlet Prevents accumulation of orphaned credentials in system keychains (macOS Keychain, Windows Credential Store, Linux Secret Service) by ensuring complete profile lifecycle management. Previously, keychain entries were left behind when profiles were deleted, and orphaned entries could interfere with new profile creation. #### Other info (issues closed, discussion etc) Builds upon the secure credential management system from PR #7956. Follows the same async architecture patterns with non-blocking UI operations, proper memory management, and callback-based error handling. Changes are only active when secure password storage is enabled. --- Video with evidence of the keychain being cleared after a profile was created, closed, removed, recreated: https://github.com/user-attachments/assets/a5e3e126-8b49-4871-8445-97b938a7c57e --- Video with evidence of the keychain being cleared upon re-creating a profile that has a keychain entry in the past: https://github.com/user-attachments/assets/15b86307-783d-49a4-87cc-06e28a5674b1
2025-08-28 07:03:30 -04:00
});
}
fix: removing a game's profile no longer hides it from the All Games list (#9608) #### Brief overview of PR changes/additions - Deleting a profile of a pre-installed game now only removes the profile - the game stays available in All Games - Games hidden by this bug in the past reappear automatically - Adds DefaultGameDeleteTest covering both cases #### Motivation for adding to Mudlet Removing a game from My Games unexpectedly removed it from the All Games catalog permanently. #### Other info (issues closed, discussion etc) Assisted-by: Claude:claude-fable-5 Assisted-by: Claude:claude-opus-5 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org> **Test case:** Play a game from All Games, close and reopen Mudlet, remove it from My Games - it still appears under All Games. #### Demo https://github.com/user-attachments/assets/6df6f2bd-d0d4-446f-80de-8c4c190dbf45
2026-08-04 12:00:37 +02:00
// record the deletion; the games catalog deliberately ignores this list
// now - only the self-test entry in fillout_form() still honours it, and
// continueProfileSave() clears the entry on profile re-creation
Allow deletion of default MUDs (#1442) * Allow deletion of default MUDs
2017-12-23 07:16:24 +01:00
auto& settings = *mudlet::self()->mpSettings;
Infrastructure: Add short qsl macro to stand in for 'QStringLiteral' (#5640)
2021-12-07 06:21:39 +01:00
auto deletedDefaultMuds = settings.value(qsl("deletedDefaultMuds"), QStringList()).toStringList();
Allow deletion of default MUDs (#1442) * Allow deletion of default MUDs
2017-12-23 07:16:24 +01:00
if (!deletedDefaultMuds.contains(profile)) {
deletedDefaultMuds.append(profile);
}
Infrastructure: Add short qsl macro to stand in for 'QStringLiteral' (#5640)
2021-12-07 06:21:39 +01:00
settings.setValue(qsl("deletedDefaultMuds"), deletedDefaultMuds);
Allow deletion of default MUDs (#1442) * Allow deletion of default MUDs
2017-12-23 07:16:24 +01:00
proper removal from profile list|prevent out-of-branch recursion Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 17:35:49 +02:00
fillout_form();
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
listWidget_profiles->setFocus();
Fix: connection dialog remove profile
2009-03-15 02:58:00 +01:00
}
Fix: connectionDialog profile copy didnt save all data | connection problem on copied profiles NOTE: very strange bug. didnt really solve this, just use some ugly way to get around the real problem: the files that hold the data relevant for the connection dialog, do get copied on copy profile, but somehow the data is not correct. Well, it cant be a filecopy problem, it will be some signal/slot behaviour that we dont expect. this should be investigated more when we have time.
2009-01-31 03:57:59 +01:00
Refactored some variable names to make the code easier to read & added comments.
2014-08-26 06:02:05 +10:00
// called when the 'delete' button is pressed, raises a dialog to confirm deletion
Make it simple to delete empty default profiles (#4592) Co-authored-by: Stephen Lyons <slysven@virginmedia.com>
2021-02-17 06:58:21 +01:00
// if this profile has been used
start
2009-01-24 02:50:22 +01:00
void dlgConnectionProfiles::slot_deleteProfile()
{
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
if (!listWidget_profiles->currentItem()) {
Feature: finished all features in connectionDialog + autologon
2009-01-28 02:35:22 +01:00
return;
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
}
misc
2010-03-15 09:37:16 +01:00
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
const QString profile = listWidget_profiles->currentItem()->data(csmNameRole).toString();
Add: command line option to only show one (or more) predefined MUD(s) (#6459) The new option is -o/--only profileName. If it is one of the "Predefined" ones it means that all other Predefined profiles do not get shown whenever the "Connect Profile" dialogue is shown in that session. It may be given more than once to show more than one predefined MUD. Whilst the setting is active for that session it is also not possible for the user to "hide" the Predefined Mud in the dialogue - it will just not bring up the profile deletion confirmation dialogue and silently not do anything. Also: * make -p also work alongside --profile * ALL of the help text is now passed through the translation system. Previously only some of the text was so processed. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2023-01-05 20:26:51 +00:00
const QStringList& onlyShownPredefinedProfiles{mudlet::self()->mOnlyShownPredefinedProfiles};
if (!onlyShownPredefinedProfiles.isEmpty() && onlyShownPredefinedProfiles.contains(profile)) {
// Do NOT allow deletion of the prioritised predefined MUD:
return;
}
misc
2010-03-15 09:37:16 +01:00
fix: a profile named "." or ".." deletes every profile when removed (#9722) #### Brief overview of PR changes/additions - Validation: a typed profile name must be a folder of its own - rejects a lone `.` and anything containing `..`. Folders already on disk stay exempt - Containment: `reallyDeleteProfile()` refuses any path that is not a direct child of `profiles/`, and now checks `removeRecursively()` instead of failing mute - Confirmation: the "nothing to delete" shortcut no longer fires when a map, stored password or dictionary is present #### Motivation for adding to Mudlet A profile named `.` or `..` turned **Remove** into a wipe: `.` resolves to `profiles/`, `..` to the whole `~/.config/mudlet`. The name was accepted with no error, and the confirmation was skipped because a fresh profile looks empty - two clicks deep on the first screen every user sees. #### Other info (issues closed, discussion etc) Pre-existing, not a 5.0 regression - shipped 4.22.0 behaves identically. Dots have been allowed deliberately since 2011 (`ee1fd051c`), and `Achaea 2.0` keeps working. **Test case:** name a new profile `.` and press Remove - previously every profile was deleted with no prompt, now the name is refused. New `ProfileDeletionSafetyTest` drives the real dialog against a temporary config dir, plus `profileFolderPath`/`profileNameUsableAsIs` rows in `ProfileNameValidationTest`. 81/81 ctest pass. Assisted-by: Claude:claude-opus-5
2026-08-08 08:30:14 +02:00
const QDir profileDir(mudlet::getMudletPath(enums::profileHomePath, profile));
bool nothingToLose = !profileDir.exists() || profileDir.entryList(QDir::Dirs | QDir::Hidden | QDir::NoDotAndDotDot).isEmpty();
if (nothingToLose) {
for (const QString& fileName : profileDir.entryList(QDir::Files | QDir::Hidden)) {
infrastructure: keep the profile-removal file list from going stale (#9739) #### Brief overview of PR changes/additions - Hoists the list `slot_deleteProfile()` checks a never-played profile against out of the function to `dlgConnectionProfiles::scmConnectionDetailFiles`, beside the file's other `scm*` constants, and points at it from both `writeProfileData()` implementations. - Adds a `ProfileDeletionSafetyTest` case that sets a profile up through the real dialog (New profile, name it, fill the connection form in, re-select it) and fails if anything it wrote is missing from the list. - Pins the deliberate exclusions too: a profile holding a stored password or a typed-in character name still asks before removal. #### Motivation for adding to Mudlet Nothing linked that list to the ~15 places profile data gets written, so it could silently go stale; because it is an allowlist a stale entry only ever costs an extra confirmation prompt, but the maintenance trap was worth closing. #### Other info (issues closed, discussion etc) Follows up https://github.com/Mudlet/Mudlet/pull/9722#discussion_r3740581754 on #9722 (fix: a profile named "." or ".." deletes every profile when removed). No behaviour change. **Test case:** `ctest -R ProfileDeletionSafetyTest` (20 cases). Removing an entry from the constant makes it fail naming the file; adding `login` makes the character-name case fail. Assisted-by: Claude:claude-opus-5
2026-08-08 19:30:26 +02:00
if (!scmConnectionDetailFiles.contains(fileName)) {
fix: a profile named "." or ".." deletes every profile when removed (#9722) #### Brief overview of PR changes/additions - Validation: a typed profile name must be a folder of its own - rejects a lone `.` and anything containing `..`. Folders already on disk stay exempt - Containment: `reallyDeleteProfile()` refuses any path that is not a direct child of `profiles/`, and now checks `removeRecursively()` instead of failing mute - Confirmation: the "nothing to delete" shortcut no longer fires when a map, stored password or dictionary is present #### Motivation for adding to Mudlet A profile named `.` or `..` turned **Remove** into a wipe: `.` resolves to `profiles/`, `..` to the whole `~/.config/mudlet`. The name was accepted with no error, and the confirmation was skipped because a fresh profile looks empty - two clicks deep on the first screen every user sees. #### Other info (issues closed, discussion etc) Pre-existing, not a 5.0 regression - shipped 4.22.0 behaves identically. Dots have been allowed deliberately since 2011 (`ee1fd051c`), and `Achaea 2.0` keeps working. **Test case:** name a new profile `.` and press Remove - previously every profile was deleted with no prompt, now the name is refused. New `ProfileDeletionSafetyTest` drives the real dialog against a temporary config dir, plus `profileFolderPath`/`profileNameUsableAsIs` rows in `ProfileNameValidationTest`. 81/81 ctest pass. Assisted-by: Claude:claude-opus-5
2026-08-08 08:30:14 +02:00
nothingToLose = false;
break;
}
}
}
if (nothingToLose) {
Make it simple to delete empty default profiles (#4592) Co-authored-by: Stephen Lyons <slysven@virginmedia.com>
2021-02-17 06:58:21 +01:00
reallyDeleteProfile(profile);
return;
}
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
QUiLoader loader;
misc
2010-03-15 09:37:16 +01:00
Infrastructure: Add short qsl macro to stand in for 'QStringLiteral' (#5640)
2021-12-07 06:21:39 +01:00
QFile file(qsl(":/ui/delete_profile_confirmation.ui"));
Infrastructure: fix Qt 6.10 compile warnings (#8115) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Fix Qt 6.10 compile warnings #### Motivation for adding to Mudlet Cleaner compiles #### Other info (issues closed, discussion etc) --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-08-28 13:02:14 +02:00
if (!file.open(QFile::ReadOnly)) {
qWarning() << "dlgConnectionProfiles: failed to open UI file for reading:" << file.errorString();
return;
}
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
Make it simple to delete empty default profiles (#4592) Co-authored-by: Stephen Lyons <slysven@virginmedia.com>
2021-02-17 06:58:21 +01:00
auto* delete_profile_dialog = dynamic_cast<QDialog*>(loader.load(&file, this));
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
file.close();
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
if (!delete_profile_dialog) {
fix: a profile named "." or ".." deletes every profile when removed (#9722) #### Brief overview of PR changes/additions - Validation: a typed profile name must be a folder of its own - rejects a lone `.` and anything containing `..`. Folders already on disk stay exempt - Containment: `reallyDeleteProfile()` refuses any path that is not a direct child of `profiles/`, and now checks `removeRecursively()` instead of failing mute - Confirmation: the "nothing to delete" shortcut no longer fires when a map, stored password or dictionary is present #### Motivation for adding to Mudlet A profile named `.` or `..` turned **Remove** into a wipe: `.` resolves to `profiles/`, `..` to the whole `~/.config/mudlet`. The name was accepted with no error, and the confirmation was skipped because a fresh profile looks empty - two clicks deep on the first screen every user sees. #### Other info (issues closed, discussion etc) Pre-existing, not a 5.0 regression - shipped 4.22.0 behaves identically. Dots have been allowed deliberately since 2011 (`ee1fd051c`), and `Achaea 2.0` keeps working. **Test case:** name a new profile `.` and press Remove - previously every profile was deleted with no prompt, now the name is refused. New `ProfileDeletionSafetyTest` drives the real dialog against a temporary config dir, plus `profileFolderPath`/`profileNameUsableAsIs` rows in `ProfileNameValidationTest`. 81/81 ctest pass. Assisted-by: Claude:claude-opus-5
2026-08-08 08:30:14 +02:00
qWarning() << "dlgConnectionProfiles::slot_deleteProfile() ERROR - the deletion confirmation did not load as a dialog.";
//: %1 is a profile name. Shown when the dialog asking the user to confirm a removal could not be built
showRemovalProblem(tr("Could not open the confirmation, so '%1' has not been removed.").arg(profile));
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
return;
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
}
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
fix: a profile named "." or ".." deletes every profile when removed (#9722) #### Brief overview of PR changes/additions - Validation: a typed profile name must be a folder of its own - rejects a lone `.` and anything containing `..`. Folders already on disk stay exempt - Containment: `reallyDeleteProfile()` refuses any path that is not a direct child of `profiles/`, and now checks `removeRecursively()` instead of failing mute - Confirmation: the "nothing to delete" shortcut no longer fires when a map, stored password or dictionary is present #### Motivation for adding to Mudlet A profile named `.` or `..` turned **Remove** into a wipe: `.` resolves to `profiles/`, `..` to the whole `~/.config/mudlet`. The name was accepted with no error, and the confirmation was skipped because a fresh profile looks empty - two clicks deep on the first screen every user sees. #### Other info (issues closed, discussion etc) Pre-existing, not a 5.0 regression - shipped 4.22.0 behaves identically. Dots have been allowed deliberately since 2011 (`ee1fd051c`), and `Achaea 2.0` keeps working. **Test case:** name a new profile `.` and press Remove - previously every profile was deleted with no prompt, now the name is refused. New `ProfileDeletionSafetyTest` drives the real dialog against a temporary config dir, plus `profileFolderPath`/`profileNameUsableAsIs` rows in `ProfileNameValidationTest`. 81/81 ctest pass. Assisted-by: Claude:claude-opus-5
2026-08-08 08:30:14 +02:00
auto* nameEntry = delete_profile_dialog->findChild<QLineEdit*>(qsl("delete_profile_lineedit"));
auto* deleteButton = delete_profile_dialog->findChild<QPushButton*>(qsl("delete_button"));
auto* cancelButton = delete_profile_dialog->findChild<QPushButton*>(qsl("cancel_button"));
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
fix: a profile named "." or ".." deletes every profile when removed (#9722) #### Brief overview of PR changes/additions - Validation: a typed profile name must be a folder of its own - rejects a lone `.` and anything containing `..`. Folders already on disk stay exempt - Containment: `reallyDeleteProfile()` refuses any path that is not a direct child of `profiles/`, and now checks `removeRecursively()` instead of failing mute - Confirmation: the "nothing to delete" shortcut no longer fires when a map, stored password or dictionary is present #### Motivation for adding to Mudlet A profile named `.` or `..` turned **Remove** into a wipe: `.` resolves to `profiles/`, `..` to the whole `~/.config/mudlet`. The name was accepted with no error, and the confirmation was skipped because a fresh profile looks empty - two clicks deep on the first screen every user sees. #### Other info (issues closed, discussion etc) Pre-existing, not a 5.0 regression - shipped 4.22.0 behaves identically. Dots have been allowed deliberately since 2011 (`ee1fd051c`), and `Achaea 2.0` keeps working. **Test case:** name a new profile `.` and press Remove - previously every profile was deleted with no prompt, now the name is refused. New `ProfileDeletionSafetyTest` drives the real dialog against a temporary config dir, plus `profileFolderPath`/`profileNameUsableAsIs` rows in `ProfileNameValidationTest`. 81/81 ctest pass. Assisted-by: Claude:claude-opus-5
2026-08-08 08:30:14 +02:00
if (!nameEntry || !deleteButton || !cancelButton) {
qWarning() << "dlgConnectionProfiles::slot_deleteProfile() ERROR - the deletion confirmation is missing one of its widgets.";
showRemovalProblem(tr("Could not open the confirmation, so '%1' has not been removed.").arg(profile));
delete delete_profile_dialog;
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
return;
}
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
fix: a profile named "." or ".." deletes every profile when removed (#9722) #### Brief overview of PR changes/additions - Validation: a typed profile name must be a folder of its own - rejects a lone `.` and anything containing `..`. Folders already on disk stay exempt - Containment: `reallyDeleteProfile()` refuses any path that is not a direct child of `profiles/`, and now checks `removeRecursively()` instead of failing mute - Confirmation: the "nothing to delete" shortcut no longer fires when a map, stored password or dictionary is present #### Motivation for adding to Mudlet A profile named `.` or `..` turned **Remove** into a wipe: `.` resolves to `profiles/`, `..` to the whole `~/.config/mudlet`. The name was accepted with no error, and the confirmation was skipped because a fresh profile looks empty - two clicks deep on the first screen every user sees. #### Other info (issues closed, discussion etc) Pre-existing, not a 5.0 regression - shipped 4.22.0 behaves identically. Dots have been allowed deliberately since 2011 (`ee1fd051c`), and `Achaea 2.0` keeps working. **Test case:** name a new profile `.` and press Remove - previously every profile was deleted with no prompt, now the name is refused. New `ProfileDeletionSafetyTest` drives the real dialog against a temporary config dir, plus `profileFolderPath`/`profileNameUsableAsIs` rows in `ProfileNameValidationTest`. 81/81 ctest pass. Assisted-by: Claude:claude-opus-5
2026-08-08 08:30:14 +02:00
// The confirmation is not modal, so by the time it is answered the selection
// may have moved on, or a second confirmation may be open alongside it:
connect(nameEntry, &QLineEdit::textChanged, delete_profile_dialog, [deleteButton, profile](const QString& text) {
deleteButton->setEnabled(text == profile);
if (deleteButton->isEnabled()) {
deleteButton->setFocus();
}
});
connect(delete_profile_dialog, &QDialog::accepted, this, [this, profile]() {
reallyDeleteProfile(profile);
});
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
fix: a profile named "." or ".." deletes every profile when removed (#9722) #### Brief overview of PR changes/additions - Validation: a typed profile name must be a folder of its own - rejects a lone `.` and anything containing `..`. Folders already on disk stay exempt - Containment: `reallyDeleteProfile()` refuses any path that is not a direct child of `profiles/`, and now checks `removeRecursively()` instead of failing mute - Confirmation: the "nothing to delete" shortcut no longer fires when a map, stored password or dictionary is present #### Motivation for adding to Mudlet A profile named `.` or `..` turned **Remove** into a wipe: `.` resolves to `profiles/`, `..` to the whole `~/.config/mudlet`. The name was accepted with no error, and the confirmation was skipped because a fresh profile looks empty - two clicks deep on the first screen every user sees. #### Other info (issues closed, discussion etc) Pre-existing, not a 5.0 regression - shipped 4.22.0 behaves identically. Dots have been allowed deliberately since 2011 (`ee1fd051c`), and `Achaea 2.0` keeps working. **Test case:** name a new profile `.` and press Remove - previously every profile was deleted with no prompt, now the name is refused. New `ProfileDeletionSafetyTest` drives the real dialog against a temporary config dir, plus `profileFolderPath`/`profileNameUsableAsIs` rows in `ProfileNameValidationTest`. 81/81 ctest pass. Assisted-by: Claude:claude-opus-5
2026-08-08 08:30:14 +02:00
nameEntry->setPlaceholderText(profile);
nameEntry->setFocus();
deleteButton->setEnabled(false);
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
delete_profile_dialog->setWindowTitle(tr("Deleting '%1'").arg(profile));
Make it simple to delete empty default profiles (#4592) Co-authored-by: Stephen Lyons <slysven@virginmedia.com>
2021-02-17 06:58:21 +01:00
delete_profile_dialog->setAttribute(Qt::WA_DeleteOnClose);
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
delete_profile_dialog->show();
delete_profile_dialog->raise();
start
2009-01-24 02:50:22 +01:00
}
New feature: Set custom icons in profiles list (#2814)
2019-07-25 16:59:16 +02:00
QString dlgConnectionProfiles::readProfileData(const QString& profile, const QString& item) const
merge with experimental secureProfiles branch
2009-01-27 12:46:34 +01:00
{
Infrastructure: add `enums.h` (#7646) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Add `enums.h` where we can add enums and flags to be used throughout the application that don't have a more specific place to be, without dragging in giant classes such as mudlet.h or Host.h. Also added `enums::PackageModuleType` to track the magic numbers used throughout package/module code :rocket: #### Motivation for adding to Mudlet Simplify code organisation. #### Other info (issues closed, discussion etc) --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-01-08 10:04:50 +01:00
QFile file(mudlet::getMudletPath(enums::profileDataItemPath, profile, item));
Infrastructure: mark read-only variables as const (#6843) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Mark read-only variables as const - that is, not intended to change after they've been declared #### Motivation for adding to Mudlet So we don't change them by accident later on, and also to clearly state intentions for the variables #### Other info (issues closed, discussion etc) This is also recommended by the [C++ Core Guidelines](https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#es25-declare-an-object-const-or-constexpr-unless-you-want-to-modify-its-value-later-on)
2023-05-14 15:06:15 +02:00
const bool success = file.open(QIODevice::ReadOnly);
merge with experimental secureProfiles branch
2009-01-27 12:46:34 +01:00
QString ret;
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
if (success) {
QDataStream ifs(&file);
BugFix ameliorate Qt changes to binary formats for QDataStream (#3133) * BugFix ameliorate Qt changes to binary formats for QDataStream In other words - fix https://github.com/Mudlet/Mudlet/issues/3088 ...! This forces the binary file format to be that which is used for Qt 5.12 if the run-time version of the Qt libraries are Qt 5.13 or later. This is needed to handle a change in the format that QFonts are saved/loaded in a binary form in a QDataStream but it also clamps the binary format to be equivalent to QDataStream::Qt_5_12 everywhere I could see it used so that future Mudlet versions do not suffer further issues going forward when Qt revise the QDataStream format for the classes it handles. This should also close https://github.com/Mudlet/Mudlet/issues/785 ! NOTE: THIS WILL BREAK THINGS TEMPORARILY FOR USERS OF MUDLET VERSIONS AFTER 4.0.1 OR THOSE WHO HAVE MANUALLY SET THE FILE FORMAT ON THEIR MAP TO BE VERSION 19 OR HIGHER AND HAVE MOVED BETWEEN A MUDLET USING A RUN-TIME QT VERSION LESS THAN QT 5.13 AND ONE USING THAT OR LATER. IT WILL LIKELY CAUSE EXISTING MAP FILE CONTENTS TO BECOME GARBAGE WHEN READ BY A MUDLET VERSION INCLUDING THIS PULL-REQUEST - SO IT IS NECESSARY TO OPEN ANY WANTED VERSION 19 OR LATER MAP FILES IN THE CURRENT (BUGGY) QT 5.13 OR LATER USING MUDLET AND RESAVE IT IN MUDLET FILE FORMAT 18 BEFORE UPGRADING TO A MUDLET WITH THIS PULL-REQUEST INCLUDED. ONCE THE MAP IS THEN LOADED IN THE NEWER MUDLET IT CAN BE RESET TO THE LATEST MAP FORMAT - and we should avoid similar Qt library change induced problems in the future. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2019-09-29 23:41:58 +02:00
if (mudlet::scmRunTimeQtVersion >= QVersionNumber(5, 13, 0)) {
ifs.setVersion(mudlet::scmQDataStreamFormat_5_12);
}
Fixed IO errors as a result of trying to read from inexistent files. We can ignore the inexistent files in this case as default values are substituted for them elsewhere.
2014-02-02 13:20:56 +10:00
ifs >> ret;
file.close();
}
merge with experimental secureProfiles branch
2009-01-27 12:46:34 +01:00
return ret;
}
infrastructure: keep the profile-removal file list from going stale (#9739) #### Brief overview of PR changes/additions - Hoists the list `slot_deleteProfile()` checks a never-played profile against out of the function to `dlgConnectionProfiles::scmConnectionDetailFiles`, beside the file's other `scm*` constants, and points at it from both `writeProfileData()` implementations. - Adds a `ProfileDeletionSafetyTest` case that sets a profile up through the real dialog (New profile, name it, fill the connection form in, re-select it) and fails if anything it wrote is missing from the list. - Pins the deliberate exclusions too: a profile holding a stored password or a typed-in character name still asks before removal. #### Motivation for adding to Mudlet Nothing linked that list to the ~15 places profile data gets written, so it could silently go stale; because it is an allowlist a stale entry only ever costs an extra confirmation prompt, but the maintenance trap was worth closing. #### Other info (issues closed, discussion etc) Follows up https://github.com/Mudlet/Mudlet/pull/9722#discussion_r3740581754 on #9722 (fix: a profile named "." or ".." deletes every profile when removed). No behaviour change. **Test case:** `ctest -R ProfileDeletionSafetyTest` (20 cases). Removing an entry from the constant makes it fail naming the file; adding `login` makes the character-name case fail. Assisted-by: Claude:claude-opus-5
2026-08-08 19:30:26 +02:00
// A new item here may need adding to scmConnectionDetailFiles above. Unlike
// mudlet::writeProfileData() this does not create the profile's folder, so a
// write before there is one is quietly dropped.
Improve first-time user experience (#1016) * Fixed the welcome message to show again It didn't before because default_host profile directory was getting created on the disk before the check. * Made it so a random profile gets selected for a first-time launch * Modernized mudlet::startAutoLogin function * Renamed poorly-named method to open connections dialog It also was confusing with Host::connectToServer doing the actual connecting * Made the connection dialog open if no profiles are on autoload * Removed superseded status bar notification The connection dialog now opens automatically. * Improved first-launch Mudlet size and positioning Mudlet is now centered and has a decent size for the most common resolutions * Fix connection dialog to get a decent size by default * Updated the welcome text It was pretty ancient and referenced outdated button names. Also cut down on the wording so a new user isn't hit with a wall of text. * Moved icon over to left so the screen isn't so busy * Undid hardcoded fonts and sizes in connection dialog User-selected desktop fonts and sizes should be used instead. * Fixed connection dialog to actually select the last played profile There was a bug where it would ignore predefined profiles in the calculation. Also use the last modified, not read date - a lot of things like virus scanners could read the directory whereas far fewer things will write to it. * Moved 'loaded profile' warning to be below profiles This prevents the whole thing from jumping around. * Added a margin to the right for aesthetic reasons * Revised to use getDescription as a method * Got tooltips to show on profile icons
2017-06-04 08:13:51 +02:00
QPair<bool, QString> dlgConnectionProfiles::writeProfileData(const QString& profile, const QString& item, const QString& what)
merge with experimental secureProfiles branch
2009-01-27 12:46:34 +01:00
{
Infrastructure: add `enums.h` (#7646) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Add `enums.h` where we can add enums and flags to be used throughout the application that don't have a more specific place to be, without dragging in giant classes such as mudlet.h or Host.h. Also added `enums::PackageModuleType` to track the magic numbers used throughout package/module code :rocket: #### Motivation for adding to Mudlet Simplify code organisation. #### Other info (issues closed, discussion etc) --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-01-08 10:04:50 +01:00
QSaveFile file(mudlet::getMudletPath(enums::profileDataItemPath, profile, item));
Improve first-time user experience (#1016) * Fixed the welcome message to show again It didn't before because default_host profile directory was getting created on the disk before the check. * Made it so a random profile gets selected for a first-time launch * Modernized mudlet::startAutoLogin function * Renamed poorly-named method to open connections dialog It also was confusing with Host::connectToServer doing the actual connecting * Made the connection dialog open if no profiles are on autoload * Removed superseded status bar notification The connection dialog now opens automatically. * Improved first-launch Mudlet size and positioning Mudlet is now centered and has a decent size for the most common resolutions * Fix connection dialog to get a decent size by default * Updated the welcome text It was pretty ancient and referenced outdated button names. Also cut down on the wording so a new user isn't hit with a wall of text. * Moved icon over to left so the screen isn't so busy * Undid hardcoded fonts and sizes in connection dialog User-selected desktop fonts and sizes should be used instead. * Fixed connection dialog to actually select the last played profile There was a bug where it would ignore predefined profiles in the calculation. Also use the last modified, not read date - a lot of things like virus scanners could read the directory whereas far fewer things will write to it. * Moved 'loaded profile' warning to be below profiles This prevents the whole thing from jumping around. * Added a margin to the right for aesthetic reasons * Revised to use getDescription as a method * Got tooltips to show on profile icons
2017-06-04 08:13:51 +02:00
if (file.open(QIODevice::WriteOnly | QIODevice::Unbuffered)) {
QDataStream ofs(&file);
BugFix ameliorate Qt changes to binary formats for QDataStream (#3133) * BugFix ameliorate Qt changes to binary formats for QDataStream In other words - fix https://github.com/Mudlet/Mudlet/issues/3088 ...! This forces the binary file format to be that which is used for Qt 5.12 if the run-time version of the Qt libraries are Qt 5.13 or later. This is needed to handle a change in the format that QFonts are saved/loaded in a binary form in a QDataStream but it also clamps the binary format to be equivalent to QDataStream::Qt_5_12 everywhere I could see it used so that future Mudlet versions do not suffer further issues going forward when Qt revise the QDataStream format for the classes it handles. This should also close https://github.com/Mudlet/Mudlet/issues/785 ! NOTE: THIS WILL BREAK THINGS TEMPORARILY FOR USERS OF MUDLET VERSIONS AFTER 4.0.1 OR THOSE WHO HAVE MANUALLY SET THE FILE FORMAT ON THEIR MAP TO BE VERSION 19 OR HIGHER AND HAVE MOVED BETWEEN A MUDLET USING A RUN-TIME QT VERSION LESS THAN QT 5.13 AND ONE USING THAT OR LATER. IT WILL LIKELY CAUSE EXISTING MAP FILE CONTENTS TO BECOME GARBAGE WHEN READ BY A MUDLET VERSION INCLUDING THIS PULL-REQUEST - SO IT IS NECESSARY TO OPEN ANY WANTED VERSION 19 OR LATER MAP FILES IN THE CURRENT (BUGGY) QT 5.13 OR LATER USING MUDLET AND RESAVE IT IN MUDLET FILE FORMAT 18 BEFORE UPGRADING TO A MUDLET WITH THIS PULL-REQUEST INCLUDED. ONCE THE MAP IS THEN LOADED IN THE NEWER MUDLET IT CAN BE RESET TO THE LATEST MAP FORMAT - and we should avoid similar Qt library change induced problems in the future. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2019-09-29 23:41:58 +02:00
if (mudlet::scmRunTimeQtVersion >= QVersionNumber(5, 13, 0)) {
ofs.setVersion(mudlet::scmQDataStreamFormat_5_12);
}
Improve first-time user experience (#1016) * Fixed the welcome message to show again It didn't before because default_host profile directory was getting created on the disk before the check. * Made it so a random profile gets selected for a first-time launch * Modernized mudlet::startAutoLogin function * Renamed poorly-named method to open connections dialog It also was confusing with Host::connectToServer doing the actual connecting * Made the connection dialog open if no profiles are on autoload * Removed superseded status bar notification The connection dialog now opens automatically. * Improved first-launch Mudlet size and positioning Mudlet is now centered and has a decent size for the most common resolutions * Fix connection dialog to get a decent size by default * Updated the welcome text It was pretty ancient and referenced outdated button names. Also cut down on the wording so a new user isn't hit with a wall of text. * Moved icon over to left so the screen isn't so busy * Undid hardcoded fonts and sizes in connection dialog User-selected desktop fonts and sizes should be used instead. * Fixed connection dialog to actually select the last played profile There was a bug where it would ignore predefined profiles in the calculation. Also use the last modified, not read date - a lot of things like virus scanners could read the directory whereas far fewer things will write to it. * Moved 'loaded profile' warning to be below profiles This prevents the whole thing from jumping around. * Added a margin to the right for aesthetic reasons * Revised to use getDescription as a method * Got tooltips to show on profile icons
2017-06-04 08:13:51 +02:00
ofs << what;
Improve: save files in a more reliable manner (#6738) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Use [QSaveFile](https://doc.qt.io/qt-5/qsavefile.html) for all cases where Mudlet is writing to disk (profiles, maps, notes, ...). QSaveFile does a few things under the hood to ensure a file can be written safely, and gives a nice error if no. #### Motivation for adding to Mudlet I'm hoping this'll address some cases of folks' settings resetting or some other weird things happening - which happens once in a blue moon, but still does. Doing disk IO on scale is something that is eventually bound to run into issues, I had the same with the Svo system. Hopefully this'll cover things off. #### Other info (issues closed, discussion etc) Fix https://github.com/Mudlet/Mudlet/issues/1342 --------- Co-authored-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: SlySven <SlySven@users.noreply.github.com>
2023-04-25 19:28:34 +02:00
if (!file.commit()) {
qDebug().noquote().nospace() << "dlgConnectionProfiles::writeProfileData(...) ERROR - writing profile: \"" << profile << "\", item: \"" << item << "\", reason: \"" << file.errorString()
<< "\".";
}
Improve first-time user experience (#1016) * Fixed the welcome message to show again It didn't before because default_host profile directory was getting created on the disk before the check. * Made it so a random profile gets selected for a first-time launch * Modernized mudlet::startAutoLogin function * Renamed poorly-named method to open connections dialog It also was confusing with Host::connectToServer doing the actual connecting * Made the connection dialog open if no profiles are on autoload * Removed superseded status bar notification The connection dialog now opens automatically. * Improved first-launch Mudlet size and positioning Mudlet is now centered and has a decent size for the most common resolutions * Fix connection dialog to get a decent size by default * Updated the welcome text It was pretty ancient and referenced outdated button names. Also cut down on the wording so a new user isn't hit with a wall of text. * Moved icon over to left so the screen isn't so busy * Undid hardcoded fonts and sizes in connection dialog User-selected desktop fonts and sizes should be used instead. * Fixed connection dialog to actually select the last played profile There was a bug where it would ignore predefined profiles in the calculation. Also use the last modified, not read date - a lot of things like virus scanners could read the directory whereas far fewer things will write to it. * Moved 'loaded profile' warning to be below profiles This prevents the whole thing from jumping around. * Added a margin to the right for aesthetic reasons * Revised to use getDescription as a method * Got tooltips to show on profile icons
2017-06-04 08:13:51 +02:00
}
Improve: save files in a more reliable manner (#6738) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Use [QSaveFile](https://doc.qt.io/qt-5/qsavefile.html) for all cases where Mudlet is writing to disk (profiles, maps, notes, ...). QSaveFile does a few things under the hood to ensure a file can be written safely, and gives a nice error if no. #### Motivation for adding to Mudlet I'm hoping this'll address some cases of folks' settings resetting or some other weird things happening - which happens once in a blue moon, but still does. Doing disk IO on scale is something that is eventually bound to run into issues, I had the same with the Svo system. Hopefully this'll cover things off. #### Other info (issues closed, discussion etc) Fix https://github.com/Mudlet/Mudlet/issues/1342 --------- Co-authored-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: SlySven <SlySven@users.noreply.github.com>
2023-04-25 19:28:34 +02:00
if (file.error() == QFileDevice::NoError) {
return {true, QString()};
Improve first-time user experience (#1016) * Fixed the welcome message to show again It didn't before because default_host profile directory was getting created on the disk before the check. * Made it so a random profile gets selected for a first-time launch * Modernized mudlet::startAutoLogin function * Renamed poorly-named method to open connections dialog It also was confusing with Host::connectToServer doing the actual connecting * Made the connection dialog open if no profiles are on autoload * Removed superseded status bar notification The connection dialog now opens automatically. * Improved first-launch Mudlet size and positioning Mudlet is now centered and has a decent size for the most common resolutions * Fix connection dialog to get a decent size by default * Updated the welcome text It was pretty ancient and referenced outdated button names. Also cut down on the wording so a new user isn't hit with a wall of text. * Moved icon over to left so the screen isn't so busy * Undid hardcoded fonts and sizes in connection dialog User-selected desktop fonts and sizes should be used instead. * Fixed connection dialog to actually select the last played profile There was a bug where it would ignore predefined profiles in the calculation. Also use the last modified, not read date - a lot of things like virus scanners could read the directory whereas far fewer things will write to it. * Moved 'loaded profile' warning to be below profiles This prevents the whole thing from jumping around. * Added a margin to the right for aesthetic reasons * Revised to use getDescription as a method * Got tooltips to show on profile icons
2017-06-04 08:13:51 +02:00
}
Infrastructure: Remove else-after-return anti-pattern (#8575) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Remove unnecessary else blocks following return statements throughout the codebase. #### Motivation for adding to Mudlet Better code readability #### Other info (issues closed, discussion etc) Other anti patterns are visible in this PR thanks to this, but let's keep this PR focused on one pattern only. --------- Co-authored-by: Claude <noreply@anthropic.com>
2025-11-25 18:10:28 +01:00
return {false, file.errorString()};
merge with experimental secureProfiles branch
2009-01-27 12:46:34 +01:00
}
Infrastructure: centralise predefined MUD game data (#6434) This moves the "description" data into the same container as all the other details for the predefined MUDS. That data is then refactored out of the `./src/mudlet.h` file into a separate smaller file that only needs to be `#include`d into two class files - so changing any details requires less to rebuild the application. This PR also removes the 3rd party dependency "qt-ordered-map" (which is 3-clause BSD licensed but NOT currently mentioned in our "About" dialogue!) Afterwards the details for each predefined MUD is held in a `QList<T>` instead - with a couple of helper methods defined to reproduce the information retrieval methods used in the prior code. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Vadim Peretokin <vperetokin@gmail.com>
2022-11-27 00:00:34 +00:00
QString dlgConnectionProfiles::getDescription(const QString& profile_name) const
Improve first-time user experience (#1016) * Fixed the welcome message to show again It didn't before because default_host profile directory was getting created on the disk before the check. * Made it so a random profile gets selected for a first-time launch * Modernized mudlet::startAutoLogin function * Renamed poorly-named method to open connections dialog It also was confusing with Host::connectToServer doing the actual connecting * Made the connection dialog open if no profiles are on autoload * Removed superseded status bar notification The connection dialog now opens automatically. * Improved first-launch Mudlet size and positioning Mudlet is now centered and has a decent size for the most common resolutions * Fix connection dialog to get a decent size by default * Updated the welcome text It was pretty ancient and referenced outdated button names. Also cut down on the wording so a new user isn't hit with a wall of text. * Moved icon over to left so the screen isn't so busy * Undid hardcoded fonts and sizes in connection dialog User-selected desktop fonts and sizes should be used instead. * Fixed connection dialog to actually select the last played profile There was a bug where it would ignore predefined profiles in the calculation. Also use the last modified, not read date - a lot of things like virus scanners could read the directory whereas far fewer things will write to it. * Moved 'loaded profile' warning to be below profiles This prevents the whole thing from jumping around. * Added a margin to the right for aesthetic reasons * Revised to use getDescription as a method * Got tooltips to show on profile icons
2017-06-04 08:13:51 +02:00
{
add get/setProfileInformation() to modify profile information field (#7511) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions 1. Add `getProfileInformation()` and `setProfileInformation(string)` functions to Lua to read/write to the profile information displayed on the profile connection window. 2. Changed profile connection window text from "Informational" to "Information" to match functions and read clearer. 3. Fix bug where one could not modify default games information text. Now load user information first if present, fallback to default. Clearing user set information (ie. `setProfileInformation("")`) also reverts to default game information. #### Motivation for adding to Mudlet Gives the ability to add profile specific information via the Lua API which can then be seen on the profile connection window. #### Other info (issues closed, discussion etc) closes #5333
2024-11-03 20:40:23 +04:00
QString profileDesc = readProfileData(profile_name, qsl("description"));
if (profileDesc.isEmpty()) {
auto itDetails = TGameDetails::findGame(profile_name);
if (itDetails != TGameDetails::scmDefaultGames.constEnd()) {
if (!(*itDetails).description.isEmpty()) {
return (*itDetails).description;
}
Improve first-time user experience (#1016) * Fixed the welcome message to show again It didn't before because default_host profile directory was getting created on the disk before the check. * Made it so a random profile gets selected for a first-time launch * Modernized mudlet::startAutoLogin function * Renamed poorly-named method to open connections dialog It also was confusing with Host::connectToServer doing the actual connecting * Made the connection dialog open if no profiles are on autoload * Removed superseded status bar notification The connection dialog now opens automatically. * Improved first-launch Mudlet size and positioning Mudlet is now centered and has a decent size for the most common resolutions * Fix connection dialog to get a decent size by default * Updated the welcome text It was pretty ancient and referenced outdated button names. Also cut down on the wording so a new user isn't hit with a wall of text. * Moved icon over to left so the screen isn't so busy * Undid hardcoded fonts and sizes in connection dialog User-selected desktop fonts and sizes should be used instead. * Fixed connection dialog to actually select the last played profile There was a bug where it would ignore predefined profiles in the calculation. Also use the last modified, not read date - a lot of things like virus scanners could read the directory whereas far fewer things will write to it. * Moved 'loaded profile' warning to be below profiles This prevents the whole thing from jumping around. * Added a margin to the right for aesthetic reasons * Revised to use getDescription as a method * Got tooltips to show on profile icons
2017-06-04 08:13:51 +02:00
}
}
Infrastructure: centralise predefined MUD game data (#6434) This moves the "description" data into the same container as all the other details for the predefined MUDS. That data is then refactored out of the `./src/mudlet.h` file into a separate smaller file that only needs to be `#include`d into two class files - so changing any details requires less to rebuild the application. This PR also removes the 3rd party dependency "qt-ordered-map" (which is 3-clause BSD licensed but NOT currently mentioned in our "About" dialogue!) Afterwards the details for each predefined MUD is held in a `QList<T>` instead - with a couple of helper methods defined to reproduce the information retrieval methods used in the prior code. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Vadim Peretokin <vperetokin@gmail.com>
2022-11-27 00:00:34 +00:00
add get/setProfileInformation() to modify profile information field (#7511) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions 1. Add `getProfileInformation()` and `setProfileInformation(string)` functions to Lua to read/write to the profile information displayed on the profile connection window. 2. Changed profile connection window text from "Informational" to "Information" to match functions and read clearer. 3. Fix bug where one could not modify default games information text. Now load user information first if present, fallback to default. Clearing user set information (ie. `setProfileInformation("")`) also reverts to default game information. #### Motivation for adding to Mudlet Gives the ability to add profile specific information via the Lua API which can then be seen on the profile connection window. #### Other info (issues closed, discussion etc) closes #5333
2024-11-03 20:40:23 +04:00
return profileDesc;
Improve first-time user experience (#1016) * Fixed the welcome message to show again It didn't before because default_host profile directory was getting created on the disk before the check. * Made it so a random profile gets selected for a first-time launch * Modernized mudlet::startAutoLogin function * Renamed poorly-named method to open connections dialog It also was confusing with Host::connectToServer doing the actual connecting * Made the connection dialog open if no profiles are on autoload * Removed superseded status bar notification The connection dialog now opens automatically. * Improved first-launch Mudlet size and positioning Mudlet is now centered and has a decent size for the most common resolutions * Fix connection dialog to get a decent size by default * Updated the welcome text It was pretty ancient and referenced outdated button names. Also cut down on the wording so a new user isn't hit with a wall of text. * Moved icon over to left so the screen isn't so busy * Undid hardcoded fonts and sizes in connection dialog User-selected desktop fonts and sizes should be used instead. * Fixed connection dialog to actually select the last played profile There was a bug where it would ignore predefined profiles in the calculation. Also use the last modified, not read date - a lot of things like virus scanners could read the directory whereas far fewer things will write to it. * Moved 'loaded profile' warning to be below profiles This prevents the whole thing from jumping around. * Added a margin to the right for aesthetic reasons * Revised to use getDescription as a method * Got tooltips to show on profile icons
2017-06-04 08:13:51 +02:00
}
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
Infrastructure: tidy up naming of SLOT methods and their usage - Part 2 (#6255) When Qt's slot/signal system is used to invoke a method there is some overhead - so it makes sense to ensure developers can spot all such methods (functions). We have tried to do this with a `slot_` prefix to the methods we create but it has not been applied uniformly. This PR (and one or more to follow) is intended to help with this by more rigorously doing so - the names changed herein should all follow a `slot_`*camelCaseMethodName* style. In addition some methods were detected that are not currently used or which are not actually used via the signal/slot system, these have been commented out or have had the prefix removed and the declaration in the relevant header file moved as appropriate. For reference the changes made are: * `TLuaInterpreter::slotDeleteSender(...)` ==> `TLuaInterpreter::slot_deleteSender(...)` * `TLuaInterpreter::slotPurge()` ==> `TLuaInterpreter::slot_purge()` * `cTelnet::handle_socket_signal_connected()` ==> `cTelnet::slot_socketConnected()` * `cTelnet::handle_socket_signal_disconnected()` ==> `cTelnet::slot_socketDisconnected()` * `cTelnet::handle_socket_signal_hostFound(...)` ==> `cTelnet::slot_socketHostFound(...)` * `cTelnet::handle_socket_signal_readyRead()` ==> `cTelnet::slot_socketReadyToBeRead()` * `cTelnet::handle_socket_signal_sslError(...)` ==> `cTelnet::slot_socketSslError(...)` * `cTelnet::setDownloadProgress(...)` ==> `cTelnet::slot_setDownloadProgress(...)` * `dlgComposer::cancel()` ==> `dlgComposer::slot_cancel()` * `dlgComposer::save()` ==> `dlgComposer::slot_save()` * `dlgConnectionProfiles::slot_item_clicked(...)` ==> `dlgConnectionProfiles::slot_itemClicked(...)` * `dlgConnectionProfiles::slot_save_name()` ==> `dlgConnectionProfiles::slot_saveName()` * `dlgConnectionProfiles::slot_update_login(...)` ==> `dlgConnectionProfiles::slot_updateLogin(...)` * `dlgConnectionProfiles::slot_update_name(...)` ==> `dlgConnectionProfiles::slot_updateName(...)` * `dlgConnectionProfiles::slot_update_pass(...)` ==> `dlgConnectionProfiles::slot_updatePassword(...)` * `dlgConnectionProfiles::slot_update_port(...)` ==> `dlgConnectionProfiles::slot_updatePort(...)` * `dlgConnectionProfiles::slot_update_SSL_TSL_port(...)` ==> `dlgConnectionProfiles::slot_updateSslTslPort(...)` * `dlgConnectionProfiles::slot_update_url(...)` ==> `dlgConnectionProfiles::slot_updateUrl(...)` * `dlgMapLabel::pickBgColor()` ==> `dlgMapLabel::slot_pickBgColor()` * `dlgMapLabel::pickFgColor()` ==> `dlgMapLabel::slot_pickFgColor()` * `dlgMapLabel::pickFile()` ==> `dlgMapLabel::slot_pickFile()` * `dlgMapLabel::pickFont()` ==> `dlgMapLabel::slot_pickFont()` * `dlgMapLabel::save()` ==> `dlgMapLabel::slot_save()` * `dlgMapLabel::updateControls()` ==> `dlgMapLabel::slot_updateControls()` * `dlgMapLabel::updateControlsVisibility()` ==> `dlgMapLabel::slot_updateControlsVisibility()` Commented out as not being used: * `cTelnet::handle_socket_signal_error()` ==> `cTelnet::slot_socketError()` * `dlgConnectionProfiles::slot_update_website(...) ==> `dlgConnectionProfiles::slot_updateWebsite(const QString& url)` I have my doubts about whether the `dlgMapLabel::save()`/`dlgMapLabel::slot_save()` method is needed at all, as it might be that the `QDialog::accept()` slot could have been inserted into the `QObject::connect(...)` call directly instead...? Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-08-27 10:47:01 +02:00
void dlgConnectionProfiles::slot_itemClicked(QListWidgetItem* pItem)
merge with experimental secureProfiles branch
2009-01-27 12:46:34 +01:00
{
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
if (!pItem) {
Fix: prevent password loss in PTBs and improve credential debug messages (#8257) #### Brief overview of PR changes/additions - Fixed a bug where users lost their saved passwords when switching between different Mudlet versions - Added safety checks to prevent password deletion unless you're using a newer version (4.20.0+) - Made error messages clearer and more helpful when password loading fails - Improved the system's ability to find passwords stored in different locations - Added better logging to help diagnose password-related issues #### Motivation for adding to Mudlet Users reported that their saved passwords disappeared after trying development versions of Mudlet. This happened because the system was automatically cleaning up old password storage without considering that users might switch back to older versions. The unclear error messages also made it difficult to understand what was happening when passwords couldn't be loaded. #### Other info (issues closed, discussion etc) This fix ensures users can safely test different Mudlet versions without losing their saved passwords. It also makes password-related problems easier to understand and troubleshoot, while maintaining compatibility with all existing Mudlet installations. --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-09-24 07:28:15 -04:00
qDebug() << "dlgConnectionProfiles::slot_itemClicked() called with null item";
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
return;
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
}
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
fix: show connection details when picking a game on a fresh install (#9451) #### Brief overview of PR changes/additions - Selecting a game on a first-ever launch now swaps the welcome message for the connection details and restores the dialog height - Programmatic selections (startup pre-selection, password-migration refreshes) still show the welcome message - Copying a pre-configured game now rebuilds the list and selects the copy with its details filled in #### Motivation for adding to Mudlet On a fresh install, clicking a game filled hidden fields and appeared to do nothing - a dead end for the very first thing a new user does. #### Other info (issues closed, discussion etc) Closes #3930 **Test case:** Fresh install (empty config dir) → connection dialog shows the welcome message → click any game → connection details appear filled in. Copy a pre-configured game → the copy appears in the list, selected, with editable details. https://github.com/user-attachments/assets/de6df8fa-e1f0-4564-91e8-c286bebdd791 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-22 05:02:00 +02:00
// on a fresh install picking a game has to swap the welcome message for
// the connection details, just as creating a new profile does
revealConnectionDetails();
Refactor: remove minute visible name from Connection dialogue icons We have been trying to hide the text associated with the `QListWidgetItems` in the connection dialogue by setting the font size to the minimum of `1` and by setting it's colour to be white. This is not effective when the background is not white - which is likely for a "Dark" desktop environment. The only way to successfully hide the text is, I think, to not have any! However the text was being used programmatically, so the best way to use a `QListWidget` in this mannar is to store the text elsewhere in each item's structure. Fortunately Qt provides for this with the user data functionality which allows multiple data items (based on the `QVariant` class) to be stored within each `QListWidgetItem` using an integer key to denote the type of the data. Ironically the text, icon and other details for each item are ALSO stored in this way - however for non-Qt internal use the lowest integer key that is to be used is `Qt::UserRole` - which I have assigned to the `(const int) dlgConnectionProfiles::csmNameRole` static value. It is quite possible that a redesign of the Connect Profiles dialogue may use this system to store/cache more details about each profile in the future! The only issue with this is the lack of a: `QListWidget::findData(const QVarient&data, int role = Qt::UserRole ...)` method (c.f. `QComboBox::findData(...)`) so I have had to provide a: `(QList<QListWidgetItem*>) findData(const QListWidget&, const QVariant&, const int role = Qt::UserRole) const; method to fill in this gap and to replace the previous `QListWidget::find(...)` that examined each item's text. Also removed local `(QString) profile` from: `(void) dlgConnectionProfiles::slot_item_clicked(QListWidgetItem*)` as it is merely a redundent duplicate of another local `(QString) profile_name`. Renamed local `(QListWidgetItem*) pM` from: `(void) dlgConnectionProfiles::fillout_form()` to: `(QListWidgetItem*) pItem` as that reflects the name used throughout the rest of the class for this type of variable. Changed a `(QLabel*)::setText(tr(""))` call to the more explicit and less stupid `(QLabel*)::clear()`. Similarly changed a `(QWidget*)::setToolTip("")` to a `(QWidget*)::setToolTip(QString())`. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2020-07-01 20:59:42 +01:00
const QString profile_name = pItem->data(csmNameRole).toString();
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
Fix: prevent password loss in PTBs and improve credential debug messages (#8257) #### Brief overview of PR changes/additions - Fixed a bug where users lost their saved passwords when switching between different Mudlet versions - Added safety checks to prevent password deletion unless you're using a newer version (4.20.0+) - Made error messages clearer and more helpful when password loading fails - Improved the system's ability to find passwords stored in different locations - Added better logging to help diagnose password-related issues #### Motivation for adding to Mudlet Users reported that their saved passwords disappeared after trying development versions of Mudlet. This happened because the system was automatically cleaning up old password storage without considering that users might switch back to older versions. The unclear error messages also made it difficult to understand what was happening when passwords couldn't be loaded. #### Other info (issues closed, discussion etc) This fix ensures users can safely test different Mudlet versions without losing their saved passwords. It also makes password-related problems easier to understand and troubleshoot, while maintaining compatibility with all existing Mudlet installations. --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-09-24 07:28:15 -04:00
// Prevent rapid duplicate clicks on the same profile
static QString lastProfileClicked;
static QTime lastClickTime;
Infrastructure: remove MSVC leak detection (#8378) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Remove support for leak detection using MSVC - this functionality hasn't been in use in a decade, and we're switching to to using [LeakSanitizer](https://github.com/google/sanitizers/wiki/AddressSanitizerLeakSanitizer) instead. #### Motivation for adding to Mudlet Cleaner code. #### Other info (issues closed, discussion etc) --------- Co-authored-by: Claude <noreply@anthropic.com>
2025-10-21 15:11:09 +01:00
Fix: prevent password loss in PTBs and improve credential debug messages (#8257) #### Brief overview of PR changes/additions - Fixed a bug where users lost their saved passwords when switching between different Mudlet versions - Added safety checks to prevent password deletion unless you're using a newer version (4.20.0+) - Made error messages clearer and more helpful when password loading fails - Improved the system's ability to find passwords stored in different locations - Added better logging to help diagnose password-related issues #### Motivation for adding to Mudlet Users reported that their saved passwords disappeared after trying development versions of Mudlet. This happened because the system was automatically cleaning up old password storage without considering that users might switch back to older versions. The unclear error messages also made it difficult to understand what was happening when passwords couldn't be loaded. #### Other info (issues closed, discussion etc) This fix ensures users can safely test different Mudlet versions without losing their saved passwords. It also makes password-related problems easier to understand and troubleshoot, while maintaining compatibility with all existing Mudlet installations. --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-09-24 07:28:15 -04:00
if (profile_name == lastProfileClicked && lastClickTime.isValid() && lastClickTime.msecsTo(QTime::currentTime()) < 100) {
return;
}
Infrastructure: remove MSVC leak detection (#8378) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Remove support for leak detection using MSVC - this functionality hasn't been in use in a decade, and we're switching to to using [LeakSanitizer](https://github.com/google/sanitizers/wiki/AddressSanitizerLeakSanitizer) instead. #### Motivation for adding to Mudlet Cleaner code. #### Other info (issues closed, discussion etc) --------- Co-authored-by: Claude <noreply@anthropic.com>
2025-10-21 15:11:09 +01:00
Fix: prevent password loss in PTBs and improve credential debug messages (#8257) #### Brief overview of PR changes/additions - Fixed a bug where users lost their saved passwords when switching between different Mudlet versions - Added safety checks to prevent password deletion unless you're using a newer version (4.20.0+) - Made error messages clearer and more helpful when password loading fails - Improved the system's ability to find passwords stored in different locations - Added better logging to help diagnose password-related issues #### Motivation for adding to Mudlet Users reported that their saved passwords disappeared after trying development versions of Mudlet. This happened because the system was automatically cleaning up old password storage without considering that users might switch back to older versions. The unclear error messages also made it difficult to understand what was happening when passwords couldn't be loaded. #### Other info (issues closed, discussion etc) This fix ensures users can safely test different Mudlet versions without losing their saved passwords. It also makes password-related problems easier to understand and troubleshoot, while maintaining compatibility with all existing Mudlet installations. --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-09-24 07:28:15 -04:00
lastProfileClicked = profile_name;
lastClickTime = QTime::currentTime();
slot_togglePasswordVisibility(false);
add: Show tutorial invitation on first launch (#9169) #### Brief overview of PR changes/additions - On first launch (no existing profiles), show a focused tutorial invitation instead of the full games list - "Start Tutorial" link launches the Mudlet Tutorial profile directly - "Skip - show me the games list" button reveals the full connection dialog with the tutorial profile preselected - Make the Connect button the dialog's explicit default so Enter in the connection form always means "Connect" (see below) #### Motivation for adding to Mudlet New users currently face a wall of 20+ unknown game names with no guidance - a focused tutorial invitation improves first-time retention by teaching basics before choosing a game. #### Other info (issues closed, discussion etc) https://github.com/user-attachments/assets/2eeb3cb9-f596-4744-b187-24e1fc785246 --- Squash-merge trailers: ``` Assisted-by: Claude:claude-fable-5 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org> ``` --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com> Co-authored-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-18 10:54:52 +02:00
welcome_message->hide();
tabWidget_connectionInfo->show();
informationArea->show();
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
profile_name_entry->setText(profile_name);
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
Infrastructure: Add short qsl macro to stand in for 'QStringLiteral' (#5640)
2021-12-07 06:21:39 +01:00
QString host_url = readProfileData(profile_name, qsl("url"));
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
if (host_url.isEmpty()) {
Added Midnight Sun 2 (#394) (cherry picked from commit 77dfbe1236d121f6c8e59a0afcbade895a9c28ae)
2017-02-28 06:32:37 +01:00
// Host to connect to, see below for port
Infrastructure: centralise predefined MUD game data (#6434) This moves the "description" data into the same container as all the other details for the predefined MUDS. That data is then refactored out of the `./src/mudlet.h` file into a separate smaller file that only needs to be `#include`d into two class files - so changing any details requires less to rebuild the application. This PR also removes the 3rd party dependency "qt-ordered-map" (which is 3-clause BSD licensed but NOT currently mentioned in our "About" dialogue!) Afterwards the details for each predefined MUD is held in a `QList<T>` instead - with a couple of helper methods defined to reproduce the information retrieval methods used in the prior code. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Vadim Peretokin <vperetokin@gmail.com>
2022-11-27 00:00:34 +00:00
auto it = TGameDetails::findGame(profile_name);
if (it != TGameDetails::scmDefaultGames.end()) {
host_url = (*it).hostUrl;
Add Legends of the Jedi connection option (#5306)
2021-07-05 23:31:53 -07:00
}
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
}
host_name_entry->setText(host_url);
Infrastructure: Add short qsl macro to stand in for 'QStringLiteral' (#5640)
2021-12-07 06:21:39 +01:00
QString host_port = readProfileData(profile_name, qsl("port"));
QString val = readProfileData(profile_name, qsl("ssl_tsl"));
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
if (val.toInt() == Qt::Checked) {
port_ssl_tsl->setChecked(true);
} else {
port_ssl_tsl->setChecked(false);
}
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
if (host_port.isEmpty()) {
Infrastructure: centralise predefined MUD game data (#6434) This moves the "description" data into the same container as all the other details for the predefined MUDS. That data is then refactored out of the `./src/mudlet.h` file into a separate smaller file that only needs to be `#include`d into two class files - so changing any details requires less to rebuild the application. This PR also removes the 3rd party dependency "qt-ordered-map" (which is 3-clause BSD licensed but NOT currently mentioned in our "About" dialogue!) Afterwards the details for each predefined MUD is held in a `QList<T>` instead - with a couple of helper methods defined to reproduce the information retrieval methods used in the prior code. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Vadim Peretokin <vperetokin@gmail.com>
2022-11-27 00:00:34 +00:00
auto it = TGameDetails::findGame(profile_name);
if (it != TGameDetails::scmDefaultGames.end()) {
host_port = QString::number((*it).port);
port_ssl_tsl->setChecked((*it).tlsEnabled);
Enable Busted tests inside Mudlet (#2617) * Run busted tests in mudlet, added test_profile. - This adds the ability to run tests written for the Busted test framework, which was written by Olivine Labs. More info at https://olivinelabs.com/busted/ - It adds a new test_profile, which loads the new run-tests.xml package. - It changes the build to install the tests in a platform dependent directory next to the geyser directory. - It adds a simple starter test, named MudletBusted_spec.lua * Ran the formatter. * Changed comparison string for clarity. * Changed wording & domain, fixed duplication bug. * Better comment in src/run-tests.xml Co-Authored-By: Vadim Peretokin <vperetokin@gmail.com> * Added message if busted package not found. * Add 'make install' for cmake files
2019-06-16 18:52:22 -06:00
}
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
}
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
port_entry->setText(host_port);
Add a toggle to store password securely, in OS or in the profile (#3121) * Add password migration toggle * Remove colourroles * Store/load option for secure storage * Minor QA cleanup, remove debug messages * Remove checkmark, it looks poor on Windows * Fix 'Copy profile' not to lose password if you're storing them securely * Actually write password to storage on copy as well * Only save secure passwords if we're using secure password storage * Store passwords in profile storage if using profile storage on edit * Use correct tooltip for secure/profile storage * Fix header return signature to match function's
2019-09-30 11:19:28 +02:00
// if we're currently copying a profile, don't blank and re-load the password,
// because there isn't one in storage yet. It'll be copied over into the widget
// by the copy method
if (!mCopyingProfile) {
Fix: Changing one profile's password no longer affects others (#9049) #### Brief overview of PR changes/additions Fixes an issue where changing the password for one profile would overwrite the passwords of other profiles. This primarily affected Windows users due to how the system credential storage works differently from macOS and Linux. #### Motivation for adding to Mudlet Users reported that setting a password on one profile caused all other profiles to use that same password. This made it impossible to have different passwords for different game connections. The fix ensures each profile's password is stored separately on all platforms. #### Other info (issues closed, discussion etc) Closes #9006
2026-03-18 12:15:40 -04:00
// Cancel any pending password save from the previous profile to prevent
// cross-profile password corruption when rapidly switching profiles
if (mPasswordSaveTimer) {
mPasswordSaveTimer->stop();
}
mPendingPasswordSaveProfile.clear();
// Block signals when clearing to prevent triggering a save for the wrong profile
{
const QSignalBlocker blocker(character_password_entry);
character_password_entry->setText(QString());
}
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
// Schedule password loading asynchronously to avoid event loop issues
auto* timer = new QTimer(this);
timer->setSingleShot(true);
timer->setProperty("profileName", profile_name);
connect(timer, &QTimer::timeout, this, &dlgConnectionProfiles::slot_loadPasswordAsync);
infrastructure: use std::chrono literals for time durations (#9493) #### Brief overview of PR changes/additions Convert raw millisecond integer literals at time-duration call sites to `std::chrono` literals, and add `#include <chrono>` to each touched translation unit. Examples: - `QTimer::singleShot(0, ...)` → `QTimer::singleShot(0ms, ...)` - `mpTimerReplay->setInterval(1000)` → `setInterval(1s)` - `mPendingTimer.start(60000)` → `start(1min)` - `QObject::startTimer(50)` → `startTimer(50ms)` - `QTest::qWait(100)` → `QTest::qWait(100ms)` - `QThread::msleep(10)` → `QThread::sleep(10ms)` This is a semantics-preserving refactor - every duration is kept exactly equal to before (e.g. `1000` ms becomes `1s`, `60000` ms becomes `1min`). No behavioural change. #### Motivation for adding to Mudlet Chrono literals make time durations self-documenting and type-safe. `1s` / `100ms` read unambiguously where a bare `1000` / `100` forces the reader to remember each API's unit, and the compiler now rejects unit mismatches. Only genuine duration arguments were converted - loop counts, scroll-line counts, sizes, ports and the like were deliberately left as plain integers. All targeted APIs provide `std::chrono` overloads in the minimum supported Qt (6.8.2): `QTimer::singleShot`/`start`/`setInterval` (5.8), `QObject::startTimer` (5.9), `QThread::sleep(std::chrono::nanoseconds)` (6.6) and `QTest::qWait(std::chrono::milliseconds)` (6.7). #### Other info (issues closed, discussion etc) Test case: the full application builds cleanly and the entire functional `ctest` suite passes. The only failing test is the known, pre-existing `PasswordMigrationTest` LSan exit-leak (GTK3/fontconfig noise), which is unrelated to this change. Assisted-by: Claude:claude-opus-4-8
2026-07-25 20:24:31 +02:00
timer->start(0ms);
Add a toggle to store password securely, in OS or in the profile (#3121) * Add password migration toggle * Remove colourroles * Store/load option for secure storage * Minor QA cleanup, remove debug messages * Remove checkmark, it looks poor on Windows * Fix 'Copy profile' not to lose password if you're storing them securely * Actually write password to storage on copy as well * Only save secure passwords if we're using secure password storage * Store passwords in profile storage if using profile storage on edit * Use correct tooltip for secure/profile storage * Fix header return signature to match function's
2019-09-30 11:19:28 +02:00
}
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
Infrastructure: Add short qsl macro to stand in for 'QStringLiteral' (#5640)
2021-12-07 06:21:39 +01:00
val = readProfileData(profile_name, qsl("login"));
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
login_entry->setText(val);
Infrastructure: Add short qsl macro to stand in for 'QStringLiteral' (#5640)
2021-12-07 06:21:39 +01:00
val = readProfileData(profile_name, qsl("autologin"));
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
if (val.toInt() == Qt::Checked) {
autologin_checkBox->setChecked(true);
} else {
autologin_checkBox->setChecked(false);
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
}
Update: remove Midkemia (and add WoTMUD) to list of predefined MUDs (#321) * Update: remove Midkemia (and add WoTMUD) to list of predefined MUDs The I.R.E. MUD Midkemia-online was shutdown on 2016/09/07 and it is not helpful to continue to offer it as a predefined MUD in the connection dialog. This commit removes it from that list and adds a favourite of mine "WoTMUD" to replace it. The logo is a temporary one that I will replace with a similar one that I need to get clearance to use (and release with a GPL2.1+ licence) from the Wheel of Time MUD sysop with whom I am in contact {Vivienne needs to get approval from the creator Flash who is away for a few days...!} The dlgConnectionProfiles.cpp file has quite a few ASCII strings, as appropriate for a file that will in the future be subject to I18n work I took the opportunity to put QStringLiteral(...) wrappers around the QStrings that are used for non-GUI tasks and tr(...) ones that are. I expect it isn't complete but it goes someway towards dealing with THIS particular file - and it should improve very slightly the generation of QStrings that need to be constructed because it means as much of possible of them is done at compile rather than run-time...! In relation to the above there are points in the code where QStrings are compared to "" to see if they do not have any contents - the isEmpty() method is a better way to do the same (it does not involve a string expression) In (void)dlgConnectionProfiles::slot_update_name( const QString ) there are a couple of variables that use a double underscore prefix - that is NOT A Good Idea: such a prefix is RESERVED in both C and C++. For example see: [what-are-the-rules-about-using-an-underscore-in-a-c-identifier](http://stackoverflow.com/questions/228783/what-are-the-rules-about-using-an-underscore-in-a-c-identifier) also a single prefix might be a bit of a problem with libraries... I have renames the offending things there - but I may have used the single underscore prefix myself in the past. *blush* There are some help messages in this class that use an apostrophe in a word contraction - as a matter of readability this is not considered best practice IMHO so I have converted them to the full words. Following experiences in my previous Pull Request I also took a look at the initialisation and use of some member variables; it became clear that: * (QString) dlgConnectionProfiles::mOrigin * (bool) dlgConnectionProfiles::mEditOK were not used and could be simply deleted and that: * (QString) dlgConnectionProfiles::mUnsavedProfileName * (QString) dlgConnectionProfiles::mCurrentProfileEditName did not need to be member variables and could be local to the method that used them, so in (void)dlgConnectionProfiles::slot_save_name(): * (QString) dlgConnectionProfiles::mCurrentProfileEditName becomes local: (QString) currentProfileEditName and in (void) dlgConnectionProfiles::slot_addProfile(): * (QString) dlgConnectionProfiles::mUnsavedProfileName becomes local: (QString) newName also added initialisers for: * (QStringList) dlgConnectionProfiles::mProfileList * (QPushButton *) dlgConnectionProfiles::connect_button * (QLineEditQPushButton *) dlgConnectionProfiles::delete_profile_lineedit * (QPushButton *) dlgConnectionProfiles::delete_button Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * More: two items missed from prior commit In the previous commit I forgot to take out: * a check for Midkemia in the dlgProfilePreferences class constructor that enabled the download map options; * a similar check in (bool)TMap::restore(QString) that asked if the user wanted to download a map if there was not one found. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * Tweak: Insert MUD supplied Logo/Icon Received an icon as a .jpg that the MUD operators can allow us to licence as GPL2.1+ which I have converted to a .png file. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2016-10-15 09:57:17 +01:00
Infrastructure: Add short qsl macro to stand in for 'QStringLiteral' (#5640)
2021-12-07 06:21:39 +01:00
val = readProfileData(profile_name, qsl("autoreconnect"));
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
if (!val.isEmpty() && val.toInt() == Qt::Checked) {
auto_reconnect->setChecked(true);
} else {
auto_reconnect->setChecked(false);
}
Infrastructure: Add short qsl macro to stand in for 'QStringLiteral' (#5640)
2021-12-07 06:21:39 +01:00
mDiscordApplicationId = readProfileData(profile_name, qsl("discordApplicationId"));
mDiscordInviteURL = readProfileData(profile_name, qsl("discordInviteURL"));
Add Discord support (#1716)
2018-10-05 06:25:57 +02:00
Infrastructure: centralise predefined MUD game data (#6434) This moves the "description" data into the same container as all the other details for the predefined MUDS. That data is then refactored out of the `./src/mudlet.h` file into a separate smaller file that only needs to be `#include`d into two class files - so changing any details requires less to rebuild the application. This PR also removes the 3rd party dependency "qt-ordered-map" (which is 3-clause BSD licensed but NOT currently mentioned in our "About" dialogue!) Afterwards the details for each predefined MUD is held in a `QList<T>` instead - with a couple of helper methods defined to reproduce the information retrieval methods used in the prior code. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Vadim Peretokin <vperetokin@gmail.com>
2022-11-27 00:00:34 +00:00
mud_description_textedit->setPlainText(getDescription(profile_name));
Update: remove Midkemia (and add WoTMUD) to list of predefined MUDs (#321) * Update: remove Midkemia (and add WoTMUD) to list of predefined MUDs The I.R.E. MUD Midkemia-online was shutdown on 2016/09/07 and it is not helpful to continue to offer it as a predefined MUD in the connection dialog. This commit removes it from that list and adds a favourite of mine "WoTMUD" to replace it. The logo is a temporary one that I will replace with a similar one that I need to get clearance to use (and release with a GPL2.1+ licence) from the Wheel of Time MUD sysop with whom I am in contact {Vivienne needs to get approval from the creator Flash who is away for a few days...!} The dlgConnectionProfiles.cpp file has quite a few ASCII strings, as appropriate for a file that will in the future be subject to I18n work I took the opportunity to put QStringLiteral(...) wrappers around the QStrings that are used for non-GUI tasks and tr(...) ones that are. I expect it isn't complete but it goes someway towards dealing with THIS particular file - and it should improve very slightly the generation of QStrings that need to be constructed because it means as much of possible of them is done at compile rather than run-time...! In relation to the above there are points in the code where QStrings are compared to "" to see if they do not have any contents - the isEmpty() method is a better way to do the same (it does not involve a string expression) In (void)dlgConnectionProfiles::slot_update_name( const QString ) there are a couple of variables that use a double underscore prefix - that is NOT A Good Idea: such a prefix is RESERVED in both C and C++. For example see: [what-are-the-rules-about-using-an-underscore-in-a-c-identifier](http://stackoverflow.com/questions/228783/what-are-the-rules-about-using-an-underscore-in-a-c-identifier) also a single prefix might be a bit of a problem with libraries... I have renames the offending things there - but I may have used the single underscore prefix myself in the past. *blush* There are some help messages in this class that use an apostrophe in a word contraction - as a matter of readability this is not considered best practice IMHO so I have converted them to the full words. Following experiences in my previous Pull Request I also took a look at the initialisation and use of some member variables; it became clear that: * (QString) dlgConnectionProfiles::mOrigin * (bool) dlgConnectionProfiles::mEditOK were not used and could be simply deleted and that: * (QString) dlgConnectionProfiles::mUnsavedProfileName * (QString) dlgConnectionProfiles::mCurrentProfileEditName did not need to be member variables and could be local to the method that used them, so in (void)dlgConnectionProfiles::slot_save_name(): * (QString) dlgConnectionProfiles::mCurrentProfileEditName becomes local: (QString) currentProfileEditName and in (void) dlgConnectionProfiles::slot_addProfile(): * (QString) dlgConnectionProfiles::mUnsavedProfileName becomes local: (QString) newName also added initialisers for: * (QStringList) dlgConnectionProfiles::mProfileList * (QPushButton *) dlgConnectionProfiles::connect_button * (QLineEditQPushButton *) dlgConnectionProfiles::delete_profile_lineedit * (QPushButton *) dlgConnectionProfiles::delete_button Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * More: two items missed from prior commit In the previous commit I forgot to take out: * a check for Midkemia in the dlgProfilePreferences class constructor that enabled the download map options; * a similar check in (bool)TMap::restore(QString) that asked if the user wanted to download a map if there was not one found. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * Tweak: Insert MUD supplied Logo/Icon Received an icon as a .jpg that the MUD operators can allow us to licence as GPL2.1+ which I have converted to a .png file. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2016-10-15 09:57:17 +01:00
Infrastructure: Add short qsl macro to stand in for 'QStringLiteral' (#5640)
2021-12-07 06:21:39 +01:00
val = readProfileData(profile_name, qsl("website"));
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
if (val.isEmpty()) {
Infrastructure: centralise predefined MUD game data (#6434) This moves the "description" data into the same container as all the other details for the predefined MUDS. That data is then refactored out of the `./src/mudlet.h` file into a separate smaller file that only needs to be `#include`d into two class files - so changing any details requires less to rebuild the application. This PR also removes the 3rd party dependency "qt-ordered-map" (which is 3-clause BSD licensed but NOT currently mentioned in our "About" dialogue!) Afterwards the details for each predefined MUD is held in a `QList<T>` instead - with a couple of helper methods defined to reproduce the information retrieval methods used in the prior code. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Vadim Peretokin <vperetokin@gmail.com>
2022-11-27 00:00:34 +00:00
auto it = TGameDetails::findGame(profile_name);
if (it != TGameDetails::scmDefaultGames.end()) {
val = (*it).websiteInfo;
Add Legends of the Jedi connection option (#5306)
2021-07-05 23:31:53 -07:00
}
Infrastructure: remove hidden 'Website:' label from connection dialog (#6111) This will close #6087 and address one task in #6031 The original plan was to reposition and show this label but It turns out that we don't really want it anyhow. With it's removal there is no need to retain the remaining two widgets in a `QGridLayout`, and they can be placed in an easier to maintain `QVBoxLayout` instead! Also we will hide the label that shows the Website details when there are none to display. This was briefly discussed between me and Vadim on Discord and felt to be a good idea - as it leaves more space for useful other content (the MUD description or user entered notes). Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-06-17 18:28:01 +01:00
website_entry->setVisible(!val.isEmpty());
} else {
website_entry->show();
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
}
website_entry->setText(val);
misc
2010-03-15 09:37:16 +01:00
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
profile_history->clear();
misc
2010-03-15 09:37:16 +01:00
Infrastructure: add `enums.h` (#7646) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Add `enums.h` where we can add enums and flags to be used throughout the application that don't have a more specific place to be, without dragging in giant classes such as mudlet.h or Host.h. Also added `enums::PackageModuleType` to track the magic numbers used throughout package/module code :rocket: #### Motivation for adding to Mudlet Simplify code organisation. #### Other info (issues closed, discussion etc) --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-01-08 10:04:50 +01:00
QDir dir(mudlet::getMudletPath(enums::profileXmlFilesPath, profile_name));
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
dir.setSorting(QDir::Time);
fix: stop crashes while saving and profiles losing their triggers (#9557) #### Brief overview of PR changes/additions - Profile loading now only considers real `*.xml` saves: an empty QSaveFile temporary left behind by a crash during a save can no longer be loaded as "the profile", which made a profile open with its connection settings intact but every trigger/script seemingly gone. Affected profiles heal themselves on next load by falling back to the newest real save. - Packages that uninstall themselves from their own timer script or event-handler script (a common auto-updater pattern) no longer free the very objects still executing: `TimerUnit`/`ScriptUnit` uninstall now defers deletion while `TTimer::execute()` / `Host::raiseEvent()` are on the call stack, completing the #9337/#9383 fix that already covered triggers/aliases/keys. Deferred timer deletes are flushed before the queued post-uninstall save runs, so removed items cannot be serialized back into the profile. - `Host::saveProfile()`'s background module task no longer reads `writers`/`saveFutures` concurrently with the main thread (data race in the profile save path). #### Motivation for adding to Mudlet Fixes a real-world heap-corruption crash cluster (Sentry MUDLET-32 / MUDLET-2S / MUDLET-48: `STATUS_HEAP_CORRUPTION` on 4.21.0/4.21.1, frames touching lua51/Qt6Core/libpugixml, breadcrumbs showing package uninstall activity around saves) and the profile data loss it caused. #### Other info (issues closed, discussion etc) Root cause of the crashes: #9111 (in the 4.20.1 → 4.21.0 window) changed the `*Unit::uninstall()` methods from unregister-only to immediate `delete`. A package script calling `uninstallPackage()` on its own package then freed objects still on the call stack - use-after-free that poisons the heap, typically detected slightly later during the background save serialization (hence the pugixml/lua frames, aborts mid-save, and zero-byte `....xml.XXXXXX` QSaveFile leftovers in `current/`). #9383 fixed the trigger/alias/key cases; this completes timers and scripts, which reproduce under ASan on current development (heap-use-after-free in `Tree<TScript>::isActive()` / `TTimer::execute()`). Data-loss mechanism (generic): a crash mid-save leaves a 0-byte QSaveFile temporary as the newest file in `current/`; `mudlet::loadProfile()` picked the newest file of any name, tried to load the empty temp, and the profile opened "gutted" (connection details live in separate files and survived). Verified end-to-end with affected profile data and covered by a synthetic regression test. Both new functional tests fail on pre-fix code (`PackageSelfUninstallTest` trips ASan heap-use-after-free; `ProfileLoadTempFileTest` reproduces the data loss) and pass with the fix; full functional suite green (24/24). Known remaining (pre-existing) issue documented in-code at `Host::pendingXmlSaveFutures()`: module writing still touches `writers` from the background task for profiles that use modules; fixing that properly means moving module serialization back to the main thread and deserves its own PR. **Test case:** 1. Create a package containing a timer or event-handler script that calls `uninstallPackage()` on its own package, and let it fire - no crash, package cleanly removed, next save does not resurrect it. 2. Simulate an interrupted save: place an empty file named like `2026-01-01#12-00-00.xml.AbCdEf` in a profile's `current/` folder with the newest timestamp - the profile still loads the newest real save with all triggers intact, and the temporary no longer appears in Connect → Options → Profile history. 3. `ctest -R "ProfileLoadTempFileTest|PackageSelfUninstallTest"` in an ASan (default Debug) build. Assisted-by: Claude:claude-fable-5 Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-30 10:49:10 +02:00
// Only offer real profile saves (*.xml) as history entries; leftover QSaveFile
// temporaries from an interrupted save (e.g. "....xml.AbCdEf") must not be loadable
const QStringList entries = dir.entryList(QStringList{qsl("*.xml")}, QDir::Files | QDir::NoDotAndDotDot, QDir::Time);
misc
2010-03-15 09:37:16 +01:00
Fix new profiles to be saved correctly when created (#2677)
2019-06-29 12:06:56 +02:00
for (const auto& entry : entries) {
Infrastructure: reposition const before type specifier (#7179) #### Brief overview of PR changes/additions This PR tries to put all `const`s before the type (class). #### Motivation for adding to Mudlet There is a mix of positioning of `const`s where it is used to indicate that a variable is not to be modified by program code, we tend to put it before the type but a prior PR (which looks to have been done with an automated tool) has resulted in a mix of cases some with the const adjacent to the variable. This lack of consistency can be confusing. #### Other info (issues closed, discussion etc) It looks like this came about in #6843. This will upset the Danger detector because of the number of files modified but it should be fairly straightforward to review. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2024-03-11 15:40:56 +00:00
const QRegularExpression rx(qsl("(\\d+)\\-(\\d+)\\-(\\d+)#(\\d+)\\-(\\d+)\\-(\\d+).xml"));
const QRegularExpressionMatch match = rx.match(entry);
Replaced QRegExp with QRegularExpression and added QStringLiteral macros in some places
2017-10-05 22:09:32 +03:00
if (match.capturedStart() != -1) {
Update: remove Midkemia (and add WoTMUD) to list of predefined MUDs (#321) * Update: remove Midkemia (and add WoTMUD) to list of predefined MUDs The I.R.E. MUD Midkemia-online was shutdown on 2016/09/07 and it is not helpful to continue to offer it as a predefined MUD in the connection dialog. This commit removes it from that list and adds a favourite of mine "WoTMUD" to replace it. The logo is a temporary one that I will replace with a similar one that I need to get clearance to use (and release with a GPL2.1+ licence) from the Wheel of Time MUD sysop with whom I am in contact {Vivienne needs to get approval from the creator Flash who is away for a few days...!} The dlgConnectionProfiles.cpp file has quite a few ASCII strings, as appropriate for a file that will in the future be subject to I18n work I took the opportunity to put QStringLiteral(...) wrappers around the QStrings that are used for non-GUI tasks and tr(...) ones that are. I expect it isn't complete but it goes someway towards dealing with THIS particular file - and it should improve very slightly the generation of QStrings that need to be constructed because it means as much of possible of them is done at compile rather than run-time...! In relation to the above there are points in the code where QStrings are compared to "" to see if they do not have any contents - the isEmpty() method is a better way to do the same (it does not involve a string expression) In (void)dlgConnectionProfiles::slot_update_name( const QString ) there are a couple of variables that use a double underscore prefix - that is NOT A Good Idea: such a prefix is RESERVED in both C and C++. For example see: [what-are-the-rules-about-using-an-underscore-in-a-c-identifier](http://stackoverflow.com/questions/228783/what-are-the-rules-about-using-an-underscore-in-a-c-identifier) also a single prefix might be a bit of a problem with libraries... I have renames the offending things there - but I may have used the single underscore prefix myself in the past. *blush* There are some help messages in this class that use an apostrophe in a word contraction - as a matter of readability this is not considered best practice IMHO so I have converted them to the full words. Following experiences in my previous Pull Request I also took a look at the initialisation and use of some member variables; it became clear that: * (QString) dlgConnectionProfiles::mOrigin * (bool) dlgConnectionProfiles::mEditOK were not used and could be simply deleted and that: * (QString) dlgConnectionProfiles::mUnsavedProfileName * (QString) dlgConnectionProfiles::mCurrentProfileEditName did not need to be member variables and could be local to the method that used them, so in (void)dlgConnectionProfiles::slot_save_name(): * (QString) dlgConnectionProfiles::mCurrentProfileEditName becomes local: (QString) currentProfileEditName and in (void) dlgConnectionProfiles::slot_addProfile(): * (QString) dlgConnectionProfiles::mUnsavedProfileName becomes local: (QString) newName also added initialisers for: * (QStringList) dlgConnectionProfiles::mProfileList * (QPushButton *) dlgConnectionProfiles::connect_button * (QLineEditQPushButton *) dlgConnectionProfiles::delete_profile_lineedit * (QPushButton *) dlgConnectionProfiles::delete_button Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * More: two items missed from prior commit In the previous commit I forgot to take out: * a check for Midkemia in the dlgProfilePreferences class constructor that enabled the download map options; * a similar check in (bool)TMap::restore(QString) that asked if the user wanted to download a map if there was not one found. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * Tweak: Insert MUD supplied Logo/Icon Received an icon as a .jpg that the MUD operators can allow us to licence as GPL2.1+ which I have converted to a .png file. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2016-10-15 09:57:17 +01:00
QString day;
Infrastructure: mark read-only variables as const (#6843) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Mark read-only variables as const - that is, not intended to change after they've been declared #### Motivation for adding to Mudlet So we don't change them by accident later on, and also to clearly state intentions for the variables #### Other info (issues closed, discussion etc) This is also recommended by the [C++ Core Guidelines](https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#es25-declare-an-object-const-or-constexpr-unless-you-want-to-modify-its-value-later-on)
2023-05-14 15:06:15 +02:00
const QString month = match.captured(2);
Update: remove Midkemia (and add WoTMUD) to list of predefined MUDs (#321) * Update: remove Midkemia (and add WoTMUD) to list of predefined MUDs The I.R.E. MUD Midkemia-online was shutdown on 2016/09/07 and it is not helpful to continue to offer it as a predefined MUD in the connection dialog. This commit removes it from that list and adds a favourite of mine "WoTMUD" to replace it. The logo is a temporary one that I will replace with a similar one that I need to get clearance to use (and release with a GPL2.1+ licence) from the Wheel of Time MUD sysop with whom I am in contact {Vivienne needs to get approval from the creator Flash who is away for a few days...!} The dlgConnectionProfiles.cpp file has quite a few ASCII strings, as appropriate for a file that will in the future be subject to I18n work I took the opportunity to put QStringLiteral(...) wrappers around the QStrings that are used for non-GUI tasks and tr(...) ones that are. I expect it isn't complete but it goes someway towards dealing with THIS particular file - and it should improve very slightly the generation of QStrings that need to be constructed because it means as much of possible of them is done at compile rather than run-time...! In relation to the above there are points in the code where QStrings are compared to "" to see if they do not have any contents - the isEmpty() method is a better way to do the same (it does not involve a string expression) In (void)dlgConnectionProfiles::slot_update_name( const QString ) there are a couple of variables that use a double underscore prefix - that is NOT A Good Idea: such a prefix is RESERVED in both C and C++. For example see: [what-are-the-rules-about-using-an-underscore-in-a-c-identifier](http://stackoverflow.com/questions/228783/what-are-the-rules-about-using-an-underscore-in-a-c-identifier) also a single prefix might be a bit of a problem with libraries... I have renames the offending things there - but I may have used the single underscore prefix myself in the past. *blush* There are some help messages in this class that use an apostrophe in a word contraction - as a matter of readability this is not considered best practice IMHO so I have converted them to the full words. Following experiences in my previous Pull Request I also took a look at the initialisation and use of some member variables; it became clear that: * (QString) dlgConnectionProfiles::mOrigin * (bool) dlgConnectionProfiles::mEditOK were not used and could be simply deleted and that: * (QString) dlgConnectionProfiles::mUnsavedProfileName * (QString) dlgConnectionProfiles::mCurrentProfileEditName did not need to be member variables and could be local to the method that used them, so in (void)dlgConnectionProfiles::slot_save_name(): * (QString) dlgConnectionProfiles::mCurrentProfileEditName becomes local: (QString) currentProfileEditName and in (void) dlgConnectionProfiles::slot_addProfile(): * (QString) dlgConnectionProfiles::mUnsavedProfileName becomes local: (QString) newName also added initialisers for: * (QStringList) dlgConnectionProfiles::mProfileList * (QPushButton *) dlgConnectionProfiles::connect_button * (QLineEditQPushButton *) dlgConnectionProfiles::delete_profile_lineedit * (QPushButton *) dlgConnectionProfiles::delete_button Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * More: two items missed from prior commit In the previous commit I forgot to take out: * a check for Midkemia in the dlgProfilePreferences class constructor that enabled the download map options; * a similar check in (bool)TMap::restore(QString) that asked if the user wanted to download a map if there was not one found. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * Tweak: Insert MUD supplied Logo/Icon Received an icon as a .jpg that the MUD operators can allow us to licence as GPL2.1+ which I have converted to a .png file. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2016-10-15 09:57:17 +01:00
QString year;
Infrastructure: mark read-only variables as const (#6843) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Mark read-only variables as const - that is, not intended to change after they've been declared #### Motivation for adding to Mudlet So we don't change them by accident later on, and also to clearly state intentions for the variables #### Other info (issues closed, discussion etc) This is also recommended by the [C++ Core Guidelines](https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#es25-declare-an-object-const-or-constexpr-unless-you-want-to-modify-its-value-later-on)
2023-05-14 15:06:15 +02:00
const QString hour = match.captured(4);
const QString minute = match.captured(5);
const QString second = match.captured(6);
Replaced QRegExp with QRegularExpression and added QStringLiteral macros in some places
2017-10-05 22:09:32 +03:00
if (match.captured(1).toInt() > 31 && match.captured(3).toInt() >= 1 && match.captured(3).toInt() <= 31) {
Update: remove Midkemia (and add WoTMUD) to list of predefined MUDs (#321) * Update: remove Midkemia (and add WoTMUD) to list of predefined MUDs The I.R.E. MUD Midkemia-online was shutdown on 2016/09/07 and it is not helpful to continue to offer it as a predefined MUD in the connection dialog. This commit removes it from that list and adds a favourite of mine "WoTMUD" to replace it. The logo is a temporary one that I will replace with a similar one that I need to get clearance to use (and release with a GPL2.1+ licence) from the Wheel of Time MUD sysop with whom I am in contact {Vivienne needs to get approval from the creator Flash who is away for a few days...!} The dlgConnectionProfiles.cpp file has quite a few ASCII strings, as appropriate for a file that will in the future be subject to I18n work I took the opportunity to put QStringLiteral(...) wrappers around the QStrings that are used for non-GUI tasks and tr(...) ones that are. I expect it isn't complete but it goes someway towards dealing with THIS particular file - and it should improve very slightly the generation of QStrings that need to be constructed because it means as much of possible of them is done at compile rather than run-time...! In relation to the above there are points in the code where QStrings are compared to "" to see if they do not have any contents - the isEmpty() method is a better way to do the same (it does not involve a string expression) In (void)dlgConnectionProfiles::slot_update_name( const QString ) there are a couple of variables that use a double underscore prefix - that is NOT A Good Idea: such a prefix is RESERVED in both C and C++. For example see: [what-are-the-rules-about-using-an-underscore-in-a-c-identifier](http://stackoverflow.com/questions/228783/what-are-the-rules-about-using-an-underscore-in-a-c-identifier) also a single prefix might be a bit of a problem with libraries... I have renames the offending things there - but I may have used the single underscore prefix myself in the past. *blush* There are some help messages in this class that use an apostrophe in a word contraction - as a matter of readability this is not considered best practice IMHO so I have converted them to the full words. Following experiences in my previous Pull Request I also took a look at the initialisation and use of some member variables; it became clear that: * (QString) dlgConnectionProfiles::mOrigin * (bool) dlgConnectionProfiles::mEditOK were not used and could be simply deleted and that: * (QString) dlgConnectionProfiles::mUnsavedProfileName * (QString) dlgConnectionProfiles::mCurrentProfileEditName did not need to be member variables and could be local to the method that used them, so in (void)dlgConnectionProfiles::slot_save_name(): * (QString) dlgConnectionProfiles::mCurrentProfileEditName becomes local: (QString) currentProfileEditName and in (void) dlgConnectionProfiles::slot_addProfile(): * (QString) dlgConnectionProfiles::mUnsavedProfileName becomes local: (QString) newName also added initialisers for: * (QStringList) dlgConnectionProfiles::mProfileList * (QPushButton *) dlgConnectionProfiles::connect_button * (QLineEditQPushButton *) dlgConnectionProfiles::delete_profile_lineedit * (QPushButton *) dlgConnectionProfiles::delete_button Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * More: two items missed from prior commit In the previous commit I forgot to take out: * a check for Midkemia in the dlgProfilePreferences class constructor that enabled the download map options; * a similar check in (bool)TMap::restore(QString) that asked if the user wanted to download a map if there was not one found. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * Tweak: Insert MUD supplied Logo/Icon Received an icon as a .jpg that the MUD operators can allow us to licence as GPL2.1+ which I have converted to a .png file. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2016-10-15 09:57:17 +01:00
// I have been experimenting with code that puts the year first
// which is actually quite useful - this accommodates such cases
// as well... - SlySven
Replaced QRegExp with QRegularExpression and added QStringLiteral macros in some places
2017-10-05 22:09:32 +03:00
year = match.captured(1);
day = match.captured(3);
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
} else {
Replaced QRegExp with QRegularExpression and added QStringLiteral macros in some places
2017-10-05 22:09:32 +03:00
day = match.captured(1);
year = match.captured(3);
Update: remove Midkemia (and add WoTMUD) to list of predefined MUDs (#321) * Update: remove Midkemia (and add WoTMUD) to list of predefined MUDs The I.R.E. MUD Midkemia-online was shutdown on 2016/09/07 and it is not helpful to continue to offer it as a predefined MUD in the connection dialog. This commit removes it from that list and adds a favourite of mine "WoTMUD" to replace it. The logo is a temporary one that I will replace with a similar one that I need to get clearance to use (and release with a GPL2.1+ licence) from the Wheel of Time MUD sysop with whom I am in contact {Vivienne needs to get approval from the creator Flash who is away for a few days...!} The dlgConnectionProfiles.cpp file has quite a few ASCII strings, as appropriate for a file that will in the future be subject to I18n work I took the opportunity to put QStringLiteral(...) wrappers around the QStrings that are used for non-GUI tasks and tr(...) ones that are. I expect it isn't complete but it goes someway towards dealing with THIS particular file - and it should improve very slightly the generation of QStrings that need to be constructed because it means as much of possible of them is done at compile rather than run-time...! In relation to the above there are points in the code where QStrings are compared to "" to see if they do not have any contents - the isEmpty() method is a better way to do the same (it does not involve a string expression) In (void)dlgConnectionProfiles::slot_update_name( const QString ) there are a couple of variables that use a double underscore prefix - that is NOT A Good Idea: such a prefix is RESERVED in both C and C++. For example see: [what-are-the-rules-about-using-an-underscore-in-a-c-identifier](http://stackoverflow.com/questions/228783/what-are-the-rules-about-using-an-underscore-in-a-c-identifier) also a single prefix might be a bit of a problem with libraries... I have renames the offending things there - but I may have used the single underscore prefix myself in the past. *blush* There are some help messages in this class that use an apostrophe in a word contraction - as a matter of readability this is not considered best practice IMHO so I have converted them to the full words. Following experiences in my previous Pull Request I also took a look at the initialisation and use of some member variables; it became clear that: * (QString) dlgConnectionProfiles::mOrigin * (bool) dlgConnectionProfiles::mEditOK were not used and could be simply deleted and that: * (QString) dlgConnectionProfiles::mUnsavedProfileName * (QString) dlgConnectionProfiles::mCurrentProfileEditName did not need to be member variables and could be local to the method that used them, so in (void)dlgConnectionProfiles::slot_save_name(): * (QString) dlgConnectionProfiles::mCurrentProfileEditName becomes local: (QString) currentProfileEditName and in (void) dlgConnectionProfiles::slot_addProfile(): * (QString) dlgConnectionProfiles::mUnsavedProfileName becomes local: (QString) newName also added initialisers for: * (QStringList) dlgConnectionProfiles::mProfileList * (QPushButton *) dlgConnectionProfiles::connect_button * (QLineEditQPushButton *) dlgConnectionProfiles::delete_profile_lineedit * (QPushButton *) dlgConnectionProfiles::delete_button Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * More: two items missed from prior commit In the previous commit I forgot to take out: * a check for Midkemia in the dlgProfilePreferences class constructor that enabled the download map options; * a similar check in (bool)TMap::restore(QString) that asked if the user wanted to download a map if there was not one found. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * Tweak: Insert MUD supplied Logo/Icon Received an icon as a .jpg that the MUD operators can allow us to licence as GPL2.1+ which I have converted to a .png file. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2016-10-15 09:57:17 +01:00
}
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
QDateTime datetime;
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
datetime.setTime(QTime(hour.toInt(), minute.toInt(), second.toInt()));
datetime.setDate(QDate(year.toInt(), month.toInt(), day.toInt()));
BugFix: make date display of profile's history follow selected UI locale (#3917) * BugFix: make date display of profile's history follow selected UI locale This PR adds a `QLocale` object to the `mudlet` class that is set to the user's selection of UI locale (language + country) so that items that need to return data in a locale aware form can use: `(const QLocale&) mudlet::getUserLocale()` in order to present their information in their selected form rather than using what they or their OS/DE has set system/desktop-wide. In this PR it is used to format and present in the correct language the date and time entries for the profile's history but it can be used elsewhere within the Mudlet application as needed. Also: * reorder some items in `dlgConnectionProfile`'s class to be correct. * mark an unused argument in `dlgConnectionProfile::slot_update_name(...)` as unused to prevent a warning. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * Revise: exclude the display of a time zone in the profile's history It takes up extra space which is tight in that widget and (apart from the time around a DST change) does not impart much information to the display. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * Apply suggestions from code review Removed unwanted ellipses from debug texts... Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2020-07-01 20:49:55 +01:00
profile_history->addItem(mudlet::self()->getUserLocale().toString(datetime, mDateTimeFormat), QVariant(entry));
Add profile autosave (#1773)
2018-07-11 20:52:02 +02:00
} else if (entry == QLatin1String("autosave.xml")) {
Infrastructure: mark read-only variables as const (#6843) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Mark read-only variables as const - that is, not intended to change after they've been declared #### Motivation for adding to Mudlet So we don't change them by accident later on, and also to clearly state intentions for the variables #### Other info (issues closed, discussion etc) This is also recommended by the [C++ Core Guidelines](https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#es25-declare-an-object-const-or-constexpr-unless-you-want-to-modify-its-value-later-on)
2023-05-14 15:06:15 +02:00
const QFileInfo fileInfo(dir, entry);
Add profile autosave (#1773)
2018-07-11 20:52:02 +02:00
auto lastModified = fileInfo.lastModified();
Infrastructure: Add short qsl macro to stand in for 'QStringLiteral' (#5640)
2021-12-07 06:21:39 +01:00
profile_history->addItem(
QIcon::fromTheme(qsl("document-save"), QIcon(qsl(":/icons/document-save.png"))), mudlet::self()->getUserLocale().toString(lastModified, mDateTimeFormat), QVariant(entry));
Fix: ignore non-xml files in profile history (#8035) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Fix: ignore non-xml files in profile history. #### Motivation for adding to Mudlet Fix https://github.com/Mudlet/Mudlet/issues/8034 #### Other info (issues closed, discussion etc) Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-08-17 10:26:26 +02:00
} else if (entry.endsWith(QLatin1String(".xml"), Qt::CaseInsensitive)) {
Add profile autosave (#1773)
2018-07-11 20:52:02 +02:00
profile_history->addItem(entry, QVariant(entry)); // if it has a custom name, use it as it is
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
}
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
}
misc
2010-03-15 09:37:16 +01:00
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
profile_history->setEnabled(static_cast<bool>(profile_history->count()));
misc
2010-03-15 09:37:16 +01:00
Improve profile "currently connected" connection message (#2408)
2019-03-11 20:37:12 +01:00
const QString profileLoadedMessage = tr("This profile is currently loaded - close it before changing the connection parameters.");
Clean up console access code (#4186) * Add a new Host::findConsole function * Sketch: TLuaInterpreter.cpp modification * Fix macros to eval their argument once * More adaptions * TLuaInterpreter: use WINDOW_NAME macro. Some cases not touched because difficult. * macro-ify a lot of functions * Remove no-longer-needed accessors * Clean up font and console handling * unify setFontSize and setMiniConsoleFontSize the latter is now an alias to the former * TConsole methods don't need "MiniConsole" in their name that's redundant * teach Host::updateConsolesFont() to refresh the main console no need to expose these details * Fix font setting * Removed a bunch more unused methods from mudlet.cpp * replace HostManager::getHostList It was only used to * create a list to test membership against just call getHost and check for null * create a list of host names, each of which is then looked up which is unnecessary work * Remove the "QMap<Host*, T*>" anti-pattern It makes much more sense to add a T* member to the Host class. * Allow window names beyond the Lua stack simply treat a missing parameter (or nil) as empty string * Use a nested class for iteration * Fix host iterator * move getLines() to Host * remove mudlet::mTabMap Redundant, the host map and Host::mpConsole works. * more moves to host * Move host-close code to the host * Move even more stuff from mudlet:: to THost:: Also drop mudlet::mpProfilePreferencesDlgMap in favor of a pointer in THost. Sorry that this got mashed in but I was halfway through this before I noticed and didn't want to do the work twice. * These things are pointers, thus should be named as such as annoying as that is … * Vanquish another two pointer-to-host maps * Move host-specific layout updates to THost This patch also removes layering violations in TToolbar and TDockWidget. * mudlet.h include directives cleanup * appease CodeFactor * variable rename * Check for valid dialog * minor cleanup * Revert mistaken checkin of test code from d918164c77382332ad1cd9bd31b2d1ea173267fd * rename function in error messages * Crash fix * renamed args for clarity * Braces please * Bugfix: "echo" didn't talk to labels * Found two wrongly-named exceptions * Clean up merge differences * Merge error * Fix potential NULL deref * Re-add the option to have a prefs dialog without a host * Don't delete the prefs dialog on close * Fix "Don't delete the prefs dialog on close" another way. Apparently Qt correctly handles this when using a QScopedPointer but not using a QSharedPointer. That is, even though the shared pointer still references the dialog, it's killed off without clearing the pointer. Since keeping the dialog around forever isn't a good idea, replace with a QPointer which *is* cleared. Co-authored-by: Vadim Peretokin <vperetokin@gmail.com>
2020-11-04 18:10:21 +01:00
if (mudlet::self()->getHostManager().getHost(profile_name)) {
Fix: prevent deletion of loaded profile (#7436) #### Brief overview of PR changes/additions Using the same code execution that puts up the warning about a profile being used not being editable (in some ways) to also disable the "Remove" button. #### Motivation for adding to Mudlet It has already been proven to break things! #### Other info (issues closed, discussion etc) This should close #2225 - and give me a $20 bounty! This was originally built on top of #7428 - but it was rebased onto `development` - and neither PR is affected by the other one. --------- Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2024-10-07 20:09:51 +01:00
remove_profile_button->setEnabled(false);
remove_profile_button->setToolTip(utils::richText(tr("A profile that is in use cannot be removed")));
Fix: disable connect and offline buttons when a profile is in use (#7673) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Disable connect and offline buttons when a profile is in use #### Motivation for adding to Mudlet Prevent double-loading of module contents - see https://discord.com/channels/283581582550237184/283582068334526464/1330617636601598024 #### Other info (issues closed, discussion etc) ![image](https://github.com/user-attachments/assets/8abe40cd-5f91-4e3e-b463-cde7368e8520) Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-01-21 20:34:40 +01:00
connect_button->setEnabled(false);
offline_button->setEnabled(false);
Fix: prevent deletion of loaded profile (#7436) #### Brief overview of PR changes/additions Using the same code execution that puts up the warning about a profile being used not being editable (in some ways) to also disable the "Remove" button. #### Motivation for adding to Mudlet It has already been proven to break things! #### Other info (issues closed, discussion etc) This should close #2225 - and give me a $20 bounty! This was originally built on top of #7428 - but it was rebased onto `development` - and neither PR is affected by the other one. --------- Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2024-10-07 20:09:51 +01:00
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
profile_name_entry->setReadOnly(true);
host_name_entry->setReadOnly(true);
port_entry->setReadOnly(true);
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
profile_name_entry->setFocusPolicy(Qt::NoFocus);
host_name_entry->setFocusPolicy(Qt::NoFocus);
port_entry->setFocusPolicy(Qt::NoFocus);
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
profile_name_entry->setPalette(mReadOnlyPalette);
host_name_entry->setPalette(mReadOnlyPalette);
port_entry->setPalette(mReadOnlyPalette);
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
notificationArea->show();
notificationAreaIconLabelWarning->hide();
notificationAreaIconLabelError->hide();
notificationAreaIconLabelInformation->show();
notificationAreaMessageBox->show();
Improve profile "currently connected" connection message (#2408)
2019-03-11 20:37:12 +01:00
notificationAreaMessageBox->setText(profileLoadedMessage);
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
} else {
profile_name_entry->setReadOnly(false);
host_name_entry->setReadOnly(false);
port_entry->setReadOnly(false);
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
profile_name_entry->setFocusPolicy(Qt::StrongFocus);
host_name_entry->setFocusPolicy(Qt::StrongFocus);
port_entry->setFocusPolicy(Qt::StrongFocus);
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
profile_name_entry->setPalette(mRegularPalette);
host_name_entry->setPalette(mRegularPalette);
port_entry->setPalette(mRegularPalette);
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
Improve profile "currently connected" connection message (#2408)
2019-03-11 20:37:12 +01:00
if (notificationAreaMessageBox->text() == profileLoadedMessage) {
Enhance: remove minuscule text from under profile icons (#4712) This finally enables us to do away with the text under the profile icons as it replicates the normal `QListWidget` behaviour to move the selection to each item which begins with the first letter of the key pressed. This also makes the non-matching profiles get disabled which I think makes the action more obvious... Revised to include a timeout on concatenating keypresses: This is to provide the same functionality that the QListWidget does for keypresses, if the keys are typed fast enough they are concatenated to form the text to search for. However if the user types slower than this then the individual keys are only considered on their own. This reflects what both Vadim and I experienced - in that he was typing fast enough to spell out a particular profile but I wasn't and so the profile that I was having selected was changing on each keypress. The time between keypresses allowed so that they can be concatenated I have set to be 1 second. This is significantly slower that the Qt code but it is long enough to permit the temporary disablement of non-matching profiles to be a useful visual feedback - and besides, it makes it easier to specify one of a number of profiles with a common initial text - the longer the timeout the more keys the user can string together! Add `std::chrono` so we can give a time delay as `1s` instead of `1000` mS. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2021-02-03 19:59:35 +00:00
clearNotificationArea();
misc
2010-03-15 09:37:16 +01:00
}
Fix: prevent deletion of loaded profile (#7436) #### Brief overview of PR changes/additions Using the same code execution that puts up the warning about a profile being used not being editable (in some ways) to also disable the "Remove" button. #### Motivation for adding to Mudlet It has already been proven to break things! #### Other info (issues closed, discussion etc) This should close #2225 - and give me a $20 bounty! This was originally built on top of #7428 - but it was rebased onto `development` - and neither PR is affected by the other one. --------- Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2024-10-07 20:09:51 +01:00
remove_profile_button->setEnabled(true);
remove_profile_button->setToolTip(QString());
start
2009-01-24 02:50:22 +01:00
}
}
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
// (re-)creates the dialogs profile list
Enhance: add option to reveal password temporarily on demand (#3040) This is an edited summary for a collection of 5 commits: * Enhance: add option to reveal password temporarily on demand This will show the password when the eye icon is clicked on until a different profile is selected or it is clicked a second time. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Also rename the icon used when the password is hidden as it is a modified version (of an oxygen theme one) so it is not wise to use the original name. Refactored to remove an unneeded new slot that can be done without; by restructuring things I did not need to have a second slot just to hide the password when the user changed selected profile - it was needed when a Timer was used to automatically hide the password but in its absence a direct call to the other new slot and a fixed argument - is sufficient. Revised to switch to using icons from theme for show/hide password And provide some `.png` icons if they are not in the current desktop theme (on Linux/FreeBSD) or the OS does not provide such a system for them... These icons were created by myself and I will licensing them under GPL 2.0 (or later terms). Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2019-09-20 22:47:20 +01:00
void dlgConnectionProfiles::fillout_form()
{
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
listWidget_profiles->clear();
merge with experimental secureProfiles branch
2009-01-27 12:46:34 +01:00
profile_name_entry->clear();
host_name_entry->clear();
port_entry->clear();
misc
2010-03-15 09:37:16 +01:00
Infrastructure: add `enums.h` (#7646) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Add `enums.h` where we can add enums and flags to be used throughout the application that don't have a more specific place to be, without dragging in giant classes such as mudlet.h or Host.h. Also added `enums::PackageModuleType` to track the magic numbers used throughout package/module code :rocket: #### Motivation for adding to Mudlet Simplify code organisation. #### Other info (issues closed, discussion etc) --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-01-08 10:04:50 +01:00
mProfileList = QDir(mudlet::getMudletPath(enums::profilesPath)).entryList(QDir::Dirs | QDir::NoDotAndDotDot, QDir::Name);
add: Show tutorial invitation on first launch (#9169) #### Brief overview of PR changes/additions - On first launch (no existing profiles), show a focused tutorial invitation instead of the full games list - "Start Tutorial" link launches the Mudlet Tutorial profile directly - "Skip - show me the games list" button reveals the full connection dialog with the tutorial profile preselected - Make the Connect button the dialog's explicit default so Enter in the connection form always means "Connect" (see below) #### Motivation for adding to Mudlet New users currently face a wall of 20+ unknown game names with no guidance - a focused tutorial invitation improves first-time retention by teaching basics before choosing a game. #### Other info (issues closed, discussion etc) https://github.com/user-attachments/assets/2eeb3cb9-f596-4744-b187-24e1fc785246 --- Squash-merge trailers: ``` Assisted-by: Claude:claude-fable-5 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org> ``` --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com> Co-authored-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-18 10:54:52 +02:00
// mProfileList gains non-disk entries (e.g. the QT_DEBUG-only self-test
// profile) further down, so capture whether the user has any saved
// profiles while it still only holds the on-disk ones:
const bool noSavedProfiles = mProfileList.isEmpty();
misc
2010-03-15 09:37:16 +01:00
add: Show tutorial invitation on first launch (#9169) #### Brief overview of PR changes/additions - On first launch (no existing profiles), show a focused tutorial invitation instead of the full games list - "Start Tutorial" link launches the Mudlet Tutorial profile directly - "Skip - show me the games list" button reveals the full connection dialog with the tutorial profile preselected - Make the Connect button the dialog's explicit default so Enter in the connection form always means "Connect" (see below) #### Motivation for adding to Mudlet New users currently face a wall of 20+ unknown game names with no guidance - a focused tutorial invitation improves first-time retention by teaching basics before choosing a game. #### Other info (issues closed, discussion etc) https://github.com/user-attachments/assets/2eeb3cb9-f596-4744-b187-24e1fc785246 --- Squash-merge trailers: ``` Assisted-by: Claude:claude-fable-5 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org> ``` --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com> Co-authored-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-18 10:54:52 +02:00
if (noSavedProfiles) {
fix: show connection details when picking a game on a fresh install (#9451) #### Brief overview of PR changes/additions - Selecting a game on a first-ever launch now swaps the welcome message for the connection details and restores the dialog height - Programmatic selections (startup pre-selection, password-migration refreshes) still show the welcome message - Copying a pre-configured game now rebuilds the list and selects the copy with its details filled in #### Motivation for adding to Mudlet On a fresh install, clicking a game filled hidden fields and appeared to do nothing - a dead end for the very first thing a new user does. #### Other info (issues closed, discussion etc) Closes #3930 **Test case:** Fresh install (empty config dir) → connection dialog shows the welcome message → click any game → connection details appear filled in. Copy a pre-configured game → the copy appears in the list, selected, with editable details. https://github.com/user-attachments/assets/de6df8fa-e1f0-4564-91e8-c286bebdd791 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-22 05:02:00 +02:00
// remember the height so revealConnectionDetails() can undo the
// shrink below, but not when the welcome message is already up as the
// dialog is then already shrunken
if (!mDialogHeightBeforeShrink || welcome_message->isHidden()) {
mDialogHeightBeforeShrink = height();
}
improve: make the New profile button show what it did (#9607) #### Brief overview of PR changes/additions - Clicking New now shows the new profile at the top of the list with an icon, selected and scrolled into view - The profile selection window no longer grows a little every time it switches views - Skipping the tutorial invitation no longer triggers a needless window resize #### Motivation for adding to Mudlet New users clicking New saw the window resize and nothing else happen, leaving them unable to add a game manually. #### Other info (issues closed, discussion etc) Assisted-by: Claude:claude-fable-5 **Test case:** Open the profile selector, click New - a highlighted "new profile name" entry appears at the top with the name field focused, and the window size does not change. #### Demo https://github.com/user-attachments/assets/5789738a-52fb-492d-89d4-b68cb0f36aff
2026-08-03 14:10:57 +02:00
// hide before show: with both visible for a moment the layout grows
// the dialog to fit them together and it never shrinks back
Improve: give a simpler connection dialog a go (tabbed) (#5883)
2022-04-29 22:31:25 +02:00
tabWidget_connectionInfo->hide();
add get/setProfileInformation() to modify profile information field (#7511) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions 1. Add `getProfileInformation()` and `setProfileInformation(string)` functions to Lua to read/write to the profile information displayed on the profile connection window. 2. Changed profile connection window text from "Informational" to "Information" to match functions and read clearer. 3. Fix bug where one could not modify default games information text. Now load user information first if present, fallback to default. Clearing user set information (ie. `setProfileInformation("")`) also reverts to default game information. #### Motivation for adding to Mudlet Gives the ability to add profile specific information via the Lua API which can then be seen on the profile connection window. #### Other info (issues closed, discussion etc) closes #5333
2024-11-03 20:40:23 +04:00
informationArea->hide();
improve: make the New profile button show what it did (#9607) #### Brief overview of PR changes/additions - Clicking New now shows the new profile at the top of the list with an icon, selected and scrolled into view - The profile selection window no longer grows a little every time it switches views - Skipping the tutorial invitation no longer triggers a needless window resize #### Motivation for adding to Mudlet New users clicking New saw the window resize and nothing else happen, leaving them unable to add a game manually. #### Other info (issues closed, discussion etc) Assisted-by: Claude:claude-fable-5 **Test case:** Open the profile selector, click New - a highlighted "new profile name" entry appears at the top with the name field focused, and the window size does not change. #### Demo https://github.com/user-attachments/assets/5789738a-52fb-492d-89d4-b68cb0f36aff
2026-08-03 14:10:57 +02:00
welcome_message->show();
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
} else {
start
2009-01-24 02:50:22 +01:00
welcome_message->hide();
misc
2010-03-15 09:37:16 +01:00
Improve: give a simpler connection dialog a go (tabbed) (#5883)
2022-04-29 22:31:25 +02:00
tabWidget_connectionInfo->show();
add get/setProfileInformation() to modify profile information field (#7511) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions 1. Add `getProfileInformation()` and `setProfileInformation(string)` functions to Lua to read/write to the profile information displayed on the profile connection window. 2. Changed profile connection window text from "Informational" to "Information" to match functions and read clearer. 3. Fix bug where one could not modify default games information text. Now load user information first if present, fallback to default. Clearing user set information (ie. `setProfileInformation("")`) also reverts to default game information. #### Motivation for adding to Mudlet Gives the ability to add profile specific information via the Lua API which can then be seen on the profile connection window. #### Other info (issues closed, discussion etc) closes #5333
2024-11-03 20:40:23 +04:00
informationArea->show();
start
2009-01-24 02:50:22 +01:00
}
misc
2010-03-15 09:37:16 +01:00
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
listWidget_profiles->setIconSize(QSize(120, 30));
Fix `--profile` to load connection info for first-time profiles (2/2) (#5381)
2021-08-21 15:44:37 +02:00
QString description;
Refactor: remove minute visible name from Connection dialogue icons We have been trying to hide the text associated with the `QListWidgetItems` in the connection dialogue by setting the font size to the minimum of `1` and by setting it's colour to be white. This is not effective when the background is not white - which is likely for a "Dark" desktop environment. The only way to successfully hide the text is, I think, to not have any! However the text was being used programmatically, so the best way to use a `QListWidget` in this mannar is to store the text elsewhere in each item's structure. Fortunately Qt provides for this with the user data functionality which allows multiple data items (based on the `QVariant` class) to be stored within each `QListWidgetItem` using an integer key to denote the type of the data. Ironically the text, icon and other details for each item are ALSO stored in this way - however for non-Qt internal use the lowest integer key that is to be used is `Qt::UserRole` - which I have assigned to the `(const int) dlgConnectionProfiles::csmNameRole` static value. It is quite possible that a redesign of the Connect Profiles dialogue may use this system to store/cache more details about each profile in the future! The only issue with this is the lack of a: `QListWidget::findData(const QVarient&data, int role = Qt::UserRole ...)` method (c.f. `QComboBox::findData(...)`) so I have had to provide a: `(QList<QListWidgetItem*>) findData(const QListWidget&, const QVariant&, const int role = Qt::UserRole) const; method to fill in this gap and to replace the previous `QListWidget::find(...)` that examined each item's text. Also removed local `(QString) profile` from: `(void) dlgConnectionProfiles::slot_item_clicked(QListWidgetItem*)` as it is merely a redundent duplicate of another local `(QString) profile_name`. Renamed local `(QListWidgetItem*) pM` from: `(void) dlgConnectionProfiles::fillout_form()` to: `(QListWidgetItem*) pItem` as that reflects the name used throughout the rest of the class for this type of variable. Changed a `(QLabel*)::setText(tr(""))` call to the more explicit and less stupid `(QLabel*)::clear()`. Similarly changed a `(QWidget*)::setToolTip("")` to a `(QWidget*)::setToolTip(QString())`. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2020-07-01 20:59:42 +01:00
QListWidgetItem* pItem;
misc
2011-06-16 09:49:34 +02:00
Add: command line option to only show one (or more) predefined MUD(s) (#6459) The new option is -o/--only profileName. If it is one of the "Predefined" ones it means that all other Predefined profiles do not get shown whenever the "Connect Profile" dialogue is shown in that session. It may be given more than once to show more than one predefined MUD. Whilst the setting is active for that session it is also not possible for the user to "hide" the Predefined Mud in the dialogue - it will just not bring up the profile deletion confirmation dialogue and silently not do anything. Also: * make -p also work alongside --profile * ALL of the help text is now passed through the translation system. Previously only some of the text was so processed. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2023-01-05 20:26:51 +00:00
const QStringList& onlyShownPredefinedProfiles{mudlet::self()->mOnlyShownPredefinedProfiles};
improve: split the games list into My games and All games tabs (#9452) #### Brief overview of PR changes/additions - Tab bar above the connection dialog's games list: "My games" (profiles on disk) and "All games" (full catalog), replacing the right-click "Show my profiles only" stop-gap - Opens on My games when profiles exist, All games on a fresh install; last-used tab and the retired filter's setting are honoured; selection preserved across tab switches - Dedicated single-game builds hide the tab bar and keep their current look #### Motivation for adding to Mudlet One flat grid of ~35 games overwhelmed newcomers and buried the profiles a player actually uses. #### Other info (issues closed, discussion etc) Closes #9140 **Test case:** Fresh install → dialog opens on All games with the tab bar visible. Create a profile, restart → opens on My games showing only that profile, selected with details filled. Switch tabs → selection follows where possible; right-click menu no longer offers "Show my profiles only". https://github.com/user-attachments/assets/50b07d6e-7908-4d25-8b4c-4c6e1396aaea --------- Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-29 17:14:14 +02:00
const bool showOnlyMyProfiles = showingOnlyMyProfiles();
fix: removing a game's profile no longer hides it from the All Games list (#9608) #### Brief overview of PR changes/additions - Deleting a profile of a pre-installed game now only removes the profile - the game stays available in All Games - Games hidden by this bug in the past reappear automatically - Adds DefaultGameDeleteTest covering both cases #### Motivation for adding to Mudlet Removing a game from My Games unexpectedly removed it from the All Games catalog permanently. #### Other info (issues closed, discussion etc) Assisted-by: Claude:claude-fable-5 Assisted-by: Claude:claude-opus-5 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org> **Test case:** Play a game from All Games, close and reopen Mudlet, remove it from My Games - it still appears under All Games. #### Demo https://github.com/user-attachments/assets/6df6f2bd-d0d4-446f-80de-8c4c190dbf45
2026-08-04 12:00:37 +02:00
const QString selfTestProfile = qsl("Mudlet self-test");
const auto deletedDefaultMuds = mudlet::self()->mpSettings->value(qsl("deletedDefaultMuds"), QStringList()).toStringList();
Add: command line option to only show one (or more) predefined MUD(s) (#6459) The new option is -o/--only profileName. If it is one of the "Predefined" ones it means that all other Predefined profiles do not get shown whenever the "Connect Profile" dialogue is shown in that session. It may be given more than once to show more than one predefined MUD. Whilst the setting is active for that session it is also not possible for the user to "hide" the Predefined Mud in the dialogue - it will just not bring up the profile deletion confirmation dialogue and silently not do anything. Also: * make -p also work alongside --profile * ALL of the help text is now passed through the translation system. Previously only some of the text was so processed. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2023-01-05 20:26:51 +00:00
if (onlyShownPredefinedProfiles.isEmpty()) {
const auto defaultGames = TGameDetails::keys();
fix: removing a game's profile no longer hides it from the All Games list (#9608) #### Brief overview of PR changes/additions - Deleting a profile of a pre-installed game now only removes the profile - the game stays available in All Games - Games hidden by this bug in the past reappear automatically - Adds DefaultGameDeleteTest covering both cases #### Motivation for adding to Mudlet Removing a game from My Games unexpectedly removed it from the All Games catalog permanently. #### Other info (issues closed, discussion etc) Assisted-by: Claude:claude-fable-5 Assisted-by: Claude:claude-opus-5 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org> **Test case:** Play a game from All Games, close and reopen Mudlet, remove it from My Games - it still appears under All Games. #### Demo https://github.com/user-attachments/assets/6df6f2bd-d0d4-446f-80de-8c4c190dbf45
2026-08-04 12:00:37 +02:00
// "My games" only lists games with profile data on disk; "All games"
// must keep offering every pre-installed game, even ones whose
// profile was deleted (recorded in deletedDefaultMuds). The self-test
// entry is the exception: it is a testing aid rather than a game, and
// is offered even without profile data on disk, so dismissing it has
// to keep it out of both tabs
Add: command line option to only show one (or more) predefined MUD(s) (#6459) The new option is -o/--only profileName. If it is one of the "Predefined" ones it means that all other Predefined profiles do not get shown whenever the "Connect Profile" dialogue is shown in that session. It may be given more than once to show more than one predefined MUD. Whilst the setting is active for that session it is also not possible for the user to "hide" the Predefined Mud in the dialogue - it will just not bring up the profile deletion confirmation dialogue and silently not do anything. Also: * make -p also work alongside --profile * ALL of the help text is now passed through the translation system. Previously only some of the text was so processed. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2023-01-05 20:26:51 +00:00
for (auto& game : defaultGames) {
fix: removing a game's profile no longer hides it from the All Games list (#9608) #### Brief overview of PR changes/additions - Deleting a profile of a pre-installed game now only removes the profile - the game stays available in All Games - Games hidden by this bug in the past reappear automatically - Adds DefaultGameDeleteTest covering both cases #### Motivation for adding to Mudlet Removing a game from My Games unexpectedly removed it from the All Games catalog permanently. #### Other info (issues closed, discussion etc) Assisted-by: Claude:claude-fable-5 Assisted-by: Claude:claude-opus-5 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org> **Test case:** Play a game from All Games, close and reopen Mudlet, remove it from My Games - it still appears under All Games. #### Demo https://github.com/user-attachments/assets/6df6f2bd-d0d4-446f-80de-8c4c190dbf45
2026-08-04 12:00:37 +02:00
if (game == selfTestProfile && deletedDefaultMuds.contains(game)) {
continue;
}
if (showOnlyMyProfiles && !mProfileList.contains(game, Qt::CaseInsensitive)) {
continue;
Add: command line option to only show one (or more) predefined MUD(s) (#6459) The new option is -o/--only profileName. If it is one of the "Predefined" ones it means that all other Predefined profiles do not get shown whenever the "Connect Profile" dialogue is shown in that session. It may be given more than once to show more than one predefined MUD. Whilst the setting is active for that session it is also not possible for the user to "hide" the Predefined Mud in the dialogue - it will just not bring up the profile deletion confirmation dialogue and silently not do anything. Also: * make -p also work alongside --profile * ALL of the help text is now passed through the translation system. Previously only some of the text was so processed. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2023-01-05 20:26:51 +00:00
}
fix: removing a game's profile no longer hides it from the All Games list (#9608) #### Brief overview of PR changes/additions - Deleting a profile of a pre-installed game now only removes the profile - the game stays available in All Games - Games hidden by this bug in the past reappear automatically - Adds DefaultGameDeleteTest covering both cases #### Motivation for adding to Mudlet Removing a game from My Games unexpectedly removed it from the All Games catalog permanently. #### Other info (issues closed, discussion etc) Assisted-by: Claude:claude-fable-5 Assisted-by: Claude:claude-opus-5 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org> **Test case:** Play a game from All Games, close and reopen Mudlet, remove it from My Games - it still appears under All Games. #### Demo https://github.com/user-attachments/assets/6df6f2bd-d0d4-446f-80de-8c4c190dbf45
2026-08-04 12:00:37 +02:00
pItem = new QListWidgetItem();
auto details = TGameDetails::findGame(game);
setupMudProfile(pItem, game, (*details).description, (*details).icon);
Fix `--profile` to load connection info for first-time profiles (2/2) (#5381)
2021-08-21 15:44:37 +02:00
}
Add Legends of the Jedi connection option (#5306)
2021-07-05 23:31:53 -07:00
Remove self-test profile from release build (#2704)
2019-07-03 05:15:12 +02:00
#if defined(QT_DEBUG)
fix: removing a game's profile no longer hides it from the All Games list (#9608) #### Brief overview of PR changes/additions - Deleting a profile of a pre-installed game now only removes the profile - the game stays available in All Games - Games hidden by this bug in the past reappear automatically - Adds DefaultGameDeleteTest covering both cases #### Motivation for adding to Mudlet Removing a game from My Games unexpectedly removed it from the All Games catalog permanently. #### Other info (issues closed, discussion etc) Assisted-by: Claude:claude-fable-5 Assisted-by: Claude:claude-opus-5 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org> **Test case:** Play a game from All Games, close and reopen Mudlet, remove it from My Games - it still appears under All Games. #### Demo https://github.com/user-attachments/assets/6df6f2bd-d0d4-446f-80de-8c4c190dbf45
2026-08-04 12:00:37 +02:00
if (!deletedDefaultMuds.contains(selfTestProfile) && !mProfileList.contains(selfTestProfile)) {
mProfileList.append(selfTestProfile);
// "All games" already listed it from TGameDetails above, only
// "My games" is still missing an entry:
if (findData(*listWidget_profiles, selfTestProfile, csmNameRole).isEmpty()) {
pItem = new QListWidgetItem();
// Can't use setupMudProfile(...) here as we do not set the icon in the same way:
setItemName(pItem, selfTestProfile);
Revise: try and identify profiles and some controls in connection dialog (#3966) Also convert all `setDisabled(state)` to `setEnabled(!state)` in the `dlgConnectionProfiles` class - using a single one instead of a mix of the two is less likely to lead to errors - and it means less effort to search for the places where something is being enabled or disabled. Shorten some overlong variable names. Remove some capitalisations. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2020-08-13 00:57:17 +01:00
fix: removing a game's profile no longer hides it from the All Games list (#9608) #### Brief overview of PR changes/additions - Deleting a profile of a pre-installed game now only removes the profile - the game stays available in All Games - Games hidden by this bug in the past reappear automatically - Adds DefaultGameDeleteTest covering both cases #### Motivation for adding to Mudlet Removing a game from My Games unexpectedly removed it from the All Games catalog permanently. #### Other info (issues closed, discussion etc) Assisted-by: Claude:claude-fable-5 Assisted-by: Claude:claude-opus-5 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org> **Test case:** Play a game from All Games, close and reopen Mudlet, remove it from My Games - it still appears under All Games. #### Demo https://github.com/user-attachments/assets/6df6f2bd-d0d4-446f-80de-8c4c190dbf45
2026-08-04 12:00:37 +02:00
listWidget_profiles->addItem(pItem);
description = getDescription(qsl("mudlet.org"));
if (!description.isEmpty()) {
pItem->setToolTip(utils::richText(description));
}
Add: command line option to only show one (or more) predefined MUD(s) (#6459) The new option is -o/--only profileName. If it is one of the "Predefined" ones it means that all other Predefined profiles do not get shown whenever the "Connect Profile" dialogue is shown in that session. It may be given more than once to show more than one predefined MUD. Whilst the setting is active for that session it is also not possible for the user to "hide" the Predefined Mud in the dialogue - it will just not bring up the profile deletion confirmation dialogue and silently not do anything. Also: * make -p also work alongside --profile * ALL of the help text is now passed through the translation system. Previously only some of the text was so processed. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2023-01-05 20:26:51 +00:00
}
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
}
New feature: Set custom icons in profiles list (#2814)
2019-07-25 16:59:16 +02:00
#endif
Add: command line option to only show one (or more) predefined MUD(s) (#6459) The new option is -o/--only profileName. If it is one of the "Predefined" ones it means that all other Predefined profiles do not get shown whenever the "Connect Profile" dialogue is shown in that session. It may be given more than once to show more than one predefined MUD. Whilst the setting is active for that session it is also not possible for the user to "hide" the Predefined Mud in the dialogue - it will just not bring up the profile deletion confirmation dialogue and silently not do anything. Also: * make -p also work alongside --profile * ALL of the help text is now passed through the translation system. Previously only some of the text was so processed. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2023-01-05 20:26:51 +00:00
} else {
for (const QString& onlyShownPredefinedProfile : onlyShownPredefinedProfiles) {
Fix: 1440 byte leak fix in connection profiles (#8318) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Fix: 1440 byte leak fix in connection profiles #### Motivation for adding to Mudlet Don't leak memory, not even a little bit #### Other info (issues closed, discussion etc)
2025-10-12 10:20:24 +02:00
pItem = new QListWidgetItem();
Add: command line option to only show one (or more) predefined MUD(s) (#6459) The new option is -o/--only profileName. If it is one of the "Predefined" ones it means that all other Predefined profiles do not get shown whenever the "Connect Profile" dialogue is shown in that session. It may be given more than once to show more than one predefined MUD. Whilst the setting is active for that session it is also not possible for the user to "hide" the Predefined Mud in the dialogue - it will just not bring up the profile deletion confirmation dialogue and silently not do anything. Also: * make -p also work alongside --profile * ALL of the help text is now passed through the translation system. Previously only some of the text was so processed. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2023-01-05 20:26:51 +00:00
auto details = TGameDetails::findGame(onlyShownPredefinedProfile);
setupMudProfile(pItem, onlyShownPredefinedProfile, (*details).description, (*details).icon);
}
}
New feature: Set custom icons in profiles list (#2814)
2019-07-25 16:59:16 +02:00
Refactor: remove minute visible name from Connection dialogue icons We have been trying to hide the text associated with the `QListWidgetItems` in the connection dialogue by setting the font size to the minimum of `1` and by setting it's colour to be white. This is not effective when the background is not white - which is likely for a "Dark" desktop environment. The only way to successfully hide the text is, I think, to not have any! However the text was being used programmatically, so the best way to use a `QListWidget` in this mannar is to store the text elsewhere in each item's structure. Fortunately Qt provides for this with the user data functionality which allows multiple data items (based on the `QVariant` class) to be stored within each `QListWidgetItem` using an integer key to denote the type of the data. Ironically the text, icon and other details for each item are ALSO stored in this way - however for non-Qt internal use the lowest integer key that is to be used is `Qt::UserRole` - which I have assigned to the `(const int) dlgConnectionProfiles::csmNameRole` static value. It is quite possible that a redesign of the Connect Profiles dialogue may use this system to store/cache more details about each profile in the future! The only issue with this is the lack of a: `QListWidget::findData(const QVarient&data, int role = Qt::UserRole ...)` method (c.f. `QComboBox::findData(...)`) so I have had to provide a: `(QList<QListWidgetItem*>) findData(const QListWidget&, const QVariant&, const int role = Qt::UserRole) const; method to fill in this gap and to replace the previous `QListWidget::find(...)` that examined each item's text. Also removed local `(QString) profile` from: `(void) dlgConnectionProfiles::slot_item_clicked(QListWidgetItem*)` as it is merely a redundent duplicate of another local `(QString) profile_name`. Renamed local `(QListWidgetItem*) pM` from: `(void) dlgConnectionProfiles::fillout_form()` to: `(QListWidgetItem*) pItem` as that reflects the name used throughout the rest of the class for this type of variable. Changed a `(QLabel*)::setText(tr(""))` call to the more explicit and less stupid `(QLabel*)::clear()`. Similarly changed a `(QWidget*)::setToolTip("")` to a `(QWidget*)::setToolTip(QString())`. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2020-07-01 20:59:42 +01:00
setProfileIcon();
Improve first-time user experience (#1016) * Fixed the welcome message to show again It didn't before because default_host profile directory was getting created on the disk before the check. * Made it so a random profile gets selected for a first-time launch * Modernized mudlet::startAutoLogin function * Renamed poorly-named method to open connections dialog It also was confusing with Host::connectToServer doing the actual connecting * Made the connection dialog open if no profiles are on autoload * Removed superseded status bar notification The connection dialog now opens automatically. * Improved first-launch Mudlet size and positioning Mudlet is now centered and has a decent size for the most common resolutions * Fix connection dialog to get a decent size by default * Updated the welcome text It was pretty ancient and referenced outdated button names. Also cut down on the wording so a new user isn't hit with a wall of text. * Moved icon over to left so the screen isn't so busy * Undid hardcoded fonts and sizes in connection dialog User-selected desktop fonts and sizes should be used instead. * Fixed connection dialog to actually select the last played profile There was a bug where it would ignore predefined profiles in the calculation. Also use the last modified, not read date - a lot of things like virus scanners could read the directory whereas far fewer things will write to it. * Moved 'loaded profile' warning to be below profiles This prevents the whole thing from jumping around. * Added a margin to the right for aesthetic reasons * Revised to use getDescription as a method * Got tooltips to show on profile icons
2017-06-04 08:13:51 +02:00
QDateTime test_date;
QString toselectProfileName;
int toselectRow = -1;
Enable Busted tests inside Mudlet (#2617) * Run busted tests in mudlet, added test_profile. - This adds the ability to run tests written for the Busted test framework, which was written by Olivine Labs. More info at https://olivinelabs.com/busted/ - It adds a new test_profile, which loads the new run-tests.xml package. - It changes the build to install the tests in a platform dependent directory next to the geyser directory. - It adds a simple starter test, named MudletBusted_spec.lua * Ran the formatter. * Changed comparison string for clarity. * Changed wording & domain, fixed duplication bug. * Better comment in src/run-tests.xml Co-Authored-By: Vadim Peretokin <vperetokin@gmail.com> * Added message if busted package not found. * Add 'make install' for cmake files
2019-06-16 18:52:22 -06:00
int test_profile_row = -1;
Add: command line option to only show one (or more) predefined MUD(s) (#6459) The new option is -o/--only profileName. If it is one of the "Predefined" ones it means that all other Predefined profiles do not get shown whenever the "Connect Profile" dialogue is shown in that session. It may be given more than once to show more than one predefined MUD. Whilst the setting is active for that session it is also not possible for the user to "hide" the Predefined Mud in the dialogue - it will just not bring up the profile deletion confirmation dialogue and silently not do anything. Also: * make -p also work alongside --profile * ALL of the help text is now passed through the translation system. Previously only some of the text was so processed. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2023-01-05 20:26:51 +00:00
int predefined_profile_row = -1;
Remove "default_host" profile (#2950)
2019-08-15 18:43:39 +02:00
bool firstMudletLaunch = true;
Improve first-time user experience (#1016) * Fixed the welcome message to show again It didn't before because default_host profile directory was getting created on the disk before the check. * Made it so a random profile gets selected for a first-time launch * Modernized mudlet::startAutoLogin function * Renamed poorly-named method to open connections dialog It also was confusing with Host::connectToServer doing the actual connecting * Made the connection dialog open if no profiles are on autoload * Removed superseded status bar notification The connection dialog now opens automatically. * Improved first-launch Mudlet size and positioning Mudlet is now centered and has a decent size for the most common resolutions * Fix connection dialog to get a decent size by default * Updated the welcome text It was pretty ancient and referenced outdated button names. Also cut down on the wording so a new user isn't hit with a wall of text. * Moved icon over to left so the screen isn't so busy * Undid hardcoded fonts and sizes in connection dialog User-selected desktop fonts and sizes should be used instead. * Fixed connection dialog to actually select the last played profile There was a bug where it would ignore predefined profiles in the calculation. Also use the last modified, not read date - a lot of things like virus scanners could read the directory whereas far fewer things will write to it. * Moved 'loaded profile' warning to be below profiles This prevents the whole thing from jumping around. * Added a margin to the right for aesthetic reasons * Revised to use getDescription as a method * Got tooltips to show on profile icons
2017-06-04 08:13:51 +02:00
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
for (int i = 0; i < listWidget_profiles->count(); i++) {
const auto profile = listWidget_profiles->item(i);
Revise: try and identify profiles and some controls in connection dialog (#3966) Also convert all `setDisabled(state)` to `setEnabled(!state)` in the `dlgConnectionProfiles` class - using a single one instead of a mix of the two is less likely to lead to errors - and it means less effort to search for the places where something is being enabled or disabled. Shorten some overlong variable names. Remove some capitalisations. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2020-08-13 00:57:17 +01:00
const auto profileName = profile->data(csmNameRole).toString();
Infrastructure: Add short qsl macro to stand in for 'QStringLiteral' (#5640)
2021-12-07 06:21:39 +01:00
if (profileName == qsl("Mudlet self-test")) {
Enable Busted tests inside Mudlet (#2617) * Run busted tests in mudlet, added test_profile. - This adds the ability to run tests written for the Busted test framework, which was written by Olivine Labs. More info at https://olivinelabs.com/busted/ - It adds a new test_profile, which loads the new run-tests.xml package. - It changes the build to install the tests in a platform dependent directory next to the geyser directory. - It adds a simple starter test, named MudletBusted_spec.lua * Ran the formatter. * Changed comparison string for clarity. * Changed wording & domain, fixed duplication bug. * Better comment in src/run-tests.xml Co-Authored-By: Vadim Peretokin <vperetokin@gmail.com> * Added message if busted package not found. * Add 'make install' for cmake files
2019-06-16 18:52:22 -06:00
test_profile_row = i;
}
Infrastructure: add `enums.h` (#7646) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Add `enums.h` where we can add enums and flags to be used throughout the application that don't have a more specific place to be, without dragging in giant classes such as mudlet.h or Host.h. Also added `enums::PackageModuleType` to track the magic numbers used throughout package/module code :rocket: #### Motivation for adding to Mudlet Simplify code organisation. #### Other info (issues closed, discussion etc) --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-01-08 10:04:50 +01:00
const auto fileinfo = QFileInfo(mudlet::getMudletPath(enums::profileXmlFilesPath, profileName));
Remove "default_host" profile (#2950)
2019-08-15 18:43:39 +02:00
if (fileinfo.exists()) {
firstMudletLaunch = false;
Infrastructure: reposition const before type specifier (#7179) #### Brief overview of PR changes/additions This PR tries to put all `const`s before the type (class). #### Motivation for adding to Mudlet There is a mix of positioning of `const`s where it is used to indicate that a variable is not to be modified by program code, we tend to put it before the type but a prior PR (which looks to have been done with an automated tool) has resulted in a mix of cases some with the const adjacent to the variable. This lack of consistency can be confusing. #### Other info (issues closed, discussion etc) It looks like this came about in #6843. This will upset the Danger detector because of the number of files modified but it should be fairly straightforward to review. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2024-03-11 15:40:56 +00:00
const QDateTime profile_lastRead = fileinfo.lastModified();
Remove "default_host" profile (#2950)
2019-08-15 18:43:39 +02:00
// Since Qt 5.x null QTimes and QDateTimes are invalid - and might not
// work as expected - so test for validity of the test_date value as well
if ((!test_date.isValid()) || profile_lastRead > test_date) {
test_date = profile_lastRead;
toselectProfileName = profileName;
toselectRow = i;
}
Improve first-time user experience (#1016) * Fixed the welcome message to show again It didn't before because default_host profile directory was getting created on the disk before the check. * Made it so a random profile gets selected for a first-time launch * Modernized mudlet::startAutoLogin function * Renamed poorly-named method to open connections dialog It also was confusing with Host::connectToServer doing the actual connecting * Made the connection dialog open if no profiles are on autoload * Removed superseded status bar notification The connection dialog now opens automatically. * Improved first-launch Mudlet size and positioning Mudlet is now centered and has a decent size for the most common resolutions * Fix connection dialog to get a decent size by default * Updated the welcome text It was pretty ancient and referenced outdated button names. Also cut down on the wording so a new user isn't hit with a wall of text. * Moved icon over to left so the screen isn't so busy * Undid hardcoded fonts and sizes in connection dialog User-selected desktop fonts and sizes should be used instead. * Fixed connection dialog to actually select the last played profile There was a bug where it would ignore predefined profiles in the calculation. Also use the last modified, not read date - a lot of things like virus scanners could read the directory whereas far fewer things will write to it. * Moved 'loaded profile' warning to be below profiles This prevents the whole thing from jumping around. * Added a margin to the right for aesthetic reasons * Revised to use getDescription as a method * Got tooltips to show on profile icons
2017-06-04 08:13:51 +02:00
}
Add: command line option to only show one (or more) predefined MUD(s) (#6459) The new option is -o/--only profileName. If it is one of the "Predefined" ones it means that all other Predefined profiles do not get shown whenever the "Connect Profile" dialogue is shown in that session. It may be given more than once to show more than one predefined MUD. Whilst the setting is active for that session it is also not possible for the user to "hide" the Predefined Mud in the dialogue - it will just not bring up the profile deletion confirmation dialogue and silently not do anything. Also: * make -p also work alongside --profile * ALL of the help text is now passed through the translation system. Previously only some of the text was so processed. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2023-01-05 20:26:51 +00:00
if (!onlyShownPredefinedProfiles.isEmpty() && profileName == onlyShownPredefinedProfiles.first()) {
predefined_profile_row = i;
}
Improve first-time user experience (#1016) * Fixed the welcome message to show again It didn't before because default_host profile directory was getting created on the disk before the check. * Made it so a random profile gets selected for a first-time launch * Modernized mudlet::startAutoLogin function * Renamed poorly-named method to open connections dialog It also was confusing with Host::connectToServer doing the actual connecting * Made the connection dialog open if no profiles are on autoload * Removed superseded status bar notification The connection dialog now opens automatically. * Improved first-launch Mudlet size and positioning Mudlet is now centered and has a decent size for the most common resolutions * Fix connection dialog to get a decent size by default * Updated the welcome text It was pretty ancient and referenced outdated button names. Also cut down on the wording so a new user isn't hit with a wall of text. * Moved icon over to left so the screen isn't so busy * Undid hardcoded fonts and sizes in connection dialog User-selected desktop fonts and sizes should be used instead. * Fixed connection dialog to actually select the last played profile There was a bug where it would ignore predefined profiles in the calculation. Also use the last modified, not read date - a lot of things like virus scanners could read the directory whereas far fewer things will write to it. * Moved 'loaded profile' warning to be below profiles This prevents the whole thing from jumping around. * Added a margin to the right for aesthetic reasons * Revised to use getDescription as a method * Got tooltips to show on profile icons
2017-06-04 08:13:51 +02:00
}
Remove "default_host" profile (#2950)
2019-08-15 18:43:39 +02:00
if (firstMudletLaunch) {
Add: command line option to only show one (or more) predefined MUD(s) (#6459) The new option is -o/--only profileName. If it is one of the "Predefined" ones it means that all other Predefined profiles do not get shown whenever the "Connect Profile" dialogue is shown in that session. It may be given more than once to show more than one predefined MUD. Whilst the setting is active for that session it is also not possible for the user to "hide" the Predefined Mud in the dialogue - it will just not bring up the profile deletion confirmation dialogue and silently not do anything. Also: * make -p also work alongside --profile * ALL of the help text is now passed through the translation system. Previously only some of the text was so processed. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2023-01-05 20:26:51 +00:00
if (onlyShownPredefinedProfiles.isEmpty()) {
add: Show tutorial invitation on first launch (#9169) #### Brief overview of PR changes/additions - On first launch (no existing profiles), show a focused tutorial invitation instead of the full games list - "Start Tutorial" link launches the Mudlet Tutorial profile directly - "Skip - show me the games list" button reveals the full connection dialog with the tutorial profile preselected - Make the Connect button the dialog's explicit default so Enter in the connection form always means "Connect" (see below) #### Motivation for adding to Mudlet New users currently face a wall of 20+ unknown game names with no guidance - a focused tutorial invitation improves first-time retention by teaching basics before choosing a game. #### Other info (issues closed, discussion etc) https://github.com/user-attachments/assets/2eeb3cb9-f596-4744-b187-24e1fc785246 --- Squash-merge trailers: ``` Assisted-by: Claude:claude-fable-5 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org> ``` --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com> Co-authored-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-18 10:54:52 +02:00
// Select the tutorial profile on first launch
for (int i = 0; i < listWidget_profiles->count(); i++) {
if (listWidget_profiles->item(i)->data(csmNameRole).toString() == qsl("Mudlet Tutorial")) {
toselectRow = i;
break;
Add: command line option to only show one (or more) predefined MUD(s) (#6459) The new option is -o/--only profileName. If it is one of the "Predefined" ones it means that all other Predefined profiles do not get shown whenever the "Connect Profile" dialogue is shown in that session. It may be given more than once to show more than one predefined MUD. Whilst the setting is active for that session it is also not possible for the user to "hide" the Predefined Mud in the dialogue - it will just not bring up the profile deletion confirmation dialogue and silently not do anything. Also: * make -p also work alongside --profile * ALL of the help text is now passed through the translation system. Previously only some of the text was so processed. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2023-01-05 20:26:51 +00:00
}
Enable Busted tests inside Mudlet (#2617) * Run busted tests in mudlet, added test_profile. - This adds the ability to run tests written for the Busted test framework, which was written by Olivine Labs. More info at https://olivinelabs.com/busted/ - It adds a new test_profile, which loads the new run-tests.xml package. - It changes the build to install the tests in a platform dependent directory next to the geyser directory. - It adds a simple starter test, named MudletBusted_spec.lua * Ran the formatter. * Changed comparison string for clarity. * Changed wording & domain, fixed duplication bug. * Better comment in src/run-tests.xml Co-Authored-By: Vadim Peretokin <vperetokin@gmail.com> * Added message if busted package not found. * Add 'make install' for cmake files
2019-06-16 18:52:22 -06:00
}
improve: split the games list into My games and All games tabs (#9452) #### Brief overview of PR changes/additions - Tab bar above the connection dialog's games list: "My games" (profiles on disk) and "All games" (full catalog), replacing the right-click "Show my profiles only" stop-gap - Opens on My games when profiles exist, All games on a fresh install; last-used tab and the retired filter's setting are honoured; selection preserved across tab switches - Dedicated single-game builds hide the tab bar and keep their current look #### Motivation for adding to Mudlet One flat grid of ~35 games overwhelmed newcomers and buried the profiles a player actually uses. #### Other info (issues closed, discussion etc) Closes #9140 **Test case:** Fresh install → dialog opens on All games with the tab bar visible. Create a profile, restart → opens on My games showing only that profile, selected with details filled. Switch tabs → selection follows where possible; right-click menu no longer offers "Show my profiles only". https://github.com/user-attachments/assets/50b07d6e-7908-4d25-8b4c-4c6e1396aaea --------- Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-29 17:14:14 +02:00
if (listWidget_profiles->count() == 1 && test_profile_row != 0) {
// The "My games" tab can show a single profile that has not been
// saved to its XML yet, so select it to fill in its details
// instead of leaving the form blank with a game highlighted
toselectRow = 0;
}
Add: command line option to only show one (or more) predefined MUD(s) (#6459) The new option is -o/--only profileName. If it is one of the "Predefined" ones it means that all other Predefined profiles do not get shown whenever the "Connect Profile" dialogue is shown in that session. It may be given more than once to show more than one predefined MUD. Whilst the setting is active for that session it is also not possible for the user to "hide" the Predefined Mud in the dialogue - it will just not bring up the profile deletion confirmation dialogue and silently not do anything. Also: * make -p also work alongside --profile * ALL of the help text is now passed through the translation system. Previously only some of the text was so processed. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2023-01-05 20:26:51 +00:00
} else if (predefined_profile_row >= 0) {
// If the user is starting one of a MUD's "dedicated" Mudlet versions then
// select the first of THAT/THOSE predefined one(s) on first launch:
toselectRow = predefined_profile_row;
Profiles are now sorted by name, but the last one used is selected
2009-01-30 00:22:12 -05:00
}
start
2009-01-24 02:50:22 +01:00
}
Feature: show/hide send() commands option in settings | Fix: mini console had a big black bottom line | Fix: commands were sometimes echoed multiple times
2009-07-17 17:57:31 +02:00
Corrected a divide-by-zero error (fixes #3044) (#3045) * Corrected a divide-by-zero error (fixes #3044) * Don't set row when we don't have one to select
2019-09-07 09:26:44 -04:00
if (toselectRow != -1) {
fix: show connection details when picking a game on a fresh install (#9451) #### Brief overview of PR changes/additions - Selecting a game on a first-ever launch now swaps the welcome message for the connection details and restores the dialog height - Programmatic selections (startup pre-selection, password-migration refreshes) still show the welcome message - Copying a pre-configured game now rebuilds the list and selects the copy with its details filled in #### Motivation for adding to Mudlet On a fresh install, clicking a game filled hidden fields and appeared to do nothing - a dead end for the very first thing a new user does. #### Other info (issues closed, discussion etc) Closes #3930 **Test case:** Fresh install (empty config dir) → connection dialog shows the welcome message → click any game → connection details appear filled in. Copy a pre-configured game → the copy appears in the list, selected, with editable details. https://github.com/user-attachments/assets/de6df8fa-e1f0-4564-91e8-c286bebdd791 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-22 05:02:00 +02:00
// this automatic selection must not be taken for the user picking a
// game, which would dismiss the welcome message shown above
mProgrammaticProfileSelection = true;
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
listWidget_profiles->setCurrentRow(toselectRow);
fix: show connection details when picking a game on a fresh install (#9451) #### Brief overview of PR changes/additions - Selecting a game on a first-ever launch now swaps the welcome message for the connection details and restores the dialog height - Programmatic selections (startup pre-selection, password-migration refreshes) still show the welcome message - Copying a pre-configured game now rebuilds the list and selects the copy with its details filled in #### Motivation for adding to Mudlet On a fresh install, clicking a game filled hidden fields and appeared to do nothing - a dead end for the very first thing a new user does. #### Other info (issues closed, discussion etc) Closes #3930 **Test case:** Fresh install (empty config dir) → connection dialog shows the welcome message → click any game → connection details appear filled in. Copy a pre-configured game → the copy appears in the list, selected, with editable details. https://github.com/user-attachments/assets/de6df8fa-e1f0-4564-91e8-c286bebdd791 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-22 05:02:00 +02:00
mProgrammaticProfileSelection = false;
Corrected a divide-by-zero error (fixes #3044) (#3045) * Corrected a divide-by-zero error (fixes #3044) * Don't set row when we don't have one to select
2019-09-07 09:26:44 -04:00
}
Add Discord support (#1716)
2018-10-05 06:25:57 +02:00
add: Show tutorial invitation on first launch (#9169) #### Brief overview of PR changes/additions - On first launch (no existing profiles), show a focused tutorial invitation instead of the full games list - "Start Tutorial" link launches the Mudlet Tutorial profile directly - "Skip - show me the games list" button reveals the full connection dialog with the tutorial profile preselected - Make the Connect button the dialog's explicit default so Enter in the connection form always means "Connect" (see below) #### Motivation for adding to Mudlet New users currently face a wall of 20+ unknown game names with no guidance - a focused tutorial invitation improves first-time retention by teaching basics before choosing a game. #### Other info (issues closed, discussion etc) https://github.com/user-attachments/assets/2eeb3cb9-f596-4744-b187-24e1fc785246 --- Squash-merge trailers: ``` Assisted-by: Claude:claude-fable-5 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org> ``` --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com> Co-authored-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-18 10:54:52 +02:00
// Dedicated single-game builds go straight to their game's profile instead
// of the Mudlet tutorial invitation:
if (firstMudletLaunch && noSavedProfiles && !mTutorialDismissed && onlyShownPredefinedProfiles.isEmpty()) {
// Hide the profile list and show only the tutorial-focused welcome
widget_topLeft->hide();
welcome_message->show();
tabWidget_connectionInfo->hide();
informationArea->hide();
connect_button->hide();
offline_button->hide();
mpSkipToGamesButton->show();
adjustSize();
}
start
2009-01-24 02:50:22 +01:00
}
Refactor: remove minute visible name from Connection dialogue icons We have been trying to hide the text associated with the `QListWidgetItems` in the connection dialogue by setting the font size to the minimum of `1` and by setting it's colour to be white. This is not effective when the background is not white - which is likely for a "Dark" desktop environment. The only way to successfully hide the text is, I think, to not have any! However the text was being used programmatically, so the best way to use a `QListWidget` in this mannar is to store the text elsewhere in each item's structure. Fortunately Qt provides for this with the user data functionality which allows multiple data items (based on the `QVariant` class) to be stored within each `QListWidgetItem` using an integer key to denote the type of the data. Ironically the text, icon and other details for each item are ALSO stored in this way - however for non-Qt internal use the lowest integer key that is to be used is `Qt::UserRole` - which I have assigned to the `(const int) dlgConnectionProfiles::csmNameRole` static value. It is quite possible that a redesign of the Connect Profiles dialogue may use this system to store/cache more details about each profile in the future! The only issue with this is the lack of a: `QListWidget::findData(const QVarient&data, int role = Qt::UserRole ...)` method (c.f. `QComboBox::findData(...)`) so I have had to provide a: `(QList<QListWidgetItem*>) findData(const QListWidget&, const QVariant&, const int role = Qt::UserRole) const; method to fill in this gap and to replace the previous `QListWidget::find(...)` that examined each item's text. Also removed local `(QString) profile` from: `(void) dlgConnectionProfiles::slot_item_clicked(QListWidgetItem*)` as it is merely a redundent duplicate of another local `(QString) profile_name`. Renamed local `(QListWidgetItem*) pM` from: `(void) dlgConnectionProfiles::fillout_form()` to: `(QListWidgetItem*) pItem` as that reflects the name used throughout the rest of the class for this type of variable. Changed a `(QLabel*)::setText(tr(""))` call to the more explicit and less stupid `(QLabel*)::clear()`. Similarly changed a `(QWidget*)::setToolTip("")` to a `(QWidget*)::setToolTip(QString())`. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2020-07-01 20:59:42 +01:00
void dlgConnectionProfiles::setProfileIcon() const
New feature: Set custom icons in profiles list (#2814)
2019-07-25 16:59:16 +02:00
{
Infrastructure: centralise predefined MUD game data (#6434) This moves the "description" data into the same container as all the other details for the predefined MUDS. That data is then refactored out of the `./src/mudlet.h` file into a separate smaller file that only needs to be `#include`d into two class files - so changing any details requires less to rebuild the application. This PR also removes the 3rd party dependency "qt-ordered-map" (which is 3-clause BSD licensed but NOT currently mentioned in our "About" dialogue!) Afterwards the details for each predefined MUD is held in a `QList<T>` instead - with a couple of helper methods defined to reproduce the information retrieval methods used in the prior code. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Vadim Peretokin <vperetokin@gmail.com>
2022-11-27 00:00:34 +00:00
const QStringList defaultGames = TGameDetails::keys();
Fix `--profile` to load connection info for first-time profiles (2/2) (#5381)
2021-08-21 15:44:37 +02:00
Infra: Use modern For loop syntax (#8162) #### Brief overview of PR changes/additions No functional change, just internal refactoring #### Motivation for adding to Mudlet Easier to read, clearer style #### Other info (issues closed, discussion etc)
2025-09-16 13:15:54 +02:00
for (const QString& profileName : mProfileList) {
New feature: Set custom icons in profiles list (#2814)
2019-07-25 16:59:16 +02:00
if (profileName.isEmpty()) {
continue;
}
if (hasCustomIcon(profileName)) {
Refactor: remove minute visible name from Connection dialogue icons We have been trying to hide the text associated with the `QListWidgetItems` in the connection dialogue by setting the font size to the minimum of `1` and by setting it's colour to be white. This is not effective when the background is not white - which is likely for a "Dark" desktop environment. The only way to successfully hide the text is, I think, to not have any! However the text was being used programmatically, so the best way to use a `QListWidget` in this mannar is to store the text elsewhere in each item's structure. Fortunately Qt provides for this with the user data functionality which allows multiple data items (based on the `QVariant` class) to be stored within each `QListWidgetItem` using an integer key to denote the type of the data. Ironically the text, icon and other details for each item are ALSO stored in this way - however for non-Qt internal use the lowest integer key that is to be used is `Qt::UserRole` - which I have assigned to the `(const int) dlgConnectionProfiles::csmNameRole` static value. It is quite possible that a redesign of the Connect Profiles dialogue may use this system to store/cache more details about each profile in the future! The only issue with this is the lack of a: `QListWidget::findData(const QVarient&data, int role = Qt::UserRole ...)` method (c.f. `QComboBox::findData(...)`) so I have had to provide a: `(QList<QListWidgetItem*>) findData(const QListWidget&, const QVariant&, const int role = Qt::UserRole) const; method to fill in this gap and to replace the previous `QListWidget::find(...)` that examined each item's text. Also removed local `(QString) profile` from: `(void) dlgConnectionProfiles::slot_item_clicked(QListWidgetItem*)` as it is merely a redundent duplicate of another local `(QString) profile_name`. Renamed local `(QListWidgetItem*) pM` from: `(void) dlgConnectionProfiles::fillout_form()` to: `(QListWidgetItem*) pItem` as that reflects the name used throughout the rest of the class for this type of variable. Changed a `(QLabel*)::setText(tr(""))` call to the more explicit and less stupid `(QLabel*)::clear()`. Similarly changed a `(QWidget*)::setToolTip("")` to a `(QWidget*)::setToolTip(QString())`. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2020-07-01 20:59:42 +01:00
loadCustomProfile(profileName);
New feature: Set custom icons in profiles list (#2814)
2019-07-25 16:59:16 +02:00
} else {
// mProfileList is derived from a filesystem directory, but MacOS is not
// necessarily case preserving for file names so any tests on them
// should be case insensitive
// skip creating icons for default MUDs as they are already created above
Fix `--profile` to load connection info for first-time profiles (2/2) (#5381)
2021-08-21 15:44:37 +02:00
if (defaultGames.contains(profileName, Qt::CaseInsensitive)) {
New feature: Set custom icons in profiles list (#2814)
2019-07-25 16:59:16 +02:00
continue;
}
Revise: select profiles by typing the name, keep profile icons (#4440) Restore the text display of the profile name. This is so that the keyboard selection of profiles beginning with a particular letter works again. This will close issue #4283 . This also sets it to the minimum size trying to hide it by setting the font size to 1 - however that still show something (and a font size of zero is NOT valid). Manipulating the QPalette of the QListWidget does not work well enough in the presence of Styles or StyleSheets to be a viable means of hiding the text either. Also in the `dlgConnection` class: * refactor out some highly repetitive code that sets up the predefined Mud icons. * remove warnings and adopts a change introduced into Qt 5.15 for the QLabel::pixmap() which now requires a Qt::ReturnByValue argument to prevent an obsolete code warning and to force a QPixmap to be returned by value and not reference... * remove a warning about: QListWidget::setItemSelected(QListWidgetItem*,bool) being deprecated and switches to the recommended: QListWidgetItem::setSelected(bool) Edit: the last item above may have become redundant as further commits amalgamated into this PR may have taken out these lines anyhow! Change the custom icon generator so that there is NOT a dependency on the position in the list for the colours used. This means that the same name will always have the same colours - which will help the user to pick out a particular profile as it will always look the same no matter if other profiles are added or removed. Remove the colour gradient in the custom icon as it is not thought to be useful nowadays. Refactor out the colour icon generator to a single method that is called from more than one place. BugFix: restore odd original way of accessing some QPixmaps This was causing failures in some CI platforms using Qt 5.14. or older. Revise: really frob the custom icon generator This is to try and produce as varied but still readable icons when they are generated entirely on the basis of the MUD name - in a reproducible (though Qt do NOT guarantee repeatable qHash() functionality across Qt versions - so they may not stay *that* constant) manner. Refrob: use a table of fixed colours Using only 15 hues but with 3 different saturation level plus 5 grey-scale one should give enough different icons but not generate them too close to each other for those with normal colour vision... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Kebap <kebap_spam@gmx.net>
2020-12-11 17:53:28 +00:00
// This will instantiate a new QListWidgetItem for the profile:
generateCustomProfile(profileName);
New feature: Set custom icons in profiles list (#2814)
2019-07-25 16:59:16 +02:00
}
}
}
bool dlgConnectionProfiles::hasCustomIcon(const QString& profileName) const
{
Infrastructure: add `enums.h` (#7646) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Add `enums.h` where we can add enums and flags to be used throughout the application that don't have a more specific place to be, without dragging in giant classes such as mudlet.h or Host.h. Also added `enums::PackageModuleType` to track the magic numbers used throughout package/module code :rocket: #### Motivation for adding to Mudlet Simplify code organisation. #### Other info (issues closed, discussion etc) --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-01-08 10:04:50 +01:00
return QFileInfo::exists(mudlet::getMudletPath(enums::profileDataItemPath, profileName, qsl("profileicon")));
New feature: Set custom icons in profiles list (#2814)
2019-07-25 16:59:16 +02:00
}
Refactor: remove minute visible name from Connection dialogue icons We have been trying to hide the text associated with the `QListWidgetItems` in the connection dialogue by setting the font size to the minimum of `1` and by setting it's colour to be white. This is not effective when the background is not white - which is likely for a "Dark" desktop environment. The only way to successfully hide the text is, I think, to not have any! However the text was being used programmatically, so the best way to use a `QListWidget` in this mannar is to store the text elsewhere in each item's structure. Fortunately Qt provides for this with the user data functionality which allows multiple data items (based on the `QVariant` class) to be stored within each `QListWidgetItem` using an integer key to denote the type of the data. Ironically the text, icon and other details for each item are ALSO stored in this way - however for non-Qt internal use the lowest integer key that is to be used is `Qt::UserRole` - which I have assigned to the `(const int) dlgConnectionProfiles::csmNameRole` static value. It is quite possible that a redesign of the Connect Profiles dialogue may use this system to store/cache more details about each profile in the future! The only issue with this is the lack of a: `QListWidget::findData(const QVarient&data, int role = Qt::UserRole ...)` method (c.f. `QComboBox::findData(...)`) so I have had to provide a: `(QList<QListWidgetItem*>) findData(const QListWidget&, const QVariant&, const int role = Qt::UserRole) const; method to fill in this gap and to replace the previous `QListWidget::find(...)` that examined each item's text. Also removed local `(QString) profile` from: `(void) dlgConnectionProfiles::slot_item_clicked(QListWidgetItem*)` as it is merely a redundent duplicate of another local `(QString) profile_name`. Renamed local `(QListWidgetItem*) pM` from: `(void) dlgConnectionProfiles::fillout_form()` to: `(QListWidgetItem*) pItem` as that reflects the name used throughout the rest of the class for this type of variable. Changed a `(QLabel*)::setText(tr(""))` call to the more explicit and less stupid `(QLabel*)::clear()`. Similarly changed a `(QWidget*)::setToolTip("")` to a `(QWidget*)::setToolTip(QString())`. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2020-07-01 20:59:42 +01:00
void dlgConnectionProfiles::loadCustomProfile(const QString& profileName) const
New feature: Set custom icons in profiles list (#2814)
2019-07-25 16:59:16 +02:00
{
Refactor: remove minute visible name from Connection dialogue icons We have been trying to hide the text associated with the `QListWidgetItems` in the connection dialogue by setting the font size to the minimum of `1` and by setting it's colour to be white. This is not effective when the background is not white - which is likely for a "Dark" desktop environment. The only way to successfully hide the text is, I think, to not have any! However the text was being used programmatically, so the best way to use a `QListWidget` in this mannar is to store the text elsewhere in each item's structure. Fortunately Qt provides for this with the user data functionality which allows multiple data items (based on the `QVariant` class) to be stored within each `QListWidgetItem` using an integer key to denote the type of the data. Ironically the text, icon and other details for each item are ALSO stored in this way - however for non-Qt internal use the lowest integer key that is to be used is `Qt::UserRole` - which I have assigned to the `(const int) dlgConnectionProfiles::csmNameRole` static value. It is quite possible that a redesign of the Connect Profiles dialogue may use this system to store/cache more details about each profile in the future! The only issue with this is the lack of a: `QListWidget::findData(const QVarient&data, int role = Qt::UserRole ...)` method (c.f. `QComboBox::findData(...)`) so I have had to provide a: `(QList<QListWidgetItem*>) findData(const QListWidget&, const QVariant&, const int role = Qt::UserRole) const; method to fill in this gap and to replace the previous `QListWidget::find(...)` that examined each item's text. Also removed local `(QString) profile` from: `(void) dlgConnectionProfiles::slot_item_clicked(QListWidgetItem*)` as it is merely a redundent duplicate of another local `(QString) profile_name`. Renamed local `(QListWidgetItem*) pM` from: `(void) dlgConnectionProfiles::fillout_form()` to: `(QListWidgetItem*) pItem` as that reflects the name used throughout the rest of the class for this type of variable. Changed a `(QLabel*)::setText(tr(""))` call to the more explicit and less stupid `(QLabel*)::clear()`. Similarly changed a `(QWidget*)::setToolTip("")` to a `(QWidget*)::setToolTip(QString())`. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2020-07-01 20:59:42 +01:00
auto pItem = new QListWidgetItem();
Revise: select profiles by typing the name, keep profile icons (#4440) Restore the text display of the profile name. This is so that the keyboard selection of profiles beginning with a particular letter works again. This will close issue #4283 . This also sets it to the minimum size trying to hide it by setting the font size to 1 - however that still show something (and a font size of zero is NOT valid). Manipulating the QPalette of the QListWidget does not work well enough in the presence of Styles or StyleSheets to be a viable means of hiding the text either. Also in the `dlgConnection` class: * refactor out some highly repetitive code that sets up the predefined Mud icons. * remove warnings and adopts a change introduced into Qt 5.15 for the QLabel::pixmap() which now requires a Qt::ReturnByValue argument to prevent an obsolete code warning and to force a QPixmap to be returned by value and not reference... * remove a warning about: QListWidget::setItemSelected(QListWidgetItem*,bool) being deprecated and switches to the recommended: QListWidgetItem::setSelected(bool) Edit: the last item above may have become redundant as further commits amalgamated into this PR may have taken out these lines anyhow! Change the custom icon generator so that there is NOT a dependency on the position in the list for the colours used. This means that the same name will always have the same colours - which will help the user to pick out a particular profile as it will always look the same no matter if other profiles are added or removed. Remove the colour gradient in the custom icon as it is not thought to be useful nowadays. Refactor out the colour icon generator to a single method that is called from more than one place. BugFix: restore odd original way of accessing some QPixmaps This was causing failures in some CI platforms using Qt 5.14. or older. Revise: really frob the custom icon generator This is to try and produce as varied but still readable icons when they are generated entirely on the basis of the MUD name - in a reproducible (though Qt do NOT guarantee repeatable qHash() functionality across Qt versions - so they may not stay *that* constant) manner. Refrob: use a table of fixed colours Using only 15 hues but with 3 different saturation level plus 5 grey-scale one should give enough different icons but not generate them too close to each other for those with normal colour vision... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Kebap <kebap_spam@gmx.net>
2020-12-11 17:53:28 +00:00
setItemName(pItem, profileName);
Revise: try and identify profiles and some controls in connection dialog (#3966) Also convert all `setDisabled(state)` to `setEnabled(!state)` in the `dlgConnectionProfiles` class - using a single one instead of a mix of the two is less likely to lead to errors - and it means less effort to search for the places where something is being enabled or disabled. Shorten some overlong variable names. Remove some capitalisations. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2020-08-13 00:57:17 +01:00
New feature: Set custom icons in profiles list (#2814)
2019-07-25 16:59:16 +02:00
setCustomIcon(profileName, pItem);
Infrastructure: centralise predefined MUD game data (#6434) This moves the "description" data into the same container as all the other details for the predefined MUDS. That data is then refactored out of the `./src/mudlet.h` file into a separate smaller file that only needs to be `#include`d into two class files - so changing any details requires less to rebuild the application. This PR also removes the 3rd party dependency "qt-ordered-map" (which is 3-clause BSD licensed but NOT currently mentioned in our "About" dialogue!) Afterwards the details for each predefined MUD is held in a `QList<T>` instead - with a couple of helper methods defined to reproduce the information retrieval methods used in the prior code. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Vadim Peretokin <vperetokin@gmail.com>
2022-11-27 00:00:34 +00:00
auto description = getDescription(profileName);
New feature: Set custom icons in profiles list (#2814)
2019-07-25 16:59:16 +02:00
if (!description.isEmpty()) {
Infrastructure: replace `qsl(...)` used for Tooltips (#5694) Specifically when it is used to put HTML like tags around the text so that it triggers the "rich-text" detector in the Qt libraries so that the tips gets better formatting than being a single (long) line of plain text. Whilst working on this PR I also spotted and fixed: * A couple of raw strings in the `VarUnit` class that should have been translated (or replaced with a `QString()`) - this required adding the `Q_DECLARE_TR_FUNCTIONS(`className`)` macro to that class as it is not derived from the `QObject` class which we normally use to provide the `QObject::tr(`...`)` method. * The tooltip for the "Save item" button in the editor contained a unmatched `<p>`...`</p>` tag pair as well as a useless (as it is ignored there) `\n` {Line Feed}. * The tooltip for the "Save profile" button in the editor contained a unmatched `<p>`...`</p>` tag pair. * I had previously defined the `QT_NO_CAST_FROM_ASCII` and `QT_NO_CAST_TO_ASCII` macros in the `dlgRoomExits` class but they are no longer considered useful for us so I have removed those Qt macros. * The `utils::richText(`...`)` wraper has exactly the same code effect as the `(const QString) singleParagraph` helper function in the `dlgRoomExits` class - so it has been replaced by that. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Vadim Peretokin <vperetokin@gmail.com>
2021-12-26 15:22:05 +00:00
pItem->setToolTip(utils::richText(description));
New feature: Set custom icons in profiles list (#2814)
2019-07-25 16:59:16 +02:00
}
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
listWidget_profiles->addItem(pItem);
New feature: Set custom icons in profiles list (#2814)
2019-07-25 16:59:16 +02:00
}
Revise: select profiles by typing the name, keep profile icons (#4440) Restore the text display of the profile name. This is so that the keyboard selection of profiles beginning with a particular letter works again. This will close issue #4283 . This also sets it to the minimum size trying to hide it by setting the font size to 1 - however that still show something (and a font size of zero is NOT valid). Manipulating the QPalette of the QListWidget does not work well enough in the presence of Styles or StyleSheets to be a viable means of hiding the text either. Also in the `dlgConnection` class: * refactor out some highly repetitive code that sets up the predefined Mud icons. * remove warnings and adopts a change introduced into Qt 5.15 for the QLabel::pixmap() which now requires a Qt::ReturnByValue argument to prevent an obsolete code warning and to force a QPixmap to be returned by value and not reference... * remove a warning about: QListWidget::setItemSelected(QListWidgetItem*,bool) being deprecated and switches to the recommended: QListWidgetItem::setSelected(bool) Edit: the last item above may have become redundant as further commits amalgamated into this PR may have taken out these lines anyhow! Change the custom icon generator so that there is NOT a dependency on the position in the list for the colours used. This means that the same name will always have the same colours - which will help the user to pick out a particular profile as it will always look the same no matter if other profiles are added or removed. Remove the colour gradient in the custom icon as it is not thought to be useful nowadays. Refactor out the colour icon generator to a single method that is called from more than one place. BugFix: restore odd original way of accessing some QPixmaps This was causing failures in some CI platforms using Qt 5.14. or older. Revise: really frob the custom icon generator This is to try and produce as varied but still readable icons when they are generated entirely on the basis of the MUD name - in a reproducible (though Qt do NOT guarantee repeatable qHash() functionality across Qt versions - so they may not stay *that* constant) manner. Refrob: use a table of fixed colours Using only 15 hues but with 3 different saturation level plus 5 grey-scale one should give enough different icons but not generate them too close to each other for those with normal colour vision... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Kebap <kebap_spam@gmx.net>
2020-12-11 17:53:28 +00:00
void dlgConnectionProfiles::setCustomIcon(const QString& profileName, QListWidgetItem* profile) const
{
Infrastructure: add `enums.h` (#7646) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Add `enums.h` where we can add enums and flags to be used throughout the application that don't have a more specific place to be, without dragging in giant classes such as mudlet.h or Host.h. Also added `enums::PackageModuleType` to track the magic numbers used throughout package/module code :rocket: #### Motivation for adding to Mudlet Simplify code organisation. #### Other info (issues closed, discussion etc) --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-01-08 10:04:50 +01:00
auto profileIconPath = mudlet::getMudletPath(enums::profileDataItemPath, profileName, qsl("profileicon"));
New feature: Set custom icons in profiles list (#2814)
2019-07-25 16:59:16 +02:00
auto icon = QIcon(QPixmap(profileIconPath).scaled(QSize(120, 30), Qt::IgnoreAspectRatio, Qt::SmoothTransformation).copy());
profile->setIcon(icon);
}
Store character's login passwords securely (#3018) * Added QtKeychain * Wire in QtKeychain into qmake build * Install libsecret-dev in Travis * Got read/write working from the secure storage only * Reset password * Change to using a callback instead of a deep chain of nested calls * Wire in CMake build, but doesn't work yet * Finish CMake build, works now * WIP * Add migration to secure storage * Remove left-in debug echo * Don't forget password when profile is renamed * Don't delete passwords upon migration for now * Revise: insert QtKeyChain licence boilerplate (#17) I have use the 2-Clause BSD (a.k.a the FreeBSD) licence that is in the upstream's "COPYING" file - this is at varience with the two README files which quote the licence as being the Modified BSD which is the 3-Clause one. I have an open issue on the upstream repository seeking clarification; should things not be as they seem it should be a relatively painless operation to select the other boillerplate for this item. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2019-09-09 07:37:11 +02:00
// When a profile is renamed, migrate password storage to the new profile
Add ability to define custom color in profile buttons in connection dialog (#5365)
2021-08-13 07:22:24 +02:00
void dlgConnectionProfiles::migrateSecuredPassword(const QString& oldProfile, const QString& newProfile)
Store character's login passwords securely (#3018) * Added QtKeychain * Wire in QtKeychain into qmake build * Install libsecret-dev in Travis * Got read/write working from the secure storage only * Reset password * Change to using a callback instead of a deep chain of nested calls * Wire in CMake build, but doesn't work yet * Finish CMake build, works now * WIP * Add migration to secure storage * Remove left-in debug echo * Don't forget password when profile is renamed * Don't delete passwords upon migration for now * Revise: insert QtKeyChain licence boilerplate (#17) I have use the 2-Clause BSD (a.k.a the FreeBSD) licence that is in the upstream's "COPYING" file - this is at varience with the two README files which quote the licence as being the Modified BSD which is the 3-Clause one. I have an open issue on the upstream repository seeking clarification; should things not be as they seem it should be a relatively painless operation to select the other boillerplate for this item. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2019-09-09 07:37:11 +02:00
{
const auto& password = character_password_entry->text().trimmed();
deleteSecurePassword(oldProfile);
Add a Mudlet Tutorial profile. (#8188) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Adds a Mudlet Tutorial profile which incorporates a basic GUI tutorial and mini-mud quest. GUI tutorial introduces the main window, command line, search bar, toolbar, map. Mini-quest attempts to act like a MUD. Teaches directional commands and some typical verbs (look, buy, give, get, open, close, quit) while the player wanders around trying to figure out the two 'quests' (buy the sheriff some lunch and find the librarian's lost ring). It is simplistic and more designed to show players how a mud 'feels and progresses' when playing rather than a full blown MUD school which most (all?) MUDs incorporate. #### Motivation for adding to Mudlet Help on-boarding new users. Destination 5.0. /claim #3072 helps #2823 #### Other info (issues closed, discussion etc) I purposefully left out triggers, scripting and all that stuff veteran players take for granted! This is supposed to be an on-boarding tutorial for NEW players, let's not overwhelm them. A link after successful completion of the game introduces the wiki Introduction page for more advanced topics. That said, any improvements or basic features you think are missing from either the GUI or Mud tutorials, let me know and I can add. https://github.com/user-attachments/assets/1d16db50-e24b-4e78-b6b0-66e0e98a0772
2025-09-13 14:17:13 +07:00
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
// Only store the password if it's not empty
if (!password.isEmpty()) {
writeSecurePassword(newProfile, password);
}
Store character's login passwords securely (#3018) * Added QtKeychain * Wire in QtKeychain into qmake build * Install libsecret-dev in Travis * Got read/write working from the secure storage only * Reset password * Change to using a callback instead of a deep chain of nested calls * Wire in CMake build, but doesn't work yet * Finish CMake build, works now * WIP * Add migration to secure storage * Remove left-in debug echo * Don't forget password when profile is renamed * Don't delete passwords upon migration for now * Revise: insert QtKeyChain licence boilerplate (#17) I have use the 2-Clause BSD (a.k.a the FreeBSD) licence that is in the upstream's "COPYING" file - this is at varience with the two README files which quote the licence as being the Modified BSD which is the 3-Clause one. I have an open issue on the upstream repository seeking clarification; should things not be as they seem it should be a relatively painless operation to select the other boillerplate for this item. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2019-09-09 07:37:11 +02:00
}
template <typename L>
Add ability to define custom color in profile buttons in connection dialog (#5365)
2021-08-13 07:22:24 +02:00
void dlgConnectionProfiles::loadSecuredPassword(const QString& profile, L callback)
Store character's login passwords securely (#3018) * Added QtKeychain * Wire in QtKeychain into qmake build * Install libsecret-dev in Travis * Got read/write working from the secure storage only * Reset password * Change to using a callback instead of a deep chain of nested calls * Wire in CMake build, but doesn't work yet * Finish CMake build, works now * WIP * Add migration to secure storage * Remove left-in debug echo * Don't forget password when profile is renamed * Don't delete passwords upon migration for now * Revise: insert QtKeyChain licence boilerplate (#17) I have use the 2-Clause BSD (a.k.a the FreeBSD) licence that is in the upstream's "COPYING" file - this is at varience with the two README files which quote the licence as being the Modified BSD which is the 3-Clause one. I have an open issue on the upstream repository seeking clarification; should things not be as they seem it should be a relatively painless operation to select the other boillerplate for this item. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2019-09-09 07:37:11 +02:00
{
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
// Use async API for QtKeychain integration with file fallback
improve: improve memory safety by using smart pointers (#9239) ### Refactor: replace raw pointer ownership with smart pointers across core subsystems #### Brief overview of PR changes/additions Replaces raw pointer ownership patterns with `std::unique_ptr` and `std::map` across several core subsystems: - **Host**: `mStopWatchMap` (`QMap<int, stopWatch*>` → `std::map<int, unique_ptr<stopWatch>>`), `profileShortcuts` (`QMap<QString, QKeySequence*>` → `std::map<QString, unique_ptr<QKeySequence>>`). Removes `qDeleteAll` in destructor and `delete mMMCPServer`. - **TMap**: `mpRoomDB` raw pointer → `unique_ptr` - **VarUnit**: `base` raw pointer → `unique_ptr` - **TTrigger**: condition map storage converted to `unique_ptr`, destructor simplified - **discord**: handler and presence maps converted from raw pointer `QMap` to `unique_ptr` + `std::map` - **Updater**: `mFeed` and `mUpdateDialog` converted to `unique_ptr` #### Motivation for adding to Mudlet These patterns were identified as sources of memory leaks and potential use-after-free bugs. Using smart pointers makes ownership explicit, eliminates manual cleanup code, and ensures correct destruction even on early-exit paths. #### Other info (issues closed, discussion etc) sorry this one is still pretty big, but most of the changes are the same for each thing so reviewing them together probably makes sense. sadly there isn't much to see here other than no slow uptick of heap size :-[ Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-05 16:42:09 +12:00
auto* credManager = new CredentialManager(this);
Add a Mudlet Tutorial profile. (#8188) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Adds a Mudlet Tutorial profile which incorporates a basic GUI tutorial and mini-mud quest. GUI tutorial introduces the main window, command line, search bar, toolbar, map. Mini-quest attempts to act like a MUD. Teaches directional commands and some typical verbs (look, buy, give, get, open, close, quit) while the player wanders around trying to figure out the two 'quests' (buy the sheriff some lunch and find the librarian's lost ring). It is simplistic and more designed to show players how a mud 'feels and progresses' when playing rather than a full blown MUD school which most (all?) MUDs incorporate. #### Motivation for adding to Mudlet Help on-boarding new users. Destination 5.0. /claim #3072 helps #2823 #### Other info (issues closed, discussion etc) I purposefully left out triggers, scripting and all that stuff veteran players take for granted! This is supposed to be an on-boarding tutorial for NEW players, let's not overwhelm them. A link after successful completion of the game introduces the wiki Introduction page for more advanced topics. That said, any improvements or basic features you think are missing from either the GUI or Mud tutorials, let me know and I can add. https://github.com/user-attachments/assets/1d16db50-e24b-4e78-b6b0-66e0e98a0772
2025-09-13 14:17:13 +07:00
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
credManager->retrievePassword(profile, "character", [credManager, callback = std::move(callback)](bool success, const QString& password, const QString& errorMessage) {
if (success) {
callback(password);
QString passwordCopy = password; // Make a copy for secure clearing
SecureStringUtils::secureStringClear(passwordCopy);
} else {
if (!errorMessage.isEmpty()) {
qDebug() << "dlgConnectionProfiles: Failed to retrieve password:" << errorMessage;
Store character's login passwords securely (#3018) * Added QtKeychain * Wire in QtKeychain into qmake build * Install libsecret-dev in Travis * Got read/write working from the secure storage only * Reset password * Change to using a callback instead of a deep chain of nested calls * Wire in CMake build, but doesn't work yet * Finish CMake build, works now * WIP * Add migration to secure storage * Remove left-in debug echo * Don't forget password when profile is renamed * Don't delete passwords upon migration for now * Revise: insert QtKeyChain licence boilerplate (#17) I have use the 2-Clause BSD (a.k.a the FreeBSD) licence that is in the upstream's "COPYING" file - this is at varience with the two README files which quote the licence as being the Modified BSD which is the 3-Clause one. I have an open issue on the upstream repository seeking clarification; should things not be as they seem it should be a relatively painless operation to select the other boillerplate for this item. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2019-09-09 07:37:11 +02:00
}
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
callback(QString()); // Call with empty string on failure
infrastructure: Apply clang-format to all CPP files (#8804) #### Brief overview of PR changes/additions Ran clang-format on all 134 CPP files in src/ using the project's .clang-format config #### Motivation for adding to Mudlet Ensures consistent code formatting across the codebase. #### Other info (issues closed, discussion etc) None **Test case:** Build the project and verify it compiles successfully.
2026-01-19 18:10:44 +01:00
}
Add a Mudlet Tutorial profile. (#8188) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Adds a Mudlet Tutorial profile which incorporates a basic GUI tutorial and mini-mud quest. GUI tutorial introduces the main window, command line, search bar, toolbar, map. Mini-quest attempts to act like a MUD. Teaches directional commands and some typical verbs (look, buy, give, get, open, close, quit) while the player wanders around trying to figure out the two 'quests' (buy the sheriff some lunch and find the librarian's lost ring). It is simplistic and more designed to show players how a mud 'feels and progresses' when playing rather than a full blown MUD school which most (all?) MUDs incorporate. #### Motivation for adding to Mudlet Help on-boarding new users. Destination 5.0. /claim #3072 helps #2823 #### Other info (issues closed, discussion etc) I purposefully left out triggers, scripting and all that stuff veteran players take for granted! This is supposed to be an on-boarding tutorial for NEW players, let's not overwhelm them. A link after successful completion of the game introduces the wiki Introduction page for more advanced topics. That said, any improvements or basic features you think are missing from either the GUI or Mud tutorials, let me know and I can add. https://github.com/user-attachments/assets/1d16db50-e24b-4e78-b6b0-66e0e98a0772
2025-09-13 14:17:13 +07:00
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
// Clean up the credential manager
credManager->deleteLater();
});
Store character's login passwords securely (#3018) * Added QtKeychain * Wire in QtKeychain into qmake build * Install libsecret-dev in Travis * Got read/write working from the secure storage only * Reset password * Change to using a callback instead of a deep chain of nested calls * Wire in CMake build, but doesn't work yet * Finish CMake build, works now * WIP * Add migration to secure storage * Remove left-in debug echo * Don't forget password when profile is renamed * Don't delete passwords upon migration for now * Revise: insert QtKeyChain licence boilerplate (#17) I have use the 2-Clause BSD (a.k.a the FreeBSD) licence that is in the upstream's "COPYING" file - this is at varience with the two README files which quote the licence as being the Modified BSD which is the 3-Clause one. I have an open issue on the upstream repository seeking clarification; should things not be as they seem it should be a relatively painless operation to select the other boillerplate for this item. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2019-09-09 07:37:11 +02:00
}
Add ability to define custom color in profile buttons in connection dialog (#5365)
2021-08-13 07:22:24 +02:00
std::optional<QColor> getCustomColor(const QString& profileName)
{
Infrastructure: add `enums.h` (#7646) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Add `enums.h` where we can add enums and flags to be used throughout the application that don't have a more specific place to be, without dragging in giant classes such as mudlet.h or Host.h. Also added `enums::PackageModuleType` to track the magic numbers used throughout package/module code :rocket: #### Motivation for adding to Mudlet Simplify code organisation. #### Other info (issues closed, discussion etc) --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-01-08 10:04:50 +01:00
auto profileColorPath = mudlet::getMudletPath(enums::profileDataItemPath, profileName, qsl("profilecolor"));
Add ability to define custom color in profile buttons in connection dialog (#5365)
2021-08-13 07:22:24 +02:00
if (QFileInfo::exists(profileColorPath)) {
QFile file(profileColorPath);
if (!file.open(QIODevice::ReadOnly | QIODevice::Text)) {
return std::nullopt;
}
QTextStream in(&file);
Infrastructure: mark read-only variables as const (#6843) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Mark read-only variables as const - that is, not intended to change after they've been declared #### Motivation for adding to Mudlet So we don't change them by accident later on, and also to clearly state intentions for the variables #### Other info (issues closed, discussion etc) This is also recommended by the [C++ Core Guidelines](https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#es25-declare-an-object-const-or-constexpr-unless-you-want-to-modify-its-value-later-on)
2023-05-14 15:06:15 +02:00
const QString colorString = in.readLine();
Add ability to define custom color in profile buttons in connection dialog (#5365)
2021-08-13 07:22:24 +02:00
QColor color(colorString);
if (color.isValid()) {
return {color};
}
}
return std::nullopt;
}
Revise: select profiles by typing the name, keep profile icons (#4440) Restore the text display of the profile name. This is so that the keyboard selection of profiles beginning with a particular letter works again. This will close issue #4283 . This also sets it to the minimum size trying to hide it by setting the font size to 1 - however that still show something (and a font size of zero is NOT valid). Manipulating the QPalette of the QListWidget does not work well enough in the presence of Styles or StyleSheets to be a viable means of hiding the text either. Also in the `dlgConnection` class: * refactor out some highly repetitive code that sets up the predefined Mud icons. * remove warnings and adopts a change introduced into Qt 5.15 for the QLabel::pixmap() which now requires a Qt::ReturnByValue argument to prevent an obsolete code warning and to force a QPixmap to be returned by value and not reference... * remove a warning about: QListWidget::setItemSelected(QListWidgetItem*,bool) being deprecated and switches to the recommended: QListWidgetItem::setSelected(bool) Edit: the last item above may have become redundant as further commits amalgamated into this PR may have taken out these lines anyhow! Change the custom icon generator so that there is NOT a dependency on the position in the list for the colours used. This means that the same name will always have the same colours - which will help the user to pick out a particular profile as it will always look the same no matter if other profiles are added or removed. Remove the colour gradient in the custom icon as it is not thought to be useful nowadays. Refactor out the colour icon generator to a single method that is called from more than one place. BugFix: restore odd original way of accessing some QPixmaps This was causing failures in some CI platforms using Qt 5.14. or older. Revise: really frob the custom icon generator This is to try and produce as varied but still readable icons when they are generated entirely on the basis of the MUD name - in a reproducible (though Qt do NOT guarantee repeatable qHash() functionality across Qt versions - so they may not stay *that* constant) manner. Refrob: use a table of fixed colours Using only 15 hues but with 3 different saturation level plus 5 grey-scale one should give enough different icons but not generate them too close to each other for those with normal colour vision... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Kebap <kebap_spam@gmx.net>
2020-12-11 17:53:28 +00:00
void dlgConnectionProfiles::generateCustomProfile(const QString& profileName) const
New feature: Set custom icons in profiles list (#2814)
2019-07-25 16:59:16 +02:00
{
Refactor: remove minute visible name from Connection dialogue icons We have been trying to hide the text associated with the `QListWidgetItems` in the connection dialogue by setting the font size to the minimum of `1` and by setting it's colour to be white. This is not effective when the background is not white - which is likely for a "Dark" desktop environment. The only way to successfully hide the text is, I think, to not have any! However the text was being used programmatically, so the best way to use a `QListWidget` in this mannar is to store the text elsewhere in each item's structure. Fortunately Qt provides for this with the user data functionality which allows multiple data items (based on the `QVariant` class) to be stored within each `QListWidgetItem` using an integer key to denote the type of the data. Ironically the text, icon and other details for each item are ALSO stored in this way - however for non-Qt internal use the lowest integer key that is to be used is `Qt::UserRole` - which I have assigned to the `(const int) dlgConnectionProfiles::csmNameRole` static value. It is quite possible that a redesign of the Connect Profiles dialogue may use this system to store/cache more details about each profile in the future! The only issue with this is the lack of a: `QListWidget::findData(const QVarient&data, int role = Qt::UserRole ...)` method (c.f. `QComboBox::findData(...)`) so I have had to provide a: `(QList<QListWidgetItem*>) findData(const QListWidget&, const QVariant&, const int role = Qt::UserRole) const; method to fill in this gap and to replace the previous `QListWidget::find(...)` that examined each item's text. Also removed local `(QString) profile` from: `(void) dlgConnectionProfiles::slot_item_clicked(QListWidgetItem*)` as it is merely a redundent duplicate of another local `(QString) profile_name`. Renamed local `(QListWidgetItem*) pM` from: `(void) dlgConnectionProfiles::fillout_form()` to: `(QListWidgetItem*) pItem` as that reflects the name used throughout the rest of the class for this type of variable. Changed a `(QLabel*)::setText(tr(""))` call to the more explicit and less stupid `(QLabel*)::clear()`. Similarly changed a `(QWidget*)::setToolTip("")` to a `(QWidget*)::setToolTip(QString())`. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2020-07-01 20:59:42 +01:00
auto pItem = new QListWidgetItem();
Revise: select profiles by typing the name, keep profile icons (#4440) Restore the text display of the profile name. This is so that the keyboard selection of profiles beginning with a particular letter works again. This will close issue #4283 . This also sets it to the minimum size trying to hide it by setting the font size to 1 - however that still show something (and a font size of zero is NOT valid). Manipulating the QPalette of the QListWidget does not work well enough in the presence of Styles or StyleSheets to be a viable means of hiding the text either. Also in the `dlgConnection` class: * refactor out some highly repetitive code that sets up the predefined Mud icons. * remove warnings and adopts a change introduced into Qt 5.15 for the QLabel::pixmap() which now requires a Qt::ReturnByValue argument to prevent an obsolete code warning and to force a QPixmap to be returned by value and not reference... * remove a warning about: QListWidget::setItemSelected(QListWidgetItem*,bool) being deprecated and switches to the recommended: QListWidgetItem::setSelected(bool) Edit: the last item above may have become redundant as further commits amalgamated into this PR may have taken out these lines anyhow! Change the custom icon generator so that there is NOT a dependency on the position in the list for the colours used. This means that the same name will always have the same colours - which will help the user to pick out a particular profile as it will always look the same no matter if other profiles are added or removed. Remove the colour gradient in the custom icon as it is not thought to be useful nowadays. Refactor out the colour icon generator to a single method that is called from more than one place. BugFix: restore odd original way of accessing some QPixmaps This was causing failures in some CI platforms using Qt 5.14. or older. Revise: really frob the custom icon generator This is to try and produce as varied but still readable icons when they are generated entirely on the basis of the MUD name - in a reproducible (though Qt do NOT guarantee repeatable qHash() functionality across Qt versions - so they may not stay *that* constant) manner. Refrob: use a table of fixed colours Using only 15 hues but with 3 different saturation level plus 5 grey-scale one should give enough different icons but not generate them too close to each other for those with normal colour vision... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Kebap <kebap_spam@gmx.net>
2020-12-11 17:53:28 +00:00
setItemName(pItem, profileName);
Add ability to define custom color in profile buttons in connection dialog (#5365)
2021-08-13 07:22:24 +02:00
pItem->setIcon(customIcon(profileName, getCustomColor(profileName)));
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
listWidget_profiles->addItem(pItem);
New feature: Set custom icons in profiles list (#2814)
2019-07-25 16:59:16 +02:00
}
Fix three crashes in the game selection screen (#9702) #### Brief overview of PR changes/additions - **Right-clicking the games list with nothing selected killed Mudlet.** `dlgConnectionProfiles::slot_profileContextMenu()` dereferenced `currentItem()` unguarded. That line is byte-identical in 4.22.0, so the null deref itself is long-standing and latent - what is new is that it became reachable: "improve: split the games list into My games and All games tabs" (#9452) leaves a user with no saved profiles an empty but still right-clickable "My games" tab, a state 4.22.0's always-populated list never had. About 40 seconds into a fresh install. - **Copying a profile while the list was rebuilt was a use-after-free.** The copy runs on a thread pool and its completion handler kept the `QListWidgetItem*` it had made; clicking the other games tab meanwhile calls `fillout_form()`, which destroys every item. The handler now finds the copy by name, and the `QFutureWatcher` is parented so it cannot outlive the dialog. - **Quitting before the connection dialog had been shown dereferenced null.** The queued `0ms` lambda in `mudlet::slot_showConnectionDialog()` used `mpConnectionDialog`, which `mudlet::closeEvent()` closes (it is `WA_DeleteOnClose`) and clears. #### Motivation for adding to Mudlet All three came out of the 5.0 QA sweep and are confirmed with AddressSanitizer. The first is the serious one - it is the default state of a brand-new install, so a new user can lose Mudlet before they have connected to anything. Scope note on the third: it is **not** a 5.0 regression. It has been there since "Fix: Improve tab indicators and detached window UX" (#7965) and is unchanged in 4.22.0; #9493 only turned the literal `0` into `0ms`. Nor could I reach it by clicking: I drove *Games -> Close profile* followed by quitting at six delays from 0 to 2000 ms and the dialog was always painted first. It reproduces deterministically in-process, and QA reproduced it 2/2 driving the close from Lua. Worth guarding - the pointer is documented to go null - but latent rather than routinely hit. #### Other info (issues closed, discussion etc) Test case: `ctest -R ConnectionDialogCrashTest` - with the fix reverted, four of its tests reproduce the original ASan reports exactly (two SEGVs in `slot_profileContextMenu`, a heap-use-after-free in `slot_itemClicked`, the SEGV in `QWidget::show()` from the lambda); two more are controls that pass either way, one of them pinning that the menu still opens for a selected profile so the guard cannot degenerate into an unconditional early return. Full suite 79/79. Assisted-by: Claude:claude-opus-5
2026-08-07 10:14:30 +02:00
// fillout_form() destroys and rebuilds every item, so callers that have let the
// event loop run cannot hold on to one.
void dlgConnectionProfiles::setIconOfListedProfile(const QString& profileName, const QIcon& icon) const
{
const auto pItems = findData(*listWidget_profiles, profileName, csmNameRole);
if (pItems.isEmpty()) {
return;
}
pItems.first()->setIcon(icon);
}
// Empty when nothing is selected. The context-menu actions re-check rather than
// trust slot_profileContextMenu(): menu.exec() runs a nested event loop, and the
// profile-copy completion handler calls fillout_form() from it, which can clear
// the selection - or leave a different profile current, in which case the action
// still mis-targets. Only the crash of acting on nothing is handled here.
QString dlgConnectionProfiles::selectedProfileName() const
{
const auto* pItem = listWidget_profiles->currentItem();
return pItem ? pItem->data(csmNameRole).toString() : QString();
}
Infrastructure: tidy up naming of SLOT methods and their usage - Part 5 (last) (#6266) When Qt's slot/signal system is used to invoke a method there is some overhead - so it makes sense to ensure developers can spot all such methods (functions). We have tried to do this with a `slot_` prefix to the methods we create but it has not been applied uniformly. This PR is intended to conclude helping with this by more rigorously doing so - the names changed herein should all follow a `slot_`*camelCaseMethodName* style. In addition some methods were detected that are not currently used or which are not actually used via the signal/slot system, these have been commented out or have had the prefix removed and the declaration in the relevant header file moved as appropriate. There were two similar sets of (not prefixed with `slot_`) slots in the Profile preferences class that adjusted the colour settings separately for the main console and the mapper the latter had the same names but with a `2` suffix. To made it more clear I have changed them to include `Map` in their names instead. Also, the NON-slot method: `(void) dlgProfilePreferences::setColor(QPushButton*, QColor&, bool)` has been renamed to: `(void) dlgProfilePreferences::setButtonAndProfileColor(QPushButton*, QColor&, bool)` so that it is clearly distinguishable from built in Qt methods that are also called `setColor` - though which do have different signatures! For reference the changes made are: * `TConsole::slot_stop_all_triggers(...)` ==> `TConsole::slot_stopAllItems(...)` * `dlgConnectionProfiles::slot_copy_profile()` ==> `dlgConnectionProfiles::slot_copyProfile()` * `dlgConnectionProfiles::slot_copy_profilesettings_only()` ==> `dlgConnectionProfiles::slot_copyOnlySettingsOfProfile()` * `dlgConnectionProfiles::slot_deleteprofile_check(...)` ==> `dlgConnectionProfiles::slot_deleteProfileCheck(...)` * `dlgConnectionProfiles::slot_password_deleted(...)` ==> `dlgConnectionProfiles::slot_passwordDeleted(...)` * `dlgConnectionProfiles::slot_password_saved(...) ==> `dlgConnectionProfiles::slot_passwordSaved(...)` * `dlgConnectionProfiles::slot_profile_menu(...)` ==> `dlgConnectionProfiles::slot_profileContextMenu(...)` * `dlgConnectionProfiles::slot_reset_custom_icon()` ==> `dlgConnectionProfiles::slot_resetCustomIcon()` * `dlgConnectionProfiles::slot_set_custom_icon()` ==> `dlgConnectionProfiles::slot_setCustomIcon()` * `dlgConnectionProfiles::slot_set_custom_color()` ==> `dlgConnectionProfiles::slot_setCustomColor()` * `dlgConnectionProfiles::slot_update_autologin(...)` ==> `dlgConnectionProfiles::slot_updateAutoConnect(...)` * `dlgConnectionProfiles::slot_update_autoreconnect(...)` ==> `dlgConnectionProfiles::slot_updateAutoReconnect(...)` * `dlgConnectionProfiles::slot_update_description()` ==> `dlgConnectionProfiles::slot_updateDescription()` * `dlgConnectionProfiles::slot_update_discord_optin(...)` ==> `dlgConnectionProfiles::slot_updateDiscordOptIn(...)` * `dlgProfilePreferences::copyMap()` ==> `dlgProfilePreferences::slot_copyMap()` * `dlgProfilePreferences::downloadMap()` ==> `dlgProfilePreferences::slot_downloadMap()` * `dlgProfilePreferences::hideActionLabel()` ==> `dlgProfilePreferences::slot_hideActionLabel()` * `dlgProfilePreferences::loadMap()` ==> `dlgProfilePreferences::slot_loadMap()` * `dlgProfilePreferences::resetColors()` ==> `dlgProfilePreferences::slot_resetColors()` * `dlgProfilePreferences::resetColors2()` ==> `dlgProfilePreferences::slot_resetMapColors()` * `dlgProfilePreferences::saveMap()` ==> `dlgProfilePreferences::slot_saveMap()` * `dlgProfilePreferences::setBgColor()` ==> `dlgProfilePreferences::slot_setBgColor()` * `dlgProfilePreferences::setBgColor2()` ==> `dlgProfilePreferences::slot_setMapBgColor()` * `dlgProfilePreferences::setColorBlack()` ==> `dlgProfilePreferences::slot_setColorBlack()` * `dlgProfilePreferences::setColorBlack2()` ==> `dlgProfilePreferences::slot_setMapColorBlack()` * `dlgProfilePreferences::setColorBlue()` ==> `dlgProfilePreferences::slot_setColorBlue()` * `dlgProfilePreferences::setColorCyan()` ==> `dlgProfilePreferences::slot_setColorCyan()` * `dlgProfilePreferences::setColorBlue2()` ==> `dlgProfilePreferences::slot_setMapColorBlue()` * `dlgProfilePreferences::setColorCyan2()` ==> `dlgProfilePreferences::slot_setMapColorCyan()` * `dlgProfilePreferences::setColorGreen()` ==> `dlgProfilePreferences::slot_setColorGreen()` * `dlgProfilePreferences::setColorGreen2()` ==> `dlgProfilePreferences::slot_setMapColorGreen()` * `dlgProfilePreferences::setColorLightBlack()` ==> `dlgProfilePreferences::slot_setColorLightBlack()` * `dlgProfilePreferences::setColorLightBlack2()` ==> `dlgProfilePreferences::slot_setMapColorLightBlack()` * `dlgProfilePreferences::setColorLightBlue()` ==> `dlgProfilePreferences::slot_setColorLightBlue()` * `dlgProfilePreferences::setColorLightBlue2()` ==> `dlgProfilePreferences::slot_setMapColorLightBlue()` * `dlgProfilePreferences::setColorLightCyan()` ==> `dlgProfilePreferences::slot_setColorLightCyan()` * `dlgProfilePreferences::setColorLightCyan2()` ==> `dlgProfilePreferences::slot_setMapColorLightCyan()` * `dlgProfilePreferences::setColorLightGreen()` ==> `dlgProfilePreferences::slot_setColorLightGreen()` * `dlgProfilePreferences::setColorLightGreen2()` ==> `dlgProfilePreferences::slot_setMapColorLightGreen()` * `dlgProfilePreferences::setColorLightMagenta()` ==> `dlgProfilePreferences::slot_setColorLightMagenta()` * `dlgProfilePreferences::setColorLightMagenta2()` ==> `dlgProfilePreferences::slot_setMapColorLightMagenta()` * `dlgProfilePreferences::setColorLightRed()` ==> `dlgProfilePreferences::slot_setColorLightRed()` * `dlgProfilePreferences::setColorLightRed2()` ==> `dlgProfilePreferences::slot_setMapColorLightRed()` * `dlgProfilePreferences::setColorLightWhite()` ==> `dlgProfilePreferences::slot_setColorLightWhite()` * `dlgProfilePreferences::setColorLightWhite2()` ==> `dlgProfilePreferences::slot_setMapColorLightWhite()` * `dlgProfilePreferences::setColorLightYellow()` ==> `dlgProfilePreferences::slot_setColorLightYellow()` * `dlgProfilePreferences::setColorLightYellow2()` ==> `dlgProfilePreferences::slot_setMapColorLightYellow()` * `dlgProfilePreferences::setColorMagenta()` ==> `dlgProfilePreferences::slot_setColorMagenta()` * `dlgProfilePreferences::setColorMagenta2()` ==> `dlgProfilePreferences::slot_setMapColorMagenta()` * `dlgProfilePreferences::setColorRed2()` ==> `dlgProfilePreferences::slot_setMapColorRed()` * `dlgProfilePreferences::setColorRed()` ==> `dlgProfilePreferences::slot_setColorRed()` * `dlgProfilePreferences::setColorWhite()` ==> `dlgProfilePreferences::slot_setColorWhite()` * `dlgProfilePreferences::setColorWhite2()` ==> `dlgProfilePreferences::slot_setMapColorWhite()` * `dlgProfilePreferences::setColorYellow()` ==> `dlgProfilePreferences::slot_setColorYellow()` * `dlgProfilePreferences::setColorYellow2()` ==> `dlgProfilePreferences::slot_setMapColorYellow()` * `dlgProfilePreferences::setCommandBgColor()` ==> `dlgProfilePreferences::slot_setCommandBgColor()` * `dlgProfilePreferences::setCommandFgColor()` ==> `dlgProfilePreferences::slot_setCommandFgColor()` * `dlgProfilePreferences::setCommandLineBgColor()` ==> `dlgProfilePreferences::slot_setCommandLineBgColor()` * `dlgProfilePreferences::setCommandLineFgColor()` ==> `dlgProfilePreferences::slot_setCommandLineFgColor()` * `dlgProfilePreferences::setDisplayFont()` ==> `dlgProfilePreferences::slot_setDisplayFont()` * `dlgProfilePreferences::setFgColor()` ==> `dlgProfilePreferences::slot_setFgColor()` * `dlgProfilePreferences::setFgColor2()` ==> `dlgProfilePreferences::slot_setMapExitsColor()` * `dlgProfilePreferences::setFontSize()` ==> `dlgProfilePreferences::slot_setFontSize()` * `dlgProfilePreferences::setMapInfoBackground()` ==> `dlgProfilePreferences::slot_setMapInfoBgColor()` * `dlgProfilePreferences::setRoomBorderColor()` ==> `dlgProfilePreferences::slot_setMapRoomBorderColor()` * `dlgProfilePreferences::slot_script_selected(...)` ==> `dlgProfilePreferences::slot_scriptSelected(...)` * `dlgProfilePreferences::slot_theme_selected(...)` ==> `dlgProfilePreferences::slot_themeSelected(...)` * `dlgRoomSymbol::colorRejected()` ==> `dlgRoomSymbol::slot_colorRejected()` * `dlgRoomSymbol::colorSelected(...)` ==> `dlgRoomSymbol::slot_colorSelected(...)` * `dlgRoomSymbol::currentColorChanged(...)` ==> `dlgRoomSymbol::slot_currentColorChanged(...)` * `dlgRoomSymbol::openColorSelector()` ==> `dlgRoomSymbol::slot_openColorSelector()` * `dlgRoomSymbol::resetColor()` ==> `dlgRoomSymbol::slot_resetColors()` * `dlgRoomSymbol::updatePreview()` ==> `dlgRoomSymbol::slot_updatePreview()` * `dlgTriggerEditor::slot_show_vars()` ==> `dlgTriggerEditor::slot_showVariables()` * `dlgTriggerEditor::slot_var_changed(...)` ==> `dlgTriggerEditor::slot_variableChanged(...)` * `dlgTriggerEditor::slot_var_selected(...)` ==> `dlgTriggerEditor::slot_variableSelected(...)` * `mudlet::slot_check_manual_update()` ==> `mudlet::slot_manualUpdateCheck()` * `mudlet::slot_close_current_profile()` ==> `mudlet::slot_closeCurrentProfile()` * `mudlet::slot_close_profile_requested(...)` ==> `mudlet::slot_closeProfileRequested(...)` * `mudlet::slot_connection_dlg_finished(...)` ==> `mudlet::slot_connectionDialogueFinished(...)` * `mudlet::slot_module_manager()` ==> `mudlet::slot_moduleManager()` * `mudlet::slot_mudlet_discord()` ==> `mudlet::slot_mudletDiscord()` * `mudlet::slot_multi_view(...)` ==> `mudlet::slot_multiView(const bool state)` * `mudlet::slot_package_manager()` ==> `mudlet::slot_packageManager()` * `mudlet::slot_package_exporter()` ==> `mudlet::slot_packageExporter()` * `mudlet::slot_timer_fires()` ==> `mudlet::slot_timerFires()` * `mudlet::slot_toggle_multi_view()` ==> `mudlet::slot_toggleMultiView()` Also the names for these in particular have been changed to make more sense: * `dlgProfilePreferences::slot_chooseProfilesChanged()` ==> `dlgProfilePreferences::slot_chosenProfilesChanged()` * `dlgProfilePreferences::slot_editor_tab_selected(...)` ==> `dlgProfilePreferences::slot_tabChanged(...)` * `dlgProfilePreferences::slot_passwords_location_changed(...)` ==> `dlgProfilePreferences::slot_passwordStorageLocationChanged(...)` * `dlgProfilePreferences::slot_save_and_exit()` ==> `dlgProfilePreferences::slot_saveAndClose()` * `dlgTriggerEditor::slot_toggleHiddenVar(...)` ==> `dlgTriggerEditor::slot_hideVariable(...)` - changed to distinguish it from `slot_toggleHiddenVariables(...)` * `dlgTriggerEditor::slot_item_selected_save(...)` ==> `dlgTriggerEditor::slot_saveSelectedItem(...)` * `mudlet::slot_discord()` ==> `mudlet::slot_profileDiscord()` - changed to distinguish it from `slot_mudletDiscord()` Not currently used and commented out: * `dlgProfilePreferences::setCommandLineFont()` ==> `dlgProfilePreferences::slot_setCommandLineFont()` Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-08-29 14:27:13 +02:00
void dlgConnectionProfiles::slot_profileContextMenu(QPoint pos)
New feature: Set custom icons in profiles list (#2814)
2019-07-25 16:59:16 +02:00
{
Fix three crashes in the game selection screen (#9702) #### Brief overview of PR changes/additions - **Right-clicking the games list with nothing selected killed Mudlet.** `dlgConnectionProfiles::slot_profileContextMenu()` dereferenced `currentItem()` unguarded. That line is byte-identical in 4.22.0, so the null deref itself is long-standing and latent - what is new is that it became reachable: "improve: split the games list into My games and All games tabs" (#9452) leaves a user with no saved profiles an empty but still right-clickable "My games" tab, a state 4.22.0's always-populated list never had. About 40 seconds into a fresh install. - **Copying a profile while the list was rebuilt was a use-after-free.** The copy runs on a thread pool and its completion handler kept the `QListWidgetItem*` it had made; clicking the other games tab meanwhile calls `fillout_form()`, which destroys every item. The handler now finds the copy by name, and the `QFutureWatcher` is parented so it cannot outlive the dialog. - **Quitting before the connection dialog had been shown dereferenced null.** The queued `0ms` lambda in `mudlet::slot_showConnectionDialog()` used `mpConnectionDialog`, which `mudlet::closeEvent()` closes (it is `WA_DeleteOnClose`) and clears. #### Motivation for adding to Mudlet All three came out of the 5.0 QA sweep and are confirmed with AddressSanitizer. The first is the serious one - it is the default state of a brand-new install, so a new user can lose Mudlet before they have connected to anything. Scope note on the third: it is **not** a 5.0 regression. It has been there since "Fix: Improve tab indicators and detached window UX" (#7965) and is unchanged in 4.22.0; #9493 only turned the literal `0` into `0ms`. Nor could I reach it by clicking: I drove *Games -> Close profile* followed by quitting at six delays from 0 to 2000 ms and the dialog was always painted first. It reproduces deterministically in-process, and QA reproduced it 2/2 driving the close from Lua. Worth guarding - the pointer is documented to go null - but latent rather than routinely hit. #### Other info (issues closed, discussion etc) Test case: `ctest -R ConnectionDialogCrashTest` - with the fix reverted, four of its tests reproduce the original ASan reports exactly (two SEGVs in `slot_profileContextMenu`, a heap-use-after-free in `slot_itemClicked`, the SEGV in `QWidget::show()` from the lambda); two more are controls that pass either way, one of them pinning that the menu still opens for a selected profile so the guard cannot degenerate into an unconditional early return. Full suite 79/79. Assisted-by: Claude:claude-opus-5
2026-08-07 10:14:30 +02:00
// "My games" on a fresh install lists nothing, so nothing is current
const auto profileName = selectedProfileName();
if (profileName.isEmpty()) {
return;
}
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
const QPoint globalPos = listWidget_profiles->mapToGlobal(pos);
New feature: Set custom icons in profiles list (#2814)
2019-07-25 16:59:16 +02:00
QMenu menu;
if (hasCustomIcon(profileName)) {
Infrastructure: update tr() annotation style (#6862) #### Brief overview of PR changes/additions Update the tr() annotation style, as discussed in #5522 #### Motivation for adding to Mudlet Makes the code cleaner and also keeps Mudlet in tune with the latest standards. #### Other info (issues closed, discussion etc) /claim #5522 --------- Co-authored-by: TachyonicBytes <support@tachyonicbytes.com> Co-authored-by: Stephen Lyons <slysven@virginmedia.com>
2023-05-29 22:03:34 +03:00
//: Reset the custom picture for this profile in the connection dialog and show the default one instead
menu.addAction(tr("Reset icon"), this, &dlgConnectionProfiles::slot_resetCustomIcon);
New feature: Set custom icons in profiles list (#2814)
2019-07-25 16:59:16 +02:00
} else {
Add ability to define custom color in profile buttons in connection dialog (#5365)
2021-08-13 07:22:24 +02:00
menu.addAction(QIcon(":/icons/mudlet_main_16px.png"),
Infrastructure: update tr() annotation style (#6862) #### Brief overview of PR changes/additions Update the tr() annotation style, as discussed in #5522 #### Motivation for adding to Mudlet Makes the code cleaner and also keeps Mudlet in tune with the latest standards. #### Other info (issues closed, discussion etc) /claim #5522 --------- Co-authored-by: TachyonicBytes <support@tachyonicbytes.com> Co-authored-by: Stephen Lyons <slysven@virginmedia.com>
2023-05-29 22:03:34 +03:00
//: Set a custom picture to show for the profile in the connection dialog
tr("Set custom icon"),
Add ability to define custom color in profile buttons in connection dialog (#5365)
2021-08-13 07:22:24 +02:00
this,
Infrastructure: tidy up naming of SLOT methods and their usage - Part 5 (last) (#6266) When Qt's slot/signal system is used to invoke a method there is some overhead - so it makes sense to ensure developers can spot all such methods (functions). We have tried to do this with a `slot_` prefix to the methods we create but it has not been applied uniformly. This PR is intended to conclude helping with this by more rigorously doing so - the names changed herein should all follow a `slot_`*camelCaseMethodName* style. In addition some methods were detected that are not currently used or which are not actually used via the signal/slot system, these have been commented out or have had the prefix removed and the declaration in the relevant header file moved as appropriate. There were two similar sets of (not prefixed with `slot_`) slots in the Profile preferences class that adjusted the colour settings separately for the main console and the mapper the latter had the same names but with a `2` suffix. To made it more clear I have changed them to include `Map` in their names instead. Also, the NON-slot method: `(void) dlgProfilePreferences::setColor(QPushButton*, QColor&, bool)` has been renamed to: `(void) dlgProfilePreferences::setButtonAndProfileColor(QPushButton*, QColor&, bool)` so that it is clearly distinguishable from built in Qt methods that are also called `setColor` - though which do have different signatures! For reference the changes made are: * `TConsole::slot_stop_all_triggers(...)` ==> `TConsole::slot_stopAllItems(...)` * `dlgConnectionProfiles::slot_copy_profile()` ==> `dlgConnectionProfiles::slot_copyProfile()` * `dlgConnectionProfiles::slot_copy_profilesettings_only()` ==> `dlgConnectionProfiles::slot_copyOnlySettingsOfProfile()` * `dlgConnectionProfiles::slot_deleteprofile_check(...)` ==> `dlgConnectionProfiles::slot_deleteProfileCheck(...)` * `dlgConnectionProfiles::slot_password_deleted(...)` ==> `dlgConnectionProfiles::slot_passwordDeleted(...)` * `dlgConnectionProfiles::slot_password_saved(...) ==> `dlgConnectionProfiles::slot_passwordSaved(...)` * `dlgConnectionProfiles::slot_profile_menu(...)` ==> `dlgConnectionProfiles::slot_profileContextMenu(...)` * `dlgConnectionProfiles::slot_reset_custom_icon()` ==> `dlgConnectionProfiles::slot_resetCustomIcon()` * `dlgConnectionProfiles::slot_set_custom_icon()` ==> `dlgConnectionProfiles::slot_setCustomIcon()` * `dlgConnectionProfiles::slot_set_custom_color()` ==> `dlgConnectionProfiles::slot_setCustomColor()` * `dlgConnectionProfiles::slot_update_autologin(...)` ==> `dlgConnectionProfiles::slot_updateAutoConnect(...)` * `dlgConnectionProfiles::slot_update_autoreconnect(...)` ==> `dlgConnectionProfiles::slot_updateAutoReconnect(...)` * `dlgConnectionProfiles::slot_update_description()` ==> `dlgConnectionProfiles::slot_updateDescription()` * `dlgConnectionProfiles::slot_update_discord_optin(...)` ==> `dlgConnectionProfiles::slot_updateDiscordOptIn(...)` * `dlgProfilePreferences::copyMap()` ==> `dlgProfilePreferences::slot_copyMap()` * `dlgProfilePreferences::downloadMap()` ==> `dlgProfilePreferences::slot_downloadMap()` * `dlgProfilePreferences::hideActionLabel()` ==> `dlgProfilePreferences::slot_hideActionLabel()` * `dlgProfilePreferences::loadMap()` ==> `dlgProfilePreferences::slot_loadMap()` * `dlgProfilePreferences::resetColors()` ==> `dlgProfilePreferences::slot_resetColors()` * `dlgProfilePreferences::resetColors2()` ==> `dlgProfilePreferences::slot_resetMapColors()` * `dlgProfilePreferences::saveMap()` ==> `dlgProfilePreferences::slot_saveMap()` * `dlgProfilePreferences::setBgColor()` ==> `dlgProfilePreferences::slot_setBgColor()` * `dlgProfilePreferences::setBgColor2()` ==> `dlgProfilePreferences::slot_setMapBgColor()` * `dlgProfilePreferences::setColorBlack()` ==> `dlgProfilePreferences::slot_setColorBlack()` * `dlgProfilePreferences::setColorBlack2()` ==> `dlgProfilePreferences::slot_setMapColorBlack()` * `dlgProfilePreferences::setColorBlue()` ==> `dlgProfilePreferences::slot_setColorBlue()` * `dlgProfilePreferences::setColorCyan()` ==> `dlgProfilePreferences::slot_setColorCyan()` * `dlgProfilePreferences::setColorBlue2()` ==> `dlgProfilePreferences::slot_setMapColorBlue()` * `dlgProfilePreferences::setColorCyan2()` ==> `dlgProfilePreferences::slot_setMapColorCyan()` * `dlgProfilePreferences::setColorGreen()` ==> `dlgProfilePreferences::slot_setColorGreen()` * `dlgProfilePreferences::setColorGreen2()` ==> `dlgProfilePreferences::slot_setMapColorGreen()` * `dlgProfilePreferences::setColorLightBlack()` ==> `dlgProfilePreferences::slot_setColorLightBlack()` * `dlgProfilePreferences::setColorLightBlack2()` ==> `dlgProfilePreferences::slot_setMapColorLightBlack()` * `dlgProfilePreferences::setColorLightBlue()` ==> `dlgProfilePreferences::slot_setColorLightBlue()` * `dlgProfilePreferences::setColorLightBlue2()` ==> `dlgProfilePreferences::slot_setMapColorLightBlue()` * `dlgProfilePreferences::setColorLightCyan()` ==> `dlgProfilePreferences::slot_setColorLightCyan()` * `dlgProfilePreferences::setColorLightCyan2()` ==> `dlgProfilePreferences::slot_setMapColorLightCyan()` * `dlgProfilePreferences::setColorLightGreen()` ==> `dlgProfilePreferences::slot_setColorLightGreen()` * `dlgProfilePreferences::setColorLightGreen2()` ==> `dlgProfilePreferences::slot_setMapColorLightGreen()` * `dlgProfilePreferences::setColorLightMagenta()` ==> `dlgProfilePreferences::slot_setColorLightMagenta()` * `dlgProfilePreferences::setColorLightMagenta2()` ==> `dlgProfilePreferences::slot_setMapColorLightMagenta()` * `dlgProfilePreferences::setColorLightRed()` ==> `dlgProfilePreferences::slot_setColorLightRed()` * `dlgProfilePreferences::setColorLightRed2()` ==> `dlgProfilePreferences::slot_setMapColorLightRed()` * `dlgProfilePreferences::setColorLightWhite()` ==> `dlgProfilePreferences::slot_setColorLightWhite()` * `dlgProfilePreferences::setColorLightWhite2()` ==> `dlgProfilePreferences::slot_setMapColorLightWhite()` * `dlgProfilePreferences::setColorLightYellow()` ==> `dlgProfilePreferences::slot_setColorLightYellow()` * `dlgProfilePreferences::setColorLightYellow2()` ==> `dlgProfilePreferences::slot_setMapColorLightYellow()` * `dlgProfilePreferences::setColorMagenta()` ==> `dlgProfilePreferences::slot_setColorMagenta()` * `dlgProfilePreferences::setColorMagenta2()` ==> `dlgProfilePreferences::slot_setMapColorMagenta()` * `dlgProfilePreferences::setColorRed2()` ==> `dlgProfilePreferences::slot_setMapColorRed()` * `dlgProfilePreferences::setColorRed()` ==> `dlgProfilePreferences::slot_setColorRed()` * `dlgProfilePreferences::setColorWhite()` ==> `dlgProfilePreferences::slot_setColorWhite()` * `dlgProfilePreferences::setColorWhite2()` ==> `dlgProfilePreferences::slot_setMapColorWhite()` * `dlgProfilePreferences::setColorYellow()` ==> `dlgProfilePreferences::slot_setColorYellow()` * `dlgProfilePreferences::setColorYellow2()` ==> `dlgProfilePreferences::slot_setMapColorYellow()` * `dlgProfilePreferences::setCommandBgColor()` ==> `dlgProfilePreferences::slot_setCommandBgColor()` * `dlgProfilePreferences::setCommandFgColor()` ==> `dlgProfilePreferences::slot_setCommandFgColor()` * `dlgProfilePreferences::setCommandLineBgColor()` ==> `dlgProfilePreferences::slot_setCommandLineBgColor()` * `dlgProfilePreferences::setCommandLineFgColor()` ==> `dlgProfilePreferences::slot_setCommandLineFgColor()` * `dlgProfilePreferences::setDisplayFont()` ==> `dlgProfilePreferences::slot_setDisplayFont()` * `dlgProfilePreferences::setFgColor()` ==> `dlgProfilePreferences::slot_setFgColor()` * `dlgProfilePreferences::setFgColor2()` ==> `dlgProfilePreferences::slot_setMapExitsColor()` * `dlgProfilePreferences::setFontSize()` ==> `dlgProfilePreferences::slot_setFontSize()` * `dlgProfilePreferences::setMapInfoBackground()` ==> `dlgProfilePreferences::slot_setMapInfoBgColor()` * `dlgProfilePreferences::setRoomBorderColor()` ==> `dlgProfilePreferences::slot_setMapRoomBorderColor()` * `dlgProfilePreferences::slot_script_selected(...)` ==> `dlgProfilePreferences::slot_scriptSelected(...)` * `dlgProfilePreferences::slot_theme_selected(...)` ==> `dlgProfilePreferences::slot_themeSelected(...)` * `dlgRoomSymbol::colorRejected()` ==> `dlgRoomSymbol::slot_colorRejected()` * `dlgRoomSymbol::colorSelected(...)` ==> `dlgRoomSymbol::slot_colorSelected(...)` * `dlgRoomSymbol::currentColorChanged(...)` ==> `dlgRoomSymbol::slot_currentColorChanged(...)` * `dlgRoomSymbol::openColorSelector()` ==> `dlgRoomSymbol::slot_openColorSelector()` * `dlgRoomSymbol::resetColor()` ==> `dlgRoomSymbol::slot_resetColors()` * `dlgRoomSymbol::updatePreview()` ==> `dlgRoomSymbol::slot_updatePreview()` * `dlgTriggerEditor::slot_show_vars()` ==> `dlgTriggerEditor::slot_showVariables()` * `dlgTriggerEditor::slot_var_changed(...)` ==> `dlgTriggerEditor::slot_variableChanged(...)` * `dlgTriggerEditor::slot_var_selected(...)` ==> `dlgTriggerEditor::slot_variableSelected(...)` * `mudlet::slot_check_manual_update()` ==> `mudlet::slot_manualUpdateCheck()` * `mudlet::slot_close_current_profile()` ==> `mudlet::slot_closeCurrentProfile()` * `mudlet::slot_close_profile_requested(...)` ==> `mudlet::slot_closeProfileRequested(...)` * `mudlet::slot_connection_dlg_finished(...)` ==> `mudlet::slot_connectionDialogueFinished(...)` * `mudlet::slot_module_manager()` ==> `mudlet::slot_moduleManager()` * `mudlet::slot_mudlet_discord()` ==> `mudlet::slot_mudletDiscord()` * `mudlet::slot_multi_view(...)` ==> `mudlet::slot_multiView(const bool state)` * `mudlet::slot_package_manager()` ==> `mudlet::slot_packageManager()` * `mudlet::slot_package_exporter()` ==> `mudlet::slot_packageExporter()` * `mudlet::slot_timer_fires()` ==> `mudlet::slot_timerFires()` * `mudlet::slot_toggle_multi_view()` ==> `mudlet::slot_toggleMultiView()` Also the names for these in particular have been changed to make more sense: * `dlgProfilePreferences::slot_chooseProfilesChanged()` ==> `dlgProfilePreferences::slot_chosenProfilesChanged()` * `dlgProfilePreferences::slot_editor_tab_selected(...)` ==> `dlgProfilePreferences::slot_tabChanged(...)` * `dlgProfilePreferences::slot_passwords_location_changed(...)` ==> `dlgProfilePreferences::slot_passwordStorageLocationChanged(...)` * `dlgProfilePreferences::slot_save_and_exit()` ==> `dlgProfilePreferences::slot_saveAndClose()` * `dlgTriggerEditor::slot_toggleHiddenVar(...)` ==> `dlgTriggerEditor::slot_hideVariable(...)` - changed to distinguish it from `slot_toggleHiddenVariables(...)` * `dlgTriggerEditor::slot_item_selected_save(...)` ==> `dlgTriggerEditor::slot_saveSelectedItem(...)` * `mudlet::slot_discord()` ==> `mudlet::slot_profileDiscord()` - changed to distinguish it from `slot_mudletDiscord()` Not currently used and commented out: * `dlgProfilePreferences::setCommandLineFont()` ==> `dlgProfilePreferences::slot_setCommandLineFont()` Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-08-29 14:27:13 +02:00
&dlgConnectionProfiles::slot_setCustomIcon);
Add ability to define custom color in profile buttons in connection dialog (#5365)
2021-08-13 07:22:24 +02:00
menu.addAction(QIcon(":/icons/mudlet_main_16px.png"),
Infrastructure: update tr() annotation style (#6862) #### Brief overview of PR changes/additions Update the tr() annotation style, as discussed in #5522 #### Motivation for adding to Mudlet Makes the code cleaner and also keeps Mudlet in tune with the latest standards. #### Other info (issues closed, discussion etc) /claim #5522 --------- Co-authored-by: TachyonicBytes <support@tachyonicbytes.com> Co-authored-by: Stephen Lyons <slysven@virginmedia.com>
2023-05-29 22:03:34 +03:00
//: Set a custom color to show for the profile in the connection dialog
tr("Set custom color"),
Add ability to define custom color in profile buttons in connection dialog (#5365)
2021-08-13 07:22:24 +02:00
this,
Infrastructure: tidy up naming of SLOT methods and their usage - Part 5 (last) (#6266) When Qt's slot/signal system is used to invoke a method there is some overhead - so it makes sense to ensure developers can spot all such methods (functions). We have tried to do this with a `slot_` prefix to the methods we create but it has not been applied uniformly. This PR is intended to conclude helping with this by more rigorously doing so - the names changed herein should all follow a `slot_`*camelCaseMethodName* style. In addition some methods were detected that are not currently used or which are not actually used via the signal/slot system, these have been commented out or have had the prefix removed and the declaration in the relevant header file moved as appropriate. There were two similar sets of (not prefixed with `slot_`) slots in the Profile preferences class that adjusted the colour settings separately for the main console and the mapper the latter had the same names but with a `2` suffix. To made it more clear I have changed them to include `Map` in their names instead. Also, the NON-slot method: `(void) dlgProfilePreferences::setColor(QPushButton*, QColor&, bool)` has been renamed to: `(void) dlgProfilePreferences::setButtonAndProfileColor(QPushButton*, QColor&, bool)` so that it is clearly distinguishable from built in Qt methods that are also called `setColor` - though which do have different signatures! For reference the changes made are: * `TConsole::slot_stop_all_triggers(...)` ==> `TConsole::slot_stopAllItems(...)` * `dlgConnectionProfiles::slot_copy_profile()` ==> `dlgConnectionProfiles::slot_copyProfile()` * `dlgConnectionProfiles::slot_copy_profilesettings_only()` ==> `dlgConnectionProfiles::slot_copyOnlySettingsOfProfile()` * `dlgConnectionProfiles::slot_deleteprofile_check(...)` ==> `dlgConnectionProfiles::slot_deleteProfileCheck(...)` * `dlgConnectionProfiles::slot_password_deleted(...)` ==> `dlgConnectionProfiles::slot_passwordDeleted(...)` * `dlgConnectionProfiles::slot_password_saved(...) ==> `dlgConnectionProfiles::slot_passwordSaved(...)` * `dlgConnectionProfiles::slot_profile_menu(...)` ==> `dlgConnectionProfiles::slot_profileContextMenu(...)` * `dlgConnectionProfiles::slot_reset_custom_icon()` ==> `dlgConnectionProfiles::slot_resetCustomIcon()` * `dlgConnectionProfiles::slot_set_custom_icon()` ==> `dlgConnectionProfiles::slot_setCustomIcon()` * `dlgConnectionProfiles::slot_set_custom_color()` ==> `dlgConnectionProfiles::slot_setCustomColor()` * `dlgConnectionProfiles::slot_update_autologin(...)` ==> `dlgConnectionProfiles::slot_updateAutoConnect(...)` * `dlgConnectionProfiles::slot_update_autoreconnect(...)` ==> `dlgConnectionProfiles::slot_updateAutoReconnect(...)` * `dlgConnectionProfiles::slot_update_description()` ==> `dlgConnectionProfiles::slot_updateDescription()` * `dlgConnectionProfiles::slot_update_discord_optin(...)` ==> `dlgConnectionProfiles::slot_updateDiscordOptIn(...)` * `dlgProfilePreferences::copyMap()` ==> `dlgProfilePreferences::slot_copyMap()` * `dlgProfilePreferences::downloadMap()` ==> `dlgProfilePreferences::slot_downloadMap()` * `dlgProfilePreferences::hideActionLabel()` ==> `dlgProfilePreferences::slot_hideActionLabel()` * `dlgProfilePreferences::loadMap()` ==> `dlgProfilePreferences::slot_loadMap()` * `dlgProfilePreferences::resetColors()` ==> `dlgProfilePreferences::slot_resetColors()` * `dlgProfilePreferences::resetColors2()` ==> `dlgProfilePreferences::slot_resetMapColors()` * `dlgProfilePreferences::saveMap()` ==> `dlgProfilePreferences::slot_saveMap()` * `dlgProfilePreferences::setBgColor()` ==> `dlgProfilePreferences::slot_setBgColor()` * `dlgProfilePreferences::setBgColor2()` ==> `dlgProfilePreferences::slot_setMapBgColor()` * `dlgProfilePreferences::setColorBlack()` ==> `dlgProfilePreferences::slot_setColorBlack()` * `dlgProfilePreferences::setColorBlack2()` ==> `dlgProfilePreferences::slot_setMapColorBlack()` * `dlgProfilePreferences::setColorBlue()` ==> `dlgProfilePreferences::slot_setColorBlue()` * `dlgProfilePreferences::setColorCyan()` ==> `dlgProfilePreferences::slot_setColorCyan()` * `dlgProfilePreferences::setColorBlue2()` ==> `dlgProfilePreferences::slot_setMapColorBlue()` * `dlgProfilePreferences::setColorCyan2()` ==> `dlgProfilePreferences::slot_setMapColorCyan()` * `dlgProfilePreferences::setColorGreen()` ==> `dlgProfilePreferences::slot_setColorGreen()` * `dlgProfilePreferences::setColorGreen2()` ==> `dlgProfilePreferences::slot_setMapColorGreen()` * `dlgProfilePreferences::setColorLightBlack()` ==> `dlgProfilePreferences::slot_setColorLightBlack()` * `dlgProfilePreferences::setColorLightBlack2()` ==> `dlgProfilePreferences::slot_setMapColorLightBlack()` * `dlgProfilePreferences::setColorLightBlue()` ==> `dlgProfilePreferences::slot_setColorLightBlue()` * `dlgProfilePreferences::setColorLightBlue2()` ==> `dlgProfilePreferences::slot_setMapColorLightBlue()` * `dlgProfilePreferences::setColorLightCyan()` ==> `dlgProfilePreferences::slot_setColorLightCyan()` * `dlgProfilePreferences::setColorLightCyan2()` ==> `dlgProfilePreferences::slot_setMapColorLightCyan()` * `dlgProfilePreferences::setColorLightGreen()` ==> `dlgProfilePreferences::slot_setColorLightGreen()` * `dlgProfilePreferences::setColorLightGreen2()` ==> `dlgProfilePreferences::slot_setMapColorLightGreen()` * `dlgProfilePreferences::setColorLightMagenta()` ==> `dlgProfilePreferences::slot_setColorLightMagenta()` * `dlgProfilePreferences::setColorLightMagenta2()` ==> `dlgProfilePreferences::slot_setMapColorLightMagenta()` * `dlgProfilePreferences::setColorLightRed()` ==> `dlgProfilePreferences::slot_setColorLightRed()` * `dlgProfilePreferences::setColorLightRed2()` ==> `dlgProfilePreferences::slot_setMapColorLightRed()` * `dlgProfilePreferences::setColorLightWhite()` ==> `dlgProfilePreferences::slot_setColorLightWhite()` * `dlgProfilePreferences::setColorLightWhite2()` ==> `dlgProfilePreferences::slot_setMapColorLightWhite()` * `dlgProfilePreferences::setColorLightYellow()` ==> `dlgProfilePreferences::slot_setColorLightYellow()` * `dlgProfilePreferences::setColorLightYellow2()` ==> `dlgProfilePreferences::slot_setMapColorLightYellow()` * `dlgProfilePreferences::setColorMagenta()` ==> `dlgProfilePreferences::slot_setColorMagenta()` * `dlgProfilePreferences::setColorMagenta2()` ==> `dlgProfilePreferences::slot_setMapColorMagenta()` * `dlgProfilePreferences::setColorRed2()` ==> `dlgProfilePreferences::slot_setMapColorRed()` * `dlgProfilePreferences::setColorRed()` ==> `dlgProfilePreferences::slot_setColorRed()` * `dlgProfilePreferences::setColorWhite()` ==> `dlgProfilePreferences::slot_setColorWhite()` * `dlgProfilePreferences::setColorWhite2()` ==> `dlgProfilePreferences::slot_setMapColorWhite()` * `dlgProfilePreferences::setColorYellow()` ==> `dlgProfilePreferences::slot_setColorYellow()` * `dlgProfilePreferences::setColorYellow2()` ==> `dlgProfilePreferences::slot_setMapColorYellow()` * `dlgProfilePreferences::setCommandBgColor()` ==> `dlgProfilePreferences::slot_setCommandBgColor()` * `dlgProfilePreferences::setCommandFgColor()` ==> `dlgProfilePreferences::slot_setCommandFgColor()` * `dlgProfilePreferences::setCommandLineBgColor()` ==> `dlgProfilePreferences::slot_setCommandLineBgColor()` * `dlgProfilePreferences::setCommandLineFgColor()` ==> `dlgProfilePreferences::slot_setCommandLineFgColor()` * `dlgProfilePreferences::setDisplayFont()` ==> `dlgProfilePreferences::slot_setDisplayFont()` * `dlgProfilePreferences::setFgColor()` ==> `dlgProfilePreferences::slot_setFgColor()` * `dlgProfilePreferences::setFgColor2()` ==> `dlgProfilePreferences::slot_setMapExitsColor()` * `dlgProfilePreferences::setFontSize()` ==> `dlgProfilePreferences::slot_setFontSize()` * `dlgProfilePreferences::setMapInfoBackground()` ==> `dlgProfilePreferences::slot_setMapInfoBgColor()` * `dlgProfilePreferences::setRoomBorderColor()` ==> `dlgProfilePreferences::slot_setMapRoomBorderColor()` * `dlgProfilePreferences::slot_script_selected(...)` ==> `dlgProfilePreferences::slot_scriptSelected(...)` * `dlgProfilePreferences::slot_theme_selected(...)` ==> `dlgProfilePreferences::slot_themeSelected(...)` * `dlgRoomSymbol::colorRejected()` ==> `dlgRoomSymbol::slot_colorRejected()` * `dlgRoomSymbol::colorSelected(...)` ==> `dlgRoomSymbol::slot_colorSelected(...)` * `dlgRoomSymbol::currentColorChanged(...)` ==> `dlgRoomSymbol::slot_currentColorChanged(...)` * `dlgRoomSymbol::openColorSelector()` ==> `dlgRoomSymbol::slot_openColorSelector()` * `dlgRoomSymbol::resetColor()` ==> `dlgRoomSymbol::slot_resetColors()` * `dlgRoomSymbol::updatePreview()` ==> `dlgRoomSymbol::slot_updatePreview()` * `dlgTriggerEditor::slot_show_vars()` ==> `dlgTriggerEditor::slot_showVariables()` * `dlgTriggerEditor::slot_var_changed(...)` ==> `dlgTriggerEditor::slot_variableChanged(...)` * `dlgTriggerEditor::slot_var_selected(...)` ==> `dlgTriggerEditor::slot_variableSelected(...)` * `mudlet::slot_check_manual_update()` ==> `mudlet::slot_manualUpdateCheck()` * `mudlet::slot_close_current_profile()` ==> `mudlet::slot_closeCurrentProfile()` * `mudlet::slot_close_profile_requested(...)` ==> `mudlet::slot_closeProfileRequested(...)` * `mudlet::slot_connection_dlg_finished(...)` ==> `mudlet::slot_connectionDialogueFinished(...)` * `mudlet::slot_module_manager()` ==> `mudlet::slot_moduleManager()` * `mudlet::slot_mudlet_discord()` ==> `mudlet::slot_mudletDiscord()` * `mudlet::slot_multi_view(...)` ==> `mudlet::slot_multiView(const bool state)` * `mudlet::slot_package_manager()` ==> `mudlet::slot_packageManager()` * `mudlet::slot_package_exporter()` ==> `mudlet::slot_packageExporter()` * `mudlet::slot_timer_fires()` ==> `mudlet::slot_timerFires()` * `mudlet::slot_toggle_multi_view()` ==> `mudlet::slot_toggleMultiView()` Also the names for these in particular have been changed to make more sense: * `dlgProfilePreferences::slot_chooseProfilesChanged()` ==> `dlgProfilePreferences::slot_chosenProfilesChanged()` * `dlgProfilePreferences::slot_editor_tab_selected(...)` ==> `dlgProfilePreferences::slot_tabChanged(...)` * `dlgProfilePreferences::slot_passwords_location_changed(...)` ==> `dlgProfilePreferences::slot_passwordStorageLocationChanged(...)` * `dlgProfilePreferences::slot_save_and_exit()` ==> `dlgProfilePreferences::slot_saveAndClose()` * `dlgTriggerEditor::slot_toggleHiddenVar(...)` ==> `dlgTriggerEditor::slot_hideVariable(...)` - changed to distinguish it from `slot_toggleHiddenVariables(...)` * `dlgTriggerEditor::slot_item_selected_save(...)` ==> `dlgTriggerEditor::slot_saveSelectedItem(...)` * `mudlet::slot_discord()` ==> `mudlet::slot_profileDiscord()` - changed to distinguish it from `slot_mudletDiscord()` Not currently used and commented out: * `dlgProfilePreferences::setCommandLineFont()` ==> `dlgProfilePreferences::slot_setCommandLineFont()` Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-08-29 14:27:13 +02:00
&dlgConnectionProfiles::slot_setCustomColor);
New feature: Set custom icons in profiles list (#2814)
2019-07-25 16:59:16 +02:00
}
menu.exec(globalPos);
}
Infrastructure: tidy up naming of SLOT methods and their usage - Part 5 (last) (#6266) When Qt's slot/signal system is used to invoke a method there is some overhead - so it makes sense to ensure developers can spot all such methods (functions). We have tried to do this with a `slot_` prefix to the methods we create but it has not been applied uniformly. This PR is intended to conclude helping with this by more rigorously doing so - the names changed herein should all follow a `slot_`*camelCaseMethodName* style. In addition some methods were detected that are not currently used or which are not actually used via the signal/slot system, these have been commented out or have had the prefix removed and the declaration in the relevant header file moved as appropriate. There were two similar sets of (not prefixed with `slot_`) slots in the Profile preferences class that adjusted the colour settings separately for the main console and the mapper the latter had the same names but with a `2` suffix. To made it more clear I have changed them to include `Map` in their names instead. Also, the NON-slot method: `(void) dlgProfilePreferences::setColor(QPushButton*, QColor&, bool)` has been renamed to: `(void) dlgProfilePreferences::setButtonAndProfileColor(QPushButton*, QColor&, bool)` so that it is clearly distinguishable from built in Qt methods that are also called `setColor` - though which do have different signatures! For reference the changes made are: * `TConsole::slot_stop_all_triggers(...)` ==> `TConsole::slot_stopAllItems(...)` * `dlgConnectionProfiles::slot_copy_profile()` ==> `dlgConnectionProfiles::slot_copyProfile()` * `dlgConnectionProfiles::slot_copy_profilesettings_only()` ==> `dlgConnectionProfiles::slot_copyOnlySettingsOfProfile()` * `dlgConnectionProfiles::slot_deleteprofile_check(...)` ==> `dlgConnectionProfiles::slot_deleteProfileCheck(...)` * `dlgConnectionProfiles::slot_password_deleted(...)` ==> `dlgConnectionProfiles::slot_passwordDeleted(...)` * `dlgConnectionProfiles::slot_password_saved(...) ==> `dlgConnectionProfiles::slot_passwordSaved(...)` * `dlgConnectionProfiles::slot_profile_menu(...)` ==> `dlgConnectionProfiles::slot_profileContextMenu(...)` * `dlgConnectionProfiles::slot_reset_custom_icon()` ==> `dlgConnectionProfiles::slot_resetCustomIcon()` * `dlgConnectionProfiles::slot_set_custom_icon()` ==> `dlgConnectionProfiles::slot_setCustomIcon()` * `dlgConnectionProfiles::slot_set_custom_color()` ==> `dlgConnectionProfiles::slot_setCustomColor()` * `dlgConnectionProfiles::slot_update_autologin(...)` ==> `dlgConnectionProfiles::slot_updateAutoConnect(...)` * `dlgConnectionProfiles::slot_update_autoreconnect(...)` ==> `dlgConnectionProfiles::slot_updateAutoReconnect(...)` * `dlgConnectionProfiles::slot_update_description()` ==> `dlgConnectionProfiles::slot_updateDescription()` * `dlgConnectionProfiles::slot_update_discord_optin(...)` ==> `dlgConnectionProfiles::slot_updateDiscordOptIn(...)` * `dlgProfilePreferences::copyMap()` ==> `dlgProfilePreferences::slot_copyMap()` * `dlgProfilePreferences::downloadMap()` ==> `dlgProfilePreferences::slot_downloadMap()` * `dlgProfilePreferences::hideActionLabel()` ==> `dlgProfilePreferences::slot_hideActionLabel()` * `dlgProfilePreferences::loadMap()` ==> `dlgProfilePreferences::slot_loadMap()` * `dlgProfilePreferences::resetColors()` ==> `dlgProfilePreferences::slot_resetColors()` * `dlgProfilePreferences::resetColors2()` ==> `dlgProfilePreferences::slot_resetMapColors()` * `dlgProfilePreferences::saveMap()` ==> `dlgProfilePreferences::slot_saveMap()` * `dlgProfilePreferences::setBgColor()` ==> `dlgProfilePreferences::slot_setBgColor()` * `dlgProfilePreferences::setBgColor2()` ==> `dlgProfilePreferences::slot_setMapBgColor()` * `dlgProfilePreferences::setColorBlack()` ==> `dlgProfilePreferences::slot_setColorBlack()` * `dlgProfilePreferences::setColorBlack2()` ==> `dlgProfilePreferences::slot_setMapColorBlack()` * `dlgProfilePreferences::setColorBlue()` ==> `dlgProfilePreferences::slot_setColorBlue()` * `dlgProfilePreferences::setColorCyan()` ==> `dlgProfilePreferences::slot_setColorCyan()` * `dlgProfilePreferences::setColorBlue2()` ==> `dlgProfilePreferences::slot_setMapColorBlue()` * `dlgProfilePreferences::setColorCyan2()` ==> `dlgProfilePreferences::slot_setMapColorCyan()` * `dlgProfilePreferences::setColorGreen()` ==> `dlgProfilePreferences::slot_setColorGreen()` * `dlgProfilePreferences::setColorGreen2()` ==> `dlgProfilePreferences::slot_setMapColorGreen()` * `dlgProfilePreferences::setColorLightBlack()` ==> `dlgProfilePreferences::slot_setColorLightBlack()` * `dlgProfilePreferences::setColorLightBlack2()` ==> `dlgProfilePreferences::slot_setMapColorLightBlack()` * `dlgProfilePreferences::setColorLightBlue()` ==> `dlgProfilePreferences::slot_setColorLightBlue()` * `dlgProfilePreferences::setColorLightBlue2()` ==> `dlgProfilePreferences::slot_setMapColorLightBlue()` * `dlgProfilePreferences::setColorLightCyan()` ==> `dlgProfilePreferences::slot_setColorLightCyan()` * `dlgProfilePreferences::setColorLightCyan2()` ==> `dlgProfilePreferences::slot_setMapColorLightCyan()` * `dlgProfilePreferences::setColorLightGreen()` ==> `dlgProfilePreferences::slot_setColorLightGreen()` * `dlgProfilePreferences::setColorLightGreen2()` ==> `dlgProfilePreferences::slot_setMapColorLightGreen()` * `dlgProfilePreferences::setColorLightMagenta()` ==> `dlgProfilePreferences::slot_setColorLightMagenta()` * `dlgProfilePreferences::setColorLightMagenta2()` ==> `dlgProfilePreferences::slot_setMapColorLightMagenta()` * `dlgProfilePreferences::setColorLightRed()` ==> `dlgProfilePreferences::slot_setColorLightRed()` * `dlgProfilePreferences::setColorLightRed2()` ==> `dlgProfilePreferences::slot_setMapColorLightRed()` * `dlgProfilePreferences::setColorLightWhite()` ==> `dlgProfilePreferences::slot_setColorLightWhite()` * `dlgProfilePreferences::setColorLightWhite2()` ==> `dlgProfilePreferences::slot_setMapColorLightWhite()` * `dlgProfilePreferences::setColorLightYellow()` ==> `dlgProfilePreferences::slot_setColorLightYellow()` * `dlgProfilePreferences::setColorLightYellow2()` ==> `dlgProfilePreferences::slot_setMapColorLightYellow()` * `dlgProfilePreferences::setColorMagenta()` ==> `dlgProfilePreferences::slot_setColorMagenta()` * `dlgProfilePreferences::setColorMagenta2()` ==> `dlgProfilePreferences::slot_setMapColorMagenta()` * `dlgProfilePreferences::setColorRed2()` ==> `dlgProfilePreferences::slot_setMapColorRed()` * `dlgProfilePreferences::setColorRed()` ==> `dlgProfilePreferences::slot_setColorRed()` * `dlgProfilePreferences::setColorWhite()` ==> `dlgProfilePreferences::slot_setColorWhite()` * `dlgProfilePreferences::setColorWhite2()` ==> `dlgProfilePreferences::slot_setMapColorWhite()` * `dlgProfilePreferences::setColorYellow()` ==> `dlgProfilePreferences::slot_setColorYellow()` * `dlgProfilePreferences::setColorYellow2()` ==> `dlgProfilePreferences::slot_setMapColorYellow()` * `dlgProfilePreferences::setCommandBgColor()` ==> `dlgProfilePreferences::slot_setCommandBgColor()` * `dlgProfilePreferences::setCommandFgColor()` ==> `dlgProfilePreferences::slot_setCommandFgColor()` * `dlgProfilePreferences::setCommandLineBgColor()` ==> `dlgProfilePreferences::slot_setCommandLineBgColor()` * `dlgProfilePreferences::setCommandLineFgColor()` ==> `dlgProfilePreferences::slot_setCommandLineFgColor()` * `dlgProfilePreferences::setDisplayFont()` ==> `dlgProfilePreferences::slot_setDisplayFont()` * `dlgProfilePreferences::setFgColor()` ==> `dlgProfilePreferences::slot_setFgColor()` * `dlgProfilePreferences::setFgColor2()` ==> `dlgProfilePreferences::slot_setMapExitsColor()` * `dlgProfilePreferences::setFontSize()` ==> `dlgProfilePreferences::slot_setFontSize()` * `dlgProfilePreferences::setMapInfoBackground()` ==> `dlgProfilePreferences::slot_setMapInfoBgColor()` * `dlgProfilePreferences::setRoomBorderColor()` ==> `dlgProfilePreferences::slot_setMapRoomBorderColor()` * `dlgProfilePreferences::slot_script_selected(...)` ==> `dlgProfilePreferences::slot_scriptSelected(...)` * `dlgProfilePreferences::slot_theme_selected(...)` ==> `dlgProfilePreferences::slot_themeSelected(...)` * `dlgRoomSymbol::colorRejected()` ==> `dlgRoomSymbol::slot_colorRejected()` * `dlgRoomSymbol::colorSelected(...)` ==> `dlgRoomSymbol::slot_colorSelected(...)` * `dlgRoomSymbol::currentColorChanged(...)` ==> `dlgRoomSymbol::slot_currentColorChanged(...)` * `dlgRoomSymbol::openColorSelector()` ==> `dlgRoomSymbol::slot_openColorSelector()` * `dlgRoomSymbol::resetColor()` ==> `dlgRoomSymbol::slot_resetColors()` * `dlgRoomSymbol::updatePreview()` ==> `dlgRoomSymbol::slot_updatePreview()` * `dlgTriggerEditor::slot_show_vars()` ==> `dlgTriggerEditor::slot_showVariables()` * `dlgTriggerEditor::slot_var_changed(...)` ==> `dlgTriggerEditor::slot_variableChanged(...)` * `dlgTriggerEditor::slot_var_selected(...)` ==> `dlgTriggerEditor::slot_variableSelected(...)` * `mudlet::slot_check_manual_update()` ==> `mudlet::slot_manualUpdateCheck()` * `mudlet::slot_close_current_profile()` ==> `mudlet::slot_closeCurrentProfile()` * `mudlet::slot_close_profile_requested(...)` ==> `mudlet::slot_closeProfileRequested(...)` * `mudlet::slot_connection_dlg_finished(...)` ==> `mudlet::slot_connectionDialogueFinished(...)` * `mudlet::slot_module_manager()` ==> `mudlet::slot_moduleManager()` * `mudlet::slot_mudlet_discord()` ==> `mudlet::slot_mudletDiscord()` * `mudlet::slot_multi_view(...)` ==> `mudlet::slot_multiView(const bool state)` * `mudlet::slot_package_manager()` ==> `mudlet::slot_packageManager()` * `mudlet::slot_package_exporter()` ==> `mudlet::slot_packageExporter()` * `mudlet::slot_timer_fires()` ==> `mudlet::slot_timerFires()` * `mudlet::slot_toggle_multi_view()` ==> `mudlet::slot_toggleMultiView()` Also the names for these in particular have been changed to make more sense: * `dlgProfilePreferences::slot_chooseProfilesChanged()` ==> `dlgProfilePreferences::slot_chosenProfilesChanged()` * `dlgProfilePreferences::slot_editor_tab_selected(...)` ==> `dlgProfilePreferences::slot_tabChanged(...)` * `dlgProfilePreferences::slot_passwords_location_changed(...)` ==> `dlgProfilePreferences::slot_passwordStorageLocationChanged(...)` * `dlgProfilePreferences::slot_save_and_exit()` ==> `dlgProfilePreferences::slot_saveAndClose()` * `dlgTriggerEditor::slot_toggleHiddenVar(...)` ==> `dlgTriggerEditor::slot_hideVariable(...)` - changed to distinguish it from `slot_toggleHiddenVariables(...)` * `dlgTriggerEditor::slot_item_selected_save(...)` ==> `dlgTriggerEditor::slot_saveSelectedItem(...)` * `mudlet::slot_discord()` ==> `mudlet::slot_profileDiscord()` - changed to distinguish it from `slot_mudletDiscord()` Not currently used and commented out: * `dlgProfilePreferences::setCommandLineFont()` ==> `dlgProfilePreferences::slot_setCommandLineFont()` Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-08-29 14:27:13 +02:00
void dlgConnectionProfiles::slot_setCustomIcon()
New feature: Set custom icons in profiles list (#2814)
2019-07-25 16:59:16 +02:00
{
Fix three crashes in the game selection screen (#9702) #### Brief overview of PR changes/additions - **Right-clicking the games list with nothing selected killed Mudlet.** `dlgConnectionProfiles::slot_profileContextMenu()` dereferenced `currentItem()` unguarded. That line is byte-identical in 4.22.0, so the null deref itself is long-standing and latent - what is new is that it became reachable: "improve: split the games list into My games and All games tabs" (#9452) leaves a user with no saved profiles an empty but still right-clickable "My games" tab, a state 4.22.0's always-populated list never had. About 40 seconds into a fresh install. - **Copying a profile while the list was rebuilt was a use-after-free.** The copy runs on a thread pool and its completion handler kept the `QListWidgetItem*` it had made; clicking the other games tab meanwhile calls `fillout_form()`, which destroys every item. The handler now finds the copy by name, and the `QFutureWatcher` is parented so it cannot outlive the dialog. - **Quitting before the connection dialog had been shown dereferenced null.** The queued `0ms` lambda in `mudlet::slot_showConnectionDialog()` used `mpConnectionDialog`, which `mudlet::closeEvent()` closes (it is `WA_DeleteOnClose`) and clears. #### Motivation for adding to Mudlet All three came out of the 5.0 QA sweep and are confirmed with AddressSanitizer. The first is the serious one - it is the default state of a brand-new install, so a new user can lose Mudlet before they have connected to anything. Scope note on the third: it is **not** a 5.0 regression. It has been there since "Fix: Improve tab indicators and detached window UX" (#7965) and is unchanged in 4.22.0; #9493 only turned the literal `0` into `0ms`. Nor could I reach it by clicking: I drove *Games -> Close profile* followed by quitting at six delays from 0 to 2000 ms and the dialog was always painted first. It reproduces deterministically in-process, and QA reproduced it 2/2 driving the close from Lua. Worth guarding - the pointer is documented to go null - but latent rather than routinely hit. #### Other info (issues closed, discussion etc) Test case: `ctest -R ConnectionDialogCrashTest` - with the fix reverted, four of its tests reproduce the original ASan reports exactly (two SEGVs in `slot_profileContextMenu`, a heap-use-after-free in `slot_itemClicked`, the SEGV in `QWidget::show()` from the lambda); two more are controls that pass either way, one of them pinning that the menu still opens for a selected profile so the guard cannot degenerate into an unconditional early return. Full suite 79/79. Assisted-by: Claude:claude-opus-5
2026-08-07 10:14:30 +02:00
const auto profileName = selectedProfileName();
if (profileName.isEmpty()) {
return;
}
New feature: Set custom icons in profiles list (#2814)
2019-07-25 16:59:16 +02:00
Improve file dialogs by saving last selected location (#7515) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Add consistent file dialog opening locations across application. When a file dialog is actioned (i.e. a file chosen) save the location globally in a `QSetting` named `lastFileDialogLocation`. If this setting has not been set then fallback to default locations as discussed in #5253. #### Motivation for adding to Mudlet Consistency across the application. #### Other info (issues closed, discussion etc) closes #5253 closes #5249
2024-11-04 10:54:51 +04:00
QSettings& settings = *mudlet::getQSettings();
QString lastDir = settings.value("lastFileDialogLocation", QDir::homePath()).toString();
const QString imageLocation = QFileDialog::getOpenFileName(this, tr("Select custom image for profile (should be 120x30)"), lastDir, tr("Images (%1)").arg(qsl("*.png *.gif *.jpg")));
New feature: Set custom icons in profiles list (#2814)
2019-07-25 16:59:16 +02:00
if (imageLocation.isEmpty()) {
return;
}
Improve file dialogs by saving last selected location (#7515) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Add consistent file dialog opening locations across application. When a file dialog is actioned (i.e. a file chosen) save the location globally in a `QSetting` named `lastFileDialogLocation`. If this setting has not been set then fallback to default locations as discussed in #5253. #### Motivation for adding to Mudlet Consistency across the application. #### Other info (issues closed, discussion etc) closes #5253 closes #5249
2024-11-04 10:54:51 +04:00
lastDir = QFileInfo(imageLocation).absolutePath();
settings.setValue("lastFileDialogLocation", lastDir);
Infrastructure: mark read-only variables as const (#6843) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Mark read-only variables as const - that is, not intended to change after they've been declared #### Motivation for adding to Mudlet So we don't change them by accident later on, and also to clearly state intentions for the variables #### Other info (issues closed, discussion etc) This is also recommended by the [C++ Core Guidelines](https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#es25-declare-an-object-const-or-constexpr-unless-you-want-to-modify-its-value-later-on)
2023-05-14 15:06:15 +02:00
const bool success = mudlet::self()->setProfileIcon(profileName, imageLocation).first;
New feature: Set custom icons in profiles list (#2814)
2019-07-25 16:59:16 +02:00
if (!success) {
return;
}
auto icon = QIcon(QPixmap(imageLocation).scaled(QSize(120, 30), Qt::IgnoreAspectRatio, Qt::SmoothTransformation).copy());
Fix three crashes in the game selection screen (#9702) #### Brief overview of PR changes/additions - **Right-clicking the games list with nothing selected killed Mudlet.** `dlgConnectionProfiles::slot_profileContextMenu()` dereferenced `currentItem()` unguarded. That line is byte-identical in 4.22.0, so the null deref itself is long-standing and latent - what is new is that it became reachable: "improve: split the games list into My games and All games tabs" (#9452) leaves a user with no saved profiles an empty but still right-clickable "My games" tab, a state 4.22.0's always-populated list never had. About 40 seconds into a fresh install. - **Copying a profile while the list was rebuilt was a use-after-free.** The copy runs on a thread pool and its completion handler kept the `QListWidgetItem*` it had made; clicking the other games tab meanwhile calls `fillout_form()`, which destroys every item. The handler now finds the copy by name, and the `QFutureWatcher` is parented so it cannot outlive the dialog. - **Quitting before the connection dialog had been shown dereferenced null.** The queued `0ms` lambda in `mudlet::slot_showConnectionDialog()` used `mpConnectionDialog`, which `mudlet::closeEvent()` closes (it is `WA_DeleteOnClose`) and clears. #### Motivation for adding to Mudlet All three came out of the 5.0 QA sweep and are confirmed with AddressSanitizer. The first is the serious one - it is the default state of a brand-new install, so a new user can lose Mudlet before they have connected to anything. Scope note on the third: it is **not** a 5.0 regression. It has been there since "Fix: Improve tab indicators and detached window UX" (#7965) and is unchanged in 4.22.0; #9493 only turned the literal `0` into `0ms`. Nor could I reach it by clicking: I drove *Games -> Close profile* followed by quitting at six delays from 0 to 2000 ms and the dialog was always painted first. It reproduces deterministically in-process, and QA reproduced it 2/2 driving the close from Lua. Worth guarding - the pointer is documented to go null - but latent rather than routinely hit. #### Other info (issues closed, discussion etc) Test case: `ctest -R ConnectionDialogCrashTest` - with the fix reverted, four of its tests reproduce the original ASan reports exactly (two SEGVs in `slot_profileContextMenu`, a heap-use-after-free in `slot_itemClicked`, the SEGV in `QWidget::show()` from the lambda); two more are controls that pass either way, one of them pinning that the menu still opens for a selected profile so the guard cannot degenerate into an unconditional early return. Full suite 79/79. Assisted-by: Claude:claude-opus-5
2026-08-07 10:14:30 +02:00
// the file dialog ran a nested event loop, so the current item may have moved
setIconOfListedProfile(profileName, icon);
New feature: Set custom icons in profiles list (#2814)
2019-07-25 16:59:16 +02:00
}
Infrastructure: tidy up naming of SLOT methods and their usage - Part 5 (last) (#6266) When Qt's slot/signal system is used to invoke a method there is some overhead - so it makes sense to ensure developers can spot all such methods (functions). We have tried to do this with a `slot_` prefix to the methods we create but it has not been applied uniformly. This PR is intended to conclude helping with this by more rigorously doing so - the names changed herein should all follow a `slot_`*camelCaseMethodName* style. In addition some methods were detected that are not currently used or which are not actually used via the signal/slot system, these have been commented out or have had the prefix removed and the declaration in the relevant header file moved as appropriate. There were two similar sets of (not prefixed with `slot_`) slots in the Profile preferences class that adjusted the colour settings separately for the main console and the mapper the latter had the same names but with a `2` suffix. To made it more clear I have changed them to include `Map` in their names instead. Also, the NON-slot method: `(void) dlgProfilePreferences::setColor(QPushButton*, QColor&, bool)` has been renamed to: `(void) dlgProfilePreferences::setButtonAndProfileColor(QPushButton*, QColor&, bool)` so that it is clearly distinguishable from built in Qt methods that are also called `setColor` - though which do have different signatures! For reference the changes made are: * `TConsole::slot_stop_all_triggers(...)` ==> `TConsole::slot_stopAllItems(...)` * `dlgConnectionProfiles::slot_copy_profile()` ==> `dlgConnectionProfiles::slot_copyProfile()` * `dlgConnectionProfiles::slot_copy_profilesettings_only()` ==> `dlgConnectionProfiles::slot_copyOnlySettingsOfProfile()` * `dlgConnectionProfiles::slot_deleteprofile_check(...)` ==> `dlgConnectionProfiles::slot_deleteProfileCheck(...)` * `dlgConnectionProfiles::slot_password_deleted(...)` ==> `dlgConnectionProfiles::slot_passwordDeleted(...)` * `dlgConnectionProfiles::slot_password_saved(...) ==> `dlgConnectionProfiles::slot_passwordSaved(...)` * `dlgConnectionProfiles::slot_profile_menu(...)` ==> `dlgConnectionProfiles::slot_profileContextMenu(...)` * `dlgConnectionProfiles::slot_reset_custom_icon()` ==> `dlgConnectionProfiles::slot_resetCustomIcon()` * `dlgConnectionProfiles::slot_set_custom_icon()` ==> `dlgConnectionProfiles::slot_setCustomIcon()` * `dlgConnectionProfiles::slot_set_custom_color()` ==> `dlgConnectionProfiles::slot_setCustomColor()` * `dlgConnectionProfiles::slot_update_autologin(...)` ==> `dlgConnectionProfiles::slot_updateAutoConnect(...)` * `dlgConnectionProfiles::slot_update_autoreconnect(...)` ==> `dlgConnectionProfiles::slot_updateAutoReconnect(...)` * `dlgConnectionProfiles::slot_update_description()` ==> `dlgConnectionProfiles::slot_updateDescription()` * `dlgConnectionProfiles::slot_update_discord_optin(...)` ==> `dlgConnectionProfiles::slot_updateDiscordOptIn(...)` * `dlgProfilePreferences::copyMap()` ==> `dlgProfilePreferences::slot_copyMap()` * `dlgProfilePreferences::downloadMap()` ==> `dlgProfilePreferences::slot_downloadMap()` * `dlgProfilePreferences::hideActionLabel()` ==> `dlgProfilePreferences::slot_hideActionLabel()` * `dlgProfilePreferences::loadMap()` ==> `dlgProfilePreferences::slot_loadMap()` * `dlgProfilePreferences::resetColors()` ==> `dlgProfilePreferences::slot_resetColors()` * `dlgProfilePreferences::resetColors2()` ==> `dlgProfilePreferences::slot_resetMapColors()` * `dlgProfilePreferences::saveMap()` ==> `dlgProfilePreferences::slot_saveMap()` * `dlgProfilePreferences::setBgColor()` ==> `dlgProfilePreferences::slot_setBgColor()` * `dlgProfilePreferences::setBgColor2()` ==> `dlgProfilePreferences::slot_setMapBgColor()` * `dlgProfilePreferences::setColorBlack()` ==> `dlgProfilePreferences::slot_setColorBlack()` * `dlgProfilePreferences::setColorBlack2()` ==> `dlgProfilePreferences::slot_setMapColorBlack()` * `dlgProfilePreferences::setColorBlue()` ==> `dlgProfilePreferences::slot_setColorBlue()` * `dlgProfilePreferences::setColorCyan()` ==> `dlgProfilePreferences::slot_setColorCyan()` * `dlgProfilePreferences::setColorBlue2()` ==> `dlgProfilePreferences::slot_setMapColorBlue()` * `dlgProfilePreferences::setColorCyan2()` ==> `dlgProfilePreferences::slot_setMapColorCyan()` * `dlgProfilePreferences::setColorGreen()` ==> `dlgProfilePreferences::slot_setColorGreen()` * `dlgProfilePreferences::setColorGreen2()` ==> `dlgProfilePreferences::slot_setMapColorGreen()` * `dlgProfilePreferences::setColorLightBlack()` ==> `dlgProfilePreferences::slot_setColorLightBlack()` * `dlgProfilePreferences::setColorLightBlack2()` ==> `dlgProfilePreferences::slot_setMapColorLightBlack()` * `dlgProfilePreferences::setColorLightBlue()` ==> `dlgProfilePreferences::slot_setColorLightBlue()` * `dlgProfilePreferences::setColorLightBlue2()` ==> `dlgProfilePreferences::slot_setMapColorLightBlue()` * `dlgProfilePreferences::setColorLightCyan()` ==> `dlgProfilePreferences::slot_setColorLightCyan()` * `dlgProfilePreferences::setColorLightCyan2()` ==> `dlgProfilePreferences::slot_setMapColorLightCyan()` * `dlgProfilePreferences::setColorLightGreen()` ==> `dlgProfilePreferences::slot_setColorLightGreen()` * `dlgProfilePreferences::setColorLightGreen2()` ==> `dlgProfilePreferences::slot_setMapColorLightGreen()` * `dlgProfilePreferences::setColorLightMagenta()` ==> `dlgProfilePreferences::slot_setColorLightMagenta()` * `dlgProfilePreferences::setColorLightMagenta2()` ==> `dlgProfilePreferences::slot_setMapColorLightMagenta()` * `dlgProfilePreferences::setColorLightRed()` ==> `dlgProfilePreferences::slot_setColorLightRed()` * `dlgProfilePreferences::setColorLightRed2()` ==> `dlgProfilePreferences::slot_setMapColorLightRed()` * `dlgProfilePreferences::setColorLightWhite()` ==> `dlgProfilePreferences::slot_setColorLightWhite()` * `dlgProfilePreferences::setColorLightWhite2()` ==> `dlgProfilePreferences::slot_setMapColorLightWhite()` * `dlgProfilePreferences::setColorLightYellow()` ==> `dlgProfilePreferences::slot_setColorLightYellow()` * `dlgProfilePreferences::setColorLightYellow2()` ==> `dlgProfilePreferences::slot_setMapColorLightYellow()` * `dlgProfilePreferences::setColorMagenta()` ==> `dlgProfilePreferences::slot_setColorMagenta()` * `dlgProfilePreferences::setColorMagenta2()` ==> `dlgProfilePreferences::slot_setMapColorMagenta()` * `dlgProfilePreferences::setColorRed2()` ==> `dlgProfilePreferences::slot_setMapColorRed()` * `dlgProfilePreferences::setColorRed()` ==> `dlgProfilePreferences::slot_setColorRed()` * `dlgProfilePreferences::setColorWhite()` ==> `dlgProfilePreferences::slot_setColorWhite()` * `dlgProfilePreferences::setColorWhite2()` ==> `dlgProfilePreferences::slot_setMapColorWhite()` * `dlgProfilePreferences::setColorYellow()` ==> `dlgProfilePreferences::slot_setColorYellow()` * `dlgProfilePreferences::setColorYellow2()` ==> `dlgProfilePreferences::slot_setMapColorYellow()` * `dlgProfilePreferences::setCommandBgColor()` ==> `dlgProfilePreferences::slot_setCommandBgColor()` * `dlgProfilePreferences::setCommandFgColor()` ==> `dlgProfilePreferences::slot_setCommandFgColor()` * `dlgProfilePreferences::setCommandLineBgColor()` ==> `dlgProfilePreferences::slot_setCommandLineBgColor()` * `dlgProfilePreferences::setCommandLineFgColor()` ==> `dlgProfilePreferences::slot_setCommandLineFgColor()` * `dlgProfilePreferences::setDisplayFont()` ==> `dlgProfilePreferences::slot_setDisplayFont()` * `dlgProfilePreferences::setFgColor()` ==> `dlgProfilePreferences::slot_setFgColor()` * `dlgProfilePreferences::setFgColor2()` ==> `dlgProfilePreferences::slot_setMapExitsColor()` * `dlgProfilePreferences::setFontSize()` ==> `dlgProfilePreferences::slot_setFontSize()` * `dlgProfilePreferences::setMapInfoBackground()` ==> `dlgProfilePreferences::slot_setMapInfoBgColor()` * `dlgProfilePreferences::setRoomBorderColor()` ==> `dlgProfilePreferences::slot_setMapRoomBorderColor()` * `dlgProfilePreferences::slot_script_selected(...)` ==> `dlgProfilePreferences::slot_scriptSelected(...)` * `dlgProfilePreferences::slot_theme_selected(...)` ==> `dlgProfilePreferences::slot_themeSelected(...)` * `dlgRoomSymbol::colorRejected()` ==> `dlgRoomSymbol::slot_colorRejected()` * `dlgRoomSymbol::colorSelected(...)` ==> `dlgRoomSymbol::slot_colorSelected(...)` * `dlgRoomSymbol::currentColorChanged(...)` ==> `dlgRoomSymbol::slot_currentColorChanged(...)` * `dlgRoomSymbol::openColorSelector()` ==> `dlgRoomSymbol::slot_openColorSelector()` * `dlgRoomSymbol::resetColor()` ==> `dlgRoomSymbol::slot_resetColors()` * `dlgRoomSymbol::updatePreview()` ==> `dlgRoomSymbol::slot_updatePreview()` * `dlgTriggerEditor::slot_show_vars()` ==> `dlgTriggerEditor::slot_showVariables()` * `dlgTriggerEditor::slot_var_changed(...)` ==> `dlgTriggerEditor::slot_variableChanged(...)` * `dlgTriggerEditor::slot_var_selected(...)` ==> `dlgTriggerEditor::slot_variableSelected(...)` * `mudlet::slot_check_manual_update()` ==> `mudlet::slot_manualUpdateCheck()` * `mudlet::slot_close_current_profile()` ==> `mudlet::slot_closeCurrentProfile()` * `mudlet::slot_close_profile_requested(...)` ==> `mudlet::slot_closeProfileRequested(...)` * `mudlet::slot_connection_dlg_finished(...)` ==> `mudlet::slot_connectionDialogueFinished(...)` * `mudlet::slot_module_manager()` ==> `mudlet::slot_moduleManager()` * `mudlet::slot_mudlet_discord()` ==> `mudlet::slot_mudletDiscord()` * `mudlet::slot_multi_view(...)` ==> `mudlet::slot_multiView(const bool state)` * `mudlet::slot_package_manager()` ==> `mudlet::slot_packageManager()` * `mudlet::slot_package_exporter()` ==> `mudlet::slot_packageExporter()` * `mudlet::slot_timer_fires()` ==> `mudlet::slot_timerFires()` * `mudlet::slot_toggle_multi_view()` ==> `mudlet::slot_toggleMultiView()` Also the names for these in particular have been changed to make more sense: * `dlgProfilePreferences::slot_chooseProfilesChanged()` ==> `dlgProfilePreferences::slot_chosenProfilesChanged()` * `dlgProfilePreferences::slot_editor_tab_selected(...)` ==> `dlgProfilePreferences::slot_tabChanged(...)` * `dlgProfilePreferences::slot_passwords_location_changed(...)` ==> `dlgProfilePreferences::slot_passwordStorageLocationChanged(...)` * `dlgProfilePreferences::slot_save_and_exit()` ==> `dlgProfilePreferences::slot_saveAndClose()` * `dlgTriggerEditor::slot_toggleHiddenVar(...)` ==> `dlgTriggerEditor::slot_hideVariable(...)` - changed to distinguish it from `slot_toggleHiddenVariables(...)` * `dlgTriggerEditor::slot_item_selected_save(...)` ==> `dlgTriggerEditor::slot_saveSelectedItem(...)` * `mudlet::slot_discord()` ==> `mudlet::slot_profileDiscord()` - changed to distinguish it from `slot_mudletDiscord()` Not currently used and commented out: * `dlgProfilePreferences::setCommandLineFont()` ==> `dlgProfilePreferences::slot_setCommandLineFont()` Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-08-29 14:27:13 +02:00
void dlgConnectionProfiles::slot_setCustomColor()
Add ability to define custom color in profile buttons in connection dialog (#5365)
2021-08-13 07:22:24 +02:00
{
Fix three crashes in the game selection screen (#9702) #### Brief overview of PR changes/additions - **Right-clicking the games list with nothing selected killed Mudlet.** `dlgConnectionProfiles::slot_profileContextMenu()` dereferenced `currentItem()` unguarded. That line is byte-identical in 4.22.0, so the null deref itself is long-standing and latent - what is new is that it became reachable: "improve: split the games list into My games and All games tabs" (#9452) leaves a user with no saved profiles an empty but still right-clickable "My games" tab, a state 4.22.0's always-populated list never had. About 40 seconds into a fresh install. - **Copying a profile while the list was rebuilt was a use-after-free.** The copy runs on a thread pool and its completion handler kept the `QListWidgetItem*` it had made; clicking the other games tab meanwhile calls `fillout_form()`, which destroys every item. The handler now finds the copy by name, and the `QFutureWatcher` is parented so it cannot outlive the dialog. - **Quitting before the connection dialog had been shown dereferenced null.** The queued `0ms` lambda in `mudlet::slot_showConnectionDialog()` used `mpConnectionDialog`, which `mudlet::closeEvent()` closes (it is `WA_DeleteOnClose`) and clears. #### Motivation for adding to Mudlet All three came out of the 5.0 QA sweep and are confirmed with AddressSanitizer. The first is the serious one - it is the default state of a brand-new install, so a new user can lose Mudlet before they have connected to anything. Scope note on the third: it is **not** a 5.0 regression. It has been there since "Fix: Improve tab indicators and detached window UX" (#7965) and is unchanged in 4.22.0; #9493 only turned the literal `0` into `0ms`. Nor could I reach it by clicking: I drove *Games -> Close profile* followed by quitting at six delays from 0 to 2000 ms and the dialog was always painted first. It reproduces deterministically in-process, and QA reproduced it 2/2 driving the close from Lua. Worth guarding - the pointer is documented to go null - but latent rather than routinely hit. #### Other info (issues closed, discussion etc) Test case: `ctest -R ConnectionDialogCrashTest` - with the fix reverted, four of its tests reproduce the original ASan reports exactly (two SEGVs in `slot_profileContextMenu`, a heap-use-after-free in `slot_itemClicked`, the SEGV in `QWidget::show()` from the lambda); two more are controls that pass either way, one of them pinning that the menu still opens for a selected profile so the guard cannot degenerate into an unconditional early return. Full suite 79/79. Assisted-by: Claude:claude-opus-5
2026-08-07 10:14:30 +02:00
const auto profileName = selectedProfileName();
if (profileName.isEmpty()) {
return;
}
Add ability to define custom color in profile buttons in connection dialog (#5365)
2021-08-13 07:22:24 +02:00
QColor color = QColorDialog::getColor(getCustomColor(profileName).value_or(QColor(255, 255, 255)));
if (color.isValid()) {
Infrastructure: add `enums.h` (#7646) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Add `enums.h` where we can add enums and flags to be used throughout the application that don't have a more specific place to be, without dragging in giant classes such as mudlet.h or Host.h. Also added `enums::PackageModuleType` to track the magic numbers used throughout package/module code :rocket: #### Motivation for adding to Mudlet Simplify code organisation. #### Other info (issues closed, discussion etc) --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-01-08 10:04:50 +01:00
auto profileColorPath = mudlet::getMudletPath(enums::profileDataItemPath, profileName, qsl("profilecolor"));
Improve: save files in a more reliable manner (#6738) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Use [QSaveFile](https://doc.qt.io/qt-5/qsavefile.html) for all cases where Mudlet is writing to disk (profiles, maps, notes, ...). QSaveFile does a few things under the hood to ensure a file can be written safely, and gives a nice error if no. #### Motivation for adding to Mudlet I'm hoping this'll address some cases of folks' settings resetting or some other weird things happening - which happens once in a blue moon, but still does. Doing disk IO on scale is something that is eventually bound to run into issues, I had the same with the Svo system. Hopefully this'll cover things off. #### Other info (issues closed, discussion etc) Fix https://github.com/Mudlet/Mudlet/issues/1342 --------- Co-authored-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: SlySven <SlySven@users.noreply.github.com>
2023-04-25 19:28:34 +02:00
QSaveFile file(profileColorPath);
Infrastructure: fix Qt 6.10 compile warnings (#8115) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Fix Qt 6.10 compile warnings #### Motivation for adding to Mudlet Cleaner compiles #### Other info (issues closed, discussion etc) --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-08-28 13:02:14 +02:00
if (!file.open(QIODevice::WriteOnly | QIODevice::Text)) {
qWarning() << "dlgConnectionProfiles: failed to open profile color file for writing:" << file.errorString();
return;
}
Add ability to define custom color in profile buttons in connection dialog (#5365)
2021-08-13 07:22:24 +02:00
auto colorName = color.name();
file.write(colorName.toUtf8(), colorName.length());
Improve: save files in a more reliable manner (#6738) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Use [QSaveFile](https://doc.qt.io/qt-5/qsavefile.html) for all cases where Mudlet is writing to disk (profiles, maps, notes, ...). QSaveFile does a few things under the hood to ensure a file can be written safely, and gives a nice error if no. #### Motivation for adding to Mudlet I'm hoping this'll address some cases of folks' settings resetting or some other weird things happening - which happens once in a blue moon, but still does. Doing disk IO on scale is something that is eventually bound to run into issues, I had the same with the Svo system. Hopefully this'll cover things off. #### Other info (issues closed, discussion etc) Fix https://github.com/Mudlet/Mudlet/issues/1342 --------- Co-authored-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: SlySven <SlySven@users.noreply.github.com>
2023-04-25 19:28:34 +02:00
if (!file.commit()) {
qDebug() << "dlgConnectionProfiles::slot_setCustomColor: error saving custom icon color: " << file.errorString();
}
Fix three crashes in the game selection screen (#9702) #### Brief overview of PR changes/additions - **Right-clicking the games list with nothing selected killed Mudlet.** `dlgConnectionProfiles::slot_profileContextMenu()` dereferenced `currentItem()` unguarded. That line is byte-identical in 4.22.0, so the null deref itself is long-standing and latent - what is new is that it became reachable: "improve: split the games list into My games and All games tabs" (#9452) leaves a user with no saved profiles an empty but still right-clickable "My games" tab, a state 4.22.0's always-populated list never had. About 40 seconds into a fresh install. - **Copying a profile while the list was rebuilt was a use-after-free.** The copy runs on a thread pool and its completion handler kept the `QListWidgetItem*` it had made; clicking the other games tab meanwhile calls `fillout_form()`, which destroys every item. The handler now finds the copy by name, and the `QFutureWatcher` is parented so it cannot outlive the dialog. - **Quitting before the connection dialog had been shown dereferenced null.** The queued `0ms` lambda in `mudlet::slot_showConnectionDialog()` used `mpConnectionDialog`, which `mudlet::closeEvent()` closes (it is `WA_DeleteOnClose`) and clears. #### Motivation for adding to Mudlet All three came out of the 5.0 QA sweep and are confirmed with AddressSanitizer. The first is the serious one - it is the default state of a brand-new install, so a new user can lose Mudlet before they have connected to anything. Scope note on the third: it is **not** a 5.0 regression. It has been there since "Fix: Improve tab indicators and detached window UX" (#7965) and is unchanged in 4.22.0; #9493 only turned the literal `0` into `0ms`. Nor could I reach it by clicking: I drove *Games -> Close profile* followed by quitting at six delays from 0 to 2000 ms and the dialog was always painted first. It reproduces deterministically in-process, and QA reproduced it 2/2 driving the close from Lua. Worth guarding - the pointer is documented to go null - but latent rather than routinely hit. #### Other info (issues closed, discussion etc) Test case: `ctest -R ConnectionDialogCrashTest` - with the fix reverted, four of its tests reproduce the original ASan reports exactly (two SEGVs in `slot_profileContextMenu`, a heap-use-after-free in `slot_itemClicked`, the SEGV in `QWidget::show()` from the lambda); two more are controls that pass either way, one of them pinning that the menu still opens for a selected profile so the guard cannot degenerate into an unconditional early return. Full suite 79/79. Assisted-by: Claude:claude-opus-5
2026-08-07 10:14:30 +02:00
setIconOfListedProfile(profileName, customIcon(profileName, {color}));
Add ability to define custom color in profile buttons in connection dialog (#5365)
2021-08-13 07:22:24 +02:00
}
}
Infrastructure: tidy up naming of SLOT methods and their usage - Part 5 (last) (#6266) When Qt's slot/signal system is used to invoke a method there is some overhead - so it makes sense to ensure developers can spot all such methods (functions). We have tried to do this with a `slot_` prefix to the methods we create but it has not been applied uniformly. This PR is intended to conclude helping with this by more rigorously doing so - the names changed herein should all follow a `slot_`*camelCaseMethodName* style. In addition some methods were detected that are not currently used or which are not actually used via the signal/slot system, these have been commented out or have had the prefix removed and the declaration in the relevant header file moved as appropriate. There were two similar sets of (not prefixed with `slot_`) slots in the Profile preferences class that adjusted the colour settings separately for the main console and the mapper the latter had the same names but with a `2` suffix. To made it more clear I have changed them to include `Map` in their names instead. Also, the NON-slot method: `(void) dlgProfilePreferences::setColor(QPushButton*, QColor&, bool)` has been renamed to: `(void) dlgProfilePreferences::setButtonAndProfileColor(QPushButton*, QColor&, bool)` so that it is clearly distinguishable from built in Qt methods that are also called `setColor` - though which do have different signatures! For reference the changes made are: * `TConsole::slot_stop_all_triggers(...)` ==> `TConsole::slot_stopAllItems(...)` * `dlgConnectionProfiles::slot_copy_profile()` ==> `dlgConnectionProfiles::slot_copyProfile()` * `dlgConnectionProfiles::slot_copy_profilesettings_only()` ==> `dlgConnectionProfiles::slot_copyOnlySettingsOfProfile()` * `dlgConnectionProfiles::slot_deleteprofile_check(...)` ==> `dlgConnectionProfiles::slot_deleteProfileCheck(...)` * `dlgConnectionProfiles::slot_password_deleted(...)` ==> `dlgConnectionProfiles::slot_passwordDeleted(...)` * `dlgConnectionProfiles::slot_password_saved(...) ==> `dlgConnectionProfiles::slot_passwordSaved(...)` * `dlgConnectionProfiles::slot_profile_menu(...)` ==> `dlgConnectionProfiles::slot_profileContextMenu(...)` * `dlgConnectionProfiles::slot_reset_custom_icon()` ==> `dlgConnectionProfiles::slot_resetCustomIcon()` * `dlgConnectionProfiles::slot_set_custom_icon()` ==> `dlgConnectionProfiles::slot_setCustomIcon()` * `dlgConnectionProfiles::slot_set_custom_color()` ==> `dlgConnectionProfiles::slot_setCustomColor()` * `dlgConnectionProfiles::slot_update_autologin(...)` ==> `dlgConnectionProfiles::slot_updateAutoConnect(...)` * `dlgConnectionProfiles::slot_update_autoreconnect(...)` ==> `dlgConnectionProfiles::slot_updateAutoReconnect(...)` * `dlgConnectionProfiles::slot_update_description()` ==> `dlgConnectionProfiles::slot_updateDescription()` * `dlgConnectionProfiles::slot_update_discord_optin(...)` ==> `dlgConnectionProfiles::slot_updateDiscordOptIn(...)` * `dlgProfilePreferences::copyMap()` ==> `dlgProfilePreferences::slot_copyMap()` * `dlgProfilePreferences::downloadMap()` ==> `dlgProfilePreferences::slot_downloadMap()` * `dlgProfilePreferences::hideActionLabel()` ==> `dlgProfilePreferences::slot_hideActionLabel()` * `dlgProfilePreferences::loadMap()` ==> `dlgProfilePreferences::slot_loadMap()` * `dlgProfilePreferences::resetColors()` ==> `dlgProfilePreferences::slot_resetColors()` * `dlgProfilePreferences::resetColors2()` ==> `dlgProfilePreferences::slot_resetMapColors()` * `dlgProfilePreferences::saveMap()` ==> `dlgProfilePreferences::slot_saveMap()` * `dlgProfilePreferences::setBgColor()` ==> `dlgProfilePreferences::slot_setBgColor()` * `dlgProfilePreferences::setBgColor2()` ==> `dlgProfilePreferences::slot_setMapBgColor()` * `dlgProfilePreferences::setColorBlack()` ==> `dlgProfilePreferences::slot_setColorBlack()` * `dlgProfilePreferences::setColorBlack2()` ==> `dlgProfilePreferences::slot_setMapColorBlack()` * `dlgProfilePreferences::setColorBlue()` ==> `dlgProfilePreferences::slot_setColorBlue()` * `dlgProfilePreferences::setColorCyan()` ==> `dlgProfilePreferences::slot_setColorCyan()` * `dlgProfilePreferences::setColorBlue2()` ==> `dlgProfilePreferences::slot_setMapColorBlue()` * `dlgProfilePreferences::setColorCyan2()` ==> `dlgProfilePreferences::slot_setMapColorCyan()` * `dlgProfilePreferences::setColorGreen()` ==> `dlgProfilePreferences::slot_setColorGreen()` * `dlgProfilePreferences::setColorGreen2()` ==> `dlgProfilePreferences::slot_setMapColorGreen()` * `dlgProfilePreferences::setColorLightBlack()` ==> `dlgProfilePreferences::slot_setColorLightBlack()` * `dlgProfilePreferences::setColorLightBlack2()` ==> `dlgProfilePreferences::slot_setMapColorLightBlack()` * `dlgProfilePreferences::setColorLightBlue()` ==> `dlgProfilePreferences::slot_setColorLightBlue()` * `dlgProfilePreferences::setColorLightBlue2()` ==> `dlgProfilePreferences::slot_setMapColorLightBlue()` * `dlgProfilePreferences::setColorLightCyan()` ==> `dlgProfilePreferences::slot_setColorLightCyan()` * `dlgProfilePreferences::setColorLightCyan2()` ==> `dlgProfilePreferences::slot_setMapColorLightCyan()` * `dlgProfilePreferences::setColorLightGreen()` ==> `dlgProfilePreferences::slot_setColorLightGreen()` * `dlgProfilePreferences::setColorLightGreen2()` ==> `dlgProfilePreferences::slot_setMapColorLightGreen()` * `dlgProfilePreferences::setColorLightMagenta()` ==> `dlgProfilePreferences::slot_setColorLightMagenta()` * `dlgProfilePreferences::setColorLightMagenta2()` ==> `dlgProfilePreferences::slot_setMapColorLightMagenta()` * `dlgProfilePreferences::setColorLightRed()` ==> `dlgProfilePreferences::slot_setColorLightRed()` * `dlgProfilePreferences::setColorLightRed2()` ==> `dlgProfilePreferences::slot_setMapColorLightRed()` * `dlgProfilePreferences::setColorLightWhite()` ==> `dlgProfilePreferences::slot_setColorLightWhite()` * `dlgProfilePreferences::setColorLightWhite2()` ==> `dlgProfilePreferences::slot_setMapColorLightWhite()` * `dlgProfilePreferences::setColorLightYellow()` ==> `dlgProfilePreferences::slot_setColorLightYellow()` * `dlgProfilePreferences::setColorLightYellow2()` ==> `dlgProfilePreferences::slot_setMapColorLightYellow()` * `dlgProfilePreferences::setColorMagenta()` ==> `dlgProfilePreferences::slot_setColorMagenta()` * `dlgProfilePreferences::setColorMagenta2()` ==> `dlgProfilePreferences::slot_setMapColorMagenta()` * `dlgProfilePreferences::setColorRed2()` ==> `dlgProfilePreferences::slot_setMapColorRed()` * `dlgProfilePreferences::setColorRed()` ==> `dlgProfilePreferences::slot_setColorRed()` * `dlgProfilePreferences::setColorWhite()` ==> `dlgProfilePreferences::slot_setColorWhite()` * `dlgProfilePreferences::setColorWhite2()` ==> `dlgProfilePreferences::slot_setMapColorWhite()` * `dlgProfilePreferences::setColorYellow()` ==> `dlgProfilePreferences::slot_setColorYellow()` * `dlgProfilePreferences::setColorYellow2()` ==> `dlgProfilePreferences::slot_setMapColorYellow()` * `dlgProfilePreferences::setCommandBgColor()` ==> `dlgProfilePreferences::slot_setCommandBgColor()` * `dlgProfilePreferences::setCommandFgColor()` ==> `dlgProfilePreferences::slot_setCommandFgColor()` * `dlgProfilePreferences::setCommandLineBgColor()` ==> `dlgProfilePreferences::slot_setCommandLineBgColor()` * `dlgProfilePreferences::setCommandLineFgColor()` ==> `dlgProfilePreferences::slot_setCommandLineFgColor()` * `dlgProfilePreferences::setDisplayFont()` ==> `dlgProfilePreferences::slot_setDisplayFont()` * `dlgProfilePreferences::setFgColor()` ==> `dlgProfilePreferences::slot_setFgColor()` * `dlgProfilePreferences::setFgColor2()` ==> `dlgProfilePreferences::slot_setMapExitsColor()` * `dlgProfilePreferences::setFontSize()` ==> `dlgProfilePreferences::slot_setFontSize()` * `dlgProfilePreferences::setMapInfoBackground()` ==> `dlgProfilePreferences::slot_setMapInfoBgColor()` * `dlgProfilePreferences::setRoomBorderColor()` ==> `dlgProfilePreferences::slot_setMapRoomBorderColor()` * `dlgProfilePreferences::slot_script_selected(...)` ==> `dlgProfilePreferences::slot_scriptSelected(...)` * `dlgProfilePreferences::slot_theme_selected(...)` ==> `dlgProfilePreferences::slot_themeSelected(...)` * `dlgRoomSymbol::colorRejected()` ==> `dlgRoomSymbol::slot_colorRejected()` * `dlgRoomSymbol::colorSelected(...)` ==> `dlgRoomSymbol::slot_colorSelected(...)` * `dlgRoomSymbol::currentColorChanged(...)` ==> `dlgRoomSymbol::slot_currentColorChanged(...)` * `dlgRoomSymbol::openColorSelector()` ==> `dlgRoomSymbol::slot_openColorSelector()` * `dlgRoomSymbol::resetColor()` ==> `dlgRoomSymbol::slot_resetColors()` * `dlgRoomSymbol::updatePreview()` ==> `dlgRoomSymbol::slot_updatePreview()` * `dlgTriggerEditor::slot_show_vars()` ==> `dlgTriggerEditor::slot_showVariables()` * `dlgTriggerEditor::slot_var_changed(...)` ==> `dlgTriggerEditor::slot_variableChanged(...)` * `dlgTriggerEditor::slot_var_selected(...)` ==> `dlgTriggerEditor::slot_variableSelected(...)` * `mudlet::slot_check_manual_update()` ==> `mudlet::slot_manualUpdateCheck()` * `mudlet::slot_close_current_profile()` ==> `mudlet::slot_closeCurrentProfile()` * `mudlet::slot_close_profile_requested(...)` ==> `mudlet::slot_closeProfileRequested(...)` * `mudlet::slot_connection_dlg_finished(...)` ==> `mudlet::slot_connectionDialogueFinished(...)` * `mudlet::slot_module_manager()` ==> `mudlet::slot_moduleManager()` * `mudlet::slot_mudlet_discord()` ==> `mudlet::slot_mudletDiscord()` * `mudlet::slot_multi_view(...)` ==> `mudlet::slot_multiView(const bool state)` * `mudlet::slot_package_manager()` ==> `mudlet::slot_packageManager()` * `mudlet::slot_package_exporter()` ==> `mudlet::slot_packageExporter()` * `mudlet::slot_timer_fires()` ==> `mudlet::slot_timerFires()` * `mudlet::slot_toggle_multi_view()` ==> `mudlet::slot_toggleMultiView()` Also the names for these in particular have been changed to make more sense: * `dlgProfilePreferences::slot_chooseProfilesChanged()` ==> `dlgProfilePreferences::slot_chosenProfilesChanged()` * `dlgProfilePreferences::slot_editor_tab_selected(...)` ==> `dlgProfilePreferences::slot_tabChanged(...)` * `dlgProfilePreferences::slot_passwords_location_changed(...)` ==> `dlgProfilePreferences::slot_passwordStorageLocationChanged(...)` * `dlgProfilePreferences::slot_save_and_exit()` ==> `dlgProfilePreferences::slot_saveAndClose()` * `dlgTriggerEditor::slot_toggleHiddenVar(...)` ==> `dlgTriggerEditor::slot_hideVariable(...)` - changed to distinguish it from `slot_toggleHiddenVariables(...)` * `dlgTriggerEditor::slot_item_selected_save(...)` ==> `dlgTriggerEditor::slot_saveSelectedItem(...)` * `mudlet::slot_discord()` ==> `mudlet::slot_profileDiscord()` - changed to distinguish it from `slot_mudletDiscord()` Not currently used and commented out: * `dlgProfilePreferences::setCommandLineFont()` ==> `dlgProfilePreferences::slot_setCommandLineFont()` Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-08-29 14:27:13 +02:00
void dlgConnectionProfiles::slot_resetCustomIcon()
New feature: Set custom icons in profiles list (#2814)
2019-07-25 16:59:16 +02:00
{
Fix three crashes in the game selection screen (#9702) #### Brief overview of PR changes/additions - **Right-clicking the games list with nothing selected killed Mudlet.** `dlgConnectionProfiles::slot_profileContextMenu()` dereferenced `currentItem()` unguarded. That line is byte-identical in 4.22.0, so the null deref itself is long-standing and latent - what is new is that it became reachable: "improve: split the games list into My games and All games tabs" (#9452) leaves a user with no saved profiles an empty but still right-clickable "My games" tab, a state 4.22.0's always-populated list never had. About 40 seconds into a fresh install. - **Copying a profile while the list was rebuilt was a use-after-free.** The copy runs on a thread pool and its completion handler kept the `QListWidgetItem*` it had made; clicking the other games tab meanwhile calls `fillout_form()`, which destroys every item. The handler now finds the copy by name, and the `QFutureWatcher` is parented so it cannot outlive the dialog. - **Quitting before the connection dialog had been shown dereferenced null.** The queued `0ms` lambda in `mudlet::slot_showConnectionDialog()` used `mpConnectionDialog`, which `mudlet::closeEvent()` closes (it is `WA_DeleteOnClose`) and clears. #### Motivation for adding to Mudlet All three came out of the 5.0 QA sweep and are confirmed with AddressSanitizer. The first is the serious one - it is the default state of a brand-new install, so a new user can lose Mudlet before they have connected to anything. Scope note on the third: it is **not** a 5.0 regression. It has been there since "Fix: Improve tab indicators and detached window UX" (#7965) and is unchanged in 4.22.0; #9493 only turned the literal `0` into `0ms`. Nor could I reach it by clicking: I drove *Games -> Close profile* followed by quitting at six delays from 0 to 2000 ms and the dialog was always painted first. It reproduces deterministically in-process, and QA reproduced it 2/2 driving the close from Lua. Worth guarding - the pointer is documented to go null - but latent rather than routinely hit. #### Other info (issues closed, discussion etc) Test case: `ctest -R ConnectionDialogCrashTest` - with the fix reverted, four of its tests reproduce the original ASan reports exactly (two SEGVs in `slot_profileContextMenu`, a heap-use-after-free in `slot_itemClicked`, the SEGV in `QWidget::show()` from the lambda); two more are controls that pass either way, one of them pinning that the menu still opens for a selected profile so the guard cannot degenerate into an unconditional early return. Full suite 79/79. Assisted-by: Claude:claude-opus-5
2026-08-07 10:14:30 +02:00
const auto profileName = selectedProfileName();
if (profileName.isEmpty()) {
return;
}
New feature: Set custom icons in profiles list (#2814)
2019-07-25 16:59:16 +02:00
Infrastructure: mark read-only variables as const (#6843) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Mark read-only variables as const - that is, not intended to change after they've been declared #### Motivation for adding to Mudlet So we don't change them by accident later on, and also to clearly state intentions for the variables #### Other info (issues closed, discussion etc) This is also recommended by the [C++ Core Guidelines](https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#es25-declare-an-object-const-or-constexpr-unless-you-want-to-modify-its-value-later-on)
2023-05-14 15:06:15 +02:00
const bool success = mudlet::self()->resetProfileIcon(profileName).first;
New feature: Set custom icons in profiles list (#2814)
2019-07-25 16:59:16 +02:00
if (!success) {
return;
}
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
auto currentRow = listWidget_profiles->currentRow();
New feature: Set custom icons in profiles list (#2814)
2019-07-25 16:59:16 +02:00
fillout_form();
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
listWidget_profiles->setCurrentRow(currentRow);
New feature: Set custom icons in profiles list (#2814)
2019-07-25 16:59:16 +02:00
}
Feature: finished all features in connectionDialog + autologon
2009-01-28 02:35:22 +01:00
void dlgConnectionProfiles::slot_cancel()
{
Update: remove Midkemia (and add WoTMUD) to list of predefined MUDs (#321) * Update: remove Midkemia (and add WoTMUD) to list of predefined MUDs The I.R.E. MUD Midkemia-online was shutdown on 2016/09/07 and it is not helpful to continue to offer it as a predefined MUD in the connection dialog. This commit removes it from that list and adds a favourite of mine "WoTMUD" to replace it. The logo is a temporary one that I will replace with a similar one that I need to get clearance to use (and release with a GPL2.1+ licence) from the Wheel of Time MUD sysop with whom I am in contact {Vivienne needs to get approval from the creator Flash who is away for a few days...!} The dlgConnectionProfiles.cpp file has quite a few ASCII strings, as appropriate for a file that will in the future be subject to I18n work I took the opportunity to put QStringLiteral(...) wrappers around the QStrings that are used for non-GUI tasks and tr(...) ones that are. I expect it isn't complete but it goes someway towards dealing with THIS particular file - and it should improve very slightly the generation of QStrings that need to be constructed because it means as much of possible of them is done at compile rather than run-time...! In relation to the above there are points in the code where QStrings are compared to "" to see if they do not have any contents - the isEmpty() method is a better way to do the same (it does not involve a string expression) In (void)dlgConnectionProfiles::slot_update_name( const QString ) there are a couple of variables that use a double underscore prefix - that is NOT A Good Idea: such a prefix is RESERVED in both C and C++. For example see: [what-are-the-rules-about-using-an-underscore-in-a-c-identifier](http://stackoverflow.com/questions/228783/what-are-the-rules-about-using-an-underscore-in-a-c-identifier) also a single prefix might be a bit of a problem with libraries... I have renames the offending things there - but I may have used the single underscore prefix myself in the past. *blush* There are some help messages in this class that use an apostrophe in a word contraction - as a matter of readability this is not considered best practice IMHO so I have converted them to the full words. Following experiences in my previous Pull Request I also took a look at the initialisation and use of some member variables; it became clear that: * (QString) dlgConnectionProfiles::mOrigin * (bool) dlgConnectionProfiles::mEditOK were not used and could be simply deleted and that: * (QString) dlgConnectionProfiles::mUnsavedProfileName * (QString) dlgConnectionProfiles::mCurrentProfileEditName did not need to be member variables and could be local to the method that used them, so in (void)dlgConnectionProfiles::slot_save_name(): * (QString) dlgConnectionProfiles::mCurrentProfileEditName becomes local: (QString) currentProfileEditName and in (void) dlgConnectionProfiles::slot_addProfile(): * (QString) dlgConnectionProfiles::mUnsavedProfileName becomes local: (QString) newName also added initialisers for: * (QStringList) dlgConnectionProfiles::mProfileList * (QPushButton *) dlgConnectionProfiles::connect_button * (QLineEditQPushButton *) dlgConnectionProfiles::delete_profile_lineedit * (QPushButton *) dlgConnectionProfiles::delete_button Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * More: two items missed from prior commit In the previous commit I forgot to take out: * a check for Midkemia in the dlgProfilePreferences class constructor that enabled the download map options; * a similar check in (bool)TMap::restore(QString) that asked if the user wanted to download a map if there was not one found. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * Tweak: Insert MUD supplied Logo/Icon Received an icon as a .jpg that the MUD operators can allow us to licence as GPL2.1+ which I have converted to a .png file. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2016-10-15 09:57:17 +01:00
// QDialog::Rejected is the enum value (= 0) return value for a "cancelled"
// outcome...
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
QDialog::done(QDialog::Rejected);
start
2009-01-24 02:50:22 +01:00
}
Infrastructure: tidy up naming of SLOT methods and their usage - Part 5 (last) (#6266) When Qt's slot/signal system is used to invoke a method there is some overhead - so it makes sense to ensure developers can spot all such methods (functions). We have tried to do this with a `slot_` prefix to the methods we create but it has not been applied uniformly. This PR is intended to conclude helping with this by more rigorously doing so - the names changed herein should all follow a `slot_`*camelCaseMethodName* style. In addition some methods were detected that are not currently used or which are not actually used via the signal/slot system, these have been commented out or have had the prefix removed and the declaration in the relevant header file moved as appropriate. There were two similar sets of (not prefixed with `slot_`) slots in the Profile preferences class that adjusted the colour settings separately for the main console and the mapper the latter had the same names but with a `2` suffix. To made it more clear I have changed them to include `Map` in their names instead. Also, the NON-slot method: `(void) dlgProfilePreferences::setColor(QPushButton*, QColor&, bool)` has been renamed to: `(void) dlgProfilePreferences::setButtonAndProfileColor(QPushButton*, QColor&, bool)` so that it is clearly distinguishable from built in Qt methods that are also called `setColor` - though which do have different signatures! For reference the changes made are: * `TConsole::slot_stop_all_triggers(...)` ==> `TConsole::slot_stopAllItems(...)` * `dlgConnectionProfiles::slot_copy_profile()` ==> `dlgConnectionProfiles::slot_copyProfile()` * `dlgConnectionProfiles::slot_copy_profilesettings_only()` ==> `dlgConnectionProfiles::slot_copyOnlySettingsOfProfile()` * `dlgConnectionProfiles::slot_deleteprofile_check(...)` ==> `dlgConnectionProfiles::slot_deleteProfileCheck(...)` * `dlgConnectionProfiles::slot_password_deleted(...)` ==> `dlgConnectionProfiles::slot_passwordDeleted(...)` * `dlgConnectionProfiles::slot_password_saved(...) ==> `dlgConnectionProfiles::slot_passwordSaved(...)` * `dlgConnectionProfiles::slot_profile_menu(...)` ==> `dlgConnectionProfiles::slot_profileContextMenu(...)` * `dlgConnectionProfiles::slot_reset_custom_icon()` ==> `dlgConnectionProfiles::slot_resetCustomIcon()` * `dlgConnectionProfiles::slot_set_custom_icon()` ==> `dlgConnectionProfiles::slot_setCustomIcon()` * `dlgConnectionProfiles::slot_set_custom_color()` ==> `dlgConnectionProfiles::slot_setCustomColor()` * `dlgConnectionProfiles::slot_update_autologin(...)` ==> `dlgConnectionProfiles::slot_updateAutoConnect(...)` * `dlgConnectionProfiles::slot_update_autoreconnect(...)` ==> `dlgConnectionProfiles::slot_updateAutoReconnect(...)` * `dlgConnectionProfiles::slot_update_description()` ==> `dlgConnectionProfiles::slot_updateDescription()` * `dlgConnectionProfiles::slot_update_discord_optin(...)` ==> `dlgConnectionProfiles::slot_updateDiscordOptIn(...)` * `dlgProfilePreferences::copyMap()` ==> `dlgProfilePreferences::slot_copyMap()` * `dlgProfilePreferences::downloadMap()` ==> `dlgProfilePreferences::slot_downloadMap()` * `dlgProfilePreferences::hideActionLabel()` ==> `dlgProfilePreferences::slot_hideActionLabel()` * `dlgProfilePreferences::loadMap()` ==> `dlgProfilePreferences::slot_loadMap()` * `dlgProfilePreferences::resetColors()` ==> `dlgProfilePreferences::slot_resetColors()` * `dlgProfilePreferences::resetColors2()` ==> `dlgProfilePreferences::slot_resetMapColors()` * `dlgProfilePreferences::saveMap()` ==> `dlgProfilePreferences::slot_saveMap()` * `dlgProfilePreferences::setBgColor()` ==> `dlgProfilePreferences::slot_setBgColor()` * `dlgProfilePreferences::setBgColor2()` ==> `dlgProfilePreferences::slot_setMapBgColor()` * `dlgProfilePreferences::setColorBlack()` ==> `dlgProfilePreferences::slot_setColorBlack()` * `dlgProfilePreferences::setColorBlack2()` ==> `dlgProfilePreferences::slot_setMapColorBlack()` * `dlgProfilePreferences::setColorBlue()` ==> `dlgProfilePreferences::slot_setColorBlue()` * `dlgProfilePreferences::setColorCyan()` ==> `dlgProfilePreferences::slot_setColorCyan()` * `dlgProfilePreferences::setColorBlue2()` ==> `dlgProfilePreferences::slot_setMapColorBlue()` * `dlgProfilePreferences::setColorCyan2()` ==> `dlgProfilePreferences::slot_setMapColorCyan()` * `dlgProfilePreferences::setColorGreen()` ==> `dlgProfilePreferences::slot_setColorGreen()` * `dlgProfilePreferences::setColorGreen2()` ==> `dlgProfilePreferences::slot_setMapColorGreen()` * `dlgProfilePreferences::setColorLightBlack()` ==> `dlgProfilePreferences::slot_setColorLightBlack()` * `dlgProfilePreferences::setColorLightBlack2()` ==> `dlgProfilePreferences::slot_setMapColorLightBlack()` * `dlgProfilePreferences::setColorLightBlue()` ==> `dlgProfilePreferences::slot_setColorLightBlue()` * `dlgProfilePreferences::setColorLightBlue2()` ==> `dlgProfilePreferences::slot_setMapColorLightBlue()` * `dlgProfilePreferences::setColorLightCyan()` ==> `dlgProfilePreferences::slot_setColorLightCyan()` * `dlgProfilePreferences::setColorLightCyan2()` ==> `dlgProfilePreferences::slot_setMapColorLightCyan()` * `dlgProfilePreferences::setColorLightGreen()` ==> `dlgProfilePreferences::slot_setColorLightGreen()` * `dlgProfilePreferences::setColorLightGreen2()` ==> `dlgProfilePreferences::slot_setMapColorLightGreen()` * `dlgProfilePreferences::setColorLightMagenta()` ==> `dlgProfilePreferences::slot_setColorLightMagenta()` * `dlgProfilePreferences::setColorLightMagenta2()` ==> `dlgProfilePreferences::slot_setMapColorLightMagenta()` * `dlgProfilePreferences::setColorLightRed()` ==> `dlgProfilePreferences::slot_setColorLightRed()` * `dlgProfilePreferences::setColorLightRed2()` ==> `dlgProfilePreferences::slot_setMapColorLightRed()` * `dlgProfilePreferences::setColorLightWhite()` ==> `dlgProfilePreferences::slot_setColorLightWhite()` * `dlgProfilePreferences::setColorLightWhite2()` ==> `dlgProfilePreferences::slot_setMapColorLightWhite()` * `dlgProfilePreferences::setColorLightYellow()` ==> `dlgProfilePreferences::slot_setColorLightYellow()` * `dlgProfilePreferences::setColorLightYellow2()` ==> `dlgProfilePreferences::slot_setMapColorLightYellow()` * `dlgProfilePreferences::setColorMagenta()` ==> `dlgProfilePreferences::slot_setColorMagenta()` * `dlgProfilePreferences::setColorMagenta2()` ==> `dlgProfilePreferences::slot_setMapColorMagenta()` * `dlgProfilePreferences::setColorRed2()` ==> `dlgProfilePreferences::slot_setMapColorRed()` * `dlgProfilePreferences::setColorRed()` ==> `dlgProfilePreferences::slot_setColorRed()` * `dlgProfilePreferences::setColorWhite()` ==> `dlgProfilePreferences::slot_setColorWhite()` * `dlgProfilePreferences::setColorWhite2()` ==> `dlgProfilePreferences::slot_setMapColorWhite()` * `dlgProfilePreferences::setColorYellow()` ==> `dlgProfilePreferences::slot_setColorYellow()` * `dlgProfilePreferences::setColorYellow2()` ==> `dlgProfilePreferences::slot_setMapColorYellow()` * `dlgProfilePreferences::setCommandBgColor()` ==> `dlgProfilePreferences::slot_setCommandBgColor()` * `dlgProfilePreferences::setCommandFgColor()` ==> `dlgProfilePreferences::slot_setCommandFgColor()` * `dlgProfilePreferences::setCommandLineBgColor()` ==> `dlgProfilePreferences::slot_setCommandLineBgColor()` * `dlgProfilePreferences::setCommandLineFgColor()` ==> `dlgProfilePreferences::slot_setCommandLineFgColor()` * `dlgProfilePreferences::setDisplayFont()` ==> `dlgProfilePreferences::slot_setDisplayFont()` * `dlgProfilePreferences::setFgColor()` ==> `dlgProfilePreferences::slot_setFgColor()` * `dlgProfilePreferences::setFgColor2()` ==> `dlgProfilePreferences::slot_setMapExitsColor()` * `dlgProfilePreferences::setFontSize()` ==> `dlgProfilePreferences::slot_setFontSize()` * `dlgProfilePreferences::setMapInfoBackground()` ==> `dlgProfilePreferences::slot_setMapInfoBgColor()` * `dlgProfilePreferences::setRoomBorderColor()` ==> `dlgProfilePreferences::slot_setMapRoomBorderColor()` * `dlgProfilePreferences::slot_script_selected(...)` ==> `dlgProfilePreferences::slot_scriptSelected(...)` * `dlgProfilePreferences::slot_theme_selected(...)` ==> `dlgProfilePreferences::slot_themeSelected(...)` * `dlgRoomSymbol::colorRejected()` ==> `dlgRoomSymbol::slot_colorRejected()` * `dlgRoomSymbol::colorSelected(...)` ==> `dlgRoomSymbol::slot_colorSelected(...)` * `dlgRoomSymbol::currentColorChanged(...)` ==> `dlgRoomSymbol::slot_currentColorChanged(...)` * `dlgRoomSymbol::openColorSelector()` ==> `dlgRoomSymbol::slot_openColorSelector()` * `dlgRoomSymbol::resetColor()` ==> `dlgRoomSymbol::slot_resetColors()` * `dlgRoomSymbol::updatePreview()` ==> `dlgRoomSymbol::slot_updatePreview()` * `dlgTriggerEditor::slot_show_vars()` ==> `dlgTriggerEditor::slot_showVariables()` * `dlgTriggerEditor::slot_var_changed(...)` ==> `dlgTriggerEditor::slot_variableChanged(...)` * `dlgTriggerEditor::slot_var_selected(...)` ==> `dlgTriggerEditor::slot_variableSelected(...)` * `mudlet::slot_check_manual_update()` ==> `mudlet::slot_manualUpdateCheck()` * `mudlet::slot_close_current_profile()` ==> `mudlet::slot_closeCurrentProfile()` * `mudlet::slot_close_profile_requested(...)` ==> `mudlet::slot_closeProfileRequested(...)` * `mudlet::slot_connection_dlg_finished(...)` ==> `mudlet::slot_connectionDialogueFinished(...)` * `mudlet::slot_module_manager()` ==> `mudlet::slot_moduleManager()` * `mudlet::slot_mudlet_discord()` ==> `mudlet::slot_mudletDiscord()` * `mudlet::slot_multi_view(...)` ==> `mudlet::slot_multiView(const bool state)` * `mudlet::slot_package_manager()` ==> `mudlet::slot_packageManager()` * `mudlet::slot_package_exporter()` ==> `mudlet::slot_packageExporter()` * `mudlet::slot_timer_fires()` ==> `mudlet::slot_timerFires()` * `mudlet::slot_toggle_multi_view()` ==> `mudlet::slot_toggleMultiView()` Also the names for these in particular have been changed to make more sense: * `dlgProfilePreferences::slot_chooseProfilesChanged()` ==> `dlgProfilePreferences::slot_chosenProfilesChanged()` * `dlgProfilePreferences::slot_editor_tab_selected(...)` ==> `dlgProfilePreferences::slot_tabChanged(...)` * `dlgProfilePreferences::slot_passwords_location_changed(...)` ==> `dlgProfilePreferences::slot_passwordStorageLocationChanged(...)` * `dlgProfilePreferences::slot_save_and_exit()` ==> `dlgProfilePreferences::slot_saveAndClose()` * `dlgTriggerEditor::slot_toggleHiddenVar(...)` ==> `dlgTriggerEditor::slot_hideVariable(...)` - changed to distinguish it from `slot_toggleHiddenVariables(...)` * `dlgTriggerEditor::slot_item_selected_save(...)` ==> `dlgTriggerEditor::slot_saveSelectedItem(...)` * `mudlet::slot_discord()` ==> `mudlet::slot_profileDiscord()` - changed to distinguish it from `slot_mudletDiscord()` Not currently used and commented out: * `dlgProfilePreferences::setCommandLineFont()` ==> `dlgProfilePreferences::slot_setCommandLineFont()` Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-08-29 14:27:13 +02:00
void dlgConnectionProfiles::slot_copyProfile()
Make the copy button work
2009-01-30 01:25:11 -05:00
{
Add a toggle to store password securely, in OS or in the profile (#3121) * Add password migration toggle * Remove colourroles * Store/load option for secure storage * Minor QA cleanup, remove debug messages * Remove checkmark, it looks poor on Windows * Fix 'Copy profile' not to lose password if you're storing them securely * Actually write password to storage on copy as well * Only save secure passwords if we're using secure password storage * Store passwords in profile storage if using profile storage on edit * Use correct tooltip for secure/profile storage * Fix header return signature to match function's
2019-09-30 11:19:28 +02:00
mCopyingProfile = true;
Add 'Copy profile (settings only)' button (#2779) * Added button and got connection info copied * Add copy profile with settings only * Tweak UI style * Cleanup * Remove duplicates * Remove another debug cout * Fix names getting duplicated * Remove debug statement * Fix unnecessary return
2019-07-17 07:33:47 +02:00
QString profile_name;
QString oldname;
QListWidgetItem* pItem;
Add a toggle to store password securely, in OS or in the profile (#3121) * Add password migration toggle * Remove colourroles * Store/load option for secure storage * Minor QA cleanup, remove debug messages * Remove checkmark, it looks poor on Windows * Fix 'Copy profile' not to lose password if you're storing them securely * Actually write password to storage on copy as well * Only save secure passwords if we're using secure password storage * Store passwords in profile storage if using profile storage on edit * Use correct tooltip for secure/profile storage * Fix header return signature to match function's
2019-09-30 11:19:28 +02:00
const auto oldPassword = character_password_entry->text();
fix: copying of default profiles after fresh install (#9317) ## fix: copying default and welcome profiles now produces a working copy ### Brief overview of PR changes/additions - Makes the **Copy** and **Copy settings only** buttons work for default and welcome profiles. - When the source profile has no folder on disk, writes its displayed connection data (URL, port, SSL, login, website, description) into the new profile so the copy is functional and persists. - Improves the first-run user experience for copying profiles. ### Motivation for adding to Mudlet Previously, copying a default or welcome profile appeared to succeed but produced a broken profile: the connect button stayed disabled and the copy vanished once the connection screen was reopened. Default profiles only exist in memory until connected to or saved, so there was no folder for the copy operation to copy from. This makes copying actually work and improves the first-run experience. ### Other info (issues closed, discussion etc) - Fixes "Copy" button does not work properly immediately after fresh install (#9247). - Supersedes #9256; per the consensus there, this makes copying work for default profiles instead of disabling the button. - **Root cause:** default profiles are generated dynamically and are not available as on-disk profiles for copy operations. - No new tests added yet; changes are limited to the copy action handling and profile data writing.
2026-07-03 12:02:11 +05:30
const CopiedProfileData data = captureProfileData();
Add a toggle to store password securely, in OS or in the profile (#3121) * Add password migration toggle * Remove colourroles * Store/load option for secure storage * Minor QA cleanup, remove debug messages * Remove checkmark, it looks poor on Windows * Fix 'Copy profile' not to lose password if you're storing them securely * Actually write password to storage on copy as well * Only save secure passwords if we're using secure password storage * Store passwords in profile storage if using profile storage on edit * Use correct tooltip for secure/profile storage * Fix header return signature to match function's
2019-09-30 11:19:28 +02:00
Add 'Copy profile (settings only)' button (#2779) * Added button and got connection info copied * Add copy profile with settings only * Tweak UI style * Cleanup * Remove duplicates * Remove another debug cout * Fix names getting duplicated * Remove debug statement * Fix unnecessary return
2019-07-17 07:33:47 +02:00
if (!copyProfileWidget(profile_name, oldname, pItem)) {
Add a toggle to store password securely, in OS or in the profile (#3121) * Add password migration toggle * Remove colourroles * Store/load option for secure storage * Minor QA cleanup, remove debug messages * Remove checkmark, it looks poor on Windows * Fix 'Copy profile' not to lose password if you're storing them securely * Actually write password to storage on copy as well * Only save secure passwords if we're using secure password storage * Store passwords in profile storage if using profile storage on edit * Use correct tooltip for secure/profile storage * Fix header return signature to match function's
2019-09-30 11:19:28 +02:00
mCopyingProfile = false;
Add 'Copy profile (settings only)' button (#2779) * Added button and got connection info copied * Add copy profile with settings only * Tweak UI style * Cleanup * Remove duplicates * Remove another debug cout * Fix names getting duplicated * Remove debug statement * Fix unnecessary return
2019-07-17 07:33:47 +02:00
return;
}
misc
2010-03-15 09:37:16 +01:00
fix: copying of default profiles after fresh install (#9317) ## fix: copying default and welcome profiles now produces a working copy ### Brief overview of PR changes/additions - Makes the **Copy** and **Copy settings only** buttons work for default and welcome profiles. - When the source profile has no folder on disk, writes its displayed connection data (URL, port, SSL, login, website, description) into the new profile so the copy is functional and persists. - Improves the first-run user experience for copying profiles. ### Motivation for adding to Mudlet Previously, copying a default or welcome profile appeared to succeed but produced a broken profile: the connect button stayed disabled and the copy vanished once the connection screen was reopened. Default profiles only exist in memory until connected to or saved, so there was no folder for the copy operation to copy from. This makes copying actually work and improves the first-run experience. ### Other info (issues closed, discussion etc) - Fixes "Copy" button does not work properly immediately after fresh install (#9247). - Supersedes #9256; per the consensus there, this makes copying work for default profiles instead of disabling the button. - **Root cause:** default profiles are generated dynamically and are not available as on-disk profiles for copy operations. - No new tests added yet; changes are limited to the copy action handling and profile data writing.
2026-07-03 12:02:11 +05:30
// A default profile (one of the predefined games) only exists in memory, so
// there is no folder to copy on-disk. Persist the displayed connection data
// into the new profile the same way saving a profile does, so the copy is
Infrastructure: add `enums.h` (#7646) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Add `enums.h` where we can add enums and flags to be used throughout the application that don't have a more specific place to be, without dragging in giant classes such as mudlet.h or Host.h. Also added `enums::PackageModuleType` to track the magic numbers used throughout package/module code :rocket: #### Motivation for adding to Mudlet Simplify code organisation. #### Other info (issues closed, discussion etc) --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-01-08 10:04:50 +01:00
const QDir dir(mudlet::getMudletPath(enums::profileHomePath, oldname));
Add 'Copy profile (settings only)' button (#2779) * Added button and got connection info copied * Add copy profile with settings only * Tweak UI style * Cleanup * Remove duplicates * Remove another debug cout * Fix names getting duplicated * Remove debug statement * Fix unnecessary return
2019-07-17 07:33:47 +02:00
if (!dir.exists()) {
fix: copying of default profiles after fresh install (#9317) ## fix: copying default and welcome profiles now produces a working copy ### Brief overview of PR changes/additions - Makes the **Copy** and **Copy settings only** buttons work for default and welcome profiles. - When the source profile has no folder on disk, writes its displayed connection data (URL, port, SSL, login, website, description) into the new profile so the copy is functional and persists. - Improves the first-run user experience for copying profiles. ### Motivation for adding to Mudlet Previously, copying a default or welcome profile appeared to succeed but produced a broken profile: the connect button stayed disabled and the copy vanished once the connection screen was reopened. Default profiles only exist in memory until connected to or saved, so there was no folder for the copy operation to copy from. This makes copying actually work and improves the first-run experience. ### Other info (issues closed, discussion etc) - Fixes "Copy" button does not work properly immediately after fresh install (#9247). - Supersedes #9256; per the consensus there, this makes copying work for default profiles instead of disabling the button. - **Root cause:** default profiles are generated dynamically and are not available as on-disk profiles for copy operations. - No new tests added yet; changes are limited to the copy action handling and profile data writing.
2026-07-03 12:02:11 +05:30
saveDefaultProfileCopy(profile_name, data, oldPassword);
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
return;
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
}
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
Improve: don't freeze Mudlet when copying large profile (#5056)
2022-04-18 20:37:10 +02:00
QApplication::setOverrideCursor(Qt::BusyCursor);
mpCopyProfile->setText(tr("Copying..."));
mpCopyProfile->setEnabled(false);
Infrastructure: add `enums.h` (#7646) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Add `enums.h` where we can add enums and flags to be used throughout the application that don't have a more specific place to be, without dragging in giant classes such as mudlet.h or Host.h. Also added `enums::PackageModuleType` to track the magic numbers used throughout package/module code :rocket: #### Motivation for adding to Mudlet Simplify code organisation. #### Other info (issues closed, discussion etc) --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-01-08 10:04:50 +01:00
auto future = QtConcurrent::run(dlgConnectionProfiles::copyFolder, mudlet::getMudletPath(enums::profileHomePath, oldname), mudlet::getMudletPath(enums::profileHomePath, profile_name));
Fix three crashes in the game selection screen (#9702) #### Brief overview of PR changes/additions - **Right-clicking the games list with nothing selected killed Mudlet.** `dlgConnectionProfiles::slot_profileContextMenu()` dereferenced `currentItem()` unguarded. That line is byte-identical in 4.22.0, so the null deref itself is long-standing and latent - what is new is that it became reachable: "improve: split the games list into My games and All games tabs" (#9452) leaves a user with no saved profiles an empty but still right-clickable "My games" tab, a state 4.22.0's always-populated list never had. About 40 seconds into a fresh install. - **Copying a profile while the list was rebuilt was a use-after-free.** The copy runs on a thread pool and its completion handler kept the `QListWidgetItem*` it had made; clicking the other games tab meanwhile calls `fillout_form()`, which destroys every item. The handler now finds the copy by name, and the `QFutureWatcher` is parented so it cannot outlive the dialog. - **Quitting before the connection dialog had been shown dereferenced null.** The queued `0ms` lambda in `mudlet::slot_showConnectionDialog()` used `mpConnectionDialog`, which `mudlet::closeEvent()` closes (it is `WA_DeleteOnClose`) and clears. #### Motivation for adding to Mudlet All three came out of the 5.0 QA sweep and are confirmed with AddressSanitizer. The first is the serious one - it is the default state of a brand-new install, so a new user can lose Mudlet before they have connected to anything. Scope note on the third: it is **not** a 5.0 regression. It has been there since "Fix: Improve tab indicators and detached window UX" (#7965) and is unchanged in 4.22.0; #9493 only turned the literal `0` into `0ms`. Nor could I reach it by clicking: I drove *Games -> Close profile* followed by quitting at six delays from 0 to 2000 ms and the dialog was always painted first. It reproduces deterministically in-process, and QA reproduced it 2/2 driving the close from Lua. Worth guarding - the pointer is documented to go null - but latent rather than routinely hit. #### Other info (issues closed, discussion etc) Test case: `ctest -R ConnectionDialogCrashTest` - with the fix reverted, four of its tests reproduce the original ASan reports exactly (two SEGVs in `slot_profileContextMenu`, a heap-use-after-free in `slot_itemClicked`, the SEGV in `QWidget::show()` from the lambda); two more are controls that pass either way, one of them pinning that the menu still opens for a selected profile so the guard cannot degenerate into an unconditional early return. Full suite 79/79. Assisted-by: Claude:claude-opus-5
2026-08-07 10:14:30 +02:00
auto watcher = new QFutureWatcher<bool>(this);
connect(watcher, &QFutureWatcher<bool>::finished, this, [this, profile_name, oldPassword, watcher]() {
if (!mProfileList.contains(profile_name)) {
mProfileList << profile_name;
}
// The dialog stays usable while the copy runs, and switching the games
// tab calls fillout_form(), which destroys every item - including the
// one made for this copy. Hence look it up by name rather than hold it.
auto pCopiedItems = findData(*listWidget_profiles, profile_name, csmNameRole);
if (pCopiedItems.isEmpty()) {
// that rebuild scanned the profiles directory before the copy
// landed in it
fillout_form();
pCopiedItems = findData(*listWidget_profiles, profile_name, csmNameRole);
}
if (!pCopiedItems.isEmpty()) {
auto* pCopiedItem = pCopiedItems.first();
if (listWidget_profiles->currentItem() == pCopiedItem) {
slot_itemClicked(pCopiedItem);
} else {
// reaches slot_itemClicked() through currentItemChanged
listWidget_profiles->setCurrentItem(pCopiedItem);
}
}
Add a toggle to store password securely, in OS or in the profile (#3121) * Add password migration toggle * Remove colourroles * Store/load option for secure storage * Minor QA cleanup, remove debug messages * Remove checkmark, it looks poor on Windows * Fix 'Copy profile' not to lose password if you're storing them securely * Actually write password to storage on copy as well * Only save secure passwords if we're using secure password storage * Store passwords in profile storage if using profile storage on edit * Use correct tooltip for secure/profile storage * Fix header return signature to match function's
2019-09-30 11:19:28 +02:00
Improve: don't freeze Mudlet when copying large profile (#5056)
2022-04-18 20:37:10 +02:00
// restore the password, which won't be copied by the disk copy if stored in the credential manager
Fix: prevent password loss in PTBs and improve credential debug messages (#8257) #### Brief overview of PR changes/additions - Fixed a bug where users lost their saved passwords when switching between different Mudlet versions - Added safety checks to prevent password deletion unless you're using a newer version (4.20.0+) - Made error messages clearer and more helpful when password loading fails - Improved the system's ability to find passwords stored in different locations - Added better logging to help diagnose password-related issues #### Motivation for adding to Mudlet Users reported that their saved passwords disappeared after trying development versions of Mudlet. This happened because the system was automatically cleaning up old password storage without considering that users might switch back to older versions. The unclear error messages also made it difficult to understand what was happening when passwords couldn't be loaded. #### Other info (issues closed, discussion etc) This fix ensures users can safely test different Mudlet versions without losing their saved passwords. It also makes password-related problems easier to understand and troubleshoot, while maintaining compatibility with all existing Mudlet installations. --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-09-24 07:28:15 -04:00
// Temporarily block textChanged signal to avoid triggering save on programmatic setText
{
const QSignalBlocker blocker(character_password_entry);
character_password_entry->setText(oldPassword);
}
Infrastructure: remove MSVC leak detection (#8378) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Remove support for leak detection using MSVC - this functionality hasn't been in use in a decade, and we're switching to to using [LeakSanitizer](https://github.com/google/sanitizers/wiki/AddressSanitizerLeakSanitizer) instead. #### Motivation for adding to Mudlet Cleaner code. #### Other info (issues closed, discussion etc) --------- Co-authored-by: Claude <noreply@anthropic.com>
2025-10-21 15:11:09 +01:00
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
if (mudlet::self()->storingPasswordsSecurely() && !oldPassword.trimmed().isEmpty()) {
Improve: don't freeze Mudlet when copying large profile (#5056)
2022-04-18 20:37:10 +02:00
writeSecurePassword(profile_name, oldPassword);
}
mCopyingProfile = false;
mpCopyProfile->setText(tr("Copy"));
mpCopyProfile->setEnabled(true);
QApplication::restoreOverrideCursor();
validateProfile();
fix: Fix QFutureWatcher memory leaks across the codebase (#9095) #### Brief overview of PR changes/additions A few places allocate a QFutureWatcher with new but don't clean it up afterwards. Added deleteLater() to all of them: Host::saveProfile, dlgConnectionProfiles::slot_copyProfile, dlgProfilePreferences theme download handler, TLuaInterpreter::unzipAsync, and Updater (3 sites). #### Motivation for adding to Mudlet Small housekeeping fix. Each leaked watcher is ~230 bytes so the practical impact is minimal, but it's good practice to clean up after ourselves. The Host::saveProfile one is the most frequent since autosave runs every 2 minutes. #### Other info (issues closed, discussion etc) Test case: review the one-line diffs, confirm deleteLater() is called after the watcher's finished signal work is done.
2026-03-22 12:09:37 +01:00
watcher->deleteLater();
Improve: don't freeze Mudlet when copying large profile (#5056)
2022-04-18 20:37:10 +02:00
});
watcher->setFuture(future);
Add 'Copy profile (settings only)' button (#2779) * Added button and got connection info copied * Add copy profile with settings only * Tweak UI style * Cleanup * Remove duplicates * Remove another debug cout * Fix names getting duplicated * Remove debug statement * Fix unnecessary return
2019-07-17 07:33:47 +02:00
}
fix: copying of default profiles after fresh install (#9317) ## fix: copying default and welcome profiles now produces a working copy ### Brief overview of PR changes/additions - Makes the **Copy** and **Copy settings only** buttons work for default and welcome profiles. - When the source profile has no folder on disk, writes its displayed connection data (URL, port, SSL, login, website, description) into the new profile so the copy is functional and persists. - Improves the first-run user experience for copying profiles. ### Motivation for adding to Mudlet Previously, copying a default or welcome profile appeared to succeed but produced a broken profile: the connect button stayed disabled and the copy vanished once the connection screen was reopened. Default profiles only exist in memory until connected to or saved, so there was no folder for the copy operation to copy from. This makes copying actually work and improves the first-run experience. ### Other info (issues closed, discussion etc) - Fixes "Copy" button does not work properly immediately after fresh install (#9247). - Supersedes #9256; per the consensus there, this makes copying work for default profiles instead of disabling the button. - **Root cause:** default profiles are generated dynamically and are not available as on-disk profiles for copy operations. - No new tests added yet; changes are limited to the copy action handling and profile data writing.
2026-07-03 12:02:11 +05:30
dlgConnectionProfiles::CopiedProfileData dlgConnectionProfiles::captureProfileData() const
{
improve: split the games list into My games and All games tabs (#9452) #### Brief overview of PR changes/additions - Tab bar above the connection dialog's games list: "My games" (profiles on disk) and "All games" (full catalog), replacing the right-click "Show my profiles only" stop-gap - Opens on My games when profiles exist, All games on a fresh install; last-used tab and the retired filter's setting are honoured; selection preserved across tab switches - Dedicated single-game builds hide the tab bar and keep their current look #### Motivation for adding to Mudlet One flat grid of ~35 games overwhelmed newcomers and buried the profiles a player actually uses. #### Other info (issues closed, discussion etc) Closes #9140 **Test case:** Fresh install → dialog opens on All games with the tab bar visible. Create a profile, restart → opens on My games showing only that profile, selected with details filled. Switch tabs → selection follows where possible; right-click menu no longer offers "Show my profiles only". https://github.com/user-attachments/assets/50b07d6e-7908-4d25-8b4c-4c6e1396aaea --------- Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-29 17:14:14 +02:00
return {host_name_entry->text(), port_entry->text(), port_ssl_tsl->isChecked() ? Qt::Checked : Qt::Unchecked, login_entry->text(), website_entry->text(), mud_description_textedit->toPlainText()};
fix: copying of default profiles after fresh install (#9317) ## fix: copying default and welcome profiles now produces a working copy ### Brief overview of PR changes/additions - Makes the **Copy** and **Copy settings only** buttons work for default and welcome profiles. - When the source profile has no folder on disk, writes its displayed connection data (URL, port, SSL, login, website, description) into the new profile so the copy is functional and persists. - Improves the first-run user experience for copying profiles. ### Motivation for adding to Mudlet Previously, copying a default or welcome profile appeared to succeed but produced a broken profile: the connect button stayed disabled and the copy vanished once the connection screen was reopened. Default profiles only exist in memory until connected to or saved, so there was no folder for the copy operation to copy from. This makes copying actually work and improves the first-run experience. ### Other info (issues closed, discussion etc) - Fixes "Copy" button does not work properly immediately after fresh install (#9247). - Supersedes #9256; per the consensus there, this makes copying work for default profiles instead of disabling the button. - **Root cause:** default profiles are generated dynamically and are not available as on-disk profiles for copy operations. - No new tests added yet; changes are limited to the copy action handling and profile data writing.
2026-07-03 12:02:11 +05:30
}
// Copying a default profile (one of the predefined games) has nothing to copy
// on-disk, because such profiles only exist in memory until saved. Create the
// new profile's folder and persist the captured connection data, so the copy is
// a faithful, functional profile that survives reopening the connection screen.
fix: show connection details when picking a game on a fresh install (#9451) #### Brief overview of PR changes/additions - Selecting a game on a first-ever launch now swaps the welcome message for the connection details and restores the dialog height - Programmatic selections (startup pre-selection, password-migration refreshes) still show the welcome message - Copying a pre-configured game now rebuilds the list and selects the copy with its details filled in #### Motivation for adding to Mudlet On a fresh install, clicking a game filled hidden fields and appeared to do nothing - a dead end for the very first thing a new user does. #### Other info (issues closed, discussion etc) Closes #3930 **Test case:** Fresh install (empty config dir) → connection dialog shows the welcome message → click any game → connection details appear filled in. Copy a pre-configured game → the copy appears in the list, selected, with editable details. https://github.com/user-attachments/assets/de6df8fa-e1f0-4564-91e8-c286bebdd791 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-22 05:02:00 +02:00
// url/port/SSL go through the same writers used when saving a profile; the
// remaining fields are written directly.
fix: copying of default profiles after fresh install (#9317) ## fix: copying default and welcome profiles now produces a working copy ### Brief overview of PR changes/additions - Makes the **Copy** and **Copy settings only** buttons work for default and welcome profiles. - When the source profile has no folder on disk, writes its displayed connection data (URL, port, SSL, login, website, description) into the new profile so the copy is functional and persists. - Improves the first-run user experience for copying profiles. ### Motivation for adding to Mudlet Previously, copying a default or welcome profile appeared to succeed but produced a broken profile: the connect button stayed disabled and the copy vanished once the connection screen was reopened. Default profiles only exist in memory until connected to or saved, so there was no folder for the copy operation to copy from. This makes copying actually work and improves the first-run experience. ### Other info (issues closed, discussion etc) - Fixes "Copy" button does not work properly immediately after fresh install (#9247). - Supersedes #9256; per the consensus there, this makes copying work for default profiles instead of disabling the button. - **Root cause:** default profiles are generated dynamically and are not available as on-disk profiles for copy operations. - No new tests added yet; changes are limited to the copy action handling and profile data writing.
2026-07-03 12:02:11 +05:30
void dlgConnectionProfiles::saveDefaultProfileCopy(const QString& profileName, const CopiedProfileData& data, const QString& oldPassword)
{
const QDir dir;
if (!dir.mkpath(mudlet::getMudletPath(enums::profileHomePath, profileName))) {
notificationArea->show();
notificationAreaIconLabelWarning->show();
notificationAreaIconLabelError->hide();
notificationAreaIconLabelInformation->hide();
notificationAreaMessageBox->show();
notificationAreaMessageBox->setText(tr("Could not create the new profile folder on your computer."));
mCopyingProfile = false;
return;
}
mProfileList << profileName;
fix: show connection details when picking a game on a fresh install (#9451) #### Brief overview of PR changes/additions - Selecting a game on a first-ever launch now swaps the welcome message for the connection details and restores the dialog height - Programmatic selections (startup pre-selection, password-migration refreshes) still show the welcome message - Copying a pre-configured game now rebuilds the list and selects the copy with its details filled in #### Motivation for adding to Mudlet On a fresh install, clicking a game filled hidden fields and appeared to do nothing - a dead end for the very first thing a new user does. #### Other info (issues closed, discussion etc) Closes #3930 **Test case:** Fresh install (empty config dir) → connection dialog shows the welcome message → click any game → connection details appear filled in. Copy a pre-configured game → the copy appears in the list, selected, with editable details. https://github.com/user-attachments/assets/de6df8fa-e1f0-4564-91e8-c286bebdd791 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-22 05:02:00 +02:00
// keep the copying flag up to the end: it stops the re-selection below
// from blanking the password field and stops validateProfile() from
// flagging the half-filled intermediate states
mCopyingProfile = true;
// the copy now exists on disk, so rebuilding the list shows it like any
// other saved profile - on a fresh install this also swaps the welcome
// message for the connection details, which would otherwise leave the
// copy invisible - then select it and fill in its details
fillout_form();
const auto pCopiedItems = findData(*listWidget_profiles, profileName, csmNameRole);
if (!pCopiedItems.isEmpty()) {
listWidget_profiles->setCurrentItem(pCopiedItems.first());
}
fix: copying of default profiles after fresh install (#9317) ## fix: copying default and welcome profiles now produces a working copy ### Brief overview of PR changes/additions - Makes the **Copy** and **Copy settings only** buttons work for default and welcome profiles. - When the source profile has no folder on disk, writes its displayed connection data (URL, port, SSL, login, website, description) into the new profile so the copy is functional and persists. - Improves the first-run user experience for copying profiles. ### Motivation for adding to Mudlet Previously, copying a default or welcome profile appeared to succeed but produced a broken profile: the connect button stayed disabled and the copy vanished once the connection screen was reopened. Default profiles only exist in memory until connected to or saved, so there was no folder for the copy operation to copy from. This makes copying actually work and improves the first-run experience. ### Other info (issues closed, discussion etc) - Fixes "Copy" button does not work properly immediately after fresh install (#9247). - Supersedes #9256; per the consensus there, this makes copying work for default profiles instead of disabling the button. - **Root cause:** default profiles are generated dynamically and are not available as on-disk profiles for copy operations. - No new tests added yet; changes are limited to the copy action handling and profile data writing.
2026-07-03 12:02:11 +05:30
{
fix: show connection details when picking a game on a fresh install (#9451) #### Brief overview of PR changes/additions - Selecting a game on a first-ever launch now swaps the welcome message for the connection details and restores the dialog height - Programmatic selections (startup pre-selection, password-migration refreshes) still show the welcome message - Copying a pre-configured game now rebuilds the list and selects the copy with its details filled in #### Motivation for adding to Mudlet On a fresh install, clicking a game filled hidden fields and appeared to do nothing - a dead end for the very first thing a new user does. #### Other info (issues closed, discussion etc) Closes #3930 **Test case:** Fresh install (empty config dir) → connection dialog shows the welcome message → click any game → connection details appear filled in. Copy a pre-configured game → the copy appears in the list, selected, with editable details. https://github.com/user-attachments/assets/de6df8fa-e1f0-4564-91e8-c286bebdd791 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-22 05:02:00 +02:00
const QSignalBlocker nameBlocker(profile_name_entry);
fix: copying of default profiles after fresh install (#9317) ## fix: copying default and welcome profiles now produces a working copy ### Brief overview of PR changes/additions - Makes the **Copy** and **Copy settings only** buttons work for default and welcome profiles. - When the source profile has no folder on disk, writes its displayed connection data (URL, port, SSL, login, website, description) into the new profile so the copy is functional and persists. - Improves the first-run user experience for copying profiles. ### Motivation for adding to Mudlet Previously, copying a default or welcome profile appeared to succeed but produced a broken profile: the connect button stayed disabled and the copy vanished once the connection screen was reopened. Default profiles only exist in memory until connected to or saved, so there was no folder for the copy operation to copy from. This makes copying actually work and improves the first-run experience. ### Other info (issues closed, discussion etc) - Fixes "Copy" button does not work properly immediately after fresh install (#9247). - Supersedes #9256; per the consensus there, this makes copying work for default profiles instead of disabling the button. - **Root cause:** default profiles are generated dynamically and are not available as on-disk profiles for copy operations. - No new tests added yet; changes are limited to the copy action handling and profile data writing.
2026-07-03 12:02:11 +05:30
const QSignalBlocker urlBlocker(host_name_entry);
const QSignalBlocker portBlocker(port_entry);
const QSignalBlocker sslBlocker(port_ssl_tsl);
const QSignalBlocker loginBlocker(login_entry);
fix: show connection details when picking a game on a fresh install (#9451) #### Brief overview of PR changes/additions - Selecting a game on a first-ever launch now swaps the welcome message for the connection details and restores the dialog height - Programmatic selections (startup pre-selection, password-migration refreshes) still show the welcome message - Copying a pre-configured game now rebuilds the list and selects the copy with its details filled in #### Motivation for adding to Mudlet On a fresh install, clicking a game filled hidden fields and appeared to do nothing - a dead end for the very first thing a new user does. #### Other info (issues closed, discussion etc) Closes #3930 **Test case:** Fresh install (empty config dir) → connection dialog shows the welcome message → click any game → connection details appear filled in. Copy a pre-configured game → the copy appears in the list, selected, with editable details. https://github.com/user-attachments/assets/de6df8fa-e1f0-4564-91e8-c286bebdd791 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-22 05:02:00 +02:00
profile_name_entry->setText(profileName);
fix: copying of default profiles after fresh install (#9317) ## fix: copying default and welcome profiles now produces a working copy ### Brief overview of PR changes/additions - Makes the **Copy** and **Copy settings only** buttons work for default and welcome profiles. - When the source profile has no folder on disk, writes its displayed connection data (URL, port, SSL, login, website, description) into the new profile so the copy is functional and persists. - Improves the first-run user experience for copying profiles. ### Motivation for adding to Mudlet Previously, copying a default or welcome profile appeared to succeed but produced a broken profile: the connect button stayed disabled and the copy vanished once the connection screen was reopened. Default profiles only exist in memory until connected to or saved, so there was no folder for the copy operation to copy from. This makes copying actually work and improves the first-run experience. ### Other info (issues closed, discussion etc) - Fixes "Copy" button does not work properly immediately after fresh install (#9247). - Supersedes #9256; per the consensus there, this makes copying work for default profiles instead of disabling the button. - **Root cause:** default profiles are generated dynamically and are not available as on-disk profiles for copy operations. - No new tests added yet; changes are limited to the copy action handling and profile data writing.
2026-07-03 12:02:11 +05:30
host_name_entry->setText(data.host);
port_entry->setText(data.port);
port_ssl_tsl->setChecked(data.sslTsl == Qt::Checked);
login_entry->setText(data.login);
website_entry->setText(data.website);
website_entry->setVisible(!data.website.isEmpty());
mud_description_textedit->setPlainText(data.description);
}
slot_updateUrl(data.host);
slot_updatePort(data.port);
slot_updateSslTslPort(data.sslTsl);
if (!data.login.isEmpty()) {
writeProfileData(profileName, qsl("login"), data.login);
}
if (!data.website.isEmpty()) {
writeProfileData(profileName, qsl("website"), data.website);
}
if (!data.description.isEmpty()) {
writeProfileData(profileName, qsl("description"), data.description);
}
{
const QSignalBlocker blocker(character_password_entry);
character_password_entry->setText(oldPassword);
}
if (mudlet::self()->storingPasswordsSecurely() && !oldPassword.trimmed().isEmpty()) {
writeSecurePassword(profileName, oldPassword);
}
fix: show connection details when picking a game on a fresh install (#9451) #### Brief overview of PR changes/additions - Selecting a game on a first-ever launch now swaps the welcome message for the connection details and restores the dialog height - Programmatic selections (startup pre-selection, password-migration refreshes) still show the welcome message - Copying a pre-configured game now rebuilds the list and selects the copy with its details filled in #### Motivation for adding to Mudlet On a fresh install, clicking a game filled hidden fields and appeared to do nothing - a dead end for the very first thing a new user does. #### Other info (issues closed, discussion etc) Closes #3930 **Test case:** Fresh install (empty config dir) → connection dialog shows the welcome message → click any game → connection details appear filled in. Copy a pre-configured game → the copy appears in the list, selected, with editable details. https://github.com/user-attachments/assets/de6df8fa-e1f0-4564-91e8-c286bebdd791 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-22 05:02:00 +02:00
mCopyingProfile = false;
validateProfile();
fix: copying of default profiles after fresh install (#9317) ## fix: copying default and welcome profiles now produces a working copy ### Brief overview of PR changes/additions - Makes the **Copy** and **Copy settings only** buttons work for default and welcome profiles. - When the source profile has no folder on disk, writes its displayed connection data (URL, port, SSL, login, website, description) into the new profile so the copy is functional and persists. - Improves the first-run user experience for copying profiles. ### Motivation for adding to Mudlet Previously, copying a default or welcome profile appeared to succeed but produced a broken profile: the connect button stayed disabled and the copy vanished once the connection screen was reopened. Default profiles only exist in memory until connected to or saved, so there was no folder for the copy operation to copy from. This makes copying actually work and improves the first-run experience. ### Other info (issues closed, discussion etc) - Fixes "Copy" button does not work properly immediately after fresh install (#9247). - Supersedes #9256; per the consensus there, this makes copying work for default profiles instead of disabling the button. - **Root cause:** default profiles are generated dynamically and are not available as on-disk profiles for copy operations. - No new tests added yet; changes are limited to the copy action handling and profile data writing.
2026-07-03 12:02:11 +05:30
}
Infrastructure: tidy up naming of SLOT methods and their usage - Part 5 (last) (#6266) When Qt's slot/signal system is used to invoke a method there is some overhead - so it makes sense to ensure developers can spot all such methods (functions). We have tried to do this with a `slot_` prefix to the methods we create but it has not been applied uniformly. This PR is intended to conclude helping with this by more rigorously doing so - the names changed herein should all follow a `slot_`*camelCaseMethodName* style. In addition some methods were detected that are not currently used or which are not actually used via the signal/slot system, these have been commented out or have had the prefix removed and the declaration in the relevant header file moved as appropriate. There were two similar sets of (not prefixed with `slot_`) slots in the Profile preferences class that adjusted the colour settings separately for the main console and the mapper the latter had the same names but with a `2` suffix. To made it more clear I have changed them to include `Map` in their names instead. Also, the NON-slot method: `(void) dlgProfilePreferences::setColor(QPushButton*, QColor&, bool)` has been renamed to: `(void) dlgProfilePreferences::setButtonAndProfileColor(QPushButton*, QColor&, bool)` so that it is clearly distinguishable from built in Qt methods that are also called `setColor` - though which do have different signatures! For reference the changes made are: * `TConsole::slot_stop_all_triggers(...)` ==> `TConsole::slot_stopAllItems(...)` * `dlgConnectionProfiles::slot_copy_profile()` ==> `dlgConnectionProfiles::slot_copyProfile()` * `dlgConnectionProfiles::slot_copy_profilesettings_only()` ==> `dlgConnectionProfiles::slot_copyOnlySettingsOfProfile()` * `dlgConnectionProfiles::slot_deleteprofile_check(...)` ==> `dlgConnectionProfiles::slot_deleteProfileCheck(...)` * `dlgConnectionProfiles::slot_password_deleted(...)` ==> `dlgConnectionProfiles::slot_passwordDeleted(...)` * `dlgConnectionProfiles::slot_password_saved(...) ==> `dlgConnectionProfiles::slot_passwordSaved(...)` * `dlgConnectionProfiles::slot_profile_menu(...)` ==> `dlgConnectionProfiles::slot_profileContextMenu(...)` * `dlgConnectionProfiles::slot_reset_custom_icon()` ==> `dlgConnectionProfiles::slot_resetCustomIcon()` * `dlgConnectionProfiles::slot_set_custom_icon()` ==> `dlgConnectionProfiles::slot_setCustomIcon()` * `dlgConnectionProfiles::slot_set_custom_color()` ==> `dlgConnectionProfiles::slot_setCustomColor()` * `dlgConnectionProfiles::slot_update_autologin(...)` ==> `dlgConnectionProfiles::slot_updateAutoConnect(...)` * `dlgConnectionProfiles::slot_update_autoreconnect(...)` ==> `dlgConnectionProfiles::slot_updateAutoReconnect(...)` * `dlgConnectionProfiles::slot_update_description()` ==> `dlgConnectionProfiles::slot_updateDescription()` * `dlgConnectionProfiles::slot_update_discord_optin(...)` ==> `dlgConnectionProfiles::slot_updateDiscordOptIn(...)` * `dlgProfilePreferences::copyMap()` ==> `dlgProfilePreferences::slot_copyMap()` * `dlgProfilePreferences::downloadMap()` ==> `dlgProfilePreferences::slot_downloadMap()` * `dlgProfilePreferences::hideActionLabel()` ==> `dlgProfilePreferences::slot_hideActionLabel()` * `dlgProfilePreferences::loadMap()` ==> `dlgProfilePreferences::slot_loadMap()` * `dlgProfilePreferences::resetColors()` ==> `dlgProfilePreferences::slot_resetColors()` * `dlgProfilePreferences::resetColors2()` ==> `dlgProfilePreferences::slot_resetMapColors()` * `dlgProfilePreferences::saveMap()` ==> `dlgProfilePreferences::slot_saveMap()` * `dlgProfilePreferences::setBgColor()` ==> `dlgProfilePreferences::slot_setBgColor()` * `dlgProfilePreferences::setBgColor2()` ==> `dlgProfilePreferences::slot_setMapBgColor()` * `dlgProfilePreferences::setColorBlack()` ==> `dlgProfilePreferences::slot_setColorBlack()` * `dlgProfilePreferences::setColorBlack2()` ==> `dlgProfilePreferences::slot_setMapColorBlack()` * `dlgProfilePreferences::setColorBlue()` ==> `dlgProfilePreferences::slot_setColorBlue()` * `dlgProfilePreferences::setColorCyan()` ==> `dlgProfilePreferences::slot_setColorCyan()` * `dlgProfilePreferences::setColorBlue2()` ==> `dlgProfilePreferences::slot_setMapColorBlue()` * `dlgProfilePreferences::setColorCyan2()` ==> `dlgProfilePreferences::slot_setMapColorCyan()` * `dlgProfilePreferences::setColorGreen()` ==> `dlgProfilePreferences::slot_setColorGreen()` * `dlgProfilePreferences::setColorGreen2()` ==> `dlgProfilePreferences::slot_setMapColorGreen()` * `dlgProfilePreferences::setColorLightBlack()` ==> `dlgProfilePreferences::slot_setColorLightBlack()` * `dlgProfilePreferences::setColorLightBlack2()` ==> `dlgProfilePreferences::slot_setMapColorLightBlack()` * `dlgProfilePreferences::setColorLightBlue()` ==> `dlgProfilePreferences::slot_setColorLightBlue()` * `dlgProfilePreferences::setColorLightBlue2()` ==> `dlgProfilePreferences::slot_setMapColorLightBlue()` * `dlgProfilePreferences::setColorLightCyan()` ==> `dlgProfilePreferences::slot_setColorLightCyan()` * `dlgProfilePreferences::setColorLightCyan2()` ==> `dlgProfilePreferences::slot_setMapColorLightCyan()` * `dlgProfilePreferences::setColorLightGreen()` ==> `dlgProfilePreferences::slot_setColorLightGreen()` * `dlgProfilePreferences::setColorLightGreen2()` ==> `dlgProfilePreferences::slot_setMapColorLightGreen()` * `dlgProfilePreferences::setColorLightMagenta()` ==> `dlgProfilePreferences::slot_setColorLightMagenta()` * `dlgProfilePreferences::setColorLightMagenta2()` ==> `dlgProfilePreferences::slot_setMapColorLightMagenta()` * `dlgProfilePreferences::setColorLightRed()` ==> `dlgProfilePreferences::slot_setColorLightRed()` * `dlgProfilePreferences::setColorLightRed2()` ==> `dlgProfilePreferences::slot_setMapColorLightRed()` * `dlgProfilePreferences::setColorLightWhite()` ==> `dlgProfilePreferences::slot_setColorLightWhite()` * `dlgProfilePreferences::setColorLightWhite2()` ==> `dlgProfilePreferences::slot_setMapColorLightWhite()` * `dlgProfilePreferences::setColorLightYellow()` ==> `dlgProfilePreferences::slot_setColorLightYellow()` * `dlgProfilePreferences::setColorLightYellow2()` ==> `dlgProfilePreferences::slot_setMapColorLightYellow()` * `dlgProfilePreferences::setColorMagenta()` ==> `dlgProfilePreferences::slot_setColorMagenta()` * `dlgProfilePreferences::setColorMagenta2()` ==> `dlgProfilePreferences::slot_setMapColorMagenta()` * `dlgProfilePreferences::setColorRed2()` ==> `dlgProfilePreferences::slot_setMapColorRed()` * `dlgProfilePreferences::setColorRed()` ==> `dlgProfilePreferences::slot_setColorRed()` * `dlgProfilePreferences::setColorWhite()` ==> `dlgProfilePreferences::slot_setColorWhite()` * `dlgProfilePreferences::setColorWhite2()` ==> `dlgProfilePreferences::slot_setMapColorWhite()` * `dlgProfilePreferences::setColorYellow()` ==> `dlgProfilePreferences::slot_setColorYellow()` * `dlgProfilePreferences::setColorYellow2()` ==> `dlgProfilePreferences::slot_setMapColorYellow()` * `dlgProfilePreferences::setCommandBgColor()` ==> `dlgProfilePreferences::slot_setCommandBgColor()` * `dlgProfilePreferences::setCommandFgColor()` ==> `dlgProfilePreferences::slot_setCommandFgColor()` * `dlgProfilePreferences::setCommandLineBgColor()` ==> `dlgProfilePreferences::slot_setCommandLineBgColor()` * `dlgProfilePreferences::setCommandLineFgColor()` ==> `dlgProfilePreferences::slot_setCommandLineFgColor()` * `dlgProfilePreferences::setDisplayFont()` ==> `dlgProfilePreferences::slot_setDisplayFont()` * `dlgProfilePreferences::setFgColor()` ==> `dlgProfilePreferences::slot_setFgColor()` * `dlgProfilePreferences::setFgColor2()` ==> `dlgProfilePreferences::slot_setMapExitsColor()` * `dlgProfilePreferences::setFontSize()` ==> `dlgProfilePreferences::slot_setFontSize()` * `dlgProfilePreferences::setMapInfoBackground()` ==> `dlgProfilePreferences::slot_setMapInfoBgColor()` * `dlgProfilePreferences::setRoomBorderColor()` ==> `dlgProfilePreferences::slot_setMapRoomBorderColor()` * `dlgProfilePreferences::slot_script_selected(...)` ==> `dlgProfilePreferences::slot_scriptSelected(...)` * `dlgProfilePreferences::slot_theme_selected(...)` ==> `dlgProfilePreferences::slot_themeSelected(...)` * `dlgRoomSymbol::colorRejected()` ==> `dlgRoomSymbol::slot_colorRejected()` * `dlgRoomSymbol::colorSelected(...)` ==> `dlgRoomSymbol::slot_colorSelected(...)` * `dlgRoomSymbol::currentColorChanged(...)` ==> `dlgRoomSymbol::slot_currentColorChanged(...)` * `dlgRoomSymbol::openColorSelector()` ==> `dlgRoomSymbol::slot_openColorSelector()` * `dlgRoomSymbol::resetColor()` ==> `dlgRoomSymbol::slot_resetColors()` * `dlgRoomSymbol::updatePreview()` ==> `dlgRoomSymbol::slot_updatePreview()` * `dlgTriggerEditor::slot_show_vars()` ==> `dlgTriggerEditor::slot_showVariables()` * `dlgTriggerEditor::slot_var_changed(...)` ==> `dlgTriggerEditor::slot_variableChanged(...)` * `dlgTriggerEditor::slot_var_selected(...)` ==> `dlgTriggerEditor::slot_variableSelected(...)` * `mudlet::slot_check_manual_update()` ==> `mudlet::slot_manualUpdateCheck()` * `mudlet::slot_close_current_profile()` ==> `mudlet::slot_closeCurrentProfile()` * `mudlet::slot_close_profile_requested(...)` ==> `mudlet::slot_closeProfileRequested(...)` * `mudlet::slot_connection_dlg_finished(...)` ==> `mudlet::slot_connectionDialogueFinished(...)` * `mudlet::slot_module_manager()` ==> `mudlet::slot_moduleManager()` * `mudlet::slot_mudlet_discord()` ==> `mudlet::slot_mudletDiscord()` * `mudlet::slot_multi_view(...)` ==> `mudlet::slot_multiView(const bool state)` * `mudlet::slot_package_manager()` ==> `mudlet::slot_packageManager()` * `mudlet::slot_package_exporter()` ==> `mudlet::slot_packageExporter()` * `mudlet::slot_timer_fires()` ==> `mudlet::slot_timerFires()` * `mudlet::slot_toggle_multi_view()` ==> `mudlet::slot_toggleMultiView()` Also the names for these in particular have been changed to make more sense: * `dlgProfilePreferences::slot_chooseProfilesChanged()` ==> `dlgProfilePreferences::slot_chosenProfilesChanged()` * `dlgProfilePreferences::slot_editor_tab_selected(...)` ==> `dlgProfilePreferences::slot_tabChanged(...)` * `dlgProfilePreferences::slot_passwords_location_changed(...)` ==> `dlgProfilePreferences::slot_passwordStorageLocationChanged(...)` * `dlgProfilePreferences::slot_save_and_exit()` ==> `dlgProfilePreferences::slot_saveAndClose()` * `dlgTriggerEditor::slot_toggleHiddenVar(...)` ==> `dlgTriggerEditor::slot_hideVariable(...)` - changed to distinguish it from `slot_toggleHiddenVariables(...)` * `dlgTriggerEditor::slot_item_selected_save(...)` ==> `dlgTriggerEditor::slot_saveSelectedItem(...)` * `mudlet::slot_discord()` ==> `mudlet::slot_profileDiscord()` - changed to distinguish it from `slot_mudletDiscord()` Not currently used and commented out: * `dlgProfilePreferences::setCommandLineFont()` ==> `dlgProfilePreferences::slot_setCommandLineFont()` Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-08-29 14:27:13 +02:00
void dlgConnectionProfiles::slot_copyOnlySettingsOfProfile()
Add 'Copy profile (settings only)' button (#2779) * Added button and got connection info copied * Add copy profile with settings only * Tweak UI style * Cleanup * Remove duplicates * Remove another debug cout * Fix names getting duplicated * Remove debug statement * Fix unnecessary return
2019-07-17 07:33:47 +02:00
{
QString profile_name;
QString oldname;
QListWidgetItem* pItem;
fix: copying of default profiles after fresh install (#9317) ## fix: copying default and welcome profiles now produces a working copy ### Brief overview of PR changes/additions - Makes the **Copy** and **Copy settings only** buttons work for default and welcome profiles. - When the source profile has no folder on disk, writes its displayed connection data (URL, port, SSL, login, website, description) into the new profile so the copy is functional and persists. - Improves the first-run user experience for copying profiles. ### Motivation for adding to Mudlet Previously, copying a default or welcome profile appeared to succeed but produced a broken profile: the connect button stayed disabled and the copy vanished once the connection screen was reopened. Default profiles only exist in memory until connected to or saved, so there was no folder for the copy operation to copy from. This makes copying actually work and improves the first-run experience. ### Other info (issues closed, discussion etc) - Fixes "Copy" button does not work properly immediately after fresh install (#9247). - Supersedes #9256; per the consensus there, this makes copying work for default profiles instead of disabling the button. - **Root cause:** default profiles are generated dynamically and are not available as on-disk profiles for copy operations. - No new tests added yet; changes are limited to the copy action handling and profile data writing.
2026-07-03 12:02:11 +05:30
const auto oldPassword = character_password_entry->text();
const CopiedProfileData data = captureProfileData();
Add 'Copy profile (settings only)' button (#2779) * Added button and got connection info copied * Add copy profile with settings only * Tweak UI style * Cleanup * Remove duplicates * Remove another debug cout * Fix names getting duplicated * Remove debug statement * Fix unnecessary return
2019-07-17 07:33:47 +02:00
if (!copyProfileWidget(profile_name, oldname, pItem)) {
return;
}
fix: copying of default profiles after fresh install (#9317) ## fix: copying default and welcome profiles now produces a working copy ### Brief overview of PR changes/additions - Makes the **Copy** and **Copy settings only** buttons work for default and welcome profiles. - When the source profile has no folder on disk, writes its displayed connection data (URL, port, SSL, login, website, description) into the new profile so the copy is functional and persists. - Improves the first-run user experience for copying profiles. ### Motivation for adding to Mudlet Previously, copying a default or welcome profile appeared to succeed but produced a broken profile: the connect button stayed disabled and the copy vanished once the connection screen was reopened. Default profiles only exist in memory until connected to or saved, so there was no folder for the copy operation to copy from. This makes copying actually work and improves the first-run experience. ### Other info (issues closed, discussion etc) - Fixes "Copy" button does not work properly immediately after fresh install (#9247). - Supersedes #9256; per the consensus there, this makes copying work for default profiles instead of disabling the button. - **Root cause:** default profiles are generated dynamically and are not available as on-disk profiles for copy operations. - No new tests added yet; changes are limited to the copy action handling and profile data writing.
2026-07-03 12:02:11 +05:30
const QDir oldProfileDir(mudlet::getMudletPath(enums::profileHomePath, oldname));
if (!oldProfileDir.exists()) {
saveDefaultProfileCopy(profile_name, data, oldPassword);
return;
}
Add 'Copy profile (settings only)' button (#2779) * Added button and got connection info copied * Add copy profile with settings only * Tweak UI style * Cleanup * Remove duplicates * Remove another debug cout * Fix names getting duplicated * Remove debug statement * Fix unnecessary return
2019-07-17 07:33:47 +02:00
Infrastructure: add `enums.h` (#7646) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Add `enums.h` where we can add enums and flags to be used throughout the application that don't have a more specific place to be, without dragging in giant classes such as mudlet.h or Host.h. Also added `enums::PackageModuleType` to track the magic numbers used throughout package/module code :rocket: #### Motivation for adding to Mudlet Simplify code organisation. #### Other info (issues closed, discussion etc) --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-01-08 10:04:50 +01:00
const QDir newProfileDir(mudlet::getMudletPath(enums::profileHomePath, profile_name));
Add 'Copy profile (settings only)' button (#2779) * Added button and got connection info copied * Add copy profile with settings only * Tweak UI style * Cleanup * Remove duplicates * Remove another debug cout * Fix names getting duplicated * Remove debug statement * Fix unnecessary return
2019-07-17 07:33:47 +02:00
newProfileDir.mkpath(newProfileDir.path());
if (!newProfileDir.exists()) {
return;
}
// copy relevant profile files
Fix reduce c++20warnings (#7638) #### Brief overview of PR changes/additions 1. Adds explicit ‘this’ or ‘*this’ capture to lambdas where required (not in static ones). 2. Rephrases some combinations of Qt `enum`s that whilst acceptable for C++17 upset the later one. For the non-key related ones which are provided a `int`s arguments to a method this is sufficient; For Qt 6 there are some additional methods that overcome the "incompatibility" of combining such different `enum`s but those have not been back ported to the Qt 5.15.8 I have - despite what https://bugreports.qt.io/browse/QTBUG-99948 says - so fixes for combining QKey and QKeyModifier have been left out of this PR. 3. Removes a couple of unused variables. 4. Adds our `qsl(...)` wrapper about some raw C-string literals used in a loop. 5. Rewrite part of the qmake project file so the logic and choices are correct. #### Motivation for adding to Mudlet 1. To eliminate the following type of warning when building with a C++20 compiler: "warning: implicit capture of ‘this’ via ‘[=]’ is deprecated in C++20 [-Wdeprecated]" 2. To eliminate the following type of warning when building with a C++20 compiler: * warning: bitwise operation between different enumeration types ‘QFont::Weight’ and ‘QFont::StyleHint’ is deprecated [-Wdeprecated-enum-enum-conversion] * warning: bitwise operation between different enumeration types ‘Qt::TextFlag’ and ‘Qt::AlignmentFlag’ is deprecated [-Wdeprecated-enum-enum-conversion] 3. To eliminate the following type of warning when building with a C++20 compiler: "warning: unused variable ‘pHost’ [-Wunused-variable]" 4. To eliminate the following type of warning when building with a C++20 compiler: "warning: loop variable ‘file’ of type ‘const QString&’ binds to a temporary constructed from type ‘const char* const’ [-Wrange-loop-construct]" 5. The previous logic was (incorrect) IF Qt Major version is less than 5 OR (if Qt Major version is less than 6 AND if Qt Minor version is less than 12)) THEN add `-std=c++20` to `QMAKE_CXXFLAGS` ELSE add `c++2a` to `CONFIG` This is borked because we have already rejected Qt versions less than 5.14 so the logic will **always** end up in the **ELSE** case, and whilst Qt 5.15 is documented as accepting `CONFIG += c++2a` (and `c++2b`) the earliest Qt 6.x version describes `c++2a` as an obsolete alias for `c++20` (in https://doc.qt.io/qt-6.2/qmake-variable-reference.html). #### Other info (issues closed, discussion etc) 3. The code in the `QFont` cases contains errors that have been copied from bogus QFont creation code going back to the very first (well second) commit in the git history. This contained calls of the form `QFont font("Courier New", 10, QFont::Courier)` however even the Qt 4.8 documentation does not list a constructor of that form but instead has: `QFont(const QString & family, int pointSize = -1, int weight = -1, bool italic = false)` the third argument could possibly be `QFont::Normal` (50) or `QFont::Bold` (75) however the value of `QFont::Courier` is `2` but it is for a completely different purpose, that of the font matching strategy ("the font matcher prefers fixed pitch fonts.") but that is not something that can be set as an argument to the font constructor! As it happens the combination of `QFont::Bold | QFont::Serif | QFont::PreferMatch | QFont::PreferAntialias` that was being used numerically equals 75 + 2 + 32 + 128 = 227 - and the scale that Qt actually uses only goes from 0 to 99! 5. This change makes the code match the comments! Overall all the changes in this PR means that https://github.com/Mudlet/Mudlet/pull/7613 is not required after all - at least for Mudlet's own code - though there are still some warnings from the edbee-lib sub-module. --------- Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2025-02-10 11:59:45 +00:00
for (const QString& file : {qsl("url"), qsl("port"), qsl("password"), qsl("login"), qsl("description")}) {
Infrastructure: add `enums.h` (#7646) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Add `enums.h` where we can add enums and flags to be used throughout the application that don't have a more specific place to be, without dragging in giant classes such as mudlet.h or Host.h. Also added `enums::PackageModuleType` to track the magic numbers used throughout package/module code :rocket: #### Motivation for adding to Mudlet Simplify code organisation. #### Other info (issues closed, discussion etc) --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-01-08 10:04:50 +01:00
auto filePath = qsl("%1/%2").arg(mudlet::getMudletPath(enums::profileHomePath, oldname), file);
auto newFilePath = qsl("%1/%2").arg(mudlet::getMudletPath(enums::profileHomePath, profile_name), file);
Add 'Copy profile (settings only)' button (#2779) * Added button and got connection info copied * Add copy profile with settings only * Tweak UI style * Cleanup * Remove duplicates * Remove another debug cout * Fix names getting duplicated * Remove debug statement * Fix unnecessary return
2019-07-17 07:33:47 +02:00
QFile::copy(filePath, newFilePath);
}
copyProfileSettingsOnly(oldname, profile_name);
mProfileList << profile_name;
Infrastructure: tidy up naming of SLOT methods and their usage - Part 2 (#6255) When Qt's slot/signal system is used to invoke a method there is some overhead - so it makes sense to ensure developers can spot all such methods (functions). We have tried to do this with a `slot_` prefix to the methods we create but it has not been applied uniformly. This PR (and one or more to follow) is intended to help with this by more rigorously doing so - the names changed herein should all follow a `slot_`*camelCaseMethodName* style. In addition some methods were detected that are not currently used or which are not actually used via the signal/slot system, these have been commented out or have had the prefix removed and the declaration in the relevant header file moved as appropriate. For reference the changes made are: * `TLuaInterpreter::slotDeleteSender(...)` ==> `TLuaInterpreter::slot_deleteSender(...)` * `TLuaInterpreter::slotPurge()` ==> `TLuaInterpreter::slot_purge()` * `cTelnet::handle_socket_signal_connected()` ==> `cTelnet::slot_socketConnected()` * `cTelnet::handle_socket_signal_disconnected()` ==> `cTelnet::slot_socketDisconnected()` * `cTelnet::handle_socket_signal_hostFound(...)` ==> `cTelnet::slot_socketHostFound(...)` * `cTelnet::handle_socket_signal_readyRead()` ==> `cTelnet::slot_socketReadyToBeRead()` * `cTelnet::handle_socket_signal_sslError(...)` ==> `cTelnet::slot_socketSslError(...)` * `cTelnet::setDownloadProgress(...)` ==> `cTelnet::slot_setDownloadProgress(...)` * `dlgComposer::cancel()` ==> `dlgComposer::slot_cancel()` * `dlgComposer::save()` ==> `dlgComposer::slot_save()` * `dlgConnectionProfiles::slot_item_clicked(...)` ==> `dlgConnectionProfiles::slot_itemClicked(...)` * `dlgConnectionProfiles::slot_save_name()` ==> `dlgConnectionProfiles::slot_saveName()` * `dlgConnectionProfiles::slot_update_login(...)` ==> `dlgConnectionProfiles::slot_updateLogin(...)` * `dlgConnectionProfiles::slot_update_name(...)` ==> `dlgConnectionProfiles::slot_updateName(...)` * `dlgConnectionProfiles::slot_update_pass(...)` ==> `dlgConnectionProfiles::slot_updatePassword(...)` * `dlgConnectionProfiles::slot_update_port(...)` ==> `dlgConnectionProfiles::slot_updatePort(...)` * `dlgConnectionProfiles::slot_update_SSL_TSL_port(...)` ==> `dlgConnectionProfiles::slot_updateSslTslPort(...)` * `dlgConnectionProfiles::slot_update_url(...)` ==> `dlgConnectionProfiles::slot_updateUrl(...)` * `dlgMapLabel::pickBgColor()` ==> `dlgMapLabel::slot_pickBgColor()` * `dlgMapLabel::pickFgColor()` ==> `dlgMapLabel::slot_pickFgColor()` * `dlgMapLabel::pickFile()` ==> `dlgMapLabel::slot_pickFile()` * `dlgMapLabel::pickFont()` ==> `dlgMapLabel::slot_pickFont()` * `dlgMapLabel::save()` ==> `dlgMapLabel::slot_save()` * `dlgMapLabel::updateControls()` ==> `dlgMapLabel::slot_updateControls()` * `dlgMapLabel::updateControlsVisibility()` ==> `dlgMapLabel::slot_updateControlsVisibility()` Commented out as not being used: * `cTelnet::handle_socket_signal_error()` ==> `cTelnet::slot_socketError()` * `dlgConnectionProfiles::slot_update_website(...) ==> `dlgConnectionProfiles::slot_updateWebsite(const QString& url)` I have my doubts about whether the `dlgMapLabel::save()`/`dlgMapLabel::slot_save()` method is needed at all, as it might be that the `QDialog::accept()` slot could have been inserted into the `QObject::connect(...)` call directly instead...? Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-08-27 10:47:01 +02:00
slot_itemClicked(pItem);
Add 'Copy profile (settings only)' button (#2779) * Added button and got connection info copied * Add copy profile with settings only * Tweak UI style * Cleanup * Remove duplicates * Remove another debug cout * Fix names getting duplicated * Remove debug statement * Fix unnecessary return
2019-07-17 07:33:47 +02:00
}
bool dlgConnectionProfiles::copyProfileWidget(QString& profile_name, QString& oldname, QListWidgetItem*& pItem) const
{
profile_name = profile_name_entry->text().trimmed();
oldname = profile_name;
if (profile_name.isEmpty()) {
return false;
}
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
// prepend n+1 to end of the profile name
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
if (profile_name.at(profile_name.size() - 1).isDigit()) {
int i = 1;
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
do {
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
profile_name = profile_name.left(profile_name.size() - 1) + QString::number(profile_name.at(profile_name.size() - 1).digitValue() + i++);
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
} while (mProfileList.contains(profile_name));
} else {
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
int i = 1;
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
QString profile_name2;
do {
profile_name2 = profile_name + QString::number(i++);
} while (mProfileList.contains(profile_name2));
profile_name = profile_name2;
}
Fix incorrect allocation error handling in a few files (#7130) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions To avoid a potential crash, improve the code's handling of allocation failures by returning a null check instead of throwing an exception. #### Motivation for adding to Mudlet Cleaner code with fewer potential issues #### Other info (issues closed, discussion etc) This document explains what was going on really well: [Incorrect allocation-error handling · Code scanning alert #138 · Mudlet_Mudlet.pdf](https://github.com/Mudlet/Mudlet/files/14232200/Incorrect.allocation-error.handling.Code.scanning.alert.138.Mudlet_Mudlet.pdf)
2024-02-18 18:07:43 +01:00
pItem = new (std::nothrow) QListWidgetItem();
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
if (!pItem) {
Add 'Copy profile (settings only)' button (#2779) * Added button and got connection info copied * Add copy profile with settings only * Tweak UI style * Cleanup * Remove duplicates * Remove another debug cout * Fix names getting duplicated * Remove debug statement * Fix unnecessary return
2019-07-17 07:33:47 +02:00
return false;
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
}
Revise: select profiles by typing the name, keep profile icons (#4440) Restore the text display of the profile name. This is so that the keyboard selection of profiles beginning with a particular letter works again. This will close issue #4283 . This also sets it to the minimum size trying to hide it by setting the font size to 1 - however that still show something (and a font size of zero is NOT valid). Manipulating the QPalette of the QListWidget does not work well enough in the presence of Styles or StyleSheets to be a viable means of hiding the text either. Also in the `dlgConnection` class: * refactor out some highly repetitive code that sets up the predefined Mud icons. * remove warnings and adopts a change introduced into Qt 5.15 for the QLabel::pixmap() which now requires a Qt::ReturnByValue argument to prevent an obsolete code warning and to force a QPixmap to be returned by value and not reference... * remove a warning about: QListWidget::setItemSelected(QListWidgetItem*,bool) being deprecated and switches to the recommended: QListWidgetItem::setSelected(bool) Edit: the last item above may have become redundant as further commits amalgamated into this PR may have taken out these lines anyhow! Change the custom icon generator so that there is NOT a dependency on the position in the list for the colours used. This means that the same name will always have the same colours - which will help the user to pick out a particular profile as it will always look the same no matter if other profiles are added or removed. Remove the colour gradient in the custom icon as it is not thought to be useful nowadays. Refactor out the colour icon generator to a single method that is called from more than one place. BugFix: restore odd original way of accessing some QPixmaps This was causing failures in some CI platforms using Qt 5.14. or older. Revise: really frob the custom icon generator This is to try and produce as varied but still readable icons when they are generated entirely on the basis of the MUD name - in a reproducible (though Qt do NOT guarantee repeatable qHash() functionality across Qt versions - so they may not stay *that* constant) manner. Refrob: use a table of fixed colours Using only 15 hues but with 3 different saturation level plus 5 grey-scale one should give enough different icons but not generate them too close to each other for those with normal colour vision... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Kebap <kebap_spam@gmx.net>
2020-12-11 17:53:28 +00:00
setItemName(pItem, profile_name);
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
// add the new widget in
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
listWidget_profiles->addItem(pItem);
Give the Mudlet icon to new profiles that were just copied #5294 (#5392) Give the Mudlet icon to new profiles that were just copied #5294
2021-08-24 10:17:24 +02:00
pItem->setIcon(customIcon(profile_name, std::nullopt));
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
listWidget_profiles->setCurrentItem(pItem);
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
profile_name_entry->setText(profile_name);
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
profile_name_entry->setFocus();
profile_name_entry->selectAll();
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
profile_name_entry->setReadOnly(false);
host_name_entry->setReadOnly(false);
port_entry->setReadOnly(false);
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
Add 'Copy profile (settings only)' button (#2779) * Added button and got connection info copied * Add copy profile with settings only * Tweak UI style * Cleanup * Remove duplicates * Remove another debug cout * Fix names getting duplicated * Remove debug statement * Fix unnecessary return
2019-07-17 07:33:47 +02:00
return true;
}
void dlgConnectionProfiles::copyProfileSettingsOnly(const QString& oldname, const QString& newname)
{
Infrastructure: add `enums.h` (#7646) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Add `enums.h` where we can add enums and flags to be used throughout the application that don't have a more specific place to be, without dragging in giant classes such as mudlet.h or Host.h. Also added `enums::PackageModuleType` to track the magic numbers used throughout package/module code :rocket: #### Motivation for adding to Mudlet Simplify code organisation. #### Other info (issues closed, discussion etc) --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-01-08 10:04:50 +01:00
const QDir oldProfiledir(mudlet::getMudletPath(enums::profileXmlFilesPath, oldname));
const QDir newProfiledir(mudlet::getMudletPath(enums::profileXmlFilesPath, newname));
Add 'Copy profile (settings only)' button (#2779) * Added button and got connection info copied * Add copy profile with settings only * Tweak UI style * Cleanup * Remove duplicates * Remove another debug cout * Fix names getting duplicated * Remove debug statement * Fix unnecessary return
2019-07-17 07:33:47 +02:00
newProfiledir.mkpath(newProfiledir.absolutePath());
fix: stop crashes while saving and profiles losing their triggers (#9557) #### Brief overview of PR changes/additions - Profile loading now only considers real `*.xml` saves: an empty QSaveFile temporary left behind by a crash during a save can no longer be loaded as "the profile", which made a profile open with its connection settings intact but every trigger/script seemingly gone. Affected profiles heal themselves on next load by falling back to the newest real save. - Packages that uninstall themselves from their own timer script or event-handler script (a common auto-updater pattern) no longer free the very objects still executing: `TimerUnit`/`ScriptUnit` uninstall now defers deletion while `TTimer::execute()` / `Host::raiseEvent()` are on the call stack, completing the #9337/#9383 fix that already covered triggers/aliases/keys. Deferred timer deletes are flushed before the queued post-uninstall save runs, so removed items cannot be serialized back into the profile. - `Host::saveProfile()`'s background module task no longer reads `writers`/`saveFutures` concurrently with the main thread (data race in the profile save path). #### Motivation for adding to Mudlet Fixes a real-world heap-corruption crash cluster (Sentry MUDLET-32 / MUDLET-2S / MUDLET-48: `STATUS_HEAP_CORRUPTION` on 4.21.0/4.21.1, frames touching lua51/Qt6Core/libpugixml, breadcrumbs showing package uninstall activity around saves) and the profile data loss it caused. #### Other info (issues closed, discussion etc) Root cause of the crashes: #9111 (in the 4.20.1 → 4.21.0 window) changed the `*Unit::uninstall()` methods from unregister-only to immediate `delete`. A package script calling `uninstallPackage()` on its own package then freed objects still on the call stack - use-after-free that poisons the heap, typically detected slightly later during the background save serialization (hence the pugixml/lua frames, aborts mid-save, and zero-byte `....xml.XXXXXX` QSaveFile leftovers in `current/`). #9383 fixed the trigger/alias/key cases; this completes timers and scripts, which reproduce under ASan on current development (heap-use-after-free in `Tree<TScript>::isActive()` / `TTimer::execute()`). Data-loss mechanism (generic): a crash mid-save leaves a 0-byte QSaveFile temporary as the newest file in `current/`; `mudlet::loadProfile()` picked the newest file of any name, tried to load the empty temp, and the profile opened "gutted" (connection details live in separate files and survived). Verified end-to-end with affected profile data and covered by a synthetic regression test. Both new functional tests fail on pre-fix code (`PackageSelfUninstallTest` trips ASan heap-use-after-free; `ProfileLoadTempFileTest` reproduces the data loss) and pass with the fix; full functional suite green (24/24). Known remaining (pre-existing) issue documented in-code at `Host::pendingXmlSaveFutures()`: module writing still touches `writers` from the background task for profiles that use modules; fixing that properly means moving module serialization back to the main thread and deserves its own PR. **Test case:** 1. Create a package containing a timer or event-handler script that calls `uninstallPackage()` on its own package, and let it fire - no crash, package cleanly removed, next save does not resurrect it. 2. Simulate an interrupted save: place an empty file named like `2026-01-01#12-00-00.xml.AbCdEf` in a profile's `current/` folder with the newest timestamp - the profile still loads the newest real save with all triggers intact, and the temporary no longer appears in Connect → Options → Profile history. 3. `ctest -R "ProfileLoadTempFileTest|PackageSelfUninstallTest"` in an ASan (default Debug) build. Assisted-by: Claude:claude-fable-5 Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
2026-07-30 10:49:10 +02:00
// Only copy from a real profile save (*.xml): the newest file of any name could
// be a leftover QSaveFile temporary from an interrupted save (e.g. "....xml.AbCdEf")
QStringList entries = oldProfiledir.entryList(QStringList{qsl("*.xml")}, QDir::Files | QDir::NoDotAndDotDot, QDir::Time);
Add 'Copy profile (settings only)' button (#2779) * Added button and got connection info copied * Add copy profile with settings only * Tweak UI style * Cleanup * Remove duplicates * Remove another debug cout * Fix names getting duplicated * Remove debug statement * Fix unnecessary return
2019-07-17 07:33:47 +02:00
if (entries.empty()) {
Make the copy button work
2009-01-30 01:25:11 -05:00
return;
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
}
misc
2010-03-15 09:37:16 +01:00
Add 'Copy profile (settings only)' button (#2779) * Added button and got connection info copied * Add copy profile with settings only * Tweak UI style * Cleanup * Remove duplicates * Remove another debug cout * Fix names getting duplicated * Remove debug statement * Fix unnecessary return
2019-07-17 07:33:47 +02:00
auto copySettingsFromFile = oldProfiledir.absoluteFilePath(entries.first());
pugi::xml_document newProfileXml;
if (extractSettingsFromProfile(newProfileXml, copySettingsFromFile)) {
saveProfileCopy(newProfiledir, newProfileXml);
}
}
bool dlgConnectionProfiles::extractSettingsFromProfile(pugi::xml_document& newProfile, const QString& copySettingsFrom)
{
pugi::xml_document oldProfile;
Infrastructure: mark read-only variables as const (#6843) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Mark read-only variables as const - that is, not intended to change after they've been declared #### Motivation for adding to Mudlet So we don't change them by accident later on, and also to clearly state intentions for the variables #### Other info (issues closed, discussion etc) This is also recommended by the [C++ Core Guidelines](https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#es25-declare-an-object-const-or-constexpr-unless-you-want-to-modify-its-value-later-on)
2023-05-14 15:06:15 +02:00
pugi::xml_parse_result const result = oldProfile.load_file(copySettingsFrom.toUtf8().constData());
Add 'Copy profile (settings only)' button (#2779) * Added button and got connection info copied * Add copy profile with settings only * Tweak UI style * Cleanup * Remove duplicates * Remove another debug cout * Fix names getting duplicated * Remove debug statement * Fix unnecessary return
2019-07-17 07:33:47 +02:00
if (!result) {
qWarning() << "dlgConnectionProfiles::copyProfileSettingsOnly() ERROR: couldn't parse" << copySettingsFrom;
qWarning() << "Parse error: " << result.description() << ", character pos= " << result.offset;
return false;
}
// write header
auto declaration = newProfile.prepend_child(pugi::node_declaration);
declaration.append_attribute("version") = "1.0";
declaration.append_attribute("encoding") = "UTF-8";
newProfile.append_child(pugi::node_doctype).set_value("MudletPackage");
// copy /MudletPackage attributes
auto mudletPackage = newProfile.append_child("MudletPackage");
const auto attributeNodes = oldProfile.select_nodes("/MudletPackage/attribute::*");
for (pugi::xpath_node_set::const_iterator it = attributeNodes.begin(); it != attributeNodes.end(); ++it) {
auto node = *it;
mudletPackage.append_attribute(node.attribute().name()) = node.attribute().value();
}
// remove installed packages/modules
const auto hostPackageResults = oldProfile.select_nodes("/MudletPackage/HostPackage");
Infrastructure: mark read-only variables as const (#6843) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Mark read-only variables as const - that is, not intended to change after they've been declared #### Motivation for adding to Mudlet So we don't change them by accident later on, and also to clearly state intentions for the variables #### Other info (issues closed, discussion etc) This is also recommended by the [C++ Core Guidelines](https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#es25-declare-an-object-const-or-constexpr-unless-you-want-to-modify-its-value-later-on)
2023-05-14 15:06:15 +02:00
pugi::xml_node const hostPackage = hostPackageResults.first().node();
Add 'Copy profile (settings only)' button (#2779) * Added button and got connection info copied * Add copy profile with settings only * Tweak UI style * Cleanup * Remove duplicates * Remove another debug cout * Fix names getting duplicated * Remove debug statement * Fix unnecessary return
2019-07-17 07:33:47 +02:00
auto host = hostPackage.child("Host");
host.remove_child("mInstalledPackages");
host.remove_child("mInstalledModules");
// copy in the /Mudlet/HostPackage
mudletPackage.append_copy(hostPackage);
return true;
}
// save profile using Qt's API's which handle non-ASCII characters in Windows paths fine
void dlgConnectionProfiles::saveProfileCopy(const QDir& newProfiledir, const pugi::xml_document& newProfileXml) const
{
Improve: save files in a more reliable manner (#6738) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Use [QSaveFile](https://doc.qt.io/qt-5/qsavefile.html) for all cases where Mudlet is writing to disk (profiles, maps, notes, ...). QSaveFile does a few things under the hood to ensure a file can be written safely, and gives a nice error if no. #### Motivation for adding to Mudlet I'm hoping this'll address some cases of folks' settings resetting or some other weird things happening - which happens once in a blue moon, but still does. Doing disk IO on scale is something that is eventually bound to run into issues, I had the same with the Svo system. Hopefully this'll cover things off. #### Other info (issues closed, discussion etc) Fix https://github.com/Mudlet/Mudlet/issues/1342 --------- Co-authored-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: SlySven <SlySven@users.noreply.github.com>
2023-04-25 19:28:34 +02:00
QSaveFile file(newProfiledir.absoluteFilePath(qsl("Copied profile (settings only).xml")));
Add 'Copy profile (settings only)' button (#2779) * Added button and got connection info copied * Add copy profile with settings only * Tweak UI style * Cleanup * Remove duplicates * Remove another debug cout * Fix names getting duplicated * Remove debug statement * Fix unnecessary return
2019-07-17 07:33:47 +02:00
if (!file.open(QFile::WriteOnly)) {
qDebug() << "dlgConnectionProfiles::copyProfileSettingsOnly ERROR - couldn't create new profile file:" << file.fileName() << "-" << file.errorString();
return;
}
std::stringstream saveStringStream(std::ios::out);
newProfileXml.save(saveStringStream);
std::string output(saveStringStream.str());
file.write(output.data());
Improve: save files in a more reliable manner (#6738) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Use [QSaveFile](https://doc.qt.io/qt-5/qsavefile.html) for all cases where Mudlet is writing to disk (profiles, maps, notes, ...). QSaveFile does a few things under the hood to ensure a file can be written safely, and gives a nice error if no. #### Motivation for adding to Mudlet I'm hoping this'll address some cases of folks' settings resetting or some other weird things happening - which happens once in a blue moon, but still does. Doing disk IO on scale is something that is eventually bound to run into issues, I had the same with the Svo system. Hopefully this'll cover things off. #### Other info (issues closed, discussion etc) Fix https://github.com/Mudlet/Mudlet/issues/1342 --------- Co-authored-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: SlySven <SlySven@users.noreply.github.com>
2023-04-25 19:28:34 +02:00
if (!file.commit()) {
qDebug() << "dlgConnectionProfiles::saveProfileCopy: error copying profile: " << file.errorString();
}
Make the copy button work
2009-01-30 01:25:11 -05:00
}
Add support for opening a profile offline (#2580) * Added Load button to profile selection dialog. * Changed name of load button to offline. * Added successful load message. * Cleaned up some tooltip messages. * Removed obsolete arg historyVersion.
2019-06-01 14:35:50 -06:00
void dlgConnectionProfiles::loadProfile(bool alsoConnect)
start
2009-01-24 02:50:22 +01:00
{
Infrastructure: mark read-only variables as const (#6843) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Mark read-only variables as const - that is, not intended to change after they've been declared #### Motivation for adding to Mudlet So we don't change them by accident later on, and also to clearly state intentions for the variables #### Other info (issues closed, discussion etc) This is also recommended by the [C++ Core Guidelines](https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#es25-declare-an-object-const-or-constexpr-unless-you-want-to-modify-its-value-later-on)
2023-05-14 15:06:15 +02:00
const QString profile_name = profile_name_entry->text().trimmed();
misc
2010-03-15 09:37:16 +01:00
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
if (profile_name.isEmpty()) {
LARGE: more profile loading work | debug console uses the new display driver | main window saves its size and position |some connection dialog
2009-01-30 00:58:44 +01:00
return;
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
}
misc
2010-03-15 09:37:16 +01:00
Fix: Prevent duplicate connection attempts after disconnect-reconnect sequence (#8038) #### Brief overview of PR changes/additions Fixes duplicate connection attempts that occurred when performing a Reconnect → Disconnect → Connect sequence. The issue caused duplicate DNS lookups and connection attempts, resulting in unnecessary network overhead and confusing connection logs. #### Motivation for adding to Mudlet Users experienced duplicate connection attempts after disconnecting and reconnecting to the same profile, which created: - Unnecessary network traffic from duplicate DNS lookups - Confusing duplicate connection messages in logs - Potential timing issues with connection establishment #### Other info (issues closed, discussion etc) **Root Cause:** Two separate code paths were both attempting to connect: 1. `mudlet::loadProfile()` called `connectIt()` for existing hosts 2. The reconnect path in `dlgConnectionProfiles::loadProfile()` called `reconnect()` **Solution:** Added logic to detect when `mudlet::loadProfile()` has already handled the connection for existing hosts and skip the duplicate reconnect call. **Files Modified:** - `src/dlgConnectionProfiles.cpp` - Added duplicate connection prevention logic - `src/mudlet.cpp` - Minor cleanup of related code --- **Before (Problem)** https://github.com/user-attachments/assets/1a71067f-f21d-4eaf-a6b3-728589f97bfa --- **After (Fixed)** https://github.com/user-attachments/assets/4b28a51d-7c24-4703-8aab-86ec6209c557
2025-08-18 09:31:03 -04:00
// Check if the host already exists before calling mudlet::loadProfile()
Host* pHostBeforeLoad = mudlet::self()->getHostManager().getHost(profile_name);
bool hostExistedBefore = (pHostBeforeLoad != nullptr);
Fix: restore ability to load older profile versions (#7559) #### Brief overview of PR changes/additions Ensures that the case where the profile to load is selected from the GUI dialogue passes the particular file that the user can select via that form is loaded rather than automatically loading the newest file that other uses of the profile loading code refactored by #7395 uses. #### Motivation for adding to Mudlet Fixes a bug introduced by the PR 7395. #### Other info (issues closed, discussion etc) This is obviously something that was not spotted when the original PR was "tested" - though to be honest it was something that the creator of that did seem to worry about: > Unifying the duped logic was a bit intimidating seeing as most of those lines haven't been touched in a decade or so, but I tried to keep actual changes in what is being executed minimal. Though I did find a few things that were being done in only one branch but not the other, which seemed to me like they should have really been in both, and them not being so was a bug. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2024-12-15 19:19:25 +00:00
Host* pHost = mudlet::self()->loadProfile(profile_name, alsoConnect, profile_history->currentData().toString());
misc
2010-03-15 09:37:16 +01:00
Feature: command line improved -> different autocompletion scheme | Feature: user toolbar graphics problems solved & 2 state buttons implemented | Feature: stop-all-triggers | Feature: script_editor: add new as sibling except if parent is a folder | Feature: MultiView button
2009-02-08 06:30:23 +01:00
// overwrite the generic profile with user supplied name, url and login information
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
if (pHost) {
Fix: Avoid corner cases by reconnecting if the same profile #7698 (#7778) #### Brief overview of PR changes/additions After a brief discussion on discord about the expected behavior when the same profile is chosen on opening the "Connect" menubar button being to simply reconnect the telnet session, I added logic to accomplish that to the dlgConnectionProfiles::loadProfile function. #### Motivation for adding to Mudlet This should avoid corner cases like lua events getting deregistered by doing as little as possible for existing profile connections. #### Other info (issues closed, discussion etc) Fixes #7698
2025-04-06 04:15:19 -04:00
Host* pActiveHost = mudlet::self()->getActiveHost();
Add a Mudlet Tutorial profile. (#8188) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Adds a Mudlet Tutorial profile which incorporates a basic GUI tutorial and mini-mud quest. GUI tutorial introduces the main window, command line, search bar, toolbar, map. Mini-quest attempts to act like a MUD. Teaches directional commands and some typical verbs (look, buy, give, get, open, close, quit) while the player wanders around trying to figure out the two 'quests' (buy the sheriff some lunch and find the librarian's lost ring). It is simplistic and more designed to show players how a mud 'feels and progresses' when playing rather than a full blown MUD school which most (all?) MUDs incorporate. #### Motivation for adding to Mudlet Help on-boarding new users. Destination 5.0. /claim #3072 helps #2823 #### Other info (issues closed, discussion etc) I purposefully left out triggers, scripting and all that stuff veteran players take for granted! This is supposed to be an on-boarding tutorial for NEW players, let's not overwhelm them. A link after successful completion of the game introduces the wiki Introduction page for more advanced topics. That said, any improvements or basic features you think are missing from either the GUI or Mud tutorials, let me know and I can add. https://github.com/user-attachments/assets/1d16db50-e24b-4e78-b6b0-66e0e98a0772
2025-09-13 14:17:13 +07:00
Fix: Avoid corner cases by reconnecting if the same profile #7698 (#7778) #### Brief overview of PR changes/additions After a brief discussion on discord about the expected behavior when the same profile is chosen on opening the "Connect" menubar button being to simply reconnect the telnet session, I added logic to accomplish that to the dlgConnectionProfiles::loadProfile function. #### Motivation for adding to Mudlet This should avoid corner cases like lua events getting deregistered by doing as little as possible for existing profile connections. #### Other info (issues closed, discussion etc) Fixes #7698
2025-04-06 04:15:19 -04:00
if (pActiveHost && pActiveHost->getName() == profile_name) {
Fix: Prevent duplicate connection attempts after disconnect-reconnect sequence (#8038) #### Brief overview of PR changes/additions Fixes duplicate connection attempts that occurred when performing a Reconnect → Disconnect → Connect sequence. The issue caused duplicate DNS lookups and connection attempts, resulting in unnecessary network overhead and confusing connection logs. #### Motivation for adding to Mudlet Users experienced duplicate connection attempts after disconnecting and reconnecting to the same profile, which created: - Unnecessary network traffic from duplicate DNS lookups - Confusing duplicate connection messages in logs - Potential timing issues with connection establishment #### Other info (issues closed, discussion etc) **Root Cause:** Two separate code paths were both attempting to connect: 1. `mudlet::loadProfile()` called `connectIt()` for existing hosts 2. The reconnect path in `dlgConnectionProfiles::loadProfile()` called `reconnect()` **Solution:** Added logic to detect when `mudlet::loadProfile()` has already handled the connection for existing hosts and skip the duplicate reconnect call. **Files Modified:** - `src/dlgConnectionProfiles.cpp` - Added duplicate connection prevention logic - `src/mudlet.cpp` - Minor cleanup of related code --- **Before (Problem)** https://github.com/user-attachments/assets/1a71067f-f21d-4eaf-a6b3-728589f97bfa --- **After (Fixed)** https://github.com/user-attachments/assets/4b28a51d-7c24-4703-8aab-86ec6209c557
2025-08-18 09:31:03 -04:00
// Skip reconnect if mudlet::loadProfile already connected for existing hosts
if (alsoConnect && hostExistedBefore) {
QDialog::accept();
return;
}
// Reconnect to the active profile
Fix: Avoid corner cases by reconnecting if the same profile #7698 (#7778) #### Brief overview of PR changes/additions After a brief discussion on discord about the expected behavior when the same profile is chosen on opening the "Connect" menubar button being to simply reconnect the telnet session, I added logic to accomplish that to the dlgConnectionProfiles::loadProfile function. #### Motivation for adding to Mudlet This should avoid corner cases like lua events getting deregistered by doing as little as possible for existing profile connections. #### Other info (issues closed, discussion etc) Fixes #7698
2025-04-06 04:15:19 -04:00
pActiveHost->mTelnet.reconnect();
QDialog::accept();
return;
}
Add a Mudlet Tutorial profile. (#8188) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Adds a Mudlet Tutorial profile which incorporates a basic GUI tutorial and mini-mud quest. GUI tutorial introduces the main window, command line, search bar, toolbar, map. Mini-quest attempts to act like a MUD. Teaches directional commands and some typical verbs (look, buy, give, get, open, close, quit) while the player wanders around trying to figure out the two 'quests' (buy the sheriff some lunch and find the librarian's lost ring). It is simplistic and more designed to show players how a mud 'feels and progresses' when playing rather than a full blown MUD school which most (all?) MUDs incorporate. #### Motivation for adding to Mudlet Help on-boarding new users. Destination 5.0. /claim #3072 helps #2823 #### Other info (issues closed, discussion etc) I purposefully left out triggers, scripting and all that stuff veteran players take for granted! This is supposed to be an on-boarding tutorial for NEW players, let's not overwhelm them. A link after successful completion of the game introduces the wiki Introduction page for more advanced topics. That said, any improvements or basic features you think are missing from either the GUI or Mud tutorials, let me know and I can add. https://github.com/user-attachments/assets/1d16db50-e24b-4e78-b6b0-66e0e98a0772
2025-09-13 14:17:13 +07:00
Fix: Prevent duplicate connection attempts after disconnect-reconnect sequence (#8038) #### Brief overview of PR changes/additions Fixes duplicate connection attempts that occurred when performing a Reconnect → Disconnect → Connect sequence. The issue caused duplicate DNS lookups and connection attempts, resulting in unnecessary network overhead and confusing connection logs. #### Motivation for adding to Mudlet Users experienced duplicate connection attempts after disconnecting and reconnecting to the same profile, which created: - Unnecessary network traffic from duplicate DNS lookups - Confusing duplicate connection messages in logs - Potential timing issues with connection establishment #### Other info (issues closed, discussion etc) **Root Cause:** Two separate code paths were both attempting to connect: 1. `mudlet::loadProfile()` called `connectIt()` for existing hosts 2. The reconnect path in `dlgConnectionProfiles::loadProfile()` called `reconnect()` **Solution:** Added logic to detect when `mudlet::loadProfile()` has already handled the connection for existing hosts and skip the duplicate reconnect call. **Files Modified:** - `src/dlgConnectionProfiles.cpp` - Added duplicate connection prevention logic - `src/mudlet.cpp` - Minor cleanup of related code --- **Before (Problem)** https://github.com/user-attachments/assets/1a71067f-f21d-4eaf-a6b3-728589f97bfa --- **After (Fixed)** https://github.com/user-attachments/assets/4b28a51d-7c24-4703-8aab-86ec6209c557
2025-08-18 09:31:03 -04:00
// Skip signal emission if mudlet::loadProfile already handled the connection
if (alsoConnect && hostExistedBefore) {
QDialog::accept();
return;
}
Infrastructure: purge trailing whitespace (#7949) #### Brief overview of PR changes/additions Use a ` +$` search-and-replace to remove trailing spaces in `.cpp` and `.h` source code files to remove unwanted trailing whitespace that has crept into a number of files. #### Motivation for adding to Mudlet To clean up files as `git` notices such white-space and objects in some circumstances - and such spaces are redundant in the source code. #### Other info (issues closed, discussion etc) Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2025-07-13 14:29:14 +01:00
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
pHost->setName(profile_name);
Enhance: add text transcoding (#969) * Enhance: add encoding/decoding to incoming and outgoing MUD data Found during testing on the Spanish Realms of Legends MUD that we did not support ISO-8859-1 (Latin-1) encoding but could if we made a small change to the way we process the incoming text bytes in the TBuffer::translateToPlainText(...) method. Instead of appending each byte as a char onto TBuffer::mMudline - which works for (7-bit) ASCII characters we can convert the upper 128 code characters to the "correct" QChars by going via a QChar::fromLatin1(...) intermediate step. It was then found possible to extend this process for other simple encoding tables by recording the differences between the ISO 8859-1 and various other encodings. Included in this commit is support for: * ISO 8859-1 * ISO 8859-2 * ISO 8859-3 * ISO 8859-4 * ISO 8859-10 * ISO 8859-15 * ISO 8859-16 * WINDOWS-1250 * WINDOWS-1251 * WINDOWS-1252 The above (and UTF-8) can be selected from the profile preferences and will be saved on a per profile basis once set and used when the profile is used again. UTF-8 is manually decoded by examining the first byte to determine how many more bytes are expected for it and then checking all of the indicated bytes for validity. Checks are included to guard against invalid code points (beyond U+10FFFF) and "overlong" sequences. During testing against some data from a real MUD it was found that the UTF-8 BOM sequence although not required or recommended for this encoding was being converted to no QChars at all, technically the position in a stream where it occurs could replace it with some form of joiner or it could actually be discarded however a script or trigger might be interested in it so the equivalent QChar is manually reinserted into the decoded stream - this is also useful as the code structure wants to insert a TChar instance into the corresponding data storage every time around the parsing loop for a single byte (for all but UTF-8) encoding or Utf-8 byte sequence for a codepoint (for UTF-8). NOTE THAT THE DECODER WILL HANDLE NON-BMP BYTE SEQUENCES AND DECODES THEM TO TWO QChars (a High surrogate followed by a Low one) AS QT DOES (It is based on QStrings that are Utf-16). To allow code that follows this stage to keep a one-to-one match between QChars in the text data and TChars that record the rendering aspects (colour, font styling) a duplicate TChar is added after the normal one for non-BMP codepoints. I feel this will help to port the existing code over to support such non-BMP codepoints...! Found missing braces was allowing some code to execute when the item it was trying to reference did not exist. Added getServerEncodingsList() which provides a list with the exact strings to use - and which allows us to revised them if necessary. Revise setServerEncoding() to not regard setting the same encoding that is already being used from being a run-time error - now it will just return the same true as if the setting had been made - but as no change is actually taking place, no message will appear on the main console. This message is now an "[ OK ] -" form one without an ending ellipses whereas it was an "[ ALERT ] -" with one. Whether a change does occur or not a text message is not provided, only on the run-time error case of specifying an incorrect encoding will a nil + error-message now be produced. Comment at start of TBuffer::translateToPlainText(...) redone. Renamed data input argument to above function to ensure that the local version which can be slightly longer if there are bytes "left-over" from the previous packet that have been prepended to it. Doing this allowed me to find and fix places where that was not being used. Revised the error handling for where the decoded UTF-8 data yields more than two QChars from when converted by a QString constructor - it should not happen but being paranoid is not unreasonable with initial coding attempts...! Also arranged that more error cases report the actual bytes that seemed to be in error. Revised: use hard coded tables for decoding MUD Server data Now using data recovered from Qt's own code repository, and adds additional encodings - which could be subsequently added/removed as we see fit. Code also restructured to work with a singleton(?) table of the above data, in the form of a QMap<QString, QVector<QChar>> where the QVector is the 128 Unicode code-point values for the characters in the range 128-255 for each of the Extended ASCII tables. This excludes ISO 8859-1 as that is implicitly the one-to-one mapping 128=128, 129=129,... 255=255 and obviously excludes ASCII which does not go that far and UTF-8 which is handled differently. It also allows a significant performance improvement as it eliminates a pair of switch() constructs and a call to a encoding specific method for each byte of data for the other encoding and replaces them with a single look-up in a single QVector; that being initialised at the start of processing the packet of data. I made an error in assessing what the bit pattern for the highest valid code-point value is for the bit pattern for the 4-bytes associated with it. It is also not acceptable to have UTF-16 Surrogates in a normal UTF-8 data- steam and best-practice is to reject them. Added a compilation conditional macro: "DEBUG_UTF8_PROCESSING" to hide possibly spammy qDebug() messages related to the decoding of incoming UTF-8 text. It IS defined after this commit. Fixed a coding bug that would lose 1 to 3 bytes of server data should a UTF-8 byte stream from the MUD server be fragmented between two incoming network data packets. It also adds a warning in the tool-tip of the encoding setting control to leave the encoding setting on the profile preferences to be ASCII or ISO 8859-1 as others will not yet work with the remainder of the application's code base. Some phrasing in the somewhat lengthy text of that tool-tip (suggestions are being considered as to "precis"ing it to a smaller version!) have also been made. The name of the setting has also been change from "Text encoding" to "Server Data Encoding" to (I feel) better indicate it's purpose. The tables containing the encoding of Extended ASCII character codes to the representation as Unicode code-points for "other" codecs that ISO-8859-1 are laid out carefully so that individual entries can be identified as best they can. However the current (any?) clang-format configuration will destroy the layout so I had deliberately marked them as not be touched by that tool. Changed to use a C++11 ranged "for" instead of Qt macro "foreach" in TBuffer constructor. Changed format of run-time error for an invalid "encoding" string supplied to to the Lua setServerEncoding("encoding") function. Reordered encodings list so that UTF-8 follows immediately after ASCII rather than being on the end of the list. Run-time error string on supplying a bad encoding to setServerEncoding(...) is now: "Encoding \"XXXX\" does not exist; use one of the following: \"ASCII\", <list of other encodings (with UTF-8 at the top)>." Profile Preferences title for encoding is now "Server data encoding" - it has lost the extra capitalisation I originally used. 8-| If the last bytes of a packet are multi-byte UTF-8 sequence it is necessary to store them if there is not enough bytes in the packet to complete the processing of them in TBuffer::translateToPlainText(...). Added a couple of QDebug()s - conditional on DEBUG_UTF8_PROCESSING that: report that an incomplete sequence has been detected and how many bytes are being stored; and report when they are being prepended onto the data in the next call to the method concerned. Whilst using Mudlet replays to debug this issue I noticed that the replay starting and ending messages did not have the classification tag of the form "[ XXXX ] -" so did not display in any special way, I revised them to become an "[ INFO ]" message for replay starting and "[ OK ]" at the end...! Found a local automatic variable "msPos" in TBuffer::trasnlateToPlainText(...) was shadowing an unnecessary TBuffer class member so renamed/retyped the local to be more appropriate, also found that a second class member was not needed outside the method so added a local automatic to do the same job: * (int) msPos ==> (size_t) localBufferPosition * msLength ==> (size_t) localBufferLength Also remove now unused and/or shadowed: * (int) TBuffer::lookupColor(const QString&, int) * (int) TBuffer::msLength * (int) TBuffer::msPos * (QString) TBuffer::mFormatSequenceRest I found that there was some MXP related code that was still working on the incoming string data rather than the possibly pre-pended local copy which would cause (further) problems in the future for non-ASCII that use MXP! I changed those to also work on the local version. Within TBuffer::translateToPlainText(...) I also spotting some single line if(...) {...} else {...} which I braced as appropriate, a couple of places where different spacing helps to line up related code and some other redundant code fragments which I removed. This comment was edited from the totality of all the commits that were squashed together to make a single commit. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2017-05-22 16:31:25 +01:00
Infrastructure: use isEmpty() instead of size() or count() being zero (#6333) This better reflects the intention of such checks. A couple of the changes originated in #6330 but they were not germane to the issue being addressed there, so factored out to a separate PR which I extended to cover all (a lot more) cases . Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-10-02 09:43:20 +01:00
if (!host_name_entry->text().trimmed().isEmpty()) {
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
pHost->setUrl(host_name_entry->text().trimmed());
} else {
Infrastructure: tidy up naming of SLOT methods and their usage - Part 2 (#6255) When Qt's slot/signal system is used to invoke a method there is some overhead - so it makes sense to ensure developers can spot all such methods (functions). We have tried to do this with a `slot_` prefix to the methods we create but it has not been applied uniformly. This PR (and one or more to follow) is intended to help with this by more rigorously doing so - the names changed herein should all follow a `slot_`*camelCaseMethodName* style. In addition some methods were detected that are not currently used or which are not actually used via the signal/slot system, these have been commented out or have had the prefix removed and the declaration in the relevant header file moved as appropriate. For reference the changes made are: * `TLuaInterpreter::slotDeleteSender(...)` ==> `TLuaInterpreter::slot_deleteSender(...)` * `TLuaInterpreter::slotPurge()` ==> `TLuaInterpreter::slot_purge()` * `cTelnet::handle_socket_signal_connected()` ==> `cTelnet::slot_socketConnected()` * `cTelnet::handle_socket_signal_disconnected()` ==> `cTelnet::slot_socketDisconnected()` * `cTelnet::handle_socket_signal_hostFound(...)` ==> `cTelnet::slot_socketHostFound(...)` * `cTelnet::handle_socket_signal_readyRead()` ==> `cTelnet::slot_socketReadyToBeRead()` * `cTelnet::handle_socket_signal_sslError(...)` ==> `cTelnet::slot_socketSslError(...)` * `cTelnet::setDownloadProgress(...)` ==> `cTelnet::slot_setDownloadProgress(...)` * `dlgComposer::cancel()` ==> `dlgComposer::slot_cancel()` * `dlgComposer::save()` ==> `dlgComposer::slot_save()` * `dlgConnectionProfiles::slot_item_clicked(...)` ==> `dlgConnectionProfiles::slot_itemClicked(...)` * `dlgConnectionProfiles::slot_save_name()` ==> `dlgConnectionProfiles::slot_saveName()` * `dlgConnectionProfiles::slot_update_login(...)` ==> `dlgConnectionProfiles::slot_updateLogin(...)` * `dlgConnectionProfiles::slot_update_name(...)` ==> `dlgConnectionProfiles::slot_updateName(...)` * `dlgConnectionProfiles::slot_update_pass(...)` ==> `dlgConnectionProfiles::slot_updatePassword(...)` * `dlgConnectionProfiles::slot_update_port(...)` ==> `dlgConnectionProfiles::slot_updatePort(...)` * `dlgConnectionProfiles::slot_update_SSL_TSL_port(...)` ==> `dlgConnectionProfiles::slot_updateSslTslPort(...)` * `dlgConnectionProfiles::slot_update_url(...)` ==> `dlgConnectionProfiles::slot_updateUrl(...)` * `dlgMapLabel::pickBgColor()` ==> `dlgMapLabel::slot_pickBgColor()` * `dlgMapLabel::pickFgColor()` ==> `dlgMapLabel::slot_pickFgColor()` * `dlgMapLabel::pickFile()` ==> `dlgMapLabel::slot_pickFile()` * `dlgMapLabel::pickFont()` ==> `dlgMapLabel::slot_pickFont()` * `dlgMapLabel::save()` ==> `dlgMapLabel::slot_save()` * `dlgMapLabel::updateControls()` ==> `dlgMapLabel::slot_updateControls()` * `dlgMapLabel::updateControlsVisibility()` ==> `dlgMapLabel::slot_updateControlsVisibility()` Commented out as not being used: * `cTelnet::handle_socket_signal_error()` ==> `cTelnet::slot_socketError()` * `dlgConnectionProfiles::slot_update_website(...) ==> `dlgConnectionProfiles::slot_updateWebsite(const QString& url)` I have my doubts about whether the `dlgMapLabel::save()`/`dlgMapLabel::slot_save()` method is needed at all, as it might be that the `QDialog::accept()` slot could have been inserted into the `QObject::connect(...)` call directly instead...? Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-08-27 10:47:01 +02:00
slot_updateUrl(pHost->getUrl());
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
}
misc
2010-03-15 09:37:16 +01:00
Infrastructure: use isEmpty() instead of size() or count() being zero (#6333) This better reflects the intention of such checks. A couple of the changes originated in #6330 but they were not germane to the issue being addressed there, so factored out to a separate PR which I extended to cover all (a lot more) cases . Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-10-02 09:43:20 +01:00
if (!port_entry->text().trimmed().isEmpty()) {
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
pHost->setPort(port_entry->text().trimmed().toInt());
} else {
Infrastructure: tidy up naming of SLOT methods and their usage - Part 2 (#6255) When Qt's slot/signal system is used to invoke a method there is some overhead - so it makes sense to ensure developers can spot all such methods (functions). We have tried to do this with a `slot_` prefix to the methods we create but it has not been applied uniformly. This PR (and one or more to follow) is intended to help with this by more rigorously doing so - the names changed herein should all follow a `slot_`*camelCaseMethodName* style. In addition some methods were detected that are not currently used or which are not actually used via the signal/slot system, these have been commented out or have had the prefix removed and the declaration in the relevant header file moved as appropriate. For reference the changes made are: * `TLuaInterpreter::slotDeleteSender(...)` ==> `TLuaInterpreter::slot_deleteSender(...)` * `TLuaInterpreter::slotPurge()` ==> `TLuaInterpreter::slot_purge()` * `cTelnet::handle_socket_signal_connected()` ==> `cTelnet::slot_socketConnected()` * `cTelnet::handle_socket_signal_disconnected()` ==> `cTelnet::slot_socketDisconnected()` * `cTelnet::handle_socket_signal_hostFound(...)` ==> `cTelnet::slot_socketHostFound(...)` * `cTelnet::handle_socket_signal_readyRead()` ==> `cTelnet::slot_socketReadyToBeRead()` * `cTelnet::handle_socket_signal_sslError(...)` ==> `cTelnet::slot_socketSslError(...)` * `cTelnet::setDownloadProgress(...)` ==> `cTelnet::slot_setDownloadProgress(...)` * `dlgComposer::cancel()` ==> `dlgComposer::slot_cancel()` * `dlgComposer::save()` ==> `dlgComposer::slot_save()` * `dlgConnectionProfiles::slot_item_clicked(...)` ==> `dlgConnectionProfiles::slot_itemClicked(...)` * `dlgConnectionProfiles::slot_save_name()` ==> `dlgConnectionProfiles::slot_saveName()` * `dlgConnectionProfiles::slot_update_login(...)` ==> `dlgConnectionProfiles::slot_updateLogin(...)` * `dlgConnectionProfiles::slot_update_name(...)` ==> `dlgConnectionProfiles::slot_updateName(...)` * `dlgConnectionProfiles::slot_update_pass(...)` ==> `dlgConnectionProfiles::slot_updatePassword(...)` * `dlgConnectionProfiles::slot_update_port(...)` ==> `dlgConnectionProfiles::slot_updatePort(...)` * `dlgConnectionProfiles::slot_update_SSL_TSL_port(...)` ==> `dlgConnectionProfiles::slot_updateSslTslPort(...)` * `dlgConnectionProfiles::slot_update_url(...)` ==> `dlgConnectionProfiles::slot_updateUrl(...)` * `dlgMapLabel::pickBgColor()` ==> `dlgMapLabel::slot_pickBgColor()` * `dlgMapLabel::pickFgColor()` ==> `dlgMapLabel::slot_pickFgColor()` * `dlgMapLabel::pickFile()` ==> `dlgMapLabel::slot_pickFile()` * `dlgMapLabel::pickFont()` ==> `dlgMapLabel::slot_pickFont()` * `dlgMapLabel::save()` ==> `dlgMapLabel::slot_save()` * `dlgMapLabel::updateControls()` ==> `dlgMapLabel::slot_updateControls()` * `dlgMapLabel::updateControlsVisibility()` ==> `dlgMapLabel::slot_updateControlsVisibility()` Commented out as not being used: * `cTelnet::handle_socket_signal_error()` ==> `cTelnet::slot_socketError()` * `dlgConnectionProfiles::slot_update_website(...) ==> `dlgConnectionProfiles::slot_updateWebsite(const QString& url)` I have my doubts about whether the `dlgMapLabel::save()`/`dlgMapLabel::slot_save()` method is needed at all, as it might be that the `QDialog::accept()` slot could have been inserted into the `QObject::connect(...)` call directly instead...? Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-08-27 10:47:01 +02:00
slot_updatePort(QString::number(pHost->getPort()));
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
}
Update: remove Midkemia (and add WoTMUD) to list of predefined MUDs (#321) * Update: remove Midkemia (and add WoTMUD) to list of predefined MUDs The I.R.E. MUD Midkemia-online was shutdown on 2016/09/07 and it is not helpful to continue to offer it as a predefined MUD in the connection dialog. This commit removes it from that list and adds a favourite of mine "WoTMUD" to replace it. The logo is a temporary one that I will replace with a similar one that I need to get clearance to use (and release with a GPL2.1+ licence) from the Wheel of Time MUD sysop with whom I am in contact {Vivienne needs to get approval from the creator Flash who is away for a few days...!} The dlgConnectionProfiles.cpp file has quite a few ASCII strings, as appropriate for a file that will in the future be subject to I18n work I took the opportunity to put QStringLiteral(...) wrappers around the QStrings that are used for non-GUI tasks and tr(...) ones that are. I expect it isn't complete but it goes someway towards dealing with THIS particular file - and it should improve very slightly the generation of QStrings that need to be constructed because it means as much of possible of them is done at compile rather than run-time...! In relation to the above there are points in the code where QStrings are compared to "" to see if they do not have any contents - the isEmpty() method is a better way to do the same (it does not involve a string expression) In (void)dlgConnectionProfiles::slot_update_name( const QString ) there are a couple of variables that use a double underscore prefix - that is NOT A Good Idea: such a prefix is RESERVED in both C and C++. For example see: [what-are-the-rules-about-using-an-underscore-in-a-c-identifier](http://stackoverflow.com/questions/228783/what-are-the-rules-about-using-an-underscore-in-a-c-identifier) also a single prefix might be a bit of a problem with libraries... I have renames the offending things there - but I may have used the single underscore prefix myself in the past. *blush* There are some help messages in this class that use an apostrophe in a word contraction - as a matter of readability this is not considered best practice IMHO so I have converted them to the full words. Following experiences in my previous Pull Request I also took a look at the initialisation and use of some member variables; it became clear that: * (QString) dlgConnectionProfiles::mOrigin * (bool) dlgConnectionProfiles::mEditOK were not used and could be simply deleted and that: * (QString) dlgConnectionProfiles::mUnsavedProfileName * (QString) dlgConnectionProfiles::mCurrentProfileEditName did not need to be member variables and could be local to the method that used them, so in (void)dlgConnectionProfiles::slot_save_name(): * (QString) dlgConnectionProfiles::mCurrentProfileEditName becomes local: (QString) currentProfileEditName and in (void) dlgConnectionProfiles::slot_addProfile(): * (QString) dlgConnectionProfiles::mUnsavedProfileName becomes local: (QString) newName also added initialisers for: * (QStringList) dlgConnectionProfiles::mProfileList * (QPushButton *) dlgConnectionProfiles::connect_button * (QLineEditQPushButton *) dlgConnectionProfiles::delete_profile_lineedit * (QPushButton *) dlgConnectionProfiles::delete_button Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * More: two items missed from prior commit In the previous commit I forgot to take out: * a check for Midkemia in the dlgProfilePreferences class constructor that enabled the download map options; * a similar check in (bool)TMap::restore(QString) that asked if the user wanted to download a map if there was not one found. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * Tweak: Insert MUD supplied Logo/Icon Received an icon as a .jpg that the MUD operators can allow us to licence as GPL2.1+ which I have converted to a .png file. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2016-10-15 09:57:17 +01:00
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
pHost->mSslTsl = port_ssl_tsl->isChecked();
Infrastructure: use isEmpty() instead of size() or count() being zero (#6333) This better reflects the intention of such checks. A couple of the changes originated in #6330 but they were not germane to the issue being addressed there, so factored out to a separate PR which I extended to cover all (a lot more) cases . Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-10-02 09:43:20 +01:00
if (!character_password_entry->text().trimmed().isEmpty()) {
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
pHost->setPass(character_password_entry->text().trimmed());
misc
2011-07-05 00:07:41 +02:00
}
Fix: Restore password loading from portable file in connection dialog (#8993) #### Brief overview of PR changes/additions Restores the ability for the connection dialog to load saved passwords from the portable password file on disk, which stopped working after PR #7956 introduced secure credential management. #### Motivation for adding to Mudlet After #7956, users who had passwords saved in the old portable file format (`~/.config/mudlet/profiles/<name>/password`) could no longer see their passwords pre-filled when selecting a profile in the connection dialog. This affected users who had not yet migrated to the system keychain. The fix ensures all three password sources are checked in order: system keychain, QSettings, and finally the portable file on disk. It also moves the password migration step to run before the connection dialog opens, so passwords are migrated in time to be found. Includes the profile password collision fix from #8948 and adds new unit tests for the password migration and fallback paths. #### Other info (issues closed, discussion etc) Reported by @SlySven — PR #7956 (commit 79ab7be4) broke password loading for profiles that only had passwords in the portable file. --------- Co-authored-by: Stephen Lyons <slysven@virginmedia.com>
2026-03-08 09:38:15 -04:00
// Note: If password field is empty, we don't call slot_updatePassword() because:
// 1. The host's password was already loaded via Host::loadSecuredPassword()
// 2. Calling slot_updatePassword with empty password would delete the stored password
// 3. slot_updatePassword reads profile from list widget which could mismatch
Update: remove Midkemia (and add WoTMUD) to list of predefined MUDs (#321) * Update: remove Midkemia (and add WoTMUD) to list of predefined MUDs The I.R.E. MUD Midkemia-online was shutdown on 2016/09/07 and it is not helpful to continue to offer it as a predefined MUD in the connection dialog. This commit removes it from that list and adds a favourite of mine "WoTMUD" to replace it. The logo is a temporary one that I will replace with a similar one that I need to get clearance to use (and release with a GPL2.1+ licence) from the Wheel of Time MUD sysop with whom I am in contact {Vivienne needs to get approval from the creator Flash who is away for a few days...!} The dlgConnectionProfiles.cpp file has quite a few ASCII strings, as appropriate for a file that will in the future be subject to I18n work I took the opportunity to put QStringLiteral(...) wrappers around the QStrings that are used for non-GUI tasks and tr(...) ones that are. I expect it isn't complete but it goes someway towards dealing with THIS particular file - and it should improve very slightly the generation of QStrings that need to be constructed because it means as much of possible of them is done at compile rather than run-time...! In relation to the above there are points in the code where QStrings are compared to "" to see if they do not have any contents - the isEmpty() method is a better way to do the same (it does not involve a string expression) In (void)dlgConnectionProfiles::slot_update_name( const QString ) there are a couple of variables that use a double underscore prefix - that is NOT A Good Idea: such a prefix is RESERVED in both C and C++. For example see: [what-are-the-rules-about-using-an-underscore-in-a-c-identifier](http://stackoverflow.com/questions/228783/what-are-the-rules-about-using-an-underscore-in-a-c-identifier) also a single prefix might be a bit of a problem with libraries... I have renames the offending things there - but I may have used the single underscore prefix myself in the past. *blush* There are some help messages in this class that use an apostrophe in a word contraction - as a matter of readability this is not considered best practice IMHO so I have converted them to the full words. Following experiences in my previous Pull Request I also took a look at the initialisation and use of some member variables; it became clear that: * (QString) dlgConnectionProfiles::mOrigin * (bool) dlgConnectionProfiles::mEditOK were not used and could be simply deleted and that: * (QString) dlgConnectionProfiles::mUnsavedProfileName * (QString) dlgConnectionProfiles::mCurrentProfileEditName did not need to be member variables and could be local to the method that used them, so in (void)dlgConnectionProfiles::slot_save_name(): * (QString) dlgConnectionProfiles::mCurrentProfileEditName becomes local: (QString) currentProfileEditName and in (void) dlgConnectionProfiles::slot_addProfile(): * (QString) dlgConnectionProfiles::mUnsavedProfileName becomes local: (QString) newName also added initialisers for: * (QStringList) dlgConnectionProfiles::mProfileList * (QPushButton *) dlgConnectionProfiles::connect_button * (QLineEditQPushButton *) dlgConnectionProfiles::delete_profile_lineedit * (QPushButton *) dlgConnectionProfiles::delete_button Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * More: two items missed from prior commit In the previous commit I forgot to take out: * a check for Midkemia in the dlgProfilePreferences class constructor that enabled the download map options; * a similar check in (bool)TMap::restore(QString) that asked if the user wanted to download a map if there was not one found. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * Tweak: Insert MUD supplied Logo/Icon Received an icon as a .jpg that the MUD operators can allow us to licence as GPL2.1+ which I have converted to a .png file. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2016-10-15 09:57:17 +01:00
Infrastructure: use isEmpty() instead of size() or count() being zero (#6333) This better reflects the intention of such checks. A couple of the changes originated in #6330 but they were not germane to the issue being addressed there, so factored out to a separate PR which I extended to cover all (a lot more) cases . Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-10-02 09:43:20 +01:00
if (!login_entry->text().trimmed().isEmpty()) {
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
pHost->setLogin(login_entry->text().trimmed());
} else {
Infrastructure: tidy up naming of SLOT methods and their usage - Part 2 (#6255) When Qt's slot/signal system is used to invoke a method there is some overhead - so it makes sense to ensure developers can spot all such methods (functions). We have tried to do this with a `slot_` prefix to the methods we create but it has not been applied uniformly. This PR (and one or more to follow) is intended to help with this by more rigorously doing so - the names changed herein should all follow a `slot_`*camelCaseMethodName* style. In addition some methods were detected that are not currently used or which are not actually used via the signal/slot system, these have been commented out or have had the prefix removed and the declaration in the relevant header file moved as appropriate. For reference the changes made are: * `TLuaInterpreter::slotDeleteSender(...)` ==> `TLuaInterpreter::slot_deleteSender(...)` * `TLuaInterpreter::slotPurge()` ==> `TLuaInterpreter::slot_purge()` * `cTelnet::handle_socket_signal_connected()` ==> `cTelnet::slot_socketConnected()` * `cTelnet::handle_socket_signal_disconnected()` ==> `cTelnet::slot_socketDisconnected()` * `cTelnet::handle_socket_signal_hostFound(...)` ==> `cTelnet::slot_socketHostFound(...)` * `cTelnet::handle_socket_signal_readyRead()` ==> `cTelnet::slot_socketReadyToBeRead()` * `cTelnet::handle_socket_signal_sslError(...)` ==> `cTelnet::slot_socketSslError(...)` * `cTelnet::setDownloadProgress(...)` ==> `cTelnet::slot_setDownloadProgress(...)` * `dlgComposer::cancel()` ==> `dlgComposer::slot_cancel()` * `dlgComposer::save()` ==> `dlgComposer::slot_save()` * `dlgConnectionProfiles::slot_item_clicked(...)` ==> `dlgConnectionProfiles::slot_itemClicked(...)` * `dlgConnectionProfiles::slot_save_name()` ==> `dlgConnectionProfiles::slot_saveName()` * `dlgConnectionProfiles::slot_update_login(...)` ==> `dlgConnectionProfiles::slot_updateLogin(...)` * `dlgConnectionProfiles::slot_update_name(...)` ==> `dlgConnectionProfiles::slot_updateName(...)` * `dlgConnectionProfiles::slot_update_pass(...)` ==> `dlgConnectionProfiles::slot_updatePassword(...)` * `dlgConnectionProfiles::slot_update_port(...)` ==> `dlgConnectionProfiles::slot_updatePort(...)` * `dlgConnectionProfiles::slot_update_SSL_TSL_port(...)` ==> `dlgConnectionProfiles::slot_updateSslTslPort(...)` * `dlgConnectionProfiles::slot_update_url(...)` ==> `dlgConnectionProfiles::slot_updateUrl(...)` * `dlgMapLabel::pickBgColor()` ==> `dlgMapLabel::slot_pickBgColor()` * `dlgMapLabel::pickFgColor()` ==> `dlgMapLabel::slot_pickFgColor()` * `dlgMapLabel::pickFile()` ==> `dlgMapLabel::slot_pickFile()` * `dlgMapLabel::pickFont()` ==> `dlgMapLabel::slot_pickFont()` * `dlgMapLabel::save()` ==> `dlgMapLabel::slot_save()` * `dlgMapLabel::updateControls()` ==> `dlgMapLabel::slot_updateControls()` * `dlgMapLabel::updateControlsVisibility()` ==> `dlgMapLabel::slot_updateControlsVisibility()` Commented out as not being used: * `cTelnet::handle_socket_signal_error()` ==> `cTelnet::slot_socketError()` * `dlgConnectionProfiles::slot_update_website(...) ==> `dlgConnectionProfiles::slot_updateWebsite(const QString& url)` I have my doubts about whether the `dlgMapLabel::save()`/`dlgMapLabel::slot_save()` method is needed at all, as it might be that the `QDialog::accept()` slot could have been inserted into the `QObject::connect(...)` call directly instead...? Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2022-08-27 10:47:01 +02:00
slot_updateLogin(pHost->getLogin());
NEW Chris Mitchell: mapper open event & support for new games 3Kingdom and 3Scapes with mapper script
2012-12-31 00:19:22 +01:00
}
install a few default packages in new profiles
2012-12-31 04:32:46 +01:00
BugFix: set Server Encoding correctly on auto-loading profiles This closes #1861 by ensuring that a setting that must be stored in the profile home directory rather than in the save file is read when auto-loading a profile as well as when it is loaded manually. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2018-07-30 15:19:04 +01:00
// This settings also need to be configured, note that the only time not to
Fix: default new profiles to UTF-8 encoding instead of ASCII (#8759) #### Brief overview of PR changes/additions New profiles now correctly default to UTF-8 encoding instead of ASCII. #### Motivation for adding to Mudlet New profiles were unintentionally defaulting to ASCII because empty profile data was treated as "ASCII" rather than "not yet set". #### Other info (issues closed, discussion etc) **Test case:** 1. Create a new profile 2. Go to Settings → General → Game protocols 3. Encoding should show UTF-8, not ASCII
2026-01-07 18:45:19 +01:00
// save the setting is on profile loading. Only override the default UTF-8
// encoding if a saved encoding exists:
const QByteArray savedEncoding = readProfileData(profile_name, qsl("encoding")).toUtf8();
if (!savedEncoding.isEmpty()) {
pHost->mTelnet.setEncoding(savedEncoding, false);
}
Fix: Revert "Improve: remove ambiguous width East Asian option (#8020)" (#8057) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions This reverts commit 53bcb3112bef7b3b54d5dd3a6d7d7a7f25f0c561, as it was breaking profile XML loading. #### Motivation for adding to Mudlet Fix `development` to load profiles. #### Other info (issues closed, discussion etc) We should have automated tests about this! Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-08-18 15:30:37 +02:00
// Needed to ensure setting is correct on start-up:
pHost->setWideAmbiguousEAsianGlyphs(pHost->getWideAmbiguousEAsianGlyphsControlState());
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
pHost->setAutoReconnect(auto_reconnect->isChecked());
Add Discord support (#1716)
2018-10-05 06:25:57 +02:00
// This also writes the value out to the profile's base directory:
mudlet::self()->mDiscord.setApplicationID(pHost, mDiscordApplicationId);
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
}
Fix broken Connect after offline mode introduction. (#2596)
2019-06-02 09:40:50 -06:00
emit signal_load_profile(profile_name, alsoConnect);
improve: Consolidate profile loading logic (#7395) /claim #7334 /claim #7357 #### Brief overview of PR changes/additions - Consolidates profile loading logic for both GUI dialogue loads and CLI loads in one function - fixes bugs caused by predefined games not loading settings correctly in certain cases #### Motivation for adding to Mudlet Gets rid of errors about an empty URLs/ports and possibly unwanted SSL connections. #### Other info (issues closed, discussion etc) I decided to go with the approach of unconditionally loading settings for predefined games from `TGameDetails` because this would fix all existing cases of "broken" profiles, as opposed to the approach I suggested earlier, which would only have prevented further broken profiles being created. Unifying the duped logic was a bit intimidating seeing as most of those lines haven't been touched in a decade or so, but I tried to keep actual changes in what is being executed minimal. Though I did find a few things that were being done in only one branch but not the other, which seemed to me like they should have really been in both, and them not being so was a bug. I'm actually not 100% sure if this solves #7357 (I can't reproduce it; config dumps from someone who can would be great), but logically this change _should_ fix any issues with loading settings for default games.
2024-08-22 12:03:38 +00:00
QDialog::accept();
start
2009-01-24 02:50:22 +01:00
}
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
bool dlgConnectionProfiles::validateProfile()
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
{
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
bool valid = true;
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
Improve: don't freeze Mudlet when copying large profile (#5056)
2022-04-18 20:37:10 +02:00
// don't validate url duplication during copy, as information will already exist when we try to set it
if (mCopyingProfile) {
return true;
}
Fix: newly created profiles will remember their connection info (#5245)
2021-06-22 19:22:08 +02:00
validName = true, validPort = true, validUrl = true;
Enhance: remove minuscule text from under profile icons (#4712) This finally enables us to do away with the text under the profile icons as it replicates the normal `QListWidget` behaviour to move the selection to each item which begins with the first letter of the key pressed. This also makes the non-matching profiles get disabled which I think makes the action more obvious... Revised to include a timeout on concatenating keypresses: This is to provide the same functionality that the QListWidget does for keypresses, if the keys are typed fast enough they are concatenated to form the text to search for. However if the user types slower than this then the individual keys are only considered on their own. This reflects what both Vadim and I experienced - in that he was typing fast enough to spell out a particular profile but I wasn't and so the profile that I was having selected was changing on each keypress. The time between keypresses allowed so that they can be concatenated I have set to be 1 second. This is significantly slower that the Qt code but it is long enough to permit the temporary disablement of non-matching profiles to be a useful visual feedback - and besides, it makes it easier to specify one of a number of profiles with a common initial text - the longer the timeout the more keys the user can string together! Add `std::chrono` so we can give a time delay as `1s` instead of `1000` mS. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2021-02-03 19:59:35 +00:00
clearNotificationArea();
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
QListWidgetItem* pItem = listWidget_profiles->currentItem();
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
if (pItem) {
QString name = profile_name_entry->text().trimmed();
fix: profiles with parentheses in their name can be opened again (#9610) #### Brief overview of PR changes/additions - Parentheses are now allowed in profile names, matching the "name (2)" folders file managers create when copying - Selecting a profile folder made outside Mudlet no longer silently mangles its name and renames the folder on disk - Adds ProfileNameValidationTest for the name validation rules and ProfileFolderNameTest, which drives the real connection dialog against externally-created folders (fails without the fix) #### Motivation for adding to Mudlet Merely selecting a profile folder like "test (2)" mangled its name to "test 2" and silently renamed the folder on disk, and the reporter could not launch the profile at all. #### Other info (issues closed, discussion etc) Assisted-by: Claude:claude-fable-5 Assisted-by: Claude:claude-opus-5 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org> **Test case:** Copy a profile folder to "test (2)" while Mudlet is closed, reopen - the profile keeps its name, Connect/Offline are enabled, and it opens. #### Demo https://github.com/user-attachments/assets/25b1bb4c-eaa7-4079-8b8e-a12de3ebb215
2026-08-04 16:09:42 +02:00
// Only check the characters of a new or edited name: a profile folder
// already on disk may have been created outside of Mudlet (e.g. by a
// file manager copying a folder) with characters we would not permit
// for a new name - such a profile must still be loadable. Comparing
// against the trimmed item name covers folders with leading/trailing
// whitespace too, as the entered name always arrives trimmed. Names
// the rest of Mudlet cannot work with get no exemption: renaming them
// is worse for the user than a profile whose password never saves.
fix: a profile named "." or ".." deletes every profile when removed (#9722) #### Brief overview of PR changes/additions - Validation: a typed profile name must be a folder of its own - rejects a lone `.` and anything containing `..`. Folders already on disk stay exempt - Containment: `reallyDeleteProfile()` refuses any path that is not a direct child of `profiles/`, and now checks `removeRecursively()` instead of failing mute - Confirmation: the "nothing to delete" shortcut no longer fires when a map, stored password or dictionary is present #### Motivation for adding to Mudlet A profile named `.` or `..` turned **Remove** into a wipe: `.` resolves to `profiles/`, `..` to the whole `~/.config/mudlet`. The name was accepted with no error, and the confirmation was skipped because a fresh profile looks empty - two clicks deep on the first screen every user sees. #### Other info (issues closed, discussion etc) Pre-existing, not a 5.0 regression - shipped 4.22.0 behaves identically. Dots have been allowed deliberately since 2011 (`ee1fd051c`), and `Achaea 2.0` keeps working. **Test case:** name a new profile `.` and press Remove - previously every profile was deleted with no prompt, now the name is refused. New `ProfileDeletionSafetyTest` drives the real dialog against a temporary config dir, plus `profileFolderPath`/`profileNameUsableAsIs` rows in `ProfileNameValidationTest`. 81/81 ctest pass. Assisted-by: Claude:claude-opus-5
2026-08-08 08:30:14 +02:00
// "." and ".." name something that exists without being a profile, so
// the exemption needs a folder that is genuinely the profile's own.
fix: profiles with parentheses in their name can be opened again (#9610) #### Brief overview of PR changes/additions - Parentheses are now allowed in profile names, matching the "name (2)" folders file managers create when copying - Selecting a profile folder made outside Mudlet no longer silently mangles its name and renames the folder on disk - Adds ProfileNameValidationTest for the name validation rules and ProfileFolderNameTest, which drives the real connection dialog against externally-created folders (fails without the fix) #### Motivation for adding to Mudlet Merely selecting a profile folder like "test (2)" mangled its name to "test 2" and silently renamed the folder on disk, and the reporter could not launch the profile at all. #### Other info (issues closed, discussion etc) Assisted-by: Claude:claude-fable-5 Assisted-by: Claude:claude-opus-5 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org> **Test case:** Copy a profile folder to "test (2)" while Mudlet is closed, reopen - the profile keeps its name, Connect/Offline are enabled, and it opens. #### Demo https://github.com/user-attachments/assets/25b1bb4c-eaa7-4079-8b8e-a12de3ebb215
2026-08-04 16:09:42 +02:00
const QString selectedName = pItem->data(csmNameRole).toString();
fix: a profile named "." or ".." deletes every profile when removed (#9722) #### Brief overview of PR changes/additions - Validation: a typed profile name must be a folder of its own - rejects a lone `.` and anything containing `..`. Folders already on disk stay exempt - Containment: `reallyDeleteProfile()` refuses any path that is not a direct child of `profiles/`, and now checks `removeRecursively()` instead of failing mute - Confirmation: the "nothing to delete" shortcut no longer fires when a map, stored password or dictionary is present #### Motivation for adding to Mudlet A profile named `.` or `..` turned **Remove** into a wipe: `.` resolves to `profiles/`, `..` to the whole `~/.config/mudlet`. The name was accepted with no error, and the confirmation was skipped because a fresh profile looks empty - two clicks deep on the first screen every user sees. #### Other info (issues closed, discussion etc) Pre-existing, not a 5.0 regression - shipped 4.22.0 behaves identically. Dots have been allowed deliberately since 2011 (`ee1fd051c`), and `Achaea 2.0` keeps working. **Test case:** name a new profile `.` and press Remove - previously every profile was deleted with no prompt, now the name is refused. New `ProfileDeletionSafetyTest` drives the real dialog against a temporary config dir, plus `profileFolderPath`/`profileNameUsableAsIs` rows in `ProfileNameValidationTest`. 81/81 ctest pass. Assisted-by: Claude:claude-opus-5
2026-08-08 08:30:14 +02:00
const QString selectedFolder = profileFolderPath(mudlet::getMudletPath(enums::profilesPath), selectedName);
const bool nameIsFolderOnDisk = (name == selectedName.trimmed()) && !selectedFolder.isEmpty() && QDir(selectedFolder).exists();
const bool nameUnchangedAndOnDisk = nameIsFolderOnDisk && profileNameUsableAsIs(name);
fix: profiles with parentheses in their name can be opened again (#9610) #### Brief overview of PR changes/additions - Parentheses are now allowed in profile names, matching the "name (2)" folders file managers create when copying - Selecting a profile folder made outside Mudlet no longer silently mangles its name and renames the folder on disk - Adds ProfileNameValidationTest for the name validation rules and ProfileFolderNameTest, which drives the real connection dialog against externally-created folders (fails without the fix) #### Motivation for adding to Mudlet Merely selecting a profile folder like "test (2)" mangled its name to "test 2" and silently renamed the folder on disk, and the reporter could not launch the profile at all. #### Other info (issues closed, discussion etc) Assisted-by: Claude:claude-fable-5 Assisted-by: Claude:claude-opus-5 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org> **Test case:** Copy a profile folder to "test (2)" while Mudlet is closed, reopen - the profile keeps its name, Connect/Offline are enabled, and it opens. #### Demo https://github.com/user-attachments/assets/25b1bb4c-eaa7-4079-8b8e-a12de3ebb215
2026-08-04 16:09:42 +02:00
const QChar invalidChar = nameUnchangedAndOnDisk ? QChar() : firstInvalidProfileNameChar(name);
if (!invalidChar.isNull()) {
notificationAreaIconLabelWarning->show();
notificationAreaMessageBox->setText(
qsl("%1\n%2\n%3\n").arg(notificationAreaMessageBox->text(), tr("The %1 character is not permitted. Use one of the following:").arg(invalidChar), scmAllowedProfileNameChars));
name.remove(invalidChar);
profile_name_entry->setText(name);
validName = false;
valid = false;
fix: a profile named "." or ".." deletes every profile when removed (#9722) #### Brief overview of PR changes/additions - Validation: a typed profile name must be a folder of its own - rejects a lone `.` and anything containing `..`. Folders already on disk stay exempt - Containment: `reallyDeleteProfile()` refuses any path that is not a direct child of `profiles/`, and now checks `removeRecursively()` instead of failing mute - Confirmation: the "nothing to delete" shortcut no longer fires when a map, stored password or dictionary is present #### Motivation for adding to Mudlet A profile named `.` or `..` turned **Remove** into a wipe: `.` resolves to `profiles/`, `..` to the whole `~/.config/mudlet`. The name was accepted with no error, and the confirmation was skipped because a fresh profile looks empty - two clicks deep on the first screen every user sees. #### Other info (issues closed, discussion etc) Pre-existing, not a 5.0 regression - shipped 4.22.0 behaves identically. Dots have been allowed deliberately since 2011 (`ee1fd051c`), and `Achaea 2.0` keeps working. **Test case:** name a new profile `.` and press Remove - previously every profile was deleted with no prompt, now the name is refused. New `ProfileDeletionSafetyTest` drives the real dialog against a temporary config dir, plus `profileFolderPath`/`profileNameUsableAsIs` rows in `ProfileNameValidationTest`. 81/81 ctest pass. Assisted-by: Claude:claude-opus-5
2026-08-08 08:30:14 +02:00
} else if (!nameIsFolderOnDisk && !name.isEmpty() && !profileNameUsableAsIs(name)) {
// Nothing to strip here, unlike the branch above: the characters
// are all permitted, it is the whole name that cannot be a folder
notificationAreaIconLabelWarning->show();
notificationAreaMessageBox->setText(
qsl("%1\n%2\n")
.arg(notificationAreaMessageBox->text(),
//: Shown when a profile name would not name a folder of its own. Keep the quoted dots as they are, they are literal characters the user typed
tr("A profile name cannot be \".\" or contain \"..\", as those refer to other folders on your computer. Please pick a different name.")));
validName = false;
valid = false;
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
}
// see if there is an edit that already uses a similar name
Improve: make new profile name check case insensitive (#6035) #### Brief overview of PR changes/additions Changed `mProfileList.contains(name)` which returned true only if exact match for name is in the list. This would let Windows users bypass profile name check if trying a similar name with different case. Now it has flag to make the comparison case insensitive. #### Motivation for adding to Mudlet On Windows, you can't create a new folder like `test` and then `Test`, and you can actually open either one to reach the same folder. Macs can also have a case-insensitive file system. #### Other info (issues closed, discussion etc) Fixes #6034
2022-04-06 07:58:34 -04:00
if ((QString::compare(pItem->data(csmNameRole).toString(), name, Qt::CaseInsensitive) != 0) && mProfileList.contains(name, Qt::CaseInsensitive)) {
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
notificationAreaIconLabelError->show();
Infrastructure: Add short qsl macro to stand in for 'QStringLiteral' (#5640)
2021-12-07 06:21:39 +01:00
notificationAreaMessageBox->setText(qsl("%1\n%2").arg(notificationAreaMessageBox->text(), tr("This profile name is already in use.")));
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
validName = false;
valid = false;
}
Infrastructure: mark read-only variables as const (#6843) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Mark read-only variables as const - that is, not intended to change after they've been declared #### Motivation for adding to Mudlet So we don't change them by accident later on, and also to clearly state intentions for the variables #### Other info (issues closed, discussion etc) This is also recommended by the [C++ Core Guidelines](https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#es25-declare-an-object-const-or-constexpr-unless-you-want-to-modify-its-value-later-on)
2023-05-14 15:06:15 +02:00
const QString port = port_entry->text().trimmed();
Infrastructure: Add short qsl macro to stand in for 'QStringLiteral' (#5640)
2021-12-07 06:21:39 +01:00
if (!port.isEmpty() && (port.indexOf(QRegularExpression(qsl("^\\d+$")), 0) == -1)) {
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
QString val = port;
val.chop(1);
port_entry->setText(val);
notificationAreaIconLabelError->show();
Infrastructure: Add short qsl macro to stand in for 'QStringLiteral' (#5640)
2021-12-07 06:21:39 +01:00
notificationAreaMessageBox->setText(qsl("%1\n%2").arg(notificationAreaMessageBox->text(), tr("You have to enter a number. Other characters are not permitted.")));
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
port_entry->setPalette(mErrorPalette);
validPort = false;
valid = false;
}
bool ok;
Infrastructure: mark read-only variables as const (#6843) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Mark read-only variables as const - that is, not intended to change after they've been declared #### Motivation for adding to Mudlet So we don't change them by accident later on, and also to clearly state intentions for the variables #### Other info (issues closed, discussion etc) This is also recommended by the [C++ Core Guidelines](https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#es25-declare-an-object-const-or-constexpr-unless-you-want-to-modify-its-value-later-on)
2023-05-14 15:06:15 +02:00
const int num = port.trimmed().toInt(&ok);
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
if (!port.isEmpty() && (num > 65536 && ok)) {
notificationAreaIconLabelError->show();
Infrastructure: Add short qsl macro to stand in for 'QStringLiteral' (#5640)
2021-12-07 06:21:39 +01:00
notificationAreaMessageBox->setText(qsl("%1\n%2\n\n").arg(notificationAreaMessageBox->text(), tr("Port number must be above zero and below 65535.")));
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
port_entry->setPalette(mErrorPalette);
validPort = false;
valid = false;
}
#if defined(QT_NO_SSL)
port_ssl_tsl->setEnabled(false);
Infrastructure: replace `qsl(...)` used for Tooltips (#5694) Specifically when it is used to put HTML like tags around the text so that it triggers the "rich-text" detector in the Qt libraries so that the tips gets better formatting than being a single (long) line of plain text. Whilst working on this PR I also spotted and fixed: * A couple of raw strings in the `VarUnit` class that should have been translated (or replaced with a `QString()`) - this required adding the `Q_DECLARE_TR_FUNCTIONS(`className`)` macro to that class as it is not derived from the `QObject` class which we normally use to provide the `QObject::tr(`...`)` method. * The tooltip for the "Save item" button in the editor contained a unmatched `<p>`...`</p>` tag pair as well as a useless (as it is ignored there) `\n` {Line Feed}. * The tooltip for the "Save profile" button in the editor contained a unmatched `<p>`...`</p>` tag pair. * I had previously defined the `QT_NO_CAST_FROM_ASCII` and `QT_NO_CAST_TO_ASCII` macros in the `dlgRoomExits` class but they are no longer considered useful for us so I have removed those Qt macros. * The `utils::richText(`...`)` wraper has exactly the same code effect as the `(const QString) singleParagraph` helper function in the `dlgRoomExits` class - so it has been replaced by that. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Vadim Peretokin <vperetokin@gmail.com>
2021-12-26 15:22:05 +00:00
port_ssl_tsl->setToolTip(utils::richText(tr("Mudlet is not configured for secure connections.")));
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
if (port_ssl_tsl->isChecked()) {
notificationAreaIconLabelError->show();
Infrastructure: Add short qsl macro to stand in for 'QStringLiteral' (#5640)
2021-12-07 06:21:39 +01:00
notificationAreaMessageBox->setText(qsl("%1\n%2\n\n").arg(notificationAreaMessageBox->text(), tr("Mudlet is not configured for secure connections.")));
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
port_ssl_tsl->setEnabled(true);
validPort = false;
valid = false;
}
#else
if (!QSslSocket::supportsSsl()) {
if (port_ssl_tsl->isChecked()) {
notificationAreaIconLabelError->show();
Infrastructure: Add short qsl macro to stand in for 'QStringLiteral' (#5640)
2021-12-07 06:21:39 +01:00
notificationAreaMessageBox->setText(qsl("%1\n%2\n\n").arg(notificationAreaMessageBox->text(), tr("Mudlet can not load support for secure connections.")));
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
validPort = false;
valid = false;
}
} else {
port_ssl_tsl->setEnabled(true);
Refactor: remove minute visible name from Connection dialogue icons We have been trying to hide the text associated with the `QListWidgetItems` in the connection dialogue by setting the font size to the minimum of `1` and by setting it's colour to be white. This is not effective when the background is not white - which is likely for a "Dark" desktop environment. The only way to successfully hide the text is, I think, to not have any! However the text was being used programmatically, so the best way to use a `QListWidget` in this mannar is to store the text elsewhere in each item's structure. Fortunately Qt provides for this with the user data functionality which allows multiple data items (based on the `QVariant` class) to be stored within each `QListWidgetItem` using an integer key to denote the type of the data. Ironically the text, icon and other details for each item are ALSO stored in this way - however for non-Qt internal use the lowest integer key that is to be used is `Qt::UserRole` - which I have assigned to the `(const int) dlgConnectionProfiles::csmNameRole` static value. It is quite possible that a redesign of the Connect Profiles dialogue may use this system to store/cache more details about each profile in the future! The only issue with this is the lack of a: `QListWidget::findData(const QVarient&data, int role = Qt::UserRole ...)` method (c.f. `QComboBox::findData(...)`) so I have had to provide a: `(QList<QListWidgetItem*>) findData(const QListWidget&, const QVariant&, const int role = Qt::UserRole) const; method to fill in this gap and to replace the previous `QListWidget::find(...)` that examined each item's text. Also removed local `(QString) profile` from: `(void) dlgConnectionProfiles::slot_item_clicked(QListWidgetItem*)` as it is merely a redundent duplicate of another local `(QString) profile_name`. Renamed local `(QListWidgetItem*) pM` from: `(void) dlgConnectionProfiles::fillout_form()` to: `(QListWidgetItem*) pItem` as that reflects the name used throughout the rest of the class for this type of variable. Changed a `(QLabel*)::setText(tr(""))` call to the more explicit and less stupid `(QLabel*)::clear()`. Similarly changed a `(QWidget*)::setToolTip("")` to a `(QWidget*)::setToolTip(QString())`. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2020-07-01 20:59:42 +01:00
port_ssl_tsl->setToolTip(QString());
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
}
#endif
Improve: don't freeze Mudlet when copying large profile (#5056)
2022-04-18 20:37:10 +02:00
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
QUrl check;
Infrastructure: mark read-only variables as const (#6843) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Mark read-only variables as const - that is, not intended to change after they've been declared #### Motivation for adding to Mudlet So we don't change them by accident later on, and also to clearly state intentions for the variables #### Other info (issues closed, discussion etc) This is also recommended by the [C++ Core Guidelines](https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#es25-declare-an-object-const-or-constexpr-unless-you-want-to-modify-its-value-later-on)
2023-05-14 15:06:15 +02:00
const QString url = host_name_entry->text().trimmed();
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
check.setHost(url);
More consistent validation for empty host in connection dialog (#4602) Co-authored-by: Piotr Wilczynski <piotr.wilczynski@bisnode.com>
2021-01-11 21:23:18 +01:00
if (url.isEmpty()) {
host_name_entry->setPalette(mErrorPalette);
validUrl = false;
valid = false;
}
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
if (!check.isValid()) {
notificationAreaIconLabelError->show();
Improve: don't freeze Mudlet when copying large profile (#5056)
2022-04-18 20:37:10 +02:00
notificationAreaMessageBox->setText(qsl("%1\n%2\n\n%3").arg(notificationAreaMessageBox->text(), tr("Please enter the URL or IP address of the Game server."), check.errorString()));
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
host_name_entry->setPalette(mErrorPalette);
validUrl = false;
valid = false;
}
Add: Happy-eyeballs (try IPv4 and IPv6 connections simultaneously) (#8135) #### Brief overview of PR changes/additions Overhauls the profile connection process to identify whether IPv4 and/or IPv6 protocol addresses are available for the entered details and if BOTH are to then try to connect with both at the same time (with a slight preference for IPv6 {by starting it first}). The first one to connect (including securely and/or via a proxy) wins out and terminates the process using the other address protocol. This technique is known as [Happy Eyeballs](https://en.wikipedia.org/wiki/Happy_Eyeballs). #### Motivation for adding to Mudlet To improve the end-user's experience if they are fortunate to be on a "dual-stack" (both protocols available) network. #### Other info (issues closed, discussion etc) The on-screen messages have been massaged somewhat to inform the user about the nature of the connection(s) being made. ALL the addresses that have been found for the Server are listed instead of just the first one {this includes a "numerus" translatable string which will need processing by yours truly!} Should a raw IP address be provided instead of a "URL" then the result of the "reverse" lookup (trying to get a host name from the IP address) is displayed instead of just repeating the address - if anything *is* found - if not that is also noted instead. One other effect of Mudlet being given a raw IP address is that those are not normally included in an SSL/TLS certificate - so rendering a secure connection impossible in that case - this was already noted for an IPv4 address but NOT for an IPv6 one. This PR corrects that to also reject secure connections being attempted if an IPv6 address is provided as the URL. --------- Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2025-11-10 23:34:39 +00:00
// Need to reject raw IP addresses (of either version 4 or 6 type) as
// it is very unlikely that the Security Certificates include them as
// a Host Name.
if (port_ssl_tsl->isChecked() && (cTelnet::isRawIPv4Address(url) || cTelnet::isRawIPv6Address(url))) {
notificationAreaIconLabelError->show();
// As the only tags are not on the first line the default
// Qt::AutoFormat won't detect that rich-text is present in this text!
notificationAreaMessageBox->setTextFormat(Qt::RichText);
/*: Please use two line-feeds after the first line so the second
Fix: clean up comments and related translation things (#8914) #### Brief overview of PR changes/additions Removes the `*`s in all but the first line of a multi-line translation comment that explains to the translators details of the Engineering English text in the source code. Whilst beginning each new line with an `*` can happen automagically in the Qt Creator as a result of the "Enable Doxygen Blocks" and "Add leading asterisks" options (in "Preferences" -> "Text Editor" -> "Documentation Comments") these are not always stripped out by the `lupdate` utility that generates the `mudlet.ts` file. Removes remaining `""` and replaces with `nullptr` any second arguments to `QObject::tr(...)` where a third argument is needed for the quantity for "numerus" (quantity dependent) translatable texts. Removes some, now obsolete, Windows specific code that identified if a 32-Bit version of Mudlet was being run in a 64-Bit Operating System. Since we no longer can produce such 32-Bit code it is now just cruft. Revises some quantity dependent code in `./src/dlgPackManager.cpp` so that only the zero cases are handled differently - in one place this means the conversion of a `.length() > 0` to an inverted `.isEmpty()` - and in three other places where a zero or one case was handled differently to the more than one case. #### Motivation for adding to Mudlet Improve the code quality and/or the situation for our translators. #### Other info (issues closed, discussion etc) Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2026-02-07 15:26:09 +00:00
line can be italicised and spaced out - if appropriate for
the locale.*/
Add: Happy-eyeballs (try IPv4 and IPv6 connections simultaneously) (#8135) #### Brief overview of PR changes/additions Overhauls the profile connection process to identify whether IPv4 and/or IPv6 protocol addresses are available for the entered details and if BOTH are to then try to connect with both at the same time (with a slight preference for IPv6 {by starting it first}). The first one to connect (including securely and/or via a proxy) wins out and terminates the process using the other address protocol. This technique is known as [Happy Eyeballs](https://en.wikipedia.org/wiki/Happy_Eyeballs). #### Motivation for adding to Mudlet To improve the end-user's experience if they are fortunate to be on a "dual-stack" (both protocols available) network. #### Other info (issues closed, discussion etc) The on-screen messages have been massaged somewhat to inform the user about the nature of the connection(s) being made. ALL the addresses that have been found for the Server are listed instead of just the first one {this includes a "numerus" translatable string which will need processing by yours truly!} Should a raw IP address be provided instead of a "URL" then the result of the "reverse" lookup (trying to get a host name from the IP address) is displayed instead of just repeating the address - if anything *is* found - if not that is also noted instead. One other effect of Mudlet being given a raw IP address is that those are not normally included in an SSL/TLS certificate - so rendering a secure connection impossible in that case - this was already noted for an IPv4 address but NOT for an IPv6 one. This PR corrects that to also reject secure connections being attempted if an IPv6 address is provided as the URL. --------- Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2025-11-10 23:34:39 +00:00
notificationAreaMessageBox->setText(qsl("%1%2\n\n%3")
.arg(!notificationAreaMessageBox->text().isEmpty() ? notificationAreaMessageBox->text().append(QChar::LineFeed) : QString(),
tr("Please enter the URL of the Game server.\n\n"
"<i>SSL/TLS connections require a URL, as an IP address is not a suitable "
"identifier for the certification of the Game Server.</i>"),
check.errorString()));
host_name_entry->setPalette(mErrorPalette);
validUrl = false;
valid = false;
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
}
if (valid) {
port_entry->setPalette(mOKPalette);
host_name_entry->setPalette(mOKPalette);
Enhance: remove minuscule text from under profile icons (#4712) This finally enables us to do away with the text under the profile icons as it replicates the normal `QListWidget` behaviour to move the selection to each item which begins with the first letter of the key pressed. This also makes the non-matching profiles get disabled which I think makes the action more obvious... Revised to include a timeout on concatenating keypresses: This is to provide the same functionality that the QListWidget does for keypresses, if the keys are typed fast enough they are concatenated to form the text to search for. However if the user types slower than this then the individual keys are only considered on their own. This reflects what both Vadim and I experienced - in that he was typing fast enough to spell out a particular profile but I wasn't and so the profile that I was having selected was changing on each keypress. The time between keypresses allowed so that they can be concatenated I have set to be 1 second. This is significantly slower that the Qt code but it is long enough to permit the temporary disablement of non-matching profiles to be a useful visual feedback - and besides, it makes it easier to specify one of a number of profiles with a common initial text - the longer the timeout the more keys the user can string together! Add `std::chrono` so we can give a time delay as `1s` instead of `1000` mS. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2021-02-03 19:59:35 +00:00
clearNotificationArea();
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
validName = true;
validPort = true;
validUrl = true;
Add support for opening a profile offline (#2580) * Added Load button to profile selection dialog. * Changed name of load button to offline. * Added successful load message. * Cleaned up some tooltip messages. * Removed obsolete arg historyVersion.
2019-06-01 14:35:50 -06:00
if (offline_button) {
offline_button->setEnabled(true);
Infrastructure: replace `qsl(...)` used for Tooltips (#5694) Specifically when it is used to put HTML like tags around the text so that it triggers the "rich-text" detector in the Qt libraries so that the tips gets better formatting than being a single (long) line of plain text. Whilst working on this PR I also spotted and fixed: * A couple of raw strings in the `VarUnit` class that should have been translated (or replaced with a `QString()`) - this required adding the `Q_DECLARE_TR_FUNCTIONS(`className`)` macro to that class as it is not derived from the `QObject` class which we normally use to provide the `QObject::tr(`...`)` method. * The tooltip for the "Save item" button in the editor contained a unmatched `<p>`...`</p>` tag pair as well as a useless (as it is ignored there) `\n` {Line Feed}. * The tooltip for the "Save profile" button in the editor contained a unmatched `<p>`...`</p>` tag pair. * I had previously defined the `QT_NO_CAST_FROM_ASCII` and `QT_NO_CAST_TO_ASCII` macros in the `dlgRoomExits` class but they are no longer considered useful for us so I have removed those Qt macros. * The `utils::richText(`...`)` wraper has exactly the same code effect as the `(const QString) singleParagraph` helper function in the `dlgRoomExits` class - so it has been replaced by that. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Vadim Peretokin <vperetokin@gmail.com>
2021-12-26 15:22:05 +00:00
offline_button->setToolTip(utils::richText(tr("Load profile without connecting.")));
Revise: try and identify profiles and some controls in connection dialog (#3966) Also convert all `setDisabled(state)` to `setEnabled(!state)` in the `dlgConnectionProfiles` class - using a single one instead of a mix of the two is less likely to lead to errors - and it means less effort to search for the places where something is being enabled or disabled. Shorten some overlong variable names. Remove some capitalisations. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2020-08-13 00:57:17 +01:00
offline_button->setAccessibleDescription(btn_load_enabled_accessDesc);
Add support for opening a profile offline (#2580) * Added Load button to profile selection dialog. * Changed name of load button to offline. * Added successful load message. * Cleaned up some tooltip messages. * Removed obsolete arg historyVersion.
2019-06-01 14:35:50 -06:00
}
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
if (connect_button) {
connect_button->setEnabled(true);
connect_button->setToolTip(QString());
Revise: try and identify profiles and some controls in connection dialog (#3966) Also convert all `setDisabled(state)` to `setEnabled(!state)` in the `dlgConnectionProfiles` class - using a single one instead of a mix of the two is less likely to lead to errors - and it means less effort to search for the places where something is being enabled or disabled. Shorten some overlong variable names. Remove some capitalisations. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2020-08-13 00:57:17 +01:00
connect_button->setAccessibleDescription(btn_connect_enabled_accessDesc);
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
}
return true;
}
Infrastructure: fix else-after-return in codebase (#9096) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Remove unnecessary else/else-if after return, break, continue, and throw statements - and in places where fixing them is more trouble than its worth, added NOLINT. #### Motivation for adding to Mudlet https://clang.llvm.org/extra/clang-tidy/checks/readability/else-after-return.html, so it doesn't pop up in PR reviews. #### Other info (issues closed, discussion etc) --------- Co-authored-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
2026-07-18 18:39:57 +02:00
if (!notificationAreaMessageBox->text().isEmpty()) {
notificationArea->show();
notificationAreaMessageBox->show();
}
if (offline_button) {
offline_button->setEnabled(false);
offline_button->setToolTip(utils::richText(tr("Please set a valid profile name, game server address and the game port before loading.")));
offline_button->setAccessibleDescription(btn_connOrLoad_disabled_accessDesc);
}
if (connect_button) {
connect_button->setEnabled(false);
connect_button->setToolTip(utils::richText(tr("Please set a valid profile name, game server address and the game port before connecting.")));
connect_button->setAccessibleDescription(btn_connOrLoad_disabled_accessDesc);
}
return false;
Implement SSL (#1146) (#1858)
2019-01-06 06:29:16 -05:00
}
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
return false;
}
// credit: http://www.qtcentre.org/archive/index.php/t-23469.html
Improve: don't freeze Mudlet when copying large profile (#5056)
2022-04-18 20:37:10 +02:00
bool dlgConnectionProfiles::copyFolder(const QString& sourceFolder, const QString& destFolder)
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
{
Infrastructure: mark read-only variables as const (#6843) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Mark read-only variables as const - that is, not intended to change after they've been declared #### Motivation for adding to Mudlet So we don't change them by accident later on, and also to clearly state intentions for the variables #### Other info (issues closed, discussion etc) This is also recommended by the [C++ Core Guidelines](https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#es25-declare-an-object-const-or-constexpr-unless-you-want-to-modify-its-value-later-on)
2023-05-14 15:06:15 +02:00
const QDir sourceDir(sourceFolder);
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
if (!sourceDir.exists()) {
Improve: don't freeze Mudlet when copying large profile (#5056)
2022-04-18 20:37:10 +02:00
return false;
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
}
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
Infrastructure: mark read-only variables as const (#6843) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Mark read-only variables as const - that is, not intended to change after they've been declared #### Motivation for adding to Mudlet So we don't change them by accident later on, and also to clearly state intentions for the variables #### Other info (issues closed, discussion etc) This is also recommended by the [C++ Core Guidelines](https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#es25-declare-an-object-const-or-constexpr-unless-you-want-to-modify-its-value-later-on)
2023-05-14 15:06:15 +02:00
const QDir destDir(destFolder);
Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces
2017-06-26 16:46:54 +02:00
if (!destDir.exists()) {
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
destDir.mkdir(destFolder);
}
QStringList files = sourceDir.entryList(QDir::Files);
Fix: Clazy warnings part 1 - range-loop-detach (#9195) #### Brief overview of PR changes/additions One of a series of PRs, each addressing a type of issue reported by Clazy. This is the: "C+11 range-loop might detach Qt container [clazy-range-loop-detach]" one. #### Motivation for adding to Mudlet Remove warnings detected by the Clazy tool - either when explicitly run on the Mudlet code-base or detected by the background scanner/analyser that Qt Creator offers. #### Other info (issues closed, discussion etc) There was over 100 of this particular item - some of them also could have `const` applied to the iterator. --------- Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
2026-04-16 14:30:33 +01:00
for (const QString& file : std::as_const(files)) {
Infra: Use modern For loop syntax (#8162) #### Brief overview of PR changes/additions No functional change, just internal refactoring #### Motivation for adding to Mudlet Easier to read, clearer style #### Other info (issues closed, discussion etc)
2025-09-16 13:15:54 +02:00
const QString srcName = sourceFolder + QDir::separator() + file;
const QString destName = destFolder + QDir::separator() + file;
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
QFile::copy(srcName, destName);
}
files.clear();
files = sourceDir.entryList(QDir::AllDirs | QDir::NoDotAndDotDot);
Fix: Clazy warnings part 1 - range-loop-detach (#9195) #### Brief overview of PR changes/additions One of a series of PRs, each addressing a type of issue reported by Clazy. This is the: "C+11 range-loop might detach Qt container [clazy-range-loop-detach]" one. #### Motivation for adding to Mudlet Remove warnings detected by the Clazy tool - either when explicitly run on the Mudlet code-base or detected by the background scanner/analyser that Qt Creator offers. #### Other info (issues closed, discussion etc) There was over 100 of this particular item - some of them also could have `const` applied to the iterator. --------- Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
2026-04-16 14:30:33 +01:00
for (const QString& file : std::as_const(files)) {
Infra: Use modern For loop syntax (#8162) #### Brief overview of PR changes/additions No functional change, just internal refactoring #### Motivation for adding to Mudlet Easier to read, clearer style #### Other info (issues closed, discussion etc)
2025-09-16 13:15:54 +02:00
const QString srcName = sourceFolder + QDir::separator() + file;
const QString destName = destFolder + QDir::separator() + file;
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
copyFolder(srcName, destName);
}
Improve: don't freeze Mudlet when copying large profile (#5056)
2022-04-18 20:37:10 +02:00
return true;
improved connection dialog Signed-off-by: Heiko Koehn <koehnheiko@googlemail.com>
2011-05-26 14:43:30 +02:00
}
Enhance: add option to reveal password temporarily on demand (#3040) This is an edited summary for a collection of 5 commits: * Enhance: add option to reveal password temporarily on demand This will show the password when the eye icon is clicked on until a different profile is selected or it is clicked a second time. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Also rename the icon used when the password is hidden as it is a modified version (of an oxygen theme one) so it is not wise to use the original name. Refactored to remove an unneeded new slot that can be done without; by restructuring things I did not need to have a second slot just to hide the password when the user changed selected profile - it was needed when a Timer was used to automatically hide the password but in its absence a direct call to the other new slot and a fixed argument - is sufficient. Revised to switch to using icons from theme for show/hide password And provide some `.png` icons if they are not in the current desktop theme (on Linux/FreeBSD) or the OS does not provide such a system for them... These icons were created by myself and I will licensing them under GPL 2.0 (or later terms). Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2019-09-20 22:47:20 +01:00
// As it is wired to the triggered() signal it is only called that way when
// the user clicks on the action, and not when setChecked() is used.
void dlgConnectionProfiles::slot_togglePasswordVisibility(const bool showPassword)
{
if (mpAction_revealPassword->isChecked() != showPassword) {
// This will only be reached and needed by a call NOT prompted by the
// user clicking on the icon - i.e. either when a different profile is
// selected or when called from the constructor:
mpAction_revealPassword->setChecked(showPassword);
}
if (mpAction_revealPassword->isChecked()) {
character_password_entry->setEchoMode(QLineEdit::Normal);
// In practice I could not get the icon to change based upon supplying
Translate remaining German comments (#4276) * De-German-ize comments * Variable rename: "dehnung" > "scale" * whilst > while (modern US English) * Fix apostrophe use * Fix random issues * Improve Readability * Remove duplicate line
2020-11-05 10:56:26 +01:00
// different QPixmaps for the QIcon for different states - so let's do it
Enhance: add option to reveal password temporarily on demand (#3040) This is an edited summary for a collection of 5 commits: * Enhance: add option to reveal password temporarily on demand This will show the password when the eye icon is clicked on until a different profile is selected or it is clicked a second time. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Also rename the icon used when the password is hidden as it is a modified version (of an oxygen theme one) so it is not wise to use the original name. Refactored to remove an unneeded new slot that can be done without; by restructuring things I did not need to have a second slot just to hide the password when the user changed selected profile - it was needed when a Timer was used to automatically hide the password but in its absence a direct call to the other new slot and a fixed argument - is sufficient. Revised to switch to using icons from theme for show/hide password And provide some `.png` icons if they are not in the current desktop theme (on Linux/FreeBSD) or the OS does not provide such a system for them... These icons were created by myself and I will licensing them under GPL 2.0 (or later terms). Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2019-09-20 22:47:20 +01:00
// directly:
Infrastructure: Add short qsl macro to stand in for 'QStringLiteral' (#5640)
2021-12-07 06:21:39 +01:00
mpAction_revealPassword->setIcon(QIcon::fromTheme(qsl("password-show-on"), QIcon(qsl(":/icons/password-show-on.png"))));
Infrastructure: replace `qsl(...)` used for Tooltips (#5694) Specifically when it is used to put HTML like tags around the text so that it triggers the "rich-text" detector in the Qt libraries so that the tips gets better formatting than being a single (long) line of plain text. Whilst working on this PR I also spotted and fixed: * A couple of raw strings in the `VarUnit` class that should have been translated (or replaced with a `QString()`) - this required adding the `Q_DECLARE_TR_FUNCTIONS(`className`)` macro to that class as it is not derived from the `QObject` class which we normally use to provide the `QObject::tr(`...`)` method. * The tooltip for the "Save item" button in the editor contained a unmatched `<p>`...`</p>` tag pair as well as a useless (as it is ignored there) `\n` {Line Feed}. * The tooltip for the "Save profile" button in the editor contained a unmatched `<p>`...`</p>` tag pair. * I had previously defined the `QT_NO_CAST_FROM_ASCII` and `QT_NO_CAST_TO_ASCII` macros in the `dlgRoomExits` class but they are no longer considered useful for us so I have removed those Qt macros. * The `utils::richText(`...`)` wraper has exactly the same code effect as the `(const QString) singleParagraph` helper function in the `dlgRoomExits` class - so it has been replaced by that. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Vadim Peretokin <vperetokin@gmail.com>
2021-12-26 15:22:05 +00:00
mpAction_revealPassword->setToolTip(utils::richText(tr("Click to hide the password; it will also hide if another profile is selected.")));
Enhance: add option to reveal password temporarily on demand (#3040) This is an edited summary for a collection of 5 commits: * Enhance: add option to reveal password temporarily on demand This will show the password when the eye icon is clicked on until a different profile is selected or it is clicked a second time. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Also rename the icon used when the password is hidden as it is a modified version (of an oxygen theme one) so it is not wise to use the original name. Refactored to remove an unneeded new slot that can be done without; by restructuring things I did not need to have a second slot just to hide the password when the user changed selected profile - it was needed when a Timer was used to automatically hide the password but in its absence a direct call to the other new slot and a fixed argument - is sufficient. Revised to switch to using icons from theme for show/hide password And provide some `.png` icons if they are not in the current desktop theme (on Linux/FreeBSD) or the OS does not provide such a system for them... These icons were created by myself and I will licensing them under GPL 2.0 (or later terms). Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2019-09-20 22:47:20 +01:00
} else {
character_password_entry->setEchoMode(QLineEdit::Password);
Infrastructure: Add short qsl macro to stand in for 'QStringLiteral' (#5640)
2021-12-07 06:21:39 +01:00
mpAction_revealPassword->setIcon(QIcon::fromTheme(qsl("password-show-off"), QIcon(qsl(":/icons/password-show-off.png"))));
Infrastructure: replace `qsl(...)` used for Tooltips (#5694) Specifically when it is used to put HTML like tags around the text so that it triggers the "rich-text" detector in the Qt libraries so that the tips gets better formatting than being a single (long) line of plain text. Whilst working on this PR I also spotted and fixed: * A couple of raw strings in the `VarUnit` class that should have been translated (or replaced with a `QString()`) - this required adding the `Q_DECLARE_TR_FUNCTIONS(`className`)` macro to that class as it is not derived from the `QObject` class which we normally use to provide the `QObject::tr(`...`)` method. * The tooltip for the "Save item" button in the editor contained a unmatched `<p>`...`</p>` tag pair as well as a useless (as it is ignored there) `\n` {Line Feed}. * The tooltip for the "Save profile" button in the editor contained a unmatched `<p>`...`</p>` tag pair. * I had previously defined the `QT_NO_CAST_FROM_ASCII` and `QT_NO_CAST_TO_ASCII` macros in the `dlgRoomExits` class but they are no longer considered useful for us so I have removed those Qt macros. * The `utils::richText(`...`)` wraper has exactly the same code effect as the `(const QString) singleParagraph` helper function in the `dlgRoomExits` class - so it has been replaced by that. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Vadim Peretokin <vperetokin@gmail.com>
2021-12-26 15:22:05 +00:00
mpAction_revealPassword->setToolTip(utils::richText(tr("Click to reveal the password for this profile.")));
Enhance: add option to reveal password temporarily on demand (#3040) This is an edited summary for a collection of 5 commits: * Enhance: add option to reveal password temporarily on demand This will show the password when the eye icon is clicked on until a different profile is selected or it is clicked a second time. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Also rename the icon used when the password is hidden as it is a modified version (of an oxygen theme one) so it is not wise to use the original name. Refactored to remove an unneeded new slot that can be done without; by restructuring things I did not need to have a second slot just to hide the password when the user changed selected profile - it was needed when a Timer was used to automatically hide the password but in its absence a direct call to the other new slot and a fixed argument - is sufficient. Revised to switch to using icons from theme for show/hide password And provide some `.png` icons if they are not in the current desktop theme (on Linux/FreeBSD) or the OS does not provide such a system for them... These icons were created by myself and I will licensing them under GPL 2.0 (or later terms). Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2019-09-20 22:47:20 +01:00
}
}
Refactor: remove minute visible name from Connection dialogue icons We have been trying to hide the text associated with the `QListWidgetItems` in the connection dialogue by setting the font size to the minimum of `1` and by setting it's colour to be white. This is not effective when the background is not white - which is likely for a "Dark" desktop environment. The only way to successfully hide the text is, I think, to not have any! However the text was being used programmatically, so the best way to use a `QListWidget` in this mannar is to store the text elsewhere in each item's structure. Fortunately Qt provides for this with the user data functionality which allows multiple data items (based on the `QVariant` class) to be stored within each `QListWidgetItem` using an integer key to denote the type of the data. Ironically the text, icon and other details for each item are ALSO stored in this way - however for non-Qt internal use the lowest integer key that is to be used is `Qt::UserRole` - which I have assigned to the `(const int) dlgConnectionProfiles::csmNameRole` static value. It is quite possible that a redesign of the Connect Profiles dialogue may use this system to store/cache more details about each profile in the future! The only issue with this is the lack of a: `QListWidget::findData(const QVarient&data, int role = Qt::UserRole ...)` method (c.f. `QComboBox::findData(...)`) so I have had to provide a: `(QList<QListWidgetItem*>) findData(const QListWidget&, const QVariant&, const int role = Qt::UserRole) const; method to fill in this gap and to replace the previous `QListWidget::find(...)` that examined each item's text. Also removed local `(QString) profile` from: `(void) dlgConnectionProfiles::slot_item_clicked(QListWidgetItem*)` as it is merely a redundent duplicate of another local `(QString) profile_name`. Renamed local `(QListWidgetItem*) pM` from: `(void) dlgConnectionProfiles::fillout_form()` to: `(QListWidgetItem*) pItem` as that reflects the name used throughout the rest of the class for this type of variable. Changed a `(QLabel*)::setText(tr(""))` call to the more explicit and less stupid `(QLabel*)::clear()`. Similarly changed a `(QWidget*)::setToolTip("")` to a `(QWidget*)::setToolTip(QString())`. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2020-07-01 20:59:42 +01:00
QList<QListWidgetItem*> dlgConnectionProfiles::findData(const QListWidget& listWidget, const QVariant& what, const int role) const
{
QList<QListWidgetItem*> results;
for (int index = 0, total = listWidget.count(); index < total; ++index) {
if (listWidget.item(index)->data(role) == what) {
results.append(listWidget.item(index));
}
}
return results;
}
Revise: select profiles by typing the name, keep profile icons (#4440) Restore the text display of the profile name. This is so that the keyboard selection of profiles beginning with a particular letter works again. This will close issue #4283 . This also sets it to the minimum size trying to hide it by setting the font size to 1 - however that still show something (and a font size of zero is NOT valid). Manipulating the QPalette of the QListWidget does not work well enough in the presence of Styles or StyleSheets to be a viable means of hiding the text either. Also in the `dlgConnection` class: * refactor out some highly repetitive code that sets up the predefined Mud icons. * remove warnings and adopts a change introduced into Qt 5.15 for the QLabel::pixmap() which now requires a Qt::ReturnByValue argument to prevent an obsolete code warning and to force a QPixmap to be returned by value and not reference... * remove a warning about: QListWidget::setItemSelected(QListWidgetItem*,bool) being deprecated and switches to the recommended: QListWidgetItem::setSelected(bool) Edit: the last item above may have become redundant as further commits amalgamated into this PR may have taken out these lines anyhow! Change the custom icon generator so that there is NOT a dependency on the position in the list for the colours used. This means that the same name will always have the same colours - which will help the user to pick out a particular profile as it will always look the same no matter if other profiles are added or removed. Remove the colour gradient in the custom icon as it is not thought to be useful nowadays. Refactor out the colour icon generator to a single method that is called from more than one place. BugFix: restore odd original way of accessing some QPixmaps This was causing failures in some CI platforms using Qt 5.14. or older. Revise: really frob the custom icon generator This is to try and produce as varied but still readable icons when they are generated entirely on the basis of the MUD name - in a reproducible (though Qt do NOT guarantee repeatable qHash() functionality across Qt versions - so they may not stay *that* constant) manner. Refrob: use a table of fixed colours Using only 15 hues but with 3 different saturation level plus 5 grey-scale one should give enough different icons but not generate them too close to each other for those with normal colour vision... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Kebap <kebap_spam@gmx.net>
2020-12-11 17:53:28 +00:00
Enhance: remove minuscule text from under profile icons (#4712) This finally enables us to do away with the text under the profile icons as it replicates the normal `QListWidget` behaviour to move the selection to each item which begins with the first letter of the key pressed. This also makes the non-matching profiles get disabled which I think makes the action more obvious... Revised to include a timeout on concatenating keypresses: This is to provide the same functionality that the QListWidget does for keypresses, if the keys are typed fast enough they are concatenated to form the text to search for. However if the user types slower than this then the individual keys are only considered on their own. This reflects what both Vadim and I experienced - in that he was typing fast enough to spell out a particular profile but I wasn't and so the profile that I was having selected was changing on each keypress. The time between keypresses allowed so that they can be concatenated I have set to be 1 second. This is significantly slower that the Qt code but it is long enough to permit the temporary disablement of non-matching profiles to be a useful visual feedback - and besides, it makes it easier to specify one of a number of profiles with a common initial text - the longer the timeout the more keys the user can string together! Add `std::chrono` so we can give a time delay as `1s` instead of `1000` mS. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2021-02-03 19:59:35 +00:00
QList<int> dlgConnectionProfiles::findProfilesBeginningWith(const QString& what) const
{
QList<int> results;
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
for (int index = 0, total = listWidget_profiles->count(); index < total; ++index) {
if (listWidget_profiles->item(index)->data(csmNameRole).toString().startsWith(what, Qt::CaseInsensitive)) {
Enhance: remove minuscule text from under profile icons (#4712) This finally enables us to do away with the text under the profile icons as it replicates the normal `QListWidget` behaviour to move the selection to each item which begins with the first letter of the key pressed. This also makes the non-matching profiles get disabled which I think makes the action more obvious... Revised to include a timeout on concatenating keypresses: This is to provide the same functionality that the QListWidget does for keypresses, if the keys are typed fast enough they are concatenated to form the text to search for. However if the user types slower than this then the individual keys are only considered on their own. This reflects what both Vadim and I experienced - in that he was typing fast enough to spell out a particular profile but I wasn't and so the profile that I was having selected was changing on each keypress. The time between keypresses allowed so that they can be concatenated I have set to be 1 second. This is significantly slower that the Qt code but it is long enough to permit the temporary disablement of non-matching profiles to be a useful visual feedback - and besides, it makes it easier to specify one of a number of profiles with a common initial text - the longer the timeout the more keys the user can string together! Add `std::chrono` so we can give a time delay as `1s` instead of `1000` mS. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2021-02-03 19:59:35 +00:00
results.append(index);
}
}
return results;
}
Revise: select profiles by typing the name, keep profile icons (#4440) Restore the text display of the profile name. This is so that the keyboard selection of profiles beginning with a particular letter works again. This will close issue #4283 . This also sets it to the minimum size trying to hide it by setting the font size to 1 - however that still show something (and a font size of zero is NOT valid). Manipulating the QPalette of the QListWidget does not work well enough in the presence of Styles or StyleSheets to be a viable means of hiding the text either. Also in the `dlgConnection` class: * refactor out some highly repetitive code that sets up the predefined Mud icons. * remove warnings and adopts a change introduced into Qt 5.15 for the QLabel::pixmap() which now requires a Qt::ReturnByValue argument to prevent an obsolete code warning and to force a QPixmap to be returned by value and not reference... * remove a warning about: QListWidget::setItemSelected(QListWidgetItem*,bool) being deprecated and switches to the recommended: QListWidgetItem::setSelected(bool) Edit: the last item above may have become redundant as further commits amalgamated into this PR may have taken out these lines anyhow! Change the custom icon generator so that there is NOT a dependency on the position in the list for the colours used. This means that the same name will always have the same colours - which will help the user to pick out a particular profile as it will always look the same no matter if other profiles are added or removed. Remove the colour gradient in the custom icon as it is not thought to be useful nowadays. Refactor out the colour icon generator to a single method that is called from more than one place. BugFix: restore odd original way of accessing some QPixmaps This was causing failures in some CI platforms using Qt 5.14. or older. Revise: really frob the custom icon generator This is to try and produce as varied but still readable icons when they are generated entirely on the basis of the MUD name - in a reproducible (though Qt do NOT guarantee repeatable qHash() functionality across Qt versions - so they may not stay *that* constant) manner. Refrob: use a table of fixed colours Using only 15 hues but with 3 different saturation level plus 5 grey-scale one should give enough different icons but not generate them too close to each other for those with normal colour vision... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Kebap <kebap_spam@gmx.net>
2020-12-11 17:53:28 +00:00
void dlgConnectionProfiles::setItemName(QListWidgetItem* pI, const QString& name) const
{
if (!pI) {
// Avoid any problems should the supplied argument be a nullptr:
return;
}
pI->setData(csmNameRole, name);
pI->setData(Qt::AccessibleTextRole, item_profile_accessName.arg(name));
pI->setData(Qt::AccessibleDescriptionRole, item_profile_accessDesc);
}
void dlgConnectionProfiles::setupMudProfile(QListWidgetItem* pItem, const QString& mudServer, const QString& serverDescription, const QString& iconFileName)
{
setItemName(pItem, mudServer);
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
listWidget_profiles->addItem(pItem);
Revise: select profiles by typing the name, keep profile icons (#4440) Restore the text display of the profile name. This is so that the keyboard selection of profiles beginning with a particular letter works again. This will close issue #4283 . This also sets it to the minimum size trying to hide it by setting the font size to 1 - however that still show something (and a font size of zero is NOT valid). Manipulating the QPalette of the QListWidget does not work well enough in the presence of Styles or StyleSheets to be a viable means of hiding the text either. Also in the `dlgConnection` class: * refactor out some highly repetitive code that sets up the predefined Mud icons. * remove warnings and adopts a change introduced into Qt 5.15 for the QLabel::pixmap() which now requires a Qt::ReturnByValue argument to prevent an obsolete code warning and to force a QPixmap to be returned by value and not reference... * remove a warning about: QListWidget::setItemSelected(QListWidgetItem*,bool) being deprecated and switches to the recommended: QListWidgetItem::setSelected(bool) Edit: the last item above may have become redundant as further commits amalgamated into this PR may have taken out these lines anyhow! Change the custom icon generator so that there is NOT a dependency on the position in the list for the colours used. This means that the same name will always have the same colours - which will help the user to pick out a particular profile as it will always look the same no matter if other profiles are added or removed. Remove the colour gradient in the custom icon as it is not thought to be useful nowadays. Refactor out the colour icon generator to a single method that is called from more than one place. BugFix: restore odd original way of accessing some QPixmaps This was causing failures in some CI platforms using Qt 5.14. or older. Revise: really frob the custom icon generator This is to try and produce as varied but still readable icons when they are generated entirely on the basis of the MUD name - in a reproducible (though Qt do NOT guarantee repeatable qHash() functionality across Qt versions - so they may not stay *that* constant) manner. Refrob: use a table of fixed colours Using only 15 hues but with 3 different saturation level plus 5 grey-scale one should give enough different icons but not generate them too close to each other for those with normal colour vision... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Kebap <kebap_spam@gmx.net>
2020-12-11 17:53:28 +00:00
if (!hasCustomIcon(mudServer)) {
Infrastructure: reposition const before type specifier (#7179) #### Brief overview of PR changes/additions This PR tries to put all `const`s before the type (class). #### Motivation for adding to Mudlet There is a mix of positioning of `const`s where it is used to indicate that a variable is not to be modified by program code, we tend to put it before the type but a prior PR (which looks to have been done with an automated tool) has resulted in a mix of cases some with the const adjacent to the variable. This lack of consistency can be confusing. #### Other info (issues closed, discussion etc) It looks like this came about in #6843. This will upset the Danger detector because of the number of files modified but it should be fairly straightforward to review. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2024-03-11 15:40:56 +00:00
const QPixmap pixmap(iconFileName);
Infrastructure: improve too-short variable names A-H (#6745) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve names of variables that are too short and not meaningful #### Motivation for adding to Mudlet So developers have an easier time working with Mudlets code - it's crucial to be able to attract and retain folks working on the project for its success! #### Other info (issues closed, discussion etc)
2023-04-15 06:38:20 +02:00
if (pixmap.isNull()) {
Fix `--profile` to load connection info for first-time profiles (2/2) (#5381)
2021-08-21 15:44:37 +02:00
qWarning() << mudServer << "doesn't have a valid icon";
return;
}
Infrastructure: improve too-short variable names A-H (#6745) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve names of variables that are too short and not meaningful #### Motivation for adding to Mudlet So developers have an easier time working with Mudlets code - it's crucial to be able to attract and retain folks working on the project for its success! #### Other info (issues closed, discussion etc)
2023-04-15 06:38:20 +02:00
if (pixmap.width() != 120) {
pItem->setIcon(pixmap.scaled(QSize(120, 30), Qt::IgnoreAspectRatio, Qt::SmoothTransformation));
Revise: select profiles by typing the name, keep profile icons (#4440) Restore the text display of the profile name. This is so that the keyboard selection of profiles beginning with a particular letter works again. This will close issue #4283 . This also sets it to the minimum size trying to hide it by setting the font size to 1 - however that still show something (and a font size of zero is NOT valid). Manipulating the QPalette of the QListWidget does not work well enough in the presence of Styles or StyleSheets to be a viable means of hiding the text either. Also in the `dlgConnection` class: * refactor out some highly repetitive code that sets up the predefined Mud icons. * remove warnings and adopts a change introduced into Qt 5.15 for the QLabel::pixmap() which now requires a Qt::ReturnByValue argument to prevent an obsolete code warning and to force a QPixmap to be returned by value and not reference... * remove a warning about: QListWidget::setItemSelected(QListWidgetItem*,bool) being deprecated and switches to the recommended: QListWidgetItem::setSelected(bool) Edit: the last item above may have become redundant as further commits amalgamated into this PR may have taken out these lines anyhow! Change the custom icon generator so that there is NOT a dependency on the position in the list for the colours used. This means that the same name will always have the same colours - which will help the user to pick out a particular profile as it will always look the same no matter if other profiles are added or removed. Remove the colour gradient in the custom icon as it is not thought to be useful nowadays. Refactor out the colour icon generator to a single method that is called from more than one place. BugFix: restore odd original way of accessing some QPixmaps This was causing failures in some CI platforms using Qt 5.14. or older. Revise: really frob the custom icon generator This is to try and produce as varied but still readable icons when they are generated entirely on the basis of the MUD name - in a reproducible (though Qt do NOT guarantee repeatable qHash() functionality across Qt versions - so they may not stay *that* constant) manner. Refrob: use a table of fixed colours Using only 15 hues but with 3 different saturation level plus 5 grey-scale one should give enough different icons but not generate them too close to each other for those with normal colour vision... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Kebap <kebap_spam@gmx.net>
2020-12-11 17:53:28 +00:00
} else {
pItem->setIcon(QIcon(iconFileName));
}
} else {
setCustomIcon(mudServer, pItem);
}
if (!serverDescription.isEmpty()) {
Infrastructure: replace `qsl(...)` used for Tooltips (#5694) Specifically when it is used to put HTML like tags around the text so that it triggers the "rich-text" detector in the Qt libraries so that the tips gets better formatting than being a single (long) line of plain text. Whilst working on this PR I also spotted and fixed: * A couple of raw strings in the `VarUnit` class that should have been translated (or replaced with a `QString()`) - this required adding the `Q_DECLARE_TR_FUNCTIONS(`className`)` macro to that class as it is not derived from the `QObject` class which we normally use to provide the `QObject::tr(`...`)` method. * The tooltip for the "Save item" button in the editor contained a unmatched `<p>`...`</p>` tag pair as well as a useless (as it is ignored there) `\n` {Line Feed}. * The tooltip for the "Save profile" button in the editor contained a unmatched `<p>`...`</p>` tag pair. * I had previously defined the `QT_NO_CAST_FROM_ASCII` and `QT_NO_CAST_TO_ASCII` macros in the `dlgRoomExits` class but they are no longer considered useful for us so I have removed those Qt macros. * The `utils::richText(`...`)` wraper has exactly the same code effect as the `(const QString) singleParagraph` helper function in the `dlgRoomExits` class - so it has been replaced by that. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Vadim Peretokin <vperetokin@gmail.com>
2021-12-26 15:22:05 +00:00
pItem->setToolTip(utils::richText(serverDescription));
Revise: select profiles by typing the name, keep profile icons (#4440) Restore the text display of the profile name. This is so that the keyboard selection of profiles beginning with a particular letter works again. This will close issue #4283 . This also sets it to the minimum size trying to hide it by setting the font size to 1 - however that still show something (and a font size of zero is NOT valid). Manipulating the QPalette of the QListWidget does not work well enough in the presence of Styles or StyleSheets to be a viable means of hiding the text either. Also in the `dlgConnection` class: * refactor out some highly repetitive code that sets up the predefined Mud icons. * remove warnings and adopts a change introduced into Qt 5.15 for the QLabel::pixmap() which now requires a Qt::ReturnByValue argument to prevent an obsolete code warning and to force a QPixmap to be returned by value and not reference... * remove a warning about: QListWidget::setItemSelected(QListWidgetItem*,bool) being deprecated and switches to the recommended: QListWidgetItem::setSelected(bool) Edit: the last item above may have become redundant as further commits amalgamated into this PR may have taken out these lines anyhow! Change the custom icon generator so that there is NOT a dependency on the position in the list for the colours used. This means that the same name will always have the same colours - which will help the user to pick out a particular profile as it will always look the same no matter if other profiles are added or removed. Remove the colour gradient in the custom icon as it is not thought to be useful nowadays. Refactor out the colour icon generator to a single method that is called from more than one place. BugFix: restore odd original way of accessing some QPixmaps This was causing failures in some CI platforms using Qt 5.14. or older. Revise: really frob the custom icon generator This is to try and produce as varied but still readable icons when they are generated entirely on the basis of the MUD name - in a reproducible (though Qt do NOT guarantee repeatable qHash() functionality across Qt versions - so they may not stay *that* constant) manner. Refrob: use a table of fixed colours Using only 15 hues but with 3 different saturation level plus 5 grey-scale one should give enough different icons but not generate them too close to each other for those with normal colour vision... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Kebap <kebap_spam@gmx.net>
2020-12-11 17:53:28 +00:00
}
}
Add ability to define custom color in profile buttons in connection dialog (#5365)
2021-08-13 07:22:24 +02:00
QIcon dlgConnectionProfiles::customIcon(const QString& text, const std::optional<QColor>& backgroundColor) const
Revise: select profiles by typing the name, keep profile icons (#4440) Restore the text display of the profile name. This is so that the keyboard selection of profiles beginning with a particular letter works again. This will close issue #4283 . This also sets it to the minimum size trying to hide it by setting the font size to 1 - however that still show something (and a font size of zero is NOT valid). Manipulating the QPalette of the QListWidget does not work well enough in the presence of Styles or StyleSheets to be a viable means of hiding the text either. Also in the `dlgConnection` class: * refactor out some highly repetitive code that sets up the predefined Mud icons. * remove warnings and adopts a change introduced into Qt 5.15 for the QLabel::pixmap() which now requires a Qt::ReturnByValue argument to prevent an obsolete code warning and to force a QPixmap to be returned by value and not reference... * remove a warning about: QListWidget::setItemSelected(QListWidgetItem*,bool) being deprecated and switches to the recommended: QListWidgetItem::setSelected(bool) Edit: the last item above may have become redundant as further commits amalgamated into this PR may have taken out these lines anyhow! Change the custom icon generator so that there is NOT a dependency on the position in the list for the colours used. This means that the same name will always have the same colours - which will help the user to pick out a particular profile as it will always look the same no matter if other profiles are added or removed. Remove the colour gradient in the custom icon as it is not thought to be useful nowadays. Refactor out the colour icon generator to a single method that is called from more than one place. BugFix: restore odd original way of accessing some QPixmaps This was causing failures in some CI platforms using Qt 5.14. or older. Revise: really frob the custom icon generator This is to try and produce as varied but still readable icons when they are generated entirely on the basis of the MUD name - in a reproducible (though Qt do NOT guarantee repeatable qHash() functionality across Qt versions - so they may not stay *that* constant) manner. Refrob: use a table of fixed colours Using only 15 hues but with 3 different saturation level plus 5 grey-scale one should give enough different icons but not generate them too close to each other for those with normal colour vision... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Kebap <kebap_spam@gmx.net>
2020-12-11 17:53:28 +00:00
{
QPixmap background(120, 30);
Add ability to define custom color in profile buttons in connection dialog (#5365)
2021-08-13 07:22:24 +02:00
Infrastructure: reposition const before type specifier (#7179) #### Brief overview of PR changes/additions This PR tries to put all `const`s before the type (class). #### Motivation for adding to Mudlet There is a mix of positioning of `const`s where it is used to indicate that a variable is not to be modified by program code, we tend to put it before the type but a prior PR (which looks to have been done with an automated tool) has resulted in a mix of cases some with the const adjacent to the variable. This lack of consistency can be confusing. #### Other info (issues closed, discussion etc) It looks like this came about in #6843. This will upset the Danger detector because of the number of files modified but it should be fairly straightforward to review. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2024-03-11 15:40:56 +00:00
const QColor color = backgroundColor.value_or(mCustomIconColors.at(static_cast<int>((qHash(text) * 8131) % mCustomIconColors.count())));
Add ability to define custom color in profile buttons in connection dialog (#5365)
2021-08-13 07:22:24 +02:00
background.fill(color);
Revise: select profiles by typing the name, keep profile icons (#4440) Restore the text display of the profile name. This is so that the keyboard selection of profiles beginning with a particular letter works again. This will close issue #4283 . This also sets it to the minimum size trying to hide it by setting the font size to 1 - however that still show something (and a font size of zero is NOT valid). Manipulating the QPalette of the QListWidget does not work well enough in the presence of Styles or StyleSheets to be a viable means of hiding the text either. Also in the `dlgConnection` class: * refactor out some highly repetitive code that sets up the predefined Mud icons. * remove warnings and adopts a change introduced into Qt 5.15 for the QLabel::pixmap() which now requires a Qt::ReturnByValue argument to prevent an obsolete code warning and to force a QPixmap to be returned by value and not reference... * remove a warning about: QListWidget::setItemSelected(QListWidgetItem*,bool) being deprecated and switches to the recommended: QListWidgetItem::setSelected(bool) Edit: the last item above may have become redundant as further commits amalgamated into this PR may have taken out these lines anyhow! Change the custom icon generator so that there is NOT a dependency on the position in the list for the colours used. This means that the same name will always have the same colours - which will help the user to pick out a particular profile as it will always look the same no matter if other profiles are added or removed. Remove the colour gradient in the custom icon as it is not thought to be useful nowadays. Refactor out the colour icon generator to a single method that is called from more than one place. BugFix: restore odd original way of accessing some QPixmaps This was causing failures in some CI platforms using Qt 5.14. or older. Revise: really frob the custom icon generator This is to try and produce as varied but still readable icons when they are generated entirely on the basis of the MUD name - in a reproducible (though Qt do NOT guarantee repeatable qHash() functionality across Qt versions - so they may not stay *that* constant) manner. Refrob: use a table of fixed colours Using only 15 hues but with 3 different saturation level plus 5 grey-scale one should give enough different icons but not generate them too close to each other for those with normal colour vision... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Kebap <kebap_spam@gmx.net>
2020-12-11 17:53:28 +00:00
// Set to one larger than wanted so that do loop can contain the decrementor
int fontSize = 30;
Infrastructure: Add short qsl macro to stand in for 'QStringLiteral' (#5640)
2021-12-07 06:21:39 +01:00
QFont font(qsl("Bitstream Vera Sans Mono"), fontSize, QFont::Normal);
Revise: select profiles by typing the name, keep profile icons (#4440) Restore the text display of the profile name. This is so that the keyboard selection of profiles beginning with a particular letter works again. This will close issue #4283 . This also sets it to the minimum size trying to hide it by setting the font size to 1 - however that still show something (and a font size of zero is NOT valid). Manipulating the QPalette of the QListWidget does not work well enough in the presence of Styles or StyleSheets to be a viable means of hiding the text either. Also in the `dlgConnection` class: * refactor out some highly repetitive code that sets up the predefined Mud icons. * remove warnings and adopts a change introduced into Qt 5.15 for the QLabel::pixmap() which now requires a Qt::ReturnByValue argument to prevent an obsolete code warning and to force a QPixmap to be returned by value and not reference... * remove a warning about: QListWidget::setItemSelected(QListWidgetItem*,bool) being deprecated and switches to the recommended: QListWidgetItem::setSelected(bool) Edit: the last item above may have become redundant as further commits amalgamated into this PR may have taken out these lines anyhow! Change the custom icon generator so that there is NOT a dependency on the position in the list for the colours used. This means that the same name will always have the same colours - which will help the user to pick out a particular profile as it will always look the same no matter if other profiles are added or removed. Remove the colour gradient in the custom icon as it is not thought to be useful nowadays. Refactor out the colour icon generator to a single method that is called from more than one place. BugFix: restore odd original way of accessing some QPixmaps This was causing failures in some CI platforms using Qt 5.14. or older. Revise: really frob the custom icon generator This is to try and produce as varied but still readable icons when they are generated entirely on the basis of the MUD name - in a reproducible (though Qt do NOT guarantee repeatable qHash() functionality across Qt versions - so they may not stay *that* constant) manner. Refrob: use a table of fixed colours Using only 15 hues but with 3 different saturation level plus 5 grey-scale one should give enough different icons but not generate them too close to each other for those with normal colour vision... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Kebap <kebap_spam@gmx.net>
2020-12-11 17:53:28 +00:00
// For an icon of size 120x30 allow 89x29 for the text:
Infrastructure: reposition const before type specifier (#7179) #### Brief overview of PR changes/additions This PR tries to put all `const`s before the type (class). #### Motivation for adding to Mudlet There is a mix of positioning of `const`s where it is used to indicate that a variable is not to be modified by program code, we tend to put it before the type but a prior PR (which looks to have been done with an automated tool) has resulted in a mix of cases some with the const adjacent to the variable. This lack of consistency can be confusing. #### Other info (issues closed, discussion etc) It looks like this came about in #6843. This will upset the Danger detector because of the number of files modified but it should be fairly straightforward to review. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2024-03-11 15:40:56 +00:00
const QRect textRectangle(0, 0, 89, 29);
Revise: select profiles by typing the name, keep profile icons (#4440) Restore the text display of the profile name. This is so that the keyboard selection of profiles beginning with a particular letter works again. This will close issue #4283 . This also sets it to the minimum size trying to hide it by setting the font size to 1 - however that still show something (and a font size of zero is NOT valid). Manipulating the QPalette of the QListWidget does not work well enough in the presence of Styles or StyleSheets to be a viable means of hiding the text either. Also in the `dlgConnection` class: * refactor out some highly repetitive code that sets up the predefined Mud icons. * remove warnings and adopts a change introduced into Qt 5.15 for the QLabel::pixmap() which now requires a Qt::ReturnByValue argument to prevent an obsolete code warning and to force a QPixmap to be returned by value and not reference... * remove a warning about: QListWidget::setItemSelected(QListWidgetItem*,bool) being deprecated and switches to the recommended: QListWidgetItem::setSelected(bool) Edit: the last item above may have become redundant as further commits amalgamated into this PR may have taken out these lines anyhow! Change the custom icon generator so that there is NOT a dependency on the position in the list for the colours used. This means that the same name will always have the same colours - which will help the user to pick out a particular profile as it will always look the same no matter if other profiles are added or removed. Remove the colour gradient in the custom icon as it is not thought to be useful nowadays. Refactor out the colour icon generator to a single method that is called from more than one place. BugFix: restore odd original way of accessing some QPixmaps This was causing failures in some CI platforms using Qt 5.14. or older. Revise: really frob the custom icon generator This is to try and produce as varied but still readable icons when they are generated entirely on the basis of the MUD name - in a reproducible (though Qt do NOT guarantee repeatable qHash() functionality across Qt versions - so they may not stay *that* constant) manner. Refrob: use a table of fixed colours Using only 15 hues but with 3 different saturation level plus 5 grey-scale one should give enough different icons but not generate them too close to each other for those with normal colour vision... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Kebap <kebap_spam@gmx.net>
2020-12-11 17:53:28 +00:00
QRect testRect;
// Really long names will be drawn very small (font size 6) with the ends clipped off:
do {
font.setPointSize(--fontSize);
Infrastructure: reposition const before type specifier (#7179) #### Brief overview of PR changes/additions This PR tries to put all `const`s before the type (class). #### Motivation for adding to Mudlet There is a mix of positioning of `const`s where it is used to indicate that a variable is not to be modified by program code, we tend to put it before the type but a prior PR (which looks to have been done with an automated tool) has resulted in a mix of cases some with the const adjacent to the variable. This lack of consistency can be confusing. #### Other info (issues closed, discussion etc) It looks like this came about in #6843. This will upset the Danger detector because of the number of files modified but it should be fairly straightforward to review. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2024-03-11 15:40:56 +00:00
const QFontMetrics metrics(font);
Infrastructure: improve too-short variable names A-H (#6745) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve names of variables that are too short and not meaningful #### Motivation for adding to Mudlet So developers have an easier time working with Mudlets code - it's crucial to be able to attract and retain folks working on the project for its success! #### Other info (issues closed, discussion etc)
2023-04-15 06:38:20 +02:00
testRect = metrics.boundingRect(textRectangle, Qt::AlignCenter | Qt::TextWordWrap, text);
Revise: select profiles by typing the name, keep profile icons (#4440) Restore the text display of the profile name. This is so that the keyboard selection of profiles beginning with a particular letter works again. This will close issue #4283 . This also sets it to the minimum size trying to hide it by setting the font size to 1 - however that still show something (and a font size of zero is NOT valid). Manipulating the QPalette of the QListWidget does not work well enough in the presence of Styles or StyleSheets to be a viable means of hiding the text either. Also in the `dlgConnection` class: * refactor out some highly repetitive code that sets up the predefined Mud icons. * remove warnings and adopts a change introduced into Qt 5.15 for the QLabel::pixmap() which now requires a Qt::ReturnByValue argument to prevent an obsolete code warning and to force a QPixmap to be returned by value and not reference... * remove a warning about: QListWidget::setItemSelected(QListWidgetItem*,bool) being deprecated and switches to the recommended: QListWidgetItem::setSelected(bool) Edit: the last item above may have become redundant as further commits amalgamated into this PR may have taken out these lines anyhow! Change the custom icon generator so that there is NOT a dependency on the position in the list for the colours used. This means that the same name will always have the same colours - which will help the user to pick out a particular profile as it will always look the same no matter if other profiles are added or removed. Remove the colour gradient in the custom icon as it is not thought to be useful nowadays. Refactor out the colour icon generator to a single method that is called from more than one place. BugFix: restore odd original way of accessing some QPixmaps This was causing failures in some CI platforms using Qt 5.14. or older. Revise: really frob the custom icon generator This is to try and produce as varied but still readable icons when they are generated entirely on the basis of the MUD name - in a reproducible (though Qt do NOT guarantee repeatable qHash() functionality across Qt versions - so they may not stay *that* constant) manner. Refrob: use a table of fixed colours Using only 15 hues but with 3 different saturation level plus 5 grey-scale one should give enough different icons but not generate them too close to each other for those with normal colour vision... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Kebap <kebap_spam@gmx.net>
2020-12-11 17:53:28 +00:00
} while (fontSize > 6 && !textRectangle.contains(testRect));
{ // Enclosed in braces to limit lifespan of QPainter:
Infrastructure: improve too-short variable names A-H (#6745) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve names of variables that are too short and not meaningful #### Motivation for adding to Mudlet So developers have an easier time working with Mudlets code - it's crucial to be able to attract and retain folks working on the project for its success! #### Other info (issues closed, discussion etc)
2023-04-15 06:38:20 +02:00
QPainter painter(&background);
painter.setCompositionMode(QPainter::CompositionMode_SourceOver);
Infrastructure: reposition const before type specifier (#7179) #### Brief overview of PR changes/additions This PR tries to put all `const`s before the type (class). #### Motivation for adding to Mudlet There is a mix of positioning of `const`s where it is used to indicate that a variable is not to be modified by program code, we tend to put it before the type but a prior PR (which looks to have been done with an automated tool) has resulted in a mix of cases some with the const adjacent to the variable. This lack of consistency can be confusing. #### Other info (issues closed, discussion etc) It looks like this came about in #6843. This will upset the Danger detector because of the number of files modified but it should be fairly straightforward to review. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2024-03-11 15:40:56 +00:00
const QPixmap pixmap(qsl(":/icons/mudlet_main_32px.png"));
Infrastructure: improve too-short variable names A-H (#6745) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve names of variables that are too short and not meaningful #### Motivation for adding to Mudlet So developers have an easier time working with Mudlets code - it's crucial to be able to attract and retain folks working on the project for its success! #### Other info (issues closed, discussion etc)
2023-04-15 06:38:20 +02:00
painter.drawPixmap(QRect(5, 5, 20, 20), pixmap);
Add ability to define custom color in profile buttons in connection dialog (#5365)
2021-08-13 07:22:24 +02:00
if (color.lightness() > 127) {
Infrastructure: improve too-short variable names A-H (#6745) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve names of variables that are too short and not meaningful #### Motivation for adding to Mudlet So developers have an easier time working with Mudlets code - it's crucial to be able to attract and retain folks working on the project for its success! #### Other info (issues closed, discussion etc)
2023-04-15 06:38:20 +02:00
painter.setPen(Qt::black);
Revise: select profiles by typing the name, keep profile icons (#4440) Restore the text display of the profile name. This is so that the keyboard selection of profiles beginning with a particular letter works again. This will close issue #4283 . This also sets it to the minimum size trying to hide it by setting the font size to 1 - however that still show something (and a font size of zero is NOT valid). Manipulating the QPalette of the QListWidget does not work well enough in the presence of Styles or StyleSheets to be a viable means of hiding the text either. Also in the `dlgConnection` class: * refactor out some highly repetitive code that sets up the predefined Mud icons. * remove warnings and adopts a change introduced into Qt 5.15 for the QLabel::pixmap() which now requires a Qt::ReturnByValue argument to prevent an obsolete code warning and to force a QPixmap to be returned by value and not reference... * remove a warning about: QListWidget::setItemSelected(QListWidgetItem*,bool) being deprecated and switches to the recommended: QListWidgetItem::setSelected(bool) Edit: the last item above may have become redundant as further commits amalgamated into this PR may have taken out these lines anyhow! Change the custom icon generator so that there is NOT a dependency on the position in the list for the colours used. This means that the same name will always have the same colours - which will help the user to pick out a particular profile as it will always look the same no matter if other profiles are added or removed. Remove the colour gradient in the custom icon as it is not thought to be useful nowadays. Refactor out the colour icon generator to a single method that is called from more than one place. BugFix: restore odd original way of accessing some QPixmaps This was causing failures in some CI platforms using Qt 5.14. or older. Revise: really frob the custom icon generator This is to try and produce as varied but still readable icons when they are generated entirely on the basis of the MUD name - in a reproducible (though Qt do NOT guarantee repeatable qHash() functionality across Qt versions - so they may not stay *that* constant) manner. Refrob: use a table of fixed colours Using only 15 hues but with 3 different saturation level plus 5 grey-scale one should give enough different icons but not generate them too close to each other for those with normal colour vision... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Kebap <kebap_spam@gmx.net>
2020-12-11 17:53:28 +00:00
} else {
Infrastructure: improve too-short variable names A-H (#6745) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve names of variables that are too short and not meaningful #### Motivation for adding to Mudlet So developers have an easier time working with Mudlets code - it's crucial to be able to attract and retain folks working on the project for its success! #### Other info (issues closed, discussion etc)
2023-04-15 06:38:20 +02:00
painter.setPen(Qt::white);
Revise: select profiles by typing the name, keep profile icons (#4440) Restore the text display of the profile name. This is so that the keyboard selection of profiles beginning with a particular letter works again. This will close issue #4283 . This also sets it to the minimum size trying to hide it by setting the font size to 1 - however that still show something (and a font size of zero is NOT valid). Manipulating the QPalette of the QListWidget does not work well enough in the presence of Styles or StyleSheets to be a viable means of hiding the text either. Also in the `dlgConnection` class: * refactor out some highly repetitive code that sets up the predefined Mud icons. * remove warnings and adopts a change introduced into Qt 5.15 for the QLabel::pixmap() which now requires a Qt::ReturnByValue argument to prevent an obsolete code warning and to force a QPixmap to be returned by value and not reference... * remove a warning about: QListWidget::setItemSelected(QListWidgetItem*,bool) being deprecated and switches to the recommended: QListWidgetItem::setSelected(bool) Edit: the last item above may have become redundant as further commits amalgamated into this PR may have taken out these lines anyhow! Change the custom icon generator so that there is NOT a dependency on the position in the list for the colours used. This means that the same name will always have the same colours - which will help the user to pick out a particular profile as it will always look the same no matter if other profiles are added or removed. Remove the colour gradient in the custom icon as it is not thought to be useful nowadays. Refactor out the colour icon generator to a single method that is called from more than one place. BugFix: restore odd original way of accessing some QPixmaps This was causing failures in some CI platforms using Qt 5.14. or older. Revise: really frob the custom icon generator This is to try and produce as varied but still readable icons when they are generated entirely on the basis of the MUD name - in a reproducible (though Qt do NOT guarantee repeatable qHash() functionality across Qt versions - so they may not stay *that* constant) manner. Refrob: use a table of fixed colours Using only 15 hues but with 3 different saturation level plus 5 grey-scale one should give enough different icons but not generate them too close to each other for those with normal colour vision... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Kebap <kebap_spam@gmx.net>
2020-12-11 17:53:28 +00:00
}
Infrastructure: improve too-short variable names A-H (#6745) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve names of variables that are too short and not meaningful #### Motivation for adding to Mudlet So developers have an easier time working with Mudlets code - it's crucial to be able to attract and retain folks working on the project for its success! #### Other info (issues closed, discussion etc)
2023-04-15 06:38:20 +02:00
painter.setFont(font);
painter.drawText(QRect(30, 0, 90, 30), Qt::AlignCenter | Qt::TextWordWrap, text);
Revise: select profiles by typing the name, keep profile icons (#4440) Restore the text display of the profile name. This is so that the keyboard selection of profiles beginning with a particular letter works again. This will close issue #4283 . This also sets it to the minimum size trying to hide it by setting the font size to 1 - however that still show something (and a font size of zero is NOT valid). Manipulating the QPalette of the QListWidget does not work well enough in the presence of Styles or StyleSheets to be a viable means of hiding the text either. Also in the `dlgConnection` class: * refactor out some highly repetitive code that sets up the predefined Mud icons. * remove warnings and adopts a change introduced into Qt 5.15 for the QLabel::pixmap() which now requires a Qt::ReturnByValue argument to prevent an obsolete code warning and to force a QPixmap to be returned by value and not reference... * remove a warning about: QListWidget::setItemSelected(QListWidgetItem*,bool) being deprecated and switches to the recommended: QListWidgetItem::setSelected(bool) Edit: the last item above may have become redundant as further commits amalgamated into this PR may have taken out these lines anyhow! Change the custom icon generator so that there is NOT a dependency on the position in the list for the colours used. This means that the same name will always have the same colours - which will help the user to pick out a particular profile as it will always look the same no matter if other profiles are added or removed. Remove the colour gradient in the custom icon as it is not thought to be useful nowadays. Refactor out the colour icon generator to a single method that is called from more than one place. BugFix: restore odd original way of accessing some QPixmaps This was causing failures in some CI platforms using Qt 5.14. or older. Revise: really frob the custom icon generator This is to try and produce as varied but still readable icons when they are generated entirely on the basis of the MUD name - in a reproducible (though Qt do NOT guarantee repeatable qHash() functionality across Qt versions - so they may not stay *that* constant) manner. Refrob: use a table of fixed colours Using only 15 hues but with 3 different saturation level plus 5 grey-scale one should give enough different icons but not generate them too close to each other for those with normal colour vision... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Kebap <kebap_spam@gmx.net>
2020-12-11 17:53:28 +00:00
}
return QIcon(background);
}
Enhance: remove minuscule text from under profile icons (#4712) This finally enables us to do away with the text under the profile icons as it replicates the normal `QListWidget` behaviour to move the selection to each item which begins with the first letter of the key pressed. This also makes the non-matching profiles get disabled which I think makes the action more obvious... Revised to include a timeout on concatenating keypresses: This is to provide the same functionality that the QListWidget does for keypresses, if the keys are typed fast enough they are concatenated to form the text to search for. However if the user types slower than this then the individual keys are only considered on their own. This reflects what both Vadim and I experienced - in that he was typing fast enough to spell out a particular profile but I wasn't and so the profile that I was having selected was changing on each keypress. The time between keypresses allowed so that they can be concatenated I have set to be 1 second. This is significantly slower that the Qt code but it is long enough to permit the temporary disablement of non-matching profiles to be a useful visual feedback - and besides, it makes it easier to specify one of a number of profiles with a common initial text - the longer the timeout the more keys the user can string together! Add `std::chrono` so we can give a time delay as `1s` instead of `1000` mS. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2021-02-03 19:59:35 +00:00
void dlgConnectionProfiles::clearNotificationArea()
{
notificationArea->hide();
notificationAreaIconLabelWarning->hide();
notificationAreaIconLabelError->hide();
notificationAreaIconLabelInformation->hide();
notificationAreaMessageBox->clear();
}
void dlgConnectionProfiles::slot_reenableAllProfileItems()
{
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
for (int i = 0, total = listWidget_profiles->count(); i < total; ++i) {
listWidget_profiles->item(i)->setFlags(listWidget_profiles->item(i)->flags() | Qt::ItemIsEnabled);
Enhance: remove minuscule text from under profile icons (#4712) This finally enables us to do away with the text under the profile icons as it replicates the normal `QListWidget` behaviour to move the selection to each item which begins with the first letter of the key pressed. This also makes the non-matching profiles get disabled which I think makes the action more obvious... Revised to include a timeout on concatenating keypresses: This is to provide the same functionality that the QListWidget does for keypresses, if the keys are typed fast enough they are concatenated to form the text to search for. However if the user types slower than this then the individual keys are only considered on their own. This reflects what both Vadim and I experienced - in that he was typing fast enough to spell out a particular profile but I wasn't and so the profile that I was having selected was changing on each keypress. The time between keypresses allowed so that they can be concatenated I have set to be 1 second. This is significantly slower that the Qt code but it is long enough to permit the temporary disablement of non-matching profiles to be a useful visual feedback - and besides, it makes it easier to specify one of a number of profiles with a common initial text - the longer the timeout the more keys the user can string together! Add `std::chrono` so we can give a time delay as `1s` instead of `1000` mS. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2021-02-03 19:59:35 +00:00
}
}
bool dlgConnectionProfiles::eventFilter(QObject* obj, QEvent* event)
{
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
if (obj == listWidget_profiles && event->type() == QEvent::KeyPress) {
Enhance: remove minuscule text from under profile icons (#4712) This finally enables us to do away with the text under the profile icons as it replicates the normal `QListWidget` behaviour to move the selection to each item which begins with the first letter of the key pressed. This also makes the non-matching profiles get disabled which I think makes the action more obvious... Revised to include a timeout on concatenating keypresses: This is to provide the same functionality that the QListWidget does for keypresses, if the keys are typed fast enough they are concatenated to form the text to search for. However if the user types slower than this then the individual keys are only considered on their own. This reflects what both Vadim and I experienced - in that he was typing fast enough to spell out a particular profile but I wasn't and so the profile that I was having selected was changing on each keypress. The time between keypresses allowed so that they can be concatenated I have set to be 1 second. This is significantly slower that the Qt code but it is long enough to permit the temporary disablement of non-matching profiles to be a useful visual feedback - and besides, it makes it easier to specify one of a number of profiles with a common initial text - the longer the timeout the more keys the user can string together! Add `std::chrono` so we can give a time delay as `1s` instead of `1000` mS. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2021-02-03 19:59:35 +00:00
QKeyEvent* keyEvent = static_cast<QKeyEvent*>(event);
switch (keyEvent->key()) {
fix: profiles with parentheses in their name can be opened again (#9610) #### Brief overview of PR changes/additions - Parentheses are now allowed in profile names, matching the "name (2)" folders file managers create when copying - Selecting a profile folder made outside Mudlet no longer silently mangles its name and renames the folder on disk - Adds ProfileNameValidationTest for the name validation rules and ProfileFolderNameTest, which drives the real connection dialog against externally-created folders (fails without the fix) #### Motivation for adding to Mudlet Merely selecting a profile folder like "test (2)" mangled its name to "test 2" and silently renamed the folder on disk, and the reporter could not launch the profile at all. #### Other info (issues closed, discussion etc) Assisted-by: Claude:claude-fable-5 Assisted-by: Claude:claude-opus-5 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org> **Test case:** Copy a profile folder to "test (2)" while Mudlet is closed, reopen - the profile keeps its name, Connect/Offline are enabled, and it opens. #### Demo https://github.com/user-attachments/assets/25b1bb4c-eaa7-4079-8b8e-a12de3ebb215
2026-08-04 16:09:42 +02:00
// Process all the keys that could be used in a profile name,
// i.e. the "scmAllowedProfileNameChars" list
Enhance: remove minuscule text from under profile icons (#4712) This finally enables us to do away with the text under the profile icons as it replicates the normal `QListWidget` behaviour to move the selection to each item which begins with the first letter of the key pressed. This also makes the non-matching profiles get disabled which I think makes the action more obvious... Revised to include a timeout on concatenating keypresses: This is to provide the same functionality that the QListWidget does for keypresses, if the keys are typed fast enough they are concatenated to form the text to search for. However if the user types slower than this then the individual keys are only considered on their own. This reflects what both Vadim and I experienced - in that he was typing fast enough to spell out a particular profile but I wasn't and so the profile that I was having selected was changing on each keypress. The time between keypresses allowed so that they can be concatenated I have set to be 1 second. This is significantly slower that the Qt code but it is long enough to permit the temporary disablement of non-matching profiles to be a useful visual feedback - and besides, it makes it easier to specify one of a number of profiles with a common initial text - the longer the timeout the more keys the user can string together! Add `std::chrono` so we can give a time delay as `1s` instead of `1000` mS. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2021-02-03 19:59:35 +00:00
default:
// For other keys handle them as normal:
return QObject::eventFilter(obj, event);
case Qt::Key_Escape:
// Clear the search:
mSearchText.clear();
slot_reenableAllProfileItems();
// Eat (filter) this event so it goes no further:
return true;
case Qt::Key_Period:
case Qt::Key_Space:
case Qt::Key_Underscore:
case Qt::Key_0:
case Qt::Key_1:
case Qt::Key_2:
case Qt::Key_3:
case Qt::Key_4:
case Qt::Key_5:
case Qt::Key_6:
case Qt::Key_7:
case Qt::Key_8:
case Qt::Key_9:
case Qt::Key_Minus:
case Qt::Key_NumberSign:
case Qt::Key_Ampersand:
fix: profiles with parentheses in their name can be opened again (#9610) #### Brief overview of PR changes/additions - Parentheses are now allowed in profile names, matching the "name (2)" folders file managers create when copying - Selecting a profile folder made outside Mudlet no longer silently mangles its name and renames the folder on disk - Adds ProfileNameValidationTest for the name validation rules and ProfileFolderNameTest, which drives the real connection dialog against externally-created folders (fails without the fix) #### Motivation for adding to Mudlet Merely selecting a profile folder like "test (2)" mangled its name to "test 2" and silently renamed the folder on disk, and the reporter could not launch the profile at all. #### Other info (issues closed, discussion etc) Assisted-by: Claude:claude-fable-5 Assisted-by: Claude:claude-opus-5 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org> **Test case:** Copy a profile folder to "test (2)" while Mudlet is closed, reopen - the profile keeps its name, Connect/Offline are enabled, and it opens. #### Demo https://github.com/user-attachments/assets/25b1bb4c-eaa7-4079-8b8e-a12de3ebb215
2026-08-04 16:09:42 +02:00
case Qt::Key_ParenLeft:
case Qt::Key_ParenRight:
Enhance: remove minuscule text from under profile icons (#4712) This finally enables us to do away with the text under the profile icons as it replicates the normal `QListWidget` behaviour to move the selection to each item which begins with the first letter of the key pressed. This also makes the non-matching profiles get disabled which I think makes the action more obvious... Revised to include a timeout on concatenating keypresses: This is to provide the same functionality that the QListWidget does for keypresses, if the keys are typed fast enough they are concatenated to form the text to search for. However if the user types slower than this then the individual keys are only considered on their own. This reflects what both Vadim and I experienced - in that he was typing fast enough to spell out a particular profile but I wasn't and so the profile that I was having selected was changing on each keypress. The time between keypresses allowed so that they can be concatenated I have set to be 1 second. This is significantly slower that the Qt code but it is long enough to permit the temporary disablement of non-matching profiles to be a useful visual feedback - and besides, it makes it easier to specify one of a number of profiles with a common initial text - the longer the timeout the more keys the user can string together! Add `std::chrono` so we can give a time delay as `1s` instead of `1000` mS. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2021-02-03 19:59:35 +00:00
case Qt::Key_A:
case Qt::Key_B:
case Qt::Key_C:
case Qt::Key_D:
case Qt::Key_E:
case Qt::Key_F:
case Qt::Key_G:
case Qt::Key_H:
case Qt::Key_I:
case Qt::Key_J:
case Qt::Key_K:
case Qt::Key_L:
case Qt::Key_M:
case Qt::Key_N:
case Qt::Key_O:
case Qt::Key_P:
case Qt::Key_Q:
case Qt::Key_R:
case Qt::Key_S:
case Qt::Key_T:
case Qt::Key_U:
case Qt::Key_V:
case Qt::Key_W:
case Qt::Key_X:
case Qt::Key_Y:
case Qt::Key_Z:
if (keyEvent->modifiers() & ~(Qt::ShiftModifier)) {
// There is a modifier in play OTHER than the shift one so treat
// it as normal:
return QObject::eventFilter(obj, event);
}
if (!mSearchTextTimer.isActive()) {
// Too long since the last keypress so forget any previously
// entered keypresses:
mSearchText.clear();
}
mSearchTextTimer.stop();
addLetterToProfileSearch(keyEvent->key());
// Restart the timeout for another keypress:
mSearchTextTimer.start();
// Eat (filter) this event so it goes no further:
return true;
}
}
// standard event processing
return QObject::eventFilter(obj, event);
}
void dlgConnectionProfiles::addLetterToProfileSearch(const int key)
{
if ((key < 0) || (key > 128)) {
// out of range of normal ASCII keys
return;
}
// As it happens the values for key correspond to those of the corresponding
// ASCII (upper-case for letters) character codes
mSearchText.append(QLatin1Char(static_cast<unsigned char>(key)));
auto indexes = findProfilesBeginningWith(mSearchText);
if (indexes.isEmpty()) {
// No matches at all so clearing search term and reset all profiles to
// be enabled:
mSearchText.clear();
slot_reenableAllProfileItems();
return;
}
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
for (int i = 0, total = listWidget_profiles->count(); i < total; ++i) {
auto flags = listWidget_profiles->item(i)->flags();
Enhance: remove minuscule text from under profile icons (#4712) This finally enables us to do away with the text under the profile icons as it replicates the normal `QListWidget` behaviour to move the selection to each item which begins with the first letter of the key pressed. This also makes the non-matching profiles get disabled which I think makes the action more obvious... Revised to include a timeout on concatenating keypresses: This is to provide the same functionality that the QListWidget does for keypresses, if the keys are typed fast enough they are concatenated to form the text to search for. However if the user types slower than this then the individual keys are only considered on their own. This reflects what both Vadim and I experienced - in that he was typing fast enough to spell out a particular profile but I wasn't and so the profile that I was having selected was changing on each keypress. The time between keypresses allowed so that they can be concatenated I have set to be 1 second. This is significantly slower that the Qt code but it is long enough to permit the temporary disablement of non-matching profiles to be a useful visual feedback - and besides, it makes it easier to specify one of a number of profiles with a common initial text - the longer the timeout the more keys the user can string together! Add `std::chrono` so we can give a time delay as `1s` instead of `1000` mS. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2021-02-03 19:59:35 +00:00
if (indexes.isEmpty() || !indexes.contains(i)) {
flags &= ~Qt::ItemIsEnabled;
} else {
flags |= Qt::ItemIsEnabled;
}
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
listWidget_profiles->item(i)->setFlags(flags);
Enhance: remove minuscule text from under profile icons (#4712) This finally enables us to do away with the text under the profile icons as it replicates the normal `QListWidget` behaviour to move the selection to each item which begins with the first letter of the key pressed. This also makes the non-matching profiles get disabled which I think makes the action more obvious... Revised to include a timeout on concatenating keypresses: This is to provide the same functionality that the QListWidget does for keypresses, if the keys are typed fast enough they are concatenated to form the text to search for. However if the user types slower than this then the individual keys are only considered on their own. This reflects what both Vadim and I experienced - in that he was typing fast enough to spell out a particular profile but I wasn't and so the profile that I was having selected was changing on each keypress. The time between keypresses allowed so that they can be concatenated I have set to be 1 second. This is significantly slower that the Qt code but it is long enough to permit the temporary disablement of non-matching profiles to be a useful visual feedback - and besides, it makes it easier to specify one of a number of profiles with a common initial text - the longer the timeout the more keys the user can string together! Add `std::chrono` so we can give a time delay as `1s` instead of `1000` mS. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2021-02-03 19:59:35 +00:00
}
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
listWidget_profiles->setCurrentRow(indexes.first());
Enhance: remove minuscule text from under profile icons (#4712) This finally enables us to do away with the text under the profile icons as it replicates the normal `QListWidget` behaviour to move the selection to each item which begins with the first letter of the key pressed. This also makes the non-matching profiles get disabled which I think makes the action more obvious... Revised to include a timeout on concatenating keypresses: This is to provide the same functionality that the QListWidget does for keypresses, if the keys are typed fast enough they are concatenated to form the text to search for. However if the user types slower than this then the individual keys are only considered on their own. This reflects what both Vadim and I experienced - in that he was typing fast enough to spell out a particular profile but I wasn't and so the profile that I was having selected was changing on each keypress. The time between keypresses allowed so that they can be concatenated I have set to be 1 second. This is significantly slower that the Qt code but it is long enough to permit the temporary disablement of non-matching profiles to be a useful visual feedback - and besides, it makes it easier to specify one of a number of profiles with a common initial text - the longer the timeout the more keys the user can string together! Add `std::chrono` so we can give a time delay as `1s` instead of `1000` mS. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
2021-02-03 19:59:35 +00:00
}
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
void dlgConnectionProfiles::slot_loadPasswordAsync()
{
if (!sender()) {
return;
}
// Get the profile name from the timer's property
QTimer* timer = qobject_cast<QTimer*>(sender());
if (!timer) {
return;
}
const QString profile_name = timer->property("profileName").toString();
Fix: prevent password loss in PTBs and improve credential debug messages (#8257) #### Brief overview of PR changes/additions - Fixed a bug where users lost their saved passwords when switching between different Mudlet versions - Added safety checks to prevent password deletion unless you're using a newer version (4.20.0+) - Made error messages clearer and more helpful when password loading fails - Improved the system's ability to find passwords stored in different locations - Added better logging to help diagnose password-related issues #### Motivation for adding to Mudlet Users reported that their saved passwords disappeared after trying development versions of Mudlet. This happened because the system was automatically cleaning up old password storage without considering that users might switch back to older versions. The unclear error messages also made it difficult to understand what was happening when passwords couldn't be loaded. #### Other info (issues closed, discussion etc) This fix ensures users can safely test different Mudlet versions without losing their saved passwords. It also makes password-related problems easier to understand and troubleshoot, while maintaining compatibility with all existing Mudlet installations. --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-09-24 07:28:15 -04:00
// Prevent duplicate password loading operations for the same profile
if (mKeychainOperationInProgress) {
return;
}
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
if (profile_name.isEmpty()) {
return;
}
// Clean up the timer
timer->deleteLater();
// Check if this dialog is still valid and the profile is still selected
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
if (listWidget_profiles->currentItem() == nullptr) {
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
return;
}
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
const QString currentProfileName = listWidget_profiles->currentItem()->data(csmNameRole).toString();
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
if (currentProfileName != profile_name) {
// Selection has changed, ignore this async load
return;
}
// If secure storage is enabled, try keychain first, then fallback to QSettings
if (mudlet::self()->storingPasswordsSecurely()) {
mKeychainOperationInProgress = true;
auto* credManager = new CredentialManager(this);
credManager->retrievePassword(profile_name, "character", [this, credManager, profile_name](bool success, const QString& retrievedPassword, const QString& errorMessage) {
// Clear the operation flag first
mKeychainOperationInProgress = false;
infrastructure: Apply clang-format to all CPP files (#8804) #### Brief overview of PR changes/additions Ran clang-format on all 134 CPP files in src/ using the project's .clang-format config #### Motivation for adding to Mudlet Ensures consistent code formatting across the codebase. #### Other info (issues closed, discussion etc) None **Test case:** Build the project and verify it compiles successfully.
2026-01-19 18:10:44 +01:00
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
// Check if profile selection has changed while we were waiting
Improve widget naming in connection profile window (#8217) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Improve widget naming in connection profile window for developers so they are more specific. #### Motivation for adding to Mudlet Happy devs. #### Other info (issues closed, discussion etc) closes #6039
2025-09-19 13:12:41 +07:00
if (listWidget_profiles->currentItem() && listWidget_profiles->currentItem()->data(csmNameRole).toString() == profile_name) {
Fix: Changing one profile's password no longer affects others (#9049) #### Brief overview of PR changes/additions Fixes an issue where changing the password for one profile would overwrite the passwords of other profiles. This primarily affected Windows users due to how the system credential storage works differently from macOS and Linux. #### Motivation for adding to Mudlet Users reported that setting a password on one profile caused all other profiles to use that same password. This made it impossible to have different passwords for different game connections. The fix ensures each profile's password is stored separately on all platforms. #### Other info (issues closed, discussion etc) Closes #9006
2026-03-18 12:15:40 -04:00
if (success) {
// Keychain operation succeeded - set the password (even if empty)
// Temporarily block textChanged signal to avoid triggering save on programmatic setText
Fix: prevent password loss in PTBs and improve credential debug messages (#8257) #### Brief overview of PR changes/additions - Fixed a bug where users lost their saved passwords when switching between different Mudlet versions - Added safety checks to prevent password deletion unless you're using a newer version (4.20.0+) - Made error messages clearer and more helpful when password loading fails - Improved the system's ability to find passwords stored in different locations - Added better logging to help diagnose password-related issues #### Motivation for adding to Mudlet Users reported that their saved passwords disappeared after trying development versions of Mudlet. This happened because the system was automatically cleaning up old password storage without considering that users might switch back to older versions. The unclear error messages also made it difficult to understand what was happening when passwords couldn't be loaded. #### Other info (issues closed, discussion etc) This fix ensures users can safely test different Mudlet versions without losing their saved passwords. It also makes password-related problems easier to understand and troubleshoot, while maintaining compatibility with all existing Mudlet installations. --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-09-24 07:28:15 -04:00
{
const QSignalBlocker blocker(character_password_entry);
character_password_entry->setText(retrievedPassword);
}
Fix: Changing one profile's password no longer affects others (#9049) #### Brief overview of PR changes/additions Fixes an issue where changing the password for one profile would overwrite the passwords of other profiles. This primarily affected Windows users due to how the system credential storage works differently from macOS and Linux. #### Motivation for adding to Mudlet Users reported that setting a password on one profile caused all other profiles to use that same password. This made it impossible to have different passwords for different game connections. The fix ensures each profile's password is stored separately on all platforms. #### Other info (issues closed, discussion etc) Closes #9006
2026-03-18 12:15:40 -04:00
if (retrievedPassword.isEmpty()) {
qDebug() << "dlgConnectionProfiles: Keychain returned empty password for" << profile_name;
Fix: Restore password loading from portable file in connection dialog (#8993) #### Brief overview of PR changes/additions Restores the ability for the connection dialog to load saved passwords from the portable password file on disk, which stopped working after PR #7956 introduced secure credential management. #### Motivation for adding to Mudlet After #7956, users who had passwords saved in the old portable file format (`~/.config/mudlet/profiles/<name>/password`) could no longer see their passwords pre-filled when selecting a profile in the connection dialog. This affected users who had not yet migrated to the system keychain. The fix ensures all three password sources are checked in order: system keychain, QSettings, and finally the portable file on disk. It also moves the password migration step to run before the connection dialog opens, so passwords are migrated in time to be found. Includes the profile password collision fix from #8948 and adds new unit tests for the password migration and fallback paths. #### Other info (issues closed, discussion etc) Reported by @SlySven — PR #7956 (commit 79ab7be4) broke password loading for profiles that only had passwords in the portable file. --------- Co-authored-by: Stephen Lyons <slysven@virginmedia.com>
2026-03-08 09:38:15 -04:00
} else {
Fix: Changing one profile's password no longer affects others (#9049) #### Brief overview of PR changes/additions Fixes an issue where changing the password for one profile would overwrite the passwords of other profiles. This primarily affected Windows users due to how the system credential storage works differently from macOS and Linux. #### Motivation for adding to Mudlet Users reported that setting a password on one profile caused all other profiles to use that same password. This made it impossible to have different passwords for different game connections. The fix ensures each profile's password is stored separately on all platforms. #### Other info (issues closed, discussion etc) Closes #9006
2026-03-18 12:15:40 -04:00
qDebug() << "dlgConnectionProfiles: Successfully loaded password from keychain for" << profile_name;
Fix: Restore password loading from portable file in connection dialog (#8993) #### Brief overview of PR changes/additions Restores the ability for the connection dialog to load saved passwords from the portable password file on disk, which stopped working after PR #7956 introduced secure credential management. #### Motivation for adding to Mudlet After #7956, users who had passwords saved in the old portable file format (`~/.config/mudlet/profiles/<name>/password`) could no longer see their passwords pre-filled when selecting a profile in the connection dialog. This affected users who had not yet migrated to the system keychain. The fix ensures all three password sources are checked in order: system keychain, QSettings, and finally the portable file on disk. It also moves the password migration step to run before the connection dialog opens, so passwords are migrated in time to be found. Includes the profile password collision fix from #8948 and adds new unit tests for the password migration and fallback paths. #### Other info (issues closed, discussion etc) Reported by @SlySven — PR #7956 (commit 79ab7be4) broke password loading for profiles that only had passwords in the portable file. --------- Co-authored-by: Stephen Lyons <slysven@virginmedia.com>
2026-03-08 09:38:15 -04:00
}
Fix: Changing one profile's password no longer affects others (#9049) #### Brief overview of PR changes/additions Fixes an issue where changing the password for one profile would overwrite the passwords of other profiles. This primarily affected Windows users due to how the system credential storage works differently from macOS and Linux. #### Motivation for adding to Mudlet Users reported that setting a password on one profile caused all other profiles to use that same password. This made it impossible to have different passwords for different game connections. The fix ensures each profile's password is stored separately on all platforms. #### Other info (issues closed, discussion etc) Closes #9006
2026-03-18 12:15:40 -04:00
} else {
// Fallback to QSettings only if credential retrieval failed
loadPasswordFromSettings(profile_name);
qDebug() << "dlgConnectionProfiles: Credential retrieval unsuccessful for" << profile_name << "-" << errorMessage;
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
}
infrastructure: Apply clang-format to all CPP files (#8804) #### Brief overview of PR changes/additions Ran clang-format on all 134 CPP files in src/ using the project's .clang-format config #### Motivation for adding to Mudlet Ensures consistent code formatting across the codebase. #### Other info (issues closed, discussion etc) None **Test case:** Build the project and verify it compiles successfully.
2026-01-19 18:10:44 +01:00
}
Add a Mudlet Tutorial profile. (#8188) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Adds a Mudlet Tutorial profile which incorporates a basic GUI tutorial and mini-mud quest. GUI tutorial introduces the main window, command line, search bar, toolbar, map. Mini-quest attempts to act like a MUD. Teaches directional commands and some typical verbs (look, buy, give, get, open, close, quit) while the player wanders around trying to figure out the two 'quests' (buy the sheriff some lunch and find the librarian's lost ring). It is simplistic and more designed to show players how a mud 'feels and progresses' when playing rather than a full blown MUD school which most (all?) MUDs incorporate. #### Motivation for adding to Mudlet Help on-boarding new users. Destination 5.0. /claim #3072 helps #2823 #### Other info (issues closed, discussion etc) I purposefully left out triggers, scripting and all that stuff veteran players take for granted! This is supposed to be an on-boarding tutorial for NEW players, let's not overwhelm them. A link after successful completion of the game introduces the wiki Introduction page for more advanced topics. That said, any improvements or basic features you think are missing from either the GUI or Mud tutorials, let me know and I can add. https://github.com/user-attachments/assets/1d16db50-e24b-4e78-b6b0-66e0e98a0772
2025-09-13 14:17:13 +07:00
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
// Check if there's a pending connection waiting for this password load
// (do this regardless of profile selection state to avoid hanging)
if (!mPendingProfileLoad.isEmpty() && mPendingProfileLoad == profile_name) {
qDebug() << "dlgConnectionProfiles: Password load completed, proceeding with pending connection for" << profile_name;
Add a Mudlet Tutorial profile. (#8188) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Adds a Mudlet Tutorial profile which incorporates a basic GUI tutorial and mini-mud quest. GUI tutorial introduces the main window, command line, search bar, toolbar, map. Mini-quest attempts to act like a MUD. Teaches directional commands and some typical verbs (look, buy, give, get, open, close, quit) while the player wanders around trying to figure out the two 'quests' (buy the sheriff some lunch and find the librarian's lost ring). It is simplistic and more designed to show players how a mud 'feels and progresses' when playing rather than a full blown MUD school which most (all?) MUDs incorporate. #### Motivation for adding to Mudlet Help on-boarding new users. Destination 5.0. /claim #3072 helps #2823 #### Other info (issues closed, discussion etc) I purposefully left out triggers, scripting and all that stuff veteran players take for granted! This is supposed to be an on-boarding tutorial for NEW players, let's not overwhelm them. A link after successful completion of the game introduces the wiki Introduction page for more advanced topics. That said, any improvements or basic features you think are missing from either the GUI or Mud tutorials, let me know and I can add. https://github.com/user-attachments/assets/1d16db50-e24b-4e78-b6b0-66e0e98a0772
2025-09-13 14:17:13 +07:00
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
// Clear pending state
QString profileToLoad = mPendingProfileLoad;
bool shouldConnect = mPendingConnect;
mPendingProfileLoad.clear();
Add a Mudlet Tutorial profile. (#8188) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Adds a Mudlet Tutorial profile which incorporates a basic GUI tutorial and mini-mud quest. GUI tutorial introduces the main window, command line, search bar, toolbar, map. Mini-quest attempts to act like a MUD. Teaches directional commands and some typical verbs (look, buy, give, get, open, close, quit) while the player wanders around trying to figure out the two 'quests' (buy the sheriff some lunch and find the librarian's lost ring). It is simplistic and more designed to show players how a mud 'feels and progresses' when playing rather than a full blown MUD school which most (all?) MUDs incorporate. #### Motivation for adding to Mudlet Help on-boarding new users. Destination 5.0. /claim #3072 helps #2823 #### Other info (issues closed, discussion etc) I purposefully left out triggers, scripting and all that stuff veteran players take for granted! This is supposed to be an on-boarding tutorial for NEW players, let's not overwhelm them. A link after successful completion of the game introduces the wiki Introduction page for more advanced topics. That said, any improvements or basic features you think are missing from either the GUI or Mud tutorials, let me know and I can add. https://github.com/user-attachments/assets/1d16db50-e24b-4e78-b6b0-66e0e98a0772
2025-09-13 14:17:13 +07:00
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
// Proceed with the connection
loadProfile(shouldConnect);
QDialog::accept();
}
Add a Mudlet Tutorial profile. (#8188) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Adds a Mudlet Tutorial profile which incorporates a basic GUI tutorial and mini-mud quest. GUI tutorial introduces the main window, command line, search bar, toolbar, map. Mini-quest attempts to act like a MUD. Teaches directional commands and some typical verbs (look, buy, give, get, open, close, quit) while the player wanders around trying to figure out the two 'quests' (buy the sheriff some lunch and find the librarian's lost ring). It is simplistic and more designed to show players how a mud 'feels and progresses' when playing rather than a full blown MUD school which most (all?) MUDs incorporate. #### Motivation for adding to Mudlet Help on-boarding new users. Destination 5.0. /claim #3072 helps #2823 #### Other info (issues closed, discussion etc) I purposefully left out triggers, scripting and all that stuff veteran players take for granted! This is supposed to be an on-boarding tutorial for NEW players, let's not overwhelm them. A link after successful completion of the game introduces the wiki Introduction page for more advanced topics. That said, any improvements or basic features you think are missing from either the GUI or Mud tutorials, let me know and I can add. https://github.com/user-attachments/assets/1d16db50-e24b-4e78-b6b0-66e0e98a0772
2025-09-13 14:17:13 +07:00
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
credManager->deleteLater();
});
} else {
// Secure storage disabled, use QSettings directly
loadPasswordFromSettings(profile_name);
Add a Mudlet Tutorial profile. (#8188) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Adds a Mudlet Tutorial profile which incorporates a basic GUI tutorial and mini-mud quest. GUI tutorial introduces the main window, command line, search bar, toolbar, map. Mini-quest attempts to act like a MUD. Teaches directional commands and some typical verbs (look, buy, give, get, open, close, quit) while the player wanders around trying to figure out the two 'quests' (buy the sheriff some lunch and find the librarian's lost ring). It is simplistic and more designed to show players how a mud 'feels and progresses' when playing rather than a full blown MUD school which most (all?) MUDs incorporate. #### Motivation for adding to Mudlet Help on-boarding new users. Destination 5.0. /claim #3072 helps #2823 #### Other info (issues closed, discussion etc) I purposefully left out triggers, scripting and all that stuff veteran players take for granted! This is supposed to be an on-boarding tutorial for NEW players, let's not overwhelm them. A link after successful completion of the game introduces the wiki Introduction page for more advanced topics. That said, any improvements or basic features you think are missing from either the GUI or Mud tutorials, let me know and I can add. https://github.com/user-attachments/assets/1d16db50-e24b-4e78-b6b0-66e0e98a0772
2025-09-13 14:17:13 +07:00
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
// Check if there's a pending connection waiting
if (!mPendingProfileLoad.isEmpty() && mPendingProfileLoad == profile_name) {
qDebug() << "dlgConnectionProfiles: Password loaded from settings, proceeding with pending connection for" << profile_name;
Add a Mudlet Tutorial profile. (#8188) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Adds a Mudlet Tutorial profile which incorporates a basic GUI tutorial and mini-mud quest. GUI tutorial introduces the main window, command line, search bar, toolbar, map. Mini-quest attempts to act like a MUD. Teaches directional commands and some typical verbs (look, buy, give, get, open, close, quit) while the player wanders around trying to figure out the two 'quests' (buy the sheriff some lunch and find the librarian's lost ring). It is simplistic and more designed to show players how a mud 'feels and progresses' when playing rather than a full blown MUD school which most (all?) MUDs incorporate. #### Motivation for adding to Mudlet Help on-boarding new users. Destination 5.0. /claim #3072 helps #2823 #### Other info (issues closed, discussion etc) I purposefully left out triggers, scripting and all that stuff veteran players take for granted! This is supposed to be an on-boarding tutorial for NEW players, let's not overwhelm them. A link after successful completion of the game introduces the wiki Introduction page for more advanced topics. That said, any improvements or basic features you think are missing from either the GUI or Mud tutorials, let me know and I can add. https://github.com/user-attachments/assets/1d16db50-e24b-4e78-b6b0-66e0e98a0772
2025-09-13 14:17:13 +07:00
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
// Clear pending state
QString profileToLoad = mPendingProfileLoad;
bool shouldConnect = mPendingConnect;
mPendingProfileLoad.clear();
Add a Mudlet Tutorial profile. (#8188) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Adds a Mudlet Tutorial profile which incorporates a basic GUI tutorial and mini-mud quest. GUI tutorial introduces the main window, command line, search bar, toolbar, map. Mini-quest attempts to act like a MUD. Teaches directional commands and some typical verbs (look, buy, give, get, open, close, quit) while the player wanders around trying to figure out the two 'quests' (buy the sheriff some lunch and find the librarian's lost ring). It is simplistic and more designed to show players how a mud 'feels and progresses' when playing rather than a full blown MUD school which most (all?) MUDs incorporate. #### Motivation for adding to Mudlet Help on-boarding new users. Destination 5.0. /claim #3072 helps #2823 #### Other info (issues closed, discussion etc) I purposefully left out triggers, scripting and all that stuff veteran players take for granted! This is supposed to be an on-boarding tutorial for NEW players, let's not overwhelm them. A link after successful completion of the game introduces the wiki Introduction page for more advanced topics. That said, any improvements or basic features you think are missing from either the GUI or Mud tutorials, let me know and I can add. https://github.com/user-attachments/assets/1d16db50-e24b-4e78-b6b0-66e0e98a0772
2025-09-13 14:17:13 +07:00
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
// Proceed with the connection
loadProfile(shouldConnect);
QDialog::accept();
}
}
}
void dlgConnectionProfiles::loadPasswordFromSettings(const QString& profile_name)
{
auto& settings = *mudlet::self()->mpSettings;
settings.beginGroup(qsl("profiles/%1").arg(profile_name));
// Get password and handle migration
const QString password = settings.value(qsl("password"), QString()).toString();
const QString oldPassword = settings.value(qsl("login"), QString()).toString();
Fix: prevent password loss in PTBs and improve credential debug messages (#8257) #### Brief overview of PR changes/additions - Fixed a bug where users lost their saved passwords when switching between different Mudlet versions - Added safety checks to prevent password deletion unless you're using a newer version (4.20.0+) - Made error messages clearer and more helpful when password loading fails - Improved the system's ability to find passwords stored in different locations - Added better logging to help diagnose password-related issues #### Motivation for adding to Mudlet Users reported that their saved passwords disappeared after trying development versions of Mudlet. This happened because the system was automatically cleaning up old password storage without considering that users might switch back to older versions. The unclear error messages also made it difficult to understand what was happening when passwords couldn't be loaded. #### Other info (issues closed, discussion etc) This fix ensures users can safely test different Mudlet versions without losing their saved passwords. It also makes password-related problems easier to understand and troubleshoot, while maintaining compatibility with all existing Mudlet installations. --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-09-24 07:28:15 -04:00
// Temporarily block textChanged signal to avoid triggering save on programmatic setText
{
const QSignalBlocker blocker(character_password_entry);
Infrastructure: remove MSVC leak detection (#8378) <!-- Keep the title short & concise so anyone non-technical can understand it, the title appears in PTB changelogs --> #### Brief overview of PR changes/additions Remove support for leak detection using MSVC - this functionality hasn't been in use in a decade, and we're switching to to using [LeakSanitizer](https://github.com/google/sanitizers/wiki/AddressSanitizerLeakSanitizer) instead. #### Motivation for adding to Mudlet Cleaner code. #### Other info (issues closed, discussion etc) --------- Co-authored-by: Claude <noreply@anthropic.com>
2025-10-21 15:11:09 +01:00
Fix: prevent password loss in PTBs and improve credential debug messages (#8257) #### Brief overview of PR changes/additions - Fixed a bug where users lost their saved passwords when switching between different Mudlet versions - Added safety checks to prevent password deletion unless you're using a newer version (4.20.0+) - Made error messages clearer and more helpful when password loading fails - Improved the system's ability to find passwords stored in different locations - Added better logging to help diagnose password-related issues #### Motivation for adding to Mudlet Users reported that their saved passwords disappeared after trying development versions of Mudlet. This happened because the system was automatically cleaning up old password storage without considering that users might switch back to older versions. The unclear error messages also made it difficult to understand what was happening when passwords couldn't be loaded. #### Other info (issues closed, discussion etc) This fix ensures users can safely test different Mudlet versions without losing their saved passwords. It also makes password-related problems easier to understand and troubleshoot, while maintaining compatibility with all existing Mudlet installations. --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-09-24 07:28:15 -04:00
if (!password.isEmpty()) {
character_password_entry->setText(password);
} else if (!oldPassword.isEmpty()) {
// Migrate old password
character_password_entry->setText(oldPassword);
settings.setValue(qsl("password"), oldPassword);
settings.remove(qsl("login"));
} else {
Fix: Changing one profile's password no longer affects others (#9049) #### Brief overview of PR changes/additions Fixes an issue where changing the password for one profile would overwrite the passwords of other profiles. This primarily affected Windows users due to how the system credential storage works differently from macOS and Linux. #### Motivation for adding to Mudlet Users reported that setting a password on one profile caused all other profiles to use that same password. This made it impossible to have different passwords for different game connections. The fix ensures each profile's password is stored separately on all platforms. #### Other info (issues closed, discussion etc) Closes #9006
2026-03-18 12:15:40 -04:00
character_password_entry->setText(QString());
Fix: prevent password loss in PTBs and improve credential debug messages (#8257) #### Brief overview of PR changes/additions - Fixed a bug where users lost their saved passwords when switching between different Mudlet versions - Added safety checks to prevent password deletion unless you're using a newer version (4.20.0+) - Made error messages clearer and more helpful when password loading fails - Improved the system's ability to find passwords stored in different locations - Added better logging to help diagnose password-related issues #### Motivation for adding to Mudlet Users reported that their saved passwords disappeared after trying development versions of Mudlet. This happened because the system was automatically cleaning up old password storage without considering that users might switch back to older versions. The unclear error messages also made it difficult to understand what was happening when passwords couldn't be loaded. #### Other info (issues closed, discussion etc) This fix ensures users can safely test different Mudlet versions without losing their saved passwords. It also makes password-related problems easier to understand and troubleshoot, while maintaining compatibility with all existing Mudlet installations. --------- Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>
2025-09-24 07:28:15 -04:00
}
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
}
settings.endGroup();
}
void dlgConnectionProfiles::slot_passwordTextChanged()
{
Fix: Restore password loading from portable file in connection dialog (#8993) #### Brief overview of PR changes/additions Restores the ability for the connection dialog to load saved passwords from the portable password file on disk, which stopped working after PR #7956 introduced secure credential management. #### Motivation for adding to Mudlet After #7956, users who had passwords saved in the old portable file format (`~/.config/mudlet/profiles/<name>/password`) could no longer see their passwords pre-filled when selecting a profile in the connection dialog. This affected users who had not yet migrated to the system keychain. The fix ensures all three password sources are checked in order: system keychain, QSettings, and finally the portable file on disk. It also moves the password migration step to run before the connection dialog opens, so passwords are migrated in time to be found. Includes the profile password collision fix from #8948 and adds new unit tests for the password migration and fallback paths. #### Other info (issues closed, discussion etc) Reported by @SlySven — PR #7956 (commit 79ab7be4) broke password loading for profiles that only had passwords in the portable file. --------- Co-authored-by: Stephen Lyons <slysven@virginmedia.com>
2026-03-08 09:38:15 -04:00
QListWidgetItem* pItem = listWidget_profiles->currentItem();
if (!pItem) {
return;
}
mPendingPasswordSaveProfile = pItem->data(csmNameRole).toString();
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
// Cancel any pending password save
if (mPasswordSaveTimer) {
mPasswordSaveTimer->stop();
} else {
mPasswordSaveTimer = new QTimer(this);
mPasswordSaveTimer->setSingleShot(true);
infrastructure: use std::chrono literals for time durations (#9493) #### Brief overview of PR changes/additions Convert raw millisecond integer literals at time-duration call sites to `std::chrono` literals, and add `#include <chrono>` to each touched translation unit. Examples: - `QTimer::singleShot(0, ...)` → `QTimer::singleShot(0ms, ...)` - `mpTimerReplay->setInterval(1000)` → `setInterval(1s)` - `mPendingTimer.start(60000)` → `start(1min)` - `QObject::startTimer(50)` → `startTimer(50ms)` - `QTest::qWait(100)` → `QTest::qWait(100ms)` - `QThread::msleep(10)` → `QThread::sleep(10ms)` This is a semantics-preserving refactor - every duration is kept exactly equal to before (e.g. `1000` ms becomes `1s`, `60000` ms becomes `1min`). No behavioural change. #### Motivation for adding to Mudlet Chrono literals make time durations self-documenting and type-safe. `1s` / `100ms` read unambiguously where a bare `1000` / `100` forces the reader to remember each API's unit, and the compiler now rejects unit mismatches. Only genuine duration arguments were converted - loop counts, scroll-line counts, sizes, ports and the like were deliberately left as plain integers. All targeted APIs provide `std::chrono` overloads in the minimum supported Qt (6.8.2): `QTimer::singleShot`/`start`/`setInterval` (5.8), `QObject::startTimer` (5.9), `QThread::sleep(std::chrono::nanoseconds)` (6.6) and `QTest::qWait(std::chrono::milliseconds)` (6.7). #### Other info (issues closed, discussion etc) Test case: the full application builds cleanly and the entire functional `ctest` suite passes. The only failing test is the known, pre-existing `PasswordMigrationTest` LSan exit-leak (GTK3/fontconfig noise), which is unrelated to this change. Assisted-by: Claude:claude-opus-4-8
2026-07-25 20:24:31 +02:00
mPasswordSaveTimer->setInterval(500ms); // 500ms debounce
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
connect(mPasswordSaveTimer, &QTimer::timeout, this, [this]() {
Fix: Restore password loading from portable file in connection dialog (#8993) #### Brief overview of PR changes/additions Restores the ability for the connection dialog to load saved passwords from the portable password file on disk, which stopped working after PR #7956 introduced secure credential management. #### Motivation for adding to Mudlet After #7956, users who had passwords saved in the old portable file format (`~/.config/mudlet/profiles/<name>/password`) could no longer see their passwords pre-filled when selecting a profile in the connection dialog. This affected users who had not yet migrated to the system keychain. The fix ensures all three password sources are checked in order: system keychain, QSettings, and finally the portable file on disk. It also moves the password migration step to run before the connection dialog opens, so passwords are migrated in time to be found. Includes the profile password collision fix from #8948 and adds new unit tests for the password migration and fallback paths. #### Other info (issues closed, discussion etc) Reported by @SlySven — PR #7956 (commit 79ab7be4) broke password loading for profiles that only had passwords in the portable file. --------- Co-authored-by: Stephen Lyons <slysven@virginmedia.com>
2026-03-08 09:38:15 -04:00
if (!mPendingPasswordSaveProfile.isEmpty()) {
// Check if this profile is STILL selected - if not, don't save
// (user switched away, so the password field content is for a different profile)
QListWidgetItem* currentItem = listWidget_profiles->currentItem();
if (currentItem && currentItem->data(csmNameRole).toString() == mPendingPasswordSaveProfile) {
slot_updatePassword(character_password_entry->text());
}
Improve: Secure credential management with system keychain integration and legacy migration (#7956) #### Brief overview of PR changes/additions This pull request implements secure credential management for Mudlet with system keychain integration and encrypted fallback storage: **Core Components:** - **CredentialManager**: High-level API for secure credential storage with QtKeychain integration - **SecureStringUtils**: Qt-based cryptographic utilities for encrypted file storage - **Legacy Migration**: Automatic detection and migration of existing plaintext passwords **Key Features:** - **System Keychain Integration**: Primary storage in macOS Keychain, Windows Credential Store, and Linux Secret Service via QtKeychain - **Encrypted File Fallback**: Qt crypto-based AES encryption for portable mode and keychain unavailability - **Seamless Migration**: Automatic detection and upgrade of legacy password storage formats - **Profile Isolation**: Per-profile encryption keys prevent cross-profile credential access - **Portable Mode Support**: Automatic detection and secure file-based storage for portable installations #### Motivation for adding to Mudlet **Security Enhancement:** - Eliminates plaintext password storage in profile XML files - Provides industry-standard system keychain integration for credential security - Implements authenticated encryption for fallback scenarios **User Experience:** - Zero configuration required - works automatically across all platforms - Seamless migration from existing plaintext passwords to secure storage - Native system integration provides familiar credential management experience **Future-Proofing:** - Extensible architecture supports additional credential types (API keys, tokens, etc.) - Robust fallback ensures functionality in all deployment scenarios - Prepares foundation for OAuth and external service integrations #### Other info (issues closed, discussion etc) **Security Architecture:** - **Keychain-First Strategy**: Prefers system keychain with automatic encrypted file fallback - **Legacy Format Detection**: Automatically migrates passwords from development branch keychain format - **Memory Security**: Secure string clearing and controlled credential lifecycle management - **Input Validation**: Path traversal protection and service name sanitization **Implementation Highlights:** - **Async Operations**: Non-blocking keychain operations with timeout protection - **Thread Safety**: Event-driven architecture prevents UI blocking and race conditions - **Comprehensive Testing**: Full test coverage for encryption, migration, and fallback scenarios - **Cross-Platform**: Unified API across Windows, macOS, and Linux with platform-specific optimizations **Version Compatibility & Migration:** - **Mudlet 4.19.x Compatibility**: Preserves existing plaintext password storage to ensure compatibility when switching between 4.19.x stable and development builds - **Mudlet 4.20.x Migration**: Post-4.20.0 release, automatic migration begins converting plaintext passwords to secure storage - **Bidirectional Safety**: Users can safely run both 4.19.x and development versions without losing access to their passwords during the transition period - **Legacy Format Support**: Automatically detects and migrates passwords from the original development branch keychain format (`service="Mudlet profile"`) to the new secure format # Credential Management Workflows ## 1. Credential Storage Strategy ```mermaid flowchart TD A[Store Password Request] --> B{Portable Mode?} B -->|Yes| C[Encrypt & Store in Profile File] B -->|No| D[Store in System Keychain] D --> E{Keychain Success?} E -->|Yes| F[Remove Encrypted Fallback File] E -->|No| G[Fallback to Encrypted File] F --> H[Success] G --> I{Encryption Success?} I -->|Yes| H I -->|No| J[Failure] C --> I classDef primary fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef decision fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef result fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class D,F primary class C,G fallback class B,E,I decision class H,J result ``` ## 2. Legacy Migration Workflow ```mermaid flowchart TD A[Retrieve Password Request] --> B[Try New Keychain Format] B --> C{Password Found?} C -->|Yes| D[Return Password] C -->|No| E[Check Legacy Keychain Format] E --> F{Legacy Found?} F -->|Yes| G[Migrate to New Format] G --> H[Store in New Format] H --> I[Remove Legacy Entry] I --> J[Return Migrated Password] F -->|No| K[Try Encrypted File] K --> L{File Found?} L -->|Yes| M[Decrypt & Return] L -->|No| N[Return Empty - No Password Stored] classDef newformat fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef legacy fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef migration fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff classDef fallback fill:#607D8B,stroke:#263238,stroke-width:2px,color:#fff classDef result fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff class B,H newformat class E,I legacy class G migration class K fallback class D,J,M,N result ``` ## 3. Cross-Platform Keychain Integration ```mermaid flowchart TD A[QtKeychain Request] --> B{Platform Detection} B -->|macOS| C[Access Keychain Services] B -->|Windows| D[Access Credential Store] B -->|Linux| E[Access Secret Service] C --> F[Store/Retrieve Credential] D --> F E --> F F --> G{Operation Success?} G -->|Yes| H[Return Result] G -->|No| I[Log Error & Fallback] I --> J[Use Encrypted File Storage] J --> K[AES Encryption with Profile Key] K --> L[Store in Profile Directory] classDef platform fill:#2196F3,stroke:#0D47A1,stroke-width:2px,color:#fff classDef keychain fill:#4CAF50,stroke:#2E7D32,stroke-width:2px,color:#000 classDef fallback fill:#FF9800,stroke:#E65100,stroke-width:2px,color:#000 classDef crypto fill:#9C27B0,stroke:#4A148C,stroke-width:2px,color:#fff class C,D,E platform class F,H keychain class I,J fallback class K,L crypto ``` This implementation provides a comprehensive, secure, and user-friendly credential management system that seamlessly upgrades existing Mudlet installations while providing robust security for future credential storage needs. --------- Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
2025-08-17 06:44:38 -04:00
}
});
}
mPasswordSaveTimer->start();
}
Reference in a new issue Copy permalink