mirror of
https://github.com/sven-n/MuMain
synced 2026-08-15 20:32:27 -04:00
2f7e1bfa20
Completes the sweep of docs/GPU Skinning/. Two documents had real errors, one was
clean, and the index contradicted the architecture doc it links to.
core-profile-migration.md -- same IR drift as the architecture doc:
- "decomposes into INDEXED triangle lists" and "IR::End() appends two triangles"
/ "IR::End() generates N-2 triangles". Decomposition moved into Vertex3f()
(GLP-29 2a) and the draw is non-indexed. Added a fourth ring-buffer bullet for
GLP-19's deferred submission, since End() issuing no GL call at all is the
single most surprising thing about this subsystem.
- Orphan-on-wrap predated GLP-25's growth policy.
- GL 3.3 is now the floor, not the target -- GLP-08 walks {4,5}/{4,3}/{3,3}.
- RHI::ReadDepthPixel was described as "used by CameraProjection::TestDepthBuffer",
which reads as live. It is dead: TestDepthBuffer's only caller is RenderSun(),
which has zero call sites. The glperf catalog already recorded this; the
migration guide contradicted it. A one-pixel glReadPixels is a full pipeline
sync, so a reader could reasonably go hunting for a stall that cannot happen --
re-verified 2026-08-12 while doing exactly that.
dxp-milestones.md -- substantially clean, and correctly so: it is an explicitly
historical chronology, which does not rot the way current-state prose does. Its
DXP-26 entry ("removed redundant per-draw shader program unbinding") was in fact
RIGHT where immediate-renderer-architecture.md was wrong. Added a note making the
historical-vs-current split explicit, pointing at the architecture documents for
present behaviour, plus a forward link to the GLP series that succeeded it.
README.md (index) -- two factual errors:
- "Skeletal Bones (Slot 1)". Bones are slot 2; slot 1 is SceneData. This
contradicted gpu-skinning-architecture.md, which the same index links to.
Corrected and extended with the vec4[600] layout and BMDFlags (slot 6).
- Pointed readers at bmd_mesh.vert as the skinning shader. That file is not
runtime-loaded and lacks normal/chrome skinning entirely; sending a reader
there is how the wrong conclusion gets drawn. Now names the authoritative
embedded source.
- Documented [Render] MaxGLVersion, absent since GLP-08 added it.
Docs only; no code change.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
||
|---|---|---|
| .. | ||
| build | ||
| GPU Skinning | ||
| camera-system.md | ||
| CODING_RULES.md | ||
| dev-editor.md | ||
| options-window.md | ||
| translation-system.md | ||