Commit graph

9 commits

Author SHA1 Message Date
Eduardo
f5acacec82 fix trivial warnings from build 2026-06-11 16:50:37 -03:00
copilot-swe-agent[bot]
280e681976 Add test for ComposableAttribute with maximum value
- Verify fix works for both StatAttribute and ComposableAttribute
- All 38 tests pass

Co-authored-by: sven-n <5238610+sven-n@users.noreply.github.com>
2025-11-21 14:46:36 +00:00
copilot-swe-agent[bot]
ff935f3144 Fix typo in comment (acreated -> created)
Co-authored-by: sven-n <5238610+sven-n@users.noreply.github.com>
2025-11-21 14:45:22 +00:00
copilot-swe-agent[bot]
18730729b7 Fix: Use actual AttributeDefinition from stored attribute for MaximumValue check
- Modified GetValueOfAttribute to use the actual definition from the stored attribute
- Added test to verify maximum value is respected from stored definition
- All 37 tests pass

Co-authored-by: sven-n <5238610+sven-n@users.noreply.github.com>
2025-11-21 14:44:02 +00:00
sven-n
c0ad16c96b Extensions of the Attribute System
Made it possible to use another attribute as operand, instead of a constant float value. This will make some calculations easier, e.g. we can use it for conditional bonuses. Example: Give a bonus only if an item with a specific attribute is equipped. This comes up in a lot of master skills, e.g. a damage bonus only when wearing a two-handed sword.
2022-11-06 15:57:44 +01:00
sven-n
db15dea508
Code improvements with C#10 features (#230)
The most changes are obviously by usage of the global using and file namespace features.
Additionally, because I was in a flow, I changed all private field names to start with an underscore.
2021-11-13 13:21:31 +01:00
sven-n
de311c5688 simplified code with new object creation style 2021-07-15 21:49:30 +02:00
sven-n
2f6c302631 AttributeSystem got nullabled 2020-12-13 13:13:21 +01:00
sven-n
a1b07df0d1 inital commit 2017-11-23 07:11:25 +01:00